cron job: media_tree daily build: ERRORS

2014-09-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Sep 13 04:00:26 CEST 2014 git branch: test git hash: f5281fc81e9a0a3e80b78720c5ae2ed06da3bfae gcc versi

Re: v4l2 ioctls

2014-09-12 Thread Shuah Khan
Mauro/Hans, Thanks for both for your replies. I finally have it working with the following: S_INPUT S_OUTPUT S_MODULATOR S_TUNER S_STD S_FREQUENCY S_HW_FREQ_SEEK S_FMT - get tuner in shared mode and hold it - i.e return with tuner held STREAMON - get tuner in shared mode and hold it - i.e re

v4l2_fops - poll and open

2014-09-12 Thread Shuah Khan
Mauro/Hans, It turns out au0828 driver does init tuner from its v4l2_fops read and poll. If an analog app comes in and does a read or poll, digital could get disrupted. Do you recommend adding token access to these?? -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Si

Re: [RFCv2 PATCH 09/14] vb2: replace 'write' by 'dma_dir'

2014-09-12 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 12 September 2014 14:59:58 Hans Verkuil wrote: > From: Hans Verkuil > > The 'write' argument is very ambiguous. I first assumed that if it is 1, > then we're doing video output but instead it meant the reverse. > > Since it is used to setup the dma_d

Re: [RFCv2 PATCH 03/14] vb2-dma-sg: add prepare/finish memops

2014-09-12 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 12 September 2014 14:59:52 Hans Verkuil wrote: > From: Hans Verkuil > > This moves dma_(un)map_sg to the prepare/finish memops of > videobuf2-dma-sg.c. > > Now that vb2-dma-sg will sync the buffers for you in the prepare/finish > memops we can drop t

Re: [RFCv2 PATCH 02/14] vb2-dma-sg: add allocation context to dma-sg

2014-09-12 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 12 September 2014 14:59:51 Hans Verkuil wrote: > From: Hans Verkuil > > Require that dma-sg also uses an allocation context. This is in preparation > for adding prepare/finish memops to sync the memory between DMA and CPU. > > Signed-off-by: Hans Verk

Re: [RFCv2 PATCH 01/14] vb2: introduce buf_prepare/finish_for_cpu

2014-09-12 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 12 September 2014 14:59:50 Hans Verkuil wrote: > From: Hans Verkuil > > This splits the buf_prepare and buf_finish actions into two: one > called while the cpu can still access the buffer contents, and one where > the memory has been prepared for DMA

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-12 Thread Bryan Wu
On Fri, Sep 5, 2014 at 2:03 PM, Bryan Wu wrote: > On Wed, Aug 20, 2014 at 6:41 AM, Jacek Anaszewski > wrote: >> led_update_brightness helper function used to be exploited only locally >> in the led-class.c module, where its result was being passed to the >> brightness_show sysfs callback. With th

Re: [PATCH v2] [media] v4l2-common: fix overflow in v4l_bound_align_image()

2014-09-12 Thread Greg KH
On Fri, Sep 12, 2014 at 06:11:49PM +0200, Maciej Matraszek wrote: > On Wed, 2014-09-10 at 10:10 -0700, Greg KH wrote: > > > Fixes: b0d3159be9a3 ("V4L/DVB (11901): v4l2: Create helper function for > > > bounding and aligning images") > > > Signed-off-by: Maciej Matraszek > > > Acked-by: Sakari Ail

Re: [PATCH v2] [media] v4l2-common: fix overflow in v4l_bound_align_image()

2014-09-12 Thread Maciej Matraszek
On Wed, 2014-09-10 at 10:10 -0700, Greg KH wrote: > > Fixes: b0d3159be9a3 ("V4L/DVB (11901): v4l2: Create helper function for > > bounding and aligning images") > > Signed-off-by: Maciej Matraszek > > Acked-by: Sakari Ailus > > > > --- > > > > This is not the correct way to submit patches fo

Re: v4l2 ioctls

2014-09-12 Thread Mauro Carvalho Chehab
Hi Shuah, See my comments below. Regards, Mauro Em Fri, 12 Sep 2014 10:07:55 +0200 Hans Verkuil escreveu: > On 09/12/2014 03:26 AM, Shuah Khan wrote: > > Hi Mauro/Hans, > > > > I am working on adding sharing construct to dvb-core and v4l2-core. > > In the case of dvb I have clean start and st

[RFCv2 PATCH 08/14] vb2-vmalloc: add get_dmabuf support

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil Add support for DMABUF exporting to the vb2-vmalloc implementation. All memory models now have support for both importing and exporting of DMABUFs. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-vmalloc.c | 174 1 file changed

[RFCv2 PATCH 12/14] cx23885: only reprogram DMA engine when necessary

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil Use the new 'new_cookies' flag to determine when the risc program needs to be regenerated. Signed-off-by: Hans Verkuil --- drivers/media/pci/cx23885/cx23885-417.c | 4 ++-- drivers/media/pci/cx23885/cx23885-core.c | 7 ++- drivers/media/pci/cx23885/cx23885-dvb.c | 4

[RFCv2 PATCH 06/14] vb2-dma-sg: add dmabuf import support

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil Add support for dmabuf to vb2-dma-sg. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 125 +++-- 1 file changed, 118 insertions(+), 7 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v

[RFCv2 PATCH 14/14] vivid: enable vb2_expbuf support.

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil Now that vb2 supports DMABUF export for dma-sg and vmalloc memory modes, we can enable the vb2_expbuf support in vivid. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivid/vivid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media

[RFCv2 PATCH 05/14] vb2: call memop prepare before the buf_prepare op is called

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil The prepare memop now returns an error, so we need to be able to handle that. In addition, prepare has to be called before buf_prepare since in the dma-sg case buf_prepare expects that the dma memory is mapped and it can use the sg_table. So call the prepare memop before calli

[RFCv2 PATCH 10/14] vb2: add 'new_cookies' flag

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil This flag helps drivers that need to reprogram their DMA engine whenever a plane cookie (== DMA address or DMA scatter-gather list) changes. Otherwise they would have to reprogram the DMA engine for every frame. Note that it is not possible to do this in buf_init() since dma_

[RFCv2 PATCH 02/14] vb2-dma-sg: add allocation context to dma-sg

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil Require that dma-sg also uses an allocation context. This is in preparation for adding prepare/finish memops to sync the memory between DMA and CPU. Signed-off-by: Hans Verkuil --- drivers/media/pci/cx23885/cx23885-417.c | 1 + drivers/media/pci/cx23885/cx23885-core

[RFCv2 PATCH 07/14] vb2-dma-sg: add get_dmabuf

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil Add DMABUF export support to vb2-dma-sg. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 170 + 1 file changed, 170 insertions(+) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2-core/vide

[RFCv2 PATCH 03/14] vb2-dma-sg: add prepare/finish memops

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil This moves dma_(un)map_sg to the prepare/finish memops of videobuf2-dma-sg.c. Now that vb2-dma-sg will sync the buffers for you in the prepare/finish memops we can drop that from the drivers that use dma-sg. For the solo6x10 driver that was a bit more involved because it need

[RFCv2 PATCH 09/14] vb2: replace 'write' by 'dma_dir'

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil The 'write' argument is very ambiguous. I first assumed that if it is 1, then we're doing video output but instead it meant the reverse. Since it is used to setup the dma_dir value anyway it is now replaced by the correct dma_dir value which is unambiguous. Signed-off-by: Han

[RFCv2 PATCH 01/14] vb2: introduce buf_prepare/finish_for_cpu

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil This splits the buf_prepare and buf_finish actions into two: one called while the cpu can still access the buffer contents, and one where the memory has been prepared for DMA and the cpu no longer can access it. Update a few drivers that use buf_finish where they really meant

[RFCv2 PATCH 04/14] vb2: memop prepare: return errors

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil For vb2-dma-sg the dma_map_sg function can return an error. This means that the prepare memop also needs to change so an error can be returned. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 5 +++-- drivers/media/v4l2-core/videobuf2-dma-sg.

[RFCv2 PATCH 13/14] saa7134: don't rebuild the page table unless new_cookies is set.

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil Only if new_cookies is set do you need to build the page table, otherwise it will be unchanged. Signed-off-by: Hans Verkuil --- drivers/media/pci/saa7134/saa7134-ts.c| 2 ++ drivers/media/pci/saa7134/saa7134-vbi.c | 2 ++ drivers/media/pci/saa7134/saa7134-video.c | 2 +

[RFCv2 PATCH 11/14] tw68: only reprogram DMA engine when necessary

2014-09-12 Thread Hans Verkuil
From: Hans Verkuil Use the new 'new_cookies' flag to determine when the risc program needs to be regenerated. Signed-off-by: Hans Verkuil --- drivers/media/pci/tw68/tw68-video.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/tw68/tw68-video.c

[RFCv2 PATCH 00/14] vb2: improve dma-sg, expbuf

2014-09-12 Thread Hans Verkuil
Changes since v1: - Updated commit logs of patches 1 and 3. - Added patches for tw68 and cx23885. The patch series adds an allocation context to dma-sg and uses that to move dma_(un)map_sg into the vb2 framework, which is where it belongs. Related to that is the addition of buf_prepare/finish _f

[PATCH for v3.17] adv7604: fix inverted condition

2014-09-12 Thread Hans Verkuil
The log_status function should show HDMI information, but the test checking for an HDMI input was inverted. Fix this. Signed-off-by: Hans Verkuil Cc: sta...@vger.kernel.org # for v3.12 and up diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index d4fa213..de88b98 10064

Re: [PATCH] v4l: videobuf2: Fix typos in comments

2014-09-12 Thread Sakari Ailus
Laurent Pinchart wrote: > The buffer flags are incorrectly referred to as V4L2_BUF_FLAGS_* instead > of V4L2_BUF_FLAG_* in comments. Fix it. > > Signed-off-by: Laurent Pinchart Thanks! Acked-by: Sakari Ailus -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line

Re: v4l2 ioctls

2014-09-12 Thread Hans Verkuil
On 09/12/2014 03:26 AM, Shuah Khan wrote: > Hi Mauro/Hans, > > I am working on adding sharing construct to dvb-core and v4l2-core. > In the case of dvb I have clean start and stop points to acquire the > tuner and release it. Tuner is acquired from dvb_frontend_start() and > released from dvb_fron