Confidential

2014-10-22 Thread Brian Joffe
Confidential Business.doc Description: MS-Word document

Re: [PATCH 2/2] adv7604: Add support for i2c_new_secondary_device

2014-10-22 Thread Jean-Michel Hautbois
Hi Laurent, Thank you for reviewing, 2014-10-23 1:44 GMT+02:00 Laurent Pinchart : > Hi Jean-Michel, > > Thank you for the patch. > > On Wednesday 22 October 2014 17:30:48 Jean-Michel Hautbois wrote: >> The ADV7604 has thirteen 256-byte maps that can be accessed via the main >> I²C ports. Each map

Re: [PATCH 1/2] i2c: Add generic support passing secondary devices addresses

2014-10-22 Thread Jean-Michel Hautbois
Hi Laurent, Thank you for your review, 2014-10-23 1:37 GMT+02:00 Laurent Pinchart : > Hi Jean-Michel, > > Thank you for the patch. > > On Wednesday 22 October 2014 17:30:47 Jean-Michel Hautbois wrote: >> Some I2C devices have multiple addresses assigned, for example each address >> corresponding

Re: [PATCH] adv7604: Add DT parsing support

2014-10-22 Thread Jean-Michel Hautbois
Hi Laurent, Thank you for reviewing, 2014-10-23 1:53 GMT+02:00 Laurent Pinchart : > Hi Jean-Michel, > > Thank you for the patch. > > On Wednesday 22 October 2014 17:34:21 Jean-Michel Hautbois wrote: >> This patch adds support for DT parsing of ADV7604 as well as ADV7611. >> It needs to be improve

cron job: media_tree daily build: WARNINGS

2014-10-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Oct 23 04:00:16 CEST 2014 git branch: test git hash: 1ef24960ab78554fe7e8e77d8fc86524fbd60d3c gcc versi

Re: [PATCH] adv7604: Add DT parsing support

2014-10-22 Thread Laurent Pinchart
Hi Jean-Michel, Thank you for the patch. On Wednesday 22 October 2014 17:34:21 Jean-Michel Hautbois wrote: > This patch adds support for DT parsing of ADV7604 as well as ADV7611. > It needs to be improved in order to get ports parsing too. Let's improve it then :-) The DT bindings as proposed by

Re: [PATCH 2/2] adv7604: Add support for i2c_new_secondary_device

2014-10-22 Thread Laurent Pinchart
Hi Jean-Michel, Thank you for the patch. On Wednesday 22 October 2014 17:30:48 Jean-Michel Hautbois wrote: > The ADV7604 has thirteen 256-byte maps that can be accessed via the main > I²C ports. Each map has it own I²C address and acts > as a standard slave device on the I²C bus. > > If nothing

Re: [PATCH 1/2] i2c: Add generic support passing secondary devices addresses

2014-10-22 Thread Laurent Pinchart
Hi Jean-Michel, Thank you for the patch. On Wednesday 22 October 2014 17:30:47 Jean-Michel Hautbois wrote: > Some I2C devices have multiple addresses assigned, for example each address > corresponding to a different internal register map page of the device. > So far drivers which need support for

Re: [PATCH 10/15] media: davinci: vpbe: add support for VIDIOC_CREATE_BUFS

2014-10-22 Thread Prabhakar Lad
Hi Hans, On Wed, Oct 22, 2014 at 12:26 PM, Hans Verkuil wrote: > Hi Prabhakar, > > This patch series looks good, except for this one. > > If you add create_bufs support, then you should also update queue_setup. > > If the fmt argument to queue_setup is non-NULL, then check that the > fmt.pix.size

[PATCH v2] media: davinci: vpbe: add support for VIDIOC_CREATE_BUFS

2014-10-22 Thread Lad, Prabhakar
this patch adds support for vidioc_create_bufs. Along side remove unneeded member numbuffers. Signed-off-by: Lad, Prabhakar --- Changes for v2: a: return -EINVAL in queue_setup() callback if sizeimage is less then current format size. b: removed unneeded member numbuffers. drivers/media

Re: [PATCH/RFC v2 2/4] Add media device related data structures and API.

2014-10-22 Thread Laurent Pinchart
Hi Sakari, On Wednesday 22 October 2014 13:03:02 Sakari Ailus wrote: > On Fri, Oct 17, 2014 at 04:54:40PM +0200, Jacek Anaszewski wrote: > ... > > > +/* > > + * struct media_entity - media device entity data > > + * @id:media entity id within media controller > > + * @name:

Re: [REVIEW] Submitting Media Patches

2014-10-22 Thread Mauro Carvalho Chehab
Hi Hans, Thanks for doing that! I added a few comments below. Regards, Mauro Em Wed, 22 Oct 2014 16:12:27 +0200 Hans Verkuil escreveu: > During the mini-summit it was decided that we should put up a document on how > to post/handle patches etc. for the media drivers in the wiki. I had such a

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-22 Thread Devin Heitmueller
> this seems like a feature, not a bug. PulseAudio starts streaming before > clients push any data and likewise keeps sources active even after for some > time after clients stop recording. Closing VLC in your example doesn't > immediately close the ALSA device. look for module-suspend-on-idle in y

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-22 Thread Pierre-Louis Bossart
On 10/21/14, 11:08 AM, Devin Heitmueller wrote: Sorry, I'm not convinced by that. If the device has to be controlled exclusively, the right position is the open/close. Otherwise, the program cannot know when it becomes inaccessible out of sudden during its operation. I can say that I've defin

[PATCH] s5p-mfc: correct the formats info for encoder

2014-10-22 Thread ayaka
The NV12M is supported by all the version of MFC, so it is better to use it as default OUTPUT format. MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is not supported either. Signed-off-by: ayaka --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++--- 1 file changed, 2 inse

[PATCH] s5p-mfc: correct the formats info for encoder

2014-10-22 Thread ayaka
I am very sorry to forget the Sign-off again and thank you for reviewing. ayaka (1): s5p-mfc: correct the formats info for encoder drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 1.9.3 -- To unsubscribe from this list: send the line

Re: linux-next: Tree for Oct 22 (media/usb/dvb-usb/az6027)

2014-10-22 Thread Randy Dunlap
On 10/21/14 20:42, Stephen Rothwell wrote: > Hi all, > > Changes since 20141021: > on x86_64: when MEDIA_SUBDRV_AUTOSELECT is not enabled: when DVB_USB_AZ6027=y and DVB_STB0899=m and DVB_STB6100=m: drivers/built-in.o: In function `az6027_frontend_attach': az6027.c:(.text+0x18c50d): undefined

Re: [PATCH] DocBook: Reduce noise from make cleandocs

2014-10-22 Thread Jonathan Corbet
On Tue, 21 Oct 2014 18:18:12 +0200 Takashi Iwai wrote: > I've got a harmless warning when running make cleandocs on an already > cleaned tree: Applied, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org Mor

[PATCH] adv7604: Add DT parsing support

2014-10-22 Thread Jean-Michel Hautbois
This patch adds support for DT parsing of ADV7604 as well as ADV7611. It needs to be improved in order to get ports parsing too. Signed-off-by: Jean-Michel Hautbois --- Documentation/devicetree/bindings/media/i2c/adv7604.txt | 1 + drivers/media/i2c/adv7604.c | 1 + 2

[PATCH 1/2] i2c: Add generic support passing secondary devices addresses

2014-10-22 Thread Jean-Michel Hautbois
Some I2C devices have multiple addresses assigned, for example each address corresponding to a different internal register map page of the device. So far drivers which need support for this have handled this with a driver specific and non-generic implementation, e.g. passing the additional address

[PATCH 2/2] adv7604: Add support for i2c_new_secondary_device

2014-10-22 Thread Jean-Michel Hautbois
The ADV7604 has thirteen 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus. If nothing is defined, it uses default addresses. The main purpose is using two adv76xx on the same i2c bus. Signed-off-by: Jean-

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-22 Thread Hans Verkuil
Hi Shuah, Some notes below... On 10/21/2014 07:32 PM, Shuah Khan wrote: > On 10/21/2014 10:05 AM, Takashi Iwai wrote: >> At Tue, 21 Oct 2014 17:42:51 +0200, >> Hans Verkuil wrote: > >>> >>> Quite often media apps open the alsa device at the start and then switch >>> between TV, radio or DVB mode

[REVIEW] Submitting Media Patches

2014-10-22 Thread Hans Verkuil
During the mini-summit it was decided that we should put up a document on how to post/handle patches etc. for the media drivers in the wiki. I had such a doc already which I'm posting now for review. Once it's all OK Pawel offered to put it up in the wiki. -

[PATCH] s5p-mfc: correct the formats info for encoder

2014-10-22 Thread ayaka
The NV12M is supported by all the version of MFC, so it is better to use it as default OUTPUT format. MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is not supported either. Signed-off-by: ayaka --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++--- 1 file changed, 2 inse

RE: [PATCH] s5p-mfc: correct the formats info for encoder

2014-10-22 Thread ayaka
I am very sorry to forget the Sign-off again and thank you for reviewing. ayaka (1): s5p-mfc: correct the formats info for encoder drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 1.9.3 -- To unsubscribe from this list: send the line

Re: [PATCH] [media] Fix smatch warning: unknown field name in initializer

2014-10-22 Thread Hans Verkuil
I sadly missed this patch and it is merged now. But: Nacked-by: Hans Verkuil This sparse warnings are due to a sparse bug that has been fixed in the sparse git repo. It's not included in sparse-0.5.0, the fix came in later. The #define that you kept it the version that does not comply with th

Re: Re: [PATCH 3/3] DVBSky V3 PCIe card: add some changes to M88DS3103for supporting the demod of M88RS6000

2014-10-22 Thread Nibble Max
On 2014-10-22 05:24:02, Antti Palosaari wrote: > > >On 10/13/2014 09:44 AM, Nibble Max wrote: >> M88RS6000 is the integrated chip, which includes tuner and demod. >> Its internal demod is similar with M88DS3103 except some registers >> definition. >> The main different part of this internal demod

Re: [PATCH 4/5] [media] vivid: add support for contiguous DMA buffers

2014-10-22 Thread Philipp Zabel
Am Mittwoch, den 22.10.2014, 12:14 +0200 schrieb Hans Verkuil: [...] > > diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c > > b/drivers/media/platform/vivid/vivid-vid-cap.c > > index 331c544..04b5fbf 100644 > > --- a/drivers/media/platform/vivid/vivid-vid-cap.c > > +++ b/drivers/media/pla

RE: [PATCH] s5p-mfc: correct the formats info for encoder

2014-10-22 Thread Kamil Debski
Hi Ayaka, Could you resend this patch with your sign-off? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: ayaka [mailto:ay...@soulik.info] > Sent: Wednesday, July 23, 2014 6:15 PM > To: linux-media@vger.kernel.org > Cc: kyungmin.p...@samsung.com;

[GIT PULL FOR v3.19] davinci vpbe cleanups and improvements

2014-10-22 Thread Hans Verkuil
Note: I skipped patch https://patchwork.linuxtv.org/patch/26430/ from Prabhakar's patch series since that needs a bit more work, but all other patches from that series are part of this pull request. Over 300 lines deleted, always nice! Regards, Hans The following changes since commit

Re: [PATCH 10/15] media: davinci: vpbe: add support for VIDIOC_CREATE_BUFS

2014-10-22 Thread Hans Verkuil
Hi Prabhakar, This patch series looks good, except for this one. If you add create_bufs support, then you should also update queue_setup. If the fmt argument to queue_setup is non-NULL, then check that the fmt.pix.sizeimage field is >= the current format's sizeimage. If not, return -EINVAL. Th

[GIT FIXES for v3.18] Various fixes

2014-10-22 Thread Hans Verkuil
Various fixes for 3.18. Regards, Hans The following changes since commit 1ef24960ab78554fe7e8e77d8fc86524fbd60d3c: Merge tag 'v3.18-rc1' into patchwork (2014-10-21 08:32:51 -0200) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.18f for yo

Re: [PATCH -next] media: tw68: fix build errors and warnings

2014-10-22 Thread Hans Verkuil
Hi Randy, After analyzing this it became clear that the I2C_ALGOBIT select was bogus since this driver doesn't use i2c at all. I've posted a new patch fixing that. Thanks, Hans On 10/06/2014 07:05 PM, Randy Dunlap wrote: From: Randy Dunlap Fix build errors and kconfig warning: since

[PATCH for v3.18] tw68: remove bogus I2C_ALGOBIT dependency

2014-10-22 Thread Hans Verkuil
tw68 doesn't use i2c at all, so remove this bogus dependency to prevent this warning: warning: (CAN_PEAK_PCIEC && SFC && IGB && VIDEO_TW68 && DRM && FB_DDC && FB_VIA) selects I2C_ALGOBIT which has unmet direct dependencies (I2C) CC [M] drivers/i2c/algos/i2c-algo-bit.o ../drivers/i2c/algos/i2

ERROR: "cfb_fillrect" undefined!

2014-10-22 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c3351dfabf5c78fb5ddc79d0f7b65ebd9e441337 commit: e75420dd25bc9d7b6f4e3b4c4f6c778b610c8cda [media] vivid: enable the vivid driver date: 7 weeks ago config: i386-randconfig-x1-10221122 (attached as .config) rep

Re: [PATCH 5/5] [media] vivid: enable VIDIOC_EXPBUF

2014-10-22 Thread Hans Verkuil
On 10/22/2014 12:03 PM, Philipp Zabel wrote: Instances created with allocators == 1 use videobuf2-dma-contig, and are able to export DMA buffers via VIDIOC_EXPBUF. Can you test what happens if you use EXPBUF when vmalloc is used? I hope it will just fail, but I am not sure. Regards, H

Re: [PATCH 4/5] [media] vivid: add support for contiguous DMA buffers

2014-10-22 Thread Hans Verkuil
On 10/22/2014 12:03 PM, Philipp Zabel wrote: To simulate the behaviour of real hardware with such limitations or to connect vivid to real hardware with such limitations, add an option to let vivid use the dma-contig allocator instead of vmalloc. Signed-off-by: Philipp Zabel --- drivers/media/

Re: [PATCH 3/5] [media] vivid: convert to platform device

2014-10-22 Thread Hans Verkuil
On 10/22/2014 12:03 PM, Philipp Zabel wrote: For contiguous DMA buffer allocation, a struct is needed that DMA buffers can be associated with. Signed-off-by: Philipp Zabel Acked-by: Hans Verkuil Nice! I was planning something like that myself. Regards, Hans --- drivers/media/p

Re: [PATCH 2/5] [media] vivid: remove unused videobuf2-vmalloc headers

2014-10-22 Thread Hans Verkuil
On 10/22/2014 12:03 PM, Philipp Zabel wrote: The videobuf2-vmalloc header is not used by the changed files, so remove it. Acked-by: Hans Verkuil Signed-off-by: Philipp Zabel --- drivers/media/platform/vivid/vivid-kthread-cap.c | 1 - drivers/media/platform/vivid/vivid-kthread-out.c | 1

Re: [PATCH 1/5] [media] vivid: select CONFIG_FB_CFB_FILLRECT/COPYAREA/IMAGEBLIT

2014-10-22 Thread Hans Verkuil
Superseded. Already part of a pull request for 3.18. But thanks anyway :-) Hans On 10/22/2014 12:03 PM, Philipp Zabel wrote: The OSD simulation uses the framebuffer core functions, so vivid needs to select the corresponding configuration options. Signed-off-by: Philipp Zabel --- dr

[PATCH 5/5] [media] vivid: enable VIDIOC_EXPBUF

2014-10-22 Thread Philipp Zabel
Instances created with allocators == 1 use videobuf2-dma-contig, and are able to export DMA buffers via VIDIOC_EXPBUF. Signed-off-by: Philipp Zabel --- drivers/media/platform/vivid/vivid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vivid/vivid

[PATCH 1/5] [media] vivid: select CONFIG_FB_CFB_FILLRECT/COPYAREA/IMAGEBLIT

2014-10-22 Thread Philipp Zabel
The OSD simulation uses the framebuffer core functions, so vivid needs to select the corresponding configuration options. Signed-off-by: Philipp Zabel --- drivers/media/platform/vivid/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/vivid/Kconfig b/drivers/m

[PATCH 0/5] Contiguous DMA buffer support for the Virtual Video Test Driver

2014-10-22 Thread Philipp Zabel
Hi, to use vivid as test source for a hardware pipeline with elements that can only handle contiguous DMA buffers, I'd like to add support for the videobuf2-dma-contig allocator and enable VIDIOC_EXPBUF in vivid. Since DMA memory should be associated with a struct device, I have added a platform d

[PATCH 2/5] [media] vivid: remove unused videobuf2-vmalloc headers

2014-10-22 Thread Philipp Zabel
The videobuf2-vmalloc header is not used by the changed files, so remove it. Signed-off-by: Philipp Zabel --- drivers/media/platform/vivid/vivid-kthread-cap.c | 1 - drivers/media/platform/vivid/vivid-kthread-out.c | 1 - drivers/media/platform/vivid/vivid-osd.c | 1 - 3 files changed, 3

[PATCH 3/5] [media] vivid: convert to platform device

2014-10-22 Thread Philipp Zabel
For contiguous DMA buffer allocation, a struct is needed that DMA buffers can be associated with. Signed-off-by: Philipp Zabel --- drivers/media/platform/vivid/vivid-core.c | 37 +-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform

[PATCH 4/5] [media] vivid: add support for contiguous DMA buffers

2014-10-22 Thread Philipp Zabel
To simulate the behaviour of real hardware with such limitations or to connect vivid to real hardware with such limitations, add an option to let vivid use the dma-contig allocator instead of vmalloc. Signed-off-by: Philipp Zabel --- drivers/media/platform/vivid/Kconfig | 1 + drivers/m

Re: [PATCH/RFC v2 2/4] Add media device related data structures and API.

2014-10-22 Thread Sakari Ailus
Hi Jacek, On Fri, Oct 17, 2014 at 04:54:40PM +0200, Jacek Anaszewski wrote: ... > +/* > + * struct media_entity - media device entity data > + * @id: media entity id within media controller > + * @name:media entity name > + * @node_name: media entity

[PATCH] v4l2-ctrls: fix sparse warning

2014-10-22 Thread Hans Verkuil
It seems I forgot about this patch and I never posted it, but it is something that needs to be fixed. Validating compound types could cause user pointers to be interpreted as kernel pointers with potentially bad results. Pawel, this is likely to be relevant to the codec API you are doing. The

Re: [v4l-utils RFC 0/2] libmediatext library

2014-10-22 Thread Sakari Ailus
Hi Hans, Hans de Goede wrote: Hi Sakari, On 10/21/2014 12:40 PM, Sakari Ailus wrote: Hi, This is a tiny library for parsing text-based media link, V4L2 sub-device format (and selection) configurations as well as controls with limited types. Hmm, we also have: [PATCH/RFC v2 1/4] Add a media

[GIT PULL FOR v3.19] mem2mem_testdev: rename to vim2m

2014-10-22 Thread Hans Verkuil
This is identical to https://patchwork.linuxtv.org/patch/26044/ except for being rebased to v3.18-rc1. Regards, Hans The following changes since commit 1ef24960ab78554fe7e8e77d8fc86524fbd60d3c: Merge tag 'v3.18-rc1' into patchwork (2014-10-21 08:32:51 -0200) are available in the git

[GIT PULL FOR v3.19] cx88: convert to vb2

2014-10-22 Thread Hans Verkuil
This pull request contains this patch series: https://www.mail-archive.com/linux-media@vger.kernel.org/msg79597.html It's unchanged except for rebasing to v3.18-rc1. Regards, Hans The following changes since commit 1ef24960ab78554fe7e8e77d8fc86524fbd60d3c: Merge tag 'v3.18-rc1' int

Re: [media] CODA960: Fails to allocate memory

2014-10-22 Thread Jean-Michel Hautbois
2014-10-22 11:29 GMT+02:00 Philipp Zabel : > Hi Jean-Michel, > > Am Mittwoch, den 22.10.2014, 11:21 +0200 schrieb Jean-Michel Hautbois: >> I may have misunderstand something... >> I try to encode, and modified the CODA_MAX_FRAME_SIZE to 0x50 just to >> see. >> >> And here is the trace-cmd : >>

cron job: media_tree daily build: WARNINGS

2014-10-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed 22 Oct 10:54:01 CEST 2014 git branch: test git hash: 1ef24960ab78554fe7e8e77d8fc86524fbd60d3c gcc versi

Re: [media] CODA960: Fails to allocate memory

2014-10-22 Thread Philipp Zabel
Hi Jean-Michel, Am Mittwoch, den 22.10.2014, 11:21 +0200 schrieb Jean-Michel Hautbois: > I may have misunderstand something... > I try to encode, and modified the CODA_MAX_FRAME_SIZE to 0x50 just to see. > > And here is the trace-cmd : > > $> trace-cmd record -e v4l2* v4l2-ctl -d1 --stream

Re: [media] CODA960: Fails to allocate memory

2014-10-22 Thread Jean-Michel Hautbois
Hi Philipp, > > 2014-10-21 18:21 GMT+02:00 Philipp Zabel : >> Hi Jean-Michel, >> >> Am Dienstag, den 21.10.2014, 17:39 +0200 schrieb Jean-Michel Hautbois: >> [...] >>> And the output is now : >>> v4l2-ctl -d1 --stream-out-mmap --stream-mmap --stream-to x.raw >>> [ 6208.240919] coda 204.vpu: Not

[PATCH for v3.18] wl128x: fix fmdbg compiler warning

2014-10-22 Thread Hans Verkuil
fmdrv_common.c: In function 'fm_download_firmware': fmdrv_common.c:1259:2: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' [-Wformat=] fmdbg("Firmware(%s) length : %d bytes\n", fw_name, fw_entry->size); ^ Signed-off-by: Hans Verkuil --- drivers/media/r