An error was returned if composing was not supported, instead of if
cropping was not supported.
A classic copy-and-paste bug. Found with v4l2-compliance.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Cc: sta...@vger.kernel.org # for v3.18
---
Hi Hans,
On Fri, Dec 05, 2014 at 04:10:05PM +0100, Hans Verkuil wrote:
On 12/03/2014 12:14 PM, Sakari Ailus wrote:
From: Sakari Ailus sakari.ai...@linux.intel.com
The data_offset field tells the start of the image data from the beginning
of the buffer. The bsize field
bsize field?
Hi Hans,
Thank you for the review.
On Fri, Dec 05, 2014 at 04:12:31PM +0100, Hans Verkuil wrote:
On 12/03/2014 12:14 PM, Sakari Ailus wrote:
From: Aviv Greenberg aviv.d.greenb...@intel.com
These formats are just like 10-bit raw bayer formats that exist already, but
the pixels are not
On 12/06/2014 12:48 PM, Sakari Ailus wrote:
Hi Hans,
On Fri, Dec 05, 2014 at 04:10:05PM +0100, Hans Verkuil wrote:
On 12/03/2014 12:14 PM, Sakari Ailus wrote:
From: Sakari Ailus sakari.ai...@linux.intel.com
snip
I think we need to add new helper functions that give back the real plane
The format of a sysfs attribute should be concise.
The error codes are generic and map directly to the V4L2 Flash
error codes.
Actually I'd like to see those flash fault code defined in LED
subsystem. And V4L2 will just include LED flash header file to use it.
Because flash fault
Moikka!
I am very surprised about that patch, especially because it *increases*
polling interval from 400ms to 200ms. For me it has been always worked
rather well, but now I suspect it could be due to I disable always
remote controller... I have to test that.
regards
Antti
On 12/06/2014
From: Benoit Parrot bpar...@ti.com
This patch adds Video Processing Front End (VPFE) driver for
AM437X family of devices
Driver supports the following:
- V4L2 API using MMAP buffer access based on videobuf2 api
- Asynchronous sensor/decoder sub device registration
- DT support
Signed-off-by:
On 12/06/2014 01:46 PM, Antti Palosaari wrote:
Moikka!
I am very surprised about that patch, especially because it
*increases* polling interval from 400ms to 200ms. For me it has been
always worked rather well, but now I suspect it could be due to I
disable always remote controller... I have
Hi Eddi,
As far as I know, the new version of Terratec H7 is another version of
DVBSky T680CI or TechnoTrend CT2-4650 CI. Just try to change the USB
IDs in the dvbsky.c driver and compile the driver and test. I'd do
this for you, but am travelling at the moment and have very limited
time.
But that is not needed anymore ?
regards
Antti
On 12/06/2014 02:25 AM, Benjamin Larsson wrote:
Using this driver with the attach dvb model might trigger a use
after free when unloading the driver. With this change the driver
will always fail on unload instead of randomly crash depending
on if
On 12/06/2014 02:25 AM, Benjamin Larsson wrote:
Signed-off-by: Benjamin Larsson benja...@southpole.se
Reviewed-by: Antti Palosaari cr...@iki.fi
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to
On my new DVBSky T980C the tuner firmware failes to load:
[ 51.326525] si2168 2-0064: found a 'Silicon Labs Si2168' in cold state
[ 51.356233] si2168 2-0064: downloading firmware from file
'dvb-demod-si2168-a30-01.fw'
[ 51.408166] si2168 2-0064: firmware download failed=-110
[ 51.415457]
I've noticed my Easycap DC60+ stopped capturing audio after a kernel
upgrade on my distribution (Arch Linux x86_64); going from linux
3.17.2 to 3.17.3.
I started a thread on the Arch Linux forums
https://bbs.archlinux.org/viewtopic.php?pid=1482059
and was adviced to report it to this mailing
On 12/06/2014 05:29 PM, Antti Palosaari wrote:
But that is not needed anymore ?
regards
Antti
Chances are that more devices with the mn8847x chips appear. Someone
somewhere might try to use this demod with the old dvb attach model
during development. Adding this memset will make the unload
On 12/06/2014 06:48 PM, Jurgen Kramer wrote:
On my new DVBSky T980C the tuner firmware failes to load:
[ 51.326525] si2168 2-0064: found a 'Silicon Labs Si2168' in cold state
[ 51.356233] si2168 2-0064: downloading firmware from file
'dvb-demod-si2168-a30-01.fw'
[ 51.408166] si2168 2-0064:
On 12/06/2014 08:08 PM, Benjamin Larsson wrote:
On 12/06/2014 05:29 PM, Antti Palosaari wrote:
But that is not needed anymore ?
regards
Antti
Chances are that more devices with the mn8847x chips appear. Someone
somewhere might try to use this demod with the old dvb attach model
during
[1627538.860627] s5h1411_readreg: readreg error (ret == -5)
[1627538.860633] saa7164_cmd_send() No free sequences
[1627538.860636] saa7164_api_i2c_read() error, ret(1) = 0xc
[1627538.860639] s5h1411_readreg: readreg error (ret == -5)
[1627538.860647] saa7164_cmd_send() No free sequences
MARRIOTT HOTEL SINGAPORE HAS EMPLOYMENT OPPORTUNITIES FOR AN EXOTIC
CANDIDATES IN DIFFERENT SKILLS,SEND YOUR CURRENT CV/RESUME AND
APPLICATION LETTER IN MICRO SOFT TO THIS E-MAIL ID:
marriothotelrecruitmentserv...@hotmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media
On 12/06/2014 07:37 PM, Antti Palosaari wrote:
I do think it is good practice to set pointers to null generally as that
would have saved me several days of work of whentracking down this bug.
The current dvb framework contain several other cases where pointers are
feed'd but not nulled.
There
'dev' is likely most common name in kernel for structure containing
device state instance, so rename it in order to keep things
consistent.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/tuners/si2157.c | 118 ++---
Remove if () from firmware command error path as there should not be
any error prone conditional logic there. Use goto labels instead.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/tuners/si2157.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
Rename some goto labels and more. No functionality changes.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 38
drivers/media/dvb-frontends/si2168.h | 6 ++
2 files changed, 14 insertions(+), 30 deletions(-)
diff
Remove if () from firmware command error path as there should not be
any error prone conditional logic there. Use goto labels instead.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
Use own label for kzalloc failure in which does not call kfree().
kfree() could be called with NULL, but it is still better to have
own label which skips unnecessary kfree().
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 3 ++-
1 file changed, 2
All known old firmware firmware formats are downloaded using 8 byte
chunks. Reject firmware if it could not be divided to 8 byte chunks
and because of that we could simplify some calculations. Now both
supported firmware download routines are rather similar.
Cc: Olli Salonen olli.salo...@iki.fi
w_scan complains about missing symbol rate limits:
This dvb driver is *buggy*: the symbol rate limits are undefined - please
report to linuxtv.org
Chip supports 1 to 7.2 MSymbol/s on DVB-C.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 2 ++
1 file
Change formatter from signed to unsigned as stream_id is 32bit
unsigned variable.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb-frontends/si2168.c
Rename firmware variable from fw_file to fw_name and change its
type from u8 to const char as request_firmware() input is.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/tuners/si2157.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
We don't need that anymore as same pointer is passed to each
routine via struct dvb_frontend private field.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 61 +++
drivers/media/dvb-frontends/si2168_priv.h | 1 -
2 files
Even firmware version is not needed to know, it is still interesting
and useful to know some cases. Due to that increase its printing to
info log level.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
'dev' is most common name in kernel for structure containing device
state instance, so rename it.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 202 +++---
drivers/media/dvb-frontends/si2168_priv.h | 2 +-
2 files changed,
Carry struct i2c_client pointer inside struct dvb_frontend private
pointer. This driver is I2C driver, which is represented as a
struct i2c_client, so better to carry this top level structure for
each routine in order to unify things. This allows further
simplification.
Signed-off-by: Antti
Print chip version once using log level into when init() is called.
Remove cold/warm state printing as those are not very useful.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/tuners/si2157.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git
Firmware version could be printed similarly than si2168 driver does.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/tuners/si2157.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
index 3f9aa7a..6ae7620
Rename firmware variable from fw_file to fw_name and change its type
from u8 to const char as request_firmware() input defines.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/si2168.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff
Print chip version once using log level into when init() is called.
Remove cold/warm state printing as those are not very useful.
old printing:
si2168 6-0064: found a 'Silicon Labs Si2168' in cold state
si2168 6-0064: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
si2168 6-0064:
Rename firmare download error path goto label. Remove firmware NULL
set as NULL value is not needed anymore, due to recent change which
started using goto labels for firmware error handling.
Cc: Olli Salonen olli.salo...@iki.fi
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Carry struct i2c_client pointer in tuner_priv. This driver is I2C driver,
which is represented as a struct i2c_client, so better to carry this top
level structure for each routine in order to unify things.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/tuners/si2157.c | 78
Use own goto label for error case mem free is needed, even kfree could
be called with NULL. I think it is better to have it, even not required.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/tuners/si2157.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
commit 034e1ec0ce299b9e90056793dcb3187e7add6b62
si2168: One function call less in si2168_init() after error detection
That commit added goto label for error path to release firmware,
but forgets to remove variable NULL set. Remove those now.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
- Rename ID table.
- Remove magic numbers from ID table driver data field.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/tuners/si2157.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index c6895ee..be8a6d5 100644
---
On 12/06/2014 11:57 PM, Benjamin Larsson wrote:
Signed-off-by: Benjamin Larsson benja...@southpole.se
Reviewed-by: Antti Palosaari cr...@iki.fi
Antti
---
drivers/staging/media/mn88472/mn88472.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
On Fri, Dec 05, 2014 at 03:19:20PM +0100, Hans Verkuil wrote:
These patches change the type of the two new fields in struct
v4l2_mbus_framefmt
from __u32 to __u16, as per Sakari's suggestion. We don't need 4 bytes per
field
for this, and this way we save one __u32.
It also updates
Hi Hans,
On Sat, Dec 06, 2014 at 01:05:16PM +0100, Hans Verkuil wrote:
On 12/06/2014 12:48 PM, Sakari Ailus wrote:
Hi Hans,
On Fri, Dec 05, 2014 at 04:10:05PM +0100, Hans Verkuil wrote:
On 12/03/2014 12:14 PM, Sakari Ailus wrote:
From: Sakari Ailus sakari.ai...@linux.intel.com
snip
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sun Dec 7 04:00:16 CET 2014
git branch: test
git hash: 71947828caef0c83d4245f7d1eaddc799b4ff1d1
gcc
46 matches
Mail list logo
