Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Daniel Thompson
On 28/01/15 06:00, Sumit Semwal wrote: At present, dma_buf_export() takes a series of parameters, which makes it difficult to add any new parameters for exporters, if required. Make it simpler by moving all these parameters into a struct, and pass the struct * as parameter to

Re: [PATCH v2 3/6] v4l2-ctrls: Make the control type init op initialize the whole control

2015-01-28 Thread Hans Verkuil
On 01/28/15 10:17, Laurent Pinchart wrote: The control type init operation is called in a loop to initialize all elements of a control. Not only is this inefficient for control types that could use a memset(), it also complicates the implementation of custom control types, for instance when a

Re: HW seek and TDA8290

2015-01-28 Thread Mauro Carvalho Chehab
Em Wed, 28 Jan 2015 04:07:44 + Buda Servantes budaservan...@gmail.com escreveu: It is possible to have HW seek support in TDA8290 cards as in recent TEA575x? Yes, if tda8290 provides such feature and someone with its datasheet can implement the code and submit us. Regards, Mauro -- To

Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros

2015-01-28 Thread Sakari Ailus
Hi Jacek, On Tue, Jan 20, 2015 at 01:53:05PM +0100, Jacek Anaszewski wrote: On 01/20/2015 12:12 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Add macros for max77693 led part related binding. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin

Re: [PATCH v2 1/6] v4l2-ctrls: Add new S8, S16 and S32 compound control types

2015-01-28 Thread Hans Verkuil
On 01/28/15 10:17, Laurent Pinchart wrote: Only unsigned compound types are implemented so far, add the corresponding signes types. Nitpick: signes - signed Regards, Hans Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil

Re: [PATCH v2 6/6] staging: media: omap4iss: ipipe: Expose the RGB2RGB blending matrix

2015-01-28 Thread Laurent Pinchart
Hi Hans, Thank you for the review. On Wednesday 28 January 2015 11:27:02 Hans Verkuil wrote: On 01/28/15 10:17, Laurent Pinchart wrote: Expose the module as two controls, one for the 3x3 multiplier matrix and one for the 3x1 offset vector. Signed-off-by: Laurent Pinchart

Re: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
Hi Mauro, On 28 January 2015 at 18:53, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Em Wed, 28 Jan 2015 18:24:03 +0530 Sumit Semwal sumit.sem...@linaro.org escreveu: +/** + * helper macro for exporters; zeros and fills in most common values + */ +#define

Re: [PATCH v2 6/6] staging: media: omap4iss: ipipe: Expose the RGB2RGB blending matrix

2015-01-28 Thread Hans Verkuil
On 01/28/15 10:17, Laurent Pinchart wrote: Expose the module as two controls, one for the 3x3 multiplier matrix and one for the 3x1 offset vector. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/staging/media/omap4iss/iss_ipipe.c | 129

Re: [PATCH] media: gspca_vc032x - wrong bytesperline

2015-01-28 Thread Hans de Goede
Hi, On 26-01-15 11:38, Luca Bonissi wrote: Hi! I found a problem on vc032x gspca usb webcam subdriver: bytesperline property is wrong for YUYV and YVYU formats. With recent v4l-utils library (=0.9.1), that uses bytesperline for pixel format conversion, the result is a wrong jerky image.

Re: [PATCH 1/2] media: v4l2-image-sizes.h: add SVGA, XGA and UXGA size definitions

2015-01-28 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 28 Jan 2015, Josh Wu wrote: Hi, Guennadi On 11/28/2014 4:13 AM, Guennadi Liakhovetski wrote: Hi Josh, On Thu, 27 Nov 2014, Josh Wu wrote: Hi, Guennadi On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote: Hi Josh, On Tue, 25 Nov 2014, Josh Wu

[PATCH 0/3] dvb_net: general cleaning

2015-01-28 Thread Joe Perches
Use more common kernel mechanisms Joe Perches (3): dvb_net: Use vsprintf %pM extension to print Ethernet addresses dvb_net: Use standard debugging facilities dvb_net: Convert local hex dump to print_hex_dump_debug drivers/media/dvb-core/dvb_net.c | 88

[PATCH] [media] dvb-usb: fix spaces after commas

2015-01-28 Thread Luis de Bethencourt
Signed-off-by: Luis de Bethencourt luis...@samsung.com --- drivers/media/usb/dvb-usb/dvb-usb-dvb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dvb-usb-dvb.c b/drivers/media/usb/dvb-usb/dvb-usb-dvb.c index 719413b..c901d15 100644

[PATCH 1/3] dvb_net: Use vsprintf %pM extension to print Ethernet addresses

2015-01-28 Thread Joe Perches
No need for more macros, so remove them and use the kernel extension. Signed-off-by: Joe Perches j...@perches.com --- drivers/media/dvb-core/dvb_net.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c

Re: [RESEND PATCH] media: fix au0828_analog_register() to not free au0828_dev

2015-01-28 Thread Shuah Khan
On 12/20/2014 08:24 PM, Shuah Khan wrote: au0828_analog_register() frees au0828_dev when it fails to locate isoc endpoint. au0828_usb_probe() continues with dvb and rc probe and registration assuming dev is still valid. When au0828_analog_register() fails to locate isoc endpoint, it should

Re: [PATCH 6/7] [media] marvell-ccic: MMP_CAMERA never worked

2015-01-28 Thread Jonathan Corbet
On Wed, 28 Jan 2015 22:17:46 +0100 Arnd Bergmann a...@arndb.de wrote: The mmp ccic driver uses a platform_data structure that has never existed in an upstream kernel and always fails to build: This driver most assuredly did work on XO 1.75 machines, and the platform_data structure does exist;

[PATCH 3/3] dvb_net: Convert local hex dump to print_hex_dump_debug

2015-01-28 Thread Joe Perches
Use the generic facility instead of a home-grown one. Signed-off-by: Joe Perches j...@perches.com --- drivers/media/dvb-core/dvb_net.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/media/dvb-core/dvb_net.c

[PATCH v4] [media] Add LVDS RGB media bus formats

2015-01-28 Thread Philipp Zabel
This patch adds three new RGB media bus formats that describe 18-bit or 24-bit samples transferred over an LVDS bus with three or four differential data pairs, serialized into 7 time slots, using standard SPWG/PSWG/VESA or JEIDA data ordering. Signed-off-by: Philipp Zabel p.za...@pengutronix.de

Re: [RFCv3 1/2] device: add dma_params-max_segment_count

2015-01-28 Thread Marek Szyprowski
Hello, On 2015-01-27 09:25, Sumit Semwal wrote: From: Rob Clark robdcl...@gmail.com For devices which have constraints about maximum number of segments in an sglist. For example, a device which could only deal with contiguous buffers would set max_segment_count to 1. The initial motivation

[PATCH 2/3] dvb_net: Use standard debugging facilities

2015-01-28 Thread Joe Perches
Convert dprintk to netdev_dbg where appropriate. Remove dvb_net_debug module_param. Remove __func__ from output as that can be added by dynamic_debug. Signed-off-by: Joe Perches j...@perches.com --- drivers/media/dvb-core/dvb_net.c | 57 +--- 1 file changed,

[PATCH 1/3] [media] v4l: vsp1: Fix VI6_WPF_SZCLIP_SIZE_MASK macro

2015-01-28 Thread Nobuhiro Iwamatsu
Clipping size bit of VI6_WPFn _HSZCLIP and VI6_WPFn _VSZCLIP register are from 0 bit to 11 bit. But VI6_WPF_SZCLIP_SIZE_MASK is set to 0x1FFF, this will mask until the reserve bits. This fixes size for VI6_WPF_SZCLIP_SIZE_MASK. Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com ---

[PATCH 3/3] [media] v4l: vsp1: Fix VI6_DPR_ROUTE_FXA_MASK macro

2015-01-28 Thread Nobuhiro Iwamatsu
FXA bit of VI6_DPR_mod_ROUTE register starts from 16bit. But VI6_DPR_ROUTE_FXA_MASK is set to become start from 8bit. This fixes shift size for VI6_DPR_ROUTE_FXA_MASK. Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com --- drivers/media/platform/vsp1/vsp1_regs.h | 2 +- 1 file

[PATCH 2/3] [media] v4l: vsp1: Fix VI6_DPR_ROUTE_FP_MASK macro

2015-01-28 Thread Nobuhiro Iwamatsu
FP bit of VI6_DPR_mod_ROUTE register is 6bit. But VI6_DPR_ROUTE_FP_MASK is set to 0xFF, this will mask until the reserve bit. This fixes size for VI6_DPR_ROUTE_FP_MASK. Signed-off-by: Nobuhiro Iwamatsu nobuhiro.iwamatsu...@renesas.com --- drivers/media/platform/vsp1/vsp1_regs.h | 2 +- 1 file

RE: [possible BUG, cx23885] Dual tuner TV card, works using one tuner only, doesn't work if both tuners are used

2015-01-28 Thread James Harper
Hi, James. After searching for somebody posting some issues similar to mine, I think this one you posted to the mailing list can be related: https://www.mail-archive.com/linux- media%40vger.kernel.org/msg80078.html I'm having problems using both tuners in a dual tuner card (Terratec

[PATCH 3/7] [media] staging/davinci/vpfe/dm365: add missing dependencies

2015-01-28 Thread Arnd Bergmann
This driver can only be built when VIDEO_V4L2_SUBDEV_API and VIDEO_DAVINCI_VPBE_DISPLAY are also provided by the kernel. drivers/staging/media/davinci_vpfe/dm365_isif.c: In function '__isif_get_format': drivers/staging/media/davinci_vpfe/dm365_isif.c:1410:3: error: implicit declaration of

[PATCH 5/7] [media] gspca: add INPUT dependency

2015-01-28 Thread Arnd Bergmann
The gspca driver uses the input_event infrastructure and fails to link if that is not available: drivers/built-in.o: In function `gspca_disconnect': media/usb/gspca/gspca.c:2171: undefined reference to `input_unregister_device' drivers/built-in.o: In function `gspca_dev_probe2':

[PATCH 0/7] [media] ARM randconfig fixes

2015-01-28 Thread Arnd Bergmann
Hi Mauro, This is one set of randconfig fixes that I've been carrying in a local branch for a long time. I have made sure that they are all still required, but there are others that I have not been able to reproduce yet, so I will probably send them out once I get the errors again. The ones here

TBS6981/vb2-cx23885 kernel oops

2015-01-28 Thread Nick Burrett
The following are 3 samples of kernel messages that I am getting on a fairly regular basis, which seem to have started occurring since the cx23885 vb2 conversion. I am using the https://github.com/ljalves/linux_media tree from 16 Jan 2015 I have a TBS6985 and a TBS6981 card present in the

[PATCH] staging: media: vino: vino: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/media/vino/vino.c |

[PATCH v2 6/7] [media] marvell-ccic: MMP_CAMERA no longer builds

2015-01-28 Thread Arnd Bergmann
The mmp ccic driver expects a platform_data structure that does not exist in the mainline kernel and presumably was changed in a kernel fork, which leads to build errors now: media/platform/marvell-ccic/mmp-driver.c: In function 'mmpcam_calc_dphy': media/platform/marvell-ccic/mmp-driver.c:252:15:

Re: [PATCH 7/7] [media] marvell-ccic needs VIDEOBUF2_DMA_SG

2015-01-28 Thread Jonathan Corbet
On Wed, 28 Jan 2015 22:17:47 +0100 Arnd Bergmann a...@arndb.de wrote: The vb2_dma_sg_memops pointer is only valid if VIDEOBUF2_DMA_SG is set, so we should select that to avoid this build error: drivers/built-in.o: In function `mcam_v4l_open': :(.text+0x388d00): undefined reference to

[PULL patches for 3.20]: New gspca touptek driver, gspca fixes and sunxi-cir driver improvments

2015-01-28 Thread Hans de Goede
Hi Mauro, Note this pull-req superseeds my previous pull-req for 3.20, and now includes one more gspca bugfix. Please pull from my tree for a new gspca touptek driver, various gspca fixes and some sunxi-cir driver improvments. The following changes since commit

Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
On 28 January 2015 at 16:50, Daniel Thompson daniel.thomp...@linaro.org wrote: On 28/01/15 06:00, Sumit Semwal wrote: snip +/** + * helper macro for exporters; zeros and fills in most common values + */ +#define DEFINE_DMA_BUF_EXPORT_INFO(a)\ + struct

[PATCH v2 0/6] omap4iss: Add RGB2RGB blending matrix support

2015-01-28 Thread Laurent Pinchart
Hello, This patch set adds support for exposing the OMAP4 ISS IPIPE RGB2RGB blending matrix through V4L2 controls, using the compound controls support. Patches 1 to 4 add new signed compound control types and simplify the control type init operation. Patches 5 then fixes an issue with the

[PATCH v2 5/6] staging: media: omap4iss: Cleanup media entities after unregistration

2015-01-28 Thread Laurent Pinchart
The ipipeif, ipipe and resizer media entities are cleaned up before unregistering the media device, creating a race condition. Fix it by cleaning them up at cleanup time. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/staging/media/omap4iss/iss_ipipe.c | 6 +++---

[PATCH v2 4/6] v4l2-ctrls: Export the standard control type operations

2015-01-28 Thread Laurent Pinchart
Drivers that implement custom control types need to implement the equal, init, log and validate operations. Depending on the control type some of those operations can use the standard control type implementation provided by the v4l2 control framework. Export them to enable their reuse.

[PATCH v2 2/6] v4l2-ctrls: Don't initialize array tail when setting a control

2015-01-28 Thread Laurent Pinchart
Setting an array control subset isn't allowed by the control framework, which returns an error in prepare_ext_ctrls() if the control size specified by userspace is smaller than the total size. There is thus no need to initialize the array tail to its default value, as the tail will always be

[PATCH 7/7] [media] marvell-ccic needs VIDEOBUF2_DMA_SG

2015-01-28 Thread Arnd Bergmann
The vb2_dma_sg_memops pointer is only valid if VIDEOBUF2_DMA_SG is set, so we should select that to avoid this build error: drivers/built-in.o: In function `mcam_v4l_open': :(.text+0x388d00): undefined reference to `vb2_dma_sg_memops' Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Jonathan

[PATCH 4/7] [media] siano: fix Kconfig dependencies

2015-01-28 Thread Arnd Bergmann
The USB and MMC front-ends to the siano driver both only make sense when combined with the SMS_SIANO_MDTV driver. That driver already requires RC_CORE to not be a module, so we also need to add that dependency here. drivers/built-in.o: In function `smssdio_remove': :(.text+0x155bd8): undefined

Re: [PATCH v5] media: au0828 - convert to use videobuf2

2015-01-28 Thread Shuah Khan
On 01/23/2015 12:41 PM, Shuah Khan wrote: Convert au0828 to use videobuf2. Tested with NTSC. Tested video and vbi devices with xawtv, tvtime, and vlc. Ran v4l2-compliance to ensure there are no failures. Video compliance test results summary: Total: 75, Succeeded: 75, Failed: 0, Warnings:

[PATCH v2 3/6] v4l2-ctrls: Make the control type init op initialize the whole control

2015-01-28 Thread Laurent Pinchart
The control type init operation is called in a loop to initialize all elements of a control. Not only is this inefficient for control types that could use a memset(), it also complicates the implementation of custom control types, for instance when a matrix needs to be initialized with different

Re: [PATCH] media: au0828 analog_register error path fixes to do proper cleanup

2015-01-28 Thread Shuah Khan
On 12/30/2014 05:22 PM, Shuah Khan wrote: au0828_analog_register() doesn't release video and vbi queues created by vb2_queue_init(). In addition, it doesn't unregister vdev when vbi register fails. Add vb2_queue_release() calls to release video and vbi queues to the failure path to be called

[PATCH v2 1/6] v4l2-ctrls: Add new S8, S16 and S32 compound control types

2015-01-28 Thread Laurent Pinchart
Only unsigned compound types are implemented so far, add the corresponding signes types. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- .../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 21 +++

[PATCH 2/7] [media] radio/aimslab: use mdelay instead of udelay

2015-01-28 Thread Arnd Bergmann
Large udelay values are not allowed on the ARM architecture and result in a build error like ERROR: __bad_udelay [drivers/media/radio/radio-aimslab.ko] undefined! This changes the aimslab radio driver to use an equivalent mdelay statement. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Hans

[PATCH v2 6/6] staging: media: omap4iss: ipipe: Expose the RGB2RGB blending matrix

2015-01-28 Thread Laurent Pinchart
Expose the module as two controls, one for the 3x3 multiplier matrix and one for the 3x1 offset vector. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/staging/media/omap4iss/iss_ipipe.c | 129 - drivers/staging/media/omap4iss/iss_ipipe.h

[PATCH 6/7] [media] marvell-ccic: MMP_CAMERA never worked

2015-01-28 Thread Arnd Bergmann
The mmp ccic driver uses a platform_data structure that has never existed in an upstream kernel and always fails to build: media/platform/marvell-ccic/mmp-driver.c: In function 'mmpcam_calc_dphy': media/platform/marvell-ccic/mmp-driver.c:252:15: error: 'struct mmp_camera_platform_data' has no

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-28 Thread Sakari Ailus
On Wed, Jan 21, 2015 at 10:39:05AM +0100, Jacek Anaszewski wrote: I agree. I think that led-sources-cnt is redundant. A list property can be read using of_prop_next_u32 function. I missed that and thus proposed putting led-sources-cnt in each sub-node to be able to read led-sources list with

Re: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Mauro Carvalho Chehab
Em Wed, 28 Jan 2015 18:24:03 +0530 Sumit Semwal sumit.sem...@linaro.org escreveu: +/** + * helper macro for exporters; zeros and fills in most common values + */ +#define DEFINE_DMA_BUF_EXPORT_INFO(a)\ + struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME } + I suspect

[PATCH 1/7] [media] timberdale: do not select TIMB_DMA

2015-01-28 Thread Arnd Bergmann
The timberdale media driver requires the use of the respective dma engine driver, but that may not be enabled, causing a Kconfig warning: warning: (VIDEO_TIMBERDALE) selects TIMB_DMA which has unmet direct dependencies (DMADEVICES MFD_TIMBERDALE) This fixes the dependency by removing the

[PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
At present, dma_buf_export() takes a series of parameters, which makes it difficult to add any new parameters for exporters, if required. Make it simpler by moving all these parameters into a struct, and pass the struct * as parameter to dma_buf_export(). While at it, unite

Re: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Maarten Lankhorst
Op 28-01-15 om 13:54 schreef Sumit Semwal: At present, dma_buf_export() takes a series of parameters, which makes it difficult to add any new parameters for exporters, if required. Make it simpler by moving all these parameters into a struct, and pass the struct * as parameter to

cron job: media_tree daily build: ERRORS

2015-01-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jan 29 04:00:13 CET 2015 git branch: test git hash: 8d44aeefcd79e9be3b6db4f37efc7544995b619e gcc

Vivid test device: adding YU12

2015-01-28 Thread Miguel Casas-Sanchez
Hi folks, I've been trying to add a triplanar format to those that vivid can generate, and didn't quite manage :( So, I tried adding code for it like in the patch (with some dprintk() as well) to clarify what I wanted to do. Module is insmod'ed like insmod vivid.ko n_devs=1 node_types=0x1

Haupage 2250 / saa7164 kernel errors

2015-01-28 Thread catchall
About once a day, my tuner stops working and my logs fill up with the following messages: 2015-01-28T20:40:23.736478-08:00 mediapc kernel: [169020.845484] saa7164_cmd_send() No free sequences 2015-01-28T20:40:23.736480-08:00 mediapc kernel: [169020.845486] saa7164_api_i2c_read() error, ret(1)

Re: TBS6981/vb2-cx23885 kernel oops

2015-01-28 Thread Hans Verkuil
On 01/28/2015 01:01 PM, Nick Burrett wrote: The following are 3 samples of kernel messages that I am getting on a fairly regular basis, which seem to have started occurring since the cx23885 vb2 conversion. I am using the https://github.com/ljalves/linux_media tree from 16 Jan 2015 That's too

Re: [REGRESSION] media: cx23885 broken by commit 453afdd [media] cx23885: convert to vb2

2015-01-28 Thread Hans Verkuil
Hi Raimonds, On 01/11/2015 10:33 AM, Raimonds Cicans wrote: Hello. I contacted you because I am hit by regression caused by your commit: 453afdd [media] cx23885: convert to vb2 My system: AMD Athlon(tm) II X2 240e Processor on Asus M5A97 LE R2.0 motherboard TBS6981 card (Dual DVB-S/S2