usb 2-1: BOGUS urb xfer, pipe 3 != type 1 while loading a USB dvb-t driver (Terratec Cinergy DT USB XS Diversity/ T5 stick)

2015-03-04 Thread Eric Valette
WARNING: CPU: 0 PID: 172 at /usr/src/linux-3.14.34/drivers/usb/core/urb.c:450 usb_submit_urb+0x297/0x449() [4.133281] usb 2-1: BOGUS urb xfer, pipe 3 != type 1 [4.133285] Modules linked in: dvb_usb_dib0700(+) dib3000mc dib8000 dvb_usb dib0070 dib7000m dib0090 dib7000p dibx000_common nvi

Re: [PATCH/RFC v12 04/19] dt-binding: leds: Add common LED DT bindings macros

2015-03-04 Thread Jacek Anaszewski
On 03/04/2015 05:14 PM, Jacek Anaszewski wrote: Add macros for defining boost mode and trigger type properties of flash LED devices. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- include/dt-bindings/leds/max77693.h | 21 +

[PATCH 3/3] media: atmel-isi: remove mck back compatiable code as we don't need it

2015-03-04 Thread Josh Wu
The master clock should handled by sensor itself. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 32 --- 1 file changed, 32 deletions(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi

[PATCH 2/3] media: atmel-isi: add runtime pm support

2015-03-04 Thread Josh Wu
The runtime pm resume/suspend will enable/disable pclk (ISI peripheral clock). And we need to call rumtime_pm_get/put_sync function to make pm resume/suspend. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 36 --- 1 file changed, 32 insertions

[PATCH 1/3] media: atmel-isi: move the peripheral clock to start/stop_stream() function

2015-03-04 Thread Josh Wu
As the clock_start/stop() use to control the mclk for the sensor not the ISI peripheral clock. So we move them to start/stop_stream() function. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 0/3] media: atmel-isi: rework on the clock part and add runtime pm support

2015-03-04 Thread Josh Wu
This patch series fix the peripheral clock code and enable runtime pm support. Aslo clean up the code which is for the compatiblity of mck. Josh Wu (3): media: atmel-isi: move the peripheral clock to start/stop_stream() function media: atmel-isi: add runtime pm support media: atmel-isi:

cron job: media_tree daily build: WARNINGS

2015-03-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Mar 5 04:00:23 CET 2015 git branch: test git hash: 3d945be05ac1e806af075e9315bc1b3409adae2b gcc versio

[PATCH] am437x: include linux/videodev2.h for expanding BASE_VIDIOC_PRIVATE

2015-03-04 Thread Masatake YAMATO
In am437x-vpfe.h BASE_VIDIOC_PRIVATE is used for making the name of ioctl command(VIDIOC_AM437X_CCDC_CFG). The definition of BASE_VIDIOC_PRIVATE is in linux/videodev2.h. However, linux/videodev2.h is not included in am437x-vpfe.h. As the result an application using has to include both am437x-vpfe.h

[PATCH/RFC v12 18/19] leds: max77693: add support for V4L2 Flash sub-device

2015-03-04 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers/l

[PATCH/RFC v12 09/19] leds: Add support for max77693 mfd flash cell

2015-03-04 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski Sig

[PATCH/RFC v12 16/19] Documentation: leds: Add description of v4l2-flash sub-device

2015-03-04 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 13 + 1 fil

[PATCH/RFC v12 10/19] DT: Add documentation for the mfd Maxim max77693

2015-03-04 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Lee Jones Cc: Chanwoo Choi Cc: Bryan Wu Cc: Richard Purdie --- Documentation/devicetre

[PATCH/RFC v12 00/19] LED / flash API integration

2015-03-04 Thread Jacek Anaszewski
This patch set is a follow-up of the LED / flash API integration series [1]. It is based on linux-next_20150304 Changes since version 11 : - removed synchronized strobe feature from LED Flash class, as it turned out to be not fitting for sysfs i

[PATCH/RFC v12 12/19] of: Add Skyworks Solutions, Inc. vendor prefix

2015-03-04 Thread Jacek Anaszewski
Use "skyworks" as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Doc

[PATCH/RFC v12 05/19] mfd: max77693: Modify flash cell name identifiers

2015-03-04 Thread Jacek Anaszewski
Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Lee Jones --- drivers/mfd/max77693.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mf

[PATCH/RFC v12 02/19] leds: flash: document sysfs interface

2015-03-04 Thread Jacek Anaszewski
Add a documentation of LED Flash class specific sysfs attributes. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/ABI/testing/sysfs-class-led-flash | 80 +++ 1 file changed, 80 insertions(+) create mode 100644 Do

[PATCH/RFC v12 04/19] dt-binding: leds: Add common LED DT bindings macros

2015-03-04 Thread Jacek Anaszewski
Add macros for defining boost mode and trigger type properties of flash LED devices. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- include/dt-bindings/leds/max77693.h | 21 + 1 file changed, 21 insertions(+) create mode 1006

[PATCH/RFC v12 14/19] exynos4-is: Add support for v4l2-flash subdevs

2015-03-04 Thread Jacek Anaszewski
This patch adds support for external v4l2-flash devices. The support includes parsing "flashes" DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-dev.c | 36 +

[PATCH/RFC v12 07/19] mfd: max77693: add TORCH_IOUT_MASK macro

2015-03-04 Thread Jacek Anaszewski
Add a macro for obtaining the mask of ITORCH register bit fields related either to FLED1 or FLED2 current output. The expected arguments are TORCH_IOUT1_SHIFT or TORCH_IOUT2_SHIFT. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Chanwoo Choi Cc: Lee Jones --- include/linux/mfd/max

[PATCH/RFC v12 01/19] leds: flash: Remove synchronized flash strobe feature

2015-03-04 Thread Jacek Anaszewski
Synchronized flash strobe feature has been considered not fitting for LED subsystem sysfs interface and thus is being removed. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/led-class-flash.c | 82 ---

[PATCH/RFC v12 17/19] DT: Add documentation for exynos4-is 'flashes' property

2015-03-04 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- .../devicetree/bindings/media/samsung-fimc.txt |8 1 file changed, 8 insertions(+) diff --git a/Documentation/device

[PATCH/RFC v12 03/19] Documentation: leds: Add description of LED Flash class extension

2015-03-04 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 22 ++ 1 file changed

[PATCH/RFC v12 11/19] leds: Add driver for AAT1290 current regulator

2015-03-04 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/Kconfig|

[PATCH/RFC v12 15/19] media: Add registration helpers for V4L2 flash sub-devices

2015-03-04 Thread Jacek Anaszewski
This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled in the kernel config the functions' empty versions will be used

[PATCH/RFC v12 06/19] mfd: max77693: Remove struct max77693_led_platform_data

2015-03-04 Thread Jacek Anaszewski
The flash part of the max77693 device will depend only on OF, and thus will not use board files. Since there are no other users of the struct max77693_led_platform_data its existence is unjustified. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Chanwoo Choi Cc: Lee Jones --- inc

[PATCH/RFC v12 08/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-03-04 Thread Jacek Anaszewski
Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2) from leds-max77693 driver. Previous definitions were compatible with one of the previous RFC versions of leds-max77693.c driver, which was not merged. Signed-off-by:

[PATCH/RFC v12 19/19] leds: aat1290: add support for V4L2 Flash sub-device

2015-03-04 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers/le

[PATCH/RFC v12 13/19] DT: Add documentation for the Skyworks AAT1290

2015-03-04 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- .../devicetree/bindings/leds/leds-aat1290.txt | 64 1 file changed, 64 i

Re: [PATCH v6 6/8] v4l: xilinx: Add Xilinx Video IP core

2015-03-04 Thread Hans Verkuil
Hi Laurent, Almost OK :-) Two small issues remain, see below. On 03/04/15 15:51, Laurent Pinchart wrote: > Xilinx platforms have no hardwired video capture or video processing > interface. Users create capture and memory to memory processing > pipelines in the FPGA fabric to suit their particula

Re: HVR2205 / HVR2255 support

2015-03-04 Thread Steven Toth
>> Mauro, what's the plan to pull the LGDT3306A branch into tip? The >> SAA7164/HVR2255 driver need this for demod support. > > Merged yesterday. Today, I added one fix from Olli to extend the > si2157 minimal frequency to match the ATSC tuner range (needed by > HVR-955Q - not sure if HVR2255 also

Re: HVR2205 / HVR2255 support

2015-03-04 Thread Steven Toth
On Wed, Mar 4, 2015 at 9:03 AM, Olli Salonen wrote: > Hello Steven, > > Great to hear! The LGDT3306A went into the media_tree yesterday as far > as I can see, together with my HVR-955Q patches. Oh, great. > > Coincidentally, I've been working with HVR-2205 and HVR-2215 as well > and have looked

Re: [PATCHv2 1/8] v4l2-subdev: replace v4l2_subdev_fh by v4l2_subdev_pad_config

2015-03-04 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Wednesday 04 March 2015 10:47:54 Hans Verkuil wrote: > From: Hans Verkuil > > If a subdevice pad op is called from a bridge driver, then there is > no v4l2_subdev_fh struct that can be passed to the subdevice. This > made it hard to use such subdevs from a b

Re: [PATCHv2 1/8] v4l2-subdev: replace v4l2_subdev_fh by v4l2_subdev_pad_config

2015-03-04 Thread Hans Verkuil
Hi Laurent, On 03/04/15 16:02, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Wednesday 04 March 2015 10:47:54 Hans Verkuil wrote: >> From: Hans Verkuil >> >> If a subdevice pad op is called from a bridge driver, then there is >> no v4l2_subdev_fh struct that can be pass

[PATCH v6 5/8] v4l: of: Add v4l2_of_parse_link() function

2015-03-04 Thread Laurent Pinchart
The function fills a link data structure with the device node and port number at both the local and remote ends of a link defined by one of its endpoint nodes. Signed-off-by: Laurent Pinchart Acked-by: Hans Verkuil Acked-by: Sakari Ailus Acked-by: Sylwester Nawrocki --- Cc: Sylwester Nawrock

[PATCH v6 4/8] v4l: Add VUY8 24 bits bus format

2015-03-04 Thread Laurent Pinchart
From: Hyun Kwon Add VUY8 24 bits bus format, V4L2_MBUS_FMT_VUY8_1X24. Signed-off-by: Hyun Kwon Signed-off-by: Laurent Pinchart Acked-by: Hans Verkuil --- Documentation/DocBook/media/v4l/subdev-formats.xml | 30 ++ include/uapi/linux/media-bus-format.h | 3 ++

[PATCH v6 7/8] v4l: xilinx: Add Video Timing Controller driver

2015-03-04 Thread Laurent Pinchart
The Video Timing Controller (VTC) includes a timing detector and/or a timing generator. Only the generator is currently supported. Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Acked-by: Hans Verkuil --- Cc: devicet...@vger.kernel.org Changes since v3: - Use xvip_init_resource

[PATCH v6 6/8] v4l: xilinx: Add Xilinx Video IP core

2015-03-04 Thread Laurent Pinchart
Xilinx platforms have no hardwired video capture or video processing interface. Users create capture and memory to memory processing pipelines in the FPGA fabric to suit their particular needs, by instantiating video IP cores from a large library. The Xilinx Video IP core is a framework that model

[PATCH v6 2/8] v4l: Add RBG and RGB 8:8:8 media bus formats on 24 and 32 bit busses

2015-03-04 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart Acked-by: Hans Verkuil --- Documentation/DocBook/media/v4l/subdev-formats.xml | 67 ++ include/uapi/linux/media-bus-format.h | 4 +- 2 files changed, 70 insertions(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/su

[PATCH v6 0/8] Xilinx Video IP Core support

2015-03-04 Thread Laurent Pinchart
Hello, lo and behold, here's the sixth, latest, greatest and most amazing ever (so far) version of the Xilinx FPGA Video IP Cores kernel drivers. I won't detail in great lengths the Xilinx Video IP architecture here, as that would result in dozens of pages of documentation. The interested reader

[PATCH v6 8/8] v4l: xilinx: Add Test Pattern Generator driver

2015-03-04 Thread Laurent Pinchart
The TPG generates multiple static or dynamic test patterns. The driver currently hardcodes the pattern to the moving box pattern. Signed-off-by: Christian Kohn Signed-off-by: Hyun Kwon Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Acked-by: Hans Verkuil --- Cc: devicet...@vger

[PATCH v6 1/8] media: entity: Document the media_entity_ops structure

2015-03-04 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart Acked-by: Hans Verkuil Acked-by: Sakari Ailus --- include/media/media-entity.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/media/media-entity.h b/include/media/media-entity.h index d6d74bc..0c003d8 100644 --- a/include/media/media-entity.

[PATCH v6 3/8] v4l: Sort YUV formats of v4l2_mbus_pixelcode

2015-03-04 Thread Laurent Pinchart
From: Hyun Kwon Keep the formats sorted by type, bus_width, bits per component, samples per pixel and order of subsamples, in that order. Signed-off-by: Hyun Kwon Signed-off-by: Laurent Pinchart Acked-by: Hans Verkuil --- Documentation/DocBook/media/v4l/subdev-formats.xml | 600 ++---

Re: [PATCH 6/7] v4l2-subdev: remove enum_framesizes/intervals

2015-03-04 Thread Jonathan Corbet
On Wed, 04 Mar 2015 09:47:47 +0100 Hans Verkuil wrote: > It took blood, sweat and a bucket full of tears, but I finally managed to > get it to run on a OLPC XO-1 laptop. Sorry you had to do that. I've been trying to find a moment to employ my own bucket, but life remains rather unsettled in the

Re: HVR2205 / HVR2255 support

2015-03-04 Thread Mauro Carvalho Chehab
Em Wed, 4 Mar 2015 08:43:24 -0500 Steven Toth escreveu: > Mauro, what's the plan to pull the LGDT3306A branch into tip? The > SAA7164/HVR2255 driver need this for demod support. Merged yesterday. Today, I added one fix from Olli to extend the si2157 minimal frequency to match the ATSC tuner ran

Re: HVR2205 / HVR2255 support

2015-03-04 Thread Olli Salonen
Hello Steven, Great to hear! The LGDT3306A went into the media_tree yesterday as far as I can see, together with my HVR-955Q patches. Coincidentally, I've been working with HVR-2205 and HVR-2215 as well and have looked into the HVR-2255 a bit too. I'll also be travelling (luckily on leisure) for

[PATCH 2/2] media: s5p-mfc: fix broken pointer cast on 64bit arch

2015-03-04 Thread Marek Szyprowski
Unsigned int cannot be used to store casted pointer on 64bit architecture, so correct such casts to properly use unsigned long variables. Signed-off-by: Marek Szyprowski --- drivers/media/platform/s5p-mfc/s5p_mfc_opr.h| 2 +- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 2 +- drivers/me

[PATCH 0/2] Fix s5p-mfc driver for ARM64

2015-03-04 Thread Marek Szyprowski
Hello, This patch series fixes issues in s5p-mfc driver related to false assumption that driver will be used only on 32bit architectures. With those fixes and respective IOMMU driver one can use this driver on ARM64-based Exynos SoCs, like Exynos 5433. Best regards Marek Szyprowski Samsung Poland

[PATCH 1/2] media: s5p-mfc: fix mmap support for 64bit arch

2015-03-04 Thread Marek Szyprowski
TASK_SIZE is depends on the systems architecture (32 or 64 bits) and it should not be used for defining offset boundary for mmaping buffers for CAPTURE and OUTPUT queues. This patch fixes support for MMAP calls on the CAPTURE queue on 64bit architectures (like ARM64). Signed-off-by: Marek Szyprows

HVR2205 / HVR2255 support

2015-03-04 Thread Steven Toth
Mauro, what's the plan to pull the LGDT3306A branch into tip? The SAA7164/HVR2255 driver need this for demod support. Hey folks, an update on this. So I have the green-light to release my HVR2205 and HVR2255 board related patches. I started merging them into tip earlier this week. The HVR2205 is

Re: [PATCH v5 6/8] v4l: xilinx: Add Xilinx Video IP core

2015-03-04 Thread Laurent Pinchart
Hi Hans, On Wednesday 04 March 2015 10:30:40 Hans Verkuil wrote: > On 03/03/15 23:15, Laurent Pinchart wrote: > > On Tuesday 03 March 2015 12:28:24 Hans Verkuil wrote: > >> On 03/02/2015 02:48 AM, Laurent Pinchart wrote: > >>> Xilinx platforms have no hardwired video capture or video processing >

Re: [PATCHv2 6/8] DocBook media: document the new 'which' field.

2015-03-04 Thread Sylwester Nawrocki
On 04/03/15 10:47, Hans Verkuil wrote: > From: Hans Verkuil > > The subdev enum ioctls now have a new 'which' field. Document this. > > Signed-off-by: Hans Verkuil > Acked-by: Lad, Prabhakar > Acked-by: Laurent Pinchart Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send th

Re: [PATCHv2 3/8] v4l2-subdev.c: add 'which' checks for enum ops.

2015-03-04 Thread Sylwester Nawrocki
On 04/03/15 10:47, Hans Verkuil wrote: > From: Hans Verkuil > > Return an error if an invalid 'which' valid is passed in. > > Signed-off-by: Hans Verkuil > Acked-by: Lad, Prabhakar > Tested-by: Lad, Prabhakar > Acked-by: Laurent Pinchart Acked-by: Sylwester Nawrocki -- To unsubscribe from

Re: [PATCHv2 1/8] v4l2-subdev: replace v4l2_subdev_fh by v4l2_subdev_pad_config

2015-03-04 Thread Sylwester Nawrocki
On 04/03/15 10:47, Hans Verkuil wrote: > From: Hans Verkuil > > If a subdevice pad op is called from a bridge driver, then there is > no v4l2_subdev_fh struct that can be passed to the subdevice. This > made it hard to use such subdevs from a bridge driver. > > This patch replaces the v4l2_subde

Re: [PATCHv2 2/8] v4l2-subdev.h: add 'which' field for the enum structs

2015-03-04 Thread Sylwester Nawrocki
On 04/03/15 10:47, Hans Verkuil wrote: > From: Hans Verkuil > > While all other pad ops allow you to select whether to use the 'try' or > the 'active' formats, the enum ops didn't have that option and always used > 'try'. > > However, this will fail if a simple (e.g. PCI) bridge driver wants to

Re: [PATCHv2 5/8] v4l2-subdev: add support for the new enum_frame_size 'which' field.

2015-03-04 Thread Sylwester Nawrocki
Hi Hans, On 04/03/15 10:47, Hans Verkuil wrote: > From: Hans Verkuil > > Support the new 'which' field in the enum_frame_size ops. Most drivers do not > need to be changed since they always returns the same enumeration regardless > of the 'which' field. > > Signed-off-by: Hans Verkuil > Acked-

Re: [PATCHv2 8/8] v4l2-subdev: remove enum_framesizes/intervals

2015-03-04 Thread Sakari Ailus
On Wed, Mar 04, 2015 at 10:48:01AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The video and pad ops are duplicates, so get rid of the more limited video op. > > The whole point of the subdev API is to allow reuse of subdev drivers by > bridge drivers. Having duplicate ops makes that muc

Re: [PATCHv2 6/8] DocBook media: document the new 'which' field.

2015-03-04 Thread Sakari Ailus
On Wed, Mar 04, 2015 at 10:47:59AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The subdev enum ioctls now have a new 'which' field. Document this. > > Signed-off-by: Hans Verkuil > Acked-by: Lad, Prabhakar > Acked-by: Laurent Pinchart Acked-by: Sakari Ailus -- Sakari Ailus e-mail:

Re: [Linux-kernel] RFC: supporting adv7604.c under soc_camera/rcar_vin

2015-03-04 Thread Hans Verkuil
On 03/04/15 10:51, William Towle wrote: > > Hi all, > > I would like to develop a point in my previous discussion based on > new findings: > > On Thu, 29 Jan 2015, William Towle wrote: >> 3. Our third problem concerns detecting the resolution of the stream. >> Our code works with the obsoleted

Re: [Linux-kernel] RFC: supporting adv7604.c under soc_camera/rcar_vin

2015-03-04 Thread William Towle
Hi all, I would like to develop a point in my previous discussion based on new findings: On Thu, 29 Jan 2015, William Towle wrote: 3. Our third problem concerns detecting the resolution of the stream. Our code works with the obsoleted driver (adv761x.c) in place, but with our modifications t

[PATCHv2 7/8] v4l2-subdev: add support for the new enum_frame_interval 'which' field.

2015-03-04 Thread Hans Verkuil
From: Hans Verkuil Support the new 'which' field in the enum_frame_interval ops. Most drivers do not need to be changed since they always returns the same enumeration regardless of the 'which' field. Tested for ov7670 and marvell-ccic on a OLPC XO-1 laptop. Signed-off-by: Hans Verkuil Cc: Jon

[PATCHv2 5/8] v4l2-subdev: add support for the new enum_frame_size 'which' field.

2015-03-04 Thread Hans Verkuil
From: Hans Verkuil Support the new 'which' field in the enum_frame_size ops. Most drivers do not need to be changed since they always returns the same enumeration regardless of the 'which' field. Signed-off-by: Hans Verkuil Acked-by: Lad, Prabhakar Tested-by: Lad, Prabhakar Cc: Sylwester Nawr

[PATCHv2 8/8] v4l2-subdev: remove enum_framesizes/intervals

2015-03-04 Thread Hans Verkuil
From: Hans Verkuil The video and pad ops are duplicates, so get rid of the more limited video op. The whole point of the subdev API is to allow reuse of subdev drivers by bridge drivers. Having duplicate ops makes that much harder. We should never have allowed duplicate ops in the first place. A

[PATCHv2 4/8] v4l2-subdev: support new 'which' field in enum_mbus_code

2015-03-04 Thread Hans Verkuil
From: Hans Verkuil Support the new 'which' field in the enum_mbus_code ops. Most drivers do not need to be changed since they always return the same enumeration regardless of the 'which' field. Signed-off-by: Hans Verkuil Acked-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/

[PATCHv2 6/8] DocBook media: document the new 'which' field.

2015-03-04 Thread Hans Verkuil
From: Hans Verkuil The subdev enum ioctls now have a new 'which' field. Document this. Signed-off-by: Hans Verkuil Acked-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- .../DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml | 13 + .../DocBook/media/v4l/vidioc-subdev-enum-

[PATCHv2 3/8] v4l2-subdev.c: add 'which' checks for enum ops.

2015-03-04 Thread Hans Verkuil
From: Hans Verkuil Return an error if an invalid 'which' valid is passed in. Signed-off-by: Hans Verkuil Acked-by: Lad, Prabhakar Tested-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/v4l2-core/v4l2-subdev.c | 12 1 file changed, 12 insertions(+) diff --git a/

[PATCHv2 0/8] v4l2-subdev: removal of duplicate video enum ops

2015-03-04 Thread Hans Verkuil
From: Hans Verkuil This patch series is based on this v1 series: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/87869 Changes for v2: - am437 needed to set 'which' to ACTIVE in patches 4 and 5, this was missing. - The comment of the new v4l2_subdev_pad_config struct h

[PATCHv2 2/8] v4l2-subdev.h: add 'which' field for the enum structs

2015-03-04 Thread Hans Verkuil
From: Hans Verkuil While all other pad ops allow you to select whether to use the 'try' or the 'active' formats, the enum ops didn't have that option and always used 'try'. However, this will fail if a simple (e.g. PCI) bridge driver wants to use the enum pad op of a subdev that's also used in a

Re: [PATCH v5 6/8] v4l: xilinx: Add Xilinx Video IP core

2015-03-04 Thread Hans Verkuil
On 03/03/15 23:15, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the review. > > On Tuesday 03 March 2015 12:28:24 Hans Verkuil wrote: >> Hi Laurent, >> >> Thanks for this patch. I do have a few comments, see below. Note that I am >> OK with the new DT format description. >> >> On 03/02/20

Re: [GIT PULL FOR v4.1] v4l2-subdev: removal of duplicate video enum ops

2015-03-04 Thread Hans Verkuil
On 03/03/15 16:56, Hans Verkuil wrote: > Hi Mauro, > > This patch series prepares for the removal of duplicate video enum ops. See > this > post for the background for this series: > > http://permalink.gmane.org/gmane.linux.drivers.video-input-infrastructure/87869 > > The patches in this pull r

Re: [PATCH 6/7] v4l2-subdev: remove enum_framesizes/intervals

2015-03-04 Thread Hans Verkuil
On 02/13/15 12:30, Hans Verkuil wrote: > From: Hans Verkuil > > Replace the video ops enum_framesizes and enum_frameintervals by the pad > ops enum_frame_size and enum_frame_interval. > > The video and pad ops are duplicates, so get rid of the more limited video op. > > The whole point of the s