Re: [PATCH 01/13] go7007: don't use vb before test if it is not NULL

2015-04-29 Thread Hans Verkuil
On 04/29/2015 01:04 AM, Mauro Carvalho Chehab wrote: > As reported by smatch: > drivers/media/usb/go7007/go7007-driver.c:452 frame_boundary() warn: > variable dereferenced before check 'vb' (see line 449) > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/

Re: [PATCH 09/14] zoran: fix indent

2015-04-29 Thread Hans Verkuil
On 04/28/2015 05:43 PM, Mauro Carvalho Chehab wrote: > As reported by smatch: > drivers/media/pci/zoran/zoran_device.c:1594 zoran_init_hardware() warn: > inconsistent indenting > > Fix indent. While here, fix CodingStyle and remove dead code, as it > can always be recovered from git logs. >

Re: [PATCH 13/13] vivid-radio-rx: Don't go past buffer

2015-04-29 Thread Hans Verkuil
On 04/29/2015 01:06 AM, Mauro Carvalho Chehab wrote: > drivers/media/platform/vivid/vivid-radio-rx.c:198 > vivid_radio_rx_s_hw_freq_seek() error: buffer overflow 'vivid_radio_bands' 3 > <= 3 > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/drivers/media/platf

Re: [PATCH 05/14] saa7164: Check if dev is NULL before dereferencing it

2015-04-29 Thread Hans Verkuil
On 04/28/2015 05:43 PM, Mauro Carvalho Chehab wrote: > As reported by smatch: > drivers/media/pci/saa7164/saa7164-core.c:631 saa7164_irq() warn: > variable dereferenced before check 'dev' (see line 621) > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/dr

Re: [PATCH 03/14] saa7134: fix indent issues

2015-04-29 Thread Hans Verkuil
On 04/28/2015 05:43 PM, Mauro Carvalho Chehab wrote: > As reported by smatch: > drivers/media/pci/saa7134/saa7134-cards.c:7197 > saa7134_xc2028_callback() warn: inconsistent indenting > drivers/media/pci/saa7134/saa7134-cards.c:7846 saa7134_board_init2() > warn: inconsistent indenting

Re: [PATCH 25/27] usbvision: fix bad indentation

2015-04-29 Thread Hans Verkuil
On 04/30/2015 01:06 AM, Mauro Carvalho Chehab wrote: > drivers/media/usb/usbvision/usbvision-core.c:2395 usbvision_init_isoc() warn: > inconsistent indenting > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/drivers/media/usb/usbvision/usbvision-core.c > b/dri

cron job: media_tree daily build: ERRORS

2015-04-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Apr 30 04:00:16 CEST 2015 git branch: test git hash: bb17141cc57c40065462c64d61c0ae362466c0c0 gcc versi

Re: DVB-T scan tables for es-Vitoria-Gasteiz, es-All and channels.conf for Vitoria-Gasteiz

2015-04-29 Thread David Santamaría Rogado
The channels file has get into the mail body. [La 1] SERVICE_ID = 560 ... ... ... TRANSMISSION_MODE = 8K HIERARCHY = NONE DELIVERY_SYSTEM = DVBT [Radio Vitoria] SERVICE_ID = 1264 AUDIO_PID = 7004 FREQUENCY = 77000 MODULATION = QAM/64 BANDWIDTH_HZ = 800

DVB-T scan tables for es-Vitoria-Gasteiz, es-All and channels.conf for Vitoria-Gasteiz

2015-04-29 Thread David Santamaría Rogado
Attached the following files: es-All DVB-T scan table contains all the frequencies used in Spain for DVB-T, perhaps it could server as All for every Europe country if someone adds also the DVB-T2 configuration inside this one as I think the spectrum for digital television in all Europe in now the

[PATCH 04/27] r820t: fix identing

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/tuners/r820t.c:945 r820t_sysfreq_sel() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index 71159a58860f..a7a8452e99d2 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r

[PATCH 25/27] usbvision: fix bad indentation

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/usb/usbvision/usbvision-core.c:2395 usbvision_init_isoc() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-core.c index 44b0c28d69b6..7c04ef697fb6 100644 --- a/drive

[PATCH 26/27] saa7134: fix bad indenting

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/pci/saa7134/saa7134-dvb.c:1682 dvb_init() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/pci/saa7134/saa7134-dvb.c b/drivers/media/pci/saa7134/saa7134-dvb.c index 73ffbabf831c..bcfebd56fa2b 100644 --- a/drivers/media/pci/saa7134/saa71

[PATCH 14/27] redrat3: change return argument on redrat3_send_cmd() to int

2015-04-29 Thread Mauro Carvalho Chehab
redrat3_send_cmd() can return an error or the read data. However, it currently returns an u8, as reported by smatch: drivers/media/rc/redrat3.c:416 redrat3_send_cmd() warn: signedness bug returning '(-12)' Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/rc/redrat3.c b/dr

[PATCH 07/27] stv0297: change typecast to u64 to avoid smatch warnings

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/stv0297.c:140 stv0297_get_symbolrate() warn: should 'stv0297_readreg(state, 86) << 8' be a 64 bit type? drivers/media/dvb-frontends/stv0297.c:141 stv0297_get_symbolrate() warn: should 'stv0297_readreg(state, 87) << 16' be a 64 bit type? drivers/media/dvb-frontends/stv0

[PATCH 13/27] vp702x: comment dead code

2015-04-29 Thread Mauro Carvalho Chehab
Since the first version of this driver, the remote controller code is disabled, adding an early return inside vp702x_rc_query(). Let's disable the code with #if 0, to remove this warning: drivers/media/usb/dvb-usb/vp702x.c:268 vp702x_rc_query() info: ignoring unreachable code. Signed-off-by: Ma

[PATCH 09/27] cx231xx: fix bad indenting

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/usb/cx231xx/cx231xx-avcore.c:1598 cx231xx_set_DIF_bandpass() warn: inconsistent indenting drivers/media/usb/cx231xx/cx231xx-core.c:656 cx231xx_demod_reset() warn: inconsistent indenting drivers/media/usb/cx231xx/cx231xx-core.c:659 cx231xx_demod_reset() warn: inconsistent indenting

[PATCH 06/27] zl10353: fix indenting

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/zl10353.c:536 zl10353_read_ucblocks() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-frontends/zl10353.c b/drivers/media/dvb-frontends/zl10353.c index 82946cd517f5..4e62a6611847 100644 --- a/drivers/media/dvb-fronten

[PATCH 24/27] s5p-mfc: fix bad indentation

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:187 s5p_mfc_alloc_codec_buffers_v5() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c index b09bcd140491..c7adc3d26792

[PATCH 22/27] bttv: fix audio hooks

2015-04-29 Thread Mauro Carvalho Chehab
as reported by smatch: drivers/media/pci/bt8xx/bttv-audio-hook.c:201 lt9415_audio() warn: bitwise AND condition is false here drivers/media/pci/bt8xx/bttv-audio-hook.c:241 winfast2000_audio() warn: bitwise AND condition is false here drivers/media/pci/bt8xx/bttv-audio-hook

[PATCH 01/27] qt1010: avoid going past array

2015-04-29 Thread Mauro Carvalho Chehab
As reported by smatch: drivers/media/tuners/qt1010.c:357 qt1010_init() error: buffer overflow 'i2c_data' 34 <= 34 This should not happen with the current code, as the i2c_data array doesn't end with a QT1010_M1, but it doesn't hurt add a BUG_ON to notify if one modifies it and breaks. Si

[PATCH 15/27] sonixj: fix bad indenting

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/usb/gspca/sonixj.c:1792 expo_adjust() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/gspca/sonixj.c b/drivers/media/usb/gspca/sonixj.c index c69b45d7cfbf..fd1c8706d86a 100644 --- a/drivers/media/usb/gspca/sonixj.c +++ b/drivers/medi

[PATCH 11/27] dib0070: Fix indenting

2015-04-29 Thread Mauro Carvalho Chehab
The indentation on this driver were deadly broken. On lots of places, it was using 4 spaces instead of tab to indent. On other parts, it were using tabs. Also, on several places, it were not even being properly aligned, as reported by smatch: drivers/media/dvb-frontends/dib0070.c:179 dib00

[PATCH 27/27] dib0700: fix bad indentation

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/usb/dvb-usb/dib0700_devices.c:864 dib7770_set_param_override() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/usb/dvb-usb/dib0700_devices.c index d7d55a20e959..90cee380d3aa 100644 --- a/dr

[PATCH 05/27] bttv: fix indenting

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/pci/bt8xx/bttv-driver.c:2679 bttv_s_fbuf() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index bc12060e0882..0f10e051f7fd 100644 --- a/drivers/media/pci/bt8xx/bttv-drive

[PATCH 19/27] stv0900: fix bad indenting

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/stv0900_sw.c:1559 stv0900_search_srate_fine() warn: inconsistent indenting drivers/media/dvb-frontends/stv0900_sw.c:2012 stv0900_algo() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-frontends/stv0900_sw.c b/drivers

[PATCH 08/27] ov7670: check read error also for REG_AECHH on ov7670_s_exp()

2015-04-29 Thread Mauro Carvalho Chehab
ov7670_s_exp() checks read error for 2 registers: REG_COM1 and REG_COM8. But, although it uses the value latter, it doesn't check errors on REG_AECHH read. Yet, as it is doing a bitmask operation there, the read operation should succeed. So, fix the code to also check if this succeeded. This fixe

[PATCH 21/27] tda10086: change typecast to u64 to avoid smatch warnings

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/tda10086.c:476 tda10086_get_frontend() warn: should 'tda10086_read_byte(state, 81) << 8' be a 64 bit type? Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-frontends/tda10086.c b/drivers/media/dvb-frontends/tda10086.c index fcfe2e080cb0..f1a752187

[PATCH 10/27] dib3000mc: fix bad indenting

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/dib3000mc.c:149 dib3000mc_setup_pwm_state() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-frontends/dib3000mc.c b/drivers/media/dvb-frontends/dib3000mc.c index ba5e832eb1d4..a9b8081a0fbc 100644 --- a/drivers/media/d

[PATCH 12/27] go7007: Comment some dead code

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/usb/go7007/go7007-usb.c:1099 go7007_usb_probe() info: ignoring unreachable code. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/go7007/go7007-usb.c b/drivers/media/usb/go7007/go7007-usb.c index 3f986e1178ce..4857c467e76c 100644 --- a/drivers/media/usb/go7007/

[PATCH 17/27] pvrusb2: fix inconsistent indenting

2015-04-29 Thread Mauro Carvalho Chehab
smatch complains about multiple issues here: drivers/media/usb/pvrusb2/pvrusb2-context.c:402 pvr2_channel_claim_stream() warn: inconsistent indenting drivers/media/usb/pvrusb2/pvrusb2-ioread.c:240 pvr2_ioread_setup() warn: inconsistent indenting drivers/media/usb/pvrusb2/p

[PATCH 23/27] ttusb-dec: fix bad indentation

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/usb/ttusb-dec/ttusb_dec.c:1434 ttusb_dec_init_stb() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/ttusb-dec/ttusb_dec.c b/drivers/media/usb/ttusb-dec/ttusb_dec.c index 15ab584cf265..322b53a4f1dd 100644 --- a/drivers/media/usb/ttu

[PATCH 18/27] cx25840: fix bad identing

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/i2c/cx25840/cx25840-core.c:974 input_change() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c index bd496447749a..18e3615737f2 100644 --- a/drivers/media/i2c/cx25840

[PATCH 02/27] mantis: remove dead code

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/pci/mantis/mantis_cards.c:229 mantis_pci_probe() info: ignoring unreachable code. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/pci/mantis/mantis_cards.c b/drivers/media/pci/mantis/mantis_cards.c index 801fc55b6167..f437646aa9aa 100644 --- a/drivers/media/pci/ma

[PATCH 16/27] stk014: fix bad indenting

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/usb/gspca/stk014.c:279 sd_start() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/gspca/stk014.c b/drivers/media/usb/gspca/stk014.c index b0c70fea760b..d324d001e114 100644 --- a/drivers/media/usb/gspca/stk014.c +++ b/drivers/media/us

[PATCH 20/27] s5h1420: use only one statement per line

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/s5h1420.c:565 s5h1420_setfec_inversion() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-frontends/s5h1420.c b/drivers/media/dvb-frontends/s5h1420.c index 0b4f8fe6bf99..dfc20665e372 100644 --- a/drivers/media/dvb-fron

[PATCH 03/27] tda1004x: fix identation

2015-04-29 Thread Mauro Carvalho Chehab
drivers/media/dvb-frontends/tda1004x.c:653 tda10046_init() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-frontends/tda1004x.c b/drivers/media/dvb-frontends/tda1004x.c index a2631be7ffac..d2b8ecbea81e 100644 --- a/drivers/media/dvb-frontends/td

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-04-29 Thread Sergei Shtylyov
Hello. On 04/30/2015 12:59 AM, Sergei Shtylyov wrote: Here's the the driver for the Renesas R-Car JPEG processing unit driver. One "the" is enough. And one "driver" too, you probbaly forgot to remove the word at the end. The driver is implemented within the V4L2 framework as a mem-to-

[PATCH v4 6/8] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-04-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. In order to h

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-04-29 Thread Sergei Shtylyov
On 04/30/2015 12:53 AM, Mikhail Ulyanov wrote: Here's the the driver for the Renesas R-Car JPEG processing unit driver. One "the" is enough. And one "driver" too, you probbaly forgot to remove the word at the end. The driver is implemented within the V4L2 framework as a mem-to-mem devic

[PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-04-29 Thread Mikhail Ulyanov
Here's the the driver for the Renesas R-Car JPEG processing unit driver. The driver is implemented within the V4L2 framework as a mem-to-mem device. It presents two video nodes to userspace, one for the encoding part, and one for the decoding part. It was found that the only working mode for enc

Re: [PATCH/RFC] v4l: vsp1: Fix Suspend-to-RAM

2015-04-29 Thread Laurent Pinchart
Hello Kaneko-san, I'm so sorry for the very late reply, I had missed your patch :-/ First of all, thank you for the patch. Please see below for a few comments. On Sunday 15 March 2015 23:33:07 Yoshihiro Kaneko wrote: > From: Sei Fumizono > > Fix Suspend-to-RAM > so that VSP1 driver continues t

[RFC PATCH 3/4] adv7604: Use interlaced info for cvt/gtf timing detection

2015-04-29 Thread Prashant Laddha
The interlaced information from stdi is passed to detect_cvt/gtf(). These functions now supports timing calculations for interlaced format. Cc: Hans Verkuil Cc: Martin Bugge Cc: Mats Randgaard Cc: Laurent Pinchart Signed-off-by: Prashant Laddha --- drivers/media/i2c/adv7604.c | 4 ++-- 1 fil

[RFC PATCH 1/4] v4l2-dv-timings: Add interlace support in detect cvt/gtf

2015-04-29 Thread Prashant Laddha
Extended detect_cvt/gtf API to indicate the format type (interlaced or progressive). In case of interlaced, the vertical front and back porch and vsync values for both (odd,even) fields are considered to derive image height. Populated vsync, verical front, back porch values in bt timing structure f

[RFC PATCH 0/4] Support for interlaced in cvt/gtf timings

2015-04-29 Thread Prashant Laddha
Currently, detect_cvt/gtf() functions in v4l2-dv-timings do not calculate timings for interlaced format. Besides the set-dv-bt-timings control in vivid, drivers for adv7604 and adv7842 may also need cvt/gtf timings for interlaced format. This patch series is a proposal for adding interlaced support

[RFC PATCH 4/4] adv7842: Use interlaced info for cvt/gtf timing detection

2015-04-29 Thread Prashant Laddha
The interlaced information from stdi is passed to detect_cvt/gtf(). Cc: Hans Verkuil Cc: Martin Bugge Cc: Mats Randgaard Cc: Laurent Pinchart Signed-off-by: Prashant Laddha --- drivers/media/i2c/adv7842.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i

[RFC PATCH 2/4] vivid: Use interlaced info for cvt/gtf timing detection

2015-04-29 Thread Prashant Laddha
The detect_cvt/gtf() now supports timing calculations for interlaced format. Cc: Hans Verkuil Signed-off-by: Prashant Laddha --- drivers/media/platform/vivid/vivid-vid-cap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c b/d

[PATCH/RFC] v4l: vsp1: Align crop rectangle to even boundary for YUV formats

2015-04-29 Thread Yoshihiro Kaneko
From: Damian Hobson-Garcia Make sure that there are valid values in the crop rectangle to ensure that the color plane doesn't get shifted when cropping. Since there is no distintion between 12bit and 16bit YUV formats in at the subdev level, use the more restrictive 12bit limits for all YUV forma

[PATCHv2 3/5] si2157: support selection of IF interface

2015-04-29 Thread Olli Salonen
The chips supported by the si2157 driver have two IF outputs (either pins 12+13 or pins 9+11). Instead of hardcoding the output to be used add an option to choose which output shall be used. As this patch changes the default behaviour, the IF interface is specified in each driver currently using s

[PATCHv2 2/5] dvbsky: use si2168 config option ts_clock_gapped

2015-04-29 Thread Olli Salonen
Change the dvbsky driver to support gapped clock instead of the current hack. Signed-off-by: Olli Salonen --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c

[PATCHv2 4/5] rtl28xxu: add I2C read without write

2015-04-29 Thread Olli Salonen
Add support for I2C read operation without a preceeding write. While here, change the error code to EOPNOTSUPP in case an unsupported I2C operation is attempted. Signed-off-by: Olli Salonen --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

[PATCHv2 5/5] rtl2832: add support for GoTView MasterHD 3 USB tuner

2015-04-29 Thread Olli Salonen
GoTView MasterHD 3 is a DVB-T2/C USB 2.0 tuner. It's based on the following components: - USB bridge: RTL2832P (contains also DVB-T demodulator) - Demodulator: Si2168-A30 - Tuner: Si2148-A20 The demodulator and the tuner will need firmwares. The Si2148 uses Si2158 firmware. Antti has the firmware

[PATCHv2 1/5] si2168: add support for gapped clock

2015-04-29 Thread Olli Salonen
Add a parameter in si2168_config to support gapped clock. This might be necessary on some devices with higher bitrates. Signed-off-by: Olli Salonen --- drivers/media/dvb-frontends/si2168.c | 3 +++ drivers/media/dvb-frontends/si2168.h | 3 +++ drivers/media/dvb-frontends/si2168_priv.h

Re: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface

2015-04-29 Thread Emil Velikov
Hi Kamil, Allow me to put a few suggestions: On 29 April 2015 at 11:02, Kamil Debski wrote: > This is the first version of the libGenCEC library. It was designed to > act as an interface between the generic CEC kernel API and userspace > applications. It provides a simple interface for applicati

Re: [PATCH v5 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-29 Thread Lee Jones
On Wed, 29 Apr 2015, Jacek Anaszewski wrote: > On 04/29/2015 02:34 PM, Lee Jones wrote: > >LED Ack please Bryan. > > You've already applied v6 with Bryan's ack today :) Ah, this is the same patch? Jolly good! -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source so

Re: [PATCH v5 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-29 Thread Jacek Anaszewski
On 04/29/2015 02:34 PM, Lee Jones wrote: LED Ack please Bryan. You've already applied v6 with Bryan's ack today :) This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda

Re: S_CTRL must be called twice to set volatile controls

2015-04-29 Thread Jacek Anaszewski
Hi Sakari, On 04/29/2015 02:01 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Apr 29, 2015 at 10:58:20AM +0200, Jacek Anaszewski wrote: Hi Hans, On 04/29/2015 09:53 AM, Hans Verkuil wrote: Hi Jacek, On 04/29/15 09:33, Jacek Anaszewski wrote: Hi, After testing my v4l2-flash helpers patch [1] wi

Re: [PATCH v5 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-29 Thread Lee Jones
LED Ack please Bryan. > This patch adds device tree binding documentation for > the flash cell of the Maxim max77693 multifunctional device. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: Chanwoo Choi > Cc: Bryan Wu > Cc: R

Re: S_CTRL must be called twice to set volatile controls

2015-04-29 Thread Sakari Ailus
Hi Jacek, On Wed, Apr 29, 2015 at 10:58:20AM +0200, Jacek Anaszewski wrote: > Hi Hans, > > On 04/29/2015 09:53 AM, Hans Verkuil wrote: > >Hi Jacek, > > > >On 04/29/15 09:33, Jacek Anaszewski wrote: > >>Hi, > >> > >>After testing my v4l2-flash helpers patch [1] with the recent patches > >>for v4l2

[RESEND PATCH v2 2/3] media/videobuf2-dma-contig: Save output from dma_map_sg

2015-04-29 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda dma_map_sg returns the number of areas mapped by the hardware, which could be different than the areas given as an input. The output must be saved to nent. Signed-off-by: Ricardo Ribalda Delgado Reviewed-by: Marek Szyprowski --- drivers/media/v4l2-core/videobuf2-dma-cont

[RESEND PATCH v2 1/3] media/videobuf2-dma-sg: Fix handling of sg_table structure

2015-04-29 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda When sg_alloc_table_from_pages() does not fail it returns a sg_table structure with nents and nents_orig initialized to the same value. dma_map_sg returns the number of areas mapped by the hardware, which could be different than the areas given as an input. The output must

[RESEND PATCH v2 3/3] media/videobuf2-dma-vmalloc: Save output from dma_map_sg

2015-04-29 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda dma_map_sg returns the number of areas mapped by the hardware, which could be different than the areas given as an input. The output must be saved to nent. Signed-off-by: Ricardo Ribalda Delgado Reviewed-by: Marek Szyprowski --- drivers/media/v4l2-core/videobuf2-vmalloc.

[RESEND PATCH v2 0/3] Fix handling of sg_table struct

2015-04-29 Thread Ricardo Ribalda Delgado
This is just a resend of the previous patches, cherry-picked to the last master media tree. I have also added the Reviewed-by: Marek Thanks Ricardo Ribalda Delgado (3): media/videobuf2-dma-sg: Fix handling of sg_table structure media/videobuf2-dma-contig: Save output from dma_map_sg media/

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-29 Thread Mauro Carvalho Chehab
Em Wed, 29 Apr 2015 13:35:01 +0200 Patrick Boettcher escreveu: > Hi Mauro, > > On Mon, 27 Apr 2015 21:40:22 -0300 Mauro Carvalho Chehab > wrote: > > > Could we send an additional patch for coding-style or would you prefer > > > a new patch which has everything inside? This would maintain the >

Re: [PULL] For 4.2 (or even 4.1?) add support for cx24120/Technisat SkyStar S2

2015-04-29 Thread Patrick Boettcher
Hi Mauro, On Mon, 27 Apr 2015 21:40:22 -0300 Mauro Carvalho Chehab wrote: > > Could we send an additional patch for coding-style or would you prefer > > a new patch which has everything inside? This would maintain the > > author-attribution of the initial commit. > > An additional patch is fine.

[PATCH v5 11/11] DocBook/media: add CEC documentation

2015-04-29 Thread Kamil Debski
From: Hans Verkuil Add DocBook documentation for the CEC API. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: add documentation for passthrough mode] [k.deb...@samsung.com: minor fixes and change of reserved field sizes] Signed-off-by: Kamil Debski --- Documentation/DocBook/media/Makefile

[PATCH] libgencec: Add userspace library for the generic CEC kernel interface

2015-04-29 Thread Kamil Debski
This is the first version of the libGenCEC library. It was designed to act as an interface between the generic CEC kernel API and userspace applications. It provides a simple interface for applications and an example application that can be used to test the CEC functionality. signed-off-by: Kamil

[PATCH v5 09/11] cec: adv7511: add cec support.

2015-04-29 Thread Kamil Debski
From: Hans Verkuil Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- drivers/media/i2c/adv7511.c | 347 ++- include/media/ad

[PATCH v5 06/11] cec: add HDMI CEC framework

2015-04-29 Thread Kamil Debski
From: Hans Verkuil The added HDMI CEC framework provides a generic kernel interface for HDMI CEC devices. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil] [k.deb...@samsung.com: Merged Update author commit by Hans Verkuil] [k.deb...@samsung.com: chan

[PATCH v5 10/11] cec: s5p-cec: Add s5p-cec driver

2015-04-29 Thread Kamil Debski
Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil Debski --- .../devicetree/bindings/media/s5p-cec.txt | 33 +++ drivers/media/platform/Kconfig

[PATCH v5 07/11] v4l2-subdev: add HDMI CEC ops

2015-04-29 Thread Kamil Debski
From: Hans Verkuil Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski --- include/media/v4l2-subdev.h |8 1 file changed, 8 insertions(+) diff --git a/

[PATCH v5 08/11] cec: adv7604: add cec support.

2015-04-29 Thread Kamil Debski
From: Hans Verkuil Add CEC support to the adv7604 driver. Signed-off-by: Hans Verkuil [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] [k.deb...@samsung.com: add missing methods cec/io_write_and_or] [k.deb...@samsung.com: change adv7604 to adv76xx in added function

[PATCH v5 05/11] rc: Add HDMI CEC protoctol handling

2015-04-29 Thread Kamil Debski
Add handling of remote control events coming from the HDMI CEC bus. This patch includes a new keymap that maps values found in the CEC messages to the keys pressed and released. Also, a new protocol has been added to the core. Signed-off-by: Kamil Debski --- drivers/media/rc/keymaps/Makefile |

[PATCH v5 01/11] dts: exynos4*: add HDMI CEC pin definition to pinctrl

2015-04-29 Thread Kamil Debski
Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and Exynos4x12 SoCs. These are required by the HDMI CEC device. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4210-pinctrl.dtsi |7 +++ arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |7 +++ 2 files changed, 14 inse

[PATCH v5 02/11] dts: exynos4: add node for the HDMI CEC device

2015-04-29 Thread Kamil Debski
This patch adds HDMI CEC node specific to the Exynos4210/4x12 SoC series. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index e20cdc2..8776db9 1006

[PATCH v5 04/11] HID: add HDMI CEC specific keycodes

2015-04-29 Thread Kamil Debski
Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski --- include/uapi/linux/input.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 731417c..7430a3f 100644 --- a/include/uapi/linux

[PATCH v5 03/11] dts: exynos4412-odroid*: enable the HDMI CEC device

2015-04-29 Thread Kamil Debski
Add a dts node entry and enable the HDMI CEC device present in the Exynos4 family of SoCs. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/d

[PATCH v5 00/11] HDMI CEC framework

2015-04-29 Thread Kamil Debski
Hi, This is the fifth version of the HDMI CEC framework patches. All the previous version have spun many discussions and quite a few changes. Hopefully, in this version, the code of the framework matured and got closer to meeting our requirements. Again, thank you so much for all the discussion a

Re: [PATCH 10/14] s3c-camif: Check if fmt is NULL before use

2015-04-29 Thread Sylwester Nawrocki
On 28/04/15 17:43, Mauro Carvalho Chehab wrote: > As reported by smatch: > drivers/media/platform/s3c-camif/camif-capture.c:463 queue_setup() > warn: variable dereferenced before check 'fmt' (see line 460) > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Sylwester Nawrocki -- To unsubs

Re: S_CTRL must be called twice to set volatile controls

2015-04-29 Thread Jacek Anaszewski
Hi Hans, On 04/29/2015 09:53 AM, Hans Verkuil wrote: Hi Jacek, On 04/29/15 09:33, Jacek Anaszewski wrote: Hi, After testing my v4l2-flash helpers patch [1] with the recent patches for v4l2-ctrl.c ([2] and [3]) s_ctrl op isn't called despite setting the value that should be aligned to the othe

Re: [PATCH v6 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-29 Thread Lee Jones
On Tue, 28 Apr 2015, Jacek Anaszewski wrote: > This patch adds device tree binding documentation for > the flash cell of the Maxim max77693 multifunctional device. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Acked-by: Sakari Ailus > Cc: Lee J

Re: S_CTRL must be called twice to set volatile controls

2015-04-29 Thread Hans Verkuil
Hi Jacek, On 04/29/15 09:33, Jacek Anaszewski wrote: > Hi, > > After testing my v4l2-flash helpers patch [1] with the recent patches > for v4l2-ctrl.c ([2] and [3]) s_ctrl op isn't called despite setting > the value that should be aligned to the other step than default one. > > This happens for

S_CTRL must be called twice to set volatile controls

2015-04-29 Thread Jacek Anaszewski
Hi, After testing my v4l2-flash helpers patch [1] with the recent patches for v4l2-ctrl.c ([2] and [3]) s_ctrl op isn't called despite setting the value that should be aligned to the other step than default one. This happens for V4L2_CID_FLASH_TORCH_INTENSITY control with V4L2_CTRL_FLAG_VOLATILE