Even easier way to activate dynamic debugging at module load time
(assuming your kernel has dynamic debugging enabled):
modprobe si2168 dyndbg==pmf
Cheers,
-olli
On 4 June 2015 at 21:28, Antti Palosaari cr...@iki.fi wrote:
On 06/04/2015 08:36 PM, Hurda wrote:
How can I enable debug-output
Currently, in gtf hblank calculations, the rounding is used twice,
one at intermediate division and one at final state where hblank
is rounded to nearest multiple of twice cell granularity. This
error got introduced in commit d7ed5a3, where it missed combining
the rounding step. Correcting the
From: Hans Verkuil hans.verk...@cisco.com
VIDIOC_CREATE_BUFS didn't clear the reserved field in the kernel.
Update the documentation so that it is in sync with what v4l2-compliance
checks and what valgrind checks.
Hans Verkuil (2):
v4l2-ioctl: clear the reserved field of v4l2_create_buffers
From: Hans Verkuil hans.verk...@cisco.com
This field was never cleared by the kernel making future extensions
hard to implement. Clear it now.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Make sure that the documentation clearly states who is zeroing reserved
fields: drivers and/or applications.
This patch syncs the documentation with the checks that v4l2-compliance
and valgrind do.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
Currently the colors for the Y16 and Y16_BE pixelformats are in the range
0x-0xff00. So pure white (0x) is never created.
Improve this by making white really white. For other colors the lsb remains 0
so vivid can be used to detect endian problems.
Signed-off-by: Hans Verkuil
The v4l2_print_dv_timings() didn't log the interlaced format correctly. The
timings
for the bottom field weren't logged and the fields per second value was half of
what
it should have been.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
diff --git
Current cvt timing calculation supports reduced blanking (RB) version 1.
This patch adds the support for RB version 2, which was missing.
Compared to RB version 1, RB version 2 differs on different parameters.
This difference is summarized in the document VESA Coordinated Video
Timings Standard
Added support for reduced blanking version 2 (RB v2) in cvt timings.
Standard specifies a fixed vsync pulse of 8 lines to indicate RB v2
timings. Vertical back porch is fixed at 6 lines and vertical front
porch is remainder of vertical blanking time.
For Rb v2, horizontal blanking is fixed at 80
Reviewed-by: Ricardo Ribalda ricardo.riba...@gmail.com
Thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/06/15 00:02, Paul Walmsley wrote:
Hi folks
just a brief comment on this one:
On Thu, 30 Apr 2015, Boris Brezillon wrote:
Clock rates are stored in an unsigned long field, but -round_rate()
(which returns a rounded rate from a requested one) returns a long
value (errors are
Hi Jon,
On Fri, 5 Jun 2015 09:46:09 +0100
Jon Hunter jonath...@nvidia.com wrote:
On 05/06/15 00:02, Paul Walmsley wrote:
Hi folks
just a brief comment on this one:
On Thu, 30 Apr 2015, Boris Brezillon wrote:
Clock rates are stored in an unsigned long field, but -round_rate()
Remove the following compilation warnings:
drivers/media/platform/vivid/vivid-tpg.c: In function 'tpg_gen_text':
drivers/media/platform/vivid/vivid-tpg.c:1562:1: warning: the frame
size of 1308 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^
This
On 06/05/2015 12:25 PM, Antti Palosaari wrote:
On 06/05/2015 12:50 PM, Hans Verkuil wrote:
Hi Antti,
FYI: don't use ATTN as prefix: patchwork doesn't pick that up as a patch,
and if it doesn't appear there, then it is likely to be forgotten.
Can you repost it with the correct prefix? It's
From: Hans Verkuil hans.verk...@cisco.com
This ensures that both do the same checks, and simplifies s_fmt_vid_out
a bit.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 86 +++--
1 file changed, 40 insertions(+), 46
From: Hans Verkuil hans.verk...@cisco.com
Dump the VOU registers in log_status.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/media/platform/sh_vou.c
From: Hans Verkuil hans.verk...@cisco.com
The bytesperline values were wrong for planar formats where bytesperline is
the line length for the first plane.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 11 +--
1 file changed, 9 insertions(+), 2
From: Hans Verkuil hans.verk...@cisco.com
This converts this driver to videobuf2. As usual it is a big and hard to review
patch, but this is always a big-bang change.
It has been tested with my Renesas board.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Tested-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
Bitrot has set in for this driver and the sh-vou.0 clock was never enabled,
so this driver didn't do anything. In addition, the clock was incorrectly
defined in clock-sh7724.c. Fix this.
While we're at it: use proper resource managed calls.
From: Hans Verkuil hans.verk...@cisco.com
It was set to a format that wasn't supported.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sh_vou.c
From: Hans Verkuil hans.verk...@cisco.com
This allows us to drop the use_count and you get free G/S_PRIORITY support.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Fix v4l2-compliance errors due to empty driver and bus_info fields.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/sh_vou.c
From: Hans Verkuil hans.verk...@cisco.com
This driver no longer works and uses old v4l2 frameworks. This patch series
updates the driver so it is once again working and is up to date.
It now passes the v4l2-compliance tests as well.
This has been tested with my Renesas development board.
From: Hans Verkuil hans.verk...@cisco.com
Implement g/s_selection. The v4l2 core will emulate g/s_crop and
cropcap on top of g/s_selection.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 71 +++--
1 file changed, 25
From: Hans Verkuil hans.verk...@cisco.com
Video output drivers must support these ioctls. Otherwise applications
cannot deduce that these outputs exist and what capabilities they have.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 27
On 06/05/2015 12:50 PM, Hans Verkuil wrote:
Hi Antti,
FYI: don't use ATTN as prefix: patchwork doesn't pick that up as a patch,
and if it doesn't appear there, then it is likely to be forgotten.
Can you repost it with the correct prefix? It's so much easier to process
for me if it ends up in
On 06/05/2015 12:29 PM, Mauro Carvalho Chehab wrote:
Remove the following compilation warnings:
drivers/media/platform/vivid/vivid-tpg.c: In function 'tpg_gen_text':
drivers/media/platform/vivid/vivid-tpg.c:1562:1: warning: the frame
size of 1308 bytes is larger than 1024 bytes
Following a change made to TS2020 tuner in patches
ts2020: Provide DVBv5 API signal strength
ts2020: Allow stats polling to be suppressed
Polling on the driver must be suppressed because
the demuxer is stopped by I2C messages.
Signed-off-by: Malcolm Priestley tvbox...@gmail.com
---
On 06/02/2015 09:07 PM, Laura Abbott wrote:
Currently, the warning for missing device_caps gives a backtrace like so:
[8175c199] dump_stack+0x45/0x57
[8109ad5a] warn_slowpath_common+0x8a/0xc0
[8109ae8a] warn_slowpath_null+0x1a/0x20
[a0237453]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp for-next
head: 6db4e6b99ba0dad4e42612a546a99ccdbd766561
commit: 0451d14d05618e5fcbdc5017a30e3d609ddc8229 [15/22] EDAC, mce_amd_inj:
Modify flags attribute to use string arguments
reproduce:
# apt-get install sparse
git checkout
On Friday 05 June 2015 13:36:40 Hans Verkuil wrote:
On 05/15/2015 11:32 PM, Pali Rohár wrote:
From: maxx m...@spaceboyz.net
This actually fixes region selection for BCM2048 FM receiver. To select
the japanese FM-band an additional bit in FM_CTRL register needs to be
set. This might not
Hi Antti,
FYI: don't use ATTN as prefix: patchwork doesn't pick that up as a patch,
and if it doesn't appear there, then it is likely to be forgotten.
Can you repost it with the correct prefix? It's so much easier to process
for me if it ends up in patchwork...
Thanks!
Hans
On
Em Fri, 05 Jun 2015 12:33:04 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 06/05/2015 12:29 PM, Mauro Carvalho Chehab wrote:
Remove the following compilation warnings:
drivers/media/platform/vivid/vivid-tpg.c: In function 'tpg_gen_text':
Hi Ezequiel,
As mentioned in irc: run v4l2-compliance -s and v4l2-compliance -f.
I quickly tried it and v4l2-compliance fails:
Test input 0:
Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test
Signed-off-by: Fengguang Wu fengguang...@intel.com
---
mce_amd_inj.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
index 2a0c829..46a6b0e 100644
--- a/drivers/edac/mce_amd_inj.c
+++ b/drivers/edac/mce_amd_inj.c
@@
On 05/15/2015 11:31 PM, Pali Rohár wrote:
From: maxx m...@spaceboyz.net
This enables access to automute function of the chip via sysfs and
gives direct access to FM_AUDIO_CTRL0/1 registers, also via sysfs. I
don't think this is so important but helps in developing radio scanner
apps.
On 05/15/2015 11:32 PM, Pali Rohár wrote:
From: maxx m...@spaceboyz.net
This actually fixes region selection for BCM2048 FM receiver. To select
the japanese FM-band an additional bit in FM_CTRL register needs to be
set. This might not sound so important but it enables at least me to
listen
This patch fix a spelling typo in nfc-hci.txt
Signed-off-by: Masanari Iida standby2...@gmail.com
---
Documentation/nfc/nfc-hci.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/nfc/nfc-hci.txt b/Documentation/nfc/nfc-hci.txt
index 0686c9e..0dc078c 100644
---
On Fri, Jun 05, 2015 at 07:24:26PM +0800, kbuild test robot wrote:
Signed-off-by: Fengguang Wu fengguang...@intel.com
---
mce_amd_inj.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
index 2a0c829..46a6b0e
Hello.
On 6/5/2015 1:59 PM, Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Dump the VOU registers in log_status.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 29 +
1 file changed, 29 insertions(+)
Hi Steven,
It seems to me that that part of the code is identical to your driver, no?
The media_tree driver:
retval = saa7164_api_i2c_read(bus,
msgs[i].addr,
0 /* reglen */,
NULL /* reg */, msgs[i].len, msgs[i].buf);
It's exactly
The current definition is weird, and produce lots of sparse
warnings:
drivers/media/i2c/cx25840/cx25840-ir.c:448 txclk_tx_s_max_pulse_width()
warn: impossible condition '(ns 4294967295) = (0-u32max u32max)'
drivers/media/i2c/cx25840/cx25840-ir.c:461 rxclk_rx_s_max_pulse_width()
From: Hans Verkuil hans.verk...@cisco.com
This was never added for some reason, so add it now.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 28
include/media/v4l2-mem2mem.h | 4
2 files changed, 32
As reported by smatch:
drivers/media/usb/em28xx/em28xx-video.c:842 get_ressource() info:
ignoring unreachable code.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
index
From: Hans Verkuil hans.verk...@cisco.com
Add support for VIDIOC_PREPARE_BUF to v4l2-mem2mem and use it in vim2m.
Also fix a small bug in the debug logging that's done by v4l2-ioctl.c.
After adding support for CREATE_BUFS in vim2m a v4l2-compliance bug was
found and v4l2-compliance has now been
As reported by smatch:
drivers/media/dvb-frontends/drxk_hard.c:3277 dvbt_sc_command() warn:
missing break? reassigning 'status'
This is basically because the error handling logic there was crappy.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git
As reported by smatch:
drivers/media/pci/bt8xx/dst_ca.c:323 ca_get_message() warn: this array
is probably non-NULL. 'p_ca_message-msg'
drivers/media/pci/bt8xx/dst_ca.c:498 ca_send_message() warn: this array
is probably non-NULL. 'p_ca_message-msg'
Those two checks are
Smatch reports two issues:
drivers/media/platform/sh_vou.c:670 vou_adjust_output() error: buffer
overflow 'vou_scale_v_num' 3 = 4
drivers/media/platform/sh_vou.c:670 vou_adjust_output() error: buffer
overflow 'vou_scale_v_den' 3 = 4
It seems that there's actually a bug here: the
From: Hans Verkuil hans.verk...@cisco.com
Add support for the missing VIDIOC_CREATE_BUFS and VIDIOC_PREPARE_BUF
ioctls.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/vim2m.c | 8
1 file changed, 8 insertions(+)
diff --git
Smatch currently produces two warnings:
drivers/media/pci/ivtv/ivtv-fileops.c:901 ivtv_v4l2_close() warn:
suspicious bitop condition
drivers/media/pci/ivtv/ivtv-fileops.c:1026 ivtv_open() warn: suspicious
bitop condition
Those are false positives, but it is not hard to get rid
Smatch reports a warning:
drivers/media/usb/tm6000/tm6000-video.c:646 tm6000_prepare_isoc()
error: we previously assumed 'dev-urb_buffer' could be null (see line 624)
This is not really a problem, but it actually shows that the check
if urb_buffer is NULL is being done twice: at the if
Fix several smatch warnings.
There are only 26 smatch warnings now:
drivers/media/pci/cx23885/cx23885-dvb.c:2046 dvb_register() Function too hairy.
Giving up.
This is actually a memory allocation limit of 50MB at smatch.
I sent a patch changing such limit to 200MB to Dan.
From: Hans Verkuil hans.verk...@cisco.com
If userspace passed the invalid buffer type 0 to the kernel, then the
kernel log would show 'type=(null)' since there was no string defined
for type 0. Fix this.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-ioctl.c
On 06/05/2015 04:40 PM, Olli Salonen wrote:
Hi Steven,
It seems to me that that part of the code is identical to your driver, no?
The media_tree driver:
retval = saa7164_api_i2c_read(bus,
msgs[i].addr,
0 /* reglen */,
NULL /*
There's a dead code on usbvision that makes it harder to read
and produces a smatch warning about bad identation.
Improve the code readability and add a FIXME to warn about
the current hack there.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git
Don't assume that IR_MAX_DURATION is a bitmask. It isn't.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index c83292ad1b34..ec74244a3853 100644
--- a/drivers/media/rc/redrat3.c
+++ b/drivers/media/rc/redrat3.c
@@
As reported by smatch:
drivers/media/dvb-frontends/dib0090.c:1710
dib0090_dc_offset_calibration() warn: missing break? reassigning '*tune_state'
There's no need to change tune_state there, as the fall though code
will change it again to another state. So, simplify it by
removing the dead
Fix several smatch warnings.
There are still 27 smatch warnings at drivers/media:
This one:
drivers/media/pci/cx23885/cx23885-dvb.c:2046 dvb_register() Function
too hairy. Giving up.
It is just to a random memory limit at smatch that allows it to
allocate only 50Mb of memory for name
Instead of using a state machine and a switch with lots of
fall-trough, use gotos and cleanup the error handling loop.
That removes those two smatch warnings:
drivers/staging/media/lirc/lirc_imon.c:933 imon_probe() warn: possible
memory leak of 'context'
On 06/05/2015 03:28 PM, Sergei Shtylyov wrote:
Hello.
On 6/5/2015 1:59 PM, Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Dump the VOU registers in log_status.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/sh_vou.c | 29
Currently, the warning for missing device_caps gives a backtrace like so:
[8175c199] dump_stack+0x45/0x57
[8109ad5a] warn_slowpath_common+0x8a/0xc0
[8109ae8a] warn_slowpath_null+0x1a/0x20
[a0237453] v4l_querycap+0x43/0x80 [videodev]
[a0237734]
Em Fri, 05 Jun 2015 17:10:53 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 06/05/2015 12:29 PM, Mauro Carvalho Chehab wrote:
Remove the following compilation warnings:
drivers/media/platform/vivid/vivid-tpg.c: In function 'tpg_gen_text':
Commit 84cb7be43cec12868e94163c99fdc34c0297c3b8 broke vivid-tpg (uninitialized
variable p).
This patch takes a different approach: four different functions are created,
one for
each PRINTSTR version.
In order to avoid the 'the frame size of 1308 bytes is larger than 1024 bytes'
warning I
had
Hi Paul,
On Thu, 4 Jun 2015 23:02:25 + (UTC)
Paul Walmsley p...@pwsan.com wrote:
Hi folks
just a brief comment on this one:
On Thu, 30 Apr 2015, Boris Brezillon wrote:
Clock rates are stored in an unsigned long field, but -round_rate()
(which returns a rounded rate from a
On 06/05/2015 12:29 PM, Mauro Carvalho Chehab wrote:
Remove the following compilation warnings:
drivers/media/platform/vivid/vivid-tpg.c: In function 'tpg_gen_text':
drivers/media/platform/vivid/vivid-tpg.c:1562:1: warning: the frame
size of 1308 bytes is larger than 1024 bytes
Change to define Media Controller API when CONFIG_MEDIA_CONTROLLER
is enabled. Define stubs for CONFIG_MEDIA_CONTROLLER disabled case.
This will help avoid drivers needing to enclose Media Controller
code within ifdef CONFIG_MEDIA_CONTROLLER block.
Signed-off-by: Shuah Khan
On Fri, 5 Jun 2015 21:38:19 +0900
Masanari Iida standby2...@gmail.com wrote:
This patch fix a spelling typo in nfc-hci.txt
Applied to the docs tree, thanks.
jon
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
In little endian cases, macro cpu_to_be16 unfolds to __swab16 which
provides special case for constants. In big endian cases,
__constant_cpu_to_be16 and cpu_to_be16 expand directly to the
same expression. So, replace __constant_cpu_to_be16 with
cpu_to_be16 with the goal of getting rid of the
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Jun 6 04:00:19 CEST 2015
git branch: test
git hash: c70316f2a193fcd62232cddc1b2d44997ca2c930
gcc
Hi,
Yesterday I extracted a new firmware for Si2168 B40 rev. from Windows
driver.
It's designed for ROM version 4.0.2 and has a version build 4.0.19
Here is a name of
file:dvb-demod-si2168-b40-rom4_0_2-patch-build4_0_19.fw.tar.gz
And a link for download:
Hi,
Information below was given by a hardware vendor, who uses these demodulators on their dvb-t2 products. As an explanation on our
questions for Si2168 Linux driver development.
I think it can give more clue with Part, Revision and ROM detection algorithm
in Linux driver for that
On 06/03/2015 01:14 PM, Mauro Carvalho Chehab wrote:
Em Wed, 03 Jun 2015 09:12:54 -0600
Shuah Khan shua...@osg.samsung.com escreveu:
Change ALSA driver to use media controller API to share tuner
with DVB and V4L2 drivers that control AU0828 media device.
Media device is created based on a
Em Fri, 05 Jun 2015 11:27:33 -0300
Mauro Carvalho Chehab mche...@osg.samsung.com escreveu:
Fix several smatch warnings.
There are still 27 smatch warnings at drivers/media:
Please discard this e-mail. Git sent it by accident. This is a version
of patch 0/11, saved with another name (and
On Fri, Jun 05, 2015 at 11:27:41AM -0300, Mauro Carvalho Chehab wrote:
Don't assume that IR_MAX_DURATION is a bitmask. It isn't.
The patch is right, but note that IR_MAX_DURATION is 0x, and in
all these cases it is being compared to a u32, so it is always false.
Should these statements
This adds a bunch of various fixes and a new bdisp driver for ST.
Regards,
Hans
The following changes since commit c1c3c85ddf60a6d97c122d57d385b4929fcec4b3:
[media] DocBook: fix FE_SET_PROPERTY ioctl arguments (2015-06-01 06:10:15
-0300)
are available in the git repository at:
Em Fri, 05 Jun 2015 16:00:43 +0100
Sean Young s...@mess.org escreveu:
On Fri, Jun 05, 2015 at 03:55:38PM +0100, Sean Young wrote:
On Fri, Jun 05, 2015 at 11:27:41AM -0300, Mauro Carvalho Chehab wrote:
Don't assume that IR_MAX_DURATION is a bitmask. It isn't.
The patch is right, but
This pull request merged Jan's vb2/mm patches to abstract vma handling.
See http://www.spinics.net/lists/linux-media/msg89653.html for more info.
It's the same pull request as from May 25th, but with an additional patch that
puts get_vaddr_frames() behind a config option (requested by Andrew
On Fri, Jun 05, 2015 at 03:55:38PM +0100, Sean Young wrote:
On Fri, Jun 05, 2015 at 11:27:41AM -0300, Mauro Carvalho Chehab wrote:
Don't assume that IR_MAX_DURATION is a bitmask. It isn't.
The patch is right, but note that IR_MAX_DURATION is 0x, and in
all these cases it is being
78 matches
Mail list logo
