As reported by smatch:
drivers/media/platform/sti/bdisp/bdisp-v4l2.c:947 bdisp_s_selection()
warn: unsigned 'out.width' is never less than zero.
drivers/media/platform/sti/bdisp/bdisp-v4l2.c:947 bdisp_s_selection()
warn: unsigned 'out.height' is never less than zero.
Indeed,
Integer controls provide a way to get their default/initial value, but
any other control (p_u32, p_u8.) provide no other way to get the
initial value than unloading the module and loading it back.
*What is the actual problem?
I have a custom control with WIDTH integer values. Every value
Hi Mauro,
On 10/06/15 00:56, Mauro Carvalho Chehab wrote:
Hmm... if patch 1 is enough to fix the issue, and patch 4 may break
things, I'll apply only patch 1/4 for now. If Patrick agrees, and you
find a way to avoid breakages, please resubmit for me to apply the
other ones. Regards, Mauro
Am 08.06.2015 um 12:04 schrieb Hans Verkuil:
big_snip /
Just curious: as we're talking about userland libraries,
why not just using gstreamer ?
--mtx
--
Enrico Weigelt, metux IT consult
+49-151-27565287
MELAG Medizintechnik oHG Sitz Berlin Registergericht AG Charlottenburg HRA
21333 B
Hi Enrico,
On 2015-06-10 5:17 PM, Enrico Weigelt, metux IT consult wrote:
Am 08.06.2015 um 12:04 schrieb Hans Verkuil:
big_snip /
Just curious: as we're talking about userland libraries,
why not just using gstreamer ?
I would prefer to use gstreamer if I could, but the application
From: Jan Kara j...@suse.cz
Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames().
This removes the knowledge about vmas and mmap_sem locking from exynos
driver. Also it fixes a problem that the function has been mapping user
provided address without holding mmap_sem.
From: Jan Kara j...@suse.cz
Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of
hand made mapping of virtual address to physical address. Also the
function leaked page reference from get_user_pages() so fix that by
properly release the reference when omap_vout_buffer_release()
From: Jan Kara j...@suse.cz
Simplify the VMA code by using frame_vector_pages() friends on VB2.
Tested-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Jan Kara j...@suse.cz
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Mauro Carvalho Chehab
From: Jan Kara j...@suse.cz
Convert vb2_vmalloc_get_userptr() to use frame vector infrastructure.
When we are doing that there's no need to allocate page array and some
code can be simplified.
Tested-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Jan Kara j...@suse.cz
From: Jan Kara j...@suse.cz
Convert vb2_dc_get_userptr() to use frame vector infrastructure. When we
are doing that there's no need to allocate page array and some code can
be simplified.
Tested-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Jan Kara j...@suse.cz
Signed-off-by:
Hi Andrew,
I received this patch series with a new set of helper functions for
mm, together with changes for media and DRM drivers.
As this stuff is actually mm code, I prefer if this got merged via
your tree.
Could you please handle it? Please notice that patch 8 actually changes
the exynos
From: Jan Kara j...@suse.cz
Conversion to the use of pinned pfns made some functions unused. Remove
them. Also there's no need to lock mmap_sem in __buf_prepare() anymore.
Tested-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Jan Kara j...@suse.cz
Signed-off-by: Hans Verkuil
From: Jan Kara j...@suse.cz
Provide new function get_vaddr_frames(). This function maps virtual
addresses from given start and fills given array with page frame numbers of
the corresponding pages. If given start belongs to a normal vma, the function
grabs reference to each of the pages to pin
From: Jan Kara j...@suse.cz
get_vaddr_frames() is used by relatively rare drivers so hide it and the
related functions behind a config option that is selected only by
drivers that need the infrastructure.
Suggested-by: Andrew Morton a...@linux-foundation.org
Signed-off-by: Jan Kara j...@suse.cz
From: Jan Kara j...@suse.cz
Provide simple helper functions to map virtual address range into an
array of pfns / pages.
Tested-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Jan Kara j...@suse.cz
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Mauro Carvalho
Klientskie bazi tel +79133913837 Yznaite podrobnee!!!
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Tue, 02 Jun 2015 23:25:31 +0100
Andy Furniss adf.li...@gmail.com escreveu:
Running kernel 3.18.14 with git master v4l-utils and a pctv290e + a 292e.
If I try to record with dvbv5-zap and include the p option to get
pat/pmt I get -
read_sections: read error: Resource temporarily
API conformance testing for completions with coccinelle spatches are being
used to locate API usage inconsistencies:
./drivers/media/pci/ddbridge/ddbridge-core.c:89
incorrect check for negative return
Return type of wait_event_timeout is signed long not int and the
return type is =0
For unclear reasons my SoB was missing in my pull request. So add it now:
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
On 05/13/15 15:08, Jan Kara wrote:
Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames().
This removes the knowledge about
The following changes since commit 9056a23ba19d911d4a079b8ca543fb8ebffa7c56:
[media] dvb-frontend: Replace timeval with ktime_t (2015-06-09
21:09:51 -0300)
are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git ts2020_pull
for you to fetch changes up to
event API conformance testing with coccinelle spatches are being
used to locate API usage inconsistencies this triggert with:
./drivers/media/platform/s5p-tv/mixer_reg.c:364
incorrect check for negative return
Return type of wait_event_timeout is signed long not int and the
return type is
Em Mon, 08 Jun 2015 10:56:29 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Antti,
I am not so sure about this. The situation with TUNER_ADC is similar to
TUNER_RADIO:
we use TUNER_RADIO for radio modulators, even though it is clearly not a
tuner type.
Basically the tuner type is
Change ALSA driver to use media controller API to share
tuner with DVB and V4L2 drivers that control AU0828 media
device. Media device is created based on a newly added
field value in the struct snd_usb_audio_quirk. Using this
approach, the media controller API usage can be added for
a specific
This patch series updates ALSA driver to use media controller
API to share tuner with DVB and V4L2 drivers that control AU0828
media device. Two new interfaces are added to media controller
API to enable creating media device as a device resource. This
allows creating media device as a device
Add a new media entity operation register_notify is added
to media_entity_operations structure. This hook is called
from media_device_register_entity() whenever a new entity
is registered to notify other entities attached to that
media device of the newly created entity. Entity owners
can register
We can simplify the code removing the if().
v4l2_ctr_new sets ctrls-elems to 1 when !ctrl-is_ptr.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 15 ---
1 file changed, 15 deletions(-)
diff --git
Hi Michal,
That mercurial repo is updated last time in 2011 as far as I can see.
Really, if you're looking forward to just build the latest media
drivers, run the 4 commands listed here (you may need to install some
depedencies first, like git and run the make install with sudo):
Fix the following warning:
drivers/media/platform/sti/bdisp/bdisp-v4l2.c: In function
'bdisp_register_device':
drivers/media/platform/sti/bdisp/bdisp-v4l2.c:1024:26: warning: variable 'pdev'
set but not used [-Wunused-but-set-variable]
struct platform_device *pdev;
Signed-off-by: Mauro
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/media/i2c/saa6588.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/i2c/saa6588.c b/drivers/media/i2c/saa6588.c
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/media/pci/bt8xx/btcx-risc.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/pci/bt8xx/btcx-risc.c
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/media/common/saa7146/saa7146_hlp.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
drivers/built-in.o: In function `ts2020_read_signal_strength':
ts2020.c:(.text+0x298ff94): undefined reference to `__divdi3'
ts2020.c:(.text+0x298ffd4): undefined reference to `__divdi3'
ts2020.c:(.text+0x298fffd): undefined reference to `__divdi3'
Makefile:921: recipe for target 'vmlinux' failed
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/media/radio/wl128x/fmdrv_common.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/radio/wl128x/fmdrv_common.c
On Wed, Jun 10, 2015 at 06:20:52AM -0300, Mauro Carvalho Chehab wrote:
From: Jan Kara j...@suse.cz
get_vaddr_frames() is used by relatively rare drivers so hide it and the
related functions behind a config option that is selected only by
drivers that need the infrastructure.
Suggested-by:
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/media/usb/ttusb-dec/ttusb_dec.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/media/usb/ttusb-dec/ttusb_dec.c
Changes compared v1:
1. Extended v4l2_detect_cvt() api to pass active image width. This
solves the issue related to how to get width in the absence of
aspect information.
2. Fix: Added condition to correct the clock granularity.
3. Removed TODO for reduced blanking version 2.
4. Other
Added support for reduced blanking version 2 (RB v2) in cvt timings.
Standard specifies a fixed vsync pulse of 8 lines to indicate RB v2
timings. Vertical back porch is fixed at 6 lines and vertical front
porch is remainder of vertical blanking time.
For RB v2, horizontal blanking is fixed at 80
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch extends LED Flash class documention by
the description of interactions with v4l2-flash sub-device.
Merged into my -devel branch and it won't be merged into 4.2.0 merge
window but wait for one more
Em Wed, 10 Jun 2015 15:50:47 -0300
Mauro Carvalho Chehab mche...@osg.samsung.com escreveu:
Em Wed, 10 Jun 2015 18:27:30 +0100
Andy Furniss adf.li...@gmail.com escreveu:
Mauro Carvalho Chehab wrote:
Just applied a fix for it:
We've had a dozen or two of these cards through our lab and the labels on the
card aren't 100% reliable; we've seen both HVR-2250 labelled as HVR-2255 and
vice versa.
Jake
-Original Message-
From: linux-media-ow...@vger.kernel.org
[mailto:linux-media-ow...@vger.kernel.org] On Behalf
Em Wed, 10 Jun 2015 18:27:30 +0100
Andy Furniss adf.li...@gmail.com escreveu:
Mauro Carvalho Chehab wrote:
Just applied a fix for it:
http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=c7c9af17163f282a147ea76f1a3c0e9a0a86e7fa
It will retry up to 10 times. This should very
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class
driver. The support allows for V4L2 Flash sub-device to take the control
of the LED Flash class device.
Merged into my -devel branch and it
On Wed, Jun 10, 2015 at 11:01 AM, Bryan Wu coolo...@gmail.com wrote:
On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu coolo...@gmail.com wrote:
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch adds helper functions for registering/unregistering
LED Flash
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch adds support for external v4l2-flash devices.
The support includes parsing camera-flashes DT property
and asynchronous sub-device registration.
Please go ahead with my Ack
Acked-by: Bryan Wu
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch adds a description of 'samsung,camera-flashes'
property to the samsung-fimc.txt.
Please go ahead with my Ack
Acked-by: Bryan Wu coolo...@gmail.com
Thanks,
-Bryan
Signed-off-by: Jacek Anaszewski
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
Avoid verifying bound async sensor sub-devices by their of_nodes,
which duplicates v4l2-async functionality, in favour of matching
them by the corresponding struct v4l2_async_subdev. The structures
are now being
Hi Jeff,
Based on the PCI subsystem ID I think your card is actually HVR-2255
and not the older HVR-2250. Check what it says on the card. Some
people have reported buying a HVR-2250, but receiving actually a
HVR-2255.
Anyway, HVR-2255 is supported by the media_tree these days, but you
need to
I am trying to get the firmware to load on a fresh install of Ubuntu
15.04 desktop 64-bit on a new system.
uname -a
Linux 3.19.0-15-generic #15-Ubuntu SMP Thu Apr 16 23:32:37 UTC 2015
x86_64 x86_64 x86_64 GNU/Linux
lshw
description: Computer
width: 64 bits
capabilities:
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch adds helper functions for registering/unregistering
LED Flash class devices as V4L2 sub-devices. The functions should
be called from the LED subsystem device driver. In case the
support for V4L2 Flash
On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu coolo...@gmail.com wrote:
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch adds helper functions for registering/unregistering
LED Flash class devices as V4L2 sub-devices. The functions should
be called from
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch adds documentation for a pinctrl-names property.
The property, when present, is used for switching the source
of the strobe signal for the device.
Merged into my -devel branch and it won't be merged
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
Add support for V4L2 Flash sub-device to the max77693 LED Flash class
driver. The support allows for V4L2 Flash sub-device to take the control
of the LED Flash class device.
Merged into my -devel branch and it
Mauro Carvalho Chehab wrote:
Just applied a fix for it:
http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=c7c9af17163f282a147ea76f1a3c0e9a0a86e7fa
It will retry up to 10 times. This should very likely be enough if the
driver doesn't have any bug.
Please let me know if this
On Wed 2015-06-10 11:12:50, Bryan Wu wrote:
On Wed, Jun 10, 2015 at 11:01 AM, Bryan Wu coolo...@gmail.com wrote:
On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu coolo...@gmail.com wrote:
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
This patch adds helper
Hi Bryan,
On Wed, Jun 10, 2015 at 02:39:09PM -0700, Bryan Wu wrote:
On Wed, Jun 10, 2015 at 2:34 PM, Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Bryan,
On Wed, Jun 10, 2015 at 11:12:50AM -0700, Bryan Wu wrote:
On Wed, Jun 10, 2015 at 11:01 AM, Bryan Wu coolo...@gmail.com wrote:
On Wed,
V4L2 async sub-devices are currently matched (OF case) based on the struct
device_node pointer in struct device. LED devices may have more than one
LED, and in that case the OF node to match is not directly the device's
node, but a LED's node.
Signed-off-by: Laurent Pinchart
Hi Laurent,
On Wed, Jun 10, 2015 at 03:52:50AM +0300, Laurent Pinchart wrote:
Hi Sakari,
Thank you for the patch.
On Friday 29 May 2015 02:17:47 Sakari Ailus wrote:
The power management code was reworked a little due to interface changes in
the MC. Due to those changes the power
There are several warnings there, on some architectures, related
to dividing a s32 by a s64 value:
drivers/media/platform/sti/bdisp/bdisp-debug.c:594: warning: comparison of
distinct pointer types lacks a cast
drivers/media/platform/sti/bdisp/bdisp-debug.c:594: warning: right shift count
=
While compiled on alpha, got this error:
drivers/media/pci/cx88/cx88-video.c:415:12: warning:
'restart_video_queue' defined but not used [-Wunused-function]
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/pci/cx88/cx88-video.c
Mauro Carvalho Chehab wrote:
Em Wed, 10 Jun 2015 18:27:30 +0100
Andy Furniss adf.li...@gmail.com escreveu:
Mauro Carvalho Chehab wrote:
Just applied a fix for it:
http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=c7c9af17163f282a147ea76f1a3c0e9a0a86e7fa
It will retry up to
Hi Bryan,
On Wed, Jun 10, 2015 at 11:12:50AM -0700, Bryan Wu wrote:
On Wed, Jun 10, 2015 at 11:01 AM, Bryan Wu coolo...@gmail.com wrote:
On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu coolo...@gmail.com wrote:
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
On Wed, Jun 10, 2015 at 2:34 PM, Sakari Ailus sakari.ai...@iki.fi wrote:
Hi Bryan,
On Wed, Jun 10, 2015 at 11:12:50AM -0700, Bryan Wu wrote:
On Wed, Jun 10, 2015 at 11:01 AM, Bryan Wu coolo...@gmail.com wrote:
On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu coolo...@gmail.com wrote:
On Mon, Jun
Mauro Carvalho Chehab wrote:
Actually, there was an error on that patch. I did some tests here
with a PCTV 292e. While I was not able to reproduce the issue you're
reporting, I forced some errors. The patch should be working. The
only question is if 1 second is enough or not.
So, please test.
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Jun 11 04:00:18 CEST 2015
git branch: test
git hash: e42c8c6eb456f8978de417ea349eef676ef4385c
gcc
Hi, Guennadi
Any feedback for this patch series?
Best Regards,
Josh Wu
On 5/26/2015 5:54 PM, Josh Wu wrote:
This patch series fix the peripheral clock code and enable runtime support.
Also it clean up the code which is for the compatiblity of mck.
Changes in v5:
- add new patch to fix the
tree: git://linuxtv.org/media_tree.git master
head: 9e8715c91da5567518fcfc16721e01f974536e4a
commit: 34b6beb65beb7f7726baa771661c671310445265 [1224/1252] [media] bdisp: add
debug file system
config: avr32-allyesconfig (attached as .config)
reproduce:
wget
67 matches
Mail list logo
