cron job: media_tree daily build: WARNINGS

2015-08-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Aug 31 04:00:14 CEST 2015 git branch: test git hash: d071c833a0d30e7aae0ea565d92ef83c79106d6f gcc versi

Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-30 Thread Junghak Sung
Hello Hans, Thank you for your review. I leave some comments in the body for reply. Regards, Junghak On 08/28/2015 10:31 PM, Hans Verkuil wrote: Hi Junghak, Thanks for this patch, it looks much better. I do have a number of comments, though... On 08/26/2015 01:59 PM, Junghak Sung wrote:

Re: [PATCH v3 4/4] media: pxa_camera: conversion to dmaengine

2015-08-30 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> +last_buf = list_entry(pcdev->capture.prev, >> + struct pxa_buffer, vb.queue); > > You can use list_last_entry() Ok. >> +last_status = dma_async_is_tx_complete(pcdev->dma_chans[chan], >> +

Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions

2015-08-30 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > This still seems to break compilation to me. Could you compile-test after > each your patch, please? Ah yes. Ill timing, I had sent the v4 before having these comments, so I'll have to fix it in v5. Cheers. -- Robert -- To unsubscribe from this list: send the l

[PATCH v4 3/4] media: pxa_camera: trivial move of dma irq functions

2015-08-30 Thread Robert Jarzmik
From: Robert Jarzmik This moves the dma irq handling functions up in the source file, so that they are available before DMA preparation functions. It prepares the conversion to DMA engine, where the descriptors are populated with these functions as callbacks. Signed-off-by: Robert Jarzmik --- S

[PATCH v4 0/4] media: pxa_camera: conversion to dmaengine

2015-08-30 Thread Robert Jarzmik
Hi Guennadi, This is the forth round. This time sg_split() was a consequence of (a) and (b), ie. sg_split() move into kernel's lib/ directory, and following dmaengine "reuse" flag introduction, change pxa_camera accordingly. Happy review. Cheers. Robert Jarzmik (4): media: pxa_camera: fix th

[PATCH v4 1/4] media: pxa_camera: fix the buffer free path

2015-08-30 Thread Robert Jarzmik
From: Robert Jarzmik Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory which was not mapped in the first place. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 6 -- 1 fi

[PATCH v4 4/4] media: pxa_camera: conversion to dmaengine

2015-08-30 Thread Robert Jarzmik
Convert pxa_camera to dmaengine. This removes all DMA registers manipulation in favor of the more generic dmaengine API. The functional level should be the same as before. The biggest change is in the videobuf_sg_splice() function, which splits a videobuf-dma into several scatterlists for 3 planes

[PATCH v4 2/4] media: pxa_camera: move interrupt to tasklet

2015-08-30 Thread Robert Jarzmik
From: Robert Jarzmik In preparation for dmaengine conversion, move the camera interrupt handling into a tasklet. This won't change the global flow, as this interrupt is only used to detect the end of frame and activate DMA fifos handling. Signed-off-by: Robert Jarzmik --- drivers/media/platfor

Re: [BUG] STV0299 has bogus CAN_INVERSION_AUTO flag

2015-08-30 Thread Malcolm Priestley
On 30/08/15 16:07, Johann Klammer wrote: On 08/30/2015 11:53 AM, Malcolm Priestley wrote: On 24/08/15 16:19, Johann Klammer wrote: from gdb dump: [...] info = { name = "ST STV0299 DVB-S", '\000' , type = FE_QPSK, frequency_min = 95, frequency_max = 215, frequen

Re: [BUG] STV0299 has bogus CAN_INVERSION_AUTO flag

2015-08-30 Thread Johann Klammer
On 08/30/2015 11:53 AM, Malcolm Priestley wrote: > On 24/08/15 16:19, Johann Klammer wrote: >> from gdb dump: >> [...] >> info = { >>name = "ST STV0299 DVB-S", '\000' , type = FE_QPSK, >>frequency_min = 95, frequency_max = 215, >>frequency_stepsize = 125, frequency_t

Re: [PATCH v8 00/55] MC next generation patches

2015-08-30 Thread Mauro Carvalho Chehab
Em Sun, 30 Aug 2015 00:06:11 -0300 Mauro Carvalho Chehab escreveu: > That's the 8th version of the MC next generation patches. > > Differences from version 7: > > - Patches reworked to make the reviewers happy; > - Bug fixes; > - ALSA changes got their own separate patches; > - Javier patches g

Re: [PATCH] media: soc-camera: increase the length of clk_name on soc_of_bind()

2015-08-30 Thread Guennadi Liakhovetski
Hi Josh, Sorry, I missed the 4.3 merge cycle, but isn't this patch a fix? Isn't it fixing soc-camera / atmel-isi on a specific platform, where the clock name is longer, than currently supported? Is this platform in the mainline and its current camera support is broken because of this? In such a

Re: [PATCH v3 4/4] media: pxa_camera: conversion to dmaengine

2015-08-30 Thread Guennadi Liakhovetski
Hi Robert, I assume, the next iteration of your patches won't contain a local copy of the SG splitting code. On Wed, 29 Jul 2015, Robert Jarzmik wrote: > Convert pxa_camera to dmaengine. This removes all DMA registers > manipulation in favor of the more generic dmaengine API. > > The functiona

Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions

2015-08-30 Thread Guennadi Liakhovetski
On Wed, 29 Jul 2015, Robert Jarzmik wrote: > From: Robert Jarzmik > > This moves the dma irq handling functions up in the source file, so that > they are available before DMA preparation functions. It prepares the > conversion to DMA engine, where the descriptors are populated with these > funct

Re: [PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-30 Thread Guennadi Liakhovetski
Yep, I see the thread and updates to this patch now, please, ignore this mail, sorry. Thanks Guennadi On Sun, 30 Aug 2015, Guennadi Liakhovetski wrote: > Hi Josh, > > On Wed, 17 Jun 2015, Josh Wu wrote: > > > As in set_fmt() function we only need to know which format is been set, > > we don't

Re: [BUG] STV0299 has bogus CAN_INVERSION_AUTO flag

2015-08-30 Thread Malcolm Priestley
On 24/08/15 16:19, Johann Klammer wrote: from gdb dump: [...] info = { name = "ST STV0299 DVB-S", '\000' , type = FE_QPSK, frequency_min = 95, frequency_max = 215, frequency_stepsize = 125, frequency_tolerance = 0, symbol_rate_min = 100, symbol_rate_max = 4

Re: [PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-30 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 17 Jun 2015, Josh Wu wrote: > As in set_fmt() function we only need to know which format is been set, > we don't need to access the ISI hardware in this moment. > > So move the configure_geometry(), which access the ISI hardware, to > start_streaming() will make code more consis

Re: [PATCH 1/2] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-30 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 17 Jun 2015, Josh Wu wrote: > In the function configure_geometry(), we will setup the ISI CFG2 > according to the sensor output format. > > It make no sense to just read back the CFG2 register and just set part > of it. > > So just set up this register directly makes things sim