Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Fri, Nov 20, 2015 at 12:58 PM, Arnd Bergmann wrote: > On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote: >> On 11/19/2015 01:25 PM, Arnd Bergmann wrote: > Another idea would be to remove the filter function from struct dma_chan_map > and pass the map through platform

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On 11/20/2015 02:24 PM, Andy Shevchenko wrote: > On Fri, Nov 20, 2015 at 12:58 PM, Arnd Bergmann wrote: >> On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote: >>> On 11/19/2015 01:25 PM, Arnd Bergmann wrote: > >> Another idea would be to remove the filter function from

Re: PID filter testing

On 11/20/2015 04:25 PM, Benjamin Larsson wrote: On 11/20/2015 02:27 PM, Honza Petrouš wrote: 2015-11-20 12:00 GMT+01:00 Benjamin Larsson : Hi, what tools can I use to test pid filter support in the drivers ? Zap utility from dvbapps seems to be some simpler way - you

Re: PID filter testing

2015-11-20 12:00 GMT+01:00 Benjamin Larsson : > Hi, what tools can I use to test pid filter support in the drivers ? Zap utility from dvbapps seems to be some simpler way - you can pass them the fixed pids and record filtered data by simple command. See at:

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Fri, Nov 20, 2015 at 2:30 PM, Peter Ujfalusi wrote: > On 11/20/2015 02:24 PM, Andy Shevchenko wrote: >> On Fri, Nov 20, 2015 at 12:58 PM, Arnd Bergmann wrote: >>> On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote: On 11/19/2015 01:25 PM, Arnd

Re: cobalt & dma

On 11/20/2015 03:49 PM, Ran Shalit wrote: > Hello, > > > >> >> No. All video capture/output devices all use DMA since it would be >> prohibitively >> expensive for the CPU to do otherwise. So just dig in and implement it. > > I am trying to better understand how read() operation actually use

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Friday 20 November 2015 14:52:03 Peter Ujfalusi wrote: > > >> For legacy the filter function is pretty much needed to handle the > >> differences > >> between the platforms as not all of them does the filtering in a same way. > >> So > >> the first type of map would be feasible IMHO. > > >

Re: PID filter testing

On 11/20/2015 02:27 PM, Honza Petrouš wrote: 2015-11-20 12:00 GMT+01:00 Benjamin Larsson : Hi, what tools can I use to test pid filter support in the drivers ? Zap utility from dvbapps seems to be some simpler way - you can pass them the fixed pids and record filtered

Re: cobalt & dma

Hello, > > No. All video capture/output devices all use DMA since it would be > prohibitively > expensive for the CPU to do otherwise. So just dig in and implement it. I am trying to better understand how read() operation actually use the dma, but I can't yet understand it from code. > > No.

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote: > On 11/19/2015 01:25 PM, Arnd Bergmann wrote: > >> dma_request_channel(mask); /* memcpy. etc, non slave mostly */ > >> > >> Not sure how to name this as reusing existing (good, descriptive) function > >> names would mean changes all over

PID filter testing

Hi, what tools can I use to test pid filter support in the drivers ? MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: PID filter testing

On 11/20/2015 01:00 PM, Benjamin Larsson wrote: Hi, what tools can I use to test pid filter support in the drivers ? dvbtraffic shows all the pids from tuned stream, but IIRC it does not work with dvbv5-zap as it opens device blocked mode. dvbv5-zap has itself quite similar mode than

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On 11/20/2015 12:58 PM, Arnd Bergmann wrote: >>> That way the vast majority of drivers can use one of the two nice interfaces >>> and the rest can be converted to use __dma_request_chan(). >>> >>> On a related topic, we had in the past considered providing a way for >>> platform code to register a

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

On 11/19/2015 01:25 PM, Arnd Bergmann wrote: >> If we have two main APIs, one to request slave channels and one to get any >> channel with given capability >> dma_request_slave_channel(NULL, NULL, , fn, fn_param); /* Legacy slave >> */ >> dma_request_slave_channel(dev, name, NULL, NULL, NULL); /*

[PATCHv10 04/15] media: videobuf2: Add copy_timestamp to struct vb2_queue

From: Junghak Sung Add copy_timestamp to struct vb2_queue as a flag set if vb2-core should copy timestamps. Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim Acked-by: Seung-Woo Kim

[PATCHv10 06/15] media: videobuf2: last_buffer_queued is set at fill_v4l2_buffer()

From: Junghak Sung The location in which last_buffer_queued is set is moved to fill_v4l2_buffer(). So, __vb2_perform_fileio() can use vb2_core_dqbuf() instead of vb2_internal_dqbuf(). Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim

[PATCHv10 03/15] media: videobuf2: Move timestamp to vb2_buffer

From: Junghak Sung Move timestamp from struct vb2_v4l2_buffer to struct vb2_buffer for common use, and change its type to u64 in order to handling y2038 problem. This patch also includes all device drivers' changes related to this restructuring. Signed-off-by: Junghak

[PATCHv10 05/15] media: videobuf2: Separate vb2_poll()

From: Junghak Sung Separate vb2_poll() into core and v4l2 part. Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim Acked-by: Seung-Woo Kim Acked-by: Inki Dae

[PATCHv10 08/15] media: videobuf2: Move vb2_fileio_data and vb2_thread to core part

From: Junghak Sung Move things related with vb2 file I/O and vb2_thread without doing any functional changes. After that, videobuf2-internal.h is removed because it is not necessary any more. Signed-off-by: Junghak Sung Signed-off-by: Geunyoung

[PATCHv10 01/15] DocBook media: update VIDIOC_CREATE_BUFS documentation

From: Hans Verkuil During the Seoul media workshop we decided to relax the VIDIOC_CREATE_BUFS specification so it would no longer require drivers to validate the format field since almost no driver did that anyway. Instead drivers use the buffer size(s) based on the

[PATCHv10 02/15] solo6x10: use v4l2_get_timestamp to fill in buffer timestamp

From: Hans Verkuil The timestamp of a v4l2_buffer was advertised as being CLOCK_MONOTONIC, but instead a timestamp from a header field was used. This is inconsistent and not what applications expect. Use v4l2_get_timestamp to properly set the timestamp. Signed-off-by:

[PATCHv10 00/15] Refactoring Videobuf2 for common use

From: Hans Verkuil It seems that Junghak no longer has time to work on this, so at Mauro's request I'm taking over this patch series. This is revision 10 and it incorporates comments from Sakari, Junghak and myself. Changes since v9: - Added my patches that drop the

Re: PID filter testing

hmm, that is null pid for padding ts to correct size IIRC. Take into account that some pid filters / bridges automatically filter it out. Usually it is there though. So it is not very good pid to test. If you want test some pid which is always there look those mandatory pids which are pids

[PATCHv10 14/15] videobuf2-core: fix plane_sizes handling in VIDIOC_CREATE_BUFS

From: Hans Verkuil The handling of q->plane_sizes was wrong in vb2_core_create_bufs(). The q->plane_sizes array was global and it was overwritten by create_bufs. So if reqbufs was called with e.g. size 10 then q->plane_sizes[0] would be set to 10. If create_bufs

[PATCHv10 13/15] videobuf2-core: call __setup_offsets before buf_init()

From: Hans Verkuil Ensure that the offsets are correct before buf_init() is called. As a consequence the __setup_offsets() function now sets up the offsets for the given buffer instead of for all new buffers. Signed-off-by: Hans Verkuil ---

[PATCHv10 11/15] videobuf2-core: move __setup_lengths into __vb2_queue_alloc()

From: Hans Verkuil Rather than setting up the lengths at the end, set them up when the vb2_buffer is allocated. This also ensures that buf_init() sees the right length values. Signed-off-by: Hans Verkuil ---

[PATCHv10 10/15] videobuf2-core: fill_user_buffer and copy_timestamp should return void

From: Hans Verkuil This ops can never fail, so make these void functions. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 27 --- drivers/media/v4l2-core/videobuf2-v4l2.c | 12 +---

[PATCHv11 04/15] media: videobuf2: Move timestamp to vb2_buffer

From: Junghak Sung Move timestamp from struct vb2_v4l2_buffer to struct vb2_buffer for common use, and change its type to u64 in order to handling y2038 problem. This patch also includes all device drivers' changes related to this restructuring. Signed-off-by: Junghak

[PATCHv11 14/15] videobuf2-core: call __setup_offsets before buf_init()

From: Hans Verkuil Ensure that the offsets are correct before buf_init() is called. As a consequence the __setup_offsets() function now sets up the offsets for the given buffer instead of for all new buffers. Signed-off-by: Hans Verkuil ---

[PATCHv11 05/15] media: videobuf2: Add copy_timestamp to struct vb2_queue

From: Junghak Sung Add copy_timestamp to struct vb2_queue as a flag set if vb2-core should copy timestamps. Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim Acked-by: Seung-Woo Kim

[PATCHv11 12/15] videobuf2-core: move __setup_lengths into __vb2_queue_alloc()

From: Hans Verkuil Rather than setting up the lengths at the end, set them up when the vb2_buffer is allocated. This also ensures that buf_init() sees the right length values. Signed-off-by: Hans Verkuil ---

[PATCHv11 06/15] media: videobuf2: Separate vb2_poll()

From: Junghak Sung Separate vb2_poll() into core and v4l2 part. Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim Acked-by: Seung-Woo Kim Acked-by: Inki Dae

[PATCHv11 13/15] videobuf2-core: fill in q->bufs[vb->index] before buf_init()

From: Hans Verkuil Fill in q->bufs[vb->index] before the call to buf_init: it makes sense that this is initialized correctly. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCHv11 07/15] media: videobuf2: last_buffer_queued is set at fill_v4l2_buffer()

From: Junghak Sung The location in which last_buffer_queued is set is moved to fill_v4l2_buffer(). So, __vb2_perform_fileio() can use vb2_core_dqbuf() instead of vb2_internal_dqbuf(). Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim

[PATCHv11 15/15] videobuf2-core: fix plane_sizes handling in VIDIOC_CREATE_BUFS

From: Hans Verkuil The handling of q->plane_sizes was wrong in vb2_core_create_bufs(). The q->plane_sizes array was global and it was overwritten by create_bufs. So if reqbufs was called with e.g. size 10 then q->plane_sizes[0] would be set to 10. If create_bufs

[PATCHv11 03/15] solo6x10: use v4l2_get_timestamp to fill in buffer timestamp

From: Hans Verkuil The timestamp of a v4l2_buffer was advertised as being CLOCK_MONOTONIC, but instead a timestamp from a header field was used. This is inconsistent and not what applications expect. Use v4l2_get_timestamp to properly set the timestamp. Signed-off-by:

Re: cobalt & dma

>> >> 1. I tried to understand the code implementation of videobuf2 with >> regards to read(): >> read() -> >> vb2_read() -> >> __vb2_perform_fileio()-> >> vb2_internal_dqbuf() & copy_to_user() >> >> Where is the actual allocation of dma contiguous memory ? Is done with

[PATCHv10 12/15] videobuf2-core: fill in q->bufs[vb->index] before buf_init()

From: Hans Verkuil Fill in q->bufs[vb->index] before the call to buf_init: it makes sense that this is initialized correctly. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCHv10 15/15] test

From: Hans Verkuil Signed-off-by: Hans Verkuil --- include/media/videobuf2-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index ef03ae5..956604d 100644

[PATCHv10 09/15] videobuf2-core.c: update module description

From: Hans Verkuil This module is no longer V4L2 specific, so update the module description accordingly. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv10 07/15] media: videobuf2: Refactor vb2_fileio_data and vb2_thread

From: Junghak Sung Replace v4l2-stuffs with common things in struct vb2_fileio_data and vb2_thread(). Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim Acked-by: Seung-Woo Kim Acked-by:

[PATCHv11 01/15] vb2: drop v4l2_format argument from queue_setup

From: Hans Verkuil The queue_setup callback has a void pointer that is just for V4L2 and is the pointer to the v4l2_format struct that was passed to VIDIOC_CREATE_BUFS. The idea was that drivers would use the information from that struct to buffers suitable for the

[PATCHv11 11/15] videobuf2-core: fill_user_buffer and copy_timestamp should return void

From: Hans Verkuil This ops can never fail, so make these void functions. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 27 --- drivers/media/v4l2-core/videobuf2-v4l2.c | 12 +---

[PATCHv11 08/15] media: videobuf2: Refactor vb2_fileio_data and vb2_thread

From: Junghak Sung Replace v4l2-stuffs with common things in struct vb2_fileio_data and vb2_thread(). Signed-off-by: Junghak Sung Signed-off-by: Geunyoung Kim Acked-by: Seung-Woo Kim Acked-by:

Re: cobalt & dma

On 11/20/2015 05:14 PM, Ran Shalit wrote: >>> >>> 1. I tried to understand the code implementation of videobuf2 with >>> regards to read(): >>> read() -> >>> vb2_read() -> >>> __vb2_perform_fileio()-> >>> vb2_internal_dqbuf() & copy_to_user() >>> >>> Where is the actual

[PATCHv11 00/15] Refactoring Videobuf2 for common use

From: Hans Verkuil Oops, v10 missed the first patch and had a bogus last patch. My fault. So ignore v10 and use v11 instead. It seems that Junghak no longer has time to work on this, so at Mauro's request I'm taking over this patch series. This is revision 11 and it

[PATCHv11 02/15] DocBook media: update VIDIOC_CREATE_BUFS documentation

From: Hans Verkuil During the Seoul media workshop we decided to relax the VIDIOC_CREATE_BUFS specification so it would no longer require drivers to validate the format field since almost no driver did that anyway. Instead drivers use the buffer size(s) based on the

[PATCHv11 09/15] media: videobuf2: Move vb2_fileio_data and vb2_thread to core part

From: Junghak Sung Move things related with vb2 file I/O and vb2_thread without doing any functional changes. After that, videobuf2-internal.h is removed because it is not necessary any more. Signed-off-by: Junghak Sung Signed-off-by: Geunyoung

[PATCHv11 10/15] videobuf2-core.c: update module description

From: Hans Verkuil This module is no longer V4L2 specific, so update the module description accordingly. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] [media] tda10023: fix wrong register assignment

On 09/08/2015 10:43 AM, Manuel Kampert wrote: Register INTP1 (0x12) Bit POCLKP (bit 0) sets the output clock polarity of tda10023 . However, the driver tries to set the parallel output mode in this register which is not correct. Parallel output mode is set on register INTP2 (0x20) INTPSEL (bit

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Nov 21 04:00:22 CET 2015 git branch: test git hash: ca78946853eb23a37260cefc074a5bf86e8b866c gcc