[PATCH] android: fix warning when releasing active sync point

2015-12-14 Thread Dmitry Torokhov
Userspace can close the sync device while there are still active fence points, in which case kernel produces the following warning: [ 43.853176] [ cut here ] [ 43.857834] WARNING: CPU: 0 PID: 892 at

Re: [PATCH v2 0/7] Exynos: MFC driver: reserved memory cleanup and IOMMU support

2015-12-14 Thread Marek Szyprowski
Hello, On 2015-12-13 20:52, Laurent Pinchart wrote: Hi Marek, Thank you for the patches. On Wednesday 09 December 2015 14:58:15 Marek Szyprowski wrote: Hello, This patchset finally perform cleanup of custom code in s5p-mfc codec driver. The first part is removal of custom, driver specific

Re: [PATCH 0/3] adv7604: .g_crop and .cropcap support

2015-12-14 Thread Hans Verkuil
On 12/13/2015 07:10 PM, Laurent Pinchart wrote: > Hi Hans, > > On Friday 11 December 2015 17:25:40 Hans Verkuil wrote: >> On 12/11/2015 05:04 PM, Ulrich Hecht wrote: >>> Hi! >>> >>> The rcar_vin driver relies on these methods. The third patch makes sure >>> that they return up-to-date data if

Re: [PATCH v2 4/8] dt-bindings: Add a binding for Mediatek Video Encoder

2015-12-14 Thread Matthias Brugger
On 14/12/15 09:26, tiffany lin wrote: On Fri, 2015-12-11 at 11:29 -0600, Rob Herring wrote: On Fri, Dec 11, 2015 at 05:55:39PM +0800, Tiffany Lin wrote: Add a DT binding documentation of Video Encoder for the MT8173 SoC from Mediatek. Signed-off-by: Tiffany Lin

Re: [PATCH 0/3] adv7604: .g_crop and .cropcap support

2015-12-14 Thread Hans Verkuil
On 12/11/2015 05:25 PM, Hans Verkuil wrote: > Hi Ulrich, > > On 12/11/2015 05:04 PM, Ulrich Hecht wrote: >> Hi! >> >> The rcar_vin driver relies on these methods. The third patch makes sure >> that they return up-to-date data if the input signal has changed since >> initialization. >> >> CU >>

Re: [PATCH v2 4/7] media: vb2-dma-contig: add helper for setting dma max seg size

2015-12-14 Thread Marek Szyprowski
Hello, On 2015-12-13 20:57, Laurent Pinchart wrote: Hi Marek, Thank you for the patch. On Wednesday 09 December 2015 14:58:19 Marek Szyprowski wrote: Add a helper function for device drivers to set DMA's max_seg_size. Setting it to largest possible value lets DMA-mapping API always create

[PATCH] saa7134: add DMABUF support

2015-12-14 Thread Hans Verkuil
Since saa7134 is now using vb2, there is no reason why we can't support dmabuf for this driver. Signed-off-by: Hans Verkuil --- drivers/media/pci/saa7134/saa7134-empress.c | 3 ++- drivers/media/pci/saa7134/saa7134-video.c | 3 ++- 2 files changed, 4 insertions(+), 2

[PATCH] mt9t001: fix clean up in case of power-on failures

2015-12-14 Thread Guennadi Liakhovetski
If the driver fails to reset the camera or to set up control handlers, it has to power the camera back off. Signed-off-by: Guennadi Liakhovetski --- drivers/media/i2c/mt9t001.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 6/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

2015-12-14 Thread Hans Verkuil
Hi Tiffany, My apologies for the long delay, but I finally have time to do a review of this code. On 12/11/2015 10:55 AM, Tiffany Lin wrote: > From: Andrew-CT Chen > > Add v4l2 layer encoder driver for MT8173 > > Signed-off-by: Tiffany Lin

cron job: media_tree daily build: WARNINGS

2015-12-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Dec 15 04:00:15 CET 2015 git branch: test git hash: 52d60eb7e6d6429a766ea1b8f67e01c3b2dcd3c5 gcc

Re: vsp1 BUG_ON() and crash (Re: [PATCH v9 03/12] media: Entities, pads and links)

2015-12-14 Thread Laurent Pinchart
Hi Geert, On Monday 14 December 2015 14:59:38 Geert Uytterhoeven wrote: > On Mon, Feb 14, 2011 at 1:20 PM, Laurent Pinchart > > wrote: > > +media_entity_create_link(struct media_entity *source, u16 source_pad, > > +struct media_entity

Re: [RFC PATCH 00/26] i.MX5/6 IPUv3 CSI/IC

2015-12-14 Thread Tim Harvey
On Tue, Dec 1, 2015 at 4:08 AM, Fabio Estevam wrote: > Hi Philipp, > > On Tue, Oct 27, 2015 at 11:10 AM, Fabio Estevam wrote: >> Hi Philipp, >> >> >> On Thu, Jun 12, 2014 at 2:06 PM, Philipp Zabel >> wrote: >>> Hi, >>> >>>

Re: [PATCH 0/3] adv7604: .g_crop and .cropcap support

2015-12-14 Thread Ulrich Hecht
On Mon, Dec 14, 2015 at 2:02 PM, Hans Verkuil wrote: > On 12/14/2015 01:55 PM, Ulrich Hecht wrote: >> On Mon, Dec 14, 2015 at 11:33 AM, Hans Verkuil wrote: >>> OK, my http://git.linuxtv.org/hverkuil/media_tree.git/log/?h=rmcrop branch >>> now has a >>>

Re: [RFC PATCH] vb2: Stop allocating 'alloc_ctx', just set the device instead

2015-12-14 Thread Laurent Pinchart
Hi Hans, On Monday 14 December 2015 15:36:04 Hans Verkuil wrote: > (Before I post this as the 'final' patch and CC all the driver developers > that are affected, I'd like to do an RFC post first. I always hated the > alloc context for obfuscating what is really going on, but let's see what >

Re: [PATCH v2 4/7] media: vb2-dma-contig: add helper for setting dma max seg size

2015-12-14 Thread Laurent Pinchart
Hi Marek, On Monday 14 December 2015 10:20:22 Marek Szyprowski wrote: > On 2015-12-13 20:57, Laurent Pinchart wrote: > > On Wednesday 09 December 2015 14:58:19 Marek Szyprowski wrote: > >> Add a helper function for device drivers to set DMA's max_seg_size. > >> Setting it to largest possible

Re: [PATCH 0/3] adv7604: .g_crop and .cropcap support

2015-12-14 Thread Hans Verkuil
On 12/14/2015 01:55 PM, Ulrich Hecht wrote: > On Mon, Dec 14, 2015 at 11:33 AM, Hans Verkuil wrote: >> OK, my http://git.linuxtv.org/hverkuil/media_tree.git/log/?h=rmcrop branch >> now has a >> rebased patch to remove g/s_crop. Only compile-tested. It's just the one >> patch

vsp1 BUG_ON() and crash (Re: [PATCH v9 03/12] media: Entities, pads and links)

2015-12-14 Thread Geert Uytterhoeven
On Mon, Feb 14, 2011 at 1:20 PM, Laurent Pinchart wrote: > +media_entity_create_link(struct media_entity *source, u16 source_pad, > +struct media_entity *sink, u16 sink_pad, u32 flags) > +{ > + struct media_link *link; > +

[PATCH v2 1/3] [media] mt9v032: Add reset and standby gpios

2015-12-14 Thread Markus Pargmann
Add optional reset and standby gpios. The reset gpio is used to reset the chip in power_on(). The standby gpio is not used currently. It is just unset, so the chip is not in standby. Signed-off-by: Markus Pargmann Reviewed-by: Philipp Zabel

[PATCH v2 3/3] [media] mt9v032: Add V4L2 controls for AEC and AGC

2015-12-14 Thread Markus Pargmann
This patch adds V4L2 controls for Auto Exposure Control and Auto Gain Control settings. These settings include low pass filter, update frequency of these settings and the update interval for those units. Signed-off-by: Markus Pargmann --- drivers/media/i2c/mt9v032.c | 153

[PATCH v2 2/3] [media] mt9v032: Do not unset master_mode

2015-12-14 Thread Markus Pargmann
The power_on function of the driver resets the chip and sets the CHIP_CONTROL register to 0. This switches the operating mode to slave. The s_stream function sets the correct mode. But this caused problems on a board where the camera chip is operated as master. The camera started after a random

Re: [PATCH 0/3] adv7604: .g_crop and .cropcap support

2015-12-14 Thread Ulrich Hecht
On Mon, Dec 14, 2015 at 11:33 AM, Hans Verkuil wrote: > OK, my http://git.linuxtv.org/hverkuil/media_tree.git/log/?h=rmcrop branch > now has a > rebased patch to remove g/s_crop. Only compile-tested. It's just the one > patch that you > need. Thank you, that works perfectly

[RFC PATCH] vb2: Stop allocating 'alloc_ctx', just set the device instead

2015-12-14 Thread Hans Verkuil
(Before I post this as the 'final' patch and CC all the driver developers that are affected, I'd like to do an RFC post first. I always hated the alloc context for obfuscating what is really going on, but let's see what others think). Instead of allocating a struct that contains just a single

Re: [Patch v5 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver

2015-12-14 Thread Hans Verkuil
On 12/11/2015 11:16 PM, Benoit Parrot wrote: > Mauro Carvalho Chehab wrote on Thu [2015-Dec-03 > 11:19:22 -0200]: >>> +static int cal_enum_framesizes(struct file *file, void *fh, >>> + struct v4l2_frmsizeenum *fsize) >>> +{ >>> + struct cal_ctx

re: [media] media-entity: protect object creation/removal using spin lock

2015-12-14 Thread Dan Carpenter
Hello Mauro Carvalho Chehab, The patch f8fd4c61b5ae: "[media] media-entity: protect object creation/removal using spin lock" from Dec 9, 2015, leads to the following static checker warning: drivers/media/media-entity.c:781 media_remove_intf_link() error: dereferencing freed

Re: [media] media-entity: protect object creation/removal using spin lock

2015-12-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Dec 2015 22:50:53 +0300 Dan Carpenter escreveu: > Hello Mauro Carvalho Chehab, > > The patch f8fd4c61b5ae: "[media] media-entity: protect object > creation/removal using spin lock" from Dec 9, 2015, leads to the > following static checker warning: > >

Re: [media] media-entity: protect object creation/removal using spin lock

2015-12-14 Thread Dan Carpenter
On Mon, Dec 14, 2015 at 06:00:52PM -0200, Mauro Carvalho Chehab wrote: > I guess gcc optimizer actually does the right thing, but we should > fix it to remove the static analyzer warnings. It probably crashes if you enable poisoning freed memory? (I haven't tested). regards, dan carpenter --

Re: [PATCH v2 1/3] [media] mt9v032: Add reset and standby gpios

2015-12-14 Thread Laurent Pinchart
Hi Markus, Thank you for the patch. On Monday 14 December 2015 15:41:51 Markus Pargmann wrote: > Add optional reset and standby gpios. The reset gpio is used to reset > the chip in power_on(). > > The standby gpio is not used currently. It is just unset, so the chip is > not in standby. > >

Re: [PATCH v2 2/3] [media] mt9v032: Do not unset master_mode

2015-12-14 Thread Laurent Pinchart
Hi Markus, Thank you for the patch. On Monday 14 December 2015 15:41:52 Markus Pargmann wrote: > The power_on function of the driver resets the chip and sets the > CHIP_CONTROL register to 0. This switches the operating mode to slave. > The s_stream function sets the correct mode. But this

Re: [PATCH v2 5/8] arm64: dts: mediatek: Add Video Encoder for MT8173

2015-12-14 Thread Matthias Brugger
On Friday 11 Dec 2015 17:55:40 Tiffany Lin wrote: > Add video encoder node for MT8173 > > Signed-off-by: Tiffany Lin > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 47 > ++ 1 file changed, 47 insertions(+) > > diff --git

Re: [yavta PATCH v2] Return proper error code if STREAMON fails

2015-12-14 Thread Laurent Pinchart
Hi Tuukka, On Monday 14 December 2015 09:49:57 Tuukka Toivonen wrote: > Return the error code if video_enable() and VIDIOC_STREAMON > fails. > > Signed-off-by: Tuukka Toivonen Applied to my tree and pushed, thank you for the patch. > --- > yavta.c | 4 +++- > 1

Re: [media] media-entity: protect object creation/removal using spin lock

2015-12-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Dec 2015 23:04:34 +0300 Dan Carpenter escreveu: > On Mon, Dec 14, 2015 at 06:00:52PM -0200, Mauro Carvalho Chehab wrote: > > I guess gcc optimizer actually does the right thing, but we should > > fix it to remove the static analyzer warnings. > > It probably

Re: [PATCH] mt9t001: fix clean up in case of power-on failures

2015-12-14 Thread Laurent Pinchart
Hi Guennadi, Thank you for the patch. On Monday 14 December 2015 10:58:29 Guennadi Liakhovetski wrote: > If the driver fails to reset the camera or to set up control handlers, it > has to power the camera back off. > > Signed-off-by: Guennadi Liakhovetski Acked-by:

Re: [PATCH v2 4/8] dt-bindings: Add a binding for Mediatek Video Encoder

2015-12-14 Thread tiffany lin
On Fri, 2015-12-11 at 11:29 -0600, Rob Herring wrote: > On Fri, Dec 11, 2015 at 05:55:39PM +0800, Tiffany Lin wrote: > > Add a DT binding documentation of Video Encoder for the > > MT8173 SoC from Mediatek. > > > > Signed-off-by: Tiffany Lin > > A question and minor