Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-27 Thread Sergei Shtylyov
On 12/27/2015 9:13 AM, Julia Lawall wrote: Well, looking again, the patch should be good. I just thought its goal was to fix the code as well... I could do that for the irq < 0 case, but I think that in that case, kbuild will only run the patch version, and the <= cases will not be

Probably a new board ID for em28xx: [1b80:e349]

2015-12-27 Thread Peter Schlaf
Hi, I have a small usb-device with s-vhs, composite-video and stereo-audio cabels attached. The shell just says "MAGIX" and "Made in China". It has also a black button to push. I plugged it in to get some video grabbed but no /dev/videoX was created. "lsusb" output: Bus 003

Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-27 Thread Julia Lawall
On Sun, 27 Dec 2015, SF Markus Elfring wrote: > > The error return value of platform_get_irq seems to often get dropped. > > How do you think about any more fine-tuning here? > > Commit message: > * … of the platform_get_irq() function seems to get dropped too often. > > * Why do you

[v4l-utils PATCH] man: Fix typos in dvbv5-scan dvbv5-zap pages

2015-12-27 Thread Chris Mayo
Signed-off-by: Chris Mayo --- utils/dvb/dvbv5-scan.1.in | 2 +- utils/dvb/dvbv5-zap.1.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/dvb/dvbv5-scan.1.in b/utils/dvb/dvbv5-scan.1.in index 8958ceb..e6fe3ee 100644 --- a/utils/dvb/dvbv5-scan.1.in

PCIe sg dma device used as dma-contig

2015-12-27 Thread Ran Shalit
Hello, The following question is not totally in the scope of v4l2, but more about your advise concering dma alternatives for non-expreciened v4l2 device writer. We intend to use the fpga for concurrent 3xHD and 3xSD. We have some dillema regadring the fpga to choose from: ALTERA fpga which use

Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-27 Thread SF Markus Elfring
>> https://cwe.mitre.org/data/definitions/252.html > > The value is not unchecked. Would you like to express any stronger relationship between the function call example and the occurrence of an if statement by the discussed SmPL script? > I made a specific rule because the specific problem is

[media] af9013: Checking for register accesses?

2015-12-27 Thread SF Markus Elfring
Hello, I have looked at the implementations of functions like the following once more. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/media/dvb-frontends/af9013.c?id=80c75a0f1d81922bf322c0634d1e1a15825a89e6#n124 * af9013_rd_regs * af9013_wr_regs Both functions will

Re: [PATCH v3 00/23] Unrestricted media entity ID range support

2015-12-27 Thread Laurent Pinchart
Hi Mauro, On Wednesday 23 December 2015 10:32:42 Mauro Carvalho Chehab wrote: > Em Wed, 16 Dec 2015 16:03:01 +0200 Sakari Ailus escreveu: > > On Wed, Dec 16, 2015 at 03:32:15PM +0200, Sakari Ailus wrote: > > > This is the third version of the unrestricted media entity ID range > > > support set.

[PATCH] [media] bttv: Returning only value constants in two functions

2015-12-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 27 Dec 2015 22:02:21 +0100 Return constant integer values without storing them in the local variable "err" or "rc". Signed-off-by: Markus Elfring --- drivers/media/pci/bt8xx/bttv-driver.c | 25

[PATCH] media: dvb_ringbuffer: Add memory barriers

2015-12-27 Thread Soeren Moch
Implement memory barriers according to Documentation/circular-buffers.txt: - use smp_store_release() to update ringbuffer read/write pointers - use smp_load_acquire() to load write pointer on reader side - use ACCESS_ONCE() to load read pointer on writer side This fixes data stream corruptions

[PATCH] [media] si2165: Refactoring for si2165_writereg_mask8()

2015-12-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 27 Dec 2015 18:23:57 +0100 This issue was detected by using the Coccinelle software. 1. Let us return directly if a call of the si2165_readreg8() function failed. 2. Reduce the scope for the local variables "ret" and "tmp" to

Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-27 Thread SF Markus Elfring
> The error return value of platform_get_irq seems to often get dropped. How do you think about any more fine-tuning here? Commit message: * … of the platform_get_irq() function seems to get dropped too often. * Why do you concentrate on a single function name? Do you plan to extend this

Re: [PATCH 1/1] v4l: subdev: Register the entity before calling subdev's registered op

2015-12-27 Thread kbuild test robot
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system] Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.4-rc6 next-20151223] url:

Re: [PATCH 2/2] [media] media: move MEDIA_LNK_FL_INTERFACE_LINK logic to link creation

2015-12-27 Thread Sakari Ailus
Hi Mauro, (Resending, there was an error in handling the cc field.) On Fri, Dec 11, 2015 at 06:17:53PM -0200, Mauro Carvalho Chehab wrote: > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > index 181ca0de6e52..7895e17aeee9 100644 > --- a/drivers/media/media-entity.c >

[PATCH 1/1] v4l: subdev: Register the entity before calling subdev's registered op

2015-12-27 Thread Sakari Ailus
Registering a V4L2 sub-device includes, among other things, registering the related media entity and calling the sub-device's registered op. Since patch "media: convert links from array to list", creating a link between two pads requires registering the entity first. If the registered() op

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-27 Thread Sakari Ailus
Hi Mauro, On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > Em Thu, 10 Sep 2015 20:14:04 +0300 > Sakari Ailus escreveu: > > > Hi Javier, > > > > Thanks for the set! A few comments below. > > > > Javier Martinez Canillas wrote: > > > The

Re: [PATCH v3 00/23] Unrestricted media entity ID range support

2015-12-27 Thread Javier Martinez Canillas
Hello Laurent, On 12/27/2015 02:11 PM, Laurent Pinchart wrote: > Hi Mauro, > > On Wednesday 23 December 2015 10:32:42 Mauro Carvalho Chehab wrote: >> Em Wed, 16 Dec 2015 16:03:01 +0200 Sakari Ailus escreveu: >>> On Wed, Dec 16, 2015 at 03:32:15PM +0200, Sakari Ailus wrote: This is the third

cron job: media_tree daily build: OK

2015-12-27 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Dec 28 04:00:15 CET 2015 git branch: test git hash: 768acf46e1320d6c41ed1b7c4952bab41c1cde79 gcc

Your company import from China, we help in logistics field.

2015-12-27 Thread Alfred
Dear Sirs: Glad to write you! Does your company have imported goods from China?If so, please send your packing list to me.I can give you a quotation for reference. Hope our years of experience in the logistics field and good service can give you help. Happy new year.