[PATCH] [media] au0828: Refactoring for start_urb_transfer()

From: Markus Elfring Date: Mon, 28 Dec 2015 22:52:48 +0100 This issue was detected by using the Coccinelle software. 1. Let us return directly if a buffer allocation failed. 2. Delete the jump label "err" then. 3. Drop the explicit initialisation for the

Assalam o Alaikum

Cordial greeting message from Eva Zahra, I am seeking for your help,I will be very glad if you do assist me to relocate a sum of (US$4 Million Dollars)into your Bank account in your country for the benefit of both of us i want to use this money for investment. I will give you more details as

Re: [PATCH v3 00/23] Unrestricted media entity ID range support

Em Sun, 27 Dec 2015 19:11:36 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Wednesday 23 December 2015 10:32:42 Mauro Carvalho Chehab wrote: > > Em Wed, 16 Dec 2015 16:03:01 +0200 Sakari Ailus escreveu: > > > On Wed, Dec 16, 2015 at 03:32:15PM +0200,

Re: Automatic device driver back-porting with media_build

On 28/12/2015 11:44, Mason wrote: > Hello Mauro, > > Haven't heard back from you in a while. Maybe someone else can point > out what I'm doing wrong? > > On 17/12/2015 13:55, Mauro Carvalho Chehab wrote: > >> Mason wrote: >> >>> I have a TechnoTrend TT-TVStick CT2-4400v2 USB tuner, as

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Em Mon, 28 Dec 2015 03:14:53 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > > Em Thu, 10 Sep 2015 20:14:04 +0300 > > Sakari Ailus escreveu: > > > > > Hi Javier, > > > > >

Re: [PATCH 2/2] [media] media: move MEDIA_LNK_FL_INTERFACE_LINK logic to link creation

Em Mon, 28 Dec 2015 02:31:32 +0200 Sakari Ailus escreveu: > Hi Mauro, > > (Resending, there was an error in handling the cc field.) > > On Fri, Dec 11, 2015 at 06:17:53PM -0200, Mauro Carvalho Chehab wrote: > > diff --git a/drivers/media/media-entity.c

Re: [media] tuners: One check less in m88rs6000t_get_rf_strength() after error detection

On Mon, 28 Dec 2015, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "ret" will not be checked once more > >> after it was determined that a function call failed. > > > > Why not avoid both unnecessary ifs > > I would find

Re: [PATCH] [media] tuners: One check less in m88rs6000t_get_rf_strength() after error detection

On Mon, 28 Dec 2015, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 28 Dec 2015 10:10:34 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable "ret"

Re: [media] tuners: One check less in m88rs6000t_get_rf_strength() after error detection

>> Move the jump label directly before the desired log statement >> so that the variable "ret" will not be checked once more >> after it was determined that a function call failed. > > Why not avoid both unnecessary ifs I would find such a fine-tuning also nice in principle at more source code

Re: Automatic device driver back-porting with media_build

Hello Mauro, Haven't heard back from you in a while. Maybe someone else can point out what I'm doing wrong? On 17/12/2015 13:55, Mauro Carvalho Chehab wrote: > Mason wrote: > >> I have a TechnoTrend TT-TVStick CT2-4400v2 USB tuner, as described here: >>

[PATCH] [media] tuners: One check less in m88rs6000t_get_rf_strength() after error detection

From: Markus Elfring Date: Mon, 28 Dec 2015 10:10:34 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "ret" will not be checked once more after it was determined that

[PATCH 1/2] [media] m88rs6000t: Better exception handling in five functions

From: Markus Elfring Date: Mon, 28 Dec 2015 15:10:30 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "ret" will not be checked once more after a function call. Use

Re: [media] m88rs6000t: Better exception handling in five functions

On Mon, 28 Dec 2015, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "ret" will not be checked once more > >> after a function call. > > > > This commit message fits with the previous change. > > Do you prefer an other wording?

[media] r820t: Checking lock scopes around i2c_gate_ctrl() calls?

Hello, I have looked at the implementation of the function "r820t_signal" once more. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/media/tuners/r820t.c?id=80c75a0f1d81922bf322c0634d1e1a15825a89e6#n2242 The function which was assigned to the pointer "i2c_gate_ctrl"

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

Em Mon, 28 Dec 2015 08:26:33 -0200 Mauro Carvalho Chehab escreveu: > Em Mon, 28 Dec 2015 03:14:53 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > > > Em Thu, 10 Sep

Re: [PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

Hello Mauro, On 12/28/2015 11:03 AM, Mauro Carvalho Chehab wrote: > There are a few discussions left with regards to this ioctl: > > 1) the name of the new structs will contain _v2_ on it? > 2) what's the best alternative to avoid compat32 issues? > > Due to that, let's postpone the addition of

Re: [PATCH 1/1] v4l: subdev: Register the entity before calling subdev's registered op

Em Mon, 28 Dec 2015 01:45:00 +0200 Sakari Ailus escreveu: > Registering a V4L2 sub-device includes, among other things, registering > the related media entity and calling the sub-device's registered op. Since > patch "media: convert links from array to list", creating a link

Re: Automatic device driver back-porting with media_build

Hi Mason, Em Mon, 28 Dec 2015 13:21:03 +0100 Mason escreveu: > On 28/12/2015 11:44, Mason wrote: > > > Hello Mauro, > > > > Haven't heard back from you in a while. Maybe someone else can point > > out what I'm doing wrong? > > > > On 17/12/2015 13:55, Mauro Carvalho Chehab

[PATCH 2/2] [media] tuners: Refactoring for m88rs6000t_sleep()

From: Markus Elfring Date: Mon, 28 Dec 2015 15:20:45 +0100 This issue was detected by using the Coccinelle software. 1. Let us return directly if a call of the regmap_write() function failed. 2. Delete the jump label "err" then. 3. Return zero as a constant at

Re: On Lindent shortcomings and massive style fixing

On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > After some iterations of checkpatch.pl, on a new developed driver > (tw5864), now I have the following: > > $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c > 31 ERROR: do not use C99 // comments > 147

[PATCH 0/2] [media] m88rs6000t: Fine-tuning for some function implementations

From: Markus Elfring Date: Mon, 28 Dec 2015 15:32:20 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Better exception handling in five functions Refactoring for m88rs6000t_sleep()

Re: [PATCH 1/1] v4l: subdev: Register the entity before calling subdev's registered op

Hi Mauro, On Mon, Dec 28, 2015 at 10:41:58AM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 28 Dec 2015 01:45:00 +0200 > Sakari Ailus escreveu: > > > Registering a V4L2 sub-device includes, among other things, registering > > the related media entity and calling the

Re: [PATCH 1/1] v4l: subdev: Register the entity before calling subdev's registered op

Em Mon, 28 Dec 2015 15:18:06 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Dec 28, 2015 at 10:41:58AM -0200, Mauro Carvalho Chehab wrote: > > Em Mon, 28 Dec 2015 01:45:00 +0200 > > Sakari Ailus escreveu: > > > > > Registering a V4L2 sub-device

[PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

There are a few discussions left with regards to this ioctl: 1) the name of the new structs will contain _v2_ on it? 2) what's the best alternative to avoid compat32 issues? Due to that, let's postpone the addition of this new ioctl to the next Kernel version, to give people more time to discuss

On Lindent shortcomings and massive style fixing

After some iterations of checkpatch.pl, on a new developed driver (tw5864), now I have the following: $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c 31 ERROR: do not use C99 // comments 147 WARNING: Block comments use a trailing */ on a separate line 144 WARNING:

Re: [PATCH 1/2] [media] m88rs6000t: Better exception handling in five functions

On Mon, 28 Dec 2015, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 28 Dec 2015 15:10:30 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable

Re: [media] m88rs6000t: Better exception handling in five functions

>> Move the jump label directly before the desired log statement >> so that the variable "ret" will not be checked once more >> after a function call. > > This commit message fits with the previous change. Do you prefer an other wording? > It could be nice to put a blank line before the error

[PATCH 1/2] [media] r820t: Delete an unnecessary variable initialisation in generic_set_freq()

From: Markus Elfring Date: Mon, 28 Dec 2015 16:36:44 +0100 The variable "rc" will be set to an appropriate value from a call of the r820t_set_tv_standard() function. Thus let us omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring

Happy New Year's Day

外贸客户开发，专业的事情专业人做 主动式优质客户开发，精准定位全球目标客户，终端客户，精准高效邮件推广送达客户邮箱，为你不断创造优质询盘，这些我们做。 用你的专业跟进意向客户，创造订单！ 详询请加Q--Q:2036-019519请你10分钟了解功能。

[PATCH 2/2] [media] r820t: Better exception handling in generic_set_freq()

From: Markus Elfring Date: Mon, 28 Dec 2015 17:13:02 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "rc" will not be checked once more after a function call. Use

Re: [PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

On Mon, Dec 28, 2015 at 08:37:19AM -0700, Shuah Khan wrote: > On 12/28/2015 07:03 AM, Mauro Carvalho Chehab wrote: > > There are a few discussions left with regards to this ioctl: > > > > 1) the name of the new structs will contain _v2_ on it? > > 2) what's the best alternative to avoid compat32

Re: [PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

On 12/28/2015 08:44 AM, Greg KH wrote: > On Mon, Dec 28, 2015 at 08:37:19AM -0700, Shuah Khan wrote: >> On 12/28/2015 07:03 AM, Mauro Carvalho Chehab wrote: >>> There are a few discussions left with regards to this ioctl: >>> >>> 1) the name of the new structs will contain _v2_ on it? >>> 2)

[PATCH 0/2] [media] r820t: Fine-tuning for generic_set_freq()

From: Markus Elfring Date: Mon, 28 Dec 2015 17:18:34 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an unnecessary variable initialisation Better exception handling

Re: [PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

On 12/28/2015 07:03 AM, Mauro Carvalho Chehab wrote: > There are a few discussions left with regards to this ioctl: > > 1) the name of the new structs will contain _v2_ on it? > 2) what's the best alternative to avoid compat32 issues? > > Due to that, let's postpone the addition of this new

[PATCH] [media] airspy: Better exception handling in two functions

From: Markus Elfring Date: Mon, 28 Dec 2015 22:10:28 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "ret" will not be checked once more after a function call. Use

[PATCH] [media] xc5000: Faster result reporting in xc_load_fw_and_init_tuner()

From: Markus Elfring Date: Mon, 28 Dec 2015 20:10:30 +0100 This issue was detected by using the Coccinelle software. Split the previous if statement at the end so that each final log statement will eventually be performed by a direct jump to these labels. *

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Dec 29 04:00:16 CET 2015 git branch: test git hash: 768acf46e1320d6c41ed1b7c4952bab41c1cde79 gcc

Donation/Charity

Hi, My name is Jeffrey Skoll, a philanthropist and the founder of one of the largest private foundations in the world. I believe strongly in ‘giving while living.’ I had one idea that never changed in my mind — that you should use your wealth to help people and I have decided to secretly give

Charity Donation

Hi, My name is Jeffrey Skoll, a philanthropist and the founder of one of the largest private foundations in the world. I believe strongly in ‘giving while living.’ I had one idea that never changed in my mind — that you should use your wealth to help people and I have decided to secretly give

Re: On Lindent shortcomings and massive style fixing

Em Mon, 28 Dec 2015 07:33:32 -0800 Greg KH escreveu: > On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > > After some iterations of checkpatch.pl, on a new developed driver > > (tw5864), now I have the following: > > > > $ grep 'WARNING\|ERROR'