[TRIVIAL PATCH] treewide: Remove unnecessary 0x prefixes before %pa extension uses

Since commit 3cab1e711297 ("lib/vsprintf: refactor duplicate code to special_hex_number()") %pa uses have been ouput with a 0x prefix. These 0x prefixes in the formats are unnecessary. Signed-off-by: Joe Perches --- drivers/dma/at_hdmac_regs.h | 2 +-

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

2016-03-05 5:20 GMT+09:00 Javier Martinez Canillas : > Hello, > > This series have two trivial fixes for issues that I noticed while > reading as a reference the driver's functions that parse the graph > port and endpoints nodes. > > It was only compile tested because I

Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-04 20:02 GMT+09:00 Sylwester Nawrocki : > On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote: >> The MFD_SYSCON depends on HAS_IOMEM so when selecting >> it avoid unmet direct dependencies. > >> diff --git a/drivers/media/platform/exynos4-is/Kconfig >>

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Mar 5 04:00:17 CET 2016 git branch: test git hash: 1e89f58499f3351a3b3c61dae8213fe3cd24a476 gcc

Re: [PATCH] [media] hide unused functions for !MEDIA_CONTROLLER

On 03/04/2016 05:06 PM, Arnd Bergmann wrote: > Some functions in the au0828 driver are only used when CONFIG_MEDIA_CONTROLLER > is enabled, and otherwise defined as empty functions: > > media/usb/au0828/au0828-core.c:208:13: error: 'au0828_media_graph_notify' > defined but not used

[PATCH] [media] hide unused functions for !MEDIA_CONTROLLER

Some functions in the au0828 driver are only used when CONFIG_MEDIA_CONTROLLER is enabled, and otherwise defined as empty functions: media/usb/au0828/au0828-core.c:208:13: error: 'au0828_media_graph_notify' defined but not used [-Werror=unused-function] media/usb/au0828/au0828-core.c:262:12:

Re: DVBSky T980C CI issues (kernel 4.0.x)

using a 4.2 kernel i get a bit further but now i'm getting a completely different oops: [ 181.077662] BUG: unable to handle kernel NULL pointer dereference at 0010 [ 181.077723] IP: [] v4l_vb2q_enable_media_source+0x9/0x40 [videodev] latest git code is too unstable for testing

[PATCH] [media] em28xx: fix Terratec Grabby AC97 codec detection

EMP202 chip inside Terratec Grabby (hw rev 2) seems to require some time before accessing reliably its registers. Otherwise it returns some values previously put on the I2C bus. To account for that period, we delay card setup until we have a proof that accessing AC97 registers is reliable. We get

[PATCH] Fix Terratec Grabby AC97 codec detection

Thanks Mauro for commenting on my work. With respect to first version, I've: * added a timeout mecanism as requested * added an extra check to avoid cases when the same value is constantly returned no matter which register is accessed. --- To test this: * modprobe em28xx-alsa * connect Grabby *

[PATCH v2] media: add prefixes to interface types

Add missing prefixes for DVB, V4L, and ALSA interface types. Signed-off-by: Shuah Khan --- Changes since v1: Addresses Hans's comments on v1 drivers/media/media-entity.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff

Re: [PATCH] media: add prefixes to interface types

Hi Hans, Thanks for the review. Mauro, Do you prefer dvb-conditional-access or dvb-ca? thanks, -- Shuah On 03/04/2016 01:25 AM, Hans Verkuil wrote: > > > On 03/04/2016 01:08 AM, Shuah Khan wrote: >> Add missing prefixes for DVB, V4L, and ALSA interface types. >> >> Signed-off-by: Shuah Khan

Re: [PATCH] [media] media-device: map new functions into old types for legacy API

Hi Mauro, Thank you for the patch. On Friday 04 March 2016 07:43:37 Mauro Carvalho Chehab wrote: > The media-ctl tool, on versions <= 1.10 relies on detecting the > media_type to identify V4L2 sub-devices and MEDIA_ENT_T_DEVNODE. 1.10 is the latest version, and the problem is still present in

[GIT PULL FOR v4.6] Media entity type

Hi Mauro, The following changes since commit 1e89f58499f3351a3b3c61dae8213fe3cd24a476: [media] v4l2-mc.h: fix yet more compiler errors (2016-03-04 07:56:43 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git v4l2/core for you to fetch changes up to

[PATCH 1/2] [media] exynos4-is: Put node before s5pcsis_parse_dt() return error

The MIPI CSIS DT parse function return an -ENXIO errno if the port # is outside of the supported values. But it doesn't call of_node_put() to decrement the node's reference counter, that's incremented inside the of_graph_get_next_endpoint() function that was called before. Instead of just

[PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint

The fimc_md_parse_port_node() function return 0 if an endpoint node is not found but according to Documentation/devicetree/bindings/graph.txt, a port must always have at least one enpoint. So return an -EINVAL errno code to the caller instead, so it knows that the port node parse failed due an

[PATCH v4 4/4] media: Rename is_media_entity_v4l2_io to is_media_entity_v4l2_video_device

All users of is_media_entity_v4l2_io() (the exynos4-is, omap3isp, davince_vpfe and omap4iss drivers and the v4l2-mc power management code) use the function to check whether entities are video_device instances, either to ensure they can cast the entity to a struct video_device, or to count the

[PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

Hello, This series have two trivial fixes for issues that I noticed while reading as a reference the driver's functions that parse the graph port and endpoints nodes. It was only compile tested because I don't have access to a Exynos4 hardware to test the DT parsing, but the patches are very

[PATCH v4 3/4] media: Add type field to struct media_entity

Code that processes media entities can require knowledge of the structure type that embeds a particular media entity instance in order to cast the entity to the proper object type. This needs is shown by the presence of the is_media_entity_v4l2_io and is_media_entity_v4l2_subdev functions. The

[PATCH v4 2/4] v4l: exynos4-is: Drop unneeded check when setting up fimc-lite links

The driver verifies that the type of the remote entity matches its expectations when setting up fimc-lite links and returns an error if it doesn't. Those checks can never fail as the links are created by the driver in a way that always match its expectations (the SINK and SOURCE_ISP pads are

[PATCH v4 1/4] v4l: vsp1: Check if an entity is a subdev with the right function

Use is_media_entity_v4l2_subdev() instead of is_media_entity_v4l2_io() to check whether the entity is a subdev. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v4 0/4] media: Add entity types

Hello, This patch series adds a type field to the media entity structure. It is a resend of v3 rebased on top of the latest media master branch, with acks collected and spelling mistakes fixed. I have dropped patches 5 to 7 as they don't depend on 1-4 and Hans would like to get them merged

Re: [PATCH 4/8] media: Rename is_media_entity_v4l2_io to is_media_entity_v4l2_video_device

Hi Hans, On Thursday 03 March 2016 14:33:19 Hans Verkuil wrote: > On 03/01/16 15:57, Laurent Pinchart wrote: > > All users of is_media_entity_v4l2_io() (the exynos4-is, omap3isp, > > davince_vpfe and omap4iss drivers) use the function to check whether > > entities are video_device instances,

Re: [PATCHv12 05/17] HID: add HDMI CEC specific keycodes

On Wed, Feb 10, 2016 at 01:51:39PM +0100, Hans Verkuil wrote: > From: Kamil Debski > > Add HDMI CEC specific keycodes to the keycodes definition. > > Signed-off-by: Kamil Debski > Signed-off-by: Hans Verkuil > --- >

[PATCH] media: rc: nuvoton: switch attribute wakeup_data to text

Switch attribute wakeup_data from binary to a text attribute. This makes it easier to handle in userspace and allows to use the output of tools like mode2 almost as is to set a wakeup sequence. Changing to a text format and values in microseconds also makes the userspace interface independent of

Re: [PATCH v4 18/18] i2c-mux: relax locking of the top i2c adapter during i2c controlled muxing

-and-locking-update/20160304-112229 config: i386-allmodconfig (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "i2c_root_adapter" undefined! >> ERROR: "i2

[PATCH] [media] v4l2-ioctl: fix YUV422P pixel format description

The plane order is YUV, not YVU. Signed-off-by: Philipp Zabel --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 8a018c6..52f5ba2

[PATCH] v4l2-mc.h: fix build failure

We are getting build failure with arm for configurations like exynos_defconfig, at91_dt_defconfig where MEDIA_CONTROLLER is not defined. While adding stubs static inline was missed and an extra ';' was added. Fixes: a77bf7048add ("v4l2-mc.h: Add stubs for the V4L2 PM/pipeline routines")

Re: [PATCH] [media] v4l2/dvb: allow v4l2_mc functions to be used by dvb

On Thursday 03 March 2016 14:29:53 Mauro Carvalho Chehab wrote: > Em Sun, 28 Feb 2016 21:51:48 +0100 > Arnd Bergmann escreveu: > > > In a configuration that supports all DVB drivers but that disables > > V4L2 or builds it as a loadable module, we get link errors because > > of the

Re: [PATCH v4 00/18] i2c mux cleanup and locking update

I wrote: > I wrote: >> Concerns: >> - The locking is perhaps too complex? > > Ok, to highlight the benefits of this series, I expect that patches such as > [1] and the one inlined below can follow up to clean up ad-hoc i2c locking > in drivers. Putting this locking in one place instead of having

Re: Kernel docs: muddying the waters a bit

On Fri, Mar 04, 2016 at 09:59:50AM -0300, Mauro Carvalho Chehab wrote: > > 3) I tried to use a .. cssclass, as Johannes suggested, but > I was not able to include the CSS file. I suspect that this is > easy to fix, but I want to see if the cssclass will also work for > the pdf output as well.

Re: tw686x driver

On 03/04/2016 01:37 PM, Krzysztof Hałasa wrote: > Hans Verkuil writes: > >> I have two drivers with different feature sets. Only one can be active >> at a time. I have to make a choice which one I'll take and Ezequiel's >> version has functionality (audio, interlaced

Re: Kernel docs: muddying the waters a bit

Em Fri, 04 Mar 2016 10:29:08 +0200 Jani Nikula escreveu: > On Fri, 04 Mar 2016, Mauro Carvalho Chehab wrote: > > Em Thu, 03 Mar 2016 15:23:23 -0800 > > Keith Packard escreveu: > > > >> Mauro Carvalho Chehab

Re: [PATCH 1/2] [media] vb2-memops: Fix over allocation of frame vectors

On Thu 03-03-16 20:12:48, Ricardo Ribalda Delgado wrote: > On page unaligned frames, create_framevec forces get_vaddr_frames to > allocate an extra page at the end of the buffer. Under some > circumstances, this leads to -EINVAL on VIDIOC_QBUF. > > E.g: > We have vm_a that vm_area that goes from

Re: tw686x driver

Hans Verkuil writes: > I have two drivers with different feature sets. Only one can be active > at a time. I have to make a choice which one I'll take and Ezequiel's > version has functionality (audio, interlaced support) which matches best > with existing v4l applications

Re: [PATCHv12 05/17] HID: add HDMI CEC specific keycodes

Dmitry, Ping? Please? I can't merge this without your Ack. Regards, Hans On 02/24/2016 09:31 AM, Hans Verkuil wrote: > Dmitry, > > Ping! > > Regards, > > Hans > > On 02/12/16 10:27, Hans Verkuil wrote: >> Dmitry, >> >> Can you provide an Ack for this patch? >> >> Thanks! >>

Re: DVBSky T980C CI issues (kernel 4.0.x)

Hi Olli, On Fri, 2016-03-04 at 10:28 +0200, Olli Salonen wrote: > Hi Jurgen, > > Ah, that's interesting. My T980C (and based on printout from Torbjörn > his as well) have Si2168-A20 chips. > > Some things I'd like to understand: > - is there a difference if the CI slot is populated or not? Not

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Mar 4 12:00:28 CET 2016 git branch: test git hash: 1e89f58499f3351a3b3c61dae8213fe3cd24a476 gcc

Re: tw686x driver

On 03/04/2016 07:11 AM, Krzysztof Hałasa wrote: > Hans Verkuil writes: > >>> Staging is meant for completely different situation - for immature, >>> incomplete code. It has nothing to do with the case. >> >> It can be for anything that prevents it from being mainlined. It was

Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting > it avoid unmet direct dependencies. > diff --git a/drivers/media/platform/exynos4-is/Kconfig > b/drivers/media/platform/exynos4-is/Kconfig > index 57d42c6172c5..c4317b99d257 100644 > ---

Re: [PATCH v4 00/18] i2c mux cleanup and locking update

I wrote: > Concerns: > - The locking is perhaps too complex? Ok, to highlight the benefits of this series, I expect that patches such as [1] and the one inlined below can follow up to clean up ad-hoc i2c locking in drivers. Putting this locking in one place instead of having it spread out in

[GIT PULL FOR v4.5] v4l2 core fixes/enhancements

The first two patches fix a bug in the core cropcap handling. I found this while reviewing the upcoming r-car vin driver. The last three patches add core support for the device_caps. Having this in place gives the core a lot more knowledge about the capabilities of v4l2 device nodes. I plan to

Re: [PATCH] v4l2-mc.h: fix PM/pipeline stub definitions

Em Fri, 04 Mar 2016 11:13:36 +0100 Arnd Bergmann escreveu: > The newly added functions have an extra semicolon, which > prevents compilation, and they need to be marked inline: > > In file included from ../include/media/tuner.h:23:0, > from

[PATCH] [media] media-device: map new functions into old types for legacy API

The media-ctl tool, on versions <= 1.10 relies on detecting the media_type to identify V4L2 sub-devices and MEDIA_ENT_T_DEVNODE. If the device doesn't match the MEDIA_ENT_T_V4L2_SUBDEV range, it ignores the major/minor and won't be getting the device name on udev or sysfs. It will also ignore the

[PATCH] v4l2-mc.h: fix PM/pipeline stub definitions

The newly added functions have an extra semicolon, which prevents compilation, and they need to be marked inline: In file included from ../include/media/tuner.h:23:0, from ../drivers/media/tuners/tuner-simple.c:10: ../include/media/v4l2-mc.h:233:1: error: expected identifier or

Re: [PATCH v4 16/18] i2c: allow adapter drivers to override the adapter locking

Hi! Here's a fixup for a problem found by the test robot. Sorry for the inconvenience. Cheers, Peter diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 6be266c3d39b..5ecc6fc52ce0 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -961,6 +961,8 @@ static int

Re: [PATCH 1/2] [media] vb2-memops: Fix over allocation of frame vectors

Hello, On 2016-03-03 20:12, Ricardo Ribalda Delgado wrote: On page unaligned frames, create_framevec forces get_vaddr_frames to allocate an extra page at the end of the buffer. Under some circumstances, this leads to -EINVAL on VIDIOC_QBUF. E.g: We have vm_a that vm_area that goes from 0x1000

Re: Kernel docs: muddying the waters a bit

On Fri, Mar 04, 2016 at 10:29:08AM +0200, Jani Nikula wrote: > On Fri, 04 Mar 2016, Mauro Carvalho Chehab wrote: > > > > If, on the other hand, we decide to use RST, we'll very likely need to > > patch it to fulfill our needs in order to add proper table support. > > I've

[PATCH] v4l2-mc.h: fix yet more compiler errors

Remove spurious return, remove copy-and-pasted semi-colons, add static inline. Signed-off-by: Hans Verkuil --- Third time in quick succession that these stubs are messed up. Please do a build without CONFIG_MEDIA_CONTROLLER before merging! --- diff --git

Re: Kernel docs: muddying the waters a bit

On Fri, 04 Mar 2016, Mauro Carvalho Chehab wrote: > Em Thu, 03 Mar 2016 15:23:23 -0800 > Keith Packard escreveu: > >> Mauro Carvalho Chehab writes: >> >> > On my tests, Sphinix seemed too limited to format tables. Asciidoc >>

Re: DVBSky T980C CI issues (kernel 4.0.x)

Hi Jurgen, Ah, that's interesting. My T980C (and based on printout from Torbjörn his as well) have Si2168-A20 chips. Some things I'd like to understand: - is there a difference if the CI slot is populated or not? - is there any difference between the different firmwares? - does it work with the

Re: [PATCH] media: add prefixes to interface types

On 03/04/2016 01:08 AM, Shuah Khan wrote: > Add missing prefixes for DVB, V4L, and ALSA interface types. > > Signed-off-by: Shuah Khan > --- > drivers/media/media-entity.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) > >

Re: DVBSky T980C CI issues (kernel 4.0.x)

Hi Olli, On Thu, 2016-03-03 at 13:02 +0200, Olli Salonen wrote: > Hi Jurgen, Torbjörn, > > I've noticed that there is currently a small confusion about the > firmware versions for the Si2168-A20 demodulator. This is used in the > older versions of DVBSky T680C (TechnoTrend CT2-4650 CI) and

Re: AverMedia HD Duet (White Box) A188WB drivers

Hi Olli, Most of the work which went into the saa716x (saa7160xx and sa7162x) I had pushed out to http://git.linuxtv.org//manu/saa716x_new.git/ so that people were able to use it while it was being developed. There were some issues over here (things went through a data recovery process), which