[PATCH] i2c: saa7115: Support CJC7113 detection

2016-03-22 Thread Ezequiel Garcia
From: Kevin Fitch It's been reported that CJC7113 devices are returning all 1s when reading register 0: "" found @ 0x4a (stk1160) This new device is apparently compatible with SA7113, so let's add a quirk to allow its autodetection. Given there isn't any

cron job: media_tree daily build: OK

2016-03-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 23 04:00:25 CET 2016 git branch: test git hash: 2705c1a96f978450377f1019d4bef34190b4ef05 gcc

[sailus-media:master 9/14] DockBook: include/media/media-device.h:629: warning: No description found for parameter 'mdev'

2016-03-22 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 2705c1a96f978450377f1019d4bef34190b4ef05 commit: 44ff16d0b7ccb4c872de7a53196b2d3f83089607 [9/14] [media] media-device: use kref for media_device instance reproduce: make htmldocs All warnings (new ones prefixed by >>):

Re: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint

2016-03-22 Thread Javier Martinez Canillas
Hello Sylwester, On 03/11/2016 10:03 AM, Sylwester Nawrocki wrote: > On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote: >> The fimc_md_parse_port_node() function return 0 if an endpoint node is >> not found but according to Documentation/devicetree/bindings/graph.txt, >> a port must always

Re: [PATCH v2] [media] media-device: use kref for media_device instance

2016-03-22 Thread Shuah Khan
On 03/18/2016 06:42 PM, Mauro Carvalho Chehab wrote: > Now that the media_device can be used by multiple drivers, > via devres, we need to be sure that it will be dropped only > when all drivers stop using it. > > Signed-off-by: Mauro Carvalho Chehab > --- > > v2: The

Re: [PATCH 4/5] [media] media-device: use kref for media_device instance

2016-03-22 Thread Shuah Khan
On 03/22/2016 01:56 PM, Shuah Khan wrote: > On 03/16/2016 06:04 AM, Mauro Carvalho Chehab wrote: >> Now that the media_device can be used by multiple drivers, >> via devres, we need to be sure that it will be dropped only >> when all drivers stop using it. >> >> Signed-off-by: Mauro Carvalho

Re: [PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-22 Thread Shuah Khan
On 03/16/2016 06:04 AM, Mauro Carvalho Chehab wrote: > When multiple drivers are sharing the media_device struct, > one driver cannot know the right moment to cleanup the > media_device struct, because it can happen only when the > struct is not used by the other drivers. > > So, let's call

Re: [PATCH 4/5] [media] media-device: use kref for media_device instance

2016-03-22 Thread Shuah Khan
On 03/16/2016 06:04 AM, Mauro Carvalho Chehab wrote: > Now that the media_device can be used by multiple drivers, > via devres, we need to be sure that it will be dropped only > when all drivers stop using it. > > Signed-off-by: Mauro Carvalho Chehab Tested bind_unbind

Re: [PATCH 3/5] [media] au0828: Unregister notifiers

2016-03-22 Thread Shuah Khan
On 03/16/2016 06:04 AM, Mauro Carvalho Chehab wrote: > If au0828 gets removed, we need to remove the notifiers. > > Signed-off-by: Mauro Carvalho Chehab Tested bind_unbind au0828 loop 1000 times, followed by bind_unbind snd_usb_audio loop 1000 times. Didn't see any lock

Re: [PATCH 1/5] [media] media-device: get rid of the spinlock

2016-03-22 Thread Shuah Khan
On 03/16/2016 06:04 AM, Mauro Carvalho Chehab wrote: > Right now, the lock schema for media_device struct is messy, > since sometimes, it is protected via a spin lock, while, for > media graph traversal, it is protected by a mutex. > > Solve this conflict by always using a mutex. > > As a side

Re: [PATCH] [media] au0828: Fix dev_state handling

2016-03-22 Thread Shuah Khan
On 03/22/2016 07:16 AM, Mauro Carvalho Chehab wrote: > The au0828 dev_state is actually a bit mask. It should not be > checking with "==" but, instead, with a logic and. There are some > places where it was doing it wrong. > > Fix that by replacing the dev_state set/clear/test with the > bitops.

Re: [PATCH] sound/usb: fix to release stream resources from media_snd_device_delete()

2016-03-22 Thread Mauro Carvalho Chehab
Em Tue, 22 Mar 2016 11:29:34 -0600 Shuah Khan escreveu: > On 03/22/2016 07:03 AM, Shuah Khan wrote: > > On 03/21/2016 10:01 PM, Shuah Khan wrote: > >> On 03/19/2016 07:31 AM, Shuah Khan wrote: > >>> On 03/19/2016 06:10 AM, Mauro Carvalho Chehab wrote: > Em

Re: [PATCH] sound/usb: fix to release stream resources from media_snd_device_delete()

2016-03-22 Thread Shuah Khan
On 03/22/2016 07:03 AM, Shuah Khan wrote: > On 03/21/2016 10:01 PM, Shuah Khan wrote: >> On 03/19/2016 07:31 AM, Shuah Khan wrote: >>> On 03/19/2016 06:10 AM, Mauro Carvalho Chehab wrote: Em Fri, 18 Mar 2016 20:50:31 -0600 Shuah Khan escreveu: > Fix to

Re: [PATCH 2/4] media: Support Intersil/Techwell TW686x-based video capture cards

2016-03-22 Thread Ezequiel Garcia
Hi Hans, On 21 March 2016 at 08:41, Hans Verkuil wrote: > From: Ezequiel Garcia > > This commit introduces the support for the Techwell TW686x video > capture IC. This hardware supports a few DMA modes, including > scatter-gather and frame

[PATCH] [media] au0828: Fix dev_state handling

2016-03-22 Thread Mauro Carvalho Chehab
The au0828 dev_state is actually a bit mask. It should not be checking with "==" but, instead, with a logic and. There are some places where it was doing it wrong. Fix that by replacing the dev_state set/clear/test with the bitops. Cc: sta...@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH] [media] xilinx-vipp: remove unnecessary of_node_put

2016-03-22 Thread Franck Jullien
Le 22/03/2016 13:12, Laurent Pinchart a écrit : > Hi Frank, > > Thank you for the patch. > > On Tuesday 22 Mar 2016 11:43:58 Franck Jullien wrote: >> of_graph_get_next_endpoint(node, ep) decrements refcount on >> ep. When next==NULL we break and refcount on ep is decremented >> again. >> >>

[PATCH] [media] xilinx-vipp: remove unnecessary of_node_put

2016-03-22 Thread Franck Jullien
of_graph_get_next_endpoint(node, ep) decrements refcount on ep. When next==NULL we break and refcount on ep is decremented again. Signed-off-by: Franck Jullien --- drivers/media/platform/xilinx/xilinx-vipp.c |8 ++-- 1 files changed, 2 insertions(+),

Re: [PATCH] media: au0828 fix au0828_v4l2_close() dev_state race condition

2016-03-22 Thread Shuah Khan
On 03/21/2016 10:04 PM, Shuah Khan wrote: > au0828_v4l2_close() check for dev_state == DEV_DISCONNECTED will fail to > detect the device disconnected state correctly, if au0828_v4l2_open() runs > to set the DEV_INITIALIZED bit. A loop test of bind/unbind found this bug > by increasing the

Re: [PATCH] sound/usb: fix to release stream resources from media_snd_device_delete()

2016-03-22 Thread Shuah Khan
On 03/21/2016 10:01 PM, Shuah Khan wrote: > On 03/19/2016 07:31 AM, Shuah Khan wrote: >> On 03/19/2016 06:10 AM, Mauro Carvalho Chehab wrote: >>> Em Fri, 18 Mar 2016 20:50:31 -0600 >>> Shuah Khan escreveu: >>> Fix to release stream resources from

Re: [PATCH] [media] xilinx-vipp: remove unnecessary of_node_put

2016-03-22 Thread Laurent Pinchart
Hi Frank, Thank you for the patch. On Tuesday 22 Mar 2016 11:43:58 Franck Jullien wrote: > of_graph_get_next_endpoint(node, ep) decrements refcount on > ep. When next==NULL we break and refcount on ep is decremented > again. > > Signed-off-by: Franck Jullien

Re: [PATCH] [media] media: am437x-vpfe: ensure ret is initialized

2016-03-22 Thread Lad, Prabhakar
Hi Colin, On Mon, Mar 21, 2016 at 11:32 PM, Colin King wrote: > From: Colin Ian King > > ret should be initialized to 0; for example if pfe->fmt.fmt.pix.field > is V4L2_FIELD_NONE then ret will contain garbage from the > uninitialized state

[PATCH 3/3] vidioc-dv-timings-cap.xml: explicitly state that pad and reserved should be zeroed

2016-03-22 Thread Hans Verkuil
The DV_TIMINGS_CAP documentation didn't state clearly that the pad and reserved fields should be zeroed by the application. For subdev pad can be other values as well. It also mistakenly said that only drivers would have to zero the reserved field, that's not correct. Signed-off-by: Hans Verkuil

[PATCH 2/3] vidioc-enum-dv-timings.xml: explicitly state that pad and reserved should be zeroed

2016-03-22 Thread Hans Verkuil
The ENUM_DV_TIMINGS documentation did not clearly state that the pad and reserved fields should be zeroed (pad only when used with a video device node). Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/vidioc-enum-dv-timings.xml | 5 +++-- 1 file changed,

[PATCH 1/3] vidioc-g-edid.xml: be explicit about zeroing the reserved array

2016-03-22 Thread Hans Verkuil
The G/S_EDID documentation did not explicitly state that the reserved array should be zeroed by the application. Also add the missing VIDIOC_SUBDEV_G/S_EDID ioctl names to the header. Signed-off-by: Hans Verkuil --- Documentation/DocBook/media/v4l/vidioc-g-edid.xml | 10

[PATCH 0/3] EDID/DV_TIMINGS docbook fixes

2016-03-22 Thread Hans Verkuil
Fixes a few issues I found in the documentation. Hans Verkuil (3): vidioc-g-edid.xml: be explicit about zeroing the reserved array vidioc-enum-dv-timings.xml: explicitly state that pad and reserved should be zeroed vidioc-dv-timings-cap.xml: explicitly state that pad and reserved

[PATCH] tc358743: zero the reserved array

2016-03-22 Thread Hans Verkuil
v4l2-compliance complained about this. Signed-off-by: Hans Verkuil diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 972e0d4..73e0cef 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1551,6 +1551,8 @@ static

Re: [PATCH 13/15] mediactl: Add media device ioctl API

2016-03-22 Thread Jacek Anaszewski
Hi Sakari, On 03/21/2016 01:07 AM, Sakari Ailus wrote: Hi Jacek, On Thu, Feb 18, 2016 at 02:14:40PM +0100, Jacek Anaszewski wrote: Hi Sakari, On 02/18/2016 01:09 PM, Sakari Ailus wrote: Hi Jacek, On Mon, Feb 15, 2016 at 02:06:06PM +0100, Jacek Anaszewski wrote: Hi Sakari, Thanks for the

Re: [PATCH 01/15] mediactl: Introduce v4l2_subdev structure

2016-03-22 Thread Jacek Anaszewski
Hi Sakari, On 03/21/2016 12:39 AM, Sakari Ailus wrote: Hi Jacek, On Thu, Feb 18, 2016 at 03:15:32PM +0100, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. On 02/12/2016 01:42 PM, Sakari Ailus wrote: Hi Jacek, Thanks for continuing this work! And my apologies for reviewing only