Re: [patch] [media] uvcvideo: freeing an error pointer

To put it another way, tools can figure out what is missing if they have access to good exmples of what should be there. To be clear, I can see both points of view. julia -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

Re: [PATCH v4l-utils v7 1/7] mediactl: Add support for v4l2-ctrl-binding config

Hi Jacek, On Mon, Nov 28, 2016 at 10:32:43PM +0100, Jacek Anaszewski wrote: > Hi Sakari, > > On 11/24/2016 03:23 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >On Wed, Oct 12, 2016 at 04:35:16PM +0200, Jacek Anaszewski wrote: > >>Make struct v4l2_subdev capable of aggregating v4l2-ctrl-bindings - >

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Nov 29 05:00:17 CET 2016 media-tree git hash:d3d83ee20afda16ad0133ba00f63c11a8d842a35 media_build

[PATCH 2/2] media: protect enable and disable source handler checks and calls

Protect enable and disable source handler checks and calls from dvb-core and v4l2-core. Hold graph_mutex to check if enable and disable source handlers are present and invoke them while holding the mutex. This change ensures these handlers will not be removed while they are being checked and

[PATCH 1/2] media: au0828 fix to protect enable/disable source set and clear

Protect enable/disable source set and clear to avoid races with callers. There is a possibility clear could occur while dvb-core and v4l2 try to access these handlers. Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-core.c | 4 1 file changed, 4

[PATCH 0/2] media protect enable and disable source handler paths

These two patches fix enable and disable source handler paths. These aren't dependent patches, grouped because they fix similar problems. This work is triggered by a review comment from Mauro Chehab on a snd_usb_audio patch about protecting the enable and disabel handler path in it. Ran tests to

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Hi Rob, Rob Herring writes: > On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: >> Signed-off-by: Kevin Hilman >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >> ++ >>

Re: Enabling peer to peer device transactions for PCIe devices

On Mon, Nov 28, 2016 at 04:55:23PM -0500, Serguei Sagalovitch wrote: > >We haven't touch this in a long time and perhaps it changed, but there > >definitely was a call back in the PeerDirect API to allow the GPU to > >invalidate the mapping. That's what we don't want. > I assume that you are

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Rob Herring writes: > On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: >> Signed-off-by: Kevin Hilman >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >> ++ >>

Re: Enabling peer to peer device transactions for PCIe devices

On 2016-11-28 04:36 PM, Logan Gunthorpe wrote: On 28/11/16 12:35 PM, Serguei Sagalovitch wrote: As soon as PeerDirect mapping is called then GPU must not "move" the such memory. It is by PeerDirect design. It is similar how it is works with system memory and RDMA MR: when "get_user_pages" is

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: > Signed-off-by: Kevin Hilman > --- > .../bindings/media/ti,da850-vpif-capture.txt | 65 > ++ > .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ > 2 files changed, 73

Re: Enabling peer to peer device transactions for PCIe devices

On 28/11/16 12:35 PM, Serguei Sagalovitch wrote: > As soon as PeerDirect mapping is called then GPU must not "move" the > such memory. It is by PeerDirect design. It is similar how it is works > with system memory and RDMA MR: when "get_user_pages" is called then the > memory is pinned. We

Re: [PATCH v4l-utils v7 1/7] mediactl: Add support for v4l2-ctrl-binding config

Hi Sakari, On 11/24/2016 03:23 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Oct 12, 2016 at 04:35:16PM +0200, Jacek Anaszewski wrote: Make struct v4l2_subdev capable of aggregating v4l2-ctrl-bindings - media device configuration entries. Added are also functions for validating support for the

Re: Enabling peer to peer device transactions for PCIe devices

On Mon, 2016-11-28 at 09:57 -0700, Jason Gunthorpe wrote: > On Sun, Nov 27, 2016 at 04:02:16PM +0200, Haggai Eran wrote: > > I think blocking mmu notifiers against something that is basically > > controlled by user-space can be problematic. This can block things > > like > > memory reclaim. If you

Re: [GIT PULL] Samsung fixes for 4.8

Em Mon, 28 Nov 2016 16:29:25 -0300 Javier Martinez Canillas escreveu: > Hello Mauro, > > On 11/16/2016 12:19 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 16 Nov 2016 16:08:19 +0100 > > Sylwester Nawrocki escreveu: > > > >> On 11/16/2016 03:46

Re: Enabling peer to peer device transactions for PCIe devices

On 2016-11-28 01:20 PM, Logan Gunthorpe wrote: On 28/11/16 09:57 AM, Jason Gunthorpe wrote: On PeerDirect, we have some kind of a middle-ground solution for pinning GPU memory. We create a non-ODP MR pointing to VRAM but rely on user-space and the GPU not to migrate it. If they do, the MR gets

Re: [GIT PULL] Samsung fixes for 4.8

Hello Mauro, On 11/16/2016 12:19 PM, Mauro Carvalho Chehab wrote: > Em Wed, 16 Nov 2016 16:08:19 +0100 > Sylwester Nawrocki escreveu: > >> On 11/16/2016 03:46 PM, Mauro Carvalho Chehab wrote: >> Marek Szyprowski (1): > s5p-mfc: fix failure path of

Re: Enabling peer to peer device transactions for PCIe devices

On Mon, Nov 28, 2016 at 06:19:40PM +, Haggai Eran wrote: > > > GPU memory. We create a non-ODP MR pointing to VRAM but rely on > > > user-space and the GPU not to migrate it. If they do, the MR gets > > > destroyed immediately. > > That sounds horrible. How can that possibly work? What if the

Re: Enabling peer to peer device transactions for PCIe devices

On Mon, 2016-11-28 at 09:48 -0500, Serguei Sagalovitch wrote: > On 2016-11-27 09:02 AM, Haggai Eran wrote > > > > On PeerDirect, we have some kind of a middle-ground solution for > > pinning > > GPU memory. We create a non-ODP MR pointing to VRAM but rely on > > user-space and the GPU not to

Re: Enabling peer to peer device transactions for PCIe devices

On 28/11/16 09:57 AM, Jason Gunthorpe wrote: >> On PeerDirect, we have some kind of a middle-ground solution for pinning >> GPU memory. We create a non-ODP MR pointing to VRAM but rely on >> user-space and the GPU not to migrate it. If they do, the MR gets >> destroyed immediately. > > That

Re: Enabling peer to peer device transactions for PCIe devices

On Sun, Nov 27, 2016 at 04:02:16PM +0200, Haggai Eran wrote: > > Like in ODP, MMU notifiers/HMM are used to monitor for translation > > changes. If a change comes in the GPU driver checks if an executing > > command is touching those pages and blocks the MMU notifier until the > > command

Re: [patch] [media] media: ti-vpe: vpdma: fix a timeout loop

Dan, Thanks for the patch. Acked-by: Benoit Parrot Dan Carpenter wrote on Sat [2016-Nov-26 00:28:34 +0300]: > The check assumes that we end on zero but actually we end on -1. Change > the post-op to a pre-op so that we do end on zero. Techinically

Re: [PATCH 1/1] smiapp: Implement power-on and power-off sequences without runtime PM

On Mon, 28 Nov 2016, Laurent Pinchart wrote: > > Well, I admit it would be nicer if drivers didn't have to worry about > > whether or not CONFIG_PM was enabled. A slightly cleaner approach > > from the one outlined above would have the probe routine do this: > > > > my_power_up(dev); > >

Re: Enabling peer to peer device transactions for PCIe devices

On 2016-11-27 09:02 AM, Haggai Eran wrote On PeerDirect, we have some kind of a middle-ground solution for pinning GPU memory. We create a non-ODP MR pointing to VRAM but rely on user-space and the GPU not to migrate it. If they do, the MR gets destroyed immediately. This should work on legacy

Re: [patch] [media] uvcvideo: freeing an error pointer

Hi Julia and Dan, On Monday 28 Nov 2016 14:54:58 Julia Lawall wrote: > On Mon, 28 Nov 2016, Dan Carpenter wrote: > > I understand the comparison, but I just think it's better if people > > always keep track of what has been allocated and what has not. I tried > > so hard to get Markus to stop

3A / auto-exposure Region of Interest setting

Hi, Has anyone already considered supporting 3A (e.g. auto-exposure) Region of Interest selection? In UVC this is the "Digital Region of Interest (ROI) Control." Android defines ANDROID_CONTROL_AE_REGIONS, ANDROID_CONTROL_AWB_REGIONS, ANDROID_CONTROL_AF_REGIONS. The UVC control defines just a

Re: [patch] [media] uvcvideo: freeing an error pointer

On Mon, 28 Nov 2016, Dan Carpenter wrote: > I understand the comparison, but I just think it's better if people > always keep track of what has been allocated and what has not. I tried > so hard to get Markus to stop sending those hundreds of patches where > he's like "this function has a

Re: [patch] [media] uvcvideo: freeing an error pointer

I understand the comparison, but I just think it's better if people always keep track of what has been allocated and what has not. I tried so hard to get Markus to stop sending those hundreds of patches where he's like "this function has a sanity check so we can pass pointers that weren't

[GIT PULL] Samsung SoC related updates

Mauro, this change set adds support for the Exynos5433 SoC variant of the MFC subsystem, it also includes related clean up and fixes/improvements. The following changes since commit 36f94a5cf0f9afb527f18166ae56bd3cc7204f63: Merge tag 'v4.9-rc5' into patchwork (2016-11-16 16:42:27 -0200)

Re: [RFC v3 00/21] Make use of kref in media device, grab references as needed

Hi Mauro, On Tue, Nov 22, 2016 at 03:44:29PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 14 Nov 2016 15:27:22 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > I'm replying below but let me first summarise the remaining problem area > > that this patchset addresses.

[PATCH v3 3/3] ARM: multi_v7_defconfig: enable STMicroelectronics HVA debugfs

Signed-off-by: Jean-Christophe Trotin --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index eb14ab6..7a15107 100644 ---

[PATCH v3 1/3] st-hva: encoding summary at instance release

This patch prints unconditionnaly a short summary about the encoding operation at each instance closing, for debug purpose: - information about the frame (format, resolution) - information about the stream (format, profile, level, resolution) - number of encoded frames - potential (system,

[PATCH v3 0/3] add debug capabilities to v4l2 encoder for STMicroelectronics SOC

version 3: - the encoding summary (first patch) is moved from hva-debug.c to hva-v4l2.c. As suggested by Hans, dev_info() is used instead of snprintf() in the hva_dbg_summary() function. - About the debugfs entries for HVA (second patch), a driver-specific Kconfig option

[PATCH v3 2/3] st-hva: add debug file system

This patch creates 4 static debugfs entries to dump: - the device-related information ("st-hva/device") - the list of registered encoders ("st-hva/encoders") - the current values of the hva registers ("st-hva/regs") - the information about the last closed instance ("st-hva/last") It also creates

Re: ir-keytable: infinite loops, segfaults

On Sun, Nov 27, 2016 at 07:35:10PM +, Sean Young wrote: > > The application I am trying to use it with is the mythtv frontend. I > > am doing the keycode munging from an SSH session while myth is still > > running on the main screen. I didn't think this would matter (since it > > worked for