Re: v4l2: Adding support for multiple MIPI CSI-2 virtual channels

Hi Everyone, On Fri, Feb 17, 2017 at 7:27 PM, Thomas Axelsson wrote: > Hi, > > I have a v4l2_subdev that provides multiple MIPI CSI-2 Virtual Channels. I > want to configure each virtual channel individually (e.g. set_fmt), but the > v4l2 interface does not seem

Re: [PATCH] media: staging: bcm2048: use unsigned int instead of unsigned

On Mon, Feb 20, 2017 at 05:08:56PM -0700, David Cako wrote: > Signed-off-by: David Cako > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 44 > +-- > 1 file changed, 22 insertions(+), 22 deletions(-) We can't take patches without any changelog text,

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 21 05:00:28 CET 2017 media-tree git hash:9eeb0ed0f30938f31a3d9135a88b9502192c18dd media_build

[PATCH 2/2] media: pci: saa7164: remove dead code

Remove dead code. The following line of code is never reached: return SAA_OK; Addresses-Coverity-ID: 114283 Signed-off-by: Gustavo A. R. Silva --- drivers/media/pci/saa7164/saa7164-cmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 1/2] media: pci: saa7164: remove unnecessary code

Remove unnecessary variable 'loop'. Signed-off-by: Gustavo A. R. Silva --- drivers/media/pci/saa7164/saa7164-cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164-cmd.c

Re: [PATCH] media: staging: bcm2048: use unsigned int instead of unsigned

Hi David, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.10 next-20170220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/David-Cako/media-staging-bcm2048-use

[PATCH] fix unsigned int argument

Sorry, left the old "int" argument in previous patch. Signed-off-by: David Cako --- drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On 02/20/2017 04:13 PM, Russell King - ARM Linux wrote: On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote: On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote: > On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: > > From: Russell King > > > > Setting and getting frame rates is part of the negotiation mechanism > > between subdevs. The lack of

[PATCH] media: staging: bcm2048: use unsigned int instead of unsigned

Signed-off-by: David Cako --- drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On 02/20/2017 02:56 PM, Steve Longerbeam wrote: On 02/20/2017 02:04 PM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism

Re: [PATCH v2 0/3] r8a7793 Gose video input support

Hi Ulrich, On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote: > On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote: > > Hi! > > > > This is a by-the-datasheet implementation of analog and digital video > > input on the Gose board. > > > > I have tried to address all concerns raised

[PATCH] rtl8188eu: style: spaces to tabs

--- drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c index f2021fe..8c715af 100644 --- a/drivers/staging/rtl8188eu/core/rtw_recv.c +++

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On 02/20/2017 02:04 PM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi! > > > > I wonder... should we somehow expose the range of diopters to > > > > userspace? I believe userland camera application will need that > > > > information. > > > > > > It'd certainly be useful to be able to provide more information. > > > > > > The question is: where to store it, and

Re: [PATCH v3 1/2] v4l: Add camera voice coil lens control class, current control

Hi Pavel, On Wed, Feb 15, 2017 at 09:09:09AM +0100, Pavel Machek wrote: > Hi! > > > On 02/15/17 00:47, Pavel Machek wrote: > > > On Tue 2017-02-14 14:20:22, Sakari Ailus wrote: > > >> Add a V4L2 control class for voice coil lens driver devices. These are > > >> simple devices that are used to

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

Hi Steve, On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: > From: Russell King > > Setting and getting frame rates is part of the negotiation mechanism > between subdevs. The lack of support means that a frame rate at the > sensor can't be

Re: [PATCH] [media] et8ek8: Export OF device ID as module aliases

On Mon, Feb 20, 2017 at 05:16:16PM -0300, Javier Martinez Canillas wrote: > The I2C core always reports a MODALIAS of the form i2c: even if the > device was registered via OF, this means that exporting the OF device ID > table device aliases in the module is not needed. But in order to change >

Re: [PATCH 0/6] Media controller and omap3isp cleanups

Acked-by: Hans Verkuil Thanks! Hans On 02/20/2017 07:22 AM, Sakari Ailus wrote: > Hi all, > > These patches prepare for media device refcounting but do not begin those > changes yet. They're worthwhile on their own merits. >

[PATCH v1 1/2] ir-ctl: use strndup instead of strndupa (fixes musl compile)

Fixes buildroot musl compile (see [1], [2]): ir-ctl.c:(.text+0xb06): undefined reference to `strndupa' [1] http://autobuild.buildroot.net/results/b8b96c7bbf2147dacac62485cbfdbcfd758271a5 [2] http://lists.busybox.net/pipermail/buildroot/2017-February/184048.html Signed-off-by: Peter Seiderer

[PATCH v1 2/2] ir-ctl: add optional copy of TEMP_FAILURE_RETRY macro (fix musl compile)

Fixes buildroot musl compile (see [1], [2]): ir-ctl.c:(.text+0xe01): undefined reference to `TEMP_FAILURE_RETRY' [1] http://autobuild.buildroot.net/results/b8b96c7bbf2147dacac62485cbfdbcfd758271a5 [2] http://lists.busybox.net/pipermail/buildroot/2017-February/184048.html Signed-off-by: Peter

[PATCH] cec rst: document the error codes

Document all the various error codes returned by the CEC ioctls. These were never documented, instead the documentation relied on a reference to the generic error codes, but that's not sufficient. Signed-off-by: Hans Verkuil --- diff --git

[PATCH] cec: log reason for returning -EINVAL

When validating the struct cec_s_log_addrs input a debug message is printed for all except two of the 'return -EINVAL' paths. Also log the reason for the missing two paths. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/cec/cec-adap.c

[PATCH] [media] et8ek8: Export OF device ID as module aliases

The I2C core always reports a MODALIAS of the form i2c: even if the device was registered via OF, this means that exporting the OF device ID table device aliases in the module is not needed. But in order to change how the core reports modaliases to user-space, it's better to export it. Before

RE: Dead code in v4l2-mem2mem.c?

Hi Laurent, I'd like to. It sounds interesting and useful to me. Could you give me some pointers about how to audit drivers? Shaobo -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: 2017年2月18日 3:54 To: Shaobo Cc:

change mode on PC tuner

Hello, I've bought TT-TVStick CT2-4400 and every time when I turn on PC, I have to write this: dvb-fe-tool -d DVBC/ANNEX_A because I have set on dvb-t. What should I do to set it permanently? -- Łukasz Batek

Re: ir-keytable: infinite loops, segfaults

Hi Vincent, Thanks for testing this. On Fri, Feb 17, 2017 at 12:05:50AM +1100, Vincent McIntyre wrote: > Hi again > > after you kindly fixed media_build for me I applied the nec protocol > patch and tried again. > > $ sudo ir-keytable > Found /sys/class/rc/rc0/ (/dev/input/event5) with: >

Re: [PATCH] v4l-utils: fix invalid protocol in streamzap keymap

On Sat, Feb 18, 2017 at 07:24:43PM +, Sean Young wrote: > On Fri, Feb 17, 2017 at 10:19:16AM +0100, Matthias Reichl wrote: > > ir-keytable can't load the streamzap keymap because the > > protocol type RC5_SZ is invalid: > > > > ./ir-keytable -w rc_keymaps/streamzap > > Protocol RC5_SZ invalid

[PATCH 6/6] media: devnode: Rename mdev argument as devnode

Historically, mdev argument name was being used on both struct media_device and struct media_devnode. Recently most occurrences of mdev referring to struct media_devnode were replaced by devnode, which makes more sense. Fix the last remaining occurrence. Fixes: 163f1e93e9950 ("[media]

[PATCH 1/6] omap3isp: Don't rely on devm for memory resource management

devm functions are fine for managing resources that are directly related to the device at hand and that have no other dependencies. However, a process holding a file handle to a device created by a driver for a device may result in the file handle left behind after the device is long gone. This

[PATCH 2/6] omap3isp: Call video_unregister_device() unconditionally

video_unregister_device() can be called on a never or an already unregistered device. Drop the redundant check. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/ispvideo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 0/6] Media controller and omap3isp cleanups

Hi all, These patches prepare for media device refcounting but do not begin those changes yet. They're worthwhile on their own merits. -- Kind regards, Sakari

[PATCH 5/6] media: Remove useless curly braces and parentheses

Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/media-device.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index 760e3e4..c51e2e5

[PATCH 4/6] omap3isp: Disable streaming at driver unbind time

Once the driver is unbound accessing the hardware is not allowed anymore. Due to this, disable streaming when the device driver is unbound. The states of the associated objects related to Media controller and videobuf2 frameworks are updated as well, just like if the application disabled streaming

[PATCH 3/6] omap3isp: Remove misleading comment

The intent of the check the comment is related to is to ensure we are streaming --- still. Not that streaming wouldn't be enabled yet. Remove it. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/ispvideo.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

On Mon, Feb 20, 2017 at 03:09:13PM +0200, Sakari Ailus wrote: > I've tested ACPI, will test DT soon... DT case works, too (Nokia N9). -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH v2 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

Hello Marek, On 02/20/2017 10:38 AM, Marek Szyprowski wrote: > To complete DMA memory configuration for MFC device, allocation of the > firmware buffer is needed, because some parameters are dependant on its base > address. Till now, this has been handled in the s5p_mfc_alloc_firmware() >

[PATCH v2 06/15] media: s5p-mfc: Move setting DMA max segment size to DMA configure function

Setting DMA max segment size to 32 bit mask is a part of DMA memory configuration, so move those calls to s5p_mfc_configure_dma_memory() function. Signed-off-by: Marek Szyprowski Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez

[PATCH v2 03/15] media: s5p-mfc: Replace mem_dev_* entries with an array

Internal MFC driver device structure contains two pointers to devices used for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the mem_dev[] array and use defines for accessing particular banks. This will help to simplify code in the next patches. Signed-off-by: Marek Szyprowski

[PATCH v2 02/15] media: s5p-mfc: Use generic of_device_get_match_data helper

Replace custom code with generic helper to retrieve driver data. Signed-off-by: Marek Szyprowski Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas --- drivers/media/platform/s5p-mfc/s5p_mfc.c

[PATCH v2 10/15] media: s5p-mfc: Reduce firmware buffer size for MFC v6+ variants

Firmware for MFC v6+ variants is not larger than 400 KiB, so there is no need to allocate a full 1 MiB buffer for it. Reduce it to 512 KiB to keep proper alignment of allocated buffer. Signed-off-by: Marek Szyprowski Reviewed-by: Javier Martinez Canillas

[PATCH v2 07/15] media: s5p-mfc: Put firmware to private buffer structure

Use s5p_mfc_priv_buf structure for keeping the firmware image. This will help handling of firmware buffer allocation in the next patches. Signed-off-by: Marek Szyprowski Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas

[PATCH v2 13/15] media: s5p-mfc: Remove special configuration of IOMMU domain

The main reason for using special configuration of IOMMU domain was the problem with MFC firmware, which failed to operate properly when placed at 0 DMA address. Instead of adding custom code for configuring each variant of IOMMU domain and architecture specific glue code, simply use what arch

[PATCH v2 11/15] media: s5p-mfc: Split variant DMA memory configuration into separate functions

Move code for DMA memory configuration with IOMMU into separate function to make it easier to compare what is being done in each case. Signed-off-by: Marek Szyprowski Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas

[PATCH v2 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

To complete DMA memory configuration for MFC device, allocation of the firmware buffer is needed, because some parameters are dependant on its base address. Till now, this has been handled in the s5p_mfc_alloc_firmware() function. This patch moves that logic to s5p_mfc_configure_dma_memory() to

[PATCH v2 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

It turned out that all versions of MFC v6+ hardware doesn't have a strict requirement for ALL buffers to be allocated on higher addresses than the firmware base like it was documented for MFC v5. This requirement is true only for the device and per-context buffers. All video data buffers can be

[PATCH v2 12/15] media: s5p-mfc: Add support for probe-time preallocated block based allocator

Current MFC driver depends on the fact that when IOMMU is available, the DMA-mapping framework and its IOMMU glue will use first-fit allocator. This was true for ARM architecture, but its not for ARM64 arch. However, in case of MFC v6+ hardware and latest firmware, it turned out that there is no

[PATCH v2 15/15] ARM: dts: exynos: Remove MFC reserved buffers

During my research I found that some of the requirements for the memory buffers for MFC v6+ devices were blindly copied from the previous (v5) version and simply turned out to be excessive. The relaxed requirements are applied by the recent patches to the MFC driver and the driver is now fully

[PATCH v2 04/15] media: s5p-mfc: Replace bank1/bank2 entries with an array

Internal MFC driver device structure contains two entries for keeping addresses of the DMA memory banks. Replace them with the dma_base[] array and use defines for accessing particular banks. This will help to simplify code in the next patches. Signed-off-by: Marek Szyprowski

[PATCH v2 05/15] media: s5p-mfc: Simplify alloc/release private buffer functions

Change parameters for s5p_mfc_alloc_priv_buf() and s5p_mfc_release_priv_buf() functions. Instead of DMA device pointer and a base, provide common MFC device structure and memory bank context identifier. Signed-off-by: Marek Szyprowski Reviewed-by: Javier Martinez

[PATCH v2 09/15] media: s5p-mfc: Allocate firmware with internal private buffer alloc function

Once firmware buffer has been converted to use s5p_mfc_priv_buf structure, it is possible to allocate it with existing s5p_mfc_alloc_priv_buf() function. This change will help to reduce code variants in the next patches. Signed-off-by: Marek Szyprowski Reviewed-by:

[PATCH v2 00/15] Exynos MFC v6+ - remove the need for the reserved memory

Dear All, This patchset is a result of my work on enabling full support for MFC device (multimedia codec) on Exynos 5433 on ARM64 architecture. Initially I thought that to let it working on ARM64 architecture with IOMMU, I would need to solve the issue related to the fact that s5p-mfc driver was

[PATCH v2 01/15] media: s5p-mfc: Remove unused structures and dead code

Remove unused structures, definitions and functions that are no longer called from the driver code. Signed-off-by: Marek Szyprowski Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas ---

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

Hello Marek, On 02/20/2017 10:23 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-02-17 22:13, Javier Martinez Canillas wrote: >> On 02/14/2017 04:52 AM, Marek Szyprowski wrote: >>> It turned out that all versions of MFC v6+ hardware doesn't have a strict >>> requirement for ALL buffers to

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

Hi Javier, On 2017-02-17 22:13, Javier Martinez Canillas wrote: On 02/14/2017 04:52 AM, Marek Szyprowski wrote: It turned out that all versions of MFC v6+ hardware doesn't have a strict requirement for ALL buffers to be allocated on higher addresses than the firmware base like it was

Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

Hi Pavel, On Mon, Feb 20, 2017 at 11:31:14AM +0100, Pavel Machek wrote: > Hi! > > On Tue 2017-02-14 23:38:49, Pavel Machek wrote: > > From: Sebastian Reichel > > > > If v4l2_device_register_subdev_nodes() is called multiple times, it is > > better to return early than corrupt

[PATCH] omap3isp: avoid uninitialized memory

Code in ispcsiphy is quite confusing, and does not initialize phy1 in case of isp rev. 2. Set it to zero, to prevent confusion. Signed-off-by: Pavel Machek index 8f73f6d..a2474b6 100644 --- a/drivers/media/platform/omap3isp/ispcsiphy.c +++

Re: PATCH: v4l-utils/utils/ir-ctl/irc-ctl.c: fix musl build

Hi Francesco, On Mon, Feb 20, 2017 at 12:33:14PM +0100, Francesco wrote: > This is my fist attempt to send a patch for v4l-utils project. > I maintain v4l-utils package for Alpine Linux (www.alpinelinux.org), a > musl-based distro. > > This patch allows the build for v4l-utils by allowing

PATCH: v4l-utils/utils/ir-ctl/irc-ctl.c: fix musl build

Hi. This is my fist attempt to send a patch for v4l-utils project. I maintain v4l-utils package for Alpine Linux (www.alpinelinux.org), a musl-based distro. This patch allows the build for v4l-utils by allowing alternatives to GLIBC assumptions. Thanks for considering. -- :: Francesco ::

Re: [PATCH 15/15] ARM: dts: exynos: Remove MFC reserved buffersg

On Mon, Feb 20, 2017 at 12:28 PM, Sylwester Nawrocki wrote: > On 02/14/2017 06:03 PM, Krzysztof Kozlowski wrote: >> On Tue, Feb 14, 2017 at 08:52:08AM +0100, Marek Szyprowski wrote: >>> During my research I found that some of the requirements for the memory >>> buffers for

Re: [PATCH] v4l: vsp1: Fix WPF U/V order in 3-planar formats on Gen3

Hi Laurent, On 12/02/17 23:17, Laurent Pinchart wrote: > The WPF U/V order bit has no effect for 3-planar formats on Gen3 > hardware. Swap the U and V planes manually instead in that case. Nice effective solution. > Fixes: b915bd24a034 ("[media] v4l: vsp1: Add tri-planar memory formats >

Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

Hi! On Tue 2017-02-14 23:38:49, Pavel Machek wrote: > From: Sebastian Reichel > > If v4l2_device_register_subdev_nodes() is called multiple times, it is > better to return early than corrupt memory. > > Without this, exposure / gain controls do not work in the camera >

Re: [PATCH 15/15] ARM: dts: exynos: Remove MFC reserved buffersg

On 02/14/2017 06:03 PM, Krzysztof Kozlowski wrote: > On Tue, Feb 14, 2017 at 08:52:08AM +0100, Marek Szyprowski wrote: >> During my research I found that some of the requirements for the memory >> buffers for MFC v6+ devices were blindly copied from the previous (v5) >> version and simply turned

Re: Bug#854100: libdvbv5-0: fails to tune / scan

Em Fri, 17 Feb 2017 22:50:57 +0100 Marcel Heinz escreveu: > Hi, > > Am 13. Februar 2017 schrieb Mauro Carvalho Chehab: > > > Em Fri, 10 Feb 2017 22:02:01 +0100 > > Gregor Jasny escreveu: > > > >> Bug report against libdvbv5 is here: > >>