cron job: media_tree daily build: WARNINGS

2017-02-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Feb 22 05:00:25 CET 2017 media-tree git hash:9eeb0ed0f30938f31a3d9135a88b9502192c18dd media_build

Re: [PATCH v2 17/19] [media] lirc: implement reading scancode

2017-02-21 Thread kbuild test robot
Hi Sean, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on next-20170221] [cannot apply to v4.10] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sean-Young/Teach

Re: [PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided

2017-02-21 Thread Hans Verkuil
On 02/21/2017 11:20 AM, Thibault Saunier wrote: > Use colorspace provided by the user as we are only doing scaling and > color encoding conversion, we won't be able to transform the colorspace > itself and the colorspace won't mater in that operation. > > Also always use output colorspace on

Re: [PATCH v2 17/19] [media] lirc: implement reading scancode

2017-02-21 Thread kbuild test robot
Hi Sean, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170221] [cannot apply to v4.10] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sean-Young/Teach-lirc

Re: [PATCH v6 2/9] doc: DT: venus: binding document for Qualcomm video driver

2017-02-21 Thread Rob Herring
On Tue, Feb 07, 2017 at 03:10:17PM +0200, Stanimir Varbanov wrote: > Add binding document for Venus video encoder/decoder driver > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed-off-by: Stanimir Varbanov > --- > Changes since

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Steve Longerbeam
On 02/21/2017 02:21 PM, Steve Longerbeam wrote: On 02/21/2017 04:15 AM, Sakari Ailus wrote: Hi Steve, On Mon, Feb 20, 2017 at 02:56:15PM -0800, Steve Longerbeam wrote: On 02/20/2017 02:04 PM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam

Re: Bug: decoders referenced in kernel rc-keymaps not loaded on boot

2017-02-21 Thread Matthias Reichl
On Tue, Feb 21, 2017 at 07:34:39PM +, Sean Young wrote: > On Tue, Feb 21, 2017 at 07:49:29PM +0100, Matthias Reichl wrote: > > There seems to be a bug in on-demand loading of IR protocol decoders. > > > > After bootup the protocol referenced in the in-kernel rc keymap shows > > up as enabled

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-21 Thread Vladimir Zapolskiy
Hi Sakari, On 02/21/2017 11:48 PM, Sakari Ailus wrote: > Hi, Vladimir! > > How do you do? :-) deferring execution of boring tasks by doing code review :) > On Tue, Feb 21, 2017 at 10:48:09PM +0200, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/21/2017 10:13 PM, Ramiro Oliveira wrote: >>>

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Steve Longerbeam
On 02/21/2017 04:15 AM, Sakari Ailus wrote: Hi Steve, On Mon, Feb 20, 2017 at 02:56:15PM -0800, Steve Longerbeam wrote: On 02/20/2017 02:04 PM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: From: Russell King

Re: [PATCH 1/2] media: pci: saa7164: remove unnecessary code

2017-02-21 Thread Peter Senna Tschudin
On Mon, Feb 20, 2017 at 09:46:58PM -0600, Gustavo A. R. Silva wrote: > Remove unnecessary variable 'loop'. > Reviewed-by: Peter Senna Tschudin > Signed-off-by: Gustavo A. R. Silva > --- > drivers/media/pci/saa7164/saa7164-cmd.c | 3 +-- > 1 file

Re: [PATCH 2/2] media: pci: saa7164: remove dead code

2017-02-21 Thread Peter Senna Tschudin
On Mon, Feb 20, 2017 at 09:49:59PM -0600, Gustavo A. R. Silva wrote: > Remove dead code. The following line of code is never reached: > return SAA_OK; > > Addresses-Coverity-ID: 114283 Reviewed-by: Peter Senna Tschudin > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-21 Thread Sakari Ailus
Hi, Vladimir! How do you do? :-) On Tue, Feb 21, 2017 at 10:48:09PM +0200, Vladimir Zapolskiy wrote: > Hi Ramiro, > > On 02/21/2017 10:13 PM, Ramiro Oliveira wrote: > > Hi Vladimir, > > > > Thank you for your feedback > > > > On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: > >> Hi Ramiro, >

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-21 Thread Vladimir Zapolskiy
Hi Ramiro, On 02/21/2017 10:13 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback > > On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >>> Create device tree bindings documentation. >>> >>> Signed-off-by:

[PATCH v2 09/19] [media] mce_kbd: add encoder

2017-02-21 Thread Sean Young
Split the protocol into two variants, one for keyboard and one for mouse data. Note that the mce_kbd protocol cannot be used on the igorplugusb, since the IR is too long. Signed-off-by: Sean Young --- drivers/media/rc/igorplugusb.c| 2 +-

[PATCH v2 17/19] [media] lirc: implement reading scancode

2017-02-21 Thread Sean Young
This implements LIRC_MODE_SCANCODE reading from the lirc device. The scancode can be read from the input device too, but with this interface you get the rc protocol, toggle and repeat status in addition too just the scancode. int main() { int fd, mode, rc; fd = open("/dev/lirc0",

[PATCH v2 15/19] [media] rc: use the correct carrier for scancode transmit

2017-02-21 Thread Sean Young
If the lirc device supports it, set the carrier for the protocol. Signed-off-by: Sean Young --- drivers/media/rc/ir-jvc-decoder.c | 1 + drivers/media/rc/ir-lirc-codec.c | 28 drivers/media/rc/ir-mce_kbd-decoder.c | 1 +

[PATCH v2 18/19] [media] lirc: scancode rc devices should have a lirc device too

2017-02-21 Thread Sean Young
Now that the lirc interface supports scancodes, RC scancode devices can also have a lirc device, except for cec devices which have their own /dev/cecN interface. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 106 ++

[PATCH v2 11/19] [media] lirc: lirc interface should not be a raw decoder

2017-02-21 Thread Sean Young
The lirc bridge exists as a raw decoder. We would like to make the bridge to also work for scancode drivers in further commits, so it cannot be a raw decoder. Note that rc-code, lirc_dev, ir-lirc-codec are now calling functions of each other, so they've been merged into one module rc-core to

[PATCH v2 12/19] [media] lirc: exorcise struct irctl

2017-02-21 Thread Sean Young
lirc_register_driver() takes a struct lirc_driver argument, it then allocates a new struct irctl which contains another struct lirc_driver and then copies it over. By moving the members of struct irctl to struct lirc_driver, we avoid the extra allocation and we can remove struct irctl completely.

[PATCH v2 16/19] [media] rc: auto load encoder if necessary

2017-02-21 Thread Sean Young
When sending scancodes, load the encoder if we need it. Signed-off-by: Sean Young --- drivers/media/rc/rc-core-priv.h | 1 + drivers/media/rc/rc-ir-raw.c| 2 ++ drivers/media/rc/rc-main.c | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 07/19] [media] lirc: advertise LIRC_CAN_GET_REC_RESOLUTION and improve

2017-02-21 Thread Sean Young
This feature was never set. The ioctl should fail if no resolution is set. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c

[PATCH v2 08/19] [media] lirc: use refcounting for lirc devices

2017-02-21 Thread Sean Young
If a lirc device is unplugged, the struct rc_dev is freed even though userspace can still have a file descriptor open on the lirc chardev. The rc_dev structure can be used in a subsequent, or even currently executing ioctl, read or write. Signed-off-by: Sean Young ---

[PATCH v2 14/19] [media] lirc: implement scancode sending

2017-02-21 Thread Sean Young
This introduces a new lirc mode: scancode. Any device which can send raw IR can also send scancodes. int main() { int fd, mode, rc; fd = open("/dev/lirc0", O_RDWR); mode = LIRC_MODE_SCANCODE; if (ioctl(fd, LIRC_SET_SEND_MODE, )) { // kernel too old

[PATCH v2 10/19] [media] serial_ir: iommap is a memory address, not bool

2017-02-21 Thread Sean Young
This has been broken for a long time, so presumably it is not used. I have no hardware to test this on. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61401 Fixes: 90ab5ee ("module_param: make bool parameters really bool") Signed-off-by: Sean Young ---

[PATCH v2 13/19] [media] lirc: use plain kfifo rather than lirc_buffer

2017-02-21 Thread Sean Young
Since a lirc char device can only be opened once, there can only be one reader. By using a plain kfifo we don't need a spinlock and we can use kfifo_to_user. The code is much simplified. Unfortunately we cannot eliminate lirc_buffer from the tree yet, as there are still some staging lirc drivers

[PATCH v2 19/19] [media] lirc: document LIRC_MODE_SCANCODE

2017-02-21 Thread Sean Young
Lirc supports a new mode which requires documentation. Signed-off-by: Sean Young --- Documentation/media/uapi/rc/lirc-dev-intro.rst | 20 Documentation/media/uapi/rc/lirc-get-features.rst | 15 +++

[PATCH v2 02/19] [media] lirc: return ENOTTY when ioctl is not supported

2017-02-21 Thread Sean Young
We shouldn't be using ENOSYS when a feature is not available. I've tested lirc; nothing is broken as far as I can make out. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 20 ++-- drivers/media/rc/lirc_dev.c | 2 +- 2 files changed, 11

[PATCH v2 00/19] Teach lirc how to send and receive scancodes

2017-02-21 Thread Sean Young
This patch series has some general cleanup work, then the lirc scancode interface (v2) and lirc documentation fixes. The cleanups are needed for the new scancode interface. lirc already supports LIRC_MODE_LIRCCODE, but that mode is entirely driver dependant and makes no provision for protocol

[PATCH v2 03/19] [media] lirc: return ENOTTY when device does support ioctl

2017-02-21 Thread Sean Young
If timeouts or carrier range is not supported, return proper error. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c index 637b583..235d74a

[PATCH v2 04/19] [media] winbond: allow timeout to be set

2017-02-21 Thread Sean Young
The drivers sets the hardware to idle when a timeout occurs. This can be any reasonable value. Signed-off-by: Sean Young --- drivers/media/rc/winbond-cir.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/winbond-cir.c

[PATCH v2 05/19] [media] gpio-ir: do not allow a timeout of 0

2017-02-21 Thread Sean Young
According to the documentation, a timeout of 0 turns off timeouts, which is not the case. Signed-off-by: Sean Young --- drivers/media/rc/gpio-ir-recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/gpio-ir-recv.c

[PATCH v2 06/19] [media] rc: lirc keymap no longer makes any sense

2017-02-21 Thread Sean Young
The lirc keymap existed once upon a time to select the lirc protocol. Since '275ddb4 [media] rc-core: remove the LIRC "protocol"', IR is always passed to the lirc decoder so this keymap is no longer needed. Signed-off-by: Sean Young --- drivers/media/rc/keymaps/Makefile | 1 -

[PATCH v2 01/19] [media] lirc: document lirc modes better

2017-02-21 Thread Sean Young
LIRC_MODE_MODE2 and LIRC_MODE_LIRCCODE were not covered at all. Signed-off-by: Sean Young --- Documentation/media/uapi/rc/lirc-dev-intro.rst | 53 +++--- Documentation/media/uapi/rc/lirc-get-features.rst | 13 --

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

2017-02-21 Thread Vladimir Zapolskiy
Hi Ramiro, On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback > > On 2/21/2017 3:54 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> please find some review comments below. >> >> On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >>> The OV5647 sensor

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-21 Thread Ramiro Oliveira
Hi Vladimir, Thank you for your feedback On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: > Hi Ramiro, > > On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >> Create device tree bindings documentation. >> >> Signed-off-by: Ramiro Oliveira >> Acked-by: Rob Herring

Re: Bug: decoders referenced in kernel rc-keymaps not loaded on boot

2017-02-21 Thread Sean Young
On Tue, Feb 21, 2017 at 07:49:29PM +0100, Matthias Reichl wrote: > There seems to be a bug in on-demand loading of IR protocol decoders. > > After bootup the protocol referenced in the in-kernel rc keymap shows > up as enabled (in sysfs and ir-keytable) but the protocol decoder > is not loaded

Re: Cine CT V6.1 code change request

2017-02-21 Thread Martin Herrman
2017-02-19 14:27 GMT+01:00 Daniel Scheller : > > Hi Martin, > > For someone who has some knowledge on the stv0367 demods, it's probably > not very hard. > > While I don't have that knowledge, I've started tackling > the "in-kernel" stv0367 module to work as a replacement

[PATCH v5 3/3] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt

2017-02-21 Thread Thibault Saunier
It is required by the standard that the field order is set by the driver. Signed-off-by: Thibault Saunier --- Changes in v5: - Just adapt the field and never error out. Changes in v4: None Changes in v3: - Do not check values in the g_fmt functions as Andrzej

[PATCH v5 2/3] [media] s5p-mfc: Set colorspace in VIDIO_{G,TRY}_FMT if DEFAULT provided

2017-02-21 Thread Thibault Saunier
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV but the driver didn't set the colorimetry when userspace provided V4L2_COLORSPACE_DEFAULT. Use 576p display resolution as a threshold to set this as suggested by

[PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided

2017-02-21 Thread Thibault Saunier
Use colorspace provided by the user as we are only doing scaling and color encoding conversion, we won't be able to transform the colorspace itself and the colorspace won't mater in that operation. Also always use output colorspace on the capture side. Start using 576p as a threashold to compute

[PATCH v5 0/3] Fixes for colorspace logic in exynos-gsc and s5p-mfc drivers

2017-02-21 Thread Thibault Saunier
Hello, This patchset fixes a few issues on the colorspace logic for the exynos-gsc and s5p-mfc drivers. We now handle the colorspace in those drivers, and make sure to respect user setting if possible. We also now set the 'v4l2_pix_format:field' if userspace passed ANY, avoiding GStreamer

Re: [PATCH v4 1/4] [media] exynos-gsc: Use 576p instead 720p as a threshold for colorspaces

2017-02-21 Thread Thibault Saunier
Hello Andrzej, On 02/21/2017 06:56 AM, Andrzej Hajda wrote: On 13.02.2017 20:08, Thibault Saunier wrote: From: Javier Martinez Canillas The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace should be used for SDTV and V4L2_COLORSPACE_REC709 for

Bug: decoders referenced in kernel rc-keymaps not loaded on boot

2017-02-21 Thread Matthias Reichl
There seems to be a bug in on-demand loading of IR protocol decoders. After bootup the protocol referenced in the in-kernel rc keymap shows up as enabled (in sysfs and ir-keytable) but the protocol decoder is not loaded and thus no rc input events will be generated. For example, RPi3 with kernel

Re: ir-keytable: infinite loops, segfaults

2017-02-21 Thread Sean Young
On Wed, Feb 22, 2017 at 12:07:07AM +1100, Vincent McIntyre wrote: > On 2/21/17, Sean Young wrote: > >> $ sudo cat /sys/class/rc/rc1/protocols > >> nec > >> $ sudo sh > >> # echo "+rc-5 +nec +rc-6 +jvc +sony +rc-5-sz +sanyo +sharp +xmp" > > >> /sys/class/rc/rc1/protocols > >> bash:

[GIT PULL for v4.11-rc1] media updates

2017-02-21 Thread Mauro Carvalho Chehab
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.11-1 For: - New drivers: i.MX6 Video Data Order Adapter's (VDOA) Toshiba et8ek8 5MP sensor STM DELTA multi-format video decoder V4L2 driver SPI

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

2017-02-21 Thread Ramiro Oliveira
Hi Vladimir, Thank you for your feedback On 2/21/2017 3:54 PM, Vladimir Zapolskiy wrote: > Hi Ramiro, > > please find some review comments below. > > On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >> The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 >> and RAW 10

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Sakari Ailus
On Tue, Feb 21, 2017 at 04:03:32PM +, Russell King - ARM Linux wrote: > On Tue, Feb 21, 2017 at 05:38:34PM +0200, Sakari Ailus wrote: > > Hi Russell, > > > > On Tue, Feb 21, 2017 at 01:21:32PM +, Russell King - ARM Linux wrote: > > > On Tue, Feb 21, 2017 at 02:37:57PM +0200, Sakari Ailus

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Russell King - ARM Linux
On Tue, Feb 21, 2017 at 05:38:34PM +0200, Sakari Ailus wrote: > Hi Russell, > > On Tue, Feb 21, 2017 at 01:21:32PM +, Russell King - ARM Linux wrote: > > On Tue, Feb 21, 2017 at 02:37:57PM +0200, Sakari Ailus wrote: > > > Hi Russell, > > > > > > On Tue, Feb 21, 2017 at 12:13:32AM +,

Re: Problem: saa7113 (saa7115) vs. "conrad usb grabber usb-472"

2017-02-21 Thread Bodo Eggert
On Tue, 21 Feb 2017, Devin Heitmueller wrote: > > lsusb: > > Bus 003 Device 002: ID 0573:0400 Zoran Co. Personal Media Division > > (Nogatech) D-Link V100 > > The Zoran usbvision driver has been a mess for years, and it's not > going to get better anytime soon. It's a *really* old design and >

[PATCH 1/1] docs-rst: media: Explicitly refer to sub-sampling in scaling documentation

2017-02-21 Thread Sakari Ailus
Skipping, which is sometimes used in terminology related to sensors when referring to sub-sampling is replaced by more suitable sub-sampling instead. Skipping is retained in a note in parentheses. Suggested-by: Russell King Signed-off-by: Sakari Ailus

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-21 Thread Vladimir Zapolskiy
Hi Ramiro, On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira > Acked-by: Rob Herring > --- > .../devicetree/bindings/media/i2c/ov5647.txt | 35 > ++ >

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

2017-02-21 Thread Vladimir Zapolskiy
Hi Ramiro, please find some review comments below. On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: > The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 > and RAW 10 output formats, and MIPI CSI-2 interface. > > The driver adds support for 640x480 RAW 8. > >

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Sakari Ailus
Hi Russell, On Tue, Feb 21, 2017 at 01:21:32PM +, Russell King - ARM Linux wrote: > On Tue, Feb 21, 2017 at 02:37:57PM +0200, Sakari Ailus wrote: > > Hi Russell, > > > > On Tue, Feb 21, 2017 at 12:13:32AM +, Russell King - ARM Linux wrote: > > > On Tue, Feb 21, 2017 at 12:04:10AM +0200,

Re: [PATCH] dma-buf: add support for compat ioctl

2017-02-21 Thread Christian König
Am 21.02.2017 um 15:55 schrieb Marek Szyprowski: Dear All, On 2017-02-21 15:37, Marek Szyprowski wrote: Hi Christian, On 2017-02-21 14:59, Christian König wrote: Am 21.02.2017 um 14:21 schrieb Marek Szyprowski: Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC

Re: Problem: saa7113 (saa7115) vs. "conrad usb grabber usb-472"

2017-02-21 Thread Devin Heitmueller
> lsusb: > Bus 003 Device 002: ID 0573:0400 Zoran Co. Personal Media Division (Nogatech) > D-Link V100 The Zoran usbvision driver has been a mess for years, and it's not going to get better anytime soon. It's a *really* old design and there hasn't been any interest from any of the developers to

Re: [PATCH] dma-buf: add support for compat ioctl

2017-02-21 Thread Marek Szyprowski
Dear All, On 2017-02-21 15:37, Marek Szyprowski wrote: Hi Christian, On 2017-02-21 14:59, Christian König wrote: Am 21.02.2017 um 14:21 schrieb Marek Szyprowski: Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC ioctl from 32bit application on 64bit kernel. Data

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

2017-02-21 Thread Sakari Ailus
Hi Ramiro, On Tue, Feb 21, 2017 at 02:49:12PM +, Ramiro Oliveira wrote: > Hi Sakari, > > Thank you for your feedback. You're welcome. An additional note as you don't implement any controls --- some CSI-2 receivers may need to know the link frequency to know how to program the receiver;

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

2017-02-21 Thread Ramiro Oliveira
Hi Sakari, Thank you for your feedback. On 2/21/2017 12:09 PM, Sakari Ailus wrote: > Hi Ramiro, > > A few minor comments below. > > On Fri, Feb 17, 2017 at 01:14:16PM +, Ramiro Oliveira wrote: >> The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 >> and RAW 10

Problem: saa7113 (saa7115) vs. "conrad usb grabber usb-472"

2017-02-21 Thread Bodo Eggert
System: Debian Jessie x64. (Using qv4l2). I've got a USB video grabber called "conrad usb grabber usb-472", essentially it's a no-name-branding. It's recognized as saa7113 by the saa7115 driver. The device has one video input (chinch, yellow) and a stereo input (red and white). The driver

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-21 Thread Sakari Ailus
Hi Ramiro, On Tue, Feb 21, 2017 at 02:30:16PM +, Ramiro Oliveira wrote: > Hi Sakari, > > Thank you for your feedback. > > On 2/21/2017 11:57 AM, Sakari Ailus wrote: > > Hi Ramiro, > > > > On Fri, Feb 17, 2017 at 01:14:15PM +, Ramiro Oliveira wrote: > >> Create device tree bindings

Re: [PATCH] dma-buf: add support for compat ioctl

2017-02-21 Thread Marek Szyprowski
Hi Christian, On 2017-02-21 14:59, Christian König wrote: Am 21.02.2017 um 14:21 schrieb Marek Szyprowski: Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC ioctl from 32bit application on 64bit kernel. Data structures for both 32 and 64bit modes are same, so there

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-21 Thread Ramiro Oliveira
Hi Sakari, Thank you for your feedback. On 2/21/2017 11:57 AM, Sakari Ailus wrote: > Hi Ramiro, > > On Fri, Feb 17, 2017 at 01:14:15PM +, Ramiro Oliveira wrote: >> Create device tree bindings documentation. >> >> Signed-off-by: Ramiro Oliveira >> Acked-by: Rob

Re: Looking more details and reasons for using orig_add_limit.

2017-02-21 Thread Sodagudi Prasad
Hi mchehab/linux-media, It is not clear why KERNEL_DS was set explicitly here. In this path video_usercopy() gets called and it copies the “struct v4l2_buffer” struct to user space stack memory. Can you please share reasons for setting to KERNEL_DS here? static long do_video_ioctl(struct

Re: [PATCH] dma-buf: add support for compat ioctl

2017-02-21 Thread Christian König
Am 21.02.2017 um 14:21 schrieb Marek Szyprowski: Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC ioctl from 32bit application on 64bit kernel. Data structures for both 32 and 64bit modes are same, so there is no need for additional translation layer. Well I might

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Russell King - ARM Linux
On Tue, Feb 21, 2017 at 02:37:57PM +0200, Sakari Ailus wrote: > Hi Russell, > > On Tue, Feb 21, 2017 at 12:13:32AM +, Russell King - ARM Linux wrote: > > On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote: > > > On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: > > >

[PATCH] dma-buf: add support for compat ioctl

2017-02-21 Thread Marek Szyprowski
Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC ioctl from 32bit application on 64bit kernel. Data structures for both 32 and 64bit modes are same, so there is no need for additional translation layer. Signed-off-by: Marek Szyprowski ---

Re: ir-keytable: infinite loops, segfaults

2017-02-21 Thread Vincent McIntyre
On 2/21/17, Sean Young wrote: > Hi Vincent, > ... > > On the cxusb the protocol is now nec, and that is the only protocol it > supports, you can't change it. > doh! ok well that's all good then. >> $ sudo cat /sys/class/rc/rc1/protocols >> nec >> $ sudo sh >> # echo "+rc-5 +nec

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Sakari Ailus
Hi Russell, On Tue, Feb 21, 2017 at 12:13:32AM +, Russell King - ARM Linux wrote: > On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote: > > On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: > > > From: Russell King > > > > > > Setting

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Sakari Ailus
Hi Steve, On Mon, Feb 20, 2017 at 02:56:15PM -0800, Steve Longerbeam wrote: > > > On 02/20/2017 02:04 PM, Sakari Ailus wrote: > >Hi Steve, > > > >On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: > >>From: Russell King > >> > >>Setting and getting

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

2017-02-21 Thread Sakari Ailus
Hi Ramiro, A few minor comments below. On Fri, Feb 17, 2017 at 01:14:16PM +, Ramiro Oliveira wrote: > The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 > and RAW 10 output formats, and MIPI CSI-2 interface. > > The driver adds support for 640x480 RAW 8. > >

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

2017-02-21 Thread Sakari Ailus
Hi Ramiro, On Fri, Feb 17, 2017 at 01:14:15PM +, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira > Acked-by: Rob Herring > --- > .../devicetree/bindings/media/i2c/ov5647.txt | 35 >

Re: [PATCH] omap3isp: avoid uninitialized memory

2017-02-21 Thread Sakari Ailus
Hi Pavel, On Mon, Feb 20, 2017 at 01:06:47PM +0100, Pavel Machek wrote: > > Code in ispcsiphy is quite confusing, and does not initialize phy1 in > case of isp rev. 2. Set it to zero, to prevent confusion. > > Signed-off-by: Pavel Machek > > index 8f73f6d..a2474b6 100644 > ---

Re: [PATCH v2 01/15] media: s5p-mfc: Remove unused structures and dead code

2017-02-21 Thread Andrzej Hajda
On 20.02.2017 14:38, Marek Szyprowski wrote: > Remove unused structures, definitions and functions that are no longer > called from the driver code. > > Signed-off-by: Marek Szyprowski > Reviewed-by: Javier Martinez Canillas > Tested-by: Javier

Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

2017-02-21 Thread Sakari Ailus
On Tue, Feb 21, 2017 at 12:07:21PM +0100, Pavel Machek wrote: > On Mon 2017-02-20 15:56:36, Sakari Ailus wrote: > > On Mon, Feb 20, 2017 at 03:09:13PM +0200, Sakari Ailus wrote: > > > I've tested ACPI, will test DT soon... > > > > DT case works, too (Nokia N9). > > Hmm. Good to know. Now to

Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

2017-02-21 Thread Pavel Machek
On Mon 2017-02-20 15:56:36, Sakari Ailus wrote: > On Mon, Feb 20, 2017 at 03:09:13PM +0200, Sakari Ailus wrote: > > I've tested ACPI, will test DT soon... > > DT case works, too (Nokia N9). Hmm. Good to know. Now to figure out how to get N900 case to work... AFAICT N9 has CSI2, not CSI1

Re: [PATCH v4 4/4] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt

2017-02-21 Thread Andrzej Hajda
On 13.02.2017 20:08, Thibault Saunier wrote: > It is required by the standard that the field order is set by the > driver. > > Signed-off-by: Thibault Saunier > > --- > > Changes in v4: None > Changes in v3: > - Do not check values in the g_fmt functions as

Re: [PATCH v4 2/4] [media] exynos-gsc: Respect userspace colorspace setting in try_fmt

2017-02-21 Thread Andrzej Hajda
On 13.02.2017 20:08, Thibault Saunier wrote: > User userspace provided by the user as we are only doing scaling and > color encoding conversion, we won't be able to transform the colorspace > itself and the colorspace won't mater in that operation. > > Also always use output colorspace on the

Re: [PATCH v4 1/4] [media] exynos-gsc: Use 576p instead 720p as a threshold for colorspaces

2017-02-21 Thread Andrzej Hajda
On 13.02.2017 20:08, Thibault Saunier wrote: > From: Javier Martinez Canillas > > The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace > should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers > don't agree on the display resolution

Re: [bug report] [media] st-delta: add mjpeg support

2017-02-21 Thread Hugues FRUCHET
Thanks Dan, Patch sent to fix warning: https://www.spinics.net/lists/linux-media/msg111529.html BR, Hugues. On 02/13/2017 08:07 PM, Dan Carpenter wrote: > Hello Hugues Fruchet, > > The patch 433ff5b4a29b: "[media] st-delta: add mjpeg support" from > Feb 2, 2017, leads to the following static

Re: [PATCH v4 15/36] platform: add video-multiplexer subdevice driver

2017-02-21 Thread Philipp Zabel
On Sun, 2017-02-19 at 23:02 +0100, Pavel Machek wrote: > Hi! > > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > > controlled either by register bit fields or by a GPIO. The subdevice > > passes through frame

[PATCH v4 3/3] [media] st-delta: add mpeg2 support

2017-02-21 Thread Hugues Fruchet
Adds support of DELTA MPEG-2 video decoder back-end, implemented by calling MPEG2_TRANSFORMER0 firmware using RPMSG IPC communication layer. MPEG-2 decoder back-end is a stateless decoder which require specific parsing metadata in access unit in order to complete decoding. Signed-off-by: Hugues

[PATCH v4 2/3] [media] st-delta: add parsing metadata controls support

2017-02-21 Thread Hugues Fruchet
Install all metadata controls required by registered decoders. Update the decoding context with the set of metadata received from user through extended control. Set the received metadata in access unit prior to call the decoder decoding ops. Signed-off-by: Hugues Fruchet

[PATCH v4 1/3] [media] v4l: add parsed MPEG-2 support

2017-02-21 Thread Hugues Fruchet
Add "parsed MPEG-2" pixel format & related controls needed by stateless video decoders. In order to decode the video bitstream chunk provided by user on output queue, stateless decoders require also some extra data resulting from this video bitstream chunk parsing. Those parsed extra data have to

[PATCH v4 0/3] Add support for MPEG-2 in DELTA video decoder

2017-02-21 Thread Hugues Fruchet
The patchset implements the MPEG-2 part of V4L2 unified low-level decoder API RFC [0] needed by stateless video decoders, ie decoders which requires specific parsing metadata in addition to video bitstream chunk in order to complete decoding. A reference implementation using STMicroelectronics

Re: [PATCH v3 1/3] [media] v4l: add parsed MPEG-2 support

2017-02-21 Thread Hugues FRUCHET
Thanks for review Nicolas, my comments thereafter. On 02/10/2017 03:07 AM, Nicolas Dufresne wrote: > Le jeudi 09 février 2017 à 18:07 +0100, Hugues Fruchet a écrit : >> Add "parsed MPEG-2" pixel format & related controls >> needed by stateless video decoders. >> In order to decode the video

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Philipp Zabel
On Mon, 2017-02-20 at 16:18 -0800, Steve Longerbeam wrote: > > On 02/20/2017 04:13 PM, Russell King - ARM Linux wrote: > > On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote: > >> On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: > >>> From: Russell King

[PATCH] [media] st-delta: mjpeg: fix static checker warning

2017-02-21 Thread Hugues Fruchet
Initialize 'data_offset' local variable to 0. drivers/media/platform/sti/delta/delta-mjpeg-dec.c:415 delta_mjpeg_decode() error: uninitialized symbol 'data_offset'. Fixes: 433ff5b4a29b: "[media] st-delta: add mjpeg support" Signed-off-by: Hugues Fruchet ---