Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote: > > > On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: > >On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: > >> > >> > >>On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: > >>>I really don't think

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Mar 12 05:00:15 CET 2017 media-tree git hash:700ea5e0e0dd70420a04e703ff264cc133834cba media_build

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: I really don't think expecting the user to understand and configure the pipeline is a sane way forward. Think

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote: Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 03:14 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote: This situation is there since 2009. If I remember well, you tried to write such generic plugin in the past, but never finished it, apparently because it is too

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote: > This situation is there since 2009. If I remember well, you tried to write > such generic plugin in the past, but never finished it, apparently because > it is too complex. Others tried too over the years. > > The last

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi! > > > The rationale is that we should support the simplest use cases first. > > > > > > In the case of the first MC-based driver (and several subsequent > > > ones), the simplest use case required MC, as it was meant to suport > > > a custom-made sophisticated application that required fine

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi! > > > Ok, perhaps supporting both subdev API and V4L2 API at the same > > > time doesn't make much sense. We could disable one in favor of the > > > other, either at compilation time or at runtime. > > > > Right. If the subdev API is disabled, then you have to inherit the subdev > >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Sat, Mar 11, 2017 at 11:06:55AM -0800, Steve Longerbeam wrote: > On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: > >On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: > >> > >> > >>On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: > >>>I really don't think expecting

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 12:26 PM, Pavel Machek wrote: Hi! I tend to agree with that. I agree as well. This is in line with how existing drivers behave, too. Well, sounds like there is consensus on this topic. I guess I'll go ahead and remove the control inheritance support. I suppose having a

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

On 03/11/2017 05:41 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: If the pads on both sides of a link specify a frame interval, then those frame intervals should match. Create the exported function

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi! > >>I tend to agree with that. > > > >I agree as well. > > > >This is in line with how existing drivers behave, too. > > > Well, sounds like there is consensus on this topic. I guess I'll > go ahead and remove the control inheritance support. I suppose > having a control appear in two

[PATCH] staging: atomisp: remove redundant check for client being null

From: Colin Ian King The previous statement checks if client is null, so the null check when assigning dev is redundant and can be removed. Detected by CoverityScan, CID#1416555 ("Logically Dead Code") Signed-off-by: Colin Ian King ---

[PATCH] staging: atomisp: clean up return logic, remove redunant code

From: Colin Ian King There is no need to check if ret is non-zero, remove this redundant check and just return the error status from the call to mt9m114_write_reg_array. Detected by CoverityScan, CID#1416577 ("Identical code for different branches") Signed-off-by:

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: I really don't think expecting the user to understand and configure the pipeline is a sane way forward. Think

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you never capture

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: > > > On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: > >I really don't think expecting the user to understand and configure > >the pipeline is a sane way forward. Think about it - should the > >user need to know that,

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you never capture

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:08:23AM -0800, Steve Longerbeam wrote: On 03/11/2017 07:32 AM, Sakari Ailus wrote: Hi Mauro and Hans, On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: Em Sat, 11 Mar 2017 12:32:43 +0100

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: > On 03/11/2017 03:39 AM, Hans Verkuil wrote: > >It's fine to use an internal event as long as the end-user doesn't > >see it. But if you lose vsyncs, then you never capture another frame, > >right? > > No, that's not correct. By

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Sat, Mar 11, 2017 at 10:08:23AM -0800, Steve Longerbeam wrote: > On 03/11/2017 07:32 AM, Sakari Ailus wrote: > >Hi Mauro and Hans, > > > >On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: > >>Em Sat, 11 Mar 2017 12:32:43 +0100 > >>Hans Verkuil escreveu:

Re: [PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

On 03/11/2017 05:49 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote: Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam The existing V4L2 UAPI headers are under

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/11/2017 03:39 AM, Hans Verkuil wrote: On 10/03/17 19:37, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 07:32 AM, Sakari Ailus wrote: Hi Mauro and Hans, On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: Em Sat, 11 Mar 2017 12:32:43 +0100 Hans Verkuil escreveu: On 10/03/17 16:09, Mauro Carvalho Chehab wrote: Em Fri, 10 Mar 2017 13:54:28

usb_video.c: 0bda:579f Realtek - corrupted frames and low FPS of captured mjpeg video frames

Hi everybody, I have a usb camera built into my laptop (hardware details here https://paste.ubuntu.com/24126969/) and I am looking for some guidance on how to debug it further - any feedback is highly appreciated. I am aware that this hardware is probably buggy/does not follow the UVC

usb_video.c: 0bda:579f Realtek - corrupted frames and low FPS of captured mjpeg video frames

Hi everybody, I have a usb camera built into my laptop (hardware details here https://paste.ubuntu.com/24126969/) and I am looking for some guidance on how to debug it further - any feedback is highly appreciated. I am aware that this hardware is probably buggy/does not follow the UVC

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Sat, Mar 11, 2017 at 05:32:29PM +0200, Sakari Ailus wrote: > My understanding of the i.MX6 case is the hardware is configurable enough > to warrant the use of the Media controller API. Some patches indicate > there are choices to be made in data routing. The iMX6 does have configurable data

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi Mauro and Hans, On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: > Em Sat, 11 Mar 2017 12:32:43 +0100 > Hans Verkuil escreveu: > > > On 10/03/17 16:09, Mauro Carvalho Chehab wrote: > > > Em Fri, 10 Mar 2017 13:54:28 +0100 > > > Hans Verkuil

Re: [PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

Hi Steve, On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote: > Add an empty UAPI Kbuild file for media UAPI headers. > > Signed-off-by: Steve Longerbeam The existing V4L2 UAPI headers are under include/uapi/linux. Could you use that directory

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

Hi Steve, On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: > If the pads on both sides of a link specify a frame interval, then > those frame intervals should match. Create the exported function > v4l2_subdev_link_validate_frame_interval() to verify this. This > function can be

Re: [PATCHv5 00/16] atmel-isi/ov7670/ov2640: convert to standalone drivers

On Sat, Mar 11, 2017 at 12:23:12PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series converts the soc-camera atmel-isi to a standalone V4L2 > driver. Patches 5 and 13: Acked-by: Sakari Ailus -- Sakari Ailus e-mail:

Re: [PATCHv5 07/16] atmel-isi: remove dependency of the soc-camera framework

Hi Hans, On Sat, Mar 11, 2017 at 12:23:19PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > This patch converts the atmel-isi driver from a soc-camera driver to a driver > that is stand-alone. > > Signed-off-by: Hans Verkuil > --- >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Sat, 11 Mar 2017 12:32:43 +0100 Hans Verkuil escreveu: > On 10/03/17 16:09, Mauro Carvalho Chehab wrote: > > Em Fri, 10 Mar 2017 13:54:28 +0100 > > Hans Verkuil escreveu: > > > >>> Devices that have complex pipeline that do essentially require using

Re: [PATCH v2 1/2] libv4lconvert: make it clear about the criteria for needs_conversion

On Sat, Mar 11, 2017 at 06:31:47AM -0300, Mauro Carvalho Chehab wrote: > While there is already a comment about the always_needs_conversion > logic at libv4lconvert, the comment is not clear enough. Also, > the decision of needing a conversion or not is actually at the > supported_src_pixfmts[]

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 10/03/17 19:37, Steve Longerbeam wrote: > Hi Hans, > > On 03/10/2017 04:03 AM, Hans Verkuil wrote: >> On 10/03/17 05:52, Steve Longerbeam wrote: >>> Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or >>> output device has measured an interval between the reception or

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 10/03/17 16:09, Mauro Carvalho Chehab wrote: > Em Fri, 10 Mar 2017 13:54:28 +0100 > Hans Verkuil escreveu: > >>> Devices that have complex pipeline that do essentially require using the >>> Media controller interface to configure them are out of that scope. >>> >> >>

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Sat, 11 Mar 2017 00:37:14 +0200 Sakari Ailus escreveu: > Hi Mauro (and others), > > On Fri, Mar 10, 2017 at 12:53:42PM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 10 Mar 2017 15:20:48 +0100 > > Hans Verkuil escreveu: > > > > > > > > > As

[PATCHv5 14/16] em28xx: drop last soc_camera link

From: Hans Verkuil The em28xx driver still used the soc_camera.h header for the ov2640 driver. Since this driver no longer uses soc_camera, that include can be removed. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus

[PATCHv5 15/16] sama5d3 dts: enable atmel-isi

From: Hans Verkuil This illustrates the changes needed to the dts in order to hook up the ov7670. I don't plan on merging this. Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 59 ++---

[PATCHv5 12/16] ov2640: use standard clk and enable it.

From: Hans Verkuil Convert v4l2_clk to normal clk and enable the clock. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/i2c/ov2640.c | 31 ++- 1 file changed, 14

[PATCHv5 16/16] at91-sama5d3_xplained.dts: select ov2640

From: Hans Verkuil This patch replaces the ov7670 with the ov2640. This patch is not meant to be merged but is for demonstration purposes only. Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 16 1

[PATCHv5 05/16] ov7670: add devicetree support

From: Hans Verkuil Add DT support. Use it to get the reset and pwdn pins (if there are any). Tested with one sensor requiring reset/pwdn and one sensor that doesn't have reset/pwdn pins. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus

[PATCHv5 10/16] ov2640: update bindings

From: Hans Verkuil Update the bindings for this device based on a working DT example. Signed-off-by: Hans Verkuil Acked-by: Rob Herring Acked-by: Sakari Ailus ---

[PATCHv5 11/16] ov2640: convert from soc-camera to a standard subdev sensor driver.

From: Hans Verkuil Convert ov2640 to a standard subdev driver. The soc-camera driver no longer uses this driver, so it can safely be converted. Note: the s_power op has been dropped: this never worked. When the last open() is closed, then the power is turned off, and

[PATCHv5 13/16] ov2640: add MC support

From: Hans Verkuil The MC support is needed by the em28xx driver. Signed-off-by: Hans Verkuil --- drivers/media/i2c/ov2640.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov2640.c

[PATCHv5 03/16] ov7670: fix g/s_parm

From: Hans Verkuil Drop unnecesary memset. Drop the unnecessary extendedmode check and set the V4L2_CAP_TIMEPERFRAME capability. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/i2c/ov7670.c | 4

[PATCHv5 06/16] atmel-isi: document device tree bindings

From: Hans Verkuil Document the device tree bindings for this hardware. Mostly copied from the atmel-isc bindings. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- .../devicetree/bindings/media/atmel-isi.txt

[PATCHv5 07/16] atmel-isi: remove dependency of the soc-camera framework

From: Hans Verkuil This patch converts the atmel-isi driver from a soc-camera driver to a driver that is stand-alone. Signed-off-by: Hans Verkuil --- drivers/media/platform/soc_camera/Kconfig |3 +-

[PATCHv5 08/16] atmel-isi: move out of soc_camera to atmel

From: Hans Verkuil Move this out of the soc_camera directory into the atmel directory where it belongs. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/platform/Makefile

[PATCHv5 02/16] ov7670: call v4l2_async_register_subdev

From: Hans Verkuil Add v4l2-async support for this driver. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/i2c/ov7670.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-)

[PATCHv5 04/16] ov7670: get xclk

From: Hans Verkuil Get the clock for this sensor. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/i2c/ov7670.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff

[PATCHv5 09/16] ov2640: fix colorspace handling

From: Hans Verkuil The colorspace is independent of whether YUV or RGB is sent to the SoC. Fix this. Signed-off-by: Hans Verkuil --- drivers/media/i2c/soc_camera/ov2640.c | 23 +++ 1 file changed, 7 insertions(+), 16

[PATCHv5 01/16] ov7670: document device tree bindings

From: Hans Verkuil Add binding documentation and add that file to the MAINTAINERS entry. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- .../devicetree/bindings/media/i2c/ov7670.txt | 43

[PATCHv5 00/16] atmel-isi/ov7670/ov2640: convert to standalone drivers

From: Hans Verkuil This patch series converts the soc-camera atmel-isi to a standalone V4L2 driver. The same is done for the ov7670 and ov2640 sensor drivers: the ov7670 was used to test the atmel-isi driver. The ov2640 is needed because the em28xx driver has a

Re: [PATCH 2/3] libv4lconvert: by default, offer the original format to the client

Em Sat, 11 Mar 2017 06:21:40 -0300 Mauro Carvalho Chehab escreveu: > The libv4lconvert part of libv4l was meant to provide a common > place to handle weird proprietary formats. With time, we also > added support to other standard formats, in order to help > V4L2

Re: [PATCH] libv4lconvert: by default, offer the original format to the client

Em Fri, 10 Mar 2017 17:00:59 -0800 Troy Kisky escreveu: > On 3/10/2017 12:53 PM, Mauro Carvalho Chehab wrote: > > The libv4lconvert part of libv4l was meant to provide a common > > place to handle weird proprietary formats. With time, we also > > added support to

[PATCH v2 1/2] libv4lconvert: make it clear about the criteria for needs_conversion

While there is already a comment about the always_needs_conversion logic at libv4lconvert, the comment is not clear enough. Also, the decision of needing a conversion or not is actually at the supported_src_pixfmts[] table. Improve the comments to make it clearer about what criteria should be

[PATCH v2 2/2] libv4lconvert: expose bayer formats

The libv4lconvert part of libv4l was meant to provide a common place to handle weird proprietary formats. With time, we also added support to other standard formats, in order to help V4L2 applications that are not performance sensitive to support all V4L2 formats. Yet, the hole idea is to let

[PATCH 3/3] libv4lconvert: make it clear about the criteria for needs_conversion

While there is already a comment about the always_needs_conversion logic at libv4lconvert, the comment is not clear enough. Also, the decision of needing a conversion or not is actually at the supported_src_pixfmts[] table. Improve the comments to make it clearer about what criteria should be

[PATCH 1/3] libv4lconvert: expose bayer formats

Currently, the bayer formats, if present, are not shown to the applications, with prevents them to use more optimized code to handle it. Signed-off-by: Mauro Carvalho Chehab Acked-by: Sakari Ailus --- lib/libv4lconvert/libv4lconvert.c | 8

[PATCH 2/3] libv4lconvert: by default, offer the original format to the client

The libv4lconvert part of libv4l was meant to provide a common place to handle weird proprietary formats. With time, we also added support to other standard formats, in order to help V4L2 applications that are not performance sensitive to support all V4L2 formats. Yet, the hole idea is to let