[PATCH 1/4] staging: atomisp: fix unsigned int comparison with less than zero

Fix warnings from the smatch tool atomisp_cmd.c:2649 atomisp_set_array_res() warn: unsigned 'config->width' is never less than zero. atomisp_cmd.c:2650 atomisp_set_array_res() warn: unsigned 'config->height' is never less than zero. Signed-off-by: Daeseok Youn

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 15 05:00:14 CET 2017 media-tree git hash:700ea5e0e0dd70420a04e703ff264cc133834cba media_build

Re: [PATCH] media: mtk-jpeg: fix continuous log "Context is NULL"

On Tue, 2017-03-14 at 22:21 +0800, Minghsiu Tsai wrote: > The symptom is continuous log "mtk-jpeg 18004000.jpegdec: Context is NULL" > in kernel log. It is becauese the error handling in irq doesn't clear > interrupt. > > The calling flow like as below when issue happen > mtk_jpeg_device_run() >

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

Em Tue, 14 Mar 2017 23:32:54 +0100 Pavel Machek escreveu: > Hi! > > > > > Even if they were merged, if we keep the same mean time to develop a > > > > libv4l plugin, that would mean that a plugin for i.MX6 could take 2-3 > > > > years to be developed. > > > > > > > > There's a

media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

Hi! > > > Even if they were merged, if we keep the same mean time to develop a > > > libv4l plugin, that would mean that a plugin for i.MX6 could take 2-3 > > > years to be developed. > > > > > > There's a clear message on it: > > > - we shouldn't keep pushing for a solution via libv4l. > >

[PATCH] [media] dvb-frontends/drxk: don't log errors on unsupported operation mode

From: Daniel Scheller When fe_ops.read_status is called and no channel is tuned (yet), the subsequent calls to get_lock_status() causes the kernel log to be filled with drxk: Error -22 on get_lock_status which either means a NULL pointer was passed for the p_lock_status

Re: [PATCH 12/13] [media] tuners/tda18212: add flag for retrying tuner init on failure

Am Mon, 13 Mar 2017 16:16:29 +0200 schrieb Antti Palosaari : > On 03/07/2017 08:57 PM, Daniel Scheller wrote: > > From: Daniel Scheller > > > > Taken from tda18212dd, first read after cold reset sometimes fails > > on some cards, trying twice shall do the trick.

Re: [RFC][PATCH] dma-buf: Introduce dma-buf test module

On 03/14/2017 01:13 PM, Daniel Vetter wrote: > On Tue, Mar 14, 2017 at 01:04:19PM -0700, Laura Abbott wrote: >> >> dma-buf is designed to share buffers. Sharing means that there needs to >> be another subsystem to accept those buffers. Introduce a simple test >> module to act as a dummy system to

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

Le mardi 14 mars 2017 à 15:47 +0100, Benjamin Gaignard a écrit : > Should we use /devi/ion/$heap instead of /dev/ion_$heap ? > I think it would be easier for user to look into one directory rather > then in whole /dev to find the heaps > > > is that we don't have to worry about a limit of 32

Re: [RFC][PATCH] dma-buf: Introduce dma-buf test module

On Tue, Mar 14, 2017 at 01:04:19PM -0700, Laura Abbott wrote: > > dma-buf is designed to share buffers. Sharing means that there needs to > be another subsystem to accept those buffers. Introduce a simple test > module to act as a dummy system to accept dma_bufs from elsewhere. The > goal is to

[RFC][PATCH] dma-buf: Introduce dma-buf test module

dma-buf is designed to share buffers. Sharing means that there needs to be another subsystem to accept those buffers. Introduce a simple test module to act as a dummy system to accept dma_bufs from elsewhere. The goal is to provide a very simple interface to validate exported buffers do something

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On 03/14/2017 07:47 AM, Benjamin Gaignard wrote: > 2017-03-13 22:09 GMT+01:00 Laura Abbott : >> On 03/12/2017 12:05 PM, Daniel Vetter wrote: >>> On Sun, Mar 12, 2017 at 2:34 PM, Benjamin Gaignard >>> wrote: 2017-03-09 18:38 GMT+01:00 Laura

Re: [PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

Hi Hans, On 14-03-2017 07:24, Hans Verkuil wrote: >> Right, I was forgetting about this ... >> >> So: >> 1) Most of HDMI receivers do not have the expected precision in >> measuring pixel clock value; > s/Most/Some/ > > Newer HDMI receivers tend to have better precision. > > However, the

[PATCH v3 14/27] rcar-vin: move media bus configuration to struct rvin_info

Bus configuration will once the driver is extended to to support Gen3 contain information not specific to only the directly connected parallel subdevice. Move it to struct rvin_info to show it's not always coupled to the parallel subdevice. Signed-off-by: Niklas Söderlund

[PATCH 02/16] rcar-vin: use rvin_reset_format() in S_DV_TIMINGS

Use rvin_reset_format() in rvin_s_dv_timings() instead of just resetting a few fields. This fixes an issue where the field format was not properly set after S_DV_TIMINGS. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 8

[PATCH 08/16] rcar-vin: use pad information when verifying media bus format

Use information about pad index when enumerating mbus codes. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c

[PATCH 12/16] rcar-vin: allow switch between capturing modes when stalling

If userspace can't feed the driver with buffers as fast as the driver consumes them the driver will stop video capturing and wait for more buffers from userspace, the driver is stalled. Once it have been feed one or more free buffers it will recover from the stall and resume capturing. Instead of

[PATCH 05/16] rcar-vin: move subdev source and sink pad index to rvin_graph_entity

It makes more sens to store the sink and source pads in struct rvin_graph_entity since that contains other subdevice related information. The data type to store pad information in is unsigned int and not int, change this. While we are at it drop the _idx suffix from the names, this never made

[PATCH 07/16] rcar-vin: move pad lookup to async bound handler

Information about pads will be needed when enumerating the media bus codes in the async complete handler which is run before rvin_v4l2_probe(). Move the pad lookup to the async bound handler so they are available when needed. Signed-off-by: Niklas Söderlund

[PATCH 13/16] rcar-vin: refactor and fold in function after stall handling rework

With the driver stopping and starting the stream each time the driver is stalled rvin_capture_off() can be folded in to the only caller. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 9 ++--- 1 file changed, 2

[PATCH 10/16] rcar-vin: move functions which acts on hardware

This only moves whole structs, defines and functions around, no code is changed inside any function. The reason for moving this code around is to prepare for refactoring and fixing of a start/stop stream bug without having to use forward declarations. Signed-off-by: Niklas Söderlund

[PATCH 06/16] rcar-vin: refactor pad lookup code

The pad lookup code can be broken out to increase readability and to reduce code duplication. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 38 + 1 file changed, 23 insertions(+), 15

[PATCH 03/16] rcar-vin: fix how pads are handled for v4l2 subdevice operations

The rcar-vin driver only uses one pad, pad number 0. - All v4l2 operations that did not check that the requested operation was for pad 0 have been updated with a check to enforce this. - All v4l2 operations that stored (and later restore) the requested pad before substituting it for the

[PATCH 04/16] rcar-vin: fix standard in input enumeration

If the subdevice supports dv_timings_cap the driver should not fill in the standard. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH 00/16] rcar-vin: fix issues with format and capturing

Hi, This series fix a number of issues for the rcar-vin driver regarding format and capturing. It is based on top of v4.11-rc1 and is tested on Koelsch. Parts of this series where previously part of '[PATCH 00/11] media: rcar-vin: fix OPS and format/pad index issues'. But after good reviews

[PATCH 14/16] rcar-vin: make use of video_device_alloc() and video_device_release()

Make use of the helper functions video_device_alloc() and video_device_release() to control the lifetime of the struct video_device. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 44 -

[PATCH 11/16] rcar-vin: select capture mode based on free buffers

Instead of selecting single or continuous capture mode based on how many buffers userspace intends to give us select capture mode based on number of free buffers we can allocate to hardware when the stream is started. This change is a prerequisite to enable the driver to switch from continuous to

[PATCH 15/16] rcar-vin: add missing error check to propagate error

The return value of __rvin_try_format_source is not checked, add a check and propagate the error. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 01/16] rcar-vin: reset bytesperline and sizeimage when resetting format

These two where forgotten when refactoring the format reset code. If they are not also reset at the same time as width and height the format returned from G_FMT will not match reality. Signed-off-by: Niklas Söderlund ---

[PATCH 16/16] rcar-vin: fix bug in pixelformat selection

If the requested pixelformat is not supported only revert to the current pixelformat, do not revert the entire format. Also if the pixelformat needs to be reverted the pixel information needs to be fetched once more. Signed-off-by: Niklas Söderlund ---

[PATCH 09/16] rcar-vin: decrease buffers needed to capture

It's possible to grab frames using only one buffer, this should never have been set to anything else then 1. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 06/27] rcar-vin: move max width and height information to chip information

On Gen3 the max supported width and height will be different from Gen2. Move the limits to the struct chip_info to prepare for Gen3 support. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 6 ++

[PATCH v3 12/27] rcar-vin: read subdevice format for crop only when needed

Instead of caching the subdevice format each time the video device format is set read it directly when its needed. As it turns out the format is only needed when figuring out the max rectangle for cropping. This simplify the code and makes it clearer what the source format is used for.

[PATCH v3 05/27] rcar-vin: move chip information to own struct

When Gen3 support is added to the driver more then chip id will be different for the different Soc. To avoid a lot of if statements in the code create a struct chip_info to contain this information. Signed-off-by: Niklas Söderlund ---

[PATCH v3 13/27] rcar-vin: do not cut height in two for top, bottom or alternate fields

The height should not be cut in half for the format for top, bottom or alternate fields settings. This was a mistake and it was made visible by the scaling refactoring. Correct behavior is that the user should request a frame size that fits the half height frame reflected in the field setting. If

[PATCH v3 04/27] media: entity: Swap pads if route is checked from source to sink

From: Sakari Ailus This way the pads are always passed to the has_route() op sink pad first. Makes sense. Signed-off-by: Sakari Ailus Signed-off-by: Niklas Söderlund ---

[PATCH v3 08/27] rcar-vin: move functions regarding scaling

In preparation of refactoring the scaling code move the code regarding scaling to to the top of the file to avoid the need to add forward declarations. No code is changed in this commit only whole functions moved inside the same file. Signed-off-by: Niklas Söderlund

[PATCH v3 01/27] rcar-vin: add Gen3 devicetree bindings documentation

Document the devicetree bindings for the CSI-2 inputs available on Gen3. There is a need to add a custom property 'renesas,id' and to define which CSI-2 input is described in which endpoint under the port@1 node. This information is needed since there are a set of predefined routes between each

[PATCH v3 10/27] rcar-vin: do not reset crop and compose when setting format

It was a bad idea to reset the crop and compose settings when a new format is set. This would overwrite any crop/compose set by s_select and cause unexpected behaviors, remove it. Also fold the reset helper in to the only remaining caller. Signed-off-by: Niklas Söderlund

[PATCH v3 17/27] rcar-vin: prepare digital notifier for group notifier

The media bus parsing functions used by the digital subdevice V4L2 notifier can be shared with the upcoming CSI-2 notifier. To prepare for this move and rename the function to reflect it's generic. Signed-off-by: Niklas Söderlund ---

[PATCH v3 25/27] rcar-vin: extend {start,stop}_streaming to work with media controller

The procedure to start or stop streaming using the none MC single subdevice and the MC graph and multiple subdevices are quiet different. Create a new function to abstract which method is used based on which mode the driver is running in and add logic to start the MC graph. Signed-off-by: Niklas

[PATCH v3 24/27] rcar-vin: add link notify for Gen3

Add the ability to process media device link change request. Link enablement are a bit complicated on Gen3, if it's possible to enable a link depends on what other links already are enabled. On Gen3 the 8 VIN are split into two subgroups (VIN0-3 and VIN4-7) and from a routing perspective these two

[PATCH v3 27/27] rcar-vin: enable support for r8a7796

Add the SoC specific information for Renesas r8a7796. Signed-off-by: Niklas Söderlund --- .../devicetree/bindings/media/rcar_vin.txt | 1 + drivers/media/platform/rcar-vin/rcar-core.c| 64 ++ 2 files changed, 65

[PATCH v3 23/27] rcar-vin: parse Gen3 OF and setup media graph

Parse the VIN Gen3 OF graph and register all devices in the CSI2 group common media device. Once a subdevice is added to the common media device list as many links as possible are added and if possible enabled. The links between the video source device and the CSI2 bridge are enabled as immutable

[PATCH v3 02/27] media: entity: Add has_route entity operation

From: Laurent Pinchart The optional operation can be used by entities to report whether two pads are internally connected. Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Signed-off-by:

[PATCH v3 18/27] rcar-vin: add flag to switch to media controller mode

On Gen3 a media controller API needs to be used to allow userspace to configure the subdevices in the pipeline instead of directly controlling a single source subdevice, which is and will continue to be the mode of operation on Gen2. Prepare for these two modes of operation by adding a flag to

[PATCH v3 09/27] rcar-vin: all Gen2 boards can scale simplify logic

The logic to preserve the requested format width and height are too complex and come from a premature optimization for Gen3. All Gen2 SoC can scale and the Gen3 implementation will not use these functions at all so simply preserve the width and hight when interacting with the subdevice much like

[PATCH v3 15/27] rcar-vin: enable Gen3 hardware configuration

Add the register needed to work with Gen3 hardware. This patch adds the logic for how to work with the Gen3 hardware. More work is required to enable the subdevice structure needed to configure capturing. Signed-off-by: Niklas Söderlund ---

[PATCH v3 07/27] rcar-vin: change name of video device

The rcar-vin driver needs to be part of a media controller to support Gen3. Give each VIN instance a unique name so it can be referenced from userspace. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 ++- 1 file

[PATCH v3 16/27] rcar-vin: add functions to manipulate Gen3 CHSEL value

On Gen3 the CSI routing is controlled by the VnCSI_IFMD register. One feature of this register is that it's only present in the VIN0 and VIN4 instances. The register in VIN0 controls the routing for VIN0-3 and the register in VIN4 controls routing for VIN4-7. To be able to control routing from a

[PATCH v3 19/27] rcar-vin: use different v4l2 operations in media controller mode

When the driver runs in media controller mode it should not directly control the subdevice instead userspace will be responsible for configuring the pipeline. To be able to run in this mode a different set of v4l2 operations needs to be used. Add a new set of v4l2 operations to support the

[PATCH v3 26/27] rcar-vin: enable support for r8a7795

Add the SoC specific information for Renesas r8a7795. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/Kconfig | 2 +- drivers/media/platform/rcar-vin/rcar-core.c | 72 + 2 files changed, 73

[PATCH v3 21/27] rcar-vin: add group allocator functions

In media controller mode all VIN instances needs to be part of the same media graph. There is also a need to each VIN instance to know and in some cases be able to communicate with other VIN instances. Add a allocator framework where the first VIN instance to be probed creates a shared data

[PATCH v3 11/27] rcar-vin: do not allow changing scaling and composing while streaming

It is possible on Gen2 to change the registers controlling composing and scaling while the stream is running. Is however not a good idea to do so and could result in trouble. There are also no good reason to allow this, remove immediate reflection in hardware registers from vidioc_s_selection and

[PATCH v3 22/27] rcar-vin: add chsel information to rvin_info

Each Gen3 SoC has a limited set of predefined routing possibilities for which CSI-2 device and virtual channel can be routed to which VIN instance. Prepare to store this information in the struct rvin_info. Signed-off-by: Niklas Söderlund ---

[PATCH v3 20/27] rcar-vin: register a media pad if running in media controller mode

When running in media controller mode a media pad is needed, register one. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 9 + drivers/media/platform/rcar-vin/rcar-vin.h | 4 2 files changed, 13

[PATCH v3 03/27] media: entity: Add media_entity_has_route() function

From: Laurent Pinchart This is a wrapper around the media entity has_route operation. Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Signed-off-by: Sakari Ailus

[PATCH v3 00/27] rcar-vin: Add Gen3 with media controller support

Hi All, This series enable Gen3 VIN support in rcar-vin driver for Renesas r8a7795 and r8a7796. It is based on top of v4.11-rc1. Patches that previously have been part of this series have been broken out to a separate series since they fix issues in the rcar-vin driver which are not strictly

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On Mon 2017-03-13 10:45:38, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > > On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > The event must be user visible, otherwise the user has no indication > > > the error, and can't correct it by stream

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi! > > Mid-layer is difficult... there are _hundreds_ of possible > > pipeline setups. If it should live in kernel or in userspace is a > > question... but I don't think having it in kernel helps in any way. > > Mid-layer is difficult, because we either need to feed some > library with

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 02:09 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote: But hold on, if my logic is correct, then why did the CSI power-off get reached in your case,

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 03:10 PM, Mauro Carvalho Chehab wrote: Em Sun, 12 Mar 2017 21:13:24 + Russell King - ARM Linux escreveu: On Sun, Mar 12, 2017 at 05:59:28PM -0300, Mauro Carvalho Chehab wrote: Yet, udev/systemd has some rules that provide an unique name for V4L

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/14/2017 09:47 AM, Russell King - ARM Linux wrote: On Tue, Mar 14, 2017 at 12:21:31PM -0400, Nicolas Dufresne wrote: My main concern here based on what I'm reading, is that this driver is not even able to notice immediately that a produced frame was corrupted (because it's out of sync).

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On Tue, Mar 14, 2017 at 12:21:31PM -0400, Nicolas Dufresne wrote: > My main concern here based on what I'm reading, is that this driver is > not even able to notice immediately that a produced frame was corrupted > (because it's out of sync). From usability perspective, this is really > bad. Can't

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has no

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > > On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > The event must be user visible, otherwise the user has no indication > > > the error, and can't correct

Re: [PATCH] media: mtk-jpeg: fix continuous log "Context is NULL"

On Tue, Mar 14, 2017 at 10:21 PM, Minghsiu Tsai wrote: > The symptom is continuous log "mtk-jpeg 18004000.jpegdec: Context is NULL" > in kernel log. It is becauese the error handling in irq doesn't clear > interrupt. > > The calling flow like as below when issue happen

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

On Tue, 2017-03-14 at 12:29 +, Reshetova, Elena wrote: > > Elena Reshetova writes: > > > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid accidental > > >

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-13 22:09 GMT+01:00 Laura Abbott : > On 03/12/2017 12:05 PM, Daniel Vetter wrote: >> On Sun, Mar 12, 2017 at 2:34 PM, Benjamin Gaignard >> wrote: >>> 2017-03-09 18:38 GMT+01:00 Laura Abbott : On 03/09/2017 02:00 AM,

[PATCH] media: mtk-jpeg: fix continuous log "Context is NULL"

The symptom is continuous log "mtk-jpeg 18004000.jpegdec: Context is NULL" in kernel log. It is becauese the error handling in irq doesn't clear interrupt. The calling flow like as below when issue happen mtk_jpeg_device_run() mtk_jpeg_job_abort() v4l2_m2m_job_finish() -> m2m_dev->curr_ctx =

Re: [PATCH v6 1/3] drm_fourcc: Add new P010, P016 video format

On Tue, 2017-03-07 at 04:27 +0800, Ayaka wrote: > > 從我的 iPad 傳送 > > > Ville Syrjälä 於 2017年3月7日 上午2:34 寫道： > > > > > On Tue, Mar 07, 2017 at 01:58:23AM +0800, Ayaka wrote: > > > > > > > > > 從我的 iPad 傳送 > > > > > > > > Ville Syrjälä

RE: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

> Elena Reshetova writes: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations.

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

Elena Reshetova writes: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > >

Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs

On Tue, 2017-03-07 at 13:08 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > Added V4l2 controls for HEVC encoder > > It should be rather "Document controls for HEVC encoder" or sth similar. > > In general most of comments are in previous patch. > Few additional

Re: [Patch v2 10/11] s5p-mfc: Add support for HEVC encoder

On Tue, 2017-03-07 at 12:33 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > Add HEVC encoder support and necessary registers, V4L2 CIDs, > > and hevc encoder parameters > > > > Signed-off-by: Smitha T Murthy > > --- > >

Re: [Patch v2 07/11] Documentation: v4l: Documentation for HEVC v4l2 definition

On Tue, 2017-03-07 at 09:39 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > Add V4L2 definition for HEVC compressed format > > > > Signed-off-by: Smitha T Murthy > > Reviewed-by: Andrzej Hajda > > Thank you for the

Re: [Patch v2 04/11] s5p-mfc: Support MFCv10.10 buffer requirements

On Mon, 2017-03-06 at 15:48 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > Aligning the luma_dpb_size, chroma_dpb_size, mv_size and me_buffer_size > > for MFCv10.10. > > > > Signed-off-by: Smitha T Murthy > > --- > >

Re: [Patch v2 09/11] v4l2: Add v4l2 control IDs for HEVC encoder

On Tue, 2017-03-07 at 09:48 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > Add v4l2 controls for HEVC encoder > > > > Signed-off-by: Smitha T Murthy > > --- > > drivers/media/v4l2-core/v4l2-ctrls.c | 51 + > >

Re: [Patch v2 05/11] videodev2.h: Add v4l2 definition for HEVC

On Mon, 2017-03-06 at 15:52 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > Add V4L2 definition for HEVC compressed format > > > > Signed-off-by: Smitha T Murthy > Reviewed-by: Andrzej Hajda > -- > Regards > Andrzej Thank

Re: [Patch v2 03/11] s5p-mfc: Use min scratch buffer size as provided by F/W

On Mon, 2017-03-06 at 15:18 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > After MFC v8.0, mfc f/w lets the driver know how much scratch buffer > > size is required for decoder. If mfc f/w has the functionality, > > E_MIN_SCRATCH_BUFFER_SIZE, driver can know how

Re: [Patch v2 02/11] s5p-mfc: Adding initial support for MFC v10.10

On Mon, 2017-03-06 at 14:58 +0100, Andrzej Hajda wrote: > On 03.03.2017 10:07, Smitha T Murthy wrote: > > Adding the support for MFC v10.10, with new register file and > > necessary hw control, decoder, encoder and structural changes. > > > > Signed-off-by: Smitha T Murthy

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On Tue, 2017-03-14 at 08:34 +0100, Hans Verkuil wrote: > On 03/13/2017 10:03 PM, Sakari Ailus wrote: > > Hi Steve, > > > > On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote: > >> > >> > >> On 03/13/2017 06:55 AM, Philipp Zabel wrote: > >>> On Mon, 2017-03-13 at 13:27 +, Russell

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Tue, 14 Mar 2017 08:55:36 +0100 Hans Verkuil escreveu: > On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote: > > Hi Sakari, > > > > I started preparing a long argument about it, but gave up in favor of a > > simpler one. > > > > Em Mon, 13 Mar 2017 14:46:22 +0200 > >

Re: [PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

On 03/13/2017 12:43 PM, Jose Abreu wrote: > Hi Neil, > > > On 09-03-2017 14:27, Jose Abreu wrote: >> Hi Neil, >> >> >> On 08-03-2017 12:12, Neil Armstrong wrote: >>> Hi Jose, >>> >>> It seems here that we only have the RGB444<->YUV444 8bit tables, from the >>> Amlogic >>> source I have the

[PATCH] staging: atomicsp: fix a loop timeout

It's a post-op loop so we timeout with "max_wait" set to -1, not 0. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c

[patch] staging: atomisp: missing break statement in switch

Static analysis tools suggest that we probably want a break statement here before then next cast statement. Looks true to me. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter diff --git

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote: > Hi Sakari, > > I started preparing a long argument about it, but gave up in favor of a > simpler one. > > Em Mon, 13 Mar 2017 14:46:22 +0200 > Sakari Ailus escreveu: > >> Drivers are written to support hardware, not

[PATCH] staging: atomisp: silence an array overflow warning

Static checkers complain that we should check if "i" is in bounds before we check if "var8[i]" is a NUL char. This bug is harmless but also easy to fix. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c

[patch] Staging: atomisp: kfreeing a devm allocated pointer

We shouldn't pass devm allocated pointers to kfree() or it leads to a double free. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/atomisp/i2c/imx/otp_brcc064_e2prom.c

[PATCH] staging: atomisp: off by one in atomisp_acc_load_extensions()

We should be doing i-- on all error paths but we don't if the loop finishes successfully. I've re-arranged this so that we don't read beyond the end of acc_flag_to_pipe[] array. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter

[patch] staging/atomisp: silence uninitialized variable warnings

These print an uninitialized value for "opt". Let's just remove the printk. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c index

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On 03/13/2017 10:03 PM, Sakari Ailus wrote: > Hi Steve, > > On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote: >> >> >> On 03/13/2017 06:55 AM, Philipp Zabel wrote: >>> On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 03:16:48PM +0200,

Re: [PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

On 03/13/2017 08:03 PM, Jose Abreu wrote: > Hi Hans, > > > On 09-03-2017 15:40, Hans Verkuil wrote: >> On 09/03/17 16:15, Jose Abreu wrote: >>> Hi Hans, >>> >>> >>> Thanks for the review! >>> >>> >>> On 09-03-2017 12:29, Hans Verkuil wrote: On 07/03/17 17:48, Jose Abreu wrote: > HDMI

Re: [PATCH RFC] dvb: af9035.c: Logilink vg0022a to device id table

On Thu, 9 Mar 2017 17:51:14 +0100 Andreas Kemnade wrote: > Ths adds the logilink VG00022a dvb-t dongle to the device table. > The dongle contains (checked by removing the case) > IT9303 > SI2168 > 214730 > > The result is in cold state: > > usb 1-6: new high-speed USB