Simplify function returns by merging assignment and return.
Signed-off-by: Arushi Singhal
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 ++--
.../media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c| 7 ++-
2 files changed, 4 insertions(+), 11 deleti
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Mar 25 05:00:17 CET 2017
media-tree git hash:c3d4fb0fb41f4b5eafeee51173c14e50be12f839
media_build git
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v3
- change the subject.
- remove extra parenthesis.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
drivers/
Changed permissions to octal style
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c | 9 +++--
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 8
2 files changed, 7 insertions(+), 10 deletions(-)
diff --g
Hi Sakari,
Thanks for your review, I have some questions below:
On 2017-01-25 11:03 AM, Sakari Ailus wrote:
Hi Helen,
My apologies for the long review time!
Please see my comments below.
On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote:
From: Helen Fornazier
First version of th
Em Thu, 23 Mar 2017 19:03:20 +0100
Frank Schäfer escreveu:
> Am 23.03.2017 um 13:56 schrieb Mauro Carvalho Chehab:
> > Em Thu, 23 Mar 2017 13:01:32 +0100
> > Frank Schäfer escreveu:
> >
> >> Am 22.03.2017 um 15:46 schrieb Mauro Carvalho Chehab:
> >>> Em Sun, 19 Feb 2017 19:29:18 +0100
> >>>
There should be a spac after every colon in the subject. Please pay
attention to these small details, so you don't have to send the same patch
over and over.
julia
On Fri, 24 Mar 2017, Arushi Singhal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This was done with cocc
Greetings Linux
http://trevorroth.com/calcloan.php?sets=mz25y2rpda7g4wsb
Scott
From: Daniel Scheller
This adds detection and activation for STV0367-based tuner hardware (namely
CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the
extended stv0367 demod driver.
TDA18212 i2c_client/regmap-api code was originally implemented by
Antti Palosaari in a variant
From: Daniel Scheller
These patches enhance the functionality of dvb-frontends/stv0367 to work
with Digital Devices hardware driven by the ST STV0367 demodulator chip
and adds probe & attach bits to ddbridge to make use of them, effectively
enabling full support for CineCTv6 PCIe bridges and (old
From: Daniel Scheller
Move the *ter and *cab st_register tables into a separate header file and
additionally organize them via a multidimensional array, allowing to add
more tables with differing init values, and also prepare for a base init
table which should contain general setup values. Also a
From: Daniel Scheller
Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit
of the demodulator will be performed. While this might cause a slight delay
when switching channels due to all involved tables being rewritten, it can
even be dangerous in certain causes in that the
From: Daniel Scheller
Digital Devices uses defaults tables in their stv0367dd demod driver
variant which differ in a few registers, at least enough that no stable
operation can be provided with the tables already present in the driver
(init succeeds and DVB reception works but at least when the d
From: Daniel Scheller
This moves the PLL SETUP code from stv0367ter_init() into a dedicated
function, and also make it possible to configure 58Mhz IC speed at
27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode).
Signed-off-by: Daniel Scheller
---
drivers/media/dvb-frontends/stv036
From: Daniel Scheller
This - in conjunction with the previous changes - makes it possible to use
the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having
this demodulator soldered on them (namely CineCTv6 bridges and some earlier
DuoFlex CT addon modules).
The changes do the f
From: Daniel Scheller
Change defaults table writing so tables can be of dynamic length without
having to keep track of their lengths by adding and evaluating an end
marker (reg 0x), also move table writing to a dedicated function to
remove code duplication. Additionally mark st_register table
From: Daniel Scheller
Some hardware and bridges (namely ddbridge) require that tuner access is
limited to one concurrent access and wrap i2c gate control with a
mutex_lock when attaching frontends. According to vendor information, this
is required as concurrent tuner reconfiguration can interfere
From: Daniel Scheller
Currently, if_khz is set and provided using the configuration var in
struct stv0367_config. However, in some constellations, the value might be
different for differing channel bandwidths or even -T and -C operation.
When e.g. used in conjunction with TDA18212 tuners, the tun
From: Daniel Scheller
In some configurations (due to different PIN config, wiring or so), the
QAM FECLock might be signalled using a different register than
F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw),
so make that register selectable.
Signed-off-by: Daniel Scheller
From: Daniel Scheller
The values used for comparing symbol rates and the resulting conditional
reg writes seem wrong (rates multiplied by ten), so fix those values.
While this doesn't seem to influence operation, it should be fixed anyway.
Signed-off-by: Daniel Scheller
---
drivers/media/dvb-f
From: Daniel Scheller
The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed
everytime tuning succeeds or fails, quite cluttering the normal kernel log.
Use dprintk() instead of printk(KERN_ERR...) so that if the information is
needed, it'll be printed when the stv_debug modparam
Le vendredi 24 mars 2017 à 15:41 +0100, Hans Verkuil a écrit :
> > +static const struct venus_format vdec_formats[] = {
> > + {
> > + .pixfmt = V4L2_PIX_FMT_NV12,
> > + .num_planes = 1,
> > + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
>
> Just curious: is N
On Sun, Feb 12, 2017 at 03:39:42PM +0900, Chetan Sethi wrote:
> This is a patch to the lirc_sir.c file that fixes coding style warning
> found by checkpatch.pl
>
> Signed-off-by: Chetan Sethi
Another patch was merged which already fixed this, I'm sorry.
Sean
> ---
> drivers/staging/media/lirc
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Benjamin Gaignard
---
drivers/staging/media/st-cec/stih-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/st-cec/stih-cec.c
b/drivers/staging/media
Hi,
This series introduces a new helper function called cec_get_drvdata() which
returns the adapter private data and can be used by drivers that use CEC.
Best regards,
Jose Miguel Abreu
Jose Abreu (8):
[media] cec: Add cec_get_drvdata()
[media] staging: st-cec: Use cec_get_drvdata()
[media
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index d8bf435..f1fa9ce
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/i2c/adv7511.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c
index 8c9e289..ccc4786
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Kamil Debski
---
drivers/staging/media/s5p-cec/s5p_cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c
b/drivers/staging/media/s5p-
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/i2c/adv7842.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c
index 2d61f0c..303effd
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/usb/pulse8-cec/pulse8-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/pulse8-cec/pulse8-cec.c
b/drivers/media/usb/puls
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/platform/vivid/vivid-cec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/vivid/vivid-cec.c
b/drivers/media/platform/viv
Add a helper function to get driver private data from CEC
adapter. This helps the readability a little bit and allows
to change the 'priv' field name to something else without
needing to touch all drivers.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
include/media/cec.h | 5 +
1 file chan
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-Remove unnecessary parenthesis
drivers/staging/media/omap4iss/iss_csi2.c| 2 +-
drivers/staging/media/omap4iss/iss
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-Remove unnecessary parenthesis.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
drivers/staging/media/davi
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
changes in v2
-remove the unnecessary parenthesis.
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 12 ++--
drive
Thanks for the comments!
On 03/24/2017 04:49 PM, Hans Verkuil wrote:
> On 03/13/17 17:37, Stanimir Varbanov wrote:
>> This adds Venus driver Makefile and changes v4l2 platform
>> Makefile/Kconfig in order to enable building of the driver.
>>
>> Signed-off-by: Stanimir Varbanov
>> ---
>> drivers/
On 03/13/17 17:37, Stanimir Varbanov wrote:
> This adds Venus driver Makefile and changes v4l2 platform
> Makefile/Kconfig in order to enable building of the driver.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/Kconfig | 14 ++
> drivers/media/platf
Some comments and questions below:
On 03/13/17 17:37, Stanimir Varbanov wrote:
> This consists of video decoder implementation plus decoder
> controls.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/venus/vdec.c | 1091
>
> drivers/media
Some review comments below:
On 03/13/17 17:37, Stanimir Varbanov wrote:
> * core.c has implemented the platform dirver methods, file
dirver -> driver
> operations and v4l2 registration.
>
> * helpers.c has implemented common helper functions for:
>- buffer management
>
>- vb2_ops and
Use for_each_sg() instead of open-coding it.
Signed-off-by: Geliang Tang
---
drivers/media/pci/ivtv/ivtv-udma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/ivtv/ivtv-udma.c
b/drivers/media/pci/ivtv/ivtv-udma.c
index 2c9232e..3b33e87 100644
--- a/drivers
On 03/24/17 15:06, Hans Verkuil wrote:
> On 03/13/17 17:37, Stanimir Varbanov wrote:
>> Hi all,
>>
>> Here is seventh version of the patch-set - no functional changes in
>> v4l2 APIs.
>>
>> The changes since v6 are.
>> * changes in DT binding document - moved memory-region DT property
>> in v
On 03/13/17 17:37, Stanimir Varbanov wrote:
> Hi all,
>
> Here is seventh version of the patch-set - no functional changes in
> v4l2 APIs.
>
> The changes since v6 are.
> * changes in DT binding document - moved memory-region DT property
> in video-codec node - see 2/9.
> * improved recov
On Fri, Mar 24, 2017 at 02:20:24PM +0100, Arnd Bergmann wrote:
> The revert reintroduced a build failure without CONFIG_ION:
>
> media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: error: excess elements in array
> initializer [-Werror]
> media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: note: (near initializati
The revert reintroduced a build failure without CONFIG_ION:
media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: error: excess elements in array
initializer [-Werror]
media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: note: (near initialization for
'hmm_bo_type_strings')
We should really be able to build in any
On 03/24/17 13:21, Jose Abreu wrote:
> Hi Hans,
>
>
> On 24-03-2017 12:12, Hans Verkuil wrote:
>> On 03/24/17 12:52, Jose Abreu wrote:
>>> Hi Hans,
>>>
>>>
> Can you please review this series, when possible? And if you
> could test it on cobalt it would be great :)
Hopefully next wee
Hi Hans,
On 24-03-2017 12:12, Hans Verkuil wrote:
> On 03/24/17 12:52, Jose Abreu wrote:
>> Hi Hans,
>>
>>
Can you please review this series, when possible? And if you
could test it on cobalt it would be great :)
>>> Hopefully next week.
>> Thanks :)
>>
>>> Did you have some real-world
On 03/24/17 12:52, Jose Abreu wrote:
> Hi Hans,
>
>
>>> Can you please review this series, when possible? And if you
>>> could test it on cobalt it would be great :)
>> Hopefully next week.
>
> Thanks :)
>
>> Did you have some real-world numbers w.r.t. measured
>> pixelclock frequencies and 60
Hi Hans,
>> Can you please review this series, when possible? And if you
>> could test it on cobalt it would be great :)
> Hopefully next week.
Thanks :)
> Did you have some real-world numbers w.r.t. measured
> pixelclock frequencies and 60 vs 59.94 Hz and 24 vs 23.976 Hz?
I did make some mea
On 03/24/17 12:03, Jose Abreu wrote:
> Hi Hans,
>
>
> On 21-03-2017 11:49, Jose Abreu wrote:
>> Hi all,
>>
>> This is a follow up patch from this discussion [1]. It should be
>> seen more as a starting point to introduce better handling of
>> time per frame in v4l2. Quoting Hans Verkuil from [1]:
Hi Hans,
On 21-03-2017 11:49, Jose Abreu wrote:
> Hi all,
>
> This is a follow up patch from this discussion [1]. It should be
> seen more as a starting point to introduce better handling of
> time per frame in v4l2. Quoting Hans Verkuil from [1]:
>
> 1) "Add a flag V4L2_DV_FL_CAN_DETECT_REDUCED_
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
tags/media/v4.11-3
for a series of fixes:
- dvb-usb-firmware: don't do DMA on stack
- coda/imx-vdoa: platform_driver should not be const
- bdisp: Clean up file handle in open() error path
Em Thu, 23 Mar 2017 17:04:21 -0700
pe...@easthope.ca escreveu:
> With a manual setting of the device path and ID, the V4L2 Test Bench
> produced this image from a JVC TK-1070U camera on a microscope.
> http://easthope.ca/JVCtoPVR150screen.jpg
>
> Setting the device in the Test Bench each time
On Fri, Mar 24, 2017 at 11:18:33AM +0530, Pushkar Jambhlekar wrote:
> Removing hardcoded function name as code is already using __func__
>
> Signed-off-by: Pushkar Jambhlekar
> ---
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
53 matches
Mail list logo