cron job: media_tree daily build: ERRORS

2017-05-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue May 16 05:00:23 CEST 2017 media-tree git hash:3622d3e77ecef090b5111e3c5423313f11711dfa media_build gi

Re: [PATCH v3 1/3] dt-bindings: mt8173: Fix mdp device tree

2017-05-15 Thread Rob Herring
On Fri, May 12, 2017 at 11:22:39AM +0800, Minghsiu Tsai wrote: > If the mdp_* nodes are under an mdp sub-node, their corresponding > platform device does not automatically get its iommu assigned properly. > > Fix this by moving the mdp component nodes up a level such that they are > siblings of md

Re: [PATCH 1/3] [media] si2157: get chip id during probing

2017-05-15 Thread Andreas Kemnade
Hi, On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari wrote: > On 03/16/2017 12:22 AM, Andreas Kemnade wrote: > > If the si2157 is behind a e.g. si2168, the si2157 will > > at least in some situations not be readable after the si268 > > got the command 0101. It still accepts commands but the an

Re: Is it possible to have a binary blob custom control?

2017-05-15 Thread Patrick Doyle
Another possible mis-abuse of a binary blob control would be as a mechanism for retrieving a lumanance histogram from an image processing peripheral. Once again, I could implement that through the debugfs as Jean-Michel suggested, or I could do something more standard. Any suggestions for a "more

[PATCH 4/5] staging: media: lirc: Use sizeof(*p) instead of sizeof(struct P)

2017-05-15 Thread Ricardo Silva
Fix all checkpatch reported issues for "CHECK: Prefer kzalloc(sizeof(*)...) over kzalloc(sizeof(struct )...)". Other similar case in the code already using recommended style, so make it all consistent with the recommended practice. Signed-off-by: Ricardo Silva --- drivers/staging/media/lirc/lir

[PATCH 3/5] staging: media: lirc: Use __func__ for logging function name

2017-05-15 Thread Ricardo Silva
Fix all checkpatch reported issues for "CHECK: Prefer using '"%s...", __func__' to using '', ..." Use recommended style. Additionally, __func__ was already used in similar cases throughout the code, so make it all consistent. Signed-off-by: Ricardo Silva --- drivers/staging/media/lirc/lirc_zilo

[PATCH 5/5] staging: media: lirc: Fix unbalanced braces around if/else

2017-05-15 Thread Ricardo Silva
Fix all checkpatch reported issues for: * CHECK: "braces {} should be used on all arms of this statement". * CHECK: "Unbalanced braces around else statement". Make sure all if/else statements are balanced in terms of braces. Most cases in code are, but a few were left unbalanced, so put them al

[PATCH 0/5] staging: media: lirc: Fix several checkpatch issues

2017-05-15 Thread Ricardo Silva
This patch series is intended to fix several checkpatch issues (from CHECK level) found on lirc_zilog.c: The 1st patch focus on whitespace related fixes. The 2nd patch fixes NULL comparisons style. The 3rd patch is for using __func__ in logging functions that are to trace the function's name, inst

[PATCH 1/5] staging: media: lirc: Fix whitespace style checks

2017-05-15 Thread Ricardo Silva
Fix style issues reported by checkpatch, affecting whitespace only: * CHECK: "Please don't use multiple blank lines". Two of these still triggering and left untouched because used for separating logical blocks (vars from functions, etc.). * CHECK: "spaces preferred around that ''". All

[PATCH 2/5] staging: media: lirc: Fix NULL comparisons style

2017-05-15 Thread Ricardo Silva
Fix all checkpatch reported issues for "CHECK: Comparison to NULL could be written...". Do these comparisons using the recommended coding style and consistent with other similar cases in the file, which already used the recommended way. Signed-off-by: Ricardo Silva --- drivers/staging/media/lir

Re: [PATCH v3 16/16] ARM: dts: exynos: Remove MFC reserved buffers

2017-05-15 Thread Krzysztof Kozlowski
On Mon, Mar 20, 2017 at 11:56:42AM +0100, Marek Szyprowski wrote: > During my research I found that some of the requirements for the memory > buffers for MFC v6+ devices were blindly copied from the previous (v5) > version and simply turned out to be excessive. The relaxed requirements > are applie

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-15 Thread Kieran Bingham
Hi Sakari On 12/05/17 17:46, Sakari Ailus wrote: > Hi Kieran, > > Thanks for the patches! Thankyou for the review! > Would you have a media-ctl -p && media-ctl --print-dot (or the PS file) to > see how this looks like in practice? The file I linked to on Friday showed the immutable links versi

Re: [PATCH 2/2] staging/atomisp: putting NULs in the wrong place

2017-05-15 Thread Dan Carpenter
On Mon, May 15, 2017 at 12:21:45PM +0200, walter harms wrote: > can this strcpy_s() replaced with strlcpy ? > These functions obviously should be removed, yes. Please send a patch for that and we can drop my patches. Give David reported-by credit. regards, dan carpenter

Re: [PATCH 2/2] staging/atomisp: putting NULs in the wrong place

2017-05-15 Thread walter harms
Am 15.05.2017 12:01, schrieb Dan Carpenter: > We're putting the NUL terminators one space beyond where they belong. > This doesn't show up in testing because all but the callers put a NUL in > the correct place themselves. LOL. It causes a static checker warning > about buffer overflows. > > F

[PATCH 2/2] staging/atomisp: putting NULs in the wrong place

2017-05-15 Thread Dan Carpenter
We're putting the NUL terminators one space beyond where they belong. This doesn't show up in testing because all but the callers put a NUL in the correct place themselves. LOL. It causes a static checker warning about buffer overflows. Fixes: a49d25364dfb ("staging/atomisp: Add support for the

[PATCH 1/2] staging/atomisp: one char read beyond end of string

2017-05-15 Thread Dan Carpenter
We should verify that "ix < max_len" before we test whether we have reached the NUL terminator. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Reported-by: David Binderman Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/hi

Re: [PATCH 1/2] staging/atomisp: one char read beyond end of string

2017-05-15 Thread Dan Carpenter
Oops. Please ignore this one. I meant to send it to David Binderman's thread. regards, dan carpenter

[PATCH 1/2] staging/atomisp: one char read beyond end of string

2017-05-15 Thread Dan Carpenter
We should verify that "ix < max_len" before we test whether we have reached the NUL terminator. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Reported-by: David Binderman Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/hi

Re: [PATCH v3 3/3] media: mtk-mdp: Fix mdp device tree

2017-05-15 Thread Matthias Brugger
On 15/05/17 04:31, Minghsiu Tsai wrote: On Fri, 2017-05-12 at 17:05 +0200, Matthias Brugger wrote: On 12/05/17 05:22, Minghsiu Tsai wrote: From: Daniel Kurtz If the mdp_* nodes are under an mdp sub-node, their corresponding platform device does not automatically get its iommu assigned prop