cron job: media_tree daily build: WARNINGS

2017-05-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed May 17 05:00:21 CEST 2017 media-tree git hash:3622d3e77ecef090b5111e3c5423313f11711dfa media_build gi

Re: [patch, libv4l]: Introduce define for lookup table size

2017-05-16 Thread Pavel Machek
Hi! > >>> Make lookup table size configurable at compile-time. > >> > >> I don't think I'll take this patch. The problem is that if we really add > >> support for 10 or 12 bit lookup tables in the future, then just changing > >> LSIZE isn't enough. > >> > >> This patch doesn't really add anything

Re: Sensor sub-device - what are the mandatory ops?

2017-05-16 Thread Sakari Ailus
Hi Dave, On Thu, May 11, 2017 at 04:51:27PM +0100, Dave Stevenson wrote: > Hi All. > > As previously discussed, I'm working on a V4L2 driver for the > CSI-2/CCP2 receiver on BCM283x, as used on Raspberry Pi. > It's a relatively simple hardware block that writes received data into > SDRAM, and onl

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-16 Thread Sakari Ailus
Hi Kieran, On Tue, May 16, 2017 at 01:56:05PM +0100, Kieran Bingham wrote: ... > +static int adv748x_afe_g_input_status(struct v4l2_subdev *sd, u32 > *status) > +{ > +struct adv748x_state *state = adv748x_afe_to_state(sd); > +int ret; > + > +

Re: [PATCH 0/4] Support for Synopsys DW CSI-2 Host

2017-05-16 Thread Sakari Ailus
Hi Ramiro, On Tue, Mar 07, 2017 at 02:37:47PM +, Ramiro Oliveira wrote: > This patchset adds support for the DW CSI-2 Host and also for a video > device associated with it. > > The first 2 patches are only for the DW CSI-2 Host and the last 2 are for > the video device. > > Although this pa

[PATCH] staging: media: atomisp: declare not-exported functions as static

2017-05-16 Thread Paolo Cretaro
Fix warnings issued by sparse: symbol 'gmin_v1p2_ctrl' was not declared. Should it be static? symbol 'gmin_v1p8_ctrl' was not declared. Should it be static? symbol 'gmin_v2p8_ctrl' was not declared. Should it be static? symbol 'gmin_flisclk_ctrl' was not declared. Should it be static? Signed-off-b

Re: [PATCH] staging: media: cxd2099: Fix checkpatch issues

2017-05-16 Thread Jasmin J.
Hello Christoph! The current cxd2099 driver is an old version. DD provides a newer variant. Please see my patch series http://www.mail-archive.com/linux-media@vger.kernel.org/msg112410.html Especially this patch http://www.mail-archive.com/linux-media@vger.kernel.org/msg112409.html where I re

[PATCH] staging: media: cxd2099: Fix checkpatch issues

2017-05-16 Thread eddi1983
From: Christoph Fanelsa Fix checkpatch warnings of prefered using '%s..", __func__' as function name in a string Signed-off-by: Christoph Fanelsa --- drivers/staging/media/cxd2099/cxd2099.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/cxd2099

Re: [PATCH 2/4] media: platform: dwc: Support for DW CSI-2 Host

2017-05-16 Thread Ramiro Oliveira
Hi Hans, Thank you very much for your feedback. On 5/8/2017 11:38 AM, Hans Verkuil wrote: > Hi Ramiro, > > My sincere apologies for the long delay in reviewing this. The good news is > that > I should have more time for reviews going forward, so I hope I'll be a lot > quicker > in the future.

Re: [PATCH 3/4] Documentation: dt: Add bindings documentation for CSI-2 Host Video Platform

2017-05-16 Thread Ramiro Oliveira
Hi Rob, Once again sorry for the late response and thank you for your feedback. On 3/15/2017 6:35 PM, Rob Herring wrote: > On Tue, Mar 07, 2017 at 02:37:50PM +, Ramiro Oliveira wrote: >> Create device tree bindings documentation for the CSI-2 Host Video >> platform. >> >> Signed-off-by: Rami

Re: [PATCH 3/4] Documentation: dt: Add bindings documentation for CSI-2 Host Video Platform

2017-05-16 Thread Ramiro Oliveira
Hi Sakari, Thank you for your feedback and sorry for the late response. On 3/8/2017 1:18 PM, Sakari Ailus wrote: > Hi Ramiro, > > On Tue, Mar 07, 2017 at 02:37:50PM +, Ramiro Oliveira wrote: >> Create device tree bindings documentation for the CSI-2 Host Video >> platform. > > Extra space

Re: [PATCH 1/4] Documentation: dt: Add bindings documentation for DW MIPI CSI-2 Host

2017-05-16 Thread Ramiro Oliveira
Hi Rob, Thank you for your feedback and sorry for the late reply. On 3/15/2017 6:26 PM, Rob Herring wrote: > On Tue, Mar 07, 2017 at 02:37:48PM +, Ramiro Oliveira wrote: >> Create device tree bindings documentation for the Synopsys DW MIPI CSI-2 >> Host. >> >> Signed-off-by: Ramiro Oliveira

Re: v4l2_subdev_queryctrl and friends

2017-05-16 Thread Patrick Doyle
On Tue, May 16, 2017 at 12:13 PM, Hans Verkuil wrote: > It needs something like this (taken from rcar-vin.c): > > ret = v4l2_ctrl_add_handler(&vin->ctrl_handler, sd->ctrl_handler, > NULL); > if (ret < 0) > return ret; > Thank you . That did the trick. Continuing o

Re: v4l2_subdev_queryctrl and friends

2017-05-16 Thread Hans Verkuil
On 16/05/17 16:31, Patrick Doyle wrote: > There is a statement in the v4l2-controls.txt in my 4.4.55 kernel that > v4l2_subdev_queryctrl and friends will be removed "Once all the V4L2 > drivers that depend on subdev drivers are converted to the control > framework". > > How would I be able to tell

Re: [PATCH v3 2/2] v4l: vsp1: Provide a writeback video device

2017-05-16 Thread Geert Uytterhoeven
Hi Kieran, On Tue, May 9, 2017 at 6:39 PM, Kieran Bingham wrote: > When the VSP1 is used in an active display pipeline, the output of the > WPF can supply the LIF entity directly and simultaneously write to > memory. > > Support this functionality in the VSP1 driver, by extending the WPF > source

v4l2_subdev_queryctrl and friends

2017-05-16 Thread Patrick Doyle
There is a statement in the v4l2-controls.txt in my 4.4.55 kernel that v4l2_subdev_queryctrl and friends will be removed "Once all the V4L2 drivers that depend on subdev drivers are converted to the control framework". How would I be able to tell if my driver (isc-atmel.c) has been converted to th

[PATCH v3] cec: add STM32 cec driver

2017-05-16 Thread Benjamin Gaignard
This patch add cec driver for STM32 platforms. cec hardware block isn't not always used with hdmi so cec notifier is not implemented. That will be done later when STM32 DSI driver will be available. Driver compliance has been tested with cec-ctl and cec-compliance tools. Signed-off-by: Benjamin G

Re: [PATCH v2 2/2] cec: add STM32 cec driver

2017-05-16 Thread Benjamin Gaignard
2017-05-16 15:09 GMT+02:00 Hans Verkuil : > Looks good, except for the logical address handling that I think is wrong: > > On 16/05/17 14:56, Benjamin Gaignard wrote: >> This patch add cec driver for STM32 platforms. >> cec hardware block isn't not always used with hdmi so >> cec notifier is not im

Re: [PATCH v2 2/2] cec: add STM32 cec driver

2017-05-16 Thread Hans Verkuil
Looks good, except for the logical address handling that I think is wrong: On 16/05/17 14:56, Benjamin Gaignard wrote: > This patch add cec driver for STM32 platforms. > cec hardware block isn't not always used with hdmi so > cec notifier is not implemented. That will be done later > when STM32 DS

[PATCH v2 0/2] cec: STM32 driver

2017-05-16 Thread Benjamin Gaignard
version 2: - fix typo in compagnie name - add yannick sign-off - use cec_message instead of custom struct in cec device - add monitor mode I don't change the split between irq handler and irq thread because it would had mean to handle all errors cases irq handler to keep a correct sequence. I don'

[PATCH v2 1/2] binding for stm32 cec driver

2017-05-16 Thread Benjamin Gaignard
Signed-off-by: Benjamin Gaignard --- .../devicetree/bindings/media/st,stm32-cec.txt| 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.txt diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.txt

[PATCH v2 2/2] cec: add STM32 cec driver

2017-05-16 Thread Benjamin Gaignard
This patch add cec driver for STM32 platforms. cec hardware block isn't not always used with hdmi so cec notifier is not implemented. That will be done later when STM32 DSI driver will be available. Driver compliance has been tested with cec-ctl and cec-compliance tools. Signed-off-by: Benjamin G

Re: [patch, libv4l]: Introduce define for lookup table size

2017-05-16 Thread Hans Verkuil
On 16/05/17 14:45, Pavel Machek wrote: > Hi! > >>> Make lookup table size configurable at compile-time. >> >> I don't think I'll take this patch. The problem is that if we really add >> support for 10 or 12 bit lookup tables in the future, then just changing >> LSIZE isn't enough. >> >> This patch

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-16 Thread Kieran Bingham
Hi Sakari, (Gianluca, I've pulled you in on CC in respect to discussing changes you implemented for supporting GCC < 4.4.6) On 16/05/17 12:54, Sakari Ailus wrote: > Hi Kieran, > > On Mon, May 15, 2017 at 01:32:41PM +0100, Kieran Bingham wrote: >> Hi Sakari >> >> On 12/05/17 17:46, Sakari Ailus w

Re: [patch, libv4l]: Introduce define for lookup table size

2017-05-16 Thread Pavel Machek
Hi! > > Make lookup table size configurable at compile-time. > > I don't think I'll take this patch. The problem is that if we really add > support for 10 or 12 bit lookup tables in the future, then just changing > LSIZE isn't enough. > > This patch doesn't really add anything as it stands. Wel

[GIT PULL FOR v4.12] Various fixes/regressions for 4.12.

2017-05-16 Thread Hans Verkuil
Hi Mauro, This supersedes this earlier pull request: https://patchwork.linuxtv.org/patch/41065/ This new pull request adds the 'cec-notifier.h: handle unreachable CONFIG_CEC_CORE' patch. Otherwise it is unchanged. Regards, Hans The following changes since commit 3622d3e77ecef090b5111

Re: [PATCH 2/3] [media] doc-rst: add IPU3 raw10 bayer pixel format definitions

2017-05-16 Thread Sakari Ailus
Hi Yong, On Sat, Apr 29, 2017 at 06:34:35PM -0500, Yong Zhi wrote: > The formats added by this patch are: > > V4L2_PIX_FMT_IPU3_SBGGR10 > V4L2_PIX_FMT_IPU3_SGBRG10 > V4L2_PIX_FMT_IPU3_SGRBG10 > V4L2_PIX_FMT_IPU3_SRGGB10 > > Signed-off-by: Yong Zhi > --- > Documentation/media/ua

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-16 Thread Sakari Ailus
Hi Kieran, On Mon, May 15, 2017 at 01:32:41PM +0100, Kieran Bingham wrote: > Hi Sakari > > On 12/05/17 17:46, Sakari Ailus wrote: > > Hi Kieran, > > > > Thanks for the patches! > > Thankyou for the review! You're welcome! :-) > > > Would you have a media-ctl -p && media-ctl --print-dot (or t

Re: [patch, libv4l]: Introduce define for lookup table size

2017-05-16 Thread Hans Verkuil
On 09/05/17 13:04, Pavel Machek wrote: > > Make lookup table size configurable at compile-time. I don't think I'll take this patch. The problem is that if we really add support for 10 or 12 bit lookup tables in the future, then just changing LSIZE isn't enough. This patch doesn't really add anyt

Re: [patch, libv4l]: fix integer overflow

2017-05-16 Thread Pavel Machek
Hi! > > This bit me while trying to use absolute exposure time on Nokia N900: > > > > Can someone apply it to libv4l2 tree? Could I get some feedback on the > > other patches? Is this the way to submit patches to libv4l2? > > Yes, it is. But I do need a Signed-off-by from you. Ping? Can I get y

Re: [PATCH 2/2] cec: add STM32 cec driver

2017-05-16 Thread Hans Verkuil
Hi Benjamin, Thanks for the patch! Always nice to see new CEC drivers. On 16/05/17 11:01, Benjamin Gaignard wrote: > This patch add cec driver for STM32 platforms. > cec hardware block isn't not always used with hdmi so > cec notifier is not implemented. That will be done later > when STM32 DSI d

Re: [PATCH 0/2] cec: STM32 driver

2017-05-16 Thread Benjamin Gaignard
2017-05-16 11:18 GMT+02:00 Hans Verkuil : > On 16/05/17 11:10, Benjamin Gaignard wrote: >> + Yannick who is the original writer of this driver (sorry) >> >> 2017-05-16 11:01 GMT+02:00 Benjamin Gaignard : >>> This serie of patches add cec driver for STM32 platforms. >>> >>> This code doesn't impleme

Re: [PATCH 0/2] cec: STM32 driver

2017-05-16 Thread Hans Verkuil
On 16/05/17 11:10, Benjamin Gaignard wrote: > + Yannick who is the original writer of this driver (sorry) > > 2017-05-16 11:01 GMT+02:00 Benjamin Gaignard : >> This serie of patches add cec driver for STM32 platforms. >> >> This code doesn't implement cec notifier because STM32 doesn't >> provide

Re: [PATCH 0/2] cec: STM32 driver

2017-05-16 Thread Benjamin Gaignard
+ Yannick who is the original writer of this driver (sorry) 2017-05-16 11:01 GMT+02:00 Benjamin Gaignard : > This serie of patches add cec driver for STM32 platforms. > > This code doesn't implement cec notifier because STM32 doesn't > provide HDMI yet but it will be added later. > > Those patches

[PATCH 0/2] cec: STM32 driver

2017-05-16 Thread Benjamin Gaignard
This serie of patches add cec driver for STM32 platforms. This code doesn't implement cec notifier because STM32 doesn't provide HDMI yet but it will be added later. Those patches have been developped on top of media_tree master branch where STM32 DCMI code has not been merged so conflict in Kcon

[PATCH 2/2] cec: add STM32 cec driver

2017-05-16 Thread Benjamin Gaignard
This patch add cec driver for STM32 platforms. cec hardware block isn't not always used with hdmi so cec notifier is not implemented. That will be done later when STM32 DSI driver will be available. Driver compliance has been tested with cec-ctl and cec-compliance tools. Signed-off-by: Benjamin G

[PATCH 1/2] binding for stm32 cec driver

2017-05-16 Thread Benjamin Gaignard
Signed-off-by: Benjamin Gaignard --- .../devicetree/bindings/media/st,stm32-cec.txt| 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/st,stm32-cec.txt diff --git a/Documentation/devicetree/bindings/media/st,stm32-cec.txt

[PATCH] [media] sir_ir: infinite loop in interrupt handler

2017-05-16 Thread Sean Young
Since this driver does no detection of hardware, it might be used with a non-sir port. Escape out if we are spinning. Signed-off-by: Sean Young --- drivers/media/rc/sir_ir.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/rc/sir_ir.c b/drivers/media/rc/sir_ir.c index e12e

Re: [[media] rc] e662671619: BUG: kernel hang in test stage

2017-05-16 Thread Sean Young
On Mon, May 08, 2017 at 08:13:37PM +0800, kernel test robot wrote: > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > commit e66267161971155a8b4756b4e17f2f2f82b9f842 > Author