Re: [RFC 00/10] V4L2 explicit synchronization support

2017-06-08 Thread Gustavo Padovan
2017-06-08 Shuah Khan : > Hi Gustavo, > > On Thu, Jun 8, 2017 at 2:17 PM, Mauro Carvalho Chehab > wrote: > > Hi Gustavo, > > > > Em Wed, 24 May 2017 21:31:01 -0300 > > Gustavo Padovan escreveu: > > > >> Hi all, > >> > >> I've been working on the v2 of this series, but I think I hit a blocker >

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-08 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 3:07 AM, Robin Murphy wrote: > On 08/06/17 15:35, Tomasz Figa wrote: >> On Thu, Jun 8, 2017 at 10:22 PM, Robin Murphy wrote: >>> On 07/06/17 10:47, Tomasz Figa wrote: Hi Yong, +Robin, Joerg, IOMMU ML Please see my comments inline. On Tue,

Re: [RFC 00/10] V4L2 explicit synchronization support

2017-06-08 Thread Gustavo Padovan
Hi Mauro, 2017-06-08 Mauro Carvalho Chehab : > Hi Gustavo, > > Em Wed, 24 May 2017 21:31:01 -0300 > Gustavo Padovan escreveu: > > > Hi all, > > > > I've been working on the v2 of this series, but I think I hit a blocker > > when trying to cover the case where the driver asks to requeue the >

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-08 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 1:43 AM, Sakari Ailus wrote: > Hi Tomasz, > > On Wed, Jun 07, 2017 at 05:35:13PM +0900, Tomasz Figa wrote: >> Hi Yong, Tuukka, >> >> Continuing from yesterday. Please see comments inline. >> >> > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: >> [snip] >> >> + ptr =

Re: [PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

2017-06-08 Thread Binoy Jayan
On 8 June 2017 at 20:40, Arnd Bergmann wrote: > On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: >> The semaphore 'cmd_mutex' is used as a simple mutex, so >> it should be written as one. Semaphores are going away in the future. >> >> Signed-off-by: Binoy Jayan >> --- > >> @@ -1283,7 +1283,7

Re: [PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

2017-06-08 Thread Kevin Hilman
On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil wrote: > On 07/06/17 01:37, Kevin Hilman wrote: >> Enable getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) >> am437x-vpfe.c >> >> Signed-off-by: Kevin Hilman >> --- >> drivers/

[media-af9013] question about return value in function af9013_wr_regs()

2017-06-08 Thread Gustavo A. R. Silva
Hello everybody, While looking into Coverity ID 1227035 I ran into the following piece of code at drivers/media/dvb-frontends/af9013.c:595: 595/* program CFOE coefficients */ 596if (c->bandwidth_hz != state->bandwidth_hz) { 597for (i = 0; i < ARRAY_SIZE(coeff_

Re: [RFC 00/10] V4L2 explicit synchronization support

2017-06-08 Thread Shuah Khan
Hi Gustavo, On Thu, Jun 8, 2017 at 2:17 PM, Mauro Carvalho Chehab wrote: > Hi Gustavo, > > Em Wed, 24 May 2017 21:31:01 -0300 > Gustavo Padovan escreveu: > >> Hi all, >> >> I've been working on the v2 of this series, but I think I hit a blocker >> when trying to cover the case where the driver a

Re: [PATCH v8 14/34] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-06-08 Thread Steve Longerbeam
On 06/08/2017 01:25 PM, Tim Harvey wrote: Steve, You need to remove the fim node now that you've moved this to V4L2 controls. Yep, I caught this just after sending the v8 patchset. I'll send a v9 of this patch. Steve

Re: [PATCH v8 14/34] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-06-08 Thread Tim Harvey
On Wed, Jun 7, 2017 at 11:33 AM, Steve Longerbeam wrote: > Enables the ADV7180 decoder sensor. The ADV7180 connects to the > parallel-bus mux input on ipu1_csi0_mux. > > The ADV7180 power pin is via max7310_b port expander. > > Signed-off-by: Steve Longerbeam > > - Use IRQ_TYPE_LEVEL_LOW instead

Re: [RFC 00/10] V4L2 explicit synchronization support

2017-06-08 Thread Mauro Carvalho Chehab
Hi Gustavo, Em Wed, 24 May 2017 21:31:01 -0300 Gustavo Padovan escreveu: > Hi all, > > I've been working on the v2 of this series, but I think I hit a blocker > when trying to cover the case where the driver asks to requeue the > buffer. It is related to the out-fence side. > > In the current

Re: [PATCH v4] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-06-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Jun 2017 22:32:10 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Thu, Jun 08, 2017 at 03:00:22PM -0300, Mauro Carvalho Chehab wrote: > > Em Wed, 7 Jun 2017 10:52:07 +0100 > > Kieran Bingham escreveu: > > > > > From: Kieran Bingham > > > > > > Return NULL, if a null entity is pa

[PATCH 1/1] v4l: ctrls: Add a control for digital gain

2017-06-08 Thread Sakari Ailus
Add V4L2_CID_DIGITAL_GAIN to control explicitly digital gain. We already have analogue gain control which the digital gain control complements. Typically higher quality images are obtained using analogue gain only as the digital gain does not add information to the image (rather it may remove it).

Re: [PATCH v4] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-06-08 Thread Sakari Ailus
Hi Mauro, On Thu, Jun 08, 2017 at 03:00:22PM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 7 Jun 2017 10:52:07 +0100 > Kieran Bingham escreveu: > > > From: Kieran Bingham > > > > Return NULL, if a null entity is parsed for it's v4l2_subdev > > > > Signed-off-by: Kieran Bingham > > Could yo

Re: [PATCH 01/11] [media] dvb-core/dvb_ca_en50221.c: Rename STATUSREG_??

2017-06-08 Thread Jasmin J.
Hello Mauro! > The idea behind patch 04/11 makes sense to me. I'll review it carefully > after having everything applied. Please don't do that now! The first series will then not be easily changed, because it changes the state machine. I will provide the first series and when it is applied the se

[PATCH] media/cec.h: use IS_REACHABLE instead of IS_ENABLED

2017-06-08 Thread Hans Verkuil
Fix messages like this: adv7842.c:(.text+0x2edadd): undefined reference to `cec_unregister_adapter' when CEC_CORE=m but the driver including media/cec.h is built-in. In that case the static inlines provided in media/cec.h should be used by that driver. Signed-off-by: Hans Verkuil --- diff --git

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-08 Thread Robin Murphy
On 08/06/17 15:35, Tomasz Figa wrote: > On Thu, Jun 8, 2017 at 10:22 PM, Robin Murphy wrote: >> On 07/06/17 10:47, Tomasz Figa wrote: >>> Hi Yong, >>> >>> +Robin, Joerg, IOMMU ML >>> >>> Please see my comments inline. >>> >>> On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > [snip] + +/

Re: [PATCH v4] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-06-08 Thread Mauro Carvalho Chehab
Em Wed, 7 Jun 2017 10:52:07 +0100 Kieran Bingham escreveu: > From: Kieran Bingham > > Return NULL, if a null entity is parsed for it's v4l2_subdev > > Signed-off-by: Kieran Bingham Could you please improve this patch description? I'm unsure if this is a bug fix, or some sort of feature...

[linuxtv-media:master 1719/1759] arch/arm/mach-davinci/pdata-quirks.c:87:13: warning: initialization discards 'const' qualifier from pointer target type

2017-06-08 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 703ecba4dbfb8de9cad7420021dfcbd11007de3b commit: 4a5f8ae50b66a40cd9cec8f72f5f64611504ddc1 [1719/1759] [media] davinci: vpif_capture: get subdevs from DT when available config: arm-davinci_all_defconfig (attached as .config) compiler: arm-linu

Re: [PATCH] [media] media-ioc-g-topology.rst: fix typos

2017-06-08 Thread Mauro Carvalho Chehab
Em Wed, 7 Jun 2017 18:33:02 +0900 Alexandre Courbot escreveu: > Fix what seems to be a few typos induced by copy/paste. > > Signed-off-by: Alexandre Courbot > --- > Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

adv7842.c:undefined reference to `cec_unregister_adapter'

2017-06-08 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b29794ec95c6856b316c2295904208bf11ffddd9 commit: 9177e51d1434076a91f9bfb693deae8b955d6d57 [media] cec: select CEC_CORE instead of depend on it date: 4 days ago config: i386-randconfig-b0-06090003 (attached

Re: [PATCH v8 02/34] [media] dt-bindings: Add bindings for i.MX media driver

2017-06-08 Thread Steve Longerbeam
On 06/08/2017 09:45 AM, Steve Longerbeam wrote: Hi Rob, Mark, Are there any remaining technical issues with this binding doc? At this point an Ack from you is the only thing holding up merge of the imx-media driver. Note that the Synopsys core in the i.MX6 is a differently configured Synop

[PATCH v2] [media] v4l2-subdev: check colorimetry in link validate

2017-06-08 Thread Helen Koike
colorspace, ycbcr_enc, quantization and xfer_func must match across the link. Check if they match in v4l2_subdev_link_validate_default unless they are set as _DEFAULT. Signed-off-by: Helen Koike --- Hi, As discussed previously, I added a warn message instead of returning error to give drivers

[PATCH] atomisp: use correct dialect to disable warnings

2017-06-08 Thread Mauro Carvalho Chehab
There's a Macro that checks if gcc supports a warning before disabling it. Use it, in order to avoid warnings when building with older gcc versions. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/i2c/Makefile| 6 -- drivers/staging/media/atomisp/i2c/imx/Makefi

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-08 Thread Sakari Ailus
Hi Tomasz and Alan, On Thu, Jun 08, 2017 at 11:55:18AM +0900, Tomasz Figa wrote: > Hi Alan, > > On Thu, Jun 8, 2017 at 2:45 AM, Alan Cox wrote: > >> > + struct ipu3_mmu *mmu = to_ipu3_mmu(dev); > >> > + dma_addr_t daddr = iommu_iova_to_phys(mmu->domain, dma_handle); > >> > + > >> > +

Re: [PATCH v8 02/34] [media] dt-bindings: Add bindings for i.MX media driver

2017-06-08 Thread Steve Longerbeam
Hi Rob, Mark, Are there any remaining technical issues with this binding doc? At this point an Ack from you is the only thing holding up merge of the imx-media driver. Thanks, Steve On 06/07/2017 11:33 AM, Steve Longerbeam wrote: Add bindings documentation for the i.MX media driver. Signed-o

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-08 Thread Sakari Ailus
Hi Tomasz, On Wed, Jun 07, 2017 at 05:35:13PM +0900, Tomasz Figa wrote: > Hi Yong, Tuukka, > > Continuing from yesterday. Please see comments inline. > > > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > [snip] > >> + ptr = ipu3_mmu_alloc_page_table(mmu_dom, false); > >> + if (!pt

Re: [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases"

2017-06-08 Thread Pavel Machek
On Thu 2017-06-08 11:01:37, Arnd Bergmann wrote: > This one got applied twice, causing a build error with clang: > > drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition of > '__mod_of__et8ek8_of_table_device_table' > > Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as

Re: [RFC PATCH] [media] v4l2-subdev: check colorimetry in link validate

2017-06-08 Thread Helen Koike
Hi On 2017-06-08 08:41 AM, Mauro Carvalho Chehab wrote: Em Tue, 6 Jun 2017 19:15:34 -0300 Helen Koike escreveu: Hi Sakari, Thanks for replying On 2017-05-31 03:31 AM, Sakari Ailus wrote: Hi Helen, On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote: colorspace, ycbcr_enc, quanti

[linuxtv-media:master 1719/1759] drivers/media//platform/davinci/vpif_capture.c:25:27: fatal error: media/v4l2-of.h: No such file or directory

2017-06-08 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 703ecba4dbfb8de9cad7420021dfcbd11007de3b commit: 4a5f8ae50b66a40cd9cec8f72f5f64611504ddc1 [1719/1759] [media] davinci: vpif_capture: get subdevs from DT when available config: arm-davinci_all_defconfig (attached as .config) compiler: arm-linu

Re: [PATCH RFC] v4l2-core: Use kvmalloc() for potentially big allocations

2017-06-08 Thread Mauro Carvalho Chehab
Em Wed, 31 May 2017 16:07:29 +0300 Sakari Ailus escreveu: > Hi Tomasz, > > On Wed, May 31, 2017 at 09:46:05PM +0900, Tomasz Figa wrote: > > On Wed, May 31, 2017 at 9:09 PM, Marek Szyprowski > > wrote: > > > Hi Tomasz, > > > > > > > > > On 2017-05-31 08:58, Tomasz Figa wrote: > > >> > > >> T

Re: Unknown symbol put_vaddr_frames when using media_build

2017-06-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Jun 2017 21:23:19 +1000 Vincent McIntyre escreveu: > On Wed, Jun 07, 2017 at 08:12:01PM -0300, Mauro Carvalho Chehab wrote: > > Em Wed, 7 Jun 2017 22:17:50 +0200 > > Matthias Schwarzott escreveu: > > > > > Am 07.06.2017 um 20:23 schrieb Mauro Carvalho Chehab: > > > > Em Tue, 9 May

[PATCH] [media] staging: css2400/Makefile: don't include makefiles

2017-06-08 Thread Mauro Carvalho Chehab
The atomisp css2400/Makefile includes a Makefile.common: include $(srctree)/$(src)/../Makefile.common Well, this file doesn't exist at the Kernel tree :-) So, don't include it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp2/css2400/Makefile | 2 --

Re: linux-next: Tree for Jun 8 (drivers/media/i2c/adv7604.c)

2017-06-08 Thread Randy Dunlap
On 06/08/17 00:50, Stephen Rothwell wrote: > Hi all, > > Changes since 20170607: > on x86_64: (randconfig) CONFIG_VIDEO_ADV7604=y # CONFIG_VIDEO_ADV7604_CEC is not set CONFIG_COMPILE_TEST=y drivers/built-in.o: In function `adv76xx_unregistered': adv7604.c:(.text+0x43ad91): undefined reference

[PATCH] [media] platform/Makefile: don't depend on arch to include dirs

2017-06-08 Thread Mauro Carvalho Chehab
Depending on arch configs to include dirs is evil, and makes harder to change drivers to work with COMPILE_TEST. Replace them by obj-y. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/

Re: [PATCH 2/3] media: ngene: Replace semaphore stream_mutex with mutex

2017-06-08 Thread Arnd Bergmann
On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: > The semaphore 'stream_mutex' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan > --- Looks correct, though I wonder whether it would be nicer to move the mutex

Re: [PATCH 3/3] media: ngene: Replace semaphore i2c_switch_mutex with mutex

2017-06-08 Thread Arnd Bergmann
On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: > The semaphore 'i2c_switch_mutex' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan This one is obviously correct, Reviewed-by: Arnd Bergmann

Re: [PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

2017-06-08 Thread Arnd Bergmann
On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: > The semaphore 'cmd_mutex' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan > --- > @@ -1283,7 +1283,7 @@ static int ngene_load_firm(struct ngene *dev) > > st

[PATCH 1/1] davinci: Switch from V4L2 OF to V4L2 fwnode

2017-06-08 Thread Sakari Ailus
The DaVinci VPIF capture driver V4L2 OF support was added after the V4L2 OF framework got removed. Switch VPIF capture driver to V4L2 fwnode. Signed-off-by: Sakari Ailus --- drivers/media/platform/davinci/Kconfig| 1 + drivers/media/platform/davinci/vpif_capture.c | 21 -

Re: [media_build] regression at 3a17e11 "update v4.10_sched_signal.patch"

2017-06-08 Thread Hans Verkuil
On 08/06/17 15:28, Vincent McIntyre wrote: > I managed to find the failing patch, not sure what the fix is. > > $ cd linux/ > $ patch -f -N -p1 -i ../backports/v4.10_sched_signal.patch > patching file drivers/media/dvb-core/dvb_ca_en50221.c > Hunk #1 succeeded at 35 (offset 1 line). > patching fil

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-08 Thread Tomasz Figa
On Thu, Jun 8, 2017 at 10:22 PM, Robin Murphy wrote: > On 07/06/17 10:47, Tomasz Figa wrote: >> Hi Yong, >> >> +Robin, Joerg, IOMMU ML >> >> Please see my comments inline. >> >> On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: [snip] >>> + >>> +/* End of things adapted from arch/arm/mm/dma-mapping

Re: [media_build] regression at 3a17e11 "update v4.10_sched_signal.patch"

2017-06-08 Thread Vincent McIntyre
> > $ cat drivers/media/rc/lirc_dev.c.rej > --- drivers/media/rc/lirc_dev.c > +++ drivers/media/rc/lirc_dev.c > @@ -18,7 +18,7 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include > -#include > +#include > #include > #include > #include > A bit of staring brings this to lig

Re: [PATCH 6/7] [media] soc_camera: rcar_vin: use proper name for the R-Car SoC

2017-06-08 Thread Wolfram Sang
> Btw, I'm seeing only patches 6 and 7 here at media ML (and patchwork). > As those are trivial changes, I'll just apply what I have. Perfect, thanks! signature.asc Description: PGP signature

Re: [media_build] regression at 3a17e11 "update v4.10_sched_signal.patch"

2017-06-08 Thread Vincent McIntyre
I managed to find the failing patch, not sure what the fix is. $ cd linux/ $ patch -f -N -p1 -i ../backports/v4.10_sched_signal.patch patching file drivers/media/dvb-core/dvb_ca_en50221.c Hunk #1 succeeded at 35 (offset 1 line). patching file drivers/media/dvb-core/dvb_demux.c Hunk #1 succeeded at

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-08 Thread Robin Murphy
On 07/06/17 10:47, Tomasz Figa wrote: > Hi Yong, > > +Robin, Joerg, IOMMU ML > > Please see my comments inline. > > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: >> IPU3 mmu based DMA mapping driver >> >> Signed-off-by: Yong Zhi >> --- >> drivers/media/pci/intel/ipu3/Kconfig | 6 + >

[media_build] regression at 3a17e11 "update v4.10_sched_signal.patch"

2017-06-08 Thread Vincent McIntyre
Hi I think the build was broken by this commit. 3a17e11 "update v4.10_sched_signal.patch" It's been fun learning about git bisect. $ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=16.04 DISTRIB_CODENAME=xenial DISTRIB_DESCRIPTION="Ubuntu 16.04.2 LTS" The build script falls over on t

Re: [PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases"

2017-06-08 Thread Sakari Ailus
On Thu, Jun 08, 2017 at 11:01:37AM +0200, Arnd Bergmann wrote: > This one got applied twice, causing a build error with clang: > > drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition of > '__mod_of__et8ek8_of_table_device_table' > > Fixes: 9ae05fd1e791 ("[media] et8ek8: Export O

Re: [RFC] V4L2 unified low-level decoder API

2017-06-08 Thread Tomasz Figa
On Thu, Jun 8, 2017 at 8:11 PM, ayaka wrote: > > > On 06/08/2017 06:56 PM, Hans Verkuil wrote: >> >> Hi Alexandre, >> >> On 08/06/17 11:59, Alexandre Courbot wrote: >>> >>> On Thu, Jun 8, 2017 at 5:56 PM, Pawel Osciak >>> wrote: Hi, On Fri, May 19, 2017 at 1:08 AM, Hugues FRUC

Re: [RFC PATCH] [media] v4l2-subdev: check colorimetry in link validate

2017-06-08 Thread Mauro Carvalho Chehab
Em Tue, 6 Jun 2017 19:15:34 -0300 Helen Koike escreveu: > Hi Sakari, > > > Thanks for replying > > On 2017-05-31 03:31 AM, Sakari Ailus wrote: > > Hi Helen, > > > > On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote: > >> colorspace, ycbcr_enc, quantization and xfer_func must match

Re: [PATCH 6/7] [media] soc_camera: rcar_vin: use proper name for the R-Car SoC

2017-06-08 Thread Mauro Carvalho Chehab
Em Mon, 29 May 2017 14:02:02 +0200 Wolfram Sang escreveu: > >Why "soc_camera:" in the subject? > > I used 'git log $file' and copied the most recent entry. Do I need to > resend? > No need to resend. I'll fix it when applying the patch. Btw, I'm seeing only patches 6 and 7 here at media

Re: Unknown symbol put_vaddr_frames when using media_build

2017-06-08 Thread Vincent McIntyre
On Wed, Jun 07, 2017 at 08:12:01PM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 7 Jun 2017 22:17:50 +0200 > Matthias Schwarzott escreveu: > > > Am 07.06.2017 um 20:23 schrieb Mauro Carvalho Chehab: > > > Em Tue, 9 May 2017 06:56:25 +0200 > > > Matthias Schwarzott escreveu: > > > > > >> Hi! >

Re: [RFC] V4L2 unified low-level decoder API

2017-06-08 Thread ayaka
On 06/08/2017 06:56 PM, Hans Verkuil wrote: Hi Alexandre, On 08/06/17 11:59, Alexandre Courbot wrote: On Thu, Jun 8, 2017 at 5:56 PM, Pawel Osciak wrote: Hi, On Fri, May 19, 2017 at 1:08 AM, Hugues FRUCHET wrote: Before merging this work Hans would like to have feedback from peers, in or

RE: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support

2017-06-08 Thread Ramesh Shanmugasundaram
> Em Thu, 8 Jun 2017 09:42:43 + > Ramesh Shanmugasundaram escreveu: > > > > Subject: Re: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support > > > > > > Em Wed, 31 May 2017 09:44:53 +0100 > > > Ramesh Shanmugasundaram > escreveu: > > > > > > > +++ b/Documentation/media/v4l-drivers/max21

Re: [RFC] V4L2 unified low-level decoder API

2017-06-08 Thread Hans Verkuil
Hi Alexandre, On 08/06/17 11:59, Alexandre Courbot wrote: > On Thu, Jun 8, 2017 at 5:56 PM, Pawel Osciak wrote: >> Hi, >> >> On Fri, May 19, 2017 at 1:08 AM, Hugues FRUCHET >> wrote: >>> Before merging this work Hans would like to have feedback from peers, in >>> order to be sure that this is i

Re: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support

2017-06-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Jun 2017 09:42:43 + Ramesh Shanmugasundaram escreveu: > > Subject: Re: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support > > > > Em Wed, 31 May 2017 09:44:53 +0100 > > Ramesh Shanmugasundaram escreveu: > > > > > +++ b/Documentation/media/v4l-drivers/max2175.rst > > > @@ -

[PATCH 2/3] media: ngene: Replace semaphore stream_mutex with mutex

2017-06-08 Thread Binoy Jayan
The semaphore 'stream_mutex' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/media/pci/ngene/ngene-core.c | 14 +++--- drivers/media/pci/ngene/ngene.h | 2 +- 2 files changed, 8 insertions(+)

[PATCH 3/3] media: ngene: Replace semaphore i2c_switch_mutex with mutex

2017-06-08 Thread Binoy Jayan
The semaphore 'i2c_switch_mutex' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/media/pci/ngene/ngene-core.c | 2 +- drivers/media/pci/ngene/ngene-i2c.c | 6 +++--- drivers/media/pci/ngene/ngene.h |

[PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

2017-06-08 Thread Binoy Jayan
The semaphore 'cmd_mutex' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/media/pci/ngene/ngene-core.c | 12 ++-- drivers/media/pci/ngene/ngene.h | 2 +- 2 files changed, 7 insertions(+), 7 d

[PATCH 0/3] ngene: Replace semaphores with mutexes

2017-06-08 Thread Binoy Jayan
These are a set of patches which removes semaphores from ngene. These are part of a bigger effort to eliminate unwanted semaphores from the linux kernel. Binoy Jayan (3): media: ngene: Replace semaphore cmd_mutex with mutex media: ngene: Replace semaphore stream_mutex with mutex media: ngene

Re: [RFC] V4L2 unified low-level decoder API

2017-06-08 Thread Alexandre Courbot
On Thu, Jun 8, 2017 at 5:56 PM, Pawel Osciak wrote: > Hi, > > On Fri, May 19, 2017 at 1:08 AM, Hugues FRUCHET wrote: >> Before merging this work Hans would like to have feedback from peers, in >> order to be sure that this is inline with other SoC vendors drivers >> expectations. >> >> Thomasz, P

RE: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support

2017-06-08 Thread Ramesh Shanmugasundaram
> Subject: Re: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support > > Em Wed, 31 May 2017 09:44:53 +0100 > Ramesh Shanmugasundaram escreveu: > > > +++ b/Documentation/media/v4l-drivers/max2175.rst > > @@ -0,0 +1,60 @@ > > +Maxim Integrated MAX2175 RF to bits tuner driver > > +==

[PATCH] [media] coda: ctx->codec is not NULL in coda_alloc_framebuffers

2017-06-08 Thread Philipp Zabel
This fixes a smatch warning: drivers/media/platform/coda/coda-bit.c:415 coda_alloc_framebuffers() error: we previously assumed 'ctx->codec' could be null (see line 396) coda_alloc_framebuffers() is called from coda_start_encoding() and __coda_start_decoding(). Both dereference ctx->codec

Re: [PATCH 8/8] omapdrm: hdmi4: hook up the HDMI CEC support

2017-06-08 Thread Tomi Valkeinen
On 08/06/17 10:34, Hans Verkuil wrote: >> Peter is about to send hotplug-interrupt-handling series, I think the >> HPD function work should be done on top of that, as otherwise it'll just >> conflict horribly. > > Has that been merged yet? And if so, what git repo/branch should I base > my next v

[PATCH] Revert "[media] et8ek8: Export OF device ID as module aliases"

2017-06-08 Thread Arnd Bergmann
This one got applied twice, causing a build error with clang: drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition of '__mod_of__et8ek8_of_table_device_table' Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases") Signed-off-by: Arnd Bergmann --- drivers/

Re: [RFC] V4L2 unified low-level decoder API

2017-06-08 Thread Pawel Osciak
Hi, On Fri, May 19, 2017 at 1:08 AM, Hugues FRUCHET wrote: > Before merging this work Hans would like to have feedback from peers, in > order to be sure that this is inline with other SoC vendors drivers > expectations. > > Thomasz, Pawel, could you give your view regarding ChromeOS and Rockchip

[PATCH v2 1/3] [media] coda: use correct offset for mvcol buffer

2017-06-08 Thread Philipp Zabel
From: Lucas Stach The mvcol buffer needs to be placed behind the chroma plane(s), so use the real offset including any required rounding. Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Signed-off-by: Philipp Zabel --- No changes since v1 [1]. [1] https://patchwork.linuxtv.org/patch/40

[PATCH v2 2/3] [media] coda: first step at error recovery

2017-06-08 Thread Philipp Zabel
From: Lucas Stach This implements a simple handler for the case where decode did not finish successfully. This might be helpful during normal streaming, but for now it only handles the case where the context would deadlock with userspace, i.e. userspace issued DEC_CMD_STOP and waits for EOS, but

[PATCH v2 3/3] [media] coda/imx-vdoa: always wait for job completion

2017-06-08 Thread Philipp Zabel
From: Lucas Stach As long as only one CODA context is running we get alternating device_run() and wait_for_completion() calls, but when more then one CODA context is active, other VDOA slots can be inserted between those calls for one context. Make sure to wait on job completion before running a

Re: [PATCH 0/7] Add block read/write to en50221 CAM functions

2017-06-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Jun 2017 09:31:25 +0200 "Jasmin J." escreveu: > Hello Mauro! > > > It should be, instead: > >From: Ralph Metzler > I thought it is enough to write him in the Signed-off-by as first. No, it isn't. It is possible to have a patch authored by someone that didn't sign. We don't us

Re: [PATCH 05/12] intel-ipu3: css: tables

2017-06-08 Thread Tomasz Figa
Hi Yong, On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > Coeff, config parameters etc const definitions for > IPU3 programming. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-tables.c | 9621 > > drivers/media/pci/intel/ipu3/ipu3-tables.h |

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-08 Thread Tomasz Figa
Hi Sakari, On Thu, Jun 8, 2017 at 6:59 AM, Sakari Ailus wrote: > Hi Tomasz, > > On Tue, Jun 06, 2017 at 07:13:19PM +0900, Tomasz Figa wrote: >> Hi Yong, Tuukka, >> >> +CC IOMMU ML and Joerg. (Technically you should resend this patch >> including them.) > > Thanks! > >> >> On Tue, Jun 6, 2017 at 5

Re: [PATCH 0/7] Add block read/write to en50221 CAM functions

2017-06-08 Thread Jasmin J.
Hello Mauro! > It should be, instead: >From: Ralph Metzler I thought it is enough to write him in the Signed-off-by as first. This From line is automatically generated by Git with Format Patch and then used by send. However I should change that and my mail program still accepting it? I will

Re: [PATCH 8/8] omapdrm: hdmi4: hook up the HDMI CEC support

2017-06-08 Thread Hans Verkuil
Hi Tomi, On 08/05/17 12:26, Tomi Valkeinen wrote: > On 06/05/17 14:58, Hans Verkuil wrote: > >> My assumption was that hdmi_display_disable() was called when the hotplug >> would go >> away. But I discovered that that isn't the case, or at least not when X is >> running. >> It seems that the ac

[GIT FIXES FOR v4.12] cec: fix race condition between poll and CEC_RECEIVE

2017-06-08 Thread Hans Verkuil
Hi Mauro, This bug fix should go to 4.12 (and has a CC to stable to get it in for 4.10 and 4.11 as well). It fixes a race condition that can cause an application to loop forever, which is how we (Cisco) discovered it. Regards, Hans The following changes since commit 47b586f66a9e78c9158