Re: [PATCH] videobuf2-core: add queue_busy/idle queue ops

2017-10-16 Thread Hans Verkuil
Hi Jacob, When going through my TODO list with pending patches I came across this one from a few weeks back. I noticed that your rga patch series didn't pick this up. Does that mean that the ROTATE control can be changed while streaming without requiring buffer size changes? If not, then you wil

Re: [GIT PULL FOR v4.15] Rockchip RGA driver

2017-10-16 Thread Hans Verkuil
Heiko, This driver was merged yesterday for 4.15, so you can go ahead and take the dts patches. Regards, Hans On 10/13/2017 01:22 PM, Hans Verkuil wrote: > On 10/13/17 13:20, Hans Verkuil wrote: >> Hi Mauro, >> >> Here is the new Rockchip RGA driver. > > Forgot to mention: Heiko will p

[PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

2017-10-16 Thread Krzysztof Hałasa
Without this fix, in 8-bit Y/Bayer mode, every other 8-byte group of pixels is lost. Not sure about possible side effects, though. Signed-off-by: Krzysztof Hałasa --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -340,7 +340,7 @@ static int csi_id

get Pinnacle Systems MovieBox (510-USB) to work

2017-10-16 Thread deim31
Hi, I'm trying to run Pinnacle Systems MovieBox (510-USB) on linux. lsusb gives me: ID 2304:0223 Pinnacle Systems, Inc. DazzleTV Sat BDA Device tried modify kernel like: https://www.linuxtv.org/pipermail/linux-dvb/2007-February/015779.html (there is note about 0223) My changes: $ diff /usr/src

[PATCH][MEDIA] i.MX6: Fix MIPI CSI-2 LP-11 check

2017-10-16 Thread Krzysztof Hałasa
Bitmask for the MIPI CSI-2 data PHY status doesn't seem to be correct. Fix it. Signed-off-by: Krzysztof Hałasa --- a/drivers/staging/media/imx/imx6-mipi-csi2.c +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c @@ -252,8 +252,8 @@ static int csi2_dphy_wait_stopstate(struct csi2_dev *csi2)

Re: [GIT PULL for v4.14-rc6] media fixes

2017-10-16 Thread Mauro Carvalho Chehab
Hi Linus, Em Mon, 16 Oct 2017 20:15:33 -0400 Linus Torvalds escreveu: > On Mon, Oct 16, 2017 at 4:31 PM, Mauro Carvalho Chehab > wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media > > media/v4.14-2 > > No such tag. > > Did you forget to push out? The latest

cron job: media_tree daily build: WARNINGS

2017-10-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Oct 17 05:00:16 CEST 2017 media-tree git hash:7571358dd22dc91dea560f0dde62ce23c033b6b6 media_build gi

Re: [GIT PULL for v4.14-rc6] media fixes

2017-10-16 Thread Linus Torvalds
On Mon, Oct 16, 2017 at 4:31 PM, Mauro Carvalho Chehab wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media > media/v4.14-2 No such tag. Did you forget to push out? The latest tag I see is v4.14-1. I do see the branch (v4l_for_linus) that contains the commit you menti

Re: [GIT PULL for 4.15] Atomisp cleanups

2017-10-16 Thread Mauro Carvalho Chehab
Em Sat, 14 Oct 2017 01:33:55 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Here's the usual set of atomisp cleanups. > > Please pull. > > > The following changes since commit 8382e556b1a2f30c4bf866f021b33577a64f9ebf: > > Simplify major/minor non-dynamic logic (2017-10-11 15:32:11 -0400) >

Re: [GIT PULL for 4.15] More sensor driver patches

2017-10-16 Thread Mauro Carvalho Chehab
Em Sat, 14 Oct 2017 01:23:45 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Here's the second set of sensor driver patches for 4.15. > > Please pull. > > > The following changes since commit 8382e556b1a2f30c4bf866f021b33577a64f9ebf: > > Simplify major/minor non-dynamic logic (2017-10-11 15:3

[PATCH] media: rga: make some functions static

2017-10-16 Thread Mauro Carvalho Chehab
drivers/media/platform/rockchip/rga/rga-hw.c:383:6: warning: no previous prototype for 'rga_cmd_set' [-Wmissing-prototypes] void rga_cmd_set(struct rga_ctx *ctx) ^~~ drivers/media/platform/rockchip/rga/rga.c:359:17: warning: no previous prototype for 'rga_fmt_find' [-Wmissing-proto

[PATCH] staging/atomisp: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: Alan Cox Cc: Daeseok Youn Cc: Arnd Bergmann Cc: li

[PATCH] media: input: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. One input_dev user hijacks the input_dev software autorepeat timer to perform its own repeat management. How

[PATCH] media: serial_ir: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Sean Young Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Signed-off-by: Kees Cook --- dr

[PATCH] media: tc358743: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Mats Randgaard Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Signed-off-by: Kees Cook ---

[PATCH] media: saa7134: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Mauro Carvalho Chehab Cc: Sakari Ailus Cc: Sean Young Cc: Geliang Tang Cc: Hans Verkuil Cc: linux-m

[PATCH] media: saa7146: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Signed-off-by: Kees Cook ---

[PATCH] media: dvb-core: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Mauro Carvalho Chehab Cc: devendra sharma Cc: linux-media@vger.kernel.org Signed-off-by: Kees Cook --

[PATCH] media: tvaudio: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Signed-off-by: Kees Cook --- drivers/media/i2c/

[PATCH] media/saa7146: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This requires adding a pointer to hold the timer's target file, as there won't be a way to pass this in the f

Re: [PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

2017-10-16 Thread Tobin C. Harding
On Mon, Oct 16, 2017 at 02:34:48PM +0200, Hans de Goede wrote: > The common-clk core expects clk consumers to always call enable/disable > in a balanced manner. The atomisp driver does not call gmin_flisclk_ctrl() > in a balanced manner, so add a clock_on bool and skip redundant calls. > > This fi

[GIT PULL for v4.14-rc6] media fixes

2017-10-16 Thread Mauro Carvalho Chehab
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media media/v4.14-2 For the following media core fixes: - cec: Respond to unregistered initiators, when applicable - dvb_frontend: only use kref after initialized and the following driver-specific f

Re: Exynos MFC issues on 4.14-rc4

2017-10-16 Thread Shuah Khan
On Mon, Oct 16, 2017 at 7:11 AM, Marek Szyprowski wrote: > Hi Marian, > > On 2017-10-12 02:49, Marian Mihailescu wrote: >> >> I've been testing 4.14-rc4 on Odroid-XU4, and here's a kernel >> complaint when running: >> >> gst-launch-1.0 filesrc location=bunny_trailer_1080p.mov ! parsebin ! >> v4l2v

Re: [PATCH v2 2/2] media: s5p-mfc: fix lockdep warning

2017-10-16 Thread Hans Verkuil
On 10/16/2017 05:16 PM, Shuah Khan wrote: > The driver mmap functions shouldn't take lock when calling vb2_mmap(). > Fix it to not take the lock. > > Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3 > and e752577ed7bf55c81e10343fced8b378cda2b63b > > The following lockdep warning

Re: [PATCH v2 1/2] media: exynos-gsc: fix lockdep warning

2017-10-16 Thread Hans Verkuil
On 10/16/2017 05:16 PM, Shuah Khan wrote: > The driver mmap functions shouldn't take lock when calling vb2_mmap(). > Fix it to not take the lock. > > Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3 > and e752577ed7bf55c81e10343fced8b378cda2b63b > > The following lockdep warning

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

2017-10-16 Thread Daniel Mack
Hi, On 28.08.2017 09:10, Todor Tomov wrote: > On 25.08.2017 17:10, Daniel Mack wrote: >> Could you explain how ISPIF, CSID and CSIPHY are related? >> >> I have a userspace test setup that works fine for USB webcams, but when >> operating on any of the video devices exposed by this driver, the >> l

Re: [PATCH resend] [media] uvcvideo: zero seq number when disabling stream

2017-10-16 Thread Laurent Pinchart
Hi Hans, (CC'ing Guennadi Liakhovetski) Thank you for the patch. On Friday, 15 September 2017 09:27:51 EEST Hans Yang wrote: > For bulk-based devices, when disabling the video stream, > in addition to issue CLEAR_FEATURE(HALT), it is better to set > alternate setting 0 as well or the sequnce num

Re: [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers

2017-10-16 Thread Shuah Khan
Hi Marek, On 10/16/2017 06:48 AM, Marek Szyprowski wrote: > Hi Shuah, > > On 2017-10-14 01:13, Shuah Khan wrote: >> Driver mmap functions shouldn't hold lock when calling vb2_mmap(). The >> vb2_mmap() function has its own lock that it uses to protect the critical >> section. >> >> Reference: comm

Re: [PATCH v3 1/2] media: i2c: OV5647: ensure clock lane in LP-11 state before streaming on

2017-10-16 Thread Sakari Ailus
On Mon, Oct 16, 2017 at 03:19:09PM +0100, Luis Oliveira wrote: > Hi all, > > Sorry for the delay and thank you for the fix. > I just checked the databook and the changes makes sense. > > cheers, > Luis > > On 16-Oct-17 13:23, Sakari Ailus wrote: > > Luis, > > > > Any comment on these? > > > >

Re: [PATCH v1] [media] uvcvideo: mark buffer error where overflow

2017-10-16 Thread Laurent Pinchart
Hi Baoyou, Thank you for the patch. On Thursday, 7 September 2017 05:59:48 EEST Baoyou Xie wrote: > Some cameras post inaccurate frame where next frame data overlap > it. this results in screen flicker, and it need to be prevented. > > So this patch marks the buffer error to discard the frame wh

Re: [PATCH v3 1/2] media: i2c: OV5647: ensure clock lane in LP-11 state before streaming on

2017-10-16 Thread Luis Oliveira
Hi all, Sorry for the delay and thank you for the fix. I just checked the databook and the changes makes sense. cheers, Luis On 16-Oct-17 13:23, Sakari Ailus wrote: > Luis, > > Any comment on these? > > On Sun, Oct 01, 2017 at 06:22:37PM +0800, Jacob Chen wrote: >> When I was supporting Rpi Ca

Re: [PATCH] [media] stk-webcam: Fix use after free on disconnect

2017-10-16 Thread Sakari Ailus
On Fri, Sep 22, 2017 at 04:48:41PM +0300, Dan Carpenter wrote: > We free the stk_camera device too early. It's allocate first in probe > and it should be freed last in stk_camera_disconnect(). > > Reported-by: Andrey Konovalov > Signed-off-by: Dan Carpenter > --- > Not tested but these bug repo

Re: Exynos MFC issues on 4.14-rc4

2017-10-16 Thread Marek Szyprowski
Hi Marian, On 2017-10-12 02:49, Marian Mihailescu wrote: I've been testing 4.14-rc4 on Odroid-XU4, and here's a kernel complaint when running: gst-launch-1.0 filesrc location=bunny_trailer_1080p.mov ! parsebin ! v4l2video4dec capture-io-mode=dmabuf ! v4l2video6convert output-io-mode=dmabuf-impo

Re: [PATCH v14 20/28] v4l: fwnode: Add a helper function to obtain device / integer references

2017-10-16 Thread Sakari Ailus
Hi Hans, On Tue, Oct 10, 2017 at 03:07:29PM +0200, Hans Verkuil wrote: > On 10/10/2017 01:27 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Oct 09, 2017 at 02:06:55PM +0200, Hans Verkuil wrote: > >> Hi Sakari, > >> > >> My reply here is also valid for v15. > >> > >> On 26/09/17 13:30, Sakar

Re: [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers

2017-10-16 Thread Marek Szyprowski
Hi Shuah, On 2017-10-14 01:13, Shuah Khan wrote: Driver mmap functions shouldn't hold lock when calling vb2_mmap(). The vb2_mmap() function has its own lock that it uses to protect the critical section. Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3 It would make sense to

[PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

2017-10-16 Thread Hans de Goede
The common-clk core expects clk consumers to always call enable/disable in a balanced manner. The atomisp driver does not call gmin_flisclk_ctrl() in a balanced manner, so add a clock_on bool and skip redundant calls. This fixes kernel oops like this one: [ 19.811613] gc0310_s_config S [ 19.8

Re: [PATCH v3 1/2] media: i2c: OV5647: ensure clock lane in LP-11 state before streaming on

2017-10-16 Thread Sakari Ailus
Luis, Any comment on these? On Sun, Oct 01, 2017 at 06:22:37PM +0800, Jacob Chen wrote: > When I was supporting Rpi Camera Module on the ASUS Tinker board, > I found this driver have some issues with rockchip's mipi-csi driver. > It didn't place clock lane in LP-11 state before performing > D-PHY

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-16 Thread Sakari Ailus
On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: > Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > > Hi Nicolas, > > > > On Tue, Oct 10, 2017 at 11:40:10AM -0400, Nicolas Dufresne wrote: > > > Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : > >

Re: [RFC PATCH 0/9] V4L2 Jobs API WIP

2017-10-16 Thread Hans Verkuil
Hi Alexandre, Thank you very much for working on this. Much appreciated! I only did a very high-level review of the patch series: there is not much point IMHO of doing a detailed review given the upcoming discussions in Prague. It's better to wait until we agree with the high-level API. Regardin

Re: [RFC PATCH 2/9] [media] v4l2-core: add core jobs API support

2017-10-16 Thread Hans Verkuil
On 09/28/2017 11:50 AM, Alexandre Courbot wrote: > Add core support code for jobs API. This manages the life cycle of jobs > and creation of a jobs queue, as well as the interface for job states. > > It also exposes the user-space jobs API. > > Signed-off-by: Alexandre Courbot > --- > drivers/m