On 12/19/2017 09:37 PM, Andy Shevchenko wrote:
> On Tue, 2017-12-19 at 14:00 +0200, Sakari Ailus wrote:
>> Cc Alan and Andy.
>>
>> On Sat, Dec 16, 2017 at 04:50:04PM +0100, Kristian Beilke wrote:
>>> Dear all,
>>>
>>> I am trying to get the cameras in a Lenovo IdeaPad Miix 320 (Atom
>>> x5-Z8350
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Dec 20 05:00:17 CET 2017
media-tree git hash:ae49432810c5cca2143afc1445edad6582c9f270
media_build
On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote:
> @@ -1147,10 +1145,8 @@ static int gc2235_probe(struct i2c_client *client)
> if (ret)
> gc2235_remove(client);
This error handling is probably wrong...
>
> - if (ACPI_HANDLE(>dev))
> - ret =
Hi, Mauro
> > +
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__
>
> Same comments as on other patches: use SPDX and dev_foo() for printing
> messages.
About printing messages pr_fmt, I also replied a comment to [PATCH v4 02/12]
[media] cxd2880-spi: Add support for CXD2880 SPI
Hi, Mauro.
> >
> > These functions monitor the driver and watch for task completion.
> > This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
>
> If I understand well, the goal here is to have thread that would be waking
> up from time to time, right? Just use the infrastructure
Hi, Mauro
> > + ret = tnr_dmd->io->read_regs(tnr_dmd->io,
> > +CXD2880_IO_TGT_SYS,
> > +0x10, data, 1);
> > + if (ret)
> > + return ret;
> > + if ((data[0] & 0x01) == 0x00)
> > + return -EBUSY;
>
> I don't
Hi, Mauro.
> > +
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__
>
> It would be better to use dev_foo() debug macros instead of
> pr_foo() ones.
I got comment for this previous version patch as below
My Dear,
How are you together with your family? I hope all is well. Considering
the fact, I did not know you in person or even have seen you before
but due to the true revelation that I should share this lucrative
opportunity with you, I have no choice other than to contact you. So,
kindly
This is the second time i am sending you this mail.
I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for
more details.
Regards.
Friedrich Mayrhofer
There is no need to keep a reference to PCI root bridge.
Signed-off-by: Andy Shevchenko
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_internal.h | 1 -
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8
2 files changed, 9
In case devm_clk_get() call fails the previously requested GPIOs are
left requested.
Fix this by moving GPIO request code after devm_clk_get() call.
Signed-off-by: Andy Shevchenko
---
.../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 4
There is no need to export function which is only used once in
the same module where it's defined.
Signed-off-by: Andy Shevchenko
---
drivers/staging/media/atomisp/include/linux/atomisp_gmin_platform.h | 1 -
The traditional pattern is to use DMI matching table and provide a
corresponding driver_data in it.
Convert driver to use DMI matching table.
Signed-off-by: Andy Shevchenko
---
.../platform/intel-mid/atomisp_gmin_platform.c | 109 +
1
Custom video format 'M101' is not supported in upstream and as a result
user will get ugly warning:
Unknown pixelformat 0x3130314d
[ cut here ]
WARNING: CPU: 3 PID: 1574 at drivers/media/v4l2-core/v4l2-ioctl.c:1291
v4l_enum_fmt+0xcf1/0x13a0 [videodev]
Signed-off-by:
MRD7 board has in particular
Base Board Information
Manufacturer: Intel Corp.
Product Name: TABLET
Version: MRD 7
Fix the DMI matching entry for it.
Signed-off-by: Andy Shevchenko
---
Driver fails to initialize due to insane settings in the
control init array.
Fix this by moving to sanity.
Signed-off-by: Andy Shevchenko
---
drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Since all drivers are solely requiring ACPI enumeration, there is no
need to additionally check for legacy platform data or ACPI handle.
Remove leftovers from the sensors and platform code.
Signed-off-by: Andy Shevchenko
---
GPIO framework checks for NULL pointer when gpiod_set_value() is called.
Signed-off-by: Andy Shevchenko
---
.../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
In a preparation of split PCI glue driver from core part, convert
the driver to use more generic struct device_driver.
Signed-off-by: Andy Shevchenko
---
.../staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c | 17 -
On Tue, 2017-12-19 at 14:00 +0200, Sakari Ailus wrote:
> Cc Alan and Andy.
>
> On Sat, Dec 16, 2017 at 04:50:04PM +0100, Kristian Beilke wrote:
> > Dear all,
> >
> > I am trying to get the cameras in a Lenovo IdeaPad Miix 320 (Atom
> > x5-Z8350 BayTrail) to work. The front camera is an ov2680.
On 12/19/2017 12:15 PM, Joe Perches wrote:
drivers/char/ipmi/ipmi_msghandler.c| 17 +++---
For ipmi:
Acked-by: Corey Minyard
Em Tue, 19 Dec 2017 19:17:12 +0200
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Tuesday, 19 December 2017 17:37:58 EET Mauro Carvalho Chehab wrote:
> > Em Tue, 19 Dec 2017 16:12:35 +0200 Sakari Ailus escreveu:
> > > On Tue, Dec 19, 2017 at 04:02:02PM +0200,
On Tue, 19 Dec 2017, Joe Perches wrote:
> drivers/gpu/drm/i915/i915_sysfs.c | 12 ++--
For i915,
Acked-by: Jani Nikula
--
Jani Nikula, Intel Open Source Technology Center
On 12/19/2017 03:42 AM, Philipp Zabel wrote:
Allow building this driver for other platforms under COMPILE_TEST.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Philipp Zabel
Acked-by: Steve Longerbeam
---
Hi Mauro,
Thanks for the patch.
> -Original Message-
> From: Mauro Carvalho Chehab [mailto:mche...@smtp.s-opensource.com]
> On Behalf Of Mauro Carvalho Chehab
> Sent: Tuesday, December 19, 2017 3:18 AM
> To: Linux Media Mailing List
> Cc: Mauro Carvalho
Joe Perches (4):
sysfs.h: Use octal permissions
treewide: Use DEVICE_ATTR_RW
treewide: Use DEVICE_ATTR_RO
treewide: Use DEVICE_ATTR_WO
arch/arm/mach-pxa/sharpsl_pm.c | 4 +-
arch/s390/kernel/smp.c | 2 +-
arch/s390/kernel/topology.c
Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible.
Done with perl script:
$ git grep -w --name-only DEVICE_ATTR | \
xargs perl -i -e 'local $/; while (<>) {
s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444\s*)\)?\s*,\s*\1_show\s*,\s*NULL\s*\)/DEVICE_ATTR_RO(\1)/g;
On 19/12/17 18:01, Tim Harvey wrote:
> On Tue, Dec 19, 2017 at 3:12 AM, Hans Verkuil wrote:
>> On 16/12/17 19:00, Tim Harvey wrote:
>>> +
>>> +static int tda1997x_fill_format(struct tda1997x_state *state,
>>> + struct v4l2_mbus_framefmt *format)
>>>
Hi Mauro,
On Tuesday, 19 December 2017 17:37:58 EET Mauro Carvalho Chehab wrote:
> Em Tue, 19 Dec 2017 16:12:35 +0200 Sakari Ailus escreveu:
> > On Tue, Dec 19, 2017 at 04:02:02PM +0200, Laurent Pinchart wrote:
> >> And furthermore using enum types in the uAPI is a bad idea as the enum
> >> size
On Tue, Dec 19, 2017 at 3:12 AM, Hans Verkuil wrote:
> On 16/12/17 19:00, Tim Harvey wrote:
>> +
>> +static int tda1997x_fill_format(struct tda1997x_state *state,
>> + struct v4l2_mbus_framefmt *format)
>> +{
>> + const struct v4l2_bt_timings
From: Colin Ian King
The current error exit path if ir_raw_encode_scancode fails is via the
label out_kfree which kfree's an uninitialized pointer txbuf. Fix this
by exiting via a new exit path that does not kfree txbuf. Also exit
via this new exit path for a failed
The CSS API uses a lot of nested anonymous structs defined in object
macros to assign default values to its data-structures. These have been
changed to use compound-literals and designated initializers to make
them more comprehensible and less fragile.
The compound-literals can also be used in
Hi,
It's almost good!
You have to fix these checkpatch Warning/Check:
WARNING: Block comments use a trailing */ on a separate line
#36: FILE: drivers/media/platform/sti/bdisp/bdisp-hw.c:383:
+ * needing any delays */
CHECK: Alignment should match open parenthesis
#38: FILE:
On Tue, Dec 19, 2017 at 12:31:46PM -0200, Fabio Estevam wrote:
> On Tue, Dec 19, 2017 at 11:43 AM, Sakari Ailus wrote:
>
> > Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 .
>
> This patch fixes .h files to use /* SPDX style comment, which is the
>
Hi Akinobu,
On Wed, Dec 20, 2017 at 12:39:51AM +0900, Akinobu Mita wrote:
> Hi Sakari,
>
> 2017-12-19 19:35 GMT+09:00 Sakari Ailus :
> > Hi Akinobu,
> >
> > On Thu, Dec 14, 2017 at 01:00:49AM +0900, Akinobu Mita wrote:
> >> This adds support VIDIOC_DBG_G/S_REGISTER ioctls.
>
On 19/12/17 16:39, Akinobu Mita wrote:
> Hi Sakari,
>
> 2017-12-19 19:35 GMT+09:00 Sakari Ailus :
>> Hi Akinobu,
>>
>> On Thu, Dec 14, 2017 at 01:00:49AM +0900, Akinobu Mita wrote:
>>> This adds support VIDIOC_DBG_G/S_REGISTER ioctls.
>>>
>>> There are many device control
Hi Pavel,
On Mon, Feb 06, 2017 at 10:37:48AM +0100, Pavel Machek wrote:
>
> Normally, link configuration can be determined at probe time... but
> Nokia N900 has two cameras, and can switch between them at runtime, so
> that mechanism is not suitable here.
>
> Add a hook that tells us link
Hi Sakari,
2017-12-19 19:35 GMT+09:00 Sakari Ailus :
> Hi Akinobu,
>
> On Thu, Dec 14, 2017 at 01:00:49AM +0900, Akinobu Mita wrote:
>> This adds support VIDIOC_DBG_G/S_REGISTER ioctls.
>>
>> There are many device control registers contained in the OV9650. So
>> this helps
Em Tue, 19 Dec 2017 16:12:35 +0200
Sakari Ailus escreveu:
> Hi Laurent,
>
> On Tue, Dec 19, 2017 at 04:02:02PM +0200, Laurent Pinchart wrote:
> > And furthermore using enum types in the uAPI is a bad idea as the enum size
> > is
> > architecture-dependent. That's
Em Tue, 19 Dec 2017 16:05:46 +0200
Laurent Pinchart escreveu:
> On Tuesday, 19 December 2017 16:02:02 EET Laurent Pinchart wrote:
> > On Tuesday, 19 December 2017 13:39:27 EET Sakari Ailus wrote:
> > > Hi Mauro,
> > >
> > > On Mon, Dec 18, 2017 at 05:53:56PM
Hi Mauro,
Here's the regular pile of atomisp cleanups and some fixes, too.
Please pull.
The following changes since commit 8ea636dcecfa7b05d60309a50beabc5317a845bf:
media: ir-spi: add SPDX identifier (2017-12-18 15:22:50 -0500)
are available in the git repository at:
On Tue, Dec 19, 2017 at 11:43 AM, Sakari Ailus wrote:
> Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 .
This patch fixes .h files to use /* SPDX style comment, which is the
recommendation.
.c files should use // SPDX style.
Hi Mauro,
This set removes the as3645a V4L2 LED flash driver. The LED flash class
driver offering V4L2 API already exists, and should be used instead.
Please pull.
The following changes since commit 8ea636dcecfa7b05d60309a50beabc5317a845bf:
media: ir-spi: add SPDX identifier (2017-12-18
Hi Laurent,
On Tue, Dec 19, 2017 at 04:02:02PM +0200, Laurent Pinchart wrote:
> And furthermore using enum types in the uAPI is a bad idea as the enum size
> is
> architecture-dependent. That's why we use integer types in structures used as
> ioctl arguments.
I guess we have an argeement on
On Tuesday, 19 December 2017 16:02:02 EET Laurent Pinchart wrote:
> On Tuesday, 19 December 2017 13:39:27 EET Sakari Ailus wrote:
> > Hi Mauro,
> >
> > On Mon, Dec 18, 2017 at 05:53:56PM -0200, Mauro Carvalho Chehab wrote:
> > > The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask,
> > > but
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: a5791b188fb25ff731d01d1c463b01a99c58f930
commit: d60ea519eb2fbee045ca18a26bd37d5949ac4f87 [5319/5462] Merge
remote-tracking branch 'v4l-dvb/master'
config: xtensa-allmodconfig (attached as .config)
On Tuesday, 19 December 2017 13:39:27 EET Sakari Ailus wrote:
> Hi Mauro,
>
> On Mon, Dec 18, 2017 at 05:53:56PM -0200, Mauro Carvalho Chehab wrote:
> > The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask,
> > but without using Kernel's modern standards. Also,
> > documentation looks
On 2017/12/19 18:43, Fabien DESSENNE wrote:
Hi,
On 16/12/17 12:54, Jia-Ju Bai wrote:
The driver may sleep under a spinlock.
The function call path is:
bdisp_device_run (acquire the spinlock)
bdisp_hw_reset
msleep --> may sleep
To fix it, readl_poll_timeout_atomic is used to
The driver may sleep under a spinlock.
The function call path is:
bdisp_device_run (acquire the spinlock)
bdisp_hw_reset
msleep --> may sleep
To fix it, readl_poll_timeout_atomic is used to replace msleep.
This bug is found by my static analysis tool(DSAC) and
checked by my code review.
Hi Sakari,
On Tuesday, 19 December 2017 15:28:55 EET Sakari Ailus wrote:
> On Tue, Dec 19, 2017 at 03:07:41PM +0200, Laurent Pinchart wrote:
> > On Tuesday, 19 December 2017 13:57:42 EET jacopo mondi wrote:
[snip]
> >> Ok, actually parse_dt() and parse_platform_data() behaves differently.
> >>
On Tue, Dec 19, 2017 at 11:19:06AM -0200, Fabio Estevam wrote:
> Hi Sakari,
>
> On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus wrote:
>
> > I guess it depends on who do you ask and when. Looking at what has been
> > recently merged to media tree master, the latter is
Heippa!
On Tue, Dec 19, 2017 at 03:07:41PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> (CC'ing Sakari)
>
> On Tuesday, 19 December 2017 13:57:42 EET jacopo mondi wrote:
> > On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote:
> > > Hi Jacopo,
> > >
> > > Thank you for the
Hi Sakari,
On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus wrote:
> I guess it depends on who do you ask and when. Looking at what has been
> recently merged to media tree master, the latter is preferred.
Just did 'git grep SPDX drivers/media'
and it consistently shows //
Hi Neil,
On Tuesday, 19 December 2017 11:00:28 EET Neil Armstrong wrote:
> On 17/12/2017 01:17, Laurent Pinchart wrote:
> > Color keying is the action of replacing pixels matching a given color
> > (or range of colors) with transparent pixels in an overlay when
> > performing blitting. Depending
On Tue, Dec 19, 2017 at 10:50:44AM -0200, Fabio Estevam wrote:
> Hi Sakari,
>
> On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus wrote:
> > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote:
> >> The ov7740 (color) image sensor is a high performance VGA CMOS
> >>
Hi Jacopo,
(CC'ing Sakari)
On Tuesday, 19 December 2017 13:57:42 EET jacopo mondi wrote:
> On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote:
> > Hi Jacopo,
> >
> > Thank you for the patch.
> >
> > [snip]
> >
> >> +static int ceu_sensor_bound(struct v4l2_async_notifier
Em Sun, 17 Dec 2017 16:28:44 -0800
Joe Perches escreveu:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
>
Em Sun, 17 Dec 2017 19:47:25 +0100
"Maciej S. Szmigiero" escreveu:
> This patch adds support for analog part of Medion 95700 in the cxusb
> driver.
>
> What works:
> * Video capture at various sizes with sequential fields,
> * Input switching (TV Tuner, Composite,
Hi Sakari,
On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus wrote:
> On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote:
>> The ov7740 (color) image sensor is a high performance VGA CMOS
>> image snesor, which supports for output formats: RAW RGB and YUV
>> and image
On 19/12/2017 12:17, Philipp Zabel wrote:
> Hi Neil,
>
> On Tue, 2017-11-21 at 10:50 +0100, Neil Armstrong wrote:
>> Hi,
>>
>> I'm trying to make the coda960 h.264 encoder work on an i.MX6q SoC with
>> Linux 4.14 and the 3.1.1 firmware.
>>
>> # dmesg | grep coda
>> [4.846574] coda
Em Sun, 17 Dec 2017 14:50:37 +0100
Ralph Metzler escreveu:
> Athanasios Oikonomou writes:
> > A new property DTV_SCRAMBLING_SEQUENCE_INDEX introduced to control
> > the gold sequence that several demods support.
> >
> > Also the DVB API was increased in order userspace
On Sat, Dec 02, 2017 at 10:12:01PM +, Jeremy Sowden wrote:
> Removing zero-valued struct-members left a number of the default
> struct-values empty. These values have now been removed.
>
> Signed-off-by: Jeremy Sowden
This one should be squashed as well.
--
Sakari
Hi Jeremy,
On Sat, Dec 02, 2017 at 10:11:59PM +, Jeremy Sowden wrote:
> The CSS API uses a lot of nested anonymous structs defined in object
> macros to assign default values to its data-structures. These have been
> changed to use compound-literals and designated initializers to make
> them
Cc Alan and Andy.
On Sat, Dec 16, 2017 at 04:50:04PM +0100, Kristian Beilke wrote:
> Dear all,
>
> I am trying to get the cameras in a Lenovo IdeaPad Miix 320 (Atom
> x5-Z8350 BayTrail) to work. The front camera is an ov2680. With kernel
> 4.14.4 and 4.15rc3 I see the following dmesg output:
>
Hi Laurent,
a few more details on subdevice management
On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> [snip]
>
> > +static int ceu_sensor_bound(struct v4l2_async_notifier *notifier,
> > + struct v4l2_subdev
On Tue, Dec 19, 2017 at 09:03:55AM -0200, Mauro Carvalho Chehab wrote:
> [PATCH] media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro
>
> The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define
> 3 functions that have the same arguments. The code of those
> functions is simple enough to
Hi Sakari,
> -Original Message-
> From: Sakari Ailus [mailto:sakari.ai...@iki.fi]
> Sent: 2017年12月19日 17:23
> To: Wenyou Yang - A41535
> Cc: Mauro Carvalho Chehab ; Rob Herring
> ; Mark Rutland
Hi Yong,
On Thu, Jul 27, 2017 at 01:01:36PM +0800, Yong Deng wrote:
> Add binding documentation for Allwinner V3s CSI.
>
> Signed-off-by: Yong Deng
DT bindings should precede the driver.
> ---
> .../devicetree/bindings/media/sun6i-csi.txt| 49
>
Tim,
On Tue, Dec 19, 2017 at 12:12 PM, Hans Verkuil wrote:
> On 16/12/17 19:00, Tim Harvey wrote:
>> Add support for the TDA1997x HDMI receivers.
>>
>> Cc: Hans Verkuil
>> Signed-off-by: Tim Harvey
>> --- /dev/null
>> +++
On Tue, 2017-12-19 at 09:18 -0200, Mauro Carvalho Chehab wrote:
> There is a mess with media bus flags: there are two sets of
> flags, one used by parallel and ITU-R BT.656 outputs,
> and another one for CSI2.
>
> Depending on the type, the same bit has different meanings.
>
> That's very
On Thu, Jul 27, 2017 at 01:01:37PM +0800, Yong Deng wrote:
> Signed-off-by: Yong Deng
> ---
> MAINTAINERS | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9826a91..b91fa27 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
>
On Tue, 2017-12-19 at 12:42 +0100, Philipp Zabel wrote:
> Allow building this driver for other platforms under COMPILE_TEST.
>
> Suggested-by: Mauro Carvalho Chehab
> Signed-off-by: Philipp Zabel
> ---
> drivers/staging/media/imx/Kconfig | 3 ++-
As warned by smatch:
drivers/media/i2c/s5c73m3/s5c73m3-core.c:268 s5c73m3_check_status()
error: uninitialized symbol 'status'.
if s5c73m3_check_status() is called too late, time_is_after_jiffies(end)
will return 0, causing the while to abort before reading status.
The current code will
Allow building this driver for other platforms under COMPILE_TEST.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Hi Mauro,
On Mon, Dec 18, 2017 at 05:53:56PM -0200, Mauro Carvalho Chehab wrote:
> The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask,
> but without using Kernel's modern standards. Also,
> documentation looks akward.
>
> So, convert them into an enum with valid bits, adding
> the
There are several macros that aren't documented using kernel-docs
markups.
Document them.
While here, add cross-references to structs on this file.
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define
3 functions that have the same arguments. The code of those
functions is simple enough to just declare them, de-obfuscating
the code.
While here, replace BUG_ON() by WARN_ON() as there's no reason
why to panic the Kernel if this fails.
There is a mess with media bus flags: there are two sets of
flags, one used by parallel and ITU-R BT.656 outputs,
and another one for CSI2.
Depending on the type, the same bit has different meanings.
That's very confusing, and counter-intuitive. So, split them
into two sets of flags, inside an
Right now, those are documented together with the subdev struct,
instead of together with the definitions.
Convert the definitions to an enum, use BIT() macros and document
it at its right place.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h |
The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask,
but without using Kernel's modern standards. Also,
documentation looks akward.
So, convert them into an enum with valid bits, adding
the correspoinding kernel-doc documentation for it.
In order to avoid possible conflicts, rename them
This series contain the patches of a /17 and a /24 series
of documentation that required non-trivial changes.
-
v2:
- added acks on patch 3/8
- added a missing fixup on patch 5/8, for staging/media/imx
- on patch 6/8, use pad=0 when WARN_ON() if pad is out of range
Mauro Carvalho Chehab
There are several undocumented v4l2-subdev functions that are
part of kAPI. Document them.
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 69 +
1
Hi Neil,
On Tue, 2017-11-21 at 10:50 +0100, Neil Armstrong wrote:
> Hi,
>
> I'm trying to make the coda960 h.264 encoder work on an i.MX6q SoC with Linux
> 4.14 and the 3.1.1 firmware.
>
> # dmesg | grep coda
> [4.846574] coda 204.vpu: Direct firmware load for vpu_fw_imx6q.bin
>
Now that kernel-doc handles nested unions, better document the
match union at struct v4l2_async_subdev.
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-async.h | 25 +
1 file
The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
match criteria requires just a device name.
So, it doesn't make sense to enclose those into structs,
as the criteria can go directly into the union.
That makes
On 16/12/17 19:00, Tim Harvey wrote:
> Add support for the TDA1997x HDMI receivers.
>
> Cc: Hans Verkuil
> Signed-off-by: Tim Harvey
> ---
> v5:
> - uppercase string constants
> - use v4l2_hdmi_rx_coloriemtry to fill format
> - fix
Em Tue, 19 Dec 2017 10:30:15 +0100
Philipp Zabel escreveu:
> Hi Mauro,
>
> On Mon, 2017-12-18 at 17:53 -0200, Mauro Carvalho Chehab wrote:
> > There is a mess with media bus flags: there are two sets of
> > flags, one used by parallel and ITU-R BT.656 outputs,
> > and
Em Tue, 19 Dec 2017 10:24:51 +0200
Sakari Ailus escreveu:
> On Mon, Dec 18, 2017 at 05:27:04PM -0200, Mauro Carvalho Chehab wrote:
> > Em Mon, 9 Oct 2017 23:23:56 +0300
> > Sakari Ailus escreveu:
> >
> > > Hi Mauro,
> > >
> > > On Mon, Oct 09, 2017
On Sun, Dec 10, 2017 at 11:03:29PM +0530, Pravin Shedge wrote:
> On Thu, Dec 7, 2017 at 7:05 PM, Sakari Ailus wrote:
> > Hi Pravin,
> >
> > On Wed, Dec 06, 2017 at 10:22:02PM +0530, Pravin Shedge wrote:
> >> These duplicate includes have been found with
Hi,
On 16/12/17 12:54, Jia-Ju Bai wrote:
> The driver may sleep under a spinlock.
> The function call path is:
> bdisp_device_run (acquire the spinlock)
>bdisp_hw_reset
> msleep --> may sleep
>
> To fix it, readl_poll_timeout_atomic is used to replace msleep.
>
> This bug is found by my
On 04/12/17 15:32, Hans Verkuil wrote:
The omap4 CEC hardware cannot tell a Nack from a Low Drive from an
Arbitration Lost error, so just report a Nack, which is almost
certainly the reason for the error anyway.
This also simplifies the implementation. The only three interrupts
that need to be
On Mon, Nov 13, 2017 at 3:30 PM, Yong Deng wrote:
> Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface
> and CSI1 is used for parallel interface. This is not documented in
> datasheet but by testing and guess.
>
> This patch implement a v4l2 framework
Hi Akinobu,
On Thu, Dec 14, 2017 at 01:00:49AM +0900, Akinobu Mita wrote:
> This adds support VIDIOC_DBG_G/S_REGISTER ioctls.
>
> There are many device control registers contained in the OV9650. So
> this helps debugging the lower level issues by getting and setting the
> registers.
>
> Cc:
Thanks Sakari,
I'll push a patchset based on this discussion.
Best regards,
Hugues.
On 12/19/2017 11:08 AM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Mon, Dec 18, 2017 at 10:24:40AM +, Hugues FRUCHET wrote:
>> Hi Sakari,
>>
>> On 12/13/2017 08:47 PM, Sakari Ailus wrote:
>>> Hi Hugues,
>>>
Hello Mauro,
does this patch look ok to you?
Thanks,
Fab
> Subject: [PATCH v2 2/4] dt-bindings: media: rcar_vin: add device tree support
> for r8a774[35]
>
> Add compatible strings for r8a7743 and r8a7745. No driver change
> is needed as "renesas,rcar-gen2-vin" will activate the right code.
>
Hi Hugues,
On Mon, Dec 18, 2017 at 10:24:40AM +, Hugues FRUCHET wrote:
> Hi Sakari,
>
> On 12/13/2017 08:47 PM, Sakari Ailus wrote:
> > Hi Hugues,
> >
> > Hugues FRUCHET wrote:
> >> Hi Sakari,
> >>
> >> On 12/07/2017 02:59 PM, Sakari Ailus wrote:
> >>> Hi Hugues,
> >>>
> >>> On Thu, Dec 07,
Em Tue, 19 Dec 2017 09:01:41 +
Fabien DESSENNE escreveu:
> On 16/12/17 15:14, Mauro Carvalho Chehab wrote:
> > Em Sat, 16 Dec 2017 19:53:55 +0800
> > Jia-Ju Bai escreveu:
> >
> >> Hi,
> >>
> >> On 2017/12/15 22:51, Fabien DESSENNE wrote:
>
Hi Mauro,
On Mon, 2017-12-18 at 17:53 -0200, Mauro Carvalho Chehab wrote:
> There is a mess with media bus flags: there are two sets of
> flags, one used by parallel and ITU-R BT.656 outputs,
> and another one for CSI2.
>
> Depending on the type, the same bit has different meanings.
>
> That's
On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote:
> The ov7740 (color) image sensor is a high performance VGA CMOS
> image snesor, which supports for output formats: RAW RGB and YUV
> and image sizes: VGA, and QVGA, CIF and any size smaller.
>
> Signed-off-by: Songjun Wu
On Mon, 2017-12-18 at 17:53 -0200, Mauro Carvalho Chehab wrote:
> The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
> struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
> match criteria requires just a device name.
>
> So, it doesn't make sense to enclose those
1 - 100 of 117 matches
Mail list logo