cron job: media_tree daily build: ERRORS

2018-01-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Jan 22 05:00:19 CET 2018 media-tree git hash:e3ee691dbf24096ea51b3200946b11d68ce75361 media_build

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread Laurent Pinchart
Hi Hans, On Friday, 19 January 2018 14:25:39 EET Hans Verkuil wrote: > On 01/19/18 13:20, Laurent Pinchart wrote: > > On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote: > >> On 01/16/18 22:44, Jacopo Mondi wrote: > >>> Add driver for Renesas Capture Engine Unit (CEU). > >>> > >>> The

Re: atomisp and g/s_parm

2018-01-21 Thread Sakari Ailus
Hi Hans, On Sun, Jan 21, 2018 at 11:46:46AM +0100, Hans Verkuil wrote: > Hi Sakari, > > I looked a bit closer at how atomisp uses g/s_parm. They abuse the > capturemode field > to select video/preview/still modes on the sensor, which actually changes the > list > of supported resolutions. > >

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-21 Thread Randy Dunlap
On 01/21/2018 09:54 AM, jacopo mondi wrote: > Hi Randy, >thanks for noticing, > > On Fri, Jan 19, 2018 at 02:12:19PM -0800, Randy Dunlap wrote: >> On 01/16/2018 01:44 PM, Jacopo Mondi wrote: >>> Hello, >>>new version of CEU after Hans' review. >>> >>> Added his Acked-by to most patches

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-21 Thread jacopo mondi
Hi Randy, thanks for noticing, On Fri, Jan 19, 2018 at 02:12:19PM -0800, Randy Dunlap wrote: > On 01/16/2018 01:44 PM, Jacopo Mondi wrote: > > Hello, > >new version of CEU after Hans' review. > > > > Added his Acked-by to most patches and closed review comments. > > Running

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-21 Thread jacopo mondi
Hi Hans, On Fri, Jan 19, 2018 at 12:26:09PM +0100, Hans Verkuil wrote: > Hi Jacopo, > > On 01/16/18 22:44, Jacopo Mondi wrote: > > Hello, > >new version of CEU after Hans' review. > > > > Added his Acked-by to most patches and closed review comments. > > Running v4l2-compliance, I noticed a

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread jacopo mondi
Hi Hans, On Sun, Jan 21, 2018 at 11:23:12AM +0100, Hans Verkuil wrote: > On 21/01/18 11:21, Hans Verkuil wrote: > > On 21/01/18 10:53, jacopo mondi wrote: > >> Hi Hans, > >> > >> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: > >>> static int ov7670_g_parm(struct v4l2_subdev *sd,

Re: [PATCH v3 0/3] media: ov9650: support device tree probing

2018-01-21 Thread jacopo mondi
Hello Akinobu, On Mon, Jan 22, 2018 at 12:14:13AM +0900, Akinobu Mita wrote: > This patchset adds device tree probing for ov9650 driver. This contains > an actual driver change and a newly added binding documentation part. > > * Changelog v3 > - Add Reviewed-by: tags > - Add MAINTAINERS entry > >

[PATCH v3 3/3] media: ov9650: add device tree binding

2018-01-21 Thread Akinobu Mita
Now the ov9650 driver supports device tree probing. So this adds a device tree binding documentation. Cc: Sylwester Nawrocki Cc: Jacopo Mondi Cc: H. Nikolaus Schaller Cc: Hugues Fruchet Cc: Sakari Ailus

[PATCH v3 0/3] media: ov9650: support device tree probing

2018-01-21 Thread Akinobu Mita
This patchset adds device tree probing for ov9650 driver. This contains an actual driver change and a newly added binding documentation part. * Changelog v3 - Add Reviewed-by: tags - Add MAINTAINERS entry * Changelog v2 - Split binding documentation, suggested by Rob Herring and Jacopo Mondi -

[PATCH v3 1/3] media: ov9650: support device tree probing

2018-01-21 Thread Akinobu Mita
The ov9650 driver currently only supports legacy platform data probe. This change adds device tree probing. There has been an attempt to add device tree support for ov9650 driver by Hugues Fruchet as a part of the patchset that adds support of OV9655 camera

[PATCH v3 2/3] media: MAINTAINERS: add entry for ov9650 driver

2018-01-21 Thread Akinobu Mita
This adds an entry to the MAINTAINERS file for ov9650 driver. The following persons are added in this entry. * Sakari as a person who looks after media sensor driver patches * Sylwester as a module author * Myself as a person who has the hardware and can test the patches Cc: Sylwester Nawrocki

atomisp and g/s_parm

2018-01-21 Thread Hans Verkuil
Hi Sakari, I looked a bit closer at how atomisp uses g/s_parm. They abuse the capturemode field to select video/preview/still modes on the sensor, which actually changes the list of supported resolutions. The following files use this: i2c/atomisp-gc0310.c i2c/atomisp-gc2235.c

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread Hans Verkuil
On 21/01/18 11:21, Hans Verkuil wrote: > On 21/01/18 10:53, jacopo mondi wrote: >> Hi Hans, >> >> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: >>> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm >>> *parms) >>> { >>> struct v4l2_captureparm *cp =

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread Hans Verkuil
On 21/01/18 10:53, jacopo mondi wrote: > Hi Hans, > > On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: >> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm >> *parms) >> { >> struct v4l2_captureparm *cp = >parm.capture; >> struct ov7670_info

Re: [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-21 Thread Hans Verkuil
On 21/01/18 10:31, jacopo mondi wrote: > Hello Hans, Laurent, Sakari, > > On Fri, Jan 19, 2018 at 02:23:21PM +0200, Laurent Pinchart wrote: >> Hello, >> >> On Friday, 19 January 2018 13:19:18 EET Sakari Ailus wrote: >>> On Fri, Jan 19, 2018 at 11:47:33AM +0100, Hans Verkuil wrote: On

Re: [PATCH v3 2/2] v4l2: i2c: ov7670: Implement OF mbus configuration

2018-01-21 Thread jacopo mondi
Hi Sakari, On Fri, Jan 19, 2018 at 12:26:48AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Fri, Jan 12, 2018 at 06:56:48PM +0100, Jacopo Mondi wrote: [snip] > > +static int ov7670_parse_dt(struct device *dev, > > + struct ov7670_info *info) > > +{ > > + struct

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-21 Thread jacopo mondi
Hi Hans, On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: > Some more comments: > [snip] > > +/* --- CEU Videobuf2 operations --- */ > > + > > +static void ceu_update_plane_sizes(struct v4l2_plane_pix_format *plane, > > + unsigned int bpl, unsigned int

Re: [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-21 Thread jacopo mondi
Hello Hans, Laurent, Sakari, On Fri, Jan 19, 2018 at 02:23:21PM +0200, Laurent Pinchart wrote: > Hello, > > On Friday, 19 January 2018 13:19:18 EET Sakari Ailus wrote: > > On Fri, Jan 19, 2018 at 11:47:33AM +0100, Hans Verkuil wrote: > > > On 01/19/18 11:24, Hans Verkuil wrote: > > >> On 01/16/18