Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
On 22/01/18 13:00, Lars-Peter Clausen wrote: > On 01/22/2018 01:50 PM, Kieran Bingham wrote: >> The ADV7511 has four 256-byte maps that can be accessed via the main I²C >> ports. Each map has it own I²C address and acts as a standard slave >> device on the I²C bus. >> >> Allow a device tree node to

Re: [Patch v6 12/12] Documention: v4l: Documentation for HEVC CIDs

2018-01-22 Thread Smitha T Murthy
On Mon, 2018-01-22 at 13:15 +0100, Hans Verkuil wrote: > On 08/12/17 10:08, Smitha T Murthy wrote: > > Added V4l2 controls for HEVC encoder > > > > Signed-off-by: Smitha T Murthy > > --- > > Documentation/media/uapi/v4l/extended-controls.rst | 395 > > + > > 1 file changed,

Re: [Patch v6 00/12] Add MFC v10.10 support

2018-01-22 Thread Smitha T Murthy
On Mon, 2018-01-22 at 13:18 +0100, Hans Verkuil wrote: > Hi Smitha, > > Thank you for this v6 series! > > You can add my: > > Acked-by: Hans Verkuil > > to patches 1-9 and 11. See my review for patches 10 and 12. The comments > are minor, so I hope I can Ack v7 once it's posted and this can be

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2018-01-22 Thread Smitha T Murthy
On Mon, 2018-01-22 at 12:08 +0100, Hans Verkuil wrote: > On 08/12/17 10:08, Smitha T Murthy wrote: > > Add v4l2 controls for HEVC encoder > > > > Signed-off-by: Smitha T Murthy > > Reviewed-by: Andrzej Hajda > > --- > > drivers/media/v4l2-core/v4l2-ctrls.c | 118 > > +++

cron job: media_tree daily build: ERRORS

2018-01-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jan 23 05:00:16 CET 2018 media-tree git hash:e3ee691dbf24096ea51b3200946b11d68ce75361 media_build git

[PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Andy Yeh
Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh --- - v2->v3 -- Update the streaming function to remove SW_STANDBY in the beginning. -- Adjust the delay time from 1ms to 12ms b

[PATCH v3 1/1] imx258: Fix sparse warnings

2018-01-22 Thread Sakari Ailus
Fix a few sparse warnings related to conversion between CPU and big endian. Also simplify the code in the process. Signed-off-by: Sakari Ailus --- since v2: - Count loop downwards, not up. drivers/media/i2c/imx258.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-)

Re: [PATCH v2 1/1] imx258: Fix sparse warnings

2018-01-22 Thread Sakari Ailus
Hi Andy, On Mon, Jan 22, 2018 at 03:19:00PM +, Yeh, Andy wrote: > Hi Sakari, > > I made a minor fix. I2C write function works after the change. Please kindly > review soon then I would submit v5. > > *buf++ = reg >> 8; > *buf++ = reg & 0xff; > > - for (i = len - 1; i >= 0

Re: [PATCH] [media] s3c-camif: array underflow in __camif_subdev_try_format()

2018-01-22 Thread Sylwester Nawrocki
On 01/22/2018 11:37 AM, Dan Carpenter wrote: > The while loop is a post op, "while (i-- >= 0)" so the last iteration > will read camif_mbus_formats[-1] and then the loop will exit with "i" > set to -2 and so we do: "mf->code = camif_mbus_formats[-2];". > > I've changed it to a pre-op, I've added a

Darlehen

2018-01-22 Thread defina
Benötigen Sie Privat- oder Geschäftskredite ohne Stress und schnelle Zustimmung? Wenn ja, kontaktieren Sie uns bitte alexgr...@gmail.com

[PATCH v2 3/5] media: dvb-frontends/stv0910: report FEC 1/4 and 1/3 in get_frontend()

2018-01-22 Thread Daniel Scheller
From: Daniel Scheller The first two missing FECs in the modcod2fec fe_code_rate table were 1/4 and 1/3. Add them as they're now defined by the API. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v2 5/5] media: dvb-frontends/stv0910: report active delsys in get_frontend()

2018-01-22 Thread Daniel Scheller
From: Daniel Scheller Report the active delivery system based on the receive_mode state of the demodulator. Suggested-by: Richard Scobie Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-frontends/s

[PATCH v2 4/5] media: dvb-frontends/stv0910: report S2 rolloff in get_frontend()

2018-01-22 Thread Daniel Scheller
From: Daniel Scheller Report the currently used S2 rolloff factor in get_frontend(). For cosmetic reasons, also change all feroll_off occurences to fe_rolloff. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 12 1 file changed, 8 insertions(+), 4 deleti

[PATCH v2 2/5] media: dvb_frontend: add DVB-S2X rolloff factors

2018-01-22 Thread Daniel Scheller
From: Daniel Scheller Add 15%, 10% and 5% DVB-S2X rolloff factors. Also fix roloff typos. Signed-off-by: Daniel Scheller --- Documentation/media/frontend.h.rst.exceptions | 3 +++ drivers/media/dvb-core/dvb_frontend.c | 9 + include/uapi/linux/dvb/frontend.h | 16

[PATCH v2 1/5] media: dvb_frontend: add FEC modes, S2X modulations and 64K transmission

2018-01-22 Thread Daniel Scheller
From: Daniel Scheller Add 1/4 and 1/3 FEC ratios, 64/128/256-APSK S2X modulations and 64K transmission mode. Update relevant doc items aswell. Signed-off-by: Daniel Scheller --- Documentation/media/frontend.h.rst.exceptions | 6 ++ include/uapi/linux/dvb/frontend.h | 13 ++

[PATCH v2 0/5] Add FEC rates, S2X params and 64K transmission

2018-01-22 Thread Daniel Scheller
From: Daniel Scheller dddvb brings a few additional FEC rates (1/4 and 1/3), 64/128/256APSK modulations and more rolloff factors (DVB-S2X), and 64K transmission mode (DVB-T2). These rather trivial patches bring them to mainline, and puts these missing bits into the stv0910's get_frontend() callba

[PATCH v2] media: dw9807: Add dw9807 vcm driver

2018-01-22 Thread Andy Yeh
From: Alan Chiang DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Signed-off-by: Andy Yeh Signed-off-by: Sakari Ailus --- v2: changed author .../bindings/media/i2c/dong

[PATCH] media: dw9807: Add dw9807 vcm driver

2018-01-22 Thread Andy Yeh
DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Signed-off-by: Andy Yeh Signed-off-by: Sakari Ailus --- .../bindings/media/i2c/dongwoon,dw9807.txt | 9 + MAINTAI

Re: [PATCH] media: ov5640: add JPEG support

2018-01-22 Thread Hugues FRUCHET
Hi Sakari, Thanks for reviewing, On 01/22/2018 01:52 PM, Sakari Ailus wrote: > Hi Hugues, > > On Mon, Jan 22, 2018 at 11:46:36AM +0100, Hugues Fruchet wrote: >> Add YUV422 encoded JPEG support. >> >> Signed-off-by: Hugues Fruchet >> --- >> drivers/media/i2c/ov5640.c | 82 >> ++

[PATCH] media: imx: add 8-bit grayscale support

2018-01-22 Thread Philipp Zabel
The IPUv3 code has 8-bit grayscale capture support. Enable imx-media to use it. Signed-off-by: Philipp Zabel --- This patch depends on https://patchwork.kernel.org/patch/10178777/ to work, otherwise STREAMON will fail with -EINVAL. --- drivers/staging/media/imx/imx-media-csi.c | 1 + drivers/s

[PATCH] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Andy Yeh
Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh Signed-off-by: Sakari Ailus --- v3: -- Update the streaming function to remove SW_STANDBY in the beginning. -- Adjust the dela

RE: [PATCH v2 1/1] imx258: Fix sparse warnings

2018-01-22 Thread Yeh, Andy
Hi Sakari, I made a minor fix. I2C write function works after the change. Please kindly review soon then I would submit v5. *buf++ = reg >> 8; *buf++ = reg & 0xff; - for (i = len - 1; i >= 0; i++) + for (i = len - 1; i >= 0; i--) if (i2c_master_send(client

Re: [PATCH 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread jacopo mondi
Hi Hans, On Mon, Jan 22, 2018 at 03:48:17PM +0100, Hans Verkuil wrote: > On 22/01/18 15:45, jacopo mondi wrote: > > Hi Hans, > > > > On Mon, Jan 22, 2018 at 11:18:50AM +0100, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> > > > > [snip] > > > >> diff --git a/drivers/media/platform/atmel/at

Re: MT9M131 on I.MX6DL CSI color issue

2018-01-22 Thread Florian Boor
Hello Daniel, On 20.01.2018 16:02, Daniel Glöckner wrote: > The VM-009 has 10 data lines. Do you use a board designed by Phytec? > If not, did you connect the lower or the upper 8 data lines to the i.MX6? > Using the upper 8 data lines is correct. its a VM-009 but not a Phytec baseboard and lucki

Re: [PATCH 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread Hans Verkuil
On 22/01/18 15:45, jacopo mondi wrote: > Hi Hans, > > On Mon, Jan 22, 2018 at 11:18:50AM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> > > [snip] > >> diff --git a/drivers/media/platform/atmel/atmel-isc.c >> b/drivers/media/platform/atmel/atmel-isc.c >> index 34676409ca08..92d695b29fa

Re: [PATCH 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread jacopo mondi
Hi Hans, On Mon, Jan 22, 2018 at 11:18:50AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > [snip] > diff --git a/drivers/media/platform/atmel/atmel-isc.c > b/drivers/media/platform/atmel/atmel-isc.c > index 34676409ca08..92d695b29fa9 100644 > --- a/drivers/media/platform/atmel/atmel-isc.c

Re: [RFC PATCH] v4l2-event/dev: wakeup pending events when unregistering

2018-01-22 Thread Michael Walz
Hi Hans, On 18.01.2018 16:13, Hans Verkuil wrote: Only apply the change to v4l2_dev.c, ignore the changes to v4l2_event. I think it is sufficient to just apply that bit. I tried both variants, with changes to v4l2_event and without. Both did not work out of the box. I think the problem is in

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-22 Thread Lars-Peter Clausen
On 01/22/2018 01:50 PM, Kieran Bingham wrote: > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as a standard slave > device on the I²C bus. > > Allow a device tree node to override the default addresses so that > address c

Re: [PATCH] media: ov5640: add JPEG support

2018-01-22 Thread Sakari Ailus
Hi Hugues, On Mon, Jan 22, 2018 at 11:46:36AM +0100, Hugues Fruchet wrote: > Add YUV422 encoded JPEG support. > > Signed-off-by: Hugues Fruchet > --- > drivers/media/i2c/ov5640.c | 82 > -- > 1 file changed, 80 insertions(+), 2 deletions(-) > > diff

[PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
The ADV7511 has four 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus. Allow a device tree node to override the default addresses so that address conflicts with other devices on the same bus may be resolve

[PATCH 1/2] media: adv7604: Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
From: Jean-Michel Hautbois The ADV7604 has thirteen 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus. Allow a device tree node to override the default addresses so that address conflicts with other devic

[PATCH 0/2] Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
Back in 2014, Jean-Michel provided patches [0] to implement a means of describing software defined I2C addresses for devices through the DT nodes. The patch to implement the function "i2c_new_secondary_device()" was integrated, but the corresponding driver update didn't get applied. This short se

Re: [PATCHv2 0/9] media: replace g/s_parm by g/s_frame_interval

2018-01-22 Thread Sakari Ailus
Hi Hans, On Mon, Jan 22, 2018 at 01:31:16PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > There are currently two subdev ops variants to get/set the frame interval: > g/s_parm and g/s_frame_interval. > > This patch series replaces all g/s_parm calls by g/s_frame_interval. > > The first p

[PATCH] [media] buffer.rst: fix link text of VIDIOC_QBUF

2018-01-22 Thread Gustavo Padovan
From: Gustavo Padovan The link was showing both VIDIOC_QBUF, VIDIOC_DQBUF while it should show only VIDIOC_QBUF in this case. Signed-off-by: Gustavo Padovan --- Documentation/media/uapi/v4l/buffer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/uapi/

[PATCHv2 6/9] staging: atomisp: mt9m114: Drop empty s_parm callback

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus The s_parm callback in mt9m114 driver did nothing, remove it. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-m

[PATCHv2 0/9] media: replace g/s_parm by g/s_frame_interval

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil There are currently two subdev ops variants to get/set the frame interval: g/s_parm and g/s_frame_interval. This patch series replaces all g/s_parm calls by g/s_frame_interval. The first patch adds helper functions that can be used by bridge drivers. Only em28xx can't use it

[PATCHv2 1/9] v4l2-common: create v4l2_g/s_parm_cap helpers

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil Create helpers to handle VIDIOC_G/S_PARM by querying the g/s_frame_interval v4l2_subdev ops. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-common.c | 48 +++ include/media/v4l2-common.h | 26 +++ 2 file

[PATCHv2 8/9] v4l2-subdev.h: remove obsolete g/s_parm

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- include/media/v4l2-subdev.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index 980a86c08fce..457917e9237f 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-su

[PATCHv2 9/9] vidioc-g-parm.rst: also allow _MPLANE buffer types

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil The specification mentions that type can be V4L2_BUF_TYPE_VIDEO_CAPTURE, but the v4l2 core implementation also allows the _MPLANE variant. Document this. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/vidioc-g-parm.rst | 7 --- 1 file changed, 4 insertions

[PATCHv2 5/9] staging: atomisp: i2c: Drop g_parm support in sensor drivers

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus These drivers already support g_frame_interval. Therefore just dropping g_parm is enough. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 27 -- drivers/staging/media/atomisp/i2c/atomisp-gc

[PATCHv2 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil Convert all g/s_parm calls to g/s_frame_interval. This allows us to remove the g/s_parm ops since those are a duplicate of g/s_frame_interval. Signed-off-by: Hans Verkuil --- drivers/media/i2c/mt9v011.c | 31 +++- drivers/media/i2c/ov6650.

[PATCHv2 7/9] staging: atomisp: Drop g_parm and s_parm subdev ops use

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus The s_parm and g_parm did nothing. Remove them. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- .../staging/media/atomisp/pci/atomisp2/atomisp_file.c| 16 drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 14 -- 2 files

[PATCHv2 3/9] staging: atomisp: Kill subdev s_parm abuse

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus Remove sensor driver's interface that made use of use case specific knowledge of platform capabilities. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 26 - drivers/staging/media/atomisp/i2c/atomisp-g

[PATCHv2 4/9] staging: atomisp: i2c: Disable non-preview configurations

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus Disable configurations for non-preview modes until configuration selection is improved. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/gc2235.h| 2 ++ drivers/staging/media/atomisp/i2c/ov2722.h| 2 ++ drivers/st

Re: [PATCH 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread Hans Verkuil
On 22/01/18 11:59, Sakari Ailus wrote: > Hi Hans, > > On Mon, Jan 22, 2018 at 11:33:28AM +0100, Hans Verkuil wrote: >> On 22/01/18 11:26, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Mon, Jan 22, 2018 at 11:18:50AM +0100, Hans Verkuil wrote: From: Hans Verkuil Convert all g/s_parm c

Re: [Patch v6 00/12] Add MFC v10.10 support

2018-01-22 Thread Hans Verkuil
Hi Smitha, Thank you for this v6 series! You can add my: Acked-by: Hans Verkuil to patches 1-9 and 11. See my review for patches 10 and 12. The comments are minor, so I hope I can Ack v7 once it's posted and this can be merged for 4.17. Regards, Hans On 08/12/17 10:08, Smitha T Murt

Re: [Patch v6 12/12] Documention: v4l: Documentation for HEVC CIDs

2018-01-22 Thread Hans Verkuil
On 08/12/17 10:08, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy > --- > Documentation/media/uapi/v4l/extended-controls.rst | 395 > + > 1 file changed, 395 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/extend

Re: [Patch v6 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2018-01-22 Thread Hans Verkuil
On 08/12/17 10:08, Smitha T Murthy wrote: > Add v4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy > Reviewed-by: Andrzej Hajda > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 118 > +++ > include/uapi/linux/v4l2-controls.h | 92

Re: [PATCH 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread Sakari Ailus
Hi Hans, On Mon, Jan 22, 2018 at 11:33:28AM +0100, Hans Verkuil wrote: > On 22/01/18 11:26, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Jan 22, 2018 at 11:18:50AM +0100, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Convert all g/s_parm calls to g/s_frame_interval. This allows us >

[PATCH] media: ov5640: add JPEG support

2018-01-22 Thread Hugues Fruchet
Add YUV422 encoded JPEG support. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 82 -- 1 file changed, 80 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index e2dd352..db9aeeb 100644

Re: [PATCH 9/9] vidioc-g-parm.rst: also allow _MPLANE buffer types

2018-01-22 Thread Hans Verkuil
On 22/01/18 11:26, Sakari Ailus wrote: > Hi Hans, > > On Mon, Jan 22, 2018 at 11:18:57AM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The specification mentions that type can be V4L2_BUF_TYPE_VIDEO_CAPTURE, >> but the v4l2 core implementation also allows the _MPLANE variant. >> >> Docum

[PATCH] [media] s3c-camif: array underflow in __camif_subdev_try_format()

2018-01-22 Thread Dan Carpenter
The while loop is a post op, "while (i-- >= 0)" so the last iteration will read camif_mbus_formats[-1] and then the loop will exit with "i" set to -2 and so we do: "mf->code = camif_mbus_formats[-2];". I've changed it to a pre-op, I've added a check to ensure we found the right format and I've rem

Re: [PATCH 1/9] v4l2-common: create v4l2_g/s_parm_cap helpers

2018-01-22 Thread Hans Verkuil
On 22/01/18 11:28, Sakari Ailus wrote: > On Mon, Jan 22, 2018 at 11:18:49AM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Create helpers to handle VIDIOC_G/S_PARM by querying the >> g/s_frame_interval v4l2_subdev ops. >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/v4l2-core/v

Re: [PATCH 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread Hans Verkuil
On 22/01/18 11:26, Sakari Ailus wrote: > Hi Hans, > > On Mon, Jan 22, 2018 at 11:18:50AM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Convert all g/s_parm calls to g/s_frame_interval. This allows us >> to remove the g/s_parm ops since those are a duplicate of >> g/s_frame_interval. >> >

Re: [PATCH 1/9] v4l2-common: create v4l2_g/s_parm_cap helpers

2018-01-22 Thread Sakari Ailus
On Mon, Jan 22, 2018 at 11:18:49AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Create helpers to handle VIDIOC_G/S_PARM by querying the > g/s_frame_interval v4l2_subdev ops. > > Signed-off-by: Hans Verkuil > --- > drivers/media/v4l2-core/v4l2-common.c | 49 > ++

Re: [PATCH 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread Sakari Ailus
Hi Hans, On Mon, Jan 22, 2018 at 11:18:50AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Convert all g/s_parm calls to g/s_frame_interval. This allows us > to remove the g/s_parm ops since those are a duplicate of > g/s_frame_interval. > > Signed-off-by: Hans Verkuil > --- > drivers/me

Re: [PATCH 9/9] vidioc-g-parm.rst: also allow _MPLANE buffer types

2018-01-22 Thread Sakari Ailus
Hi Hans, On Mon, Jan 22, 2018 at 11:18:57AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The specification mentions that type can be V4L2_BUF_TYPE_VIDEO_CAPTURE, > but the v4l2 core implementation also allows the _MPLANE variant. > > Document this. > > Signed-off-by: Hans Verkuil > ---

[PATCH 9/9] vidioc-g-parm.rst: also allow _MPLANE buffer types

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil The specification mentions that type can be V4L2_BUF_TYPE_VIDEO_CAPTURE, but the v4l2 core implementation also allows the _MPLANE variant. Document this. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/vidioc-g-parm.rst | 6 +++--- 1 file changed, 3 insertions(

[PATCH 5/9] staging: atomisp: i2c: Drop g_parm support in sensor drivers

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus These drivers already support g_frame_interval. Therefore just dropping g_parm is enough. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 27 -- drivers/staging/media/atomisp/i2c/atomisp-gc

[PATCH 6/9] staging: atomisp: mt9m114: Drop empty s_parm callback

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus The s_parm callback in mt9m114 driver did nothing, remove it. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-m

[PATCH 8/9] v4l2-subdev.h: remove obsolete g/s_parm

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- include/media/v4l2-subdev.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index 980a86c08fce..457917e9237f 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-su

[PATCH 7/9] staging: atomisp: Drop g_parm and s_parm subdev ops use

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus The s_parm and g_parm did nothing. Remove them. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- .../staging/media/atomisp/pci/atomisp2/atomisp_file.c| 16 drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 14 -- 2 files

[PATCH 3/9] staging: atomisp: Kill subdev s_parm abuse

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus Remove sensor driver's interface that made use of use case specific knowledge of platform capabilities. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 26 - drivers/staging/media/atomisp/i2c/atomisp-g

[PATCH 2/9] media: convert g/s_parm to g/s_frame_interval in subdevs

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil Convert all g/s_parm calls to g/s_frame_interval. This allows us to remove the g/s_parm ops since those are a duplicate of g/s_frame_interval. Signed-off-by: Hans Verkuil --- drivers/media/i2c/mt9v011.c | 29 +-- drivers/media/i2c/ov6650.c

[PATCH 1/9] v4l2-common: create v4l2_g/s_parm_cap helpers

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil Create helpers to handle VIDIOC_G/S_PARM by querying the g/s_frame_interval v4l2_subdev ops. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-common.c | 49 +++ include/media/v4l2-common.h | 26 +++ 2 file

[PATCH 4/9] staging: atomisp: i2c: Disable non-preview configurations

2018-01-22 Thread Hans Verkuil
From: Sakari Ailus Disable configurations for non-preview modes until configuration selection is improved. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- drivers/staging/media/atomisp/i2c/gc2235.h| 2 ++ drivers/staging/media/atomisp/i2c/ov2722.h| 2 ++ drivers/st

[PATCH 0/9] media: replace g/s_parm by g/s_frame_interval

2018-01-22 Thread Hans Verkuil
From: Hans Verkuil There are currently two subdev ops variants to get/set the frame interval: g/s_parm and g/s_frame_interval. This patch series replaces all g/s_parm calls by g/s_frame_interval. The first patch adds helper functions that can be used by bridge drivers. Only em28xx can't use it

[PATCH] media: ov5640: fix spurious streamon failures

2018-01-22 Thread Hugues Fruchet
Time to time, stream is failing with a strange positive error. Error code is returned erroneously by ov5640_set_ctrl_exposure() due to ov5640_get_vts() return value wrongly treated as error. Fix this by forcing ret to 0 after ov5640_get_vts() success call, in order that ret is set to success for re

[PATCH] media: ov5640: fix spurious streamon failures

2018-01-22 Thread Hugues Fruchet
Time to time, stream on is failing with a strange positive error. Error code is returned erroneously by ov5640_set_ctrl_exposure() due to ov5640_get_vts() return value wrongly treated as error. Fix this by forcing ret to 0 after ov5640_get_vts() success call, in order that ret is set to success for

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-22 Thread Hans Verkuil
On 21/01/18 18:49, jacopo mondi wrote: > Hi Hans, > > On Fri, Jan 19, 2018 at 12:26:09PM +0100, Hans Verkuil wrote: >> Hi Jacopo, >> >> On 01/16/18 22:44, Jacopo Mondi wrote: >>> Hello, >>>new version of CEU after Hans' review. >>> >>> Added his Acked-by to most patches and closed review comme

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-22 Thread Hans Verkuil
On 21/01/18 18:29, jacopo mondi wrote: > Hi Hans, > > On Sun, Jan 21, 2018 at 11:23:12AM +0100, Hans Verkuil wrote: >> On 21/01/18 11:21, Hans Verkuil wrote: >>> On 21/01/18 10:53, jacopo mondi wrote: Hi Hans, On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: > stati

Re: atomisp and g/s_parm

2018-01-22 Thread Sakari Ailus
Hi Hans, On Mon, Jan 22, 2018 at 10:19:13AM +0100, Hans Verkuil wrote: > On 21/01/18 23:48, Sakari Ailus wrote: > > Hi Hans, > > > > On Sun, Jan 21, 2018 at 11:46:46AM +0100, Hans Verkuil wrote: > >> Hi Sakari, > >> > >> I looked a bit closer at how atomisp uses g/s_parm. They abuse the > >> cap

Re: atomisp and g/s_parm

2018-01-22 Thread Hans Verkuil
On 21/01/18 23:48, Sakari Ailus wrote: > Hi Hans, > > On Sun, Jan 21, 2018 at 11:46:46AM +0100, Hans Verkuil wrote: >> Hi Sakari, >> >> I looked a bit closer at how atomisp uses g/s_parm. They abuse the >> capturemode field >> to select video/preview/still modes on the sensor, which actually chan

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-22 Thread Hans Verkuil
On 22/01/18 01:52, Laurent Pinchart wrote: > Hi Hans, > > On Friday, 19 January 2018 14:25:39 EET Hans Verkuil wrote: >> On 01/19/18 13:20, Laurent Pinchart wrote: >>> On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote: On 01/16/18 22:44, Jacopo Mondi wrote: > Add driver for Renes

Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Sakari Ailus
On Mon, Jan 22, 2018 at 10:37:43AM +0200, Sakari Ailus wrote: > Hi Andy, > > On Mon, Jan 22, 2018 at 08:03:23AM +, Yeh, Andy wrote: > > Hi Sakari, Tomasz, > > > > As below discussion that other drivers are with this pattern, I would > > prefer to defer to address the concern in later discuss

Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Sakari Ailus
Hi Andy, On Mon, Jan 22, 2018 at 08:03:23AM +, Yeh, Andy wrote: > Hi Sakari, Tomasz, > > As below discussion that other drivers are with this pattern, I would prefer > to defer to address the concern in later discussion with you and owners of > other sensors. > > Thanks a lot. I thought o

Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Sakari Ailus
On Mon, Jan 22, 2018 at 08:03:23AM +, Yeh, Andy wrote: > Hi Sakari, Tomasz, > > As below discussion that other drivers are with this pattern, I would > prefer to defer to address the concern in later discussion with you and > owners of other sensors. > > Thanks a lot. Works for me. -- Saka

[PATCH v2 1/1] imx258: Fix sparse warnings

2018-01-22 Thread Sakari Ailus
Fix a few sparse warnings related to conversion between CPU and big endian. Also simplify the code in the process. Signed-off-by: Sakari Ailus --- Hi Andy, I think I figured out the problem. Could you test this? Thanks. since v1: - Fix pointer passed to i2c_master_send. This is the entire buf

RE: [PATCH 1/1] imx258: Fix sparse warnings

2018-01-22 Thread Yeh, Andy
Hi Sakari, I verified the patch multiple times but the code cannot work. Regards, Andy -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Friday, January 19, 2018 5:23 PM To: linux-media@vger.kernel.org Cc: Yeh, Andy Subject: [PATCH 1/1] imx258: Fix spa

RE: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Yeh, Andy
Hi Sakari, Tomasz, As below discussion that other drivers are with this pattern, I would prefer to defer to address the concern in later discussion with you and owners of other sensors. Thanks a lot. Regards, Andy -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.