cron job: media_tree daily build: ERRORS

2018-01-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Jan 27 05:00:16 CET 2018 media-tree git hash:4852fdca8818972d0ea5b5ce7114da628f9954a4 media_build

[PATCH] media: radio: Critical interrupt bugfix for si470x over i2c

2018-01-26 Thread Douglas Fischer
Fixed si470x_start() disabling the interrupt signal, causing tune operations to never complete. This does not affect USB radios because they poll the registers instead of using the IRQ line. Signed-off-by: Douglas Fischer --- diff -uprN

[PATCH] ir-hix5hd2: fix error handling of clk_prepare_enable()

2018-01-26 Thread Alexey Khoroshilov
Return code of clk_prepare_enable() is ignored in many places. The patch adds error handling for all of them. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/rc/ir-hix5hd2.c | 35

Re: [linux-next:master 3766/11889] drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition

2018-01-26 Thread Wolfgang Rohdewald
On Sa, 2018-01-27 at 05:51 +0800, kbuild test robot wrote: > Hi Wolfgang, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: f0701bf7db7ab816244aed52d28ac49f32c8c2c9 > commit:

[linux-next:master 3766/11889] drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition

2018-01-26 Thread kbuild test robot
Hi Wolfgang, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f0701bf7db7ab816244aed52d28ac49f32c8c2c9 commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e [3766/11889] media: dvb_usb_pctv452e: module refcount changes

Re: [RFC PATCH 6/8] v4l2: document the request API interface

2018-01-26 Thread Nicolas Dufresne
Le vendredi 26 janvier 2018 à 12:40 -0800, Randy Dunlap a écrit : > > +Request API > > +=== > > + > > +The Request API has been designed to allow V4L2 to deal with > > requirements of > > +modern IPs (stateless codecs, MIPI cameras, ...) and APIs (Android > > Codec v2). > > Hi, > Just a

Re: [RFC PATCH 6/8] v4l2: document the request API interface

2018-01-26 Thread Randy Dunlap
On 01/25/2018 10:02 PM, Alexandre Courbot wrote: > Document how the request API can be used along with the existing V4L2 > interface. > > +Request API > +=== > + > +The Request API has been designed to allow V4L2 to deal with requirements of > +modern IPs (stateless codecs, MIPI cameras,

[PATCH] media: drx-j remove bsp_i2c.h

2018-01-26 Thread Corentin Labbe
bsp_i2c.h is unused since commit ffe7c4f92183 ("[media] drx-j: Get rid of drx39xyj/bsp_tuner.h") Remove it from tree. Signed-off-by: Corentin Labbe --- drivers/media/dvb-frontends/drx39xyj/bsp_i2c.h | 139 - 1 file changed, 139 deletions(-) delete

Re: dvb usb issues since kernel 4.9

2018-01-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Jan 2018 12:17:37 -0200 Mauro Carvalho Chehab escreveu: > Hi Alan, > > Em Mon, 8 Jan 2018 14:15:35 -0500 (EST) > Alan Stern escreveu: > > > On Mon, 8 Jan 2018, Linus Torvalds wrote: > > > > > Can somebody tell which softirq it

Re: [PATCH] sh: clk: Relax clk rate match test

2018-01-26 Thread jacopo mondi
Hi Geert, On Thu, Jan 25, 2018 at 03:39:32PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, [snip] > >> > --- > >> > drivers/sh/clk/core.c | 9 ++--- > >> > 1 file changed, 6 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/drivers/sh/clk/core.c b/drivers/sh/clk/core.c > >> > index

Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig

2018-01-26 Thread Andy Shevchenko
On Fri, Jan 26, 2018 at 2:49 PM, LABBE Corentin wrote: > On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote: >> On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: >> > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe >> >

Re: [PATCH 07/12] v4l2-compat-ioctl32.c: copy m.userptr in put_v4l2_plane32

2018-01-26 Thread Sakari Ailus
Hi Hans, On Fri, Jan 26, 2018 at 01:43:22PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The struct v4l2_plane32 should set m.userptr as well. The same > happens in v4l2_buffer32 and v4l2-compliance tests for this. > > Signed-off-by: Hans Verkuil

Re: [PATCH 06/12] v4l2-compat-ioctl32.c: avoid sizeof(type)

2018-01-26 Thread Sakari Ailus
On Fri, Jan 26, 2018 at 01:43:21PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Instead of doing sizeof(struct foo) use sizeof(*up). There even were > cases where 4 * sizeof(__u32) was used instead of sizeof(kp->reserved), > which is very dangerous when the size of

Re: [PATCH 05/12] v4l2-compat-ioctl32.c: move 'helper' functions to __get/put_v4l2_format32

2018-01-26 Thread Sakari Ailus
Hi Hans, On Fri, Jan 26, 2018 at 01:43:20PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > These helper functions do not really help. Move the code to the > __get/put_v4l2_format32 functions. > > Signed-off-by: Hans Verkuil > --- >

Re: [PATCH 04/12] v4l2-compat-ioctl32.c: fix the indentation

2018-01-26 Thread Sakari Ailus
On Fri, Jan 26, 2018 at 01:43:19PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The indentation of this source is all over the place. Fix this. > This patch only changes whitespace. > > Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus

[PATCH] media: staging: atomisp: remove redundant assignments to various variables

2018-01-26 Thread Colin King
From: Colin Ian King There are various assignments that are being made to variables that are not read and the variables are being updated later on, hence the redundant assignments can be removed. Cleans up clang warnings:

Re: [PATCH 01/12] vivid: fix module load error when enabling fb and no_error_inj=1

2018-01-26 Thread Sakari Ailus
On Fri, Jan 26, 2018 at 01:43:16PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > If the framebuffer is enabled and error injection is disabled, then > creating the controls for the video output device would fail with an > error. > > This is because the Clear

Re: [PATCH 03/12] v4l2-compat-ioctl32.c: add missing VIDIOC_PREPARE_BUF

2018-01-26 Thread Sakari Ailus
On Fri, Jan 26, 2018 at 01:43:18PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The result of the VIDIOC_PREPARE_BUF ioctl was never copied back > to userspace since it was missing in the switch. > > Signed-off-by: Hans Verkuil Acked-by:

Re: [PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt

2018-01-26 Thread Sakari Ailus
Hi Hans, On Fri, Jan 26, 2018 at 01:43:17PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Don't duplicate the buffer type checks in enum/g/s/try_fmt. > The check_fmt function does that already. > > It is hard to keep the checks in sync for all these functions and

Re: dvb usb issues since kernel 4.9

2018-01-26 Thread Mauro Carvalho Chehab
Hi Alan, Em Mon, 8 Jan 2018 14:15:35 -0500 (EST) Alan Stern escreveu: > On Mon, 8 Jan 2018, Linus Torvalds wrote: > > > Can somebody tell which softirq it is that dvb/usb cares about? > > I don't know about the DVB part. The USB part is a little difficult to >

[PATCH v7 02/11] include: media: Add Renesas CEU driver interface

2018-01-26 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil

[PATCH v7 00/11] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-26 Thread Jacopo Mondi
Hello, 7th round for CEU driver This series includes 2 new patches compared to v6 and it is now based on top of Hans' series: [PATCHv2 0/9] media: replace g/s_parm by g/s_frame_interval and makes use of newly introduced v4l2_g/s_parm_cap() functions from v4l2-common in CEU's g/s_parm()

[PATCH v7 01/11] dt-bindings: media: Add Renesas CEU bindings

2018-01-26 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH v7 03/11] media: platform: Add Renesas CEU driver

2018-01-26 Thread Jacopo Mondi
Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

[PATCH v7 06/11] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-26 Thread Jacopo Mondi
Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Change image format colorspace from JPEG to SRGB as the two use the same colorspace information but JPEG makes

[PATCH v7 05/11] media: i2c: Copy ov772x soc_camera sensor driver

2018-01-26 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v7 04/11] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-26 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

Re: [PATCH v7 00/11] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-26 Thread Geert Uytterhoeven
Hi Jacopo, On Fri, Jan 26, 2018 at 2:54 PM, jacopo mondi wrote: > UUUPS > > please ignore this submission as it contains patches from a previous > version (you may have noticed some patches in the series reports > [xx/09] in the subject). > > I will resend. Good. So there's

[PATCH v7 07/11] media: i2c: ov772x: Support frame interval handling

2018-01-26 Thread Jacopo Mondi
Add support to ov772x driver for frame intervals handling and enumeration. Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for 10, 15 and 30 frame per second rates. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 315

[PATCH v7 09/11] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-26 Thread Jacopo Mondi
Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

[PATCH v7 08/11] media: i2c: Copy tw9910 soc_camera sensor driver

2018-01-26 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v7 10/11] arch: sh: migor: Use new renesas-ceu camera driver

2018-01-26 Thread Jacopo Mondi
Migo-R platform uses sh_mobile_ceu camera driver, which is now being replaced by a proper V4L2 camera driver named 'renesas-ceu'. Move Migo-R platform to use the v4l2 renesas-ceu camera driver interface and get rid of soc_camera defined components used to register sensor drivers and of platform

[PATCH v7 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-01-26 Thread Jacopo Mondi
The sensor driver sets mbus format colorspace information and sizes, but not ycbcr encoding, quantization and xfer function. When supplied with an badly initialized mbus frame format structure, those fields need to be set explicitly not to leave them uninitialized. This is tested by

[PATCH v7 01/11] dt-bindings: media: Add Renesas CEU bindings

2018-01-26 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH v7 02/11] include: media: Add Renesas CEU driver interface

2018-01-26 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil

Re: [PATCH v7 00/11] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-26 Thread jacopo mondi
UUUPS please ignore this submission as it contains patches from a previous version (you may have noticed some patches in the series reports [xx/09] in the subject). I will resend. Sorry for the noise On Fri, Jan 26, 2018 at 02:48:32PM +0100, Jacopo Mondi wrote: > Hello, > 7th round for CEU

[PATCH v7 04/11] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-26 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH v7 3/9] v4l: platform: Add Renesas CEU driver

2018-01-26 Thread Jacopo Mondi
Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

[PATCH v7 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2018-01-26 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v7 06/11] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-26 Thread Jacopo Mondi
Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Change image format colorspace from JPEG to SRGB as the two use the same colorspace information but JPEG makes

[PATCH v7 07/11] media: i2c: ov772x: Support frame interval handling

2018-01-26 Thread Jacopo Mondi
Add support to ov772x driver for frame intervals handling and enumeration. Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for 10, 15 and 30 frame per second rates. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 315

[PATCH v7 08/11] media: i2c: Copy tw9910 soc_camera sensor driver

2018-01-26 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v7 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

2018-01-26 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v7 9/9] arch: sh: migor: Use new renesas-ceu camera driver

2018-01-26 Thread Jacopo Mondi
Migo-R platform uses sh_mobile_ceu camera driver, which is now being replaced by a proper V4L2 camera driver named 'renesas-ceu'. Move Migo-R platform to use the v4l2 renesas-ceu camera driver interface and get rid of soc_camera defined components used to register sensor drivers and of platform

[PATCH v7 8/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-26 Thread Jacopo Mondi
Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

[PATCH v7 09/11] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-26 Thread Jacopo Mondi
Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

[PATCH v7 10/11] arch: sh: migor: Use new renesas-ceu camera driver

2018-01-26 Thread Jacopo Mondi
Migo-R platform uses sh_mobile_ceu camera driver, which is now being replaced by a proper V4L2 camera driver named 'renesas-ceu'. Move Migo-R platform to use the v4l2 renesas-ceu camera driver interface and get rid of soc_camera defined components used to register sensor drivers and of platform

[PATCH v7 05/11] media: i2c: Copy ov772x soc_camera sensor driver

2018-01-26 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v7 03/11] media: platform: Add Renesas CEU driver

2018-01-26 Thread Jacopo Mondi
Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

[PATCH v7 00/11] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-26 Thread Jacopo Mondi
Hello, 7th round for CEU driver This series includes 2 new patches compared to v6 and it is now based on top of Hans' series: [PATCHv2 0/9] media: replace g/s_parm by g/s_frame_interval and makes use of newly introduced v4l2_g/s_parm_cap() functions from v4l2-common in CEU's g/s_parm()

Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig

2018-01-26 Thread LABBE Corentin
On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: > > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe wrote: > > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 > > >

[PATCH 12/12] v4l2-compat-ioctl32.c: refactor, fix security bug in compat ioctl32

2018-01-26 Thread Hans Verkuil
From: Daniel Mentz The 32-bit compat v4l2 ioctl is implemented based on its 64-bit equivalent. It converts 32-bit data structures into its 64-bit equivalents and needs to provide the data to the 64-bit ioctl in user space memory which is commonly allocated using

[PATCH 01/12] vivid: fix module load error when enabling fb and no_error_inj=1

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil If the framebuffer is enabled and error injection is disabled, then creating the controls for the video output device would fail with an error. This is because the Clear Framebuffer control uses the 'vivid control class' and that control class isn't

[PATCH 10/12] v4l2-compat-ioctl32.c: drop pr_info for unknown buffer type

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil There is nothing wrong with using an unknown buffer type. So stop spamming the kernel log whenever this happens. The kernel will just return -EINVAL to signal this. Signed-off-by: Hans Verkuil ---

[PATCH 06/12] v4l2-compat-ioctl32.c: avoid sizeof(type)

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil Instead of doing sizeof(struct foo) use sizeof(*up). There even were cases where 4 * sizeof(__u32) was used instead of sizeof(kp->reserved), which is very dangerous when the size of the reserved array changes. Signed-off-by: Hans Verkuil

[PATCH 07/12] v4l2-compat-ioctl32.c: copy m.userptr in put_v4l2_plane32

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil The struct v4l2_plane32 should set m.userptr as well. The same happens in v4l2_buffer32 and v4l2-compliance tests for this. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 47

[PATCH 09/12] v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil put_v4l2_window32() didn't copy back the clip list to userspace. Drivers can update the clip rectangles, so this should be done. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 58

[PATCH 04/12] v4l2-compat-ioctl32.c: fix the indentation

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil The indentation of this source is all over the place. Fix this. This patch only changes whitespace. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 212 +- 1 file

[PATCH 08/12] v4l2-compat-ioctl32.c: fix ctrl_is_pointer

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil ctrl_is_pointer just hardcoded two known string controls, but that caused problems when using e.g. custom controls that use a pointer for the payload. Reimplement this function: it now finds the v4l2_ctrl (if the driver uses the control framework) or

[PATCH 03/12] v4l2-compat-ioctl32.c: add missing VIDIOC_PREPARE_BUF

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil The result of the VIDIOC_PREPARE_BUF ioctl was never copied back to userspace since it was missing in the switch. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 1 + 1 file changed, 1

[PATCH 11/12] v4l2-compat-ioctl32.c: don't copy back the result for certain errors

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil Some ioctls need to copy back the result even if the ioctl returned an error. However, don't do this for the error codes -ENOTTY, -EFAULT and -ENOIOCTLCMD. It makes no sense in those cases. Signed-off-by: Hans Verkuil ---

[PATCH 02/12] v4l2-ioctl.c: use check_fmt for enum/g/s/try_fmt

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil Don't duplicate the buffer type checks in enum/g/s/try_fmt. The check_fmt function does that already. It is hard to keep the checks in sync for all these functions and in fact the check for VBI was wrong in the _fmt functions as it allowed SDR types as

[PATCH 05/12] v4l2-compat-ioctl32.c: move 'helper' functions to __get/put_v4l2_format32

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil These helper functions do not really help. Move the code to the __get/put_v4l2_format32 functions. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 124 +- 1 file changed,

[PATCH 00/12] v4l2-compat-ioctl32.c: remove set_fs(KERNEL_DS)

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil This patch series fixes a number of bugs and culminates in the removal of the set_fs(KERNEL_DS) call in v4l2-compat-ioctl32.c. See http://people.canonical.com/~ubuntu-security/cve/2017/CVE-2017-13166.html for why this set_fs call is a bad idea. In

Re: [PATCH v3] media: dw9807: Add dw9807 vcm driver

2018-01-26 Thread Sakari Ailus
Hi Andy, There seem to be two different v3 versions of the dw9807 driver patch. I assume this is the right one. A few more comments below. On Fri, Jan 26, 2018 at 01:38:52AM +0800, Andy Yeh wrote: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed

Re: [RFC PATCH 1/9] media: add request API core and UAPI

2018-01-26 Thread Sakari Ailus
Hi Alexandre, I remember it was discussed that the work after the V4L2 jobs API would continue from the existing request API patches. I see that at least the rather important support for events is missing in this version. Why was it left out? I also see that variable size IOCTL argument support

Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

2018-01-26 Thread Maxime Ripard
On Fri, Jan 26, 2018 at 11:00:41AM +0800, Yong wrote: > Hi Maxime, > > On Fri, 26 Jan 2018 09:46:58 +0800 > Yong wrote: > > > Hi Maxime, > > > > Do you have any experience in solving this problem? > > It seems the PHYS_OFFSET maybe undeclared when the ARCH is not arm. >