Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

On Thu, Apr 12, 2018 at 6:57 PM Sakari Ailus wrote: > Hi Jacopo, > On Thu, Apr 12, 2018 at 10:57:01AM +0200, jacopo mondi wrote: > ... > > > + if (MAX_RETRY == ++retry) { > > > + dev_err(>dev, > > > + "Cannot do

Re: Donation

-- I Mikhail Fridman. has selected you specially as one of my beneficiaries for my Charitable Donation, Just as I have declared on May 23, 2016 to give my fortune as charity. Check the link below for confirmation:

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Apr 16 05:00:13 CEST 2018 media-tree git hash:b284d4d5a6785f8cd07eda2646a95782373cd01e media_build

[PATCH v2 10/10] media: ov772x: avoid accessing registers under power saving mode

The set_fmt() in subdev pad ops, the s_ctrl() for subdev control handler, and the s_frame_interval() in subdev video ops could be called when the device is under power saving mode. These callbacks for ov772x driver cause updating H/W registers that will fail under power saving mode. This avoids

[PATCH v2 08/10] media: ov772x: handle nested s_power() calls

Depending on the v4l2 driver, calling s_power() could be nested. So the actual transitions between power saving mode and normal operation mode should only happen at the first power on and the last power off. This adds an s_power() nesting counter and updates the power state if the counter is

[PATCH v2 04/10] media: ov772x: add media controller support

Create a source pad and set the media controller type to the sensor. Cc: Jacopo Mondi Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus Cc: Mauro Carvalho Chehab

[PATCH v2 06/10] media: dt-bindings: ov772x: add device tree binding

This adds a device tree binding documentation for OV7720/OV7725 sensor. Cc: Jacopo Mondi Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus Cc: Mauro Carvalho Chehab

[PATCH v2 09/10] media: ov772x: reconstruct s_frame_interval()

This splits the s_frame_interval() in subdev video ops into selecting the frame interval and setting up the registers. This is a preparatory change to avoid accessing registers under power saving mode. Cc: Jacopo Mondi Cc: Laurent Pinchart

[PATCH v2 03/10] media: ov772x: create subdevice device node

Set the V4L2_SUBDEV_FL_HAS_DEVNODE flag for the subdevice so that the subdevice device node is created. Cc: Jacopo Mondi Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus

[PATCH v2 07/10] media: ov772x: support device tree probing

The ov772x driver currently only supports legacy platform data probe. This change enables device tree probing. Note that the platform data probe can select auto or manual edge control mode, but the device tree probling can only select auto edge control mode for now. Cc: Jacopo Mondi

[PATCH v2 02/10] media: ov772x: add checks for register read errors

This change adds checks for register read errors and returns correct error code. Cc: Jacopo Mondi Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus Cc: Mauro Carvalho

[PATCH v2 01/10] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

The ov772x driver only works when the i2c controller have I2C_FUNC_PROTOCOL_MANGLING. However, many i2c controller drivers don't support it. The reason that the ov772x requires I2C_FUNC_PROTOCOL_MANGLING is that it doesn't support repeated starts. This changes the reading ov772x register method

[PATCH v2 00/10] media: ov772x: support media controller, device tree probing, etc.

This patchset includes support media controller, device tree probing and other miscellanuous changes for ov772x driver. * v2 (thanks to Jacopo Mondi) - Replace the implementation of ov772x_read() instead of adding an alternative method - Assign the ov772x_read() return value to pid and ver

[PATCH v2 05/10] media: ov772x: use generic names for reset and powerdown gpios

The ov772x driver uses "rstb-gpios" and "pwdn-gpios" for reset and powerdown pins. However, using generic names for thse gpios is preferred. ("reset-gpios" and "powerdown-gpios" respectively) There is only one mainline user for these gpios, so rename to generic names. Cc: Jacopo Mondi

[PATCH] media: rc: mtk-cir: use of_device_get_match_data()

The usage of of_device_get_match_data() reduce the code size a bit. Signed-off-by: Ryder Lee --- drivers/media/rc/mtk-cir.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/rc/mtk-cir.c b/drivers/media/rc/mtk-cir.c index

OV5640 with 12MHz xclk

Can anyone verify if the OV5640 driver works with input clocks other than the typical 24MHz? The driver suggests anything from 6MHz-24MHz is acceptable, but I am running into issues while bringing up a module that uses a 12MHz oscillator. I'd expect that different xclk's would necessitate

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Jacopo, Thanks for your feedback. Comments I have snipped out from this reply are addressed, thanks for bringing them to my attention! On 2018-04-05 11:10:01 +0200, Jacopo Mondi wrote: [snip] > > +static int rcar_csi2_wait_phy_start(struct rcar_csi2 *priv) > > +{ > > + int timeout; > >

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Laurent, Thanks for your feedback. I have addressed all your comment's but one for the next version. Please indicate if you are fine with this and I can still keep your review tag :-) On 2018-04-04 18:15:16 +0300, Laurent Pinchart wrote: [snip] > > +static int rcar_csi2_start(struct

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Sakari, Thanks for your feedback. On 2018-04-04 23:13:57 +0300, Sakari Ailus wrote: [snip] > > > + pm_runtime_enable(>dev); > > > > Is CONFIG_PM mandatory on Renesas SoCs? If not, you end up with the > > device uninitialised at probe, and pm_runtime_get_sync will not > > initialise it

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Geert and Laurent, Thanks for the feedback. On 2018-04-05 11:26:45 +0300, Laurent Pinchart wrote: [snip] > > Alternatively, you could check for a valid number of lanes, and use > > knowledge about the internal lane bits: > > > > phycnt = PHYCNT_ENABLECLK; > > phycnt |= (1 <<

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Maxime, Thanks for your feedback. On 2018-03-29 13:30:39 +0200, Maxime Ripard wrote: > Hi Niklas, > > On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > > + switch (priv->lanes) { > > + case 1: > > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_0; > > +

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Laurent, Thanks for your feedback. On 2018-04-04 18:25:23 +0300, Laurent Pinchart wrote: [snip] > > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c > > > b/drivers/media/platform/rcar-vin/rcar-csi2.c new file mode 100644 > > > index ..c0c2a763151bc928 > > > ---

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Kieran, Thanks for your feedback. On 2018-03-13 23:23:49 +0100, Kieran Bingham wrote: > Hi Niklas > > Thank you for this patch ... > I know it has been a lot of work getting this and the VIN together! > > On 13/02/18 00:01, Niklas Söderlund wrote: > > A V4L2 driver for Renesas R-Car MIPI

cx88 invalid video opcodes when VBI enabled

Hello, I received a report of a case where cx88 video capture was failing on start and the dmesg was reporting an invalid opcode on the video IRQ handler. I did a bisect, and it looks like it's a result of the videobuf2 conversion done back in late 2014. A few notes: 1. It only seems to occur

[PATCH stable v4.15 0/3] lirc_zilog bugs

This driver has a few problems, however the driver has been removed from staging in v4.16 (replaced by a new driver). Please can these patches be included in the 4.15.* stable tree. Thanks Sean Young (3): media: staging: lirc_zilog: broken reference counting Revert "media: lirc_zilog: driver

[PATCH stable v4.15 1/3] media: staging: lirc_zilog: broken reference counting

commit 615cd3fe6ccc ("[media] media: lirc_dev: make better use of file->private_data") removed the reference get from open, so on the first close the reference count hits zero and the lirc device is freed. BUG: unable to handle kernel NULL pointer dereference at 0040 IP:

[PATCH stable v4.15 2/3] Revert "media: lirc_zilog: driver only sends LIRCCODE"

The lirc config documented here https://www.blushingpenguin.com/mark/blog/?p=24 uses raw_codes for sending IR. Each key only has one pulse, which in fact is an index into the haup-ir-blaster.bin file. Changing the driver to LIRCCODE (although more accurate) breaks this configuration. This code

[PATCH stable v4.15 3/3] media: staging: lirc_zilog: incorrect reference counting

Whenever poll is called, the reference count is increased but never decreased. This means that on rmmod, the lirc_thread is not stopped, and will trample over freed memory. Zilog/Hauppauge IR driver unloaded BUG: unable to handle kernel paging request at c17ba640 Oops: 0010 [#1] SMP CPU:

[PATCH stable v4.14 0/2] lirc_zilog bugs

This driver has a few problems, however the driver has been removed from staging in v4.16 (replaced by a new driver). Please can these patches be included in the 4.14.* stable tree. Sean Young (2): Revert "media: lirc_zilog: driver only sends LIRCCODE" media: staging: lirc_zilog: incorrect

[PATCH stable v4.14 1/2] Revert "media: lirc_zilog: driver only sends LIRCCODE"

The lirc config documented here https://www.blushingpenguin.com/mark/blog/?p=24 uses raw_codes for sending IR. Each key only has one pulse, which in fact is an index into the haup-ir-blaster.bin file. Changing the driver to LIRCCODE (although more accurate) breaks this configuration. This code

[PATCH stable v4.14 2/2] media: staging: lirc_zilog: incorrect reference counting

Whenever poll is called, the reference count is increased but never decreased. This means that on rmmod, the lirc_thread is not stopped, and will trample over freed memory. Zilog/Hauppauge IR driver unloaded BUG: unable to handle kernel paging request at c17ba640 Oops: 0010 [#1] SMP CPU: