On Tue, Apr 17, 2018 at 3:12 PM Hans Verkuil wrote:
> On 04/17/2018 06:33 AM, Alexandre Courbot wrote:
> > On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> >
> >> From: Hans Verkuil
> >
> >> Hi all,
> >
> >> This is a cleaned up version of the v10 series (never posted to
> >> the list sinc
On 04/17/2018 06:33 AM, Alexandre Courbot wrote:
> On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
>
>> From: Hans Verkuil
>
>> Hi all,
>
>> This is a cleaned up version of the v10 series (never posted to
>> the list since it was messy).
>
> Hi Hans,
>
> It took me a while to test and re
Hi,
On Sun, Apr 15, 2018 at 01:37:50PM -0400, Devin Heitmueller wrote:
> Any suggestions on the best way to debug this without having to learn
> the intimate details of the RISC engine on the cx88? From the state
> of the RISC engine it looks like there is some issue with queuing the
> opcodes/ar
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Alexandre Courbot
> Request API requires a media node. Add one to the vim2m driver so we can
> use requests with it.
> This probably needs a bit more work to correctly represent m2m
> hardware in the media topology.
> Signed-off-by:
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Add support for requests to vim2m.
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/platform/vim2m.c | 25 +
> 1 file changed, 25 insertions(+)
> diff --git a/drivers/media/platform/vim2m
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Hans Verkuil
> This implements the V4L2 part of the request support. The main
> change is that vb2_qbuf and vb2_prepare_buf now have a new
> media_device pointer. This required changes to several drivers
> that did not use the vb2_ioct
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Add media_request_object_find to find a request object inside a
> request based on ops and/or priv values.
> Objects of the same type (vb2 buffer, control handler) will have
> the same ops value. And objects that refer
We are re-implementing this patch. So obsolete this patch from list first.
https://patchwork.linuxtv.org/patch/48722/
Permalink /patch/48722/
State Obsoleted
Regards, Andy
-Original Message-
From: Yeh, Andy
Sent: Monday, April 16, 2018 11:04 PM
To: linux-media@vger.kernel.org
Cc:
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Implement the core of the media request processing.
> Drivers can bind request objects to a request. These objects
> can then be marked completed if the driver finished using them,
> or just be unbound if the results do
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Hans Verkuil
> The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set.
> But since we will need to pass the media_device to vb2 snd the
Typo: s/snd/and
> control framework it is very convenient to just make this field
> ava
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Define the public request API.
> This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request
> and two ioctls that operate on a request in order to queue the
> contents of the request to the driver and to re-i
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Hi all,
> This is a cleaned up version of the v10 series (never posted to
> the list since it was messy).
Hi Hans,
It took me a while to test and review this, but finally have been able to
do it.
First the result of
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Add support for allocating a new request. This is only supported
> if mdev->ops->req_queue is set, i.e. the driver indicates that it
> supports queueing requests.
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/M
On Mon, 2018-04-16 at 10:34 +0800, Ryder Lee wrote:
> The usage of of_device_get_match_data() reduce the code size a bit.
>
> Signed-off-by: Ryder Lee
> ---
> drivers/media/rc/mtk-cir.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/rc/mtk-cir.c b/driv
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Apr 17 05:00:16 CEST 2018
media-tree git hash:60cc43fc888428bb2f18f08997432d426a243338
media_build gi
Hi Jacopo,
On 2018-04-16 01:16:35 +0200, Niklas Söderlund wrote:
[snip]
> > > +
> > > + /* Set frequency range if we have it */
> > > + if (priv->info->csi0clkfreqrange)
> > > + rcar_csi2_write(priv, CSI0CLKFCPR_REG,
> > > + CSI0CLKFREQRANGE(priv->info->csi0clkfre
I've been digging around the ov5640.c code for a few weeks now, these
look like some solid improvements. I'll give them a shot and let you
know how they work.
On that note, I'm bringing up a module that uses dual lane MIPI with a
12MHz fixed oscillator for xclk (Digilent's Pcam 5c). The mainline
v
Thanks all, that's what I was expecting. It clears some things up.
I'm going to check out Maxime's recent patches and see if those do the
trick, otherwise I'll get cracking on some patches myself.
Sam
---
Sam Bobrowicz
Elite Embedded Consulting LLC
elite-embedded.com
On Mon,
On Mon, Apr 16, 2018 at 11:51:47AM +0900, Akinobu Mita wrote:
> This adds a device tree binding documentation for OV7720/OV7725 sensor.
>
> Cc: Jacopo Mondi
> Cc: Laurent Pinchart
> Cc: Hans Verkuil
> Cc: Sakari Ailus
> Cc: Mauro Carvalho Chehab
> Cc: Rob Herring
> Signed-off-by: Akinobu Mit
Hello
Greeetings to you please did you get my previous email regarding my
investment proposal last week friday ?
MS.Zeliha ömer faruk
zeliha.omer.fa...@gmail.com
On Mon, Apr 16, 2018 at 06:00:12PM +0200, Hans Verkuil wrote:
> On 04/16/2018 05:11 PM, Mauro Carvalho Chehab wrote:
> > In the past, "up" were an acronym for "user pointer" and "kp" for
> > "kernel pointer". However, since a1dfb4c48cc1 ("media:
> > v4l2-compat-ioctl32.c: refactor compat ioctl32 lo
On 04/16/2018 09:40 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 16 Apr 2018 21:27:01 +0200
> Hans Verkuil escreveu:
>
>> On 04/16/2018 08:01 PM, Mauro Carvalho Chehab wrote:
>>> Em Mon, 16 Apr 2018 15:21:16 +0200
>>> Hans Verkuil escreveu:
>>>
From: Hans Verkuil
This adds suppo
On 04/16/2018 08:09 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 16 Apr 2018 15:03:35 -0300
> Mauro Carvalho Chehab escreveu:
>
>> Em Mon, 16 Apr 2018 15:21:18 +0200
>> Hans Verkuil escreveu:
>>
>>> From: Hans Verkuil
>>>
>>> The v2 pad structure never exposed the pad index, which made it impossi
Em Mon, 16 Apr 2018 21:27:01 +0200
Hans Verkuil escreveu:
> On 04/16/2018 08:01 PM, Mauro Carvalho Chehab wrote:
> > Em Mon, 16 Apr 2018 15:21:16 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> This adds support for 'proper' functions to the existing API.
> >> This inf
On 04/16/2018 08:01 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 16 Apr 2018 15:21:16 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> This adds support for 'proper' functions to the existing API.
>> This information was before only available through the new v2
>> API, with this change
--
I Mikhail Fridman. has selected you specially as one of my beneficiaries
for my Charitable Donation, Just as I have declared on May 23, 2016 to
give
my fortune as charity.
Check the link below for confirmation:
http://www.ibtimes.co.uk/russias-second-wealthiest-man-mikhail-fridman-plans-l
Hi Sam,
On 04/16/2018 05:26 AM, Hans Verkuil wrote:
On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote:
Can anyone verify if the OV5640 driver works with input clocks other
than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
is acceptable, but I am running into issues while bringin
Em Mon, 16 Apr 2018 15:21:13 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Just like struct v4l2_pix_format add a hsv_enc field to describe
> the HSV encoding. It is in a union with the ycbcr_enc, since it
> is one or the other.
>
> Signed-off-by: Hans Verkuil
> ---
> include/uapi/li
Em Mon, 16 Apr 2018 15:21:21 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Document the new struct media_v2_entity 'flags' field.
>
> Signed-off-by: Hans Verkuil
> ---
> Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 13 -
> 1 file changed, 12 insertions(+),
Em Mon, 16 Apr 2018 15:03:35 -0300
Mauro Carvalho Chehab escreveu:
> Em Mon, 16 Apr 2018 15:21:18 +0200
> Hans Verkuil escreveu:
>
> > From: Hans Verkuil
> >
> > The v2 pad structure never exposed the pad index, which made it impossible
> > to call the MEDIA_IOC_SETUP_LINK ioctl, which needs
Em Mon, 16 Apr 2018 15:21:19 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Document the new struct media_v2_pad 'index' field.
>
> Signed-off-by: Hans Verkuil
> ---
> Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 12 +++-
> 1 file changed, 11 insertions(+), 1 d
Em Mon, 16 Apr 2018 15:21:18 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> The v2 pad structure never exposed the pad index, which made it impossible
> to call the MEDIA_IOC_SETUP_LINK ioctl, which needs that information.
>
> It is really trivial to just expose this information, so imp
Em Mon, 16 Apr 2018 15:21:17 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Document the new struct media_entity_desc 'function' field.
See my comments to patch 4/9.
> Signed-off-by: Hans Verkuil
> ---
> .../uapi/mediactl/media-ioc-enum-entities.rst | 31
> +
Em Mon, 16 Apr 2018 15:21:16 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> This adds support for 'proper' functions to the existing API.
> This information was before only available through the new v2
> API, with this change it's available to both.
>
> Yes, the plan is to allow entitie
Em Mon, 16 Apr 2018 15:21:15 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> The __NEED_MEDIA_LEGACY_API define is 1) ugly and 2) dangerous
> since it is all too easy for drivers to define it to get hold of
> legacy defines. Instead just define what we need in media-device.c
> which is th
From: Daniel Scheller
The check for a valid ptr in ddb_io->dma isn't really necessary since only
devices that do data transport using DMA are supported by the driver, and
all previous initialisation code (through input_init(), output_init() and
dma_init(), has_dma is always true as it's set in dd
On Mon, Apr 16, 2018 at 10:16 AM, Philipp Zabel wrote:
> The second patch is applied now, but this part is still missing in
> v4.17-rc1, causing the CSI subdev probe to fail:
>
> imx-ipuv3-csi: probe of imx-ipuv3-csi.0 failed with error -1369528304
> imx-ipuv3-csi: probe of imx-ipuv3-csi.1 fa
When I started building media subsystem with the atomisp driver,
I ended by adding several hacks on their Makefiles, in order to
get rid of thousands of warnings. I felt a little guty of hiding how
broken is this driver, so I decided t remove two Makefile hacks that
affect sensors and fix the warni
It seems that, originally, the logic would allow selecting between
fine and coarse integration. However, only coarse seems to be
implemented.
Get rid of this warning:
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c: In function
'mt9m114_s_exposure':
drivers/staging/media/atomisp/i2c/atom
From: From: Gustavo A. R. Silva
Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe.
The proper pointer to be passed as argument is pinctrl
instead of priv->vdev.
This issue was detected with the help of Coccinelle.
Fixes: 52e17089d185 ("media: imx: Don't initialize vars that won't be used")
S
> >>> @@ -898,7 +899,8 @@ static int put_v4l2_ext_controls32(struct file *file,
> >>> if (ctrl_is_pointer(file, id))
> >>> size -= sizeof(ucontrols->value64);
> >>>
> >>> - if (copy_in_user(ucontrols, kcontrols, size))
> >>> + if (copy_in_user(ucontrols
The register settings for several resolutions aren't used
currently. So, comment them out.
Fix those warnings:
In file included from drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:35:0:
drivers/staging/media/atomisp/i2c/gc2235.h:340:32: warning:
'gc2235_960_640_30fps' defined but not used [-
There are lots of data structs defined there but aren't used
anywhere.
Comment them out. Gets rid of those warnings:
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c:1808:45: warning:
'mt9m114_entity_ops' defined but not used [-Wunused-const-variable=]
static const struct media_entity_operat
The code with uses the dummy var is commented out. So,
coment out its definition/initialization.
Fix this warning:
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c: In function
'gc2235_get_intg_factor':
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:249:26: warning: variable
'dummy' s
The identation for several tables there are broken.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/atomisp/i2c/ov2680.h | 895 ++---
1 file changed, 447 insertions(+), 448 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ov2680.h
b/drivers/sta
If something wrong gets there, return the error.
Get rid of this warning:
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c: In function 'gc0310_init':
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:713:6: warning: variable
'ret' set but not used [-Wunused-but-set-variable]
int ret;
There's no sense for a Kernel driver to have __KERNEL macros
on it.
Signed-off-by: Mauro Carvalho Chehab
---
.../css2400/css_2401_csi2p_system/host/system_local.h | 15 ---
.../css2400/hive_isp_css_common/host/system_local.h | 15 ---
.../atomisp2/css2400/hive_i
When atomisp got merged, there were so many warnings with W=1
that we simply disabled the ones that were causing troubles.
Since then, several changes got applied to atomisp, and the
number of warnings are a way smaller than it used to be.
So, let's reenable warnings there and fix the issues.
Si
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: In function
‘__ov2680_set_exposure’:
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:400:10: warning: variable
‘hts’ set but not used [-Wunused-but-set-variable]
u16 vts,hts;
^~~
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:
On 04/16/2018 05:11 PM, Mauro Carvalho Chehab wrote:
> In the past, "up" were an acronym for "user pointer" and "kp" for
> "kernel pointer". However, since a1dfb4c48cc1 ("media:
> v4l2-compat-ioctl32.c: refactor compat ioctl32 logic"), both
> are now __user pointers.
>
> So, the usage of "kp" is r
On 04/16/2018 04:50 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 16 Apr 2018 14:03:45 +0200
> Hans Verkuil escreveu:
>
>> On 04/13/2018 08:07 PM, Mauro Carvalho Chehab wrote:
>>> Smatch report several issues with bad __user annotations:
>>>
>>> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21
On 04/16/2018 04:27 PM, Geert Uytterhoeven wrote:
>> The image renderer, or the distortion correction engine, is a drawing
>> processor with a simple instruction system capable of referencing video
>> capture data or data in an external memory as the 2D texture data and
>> performing texture mappi
In the past, "up" were an acronym for "user pointer" and "kp" for
"kernel pointer". However, since a1dfb4c48cc1 ("media:
v4l2-compat-ioctl32.c: refactor compat ioctl32 logic"), both
are now __user pointers.
So, the usage of "kp" is really misleading there. So, rename
both to just "p32" and "p64" e
Hi Mauro,
These patches include the low latency changes, which do make IR more
responsive. These patches could breaks things in subtle ways, so it
would be great to have these changes in early in the cycle.
Thanks,
Sean
The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
From: Jason Chen
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
Signed-off-by: Alan Chiang
---
ince v2:
-- Update the streaming function to remove SW_STANDBY in the beginni
Em Mon, 16 Apr 2018 14:03:45 +0200
Hans Verkuil escreveu:
> On 04/13/2018 08:07 PM, Mauro Carvalho Chehab wrote:
> > Smatch report several issues with bad __user annotations:
> >
> > drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect
> > type in argument 1 (different add
On Mon, Apr 16, 2018 at 2:39 PM, Christoph Hellwig wrote:
> On Tue, Apr 03, 2018 at 08:08:32PM +0200, Daniel Vetter wrote:
>> I did not mean you should dma_map_sg/page. I just meant that using
>> dma_map_resource to fill only the dma address part of the sg table seems
>> perfectly sufficient.
>
>
Hi Sergei,
On Fri, Aug 4, 2017 at 8:03 PM, Sergei Shtylyov
wrote:
> The image renderer, or the distortion correction engine, is a drawing
> processor with a simple instruction system capable of referencing video
> capture data or data in an external memory as the 2D texture data and
> performing
From: Hans Verkuil
This adds support for 'proper' functions to the existing API.
This information was before only available through the new v2
API, with this change it's available to both.
Yes, the plan is to allow entities to expose multiple functions for
multi-function devices, but we do not s
From: Hans Verkuil
Document the new struct media_entity_desc 'function' field.
Signed-off-by: Hans Verkuil
---
.../uapi/mediactl/media-ioc-enum-entities.rst | 31 +-
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/Documentation/media/uapi/mediactl/media-
From: Hans Verkuil
The v2 pad structure never exposed the pad index, which made it impossible
to call the MEDIA_IOC_SETUP_LINK ioctl, which needs that information.
It is really trivial to just expose this information, so implement this.
Signed-off-by: Hans Verkuil
---
drivers/media/media-devi
From: Hans Verkuil
The v2 entity structure never exposed the entity flags, which made it
impossible to detect connector or default entities.
It is really trivial to just expose this information, so implement this.
Signed-off-by: Hans Verkuil
---
drivers/media/media-device.c | 1 +
include/uap
From: Hans Verkuil
Document the new struct media_v2_entity 'flags' field.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/Documentation/media/uapi/mediactl/media-ioc-g-t
From: Hans Verkuil
The __NEED_MEDIA_LEGACY_API define is 1) ugly and 2) dangerous
since it is all too easy for drivers to define it to get hold of
legacy defines. Instead just define what we need in media-device.c
which is the only place where we need the legacy define
(MEDIA_ENT_T_DEVNODE_UNKNOW
From: Hans Verkuil
Just like struct v4l2_pix_format add a hsv_enc field to describe
the HSV encoding. It is in a union with the ycbcr_enc, since it
is one or the other.
Signed-off-by: Hans Verkuil
---
include/uapi/linux/v4l2-mediabus.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(
From: Hans Verkuil
Document the new struct media_v2_pad 'index' field.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Documentation/media/uapi/mediactl/media-ioc-g-topol
From: Hans Verkuil
The ycbcr_enc, quantization and xfer_func fields are __u16 and not enums.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/v4l/subdev-formats.rst | 27 +++--
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/Documentation/media/uapi/v
From: Hans Verkuil
This patch series is a follow-up to these two v1 series:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg127943.html
https://www.mail-archive.com/linux-media@vger.kernel.org/msg127963.html
Some of those patches have been merged for 4.17, so this v2 contains
the re
Hi,
On Sat, 2018-03-03 at 09:56 -0300, Fabio Estevam wrote:
> From: Gustavo A. R. Silva
>
> Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe.
> The proper pointer to be passed as argument is pinctrl
> instead of priv->vdev.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes
On Sun, 2018-04-15 at 18:39 -0700, Samuel Bobrowicz wrote:
> Can anyone verify if the OV5640 driver works with input clocks other
> than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
> is acceptable, but I am running into issues while bringing up a module
> that uses a 12MHz oscil
Hi Niklas,
On Mon, Apr 16, 2018 at 01:16:35AM +0200, Niklas Söderlund wrote:
> Hi Jacopo,
>
> Thanks for your feedback.
>
> Comments I have snipped out from this reply are addressed, thanks for
> bringing them to my attention!
>
> On 2018-04-05 11:10:01 +0200, Jacopo Mondi wrote:
>
> [snip]
>
> >
On Tue, Apr 03, 2018 at 08:08:32PM +0200, Daniel Vetter wrote:
> I did not mean you should dma_map_sg/page. I just meant that using
> dma_map_resource to fill only the dma address part of the sg table seems
> perfectly sufficient.
But that is not how the interface work, especially facing sg_dma_le
The clock rate, while hardcoded until now, is actually a function of the
resolution, framerate and bytes per pixel. Now that we have an algorithm to
adjust our clock rate, we can select it dynamically when we change the
mode.
This changes a bit the clock rate being used, with the following effect:
Now that we have everything in place to compute the clock rate at runtime,
we can enable the 60fps framerate for the mode we tested it with.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 33 +
1 file changed, 25 insertions(+), 8 deletions(-)
diff
The active frame size is set in the initialization arrays, but the value
itself is also available in the struct ov5640_mode_info.
Let's move these values out of the big bytes arrays, and program it with
the value of the mode that we are given.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/
The clock structure for the PCLK is quite obscure in the documentation, and
was hardcoded through the bytes array of each and every mode.
This is troublesome, since we cannot adjust it at runtime based on other
parameters (such as the number of bytes per pixel), and we can't support
either framera
The SCLK and SCLK2X dividers are fixed in stone in the initialization
array. Let's make explicit what we're doing and move that away from the
huge array to the initialization code.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 11 ++-
1 file changed, 10 insertions(+), 1 d
The autoexposure setup in the 1080p init array is redundant with the
default value of the sensor.
Remove it.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
in
Hi,
Here is a "small" series that mostly cleans up the ov5640 driver code,
slowly getting rid of the big data array for more understandable code
(hopefully).
The biggest addition would be the clock rate computation at runtime,
instead of relying on those arrays to setup the clock tree
properly. A
The current width and height parameters in the struct ov5640_mode_info are
actually the active horizontal and vertical resolutions.
Since we're going to add a few other parameters, let's pick a better, more
precise name for these values.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640
From: Mylène Josserand
Add the light frequency control to be able to set the frequency
to manual (50Hz or 60Hz) or auto.
Signed-off-by: Mylène Josserand
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 24
1 file changed, 24 insertions(+)
diff --git a/dr
From: Mylène Josserand
Add the auto-focus ENABLE/DISABLE feature as V4L2 control.
Disabled by default.
Signed-off-by: Mylène Josserand
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/media
Now that we have moved the clock generation logic out of the bytes array,
these arrays are identical between the 15fps and 30fps variants.
Remove the duplicate entries, and convert the code accordingly.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 316 +++---
The sensor needs to have the auto exposure stopped while changing mode.
However, when the new mode is set, the driver will force the auto exposure
on, disregarding whether the control has been changed or not.
Bypass the controls code entirely to do that, and only use the control
value cached when
All the initialization arrays are changing the horizontal and vertical
totals for some value.
In order to clean up the driver, and since we're going to need that value
later on, let's introduce in the ov5640_mode_info structure the horizontal
and vertical total sizes, and move these out of the byt
On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote:
> Can anyone verify if the OV5640 driver works with input clocks other
> than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
> is acceptable, but I am running into issues while bringing up a module
> that uses a 12MHz oscillator. I'd
On 04/14/2018 03:18 AM, Jasmin J. wrote:
> Hello Mauro/Hans!
>
>> There is already an upstream patch for hidding it:
> The patch from https://patchwork.kernel.org/patch/10334353 will not
> apply at the smatch tree.
>
> Attached is an updated version for smatch.
>
> Even with the patched tools, s
Ok, confusion around backend is I think cleared up. The other
confusion seems to be around dma-buf:
dma-buf is the cross subsystem zerocopy abstraction. PRIME is the
drm-specific support for it, 100% based on top of the generic struct
dma_buf.
You need a dma_buf exporter to convert a xen grant re
On 04/13/2018 08:07 PM, Mauro Carvalho Chehab wrote:
> Smatch report several issues with bad __user annotations:
>
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect
> type in argument 1 (different address spaces)
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21:
Hi Akinobu,
On Mon, Apr 16, 2018 at 11:51:44AM +0900, Akinobu Mita wrote:
> Set the V4L2_SUBDEV_FL_HAS_DEVNODE flag for the subdevice so that the
> subdevice device node is created.
>
> Cc: Jacopo Mondi
> Cc: Laurent Pinchart
> Cc: Hans Verkuil
> Cc: Sakari Ailus
> Cc: Mauro Carvalho Chehab
Hi Akinobu,
As the driver now offers a V4L2 sub-device uAPI, it needs to serialise
access to its internal data structures. This appears to be fine, but there
are additional requirements; for instance ov772x_select_params() should
likely fail if you're streaming.
On Mon, Apr 16, 2018 at 11:51:51AM
The mmu_private.h header is included at mmu.c, with duplicates the
already existing definitions at mmu_public.h.
Fix this by removing the erroneous header file.
Solve those issues:
drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h:24:26:
warning: fun
On 04/16/2018 12:32 PM, Daniel Vetter wrote:
On Mon, Apr 16, 2018 at 10:22 AM, Oleksandr Andrushchenko
wrote:
On 04/16/2018 10:43 AM, Daniel Vetter wrote:
On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote:
On 04/13/2018 06:37 PM, Daniel Vetter wrote:
On Wed, Apr 11, 201
Pull request of the 'rcar-vin: Add Gen3 with media controller' v14 patch series.
Regards,
Hans
The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)
are available in the Git repository at:
git://linuxtv.org/hverkuil
Em Sat, 14 Apr 2018 01:31:34 +0200
"Jasmin J." escreveu:
> From: Jasmin Jessich
>
> This reverts 8b0e195314fa, because this will not compile for Kernels
> older than 4.10.
This patch looks fine, but not for the above-mentioned.
The thing is that it is not consistent to have some places with
t
On Mon, Apr 16, 2018 at 04:30:46AM +, Tomasz Figa wrote:
> On Thu, Apr 12, 2018 at 6:57 PM Sakari Ailus
> wrote:
>
> > Hi Jacopo,
>
> > On Thu, Apr 12, 2018 at 10:57:01AM +0200, jacopo mondi wrote:
> > ...
> > > > + if (MAX_RETRY == ++retry) {
> > > > + dev_err(&c
On Mon, Apr 16, 2018 at 10:22 AM, Oleksandr Andrushchenko
wrote:
> On 04/16/2018 10:43 AM, Daniel Vetter wrote:
>>
>> On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote:
>>>
>>> On 04/13/2018 06:37 PM, Daniel Vetter wrote:
On Wed, Apr 11, 2018 at 08:59:32AM +0300, Ol
Hello,
I'm currently working with a RPI 3 in 64 bit os.
I have the issue that the image captured is cropped. I don't know
where it comes from but I'm exploring all possibilities. Note that it
works perfectly on a 32 bits os with same versions of v4l, kernel,
libc and everything. The system is gene
On Mon, 2018-04-16 at 09:54 +0200, Ibtsam Ul-Haq wrote:
[...]
> This indeed looks the case. But then, is 'GR16' the FourCC for 'SGRBG16'?
Yes, see Documentation/media/uapi/v4l/pixfmt-srggb16.rst:
https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/pixfmt-srggb16.html
> To be honest, I had not
Hi Niklas,
On Sun, Apr 15, 2018 at 10:47:37PM +0200, Niklas Söderlund wrote:
> Hi Sakari,
>
> Thanks for your feedback.
>
> On 2018-04-04 23:13:57 +0300, Sakari Ailus wrote:
>
> [snip]
>
> > > > + pm_runtime_enable(&pdev->dev);
> > >
> > > Is CONFIG_PM mandatory on Renesas SoCs? If not,
1 - 100 of 108 matches
Mail list logo