Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-24 Thread Christoph Hellwig
On Tue, Apr 24, 2018 at 09:32:20PM +0200, Daniel Vetter wrote: > Out of curiosity, how much virtual flushing stuff is there still out > there? At least in drm we've pretty much ignore this, and seem to be > getting away without a huge uproar (at least from driver developers > and users, core folks

cron job: media_tree daily build: ERRORS

2018-04-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Apr 25 05:00:10 CEST 2018 media-tree git hash:a2b2eff6ac2716f499defa590a6ec4ba379d765e media_build

RE: [RESEND PATCH v7 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-04-24 Thread Yeh, Andy
Hi Rob, Apologize missed your comment before sent out v8. I will definitely add acks/reviewed-bys in next version. Regards, Andy -Original Message- From: Rob Herring [mailto:r...@kernel.org] Sent: Friday, April 13, 2018 11:11 PM To: Yeh, Andy Cc:

RE: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-24 Thread Yeh, Andy
Hi Jocopo, Tomasz, Thanks for your comments. Resend patches to https://patchwork.linuxtv.org/patch/49029/ Most of the comments are addressed. However some remain no change based on the discussion with Sakari and Tomasz. Posted as below. > if (MAX_RETRY == ++retry) { >

[RESEND PATCH v8 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-24 Thread Andy Yeh
From: Alan Chiang DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Signed-off-by: Andy Yeh --- since v1: - changed author.

[RESEND PATCH v8 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-04-24 Thread Andy Yeh
From: Alan Chiang Dongwoon DW9807 is a voice coil lens driver. Signed-off-by: Andy Yeh --- Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 + 1 file changed, 9 insertions(+) create mode 100644

[RESEND PATCH v8 0/2] DW9807 DT binding and driver patches

2018-04-24 Thread Andy Yeh
Hi Sakari and Tomasz, The two patches are the DT binding and driver for DW9807 VCM controller. Alan Chiang (2): media: dw9807: Add dw9807 vcm driver media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil .../bindings/media/i2c/dongwoon,dw9807.txt | 9 + MAINTAINERS

[GIT FIXES FOR v4.17] UVC fixes

2018-04-24 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:

Re: a 4.16 kernel with Debian 9.4 "stretch" causes a log explosion

2018-04-24 Thread Laurent Pinchart
Hi Guennadi, On Wednesday, 11 April 2018 22:33:43 EEST Guennadi Liakhovetski wrote: > On Wed, 11 Apr 2018, Kieran Bingham wrote: > > On 11/04/18 18:06, Guennadi Liakhovetski wrote: > > > > > > Just figured out this commit > > > > From: Edgar Thier > >

Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to component

2018-04-24 Thread Kuninori Morimoto
Hi Tim, Mark > >> Could you add some detail to the commit explaining why we need to > >> replace codec to component? I don't really know what that means. > >> Please refer to a commit if the ASoC API is changing in some way we > >> need to catch up with. > > > > This is a big transition in the

[PATCH] rcar-vin: enable field toggle after a set number of lines for Gen3

2018-04-24 Thread Niklas Söderlund
The VIN Gen3 hardware don't have Line Post-Clip capabilities as VIN Gen2 hardware have. To protect against writing outside the capture window enable field toggle after a set number of lines have been captured. Capturing outside the allocated capture buffer where observed on R-Car Gen3 Salvator-XS

[PATCH] rcar-vin: add support for MEDIA_BUS_FMT_UYVY8_1X16

2018-04-24 Thread Niklas Söderlund
By setting VNMC_YCAL rcar-vin can support input video in MEDIA_BUS_FMT_UYVY8_1X16 format. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 1 + drivers/media/platform/rcar-vin/rcar-dma.c | 5 + 2 files changed, 6

[PATCH] rcar-vin: fix null pointer dereference in rvin_group_get()

2018-04-24 Thread Niklas Söderlund
Store the group pointer before disassociating the VIN from the group. Fixes: 3bb4c3bc85bf77a7 ("media: rcar-vin: add group allocator functions") Reported-by: Colin Ian King Signed-off-by: Niklas Söderlund ---

[PATCH] rcar-vin: remove generic gen3 compatible string

2018-04-24 Thread Niklas Söderlund
The compatible string "renesas,rcar-gen3-vin" was added before the Gen3 driver code was added but it's not possible to use. Each SoC in the Gen3 series require SoC specific knowledge in the driver to function. Remove it before it is added to any device tree descriptions. Signed-off-by: Niklas

Re: [PATCH] media: i2c: adv748x: Fix pixel rate values

2018-04-24 Thread Niklas Söderlund
Hi Laurent, Thanks for your patch. On 2018-04-21 15:44:44 +0300, Laurent Pinchart wrote: > The pixel rate, as reported by the V4L2_CID_PIXEL_RATE control, must > include both horizontal and vertical blanking. Both the AFE and HDMI > receiver program it incorrectly: > > - The HDMI receiver goes

[PATCH] cx88: Get rid of spurious call to cx8800_start_vbi_dma()

2018-04-24 Thread Devin Heitmueller
This was left over from the conversion to VB2, where the call was getting invoked both in buffer_queue and start_streaming, which was intermittently causing invalid opcodes on the VBI RISC queue. This change effectively mirrors the exact same change Hans Verkuil made in cx88-video.c in

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-04-24 Thread Sam Bobrowicz
FYI, still hard at work on this. Did some more experiments last week that seemed to corroborate the clock tree in the spreadsheet. It also seems that the output of the P divider cell, SCLK cell and MIPI Rate cell in the spreadsheet must have a ratio of 2x:1x:8x (respectively) in order for the

[PATCH] media: zoran: move to dma-mapping interface

2018-04-24 Thread Arnd Bergmann
No drivers should use virt_to_bus() any more. This converts one of the few remaining ones to the DMA mapping interface. Signed-off-by: Arnd Bergmann --- drivers/media/pci/zoran/Kconfig| 2 +- drivers/media/pci/zoran/zoran.h| 10 +--

Re: [PATCH v2 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-04-24 Thread Maxime Ripard
Hi Sakari, On Tue, Apr 24, 2018 at 10:21:47AM +0300, Sakari Ailus wrote: > > /* download ov5640 settings to sensor through i2c */ > > static int ov5640_load_regs(struct ov5640_dev *sensor, > > const struct ov5640_mode_info *mode) > > @@ -1620,6 +1830,14 @@ static int

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2018 at 8:48 PM, Christoph Hellwig wrote: > On Fri, Apr 20, 2018 at 05:21:11PM +0200, Daniel Vetter wrote: >> > At the very lowest level they will need to be handled differently for >> > many architectures, the questions is at what point we'll do the >> >

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-24 Thread Christoph Hellwig
On Fri, Apr 20, 2018 at 05:21:11PM +0200, Daniel Vetter wrote: > > At the very lowest level they will need to be handled differently for > > many architectures, the questions is at what point we'll do the > > branching out. > > Having at least struct page also in that list with (dma_addr_t,

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-04-24 Thread Peter Zijlstra
On Tue, Apr 24, 2018 at 02:47:55PM -0300, Mauro Carvalho Chehab wrote: > So, I'm wondering if are there any way to mitigate it inside the > core itself, instead of doing it on every driver, e. g. changing > v4l_enum_fmt() implementation at v4l2-ioctl. > > Ok, a "poor man" approach would be to

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-04-24 Thread Mauro Carvalho Chehab
Em Tue, 24 Apr 2018 12:36:09 +0200 Peter Zijlstra escreveu: > On Tue, Apr 24, 2018 at 12:35:00PM +0300, Dan Carpenter wrote: > > On Mon, Apr 23, 2018 at 03:24:55PM -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 23 Apr 2018 12:38:03 -0500 > > > "Gustavo A. R. Silva"

Re: [PATCH v2 09/13] media: imx274: get rid of mode_index

2018-04-24 Thread kbuild test robot
Hi Luca, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH] media: mxl5xx: fix get_algo()'s return type

2018-04-24 Thread Daniel Scheller
Am Tue, 24 Apr 2018 15:19:31 +0200 schrieb Luc Van Oostenryck : > The method dvb_frontend_ops::get_frontend_algo() is defined as > returning an 'enum dvbfe_algo', but the implementation in this > driver returns an 'int'. > > Fix this by returning 'enum dvbfe_algo' in

Re: [PATCH] media: stv0910: fix get_algo()'s return type

2018-04-24 Thread Daniel Scheller
Am Tue, 24 Apr 2018 15:19:38 +0200 schrieb Luc Van Oostenryck : > The method dvb_frontend_ops::get_frontend_algo() is defined as > returning an 'enum dvbfe_algo', but the implementation in this > driver returns an 'int'. > > Fix this by returning 'enum dvbfe_algo' in

Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property

2018-04-24 Thread Rob Herring
On Thu, Apr 19, 2018 at 11:31:03AM +0200, Jacopo Mondi wrote: > The THC63LVD1024 LVDS to RGB bridge supports two different input mapping > modes, selectable by means of an external pin. > > Describe the LVDS mode map through a newly defined mandatory property in > device tree bindings. > >

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

2018-04-24 Thread Rui Miguel Silva
Hi Fabio, On Tue 24 Apr 2018 at 15:53, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

2018-04-24 Thread Fabio Estevam
Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: > Add device tree binding documentation for the OV2680 camera sensor. > > Reviewed-by: Rob Herring > CC: devicet...@vger.kernel.org > Signed-off-by: Rui Miguel Silva >

[PATCH v3 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-24 Thread Todor Tomov
The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image Sensor from Omnivision. The driver supports the following modes: - 640x480 30fps - 640x480 60fps - 640x480 90fps Output format is 10bit B RAW - MEDIA_BUS_FMT_Y10_1X10. The driver supports configuration via user controls for: -

[PATCH v3 0/2] Add support for ov7251 camera sensor

2018-04-24 Thread Todor Tomov
The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image Sensor from Omnivision. -- Version 3: - DT binding: added that there shall be a single endpoint node in the port node; - added a comment for regulator

[PATCH v3 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-04-24 Thread Todor Tomov
Add the document for ov7251 device tree binding. CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Reviewed-by: Rob Herring ---

Re: [PATCH v2 13/13] media: imx274: add SELECTION support for cropping

2018-04-24 Thread Luca Ceresoli
Hi Sakari, On 24/04/2018 11:59, Sakari Ailus wrote: > Hi Luca, > > Thank you for the patchset. > > Some comments below... what I propose is that I apply the rest of the > patches and then the comments to this one could be addressed separately. > Would that work for you? Yes, but I suggest you

[PATCH] media: dvb_net: fix dvb_net_tx()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH v11 3/4] dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings

2018-04-24 Thread Benoit Parrot
Acked-by: Benoit Parrot Maxime Ripard wrote on Tue [2018-Apr-24 14:26:59 +0200]: > The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4 > video streams and can output on up to 4 CSI-2 lanes, depending on the > hardware

[PATCH] media: lgdt3306a: fix lgdt3306a_search()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::search() is defined as returning an 'enum dvbfe_search', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_search' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: cx24117: fix cx24117_get_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: cx24116: fix cx24116_get_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH v11 4/4] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-04-24 Thread Benoit Parrot
Acked-by: Benoit Parrot Maxime Ripard wrote on Tue [2018-Apr-24 14:27:00 +0200]: > The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used > as a bridge between pixel interfaces and a CSI-2 bus. > > It supports operating with an

[PATCH] media: cx24123: fix cx24123_get_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: mb86a20s: fix mb86a20s_get_frontend_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: mxl5xx: fix get_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: s921: fix s921_get_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH v11 2/4] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-04-24 Thread Benoit Parrot
Maxime Ripard wrote on Tue [2018-Apr-24 14:26:58 +0200]: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or external D-PHY, with up to 4 lanes, > or

[PATCH] media: bt8xx: fix dst_get_tuning_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: stv0910: fix get_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: fix va1j5jf8007t_get_frontend_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: fix va1j5jf8007s_get_frontend_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: cxd2820r: fix cxd2820r_get_frontend_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] media: cx24120: fix cx24120_get_algo()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method dvb_frontend_ops::get_frontend_algo() is defined as returning an 'enum dvbfe_algo', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_algo' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] remove 2 excess lines in driver module em28xx

2018-04-24 Thread mjs
From 5103cc546075de0eb800f5a76f3212a3e342b833 Mon Sep 17 00:00:00 2001 From: Marcel Stork Date: Tue, 24 Apr 2018 14:43:01 +0200 Subject: [PATCH] remove 2 excess lines in driver module em28xx A cosmetic change by combining two sets of boards into one set because having the

[PATCH][next] media: ispstat: don't dereference user_cfg before a null check

2018-04-24 Thread Colin King
From: Colin Ian King The pointer user_cfg (a copy of new_conf) is dereference before new_conf is null checked, hence we may have a null pointer dereference on user_cfg when assigning buf_size from user_cfg->buf_size. Ensure this does not occur by moving the assignment

Re: [DE] Re: [CN] Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-04-24 Thread Philipp Zabel
Hi Javier, On Mon, 2018-04-23 at 11:29 +0200, Javier Martin wrote: > Sorry for resurrecting this thread but I'm still quite interested on > making this scenario work: > > > OK, I've performed some tests with several resolutions and gop sizes, > here is the table with the results: > > > >

[PATCH 01/28] venus: hfi_msgs: correct pointer increment

2018-04-24 Thread Stanimir Varbanov
Data pointer should be incremented by size of the structure not the size of a pointer, correct the mistake. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/28] venus: hfi: update sequence event to handle more properties

2018-04-24 Thread Stanimir Varbanov
HFI version 4xx can pass more properties in the sequence change event, extend the event structure with them. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.h | 9 ++ drivers/media/platform/qcom/venus/hfi_msgs.c | 46

[PATCH 02/28] venus: hfi: preparation to support venus 4xx

2018-04-24 Thread Stanimir Varbanov
This covers the differences between 1xx,3xx and 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 4 ++ drivers/media/platform/qcom/venus/helpers.c | 37 +++ drivers/media/platform/qcom/venus/hfi_helper.h |

[PATCH 05/28] venus: hfi: support session continue for 4xx version

2018-04-24 Thread Stanimir Varbanov
This makes possible to handle session_continue for 4xx as well. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi.c

[PATCH 06/28] venus: hfi: handle buffer output2 type as well

2018-04-24 Thread Stanimir Varbanov
This adds handling of buffers of type OUTPUT2 which is needed to support Venus 4xx version. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi.c | 3 ++- drivers/media/platform/qcom/venus/hfi_msgs.c | 3 ++- 2 files changed, 4

[PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

2018-04-24 Thread Stanimir Varbanov
This adds suspend (power collapse) function with slightly different order of calls comparing with Venus 3xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 52 +++ 1 file changed, 52 insertions(+) diff

[PATCH 07/28] venus: hfi_venus: add halt AXI support for Venus 4xx

2018-04-24 Thread Stanimir Varbanov
Add AXI halt support for version 4xx by using venus wrapper registers. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH 09/28] venus: venc,vdec: adds clocks needed for venus 4xx

2018-04-24 Thread Stanimir Varbanov
This extends the clocks number to support suspend and resume on Venus version 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 4 +-- drivers/media/platform/qcom/venus/vdec.c | 42 ++--

[PATCH 11/28] venus: add common capability parser

2018-04-24 Thread Stanimir Varbanov
This adds common capability parser for all supported Venus versions. Having it will help to enumerate better the supported raw formars and codecs and also the capabilities for every codec like max/min width/height, framerate, bitrate and so on. Signed-off-by: Stanimir Varbanov

[PATCH 10/28] venus: vdec: call session_continue in insufficient event

2018-04-24 Thread Stanimir Varbanov
Call session_continue for Venus 4xx version even when the event says that the buffer resources are not sufficient. Leaving a comment with more information about the workaround. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec.c | 8

[PATCH 04/28] venus: hfi_cmds: add set_properties for 4xx version

2018-04-24 Thread Stanimir Varbanov
Adds set_properties method to handle newer 4xx properties and fall-back to 3xx for the rest. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_cmds.c | 64 +++- 1 file changed, 63 insertions(+), 1 deletion(-) diff

[PATCH 21/28] venus: helpers: extend set_num_bufs helper with one more argument

2018-04-24 Thread Stanimir Varbanov
Extend venus_helper_set_num_bufs() helper function with one more argument to set number of output buffers for the secondary decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 16 ++--

[PATCH 12/28] venus: helpers: make a commmon function for power_enable

2018-04-24 Thread Stanimir Varbanov
Make common function which will enable power when enabling/disabling clocks and also covers Venus 3xx/4xx versions. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 51 +

[PATCH 19/28] venus: helpers: add a new helper to set raw format

2018-04-24 Thread Stanimir Varbanov
The new helper will has one more argument for buffer type, that way the decoder can configure the format on it's secondary output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 52 ++---

[PATCH 18/28] venus: helpers: add buffer type argument to a helper

2018-04-24 Thread Stanimir Varbanov
This adds one more function argument to pass buffer type to set_output_resolution() helper function. That is a preparation to support secondary decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 5 +++--

[PATCH] omap3isp: ispstat: fix potential NULL pointer dereference

2018-04-24 Thread Gustavo A. R. Silva
new_conf is indirectly dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after new_conf has been properly null checked. Addresses-Coverity-ID: 1468386 ("Dereference before null check") Signed-off-by: Gustavo A.

[PATCH 17/28] venus: delete no longer used bufmode flag from instance

2018-04-24 Thread Stanimir Varbanov
Delete no longer used flag cap_bufs_mode_dynamic from instance structure. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 -- drivers/media/platform/qcom/venus/hfi_parser.c | 6 +- 2 files changed, 1 insertion(+), 7

[PATCH 15/28] venus: add a helper function to set dynamic buffer mode

2018-04-24 Thread Stanimir Varbanov
Adds a new helper function to set dymaic buffer mode if it is supported by current HFI version. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 22 ++ drivers/media/platform/qcom/venus/helpers.h | 1 +

[PATCH 14/28] venus: helpers: rename a helper function and use buffer mode from caps

2018-04-24 Thread Stanimir Varbanov
Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and use buffer mode from enumerated per codec capabilities. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 21 +++-- 1 file changed, 11

[PATCH 13/28] venus: core: delete not used flag for buffer mode

2018-04-24 Thread Stanimir Varbanov
Delete not used flag for capture buffer allocation mode. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.h

Re: [PATCH v2 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-24 Thread Todor Tomov
Hi Sakari, On 17.04.2018 23:10, Sakari Ailus wrote: > Hi Todor, > > On Tue, Apr 17, 2018 at 06:32:07PM +0300, Todor Tomov wrote: > ... +static int ov7251_regulators_enable(struct ov7251 *ov7251) +{ + int ret; + + ret = regulator_enable(ov7251->io_regulator); >>> >>>

[PATCH 27/28] venus: add sdm845 compatible and resource data

2018-04-24 Thread Stanimir Varbanov
This adds sdm845 DT compatible string with it's resource data table. Cc: devicet...@vger.kernel.org Signed-off-by: Stanimir Varbanov --- .../devicetree/bindings/media/qcom,venus.txt | 1 + drivers/media/platform/qcom/venus/core.c | 22

[PATCH 20/28] venus: helpers,vdec,venc: add helpers to set work mode and core usage

2018-04-24 Thread Stanimir Varbanov
These are new properties applicable to Venus version 4xx. Add the helpers and call them from decoder and encoder drivers. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 28

[PATCH 26/28] venus: implementing multi-stream support

2018-04-24 Thread Stanimir Varbanov
This is implementing a multi-stream decoder support. The multi stream gives an option to use the secondary decoder output with different raw format (or the same in case of crop). Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 1

[PATCH 23/28] venus: vdec: get required input buffers as well

2018-04-24 Thread Stanimir Varbanov
Rework and rename vdec_cap_num_buffers() to get the number of input buffers too. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/vdec.c | 41 +++- 1 file changed, 24 insertions(+), 17 deletions(-) diff --git

[PATCH 22/28] venus: helpers: add a helper to return opb buffer sizes

2018-04-24 Thread Stanimir Varbanov
Add a helper function to return current output picture buffer size. OPB sizes can vary depending on the selected decoder output(s). Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 10 ++

[PATCH 24/28] venus: vdec: new function for output configuration

2018-04-24 Thread Stanimir Varbanov
Make a new function vdec_output_conf() for decoder output configuration. vdec_output_conf() will set properties via HFI interface related to the output configuration, and keep vdec_set_properties() which will set properties related to decoding parameters. Signed-off-by: Stanimir Varbanov

[PATCH 25/28] venus: move frame size calculations in common place

2018-04-24 Thread Stanimir Varbanov
move calculations of raw and compressed in a common helper and make it identical for encoder and decoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 98 +

[PATCH 28/28] venus: add HEVC codec support

2018-04-24 Thread Stanimir Varbanov
This add HEVC codec support for venus versions 3xx and 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 3 +++ drivers/media/platform/qcom/venus/hfi.c | 2 ++ drivers/media/platform/qcom/venus/vdec.c| 4

[PATCH 16/28] venus: add helper function to set actual buffer size

2018-04-24 Thread Stanimir Varbanov
Add and use a helper function to set actual buffer size for particular buffer type. This is also preparation to use the second decoder output. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 12

[PATCH 00/28] Venus updates

2018-04-24 Thread Stanimir Varbanov
Hello, This patch set aims to: * add initial support for Venus version 4xx (found on sdm845). * introduce a common capability parser to enumerate better supported uncompressed formats, capabilities by codec, supported codecs and so on. * also contains various cleanups, readability

[PATCH v11 3/4] dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings

2018-04-24 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4 video streams and can output on up to 4 CSI-2 lanes, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

[PATCH v11 4/4] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-04-24 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used as a bridge between pixel interfaces and a CSI-2 bus. It supports operating with an internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the latter case. While the virtual

[PATCH v11 1/4] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2018-04-24 Thread Maxime Ripard
The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

[PATCH v11 0/4] media: v4l: Add support for the Cadence MIPI-CSI2 TX controller

2018-04-24 Thread Maxime Ripard
Hi, Here is a hopefully final attempt at supporting the MIPI-CSI2 RX and TX blocks from Cadence. This is a merged serie of the CSI2-RX and CSI2-TX series I've been sending for a while now and gathered a significant amount of Reviewed-by/Acked-by. The merge has been done thanks to Sakari's

[PATCH v11 2/4] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-04-24 Thread Maxime Ripard
The Cadence CSI-2 RX Controller is an hardware block meant to be used as a bridge between a CSI-2 bus and pixel grabbers. It supports operating with internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the latter case. It also support dynamic

Re: [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

2018-04-24 Thread Daniel Mack
Hi, On Tuesday, April 24, 2018 12:22 PM, Sakari Ailus wrote: > On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote: >> Add v4l2 controls to report the pixel and MIPI link rates of each mode. >> The camss camera subsystem needs them to set up the correct hardware >> clocks. >> >> Tested on

Re: [PATCH v2 02/12] media: ov5640: Add light frequency control

2018-04-24 Thread Sakari Ailus
On Fri, Apr 20, 2018 at 09:04:10PM +0200, Maxime Ripard wrote: > Hi Laurent, > > On Thu, Apr 19, 2018 at 12:44:18PM +0300, Laurent Pinchart wrote: > > On Monday, 16 April 2018 15:36:51 EEST Maxime Ripard wrote: > > > From: Mylène Josserand > > > > > > Add the light

Re: [RESEND PATCH 1/1] ov5640: Use dev_fwnode() to obtain device's fwnode

2018-04-24 Thread Maxime Ripard
On Tue, Apr 24, 2018 at 02:10:29PM +0300, Sakari Ailus wrote: > Use dev_fwnode() on the device instead of getting an fwnode handle of the > device's OF node. The result is the same on OF-based systems and looks > better, too. > > Signed-off-by: Sakari Ailus

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-04-24 Thread Peter Zijlstra
On Tue, Apr 24, 2018 at 12:36:09PM +0200, Peter Zijlstra wrote: > > Then usespace probes which part of the descr[] array is now in cache and > from that it can infer the initial out-of-bound value. Just had a better look at v4l_fill_fmtdesc() and actually read the comment. The code cannot be

[RESEND PATCH 1/1] ov5640: Use dev_fwnode() to obtain device's fwnode

2018-04-24 Thread Sakari Ailus
Use dev_fwnode() on the device instead of getting an fwnode handle of the device's OF node. The result is the same on OF-based systems and looks better, too. Signed-off-by: Sakari Ailus --- Fixed Maxime's e-mail. drivers/media/i2c/ov5640.c | 4 ++-- 1 file

Re: [RESEND PATCH] media: i2c: ov5640: Add pixel clock support

2018-04-24 Thread Loic Poulain
Hi Sakari, >> Any comments on this change? > > > > There's also another set that adds PIXEL_CLOCK (as well as LINK_FREQ) > support to the driver, that seems more complete than this patch but > requires

Re: [PATCH] staging: media: use relevant lock

2018-04-24 Thread Kieran Bingham
Hi Julia Thank you for the patch. On 03/08/17 13:26, Julia Lawall wrote: > The data protected is video_out2 and the lock that is released is > _out2->dma_queue_lock, so it seems that that lock should be > taken as well. I agree - this certainly looks like there was a copy/paste error perhaps

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-04-24 Thread Peter Zijlstra
On Tue, Apr 24, 2018 at 12:35:00PM +0300, Dan Carpenter wrote: > On Mon, Apr 23, 2018 at 03:24:55PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 23 Apr 2018 12:38:03 -0500 > > "Gustavo A. R. Silva" escreveu: > > > @@ -875,6 +876,7 @@ static int

Re: [RESEND PATCH] media: i2c: ov5640: Add pixel clock support

2018-04-24 Thread Sakari Ailus
On Tue, Apr 24, 2018 at 11:01:18AM +0200, Loic Poulain wrote: > On 29 March 2018 at 16:55, Manivannan Sadhasivam > wrote: > > Some of the camera subsystems like camss in Qualcommm MSM chipsets > > require pixel clock support in camera sensor drivers. So, this

Re: [PATCH 1/1] media: rc: Add NVIDIA IR keymapping

2018-04-24 Thread Sean Young
On Fri, Apr 20, 2018 at 11:47:47AM -0700, Vladislav Zhurba wrote: > From: Jun Yan > > Add keymap with NEC and SONY12 protocol for NVIDIA IR > > Signed-off-by: Jun Yan > Signed-off-by: marting > Signed-off-by: Daniel Fu

[PATCH 1/1] ov5640: Use dev_fwnode() to obtain device's fwnode

2018-04-24 Thread Sakari Ailus
Use dev_fwnode() on the device instead of getting an fwnode handle of the device's OF node. The result is the same on OF-based systems and looks better, too. Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov5640.c | 4 ++-- 1 file changed, 2 insertions(+), 2

  1   2   >