cron job: media_tree daily build: OK

2018-05-01 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed May 2 05:00:12 CEST 2018 media-tree git hash:a2b2eff6ac2716f499defa590a6ec4ba379d765e media_build

RE: [PATCH v4 09/10] v4l: xilinx: dma: Add multi-planar support

2018-05-01 Thread Satish Kumar Nagireddy
Hi Hyun, Thanks for the review. > -Original Message- > From: Hyun Kwon [mailto:hyun.k...@xilinx.com] > Sent: Tuesday, May 01, 2018 2:25 PM > To: Satish Kumar Nagireddy > Cc: linux-media@vger.kernel.org; laurent.pinch...@ideasonboard.com; > michal.si...@xilinx.com;

RE: [PATCH v4 09/10] v4l: xilinx: dma: Add multi-planar support

2018-05-01 Thread Satish Kumar Nagireddy
Hi Ian, Thanks for the review. > -Original Message- > From: Ian Arkver [mailto:ian.arkver@gmail.com] > Sent: Monday, April 30, 2018 11:44 PM > To: Satish Kumar Nagireddy ; linux- > me...@vger.kernel.org; laurent.pinch...@ideasonboard.com; >

Re: [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent

2018-05-01 Thread Stephen Boyd
Quoting Rui Miguel Silva (2018-04-23 06:47:38) > Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a > orphan > clock and set the correct parent. > > before: > cat clk_orphan_summary > enable prepare protect >clock

Re: [PATCH v4 10/10] v4l: xilinx: dma: Add support for 10 bit formats

2018-05-01 Thread Hyun Kwon
Hi Satish, Thanks for that patch. On Mon, 2018-04-30 at 18:35:13 -0700, Satish Kumar Nagireddy wrote: > This patch adds xvip_format_plane_width_bytes function to > calculate number of bytes for a macropixel formats and also > adds new 10 bit pixel formats to video descriptor table. > >

Re: [PATCH v4 09/10] v4l: xilinx: dma: Add multi-planar support

2018-05-01 Thread Hyun Kwon
On Mon, 2018-04-30 at 18:35:12 -0700, Satish Kumar Nagireddy wrote: > The current v4l driver supports single plane formats. This patch > adds support to handle multi-planar formats. Driver can handle > both single and multi-planar formats. > > Signed-off-by: Satish Kumar Nagireddy

Re: [PATCH v4 08/10] v4l: xilinx: dma: Update video format descriptor

2018-05-01 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:11 -0700, Satish Kumar Nagireddy wrote: > This patch updates video format descriptor to help information > viz., number of planes per color format and chroma sub sampling > factors. > > Signed-off-by: Satish Kumar Nagireddy

Re: [PATCH v4 07/10] media: Add new dt-bindings/vf_codes for supported formats

2018-05-01 Thread Hyun Kwon
On Mon, 2018-04-30 at 18:35:10 -0700, Satish Kumar Nagireddy wrote: > From: Rohit Athavale > > This commit adds new entries to the exisiting vf_codes that are used > to describe the media bus formats in the DT bindings. The newly added > 8-bit and 10-bit color depth related

Re: [PATCH v4 05/10] uapi: media: New fourcc codes needed by Xilinx Video IP

2018-05-01 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:08 -0700, Satish Kumar Nagireddy wrote: > From: Jeffrey Mouroux > > The Xilinx Video Framebuffer DMA IP supports video memory formats > that are not represented in the current V4L2 fourcc library. This > patch

Re: [PATCH v4 02/10] xilinx: v4l: dma: Use the dmaengine_terminate_all() wrapper

2018-05-01 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:05 -0700, Satish Kumar Nagireddy wrote: > From: Laurent Pinchart > > Calling dmaengine_device_control() to terminate transfers is an internal > API that will disappear, use the stable API wrapper

Re: [PATCH 1/2] dt-bindings: media: i2c: Add mt9t111 image sensor

2018-05-01 Thread Rob Herring
On Wed, Apr 25, 2018 at 01:00:13PM +0200, Jacopo Mondi wrote: > Add device tree bindings documentation for Micron MT9T111/MT9T112 image > sensors. > > Signed-off-by: Jacopo Mondi > --- > Documentation/devicetree/bindings/mt9t112.txt | 41 > +++

Re: [PATCH] rcar-vin: remove generic gen3 compatible string

2018-05-01 Thread Rob Herring
On Wed, Apr 25, 2018 at 01:43:21AM +0200, Niklas Söderlund wrote: > The compatible string "renesas,rcar-gen3-vin" was added before the > Gen3 driver code was added but it's not possible to use. Each SoC in the > Gen3 series require SoC specific knowledge in the driver to function. > Remove it

Re: [PATCH 27/28] venus: add sdm845 compatible and resource data

2018-05-01 Thread Rob Herring
On Tue, Apr 24, 2018 at 03:44:35PM +0300, Stanimir Varbanov wrote: > This adds sdm845 DT compatible string with it's resource > data table. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Stanimir Varbanov > --- > .../devicetree/bindings/media/qcom,venus.txt

Re: [PATCH 3/3] v4l: rcar_fdp1: Fix indentation oddities

2018-05-01 Thread Kieran Bingham
Hi Laurent, Thanks for the fixes. On 22/04/18 11:28, Laurent Pinchart wrote: > Indentation is odd in several places, especially when printing messages > to the kernel log. Fix it to match the usual coding style. > > Signed-off-by: Laurent Pinchart

[PATCH v8 4/8] media: vsp1: Convert display lists to use new body pool

2018-05-01 Thread Kieran Bingham
Adapt the dl->body0 object to use an object from the body pool. This greatly reduces the pressure on the TLB for IPMMU use cases, as all of the lists use a single allocation for the main body. The CLU and LUT objects pre-allocate a pool containing three bodies, allowing a userspace update before

[PATCH v8 7/8] media: vsp1: Adapt entities to configure into a body

2018-05-01 Thread Kieran Bingham
Currently the entities store their configurations into a display list. Adapt this such that the code can be configured into a body directly, allowing greater flexibility and control of the content. All users of vsp1_dl_list_write() are removed in this process, thus it too is removed. A helper,

[PATCH v8 8/8] media: vsp1: Move video configuration to a cached dlb

2018-05-01 Thread Kieran Bingham
We are now able to configure a pipeline directly into a local display list body. Take advantage of this fact, and create a cacheable body to store the configuration of the pipeline in the video object. vsp1_video_pipeline_run() is now the last user of the pipe->dl object. Convert this function to

[PATCH v8 2/8] media: vsp1: Protect bodies against overflow

2018-05-01 Thread Kieran Bingham
The body write function relies on the code never asking it to write more than the entries available in the list. Currently with each list body containing 256 entries, this is fine, but we can reduce this number greatly saving memory. In preparation of this add a level of protection to catch any

[PATCH v8 5/8] media: vsp1: Use reference counting for bodies

2018-05-01 Thread Kieran Bingham
Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-applied to multiple display lists. Signed-off-by: Kieran Bingham

[PATCH v8 1/8] media: vsp1: Reword uses of 'fragment' as 'body'

2018-05-01 Thread Kieran Bingham
Throughout the codebase, the term 'fragment' is used to represent a display list body. This term duplicates the 'body' which is already in use. The datasheet references these objects as a body, therefore replace all mentions of a fragment with a body, along with the corresponding pluralised

[PATCH v8 0/8] vsp1: TLB optimisation and DL caching

2018-05-01 Thread Kieran Bingham
Each display list currently allocates an area of DMA memory to store register settings for the VSP1 to process. Each of these allocations adds pressure to the IPMMU TLB entries. We can reduce the pressure by pre-allocating larger areas and dividing the area across multiple bodies represented as a

[PATCH v8 6/8] media: vsp1: Refactor display list configure operations

2018-05-01 Thread Kieran Bingham
The entities provide a single .configure operation which configures the object into the target display list, based on the vsp1_entity_params selection. Split the configure function into three parts, '.configure_stream()', '.configure_frame()', and '.configure_partition()' to facilitate splitting

[PATCH v8 3/8] media: vsp1: Provide a body pool

2018-05-01 Thread Kieran Bingham
Each display list allocates a body to store register values in a dma accessible buffer from a dma_alloc_wc() allocation. Each of these results in an entry in the IOMMU TLB, and a large number of display list allocations adds pressure to this resource. Reduce TLB pressure on the IPMMUs by

Re: [PATCH v7 8/8] media: vsp1: Move video configuration to a cached dlb

2018-05-01 Thread Kieran Bingham
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/05/18 09:28, Kieran Bingham wrote: > Hi Laurent, > > New plan ... (from the .. why didn't I think of this earlier department) Nope ... My suggestion in the previous mail (regarding dropping the configured flag in place of using the

[RFCv12 PATCH 22/29] v4l2-mem2mem: add vb2_m2m_request_queue

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil For mem2mem devices we have to make sure that v4l2_m2m_try_schedule() is called whenever a request is queued. We do that by creating a vb2_m2m_request_queue() helper that should be used instead of the 'normal' vb2_request_queue() helper. The m2m helper

[RFCv12 PATCH 14/29] videodev2.h: Add request_fd field to v4l2_buffer

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil When queuing buffers allow for passing the request that should be associated with this buffer. If V4L2_BUF_FLAG_REQUEST_FD is set, then request_fd is used as the file descriptor. If a buffer is stored in a request, but not yet queued to the driver,

[RFCv12 PATCH 29/29] RFC: media-requests: add debugfs node

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Keep track of the number of requests and request objects of a media device. Helps to verify that all request-related memory is freed. Signed-off-by: Hans Verkuil --- drivers/media/media-device.c | 41

[RFCv12 PATCH 06/29] media-request: add media_request_object_find

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Add media_request_object_find to find a request object inside a request based on ops and/or priv values. Objects of the same type (vb2 buffer, control handler) will have the same ops value. And objects that refer to the same 'parent' object (e.g. the

[RFCv12 PATCH 23/29] Documentation: v4l: document request API

2018-05-01 Thread Hans Verkuil
From: Alexandre Courbot Document the request API for V4L2 devices, and amend the documentation of system calls influenced by it. Signed-off-by: Alexandre Courbot --- Documentation/media/uapi/v4l/buffer.rst | 19 +-

[RFCv12 PATCH 11/29] v4l2-ctrls: use ref in helper instead of ctrl

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil The next patch needs the reference to a control instead of the control itself, so change struct v4l2_ctrl_helper accordingly. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 18 +- 1 file

[RFCv12 PATCH 08/29] v4l2-ctrls: v4l2_ctrl_add_handler: add from_other_dev

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Add a 'bool from_other_dev' argument: set to true if the two handlers refer to different devices (e.g. it is true when inheriting controls from a subdev into a main v4l2 bridge driver). This will be used later when implementing support for the request

[RFCv12 PATCH 12/29] v4l2-ctrls: add core request support

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Integrate the request support. This adds the v4l2_ctrl_request_complete and v4l2_ctrl_request_setup functions to complete a request and (as a helper function) to apply a request to the hardware. It takes care of queuing requests and correctly chaining

[RFCv12 PATCH 13/29] v4l2-ctrls: support g/s_ext_ctrls for requests

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil The v4l2_g/s_ext_ctrls functions now support control handlers that represent requests. The v4l2_ctrls_find_req_obj() function is responsible for finding the request from the fd. Signed-off-by: Hans Verkuil ---

[RFCv12 PATCH 02/29] uapi/linux/media.h: add request API

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Define the public request API. This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request and two ioctls that operate on a request in order to queue the contents of the request to the driver and to re-initialize the request. Signed-off-by:

[RFCv12 PATCH 28/29] vivid: add request support

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Add support for requests to vivid. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivid/vivid-core.c| 8 drivers/media/platform/vivid/vivid-kthread-cap.c | 12

[RFCv12 PATCH 01/29] v4l2-device.h: always expose mdev

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set. But since we will need to pass the media_device to vb2 and the control framework it is very convenient to just make this field available all the time. If CONFIG_MEDIA_CONTROLLER is not

[RFCv12 PATCH 03/29] media-request: implement media requests

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Add initial media request support. Signed-off-by: Hans Verkuil --- drivers/media/Makefile| 3 +- drivers/media/media-device.c | 13 ++ drivers/media/media-request.c | 418 ++

[RFCv12 PATCH 27/29] vivid: add mc

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Add support for the media_device to vivid. This is a prerequisite for request support. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivid/vivid-core.c | 61 +++

[RFCv12 PATCH 25/29] vim2m: use workqueue

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in interrupt context. Switch to a workqueue instead. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 15 +-- 1 file changed, 13

[RFCv12 PATCH 15/29] vb2: store userspace data in vb2_v4l2_buffer

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil The userspace-provided plane data needs to be stored in vb2_v4l2_buffer. Currently this information is applied by __fill_vb2_buffer() which is called by the core prepare_buf and qbuf functions, but when using requests these functions aren't called yet

[RFCv12 PATCH 24/29] media: vim2m: add media device

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Request API requires a media node. Add one to the vim2m driver so we can use requests with it. This probably needs a bit more work to correctly represent m2m hardware in the media topology. Signed-off-by: Hans Verkuil ---

[RFCv12 PATCH 05/29] media-request: add media_request_find

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Add media_request_find() to find a request based on the file descriptor. The caller has to call media_request_put() for the returned request since this function increments the refcount. Signed-off-by: Hans Verkuil ---

[RFCv12 PATCH 04/29] v4l2-dev: lock req_queue_mutex

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dev.c | 37 +- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-dev.c

[RFCv12 PATCH 00/29] Request API

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Hi all, This is version 12 of the Request API series. The main changes compared to v11 are: - Improve locking (more about that below) - Split req_queue into req_validate and req_queue - Add vb2_m2m_request_queue() helper - Merge v11 patches 3-5 into

[RFCv12 PATCH 18/29] videobuf2-v4l2: integrate with media requests

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil This implements the V4L2 part of the request support. The main change is that vb2_qbuf and vb2_prepare_buf now have a new media_device pointer. This required changes to several drivers that did not use the vb2_ioctl_qbuf/prepare_buf helper functions.

[RFCv12 PATCH 10/29] v4l2-ctrls: alloc memory for p_req

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil To store request data the handler_new_ref() allocates memory for it if needed. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 20 1 file changed, 16 insertions(+), 4 deletions(-)

[RFCv12 PATCH 19/29] videobuf2-core: add vb2_core_request_has_buffers

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Add a new helper function that returns true if a media_request contains buffers. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-core.c | 17 + include/media/videobuf2-core.h

[RFCv12 PATCH 16/29] videobuf2-core: embed media_request_object

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Make vb2_buffer a request object. Signed-off-by: Hans Verkuil --- include/media/videobuf2-core.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index

[RFCv12 PATCH 17/29] videobuf2-core: integrate with media requests

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Buffers can now be prepared or queued for a request. A buffer is unbound from the request at vb2_buffer_done time or when the queue is cancelled. Signed-off-by: Hans Verkuil --- .../media/common/videobuf2/videobuf2-core.c |

[RFCv12 PATCH 09/29] v4l2-ctrls: prepare internal structs for request API

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Embed and initialize a media_request_object in struct v4l2_ctrl_handler. Add a p_req field to struct v4l2_ctrl_ref that will store the request value. Signed-off-by: Hans Verkuil Signed-off-by: Alexandre Courbot

[RFCv12 PATCH 21/29] videobuf2-v4l2: export request_fd

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Requested by Sakari Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 6 -- include/media/videobuf2-v4l2.h | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff

[RFCv12 PATCH 26/29] vim2m: support requests

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil Add support for requests to vim2m. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/media/platform/vim2m.c

[RFCv12 PATCH 20/29] videobuf2-v4l2: add vb2_request_queue/validate helpers

2018-05-01 Thread Hans Verkuil
From: Hans Verkuil The generic vb2_request_validate helper function checks if there are buffers in the request and if so, prepares and all objects in the request. The generic vb2_request_queue helper function queues all buffer objects in the validated request.

[RFCv12 PATCH 07/29] videodev2.h: add request_fd field to v4l2_ext_controls

2018-05-01 Thread Hans Verkuil
From: Alexandre Courbot If which is V4L2_CTRL_WHICH_REQUEST_VAL, then the request_fd field can be used to specify a request for the G/S/TRY_EXT_CTRLS ioctls. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 5

Re: [PATCH v7 8/8] media: vsp1: Move video configuration to a cached dlb

2018-05-01 Thread Kieran Bingham
Hi Laurent, New plan ... (from the .. why didn't I think of this earlier department) On 30/04/18 18:48, Kieran Bingham wrote: > Hi Laurent, > > On 07/04/18 01:23, Laurent Pinchart wrote: >> Hi Kieran, >> >> Thank you for the patch. >> >> On Thursday, 8 March 2018 02:05:31 EEST Kieran Bingham

Re: [PATCH v4 09/10] v4l: xilinx: dma: Add multi-planar support

2018-05-01 Thread Ian Arkver
Hi Satish, On 01/05/18 02:35, Satish Kumar Nagireddy wrote: The current v4l driver supports single plane formats. This patch adds support to handle multi-planar formats. Driver can handle both single and multi-planar formats. Signed-off-by: Satish Kumar Nagireddy