RFC: stop support for 2.6 kernel in the daily build

2018-09-12 Thread Hans Verkuil
SUSE Linux Enterprise Server 12 is on kernel 3.12, and version 11 SP2 or up is on kernel 3.0. Red Hat's RHEL 7 is on kernel 3.10. I'm inclined to drop support for 2.6 altogether. If nothing else it simplifies the kernel version handling in media_build. Whether we should also drop support for 3.0

cron job: media_tree daily build: ERRORS

2018-09-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Sep 13 04:00:17 CEST 2018 media-tree git hash:78cf8c842c111df656c63b5d04997ea4e40ef26a media_build gi

[PATCH v2 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-12 Thread Sakari Ailus
The event subscriptions are added to the subscribed event list while holding a spinlock, but that lock is subsequently released while still accessing the subscription object. This makes it possible to unsubscribe the event --- and freeing the subscription object's memory --- while the subscription

Re: [PATCH 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-12 Thread Sakari Ailus
Hi Laurent, On Wed, Sep 12, 2018 at 02:57:20PM +0300, Laurent Pinchart wrote: > Hello, > > On Wednesday, 12 September 2018 13:00:57 EEST Sakari Ailus wrote: > > On Wed, Sep 12, 2018 at 11:27:35AM +0200, Hans Verkuil wrote: > > > On 09/12/18 10:52, Sakari Ailus wrote: > > >> The event subscription

Re: [PATCH v2 18/23] v4l: fwnode: Use media bus type for bus parser selection

2018-09-12 Thread Sakari Ailus
Hi Jacopo, Thanks for the comments. On Wed, Sep 12, 2018 at 05:15:05PM +0200, jacopo mondi wrote: > Hi Sakari, > > On Mon, Aug 27, 2018 at 12:29:55PM +0300, Sakari Ailus wrote: > > Use the media bus types instead of the fwnode bus types internally. This > > is the interface to the drivers as wel

Re: [PATCH v2 07/23] v4l: fwnode: Let the caller provide V4L2 fwnode endpoint

2018-09-12 Thread Sakari Ailus
Hi Jacopo, On Wed, Sep 12, 2018 at 04:51:07PM +0200, jacopo mondi wrote: > Hi Sakari, > > On Mon, Aug 27, 2018 at 12:29:44PM +0300, Sakari Ailus wrote: > > Instead of allocating the V4L2 fwnode endpoint in > > v4l2_fwnode_endpoint_alloc_parse, let the caller to do this. This allows > > setting de

Re: [PATCH 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-12 Thread Sakari Ailus
Hi Hans, On Wed, Sep 12, 2018 at 02:32:52PM +0200, Hans Verkuil wrote: > On 09/12/18 12:00, Sakari Ailus wrote: > > Hi Hans, > > > > Thanks for the quick review. > > > > On Wed, Sep 12, 2018 at 11:27:35AM +0200, Hans Verkuil wrote: > >> On 09/12/18 10:52, Sakari Ailus wrote: > >>> The event subs

Re: [PATCH v2 18/23] v4l: fwnode: Use media bus type for bus parser selection

2018-09-12 Thread jacopo mondi
Hi Sakari, On Mon, Aug 27, 2018 at 12:29:55PM +0300, Sakari Ailus wrote: > Use the media bus types instead of the fwnode bus types internally. This > is the interface to the drivers as well, making the use of the fwnode bus > types more localised to the V4L2 fwnode framework. > So basically now "

Re: [PATCH v2 07/23] v4l: fwnode: Let the caller provide V4L2 fwnode endpoint

2018-09-12 Thread jacopo mondi
Hi Sakari, On Mon, Aug 27, 2018 at 12:29:44PM +0300, Sakari Ailus wrote: > Instead of allocating the V4L2 fwnode endpoint in > v4l2_fwnode_endpoint_alloc_parse, let the caller to do this. This allows > setting default parameters for the endpoint which is a very common need > for drivers. > > Signe

Question 16

2018-09-12 Thread Jimmy
Hi, We are waiting for your photos. Please send photos to hansre...@outlook.com for further editing. Our team is ready to edit your photos. Do you have photos for editing? We are team who can do following work for you. Cutting out your photos, or retouching if needed. It is for products photos

Re: [git:media_tree/master] media: em28xx-audio: use GFP_KERNEL for memory allocation during init

2018-09-12 Thread Sebastian Andrzej Siewior
On 2018-09-12 14:43:11 [+0200], To linux-media@vger.kernel.org wrote: > On 2018-09-12 12:00:36 [+], Mauro Carvalho Chehab wrote: > > This is an automatic generated email to let you know that the following > > patch were queued: > > The three patches you just enqueued are also in Greg's USB tr

Re: [git:media_tree/master] media: em28xx-audio: use GFP_KERNEL for memory allocation during init

2018-09-12 Thread Sebastian Andrzej Siewior
On 2018-09-12 12:00:36 [+], Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued: The three patches you just enqueued are also in Greg's USB tree for the next merge-window. Sebastian

Re: [PATCH 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-12 Thread Hans Verkuil
On 09/12/18 12:00, Sakari Ailus wrote: > Hi Hans, > > Thanks for the quick review. > > On Wed, Sep 12, 2018 at 11:27:35AM +0200, Hans Verkuil wrote: >> On 09/12/18 10:52, Sakari Ailus wrote: >>> The event subscriptions are added to the subscribed event list while >>> holding a spinlock, but that

Re: [PATCH 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-12 Thread Laurent Pinchart
Hello, On Wednesday, 12 September 2018 13:00:57 EEST Sakari Ailus wrote: > On Wed, Sep 12, 2018 at 11:27:35AM +0200, Hans Verkuil wrote: > > On 09/12/18 10:52, Sakari Ailus wrote: > >> The event subscriptions are added to the subscribed event list while > >> holding a spinlock, but that lock is su

Re: [PATCH 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-12 Thread Sakari Ailus
Hi Hans, Thanks for the quick review. On Wed, Sep 12, 2018 at 11:27:35AM +0200, Hans Verkuil wrote: > On 09/12/18 10:52, Sakari Ailus wrote: > > The event subscriptions are added to the subscribed event list while > > holding a spinlock, but that lock is subsequently released while still > > acce

Re: [PATCH v4] vb2: check for sane values from queue_setup

2018-09-12 Thread Sakari Ailus
On Tue, Sep 11, 2018 at 04:46:04PM +0200, Johan Fjeldtvedt wrote: > Warn and return error from the reqbufs ioctl when driver sets 0 number > of planes or 0 as plane sizes, as these values don't make any sense. > Checking this here stops obviously wrong values from propagating > further and causing

Re: [PATCH v3] vb2: check for sane values from queue_setup

2018-09-12 Thread Stanimir Varbanov
Hi, On 09/11/2018 03:46 PM, Johan Fjeldtvedt wrote: > Warn and return error from the reqbufs ioctl when driver sets 0 number > of planes or 0 as plane sizes, as these values don't make any sense. typo: planes -> buffers > Checking this here stops obviously wrong values from propagating > further

Re: [PATCH 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-12 Thread Hans Verkuil
On 09/12/18 10:52, Sakari Ailus wrote: > The event subscriptions are added to the subscribed event list while > holding a spinlock, but that lock is subsequently released while still > accessing the subscription object. This makes it possible to unsubscribe > the event --- and freeing the subscript

[PATCH 1/1] v4l: event: Prevent freeing event subscriptions while accessed

2018-09-12 Thread Sakari Ailus
The event subscriptions are added to the subscribed event list while holding a spinlock, but that lock is subsequently released while still accessing the subscription object. This makes it possible to unsubscribe the event --- and freeing the subscription object's memory --- while the subscription

Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-12 Thread Hans Verkuil
On 09/10/2018 02:19 PM, Mauro Carvalho Chehab wrote: > The strncpy() function is being deprecated upstream. Replace > it by the safer strscpy(). > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/dvb-frontends/as102_fe.c | 2 +- > drivers/media/dvb-frontends/dib7000p.c