Re: [PATCHv3 11/12] media: docs-rst: Document m2m stateless video decoder interface

On Fri, Sep 27, 2019 at 12:40 AM Nicolas Dufresne wrote: > > Le jeudi 26 septembre 2019 à 13:33 +0200, Hans Verkuil a écrit : > > Hi Alexandre, Tomasz, > > > > On 8/15/19 4:44 PM, Hans Verkuil wrote: > > > From: Alexandre Courbot > > > > > > Documents the protocol that user-space should follow wh

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Oct 2 05:00:10 CEST 2019 media-tree git hash:503e59365dd134b2c63864f14e2de0476284b003 media_build gi

[PATCH 2/2] media: usbvision: Fix races among open, close, and disconnect

Visual inspection of the usbvision driver shows that it suffers from three races between its open, close, and disconnect handlers. In particular, the driver is careful to update its usbvision->user and usbvision->remove_pending flags while holding the private mutex, but: usbvision_v4l2_cl

[PATCH 1/2] media: usbvision: Fix invalid accesses after device disconnect

The syzbot fuzzer found two invalid-access bugs in the usbvision driver. These bugs occur when userspace keeps the device file open after the device has been disconnected and usbvision_disconnect() has set usbvision->dev to NULL: When the device file is closed, usbvision_radio_close() tri

Re: [GIT PULL FOR v5.5] am437x-vpfe: overdue maintenance

Em Fri, 27 Sep 2019 16:27:00 +0200 Hans Verkuil escreveu: > Various fixes for am437x-vpfe. > > One special note: the last three patches adds new macros to be able to > print a V4L2 fourcc in a standard way, both for kernel and userspace, > and uses them in v4l2-ioctl.c and am437x. > > If you ha

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Tue, Oct 01, 2019 at 11:58:26AM -0700, Tim Harvey wrote: > CONFIDENTIALITY NOTICE: This email constitutes an electronic > communication within the meaning of the Electronic Communications Privacy > Act, 18 U.S.C. 2510, and its disclosure is strictly limited to the named > recipient(s) intende

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Tue, 1 Oct 2019, Tim Harvey wrote: > On Thu, Sep 26, 2019 at 3:47 PM Tim Harvey wrote: > > > > Greetings, > > > > I'm running into an issue with a USB UVC Full speed camera, the > > PureThermal2 [1] on an IMX6 based ARM board. > > > > What I find is that I get two video devices registered (the

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Thu, Sep 26, 2019 at 3:47 PM Tim Harvey wrote: > > Greetings, > > I'm running into an issue with a USB UVC Full speed camera, the > PureThermal2 [1] on an IMX6 based ARM board. > > What I find is that I get two video devices registered (the first one > is the expected device, and I'm not clear

Re: [PATCH] media: vimc: embed the pads of entities in the entities' structs

Hi Dafna, Thanks for your patch, just some comments below. On 10/1/19 2:07 PM, Dafna Hirschfeld wrote: > since the pads array is of known small size, there is no reason to > allocate it separately. Instead, it is embedded in the entity struct. > This also conforms to the media controller doc: > '

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

W dniu 01.10.2019 o 19:35, Helen Koike pisze: I believe just the kcalloc bellow should fix the issue. But if you want to do this cleanup anyway, I would suggest sending a separate patch for it. @@ -199,7 +197,7 @@ static int vimc_register_devices(struct vimc_device *vimc)   }     

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

On 10/1/19 2:25 PM, Andrzej Pietrasiewicz wrote: > Hi Dafna, hi Helen, > > W dniu 01.10.2019 o 19:19, Helen Koike pisze: >> Hi Dafna, >> >> On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: >>> since NULL value for vimc entity pointer indicates >>> that entity creation failed and this is tested, the

Re: [PATCH 3/3] media: vimc: move media_entity_cleanup to release callbacks

Hi Dafna, Thanks for your patch On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: > according to the docs, this function must be called during > the cleanup phase after unregistering the entity. > > Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike I just have one note below. > --- > drivers

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

Hi Dafna, hi Helen, W dniu 01.10.2019 o 19:19, Helen Koike pisze: Hi Dafna, On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: since NULL value for vimc entity pointer indicates that entity creation failed and this is tested, the pointers should be initialized to NULL. Nice catch :) Signed-off-b

Re: [PATCH 2/3] media: vimc: sensor: register subdevice only after initialization

On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: > vimc_sen_add function first registers the subdevice and then > calls tpg_alloc. If tpg_alloc fails it unregisters the subdevice > and then frees vsen, this cause double free since the release > callback that follows subdevice unregistration also free

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

Hi Dafna, On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: > since NULL value for vimc entity pointer indicates > that entity creation failed and this is tested, the > pointers should be initialized to NULL. Nice catch :) > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/platform/vimc/vimc

[PATCH] media: vimc: embed the pads of entities in the entities' structs

since the pads array is of known small size, there is no reason to allocate it separately. Instead, it is embedded in the entity struct. This also conforms to the media controller doc: 'Most drivers will embed the pads array in a driver-specific structure, avoiding dynamic allocation.' Signed-off-

[PATCH 0/3] media: vimc: bug fixes related to memory management

This patchset has 3 patches fixing 3 bugs in vimc. The patchset is rebased on top of v5 of the patchset 'media: vimc: Collapse component structure into a single monolithic driver' sent by 'Shuah Khan' Dafna Hirschfeld (3): media: vimc: initialize vim entity pointers to NULL media: vimc: se

[PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

since NULL value for vimc entity pointer indicates that entity creation failed and this is tested, the pointers should be initialized to NULL. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-core.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/d

[PATCH 2/3] media: vimc: sensor: register subdevice only after initialization

vimc_sen_add function first registers the subdevice and then calls tpg_alloc. If tpg_alloc fails it unregisters the subdevice and then frees vsen, this cause double free since the release callback that follows subdevice unregistration also frees vsen. Signed-off-by: Dafna Hirschfeld --- drivers/

[PATCH 3/3] media: vimc: move media_entity_cleanup to release callbacks

according to the docs, this function must be called during the cleanup phase after unregistering the entity. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-capture.c | 2 +- drivers/media/platform/vimc/vimc-common.c | 1 - drivers/media/platform/vimc/vimc-debayer.c | 1 +

[PATCH] media: dvbsky: add support for eyeTV Geniatech T2 lite

Adds USB ID for the eyeTV Geniatech T2 lite to the dvbsky driver. This is a Geniatech T230C based stick without IR and a different USB ID. Signed-off-by: Thomas Voegtle --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 +++ include/media/dvb-usb-ids.h | 1 + 2 files changed, 4 insertions(+

Re: [GIT PULL for v5.4-rc1] media updates

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58782/ Build log: https://builder.linuxtv.org/job/patchwork/18524/ Build time: 00:00:00 Link: https://lore.kernel.org/linux-media/20190916092515.66549...@coco.lan gpg: Signature made Mon 16 Sep 2019 12:06:35 PM UTC gpg:

Re: [GIT PULL FOR v5.5] cx231xx: convert to vb2

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59089/ Build log: https://builder.linuxtv.org/job/patchwork/18511/ Build time: 00:02:58 Link: https://lore.kernel.org/linux-media/d22f3417-9f36-c57e-ceb9-fe8436422...@xs4all.nl gpg: Signature made Tue 01 Oct 2019 10:04:5

[GIT PULL FOR v5.5] cx231xx: convert to vb2

The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c: Linux 5.4-rc1 (2019-09-30 10:35:40 -0700) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-cx231xx-vb2 for you to fetch changes up to f52ff1811749b057007be565b23c98c5086c274

[PATCH v3] edid-decode: Avoid division by zero

There are some weird monitors that returns invalid data, as zeroed Horizontal/Vertical Active/Blanking. This causes edid-decode to crash with a divsion by error exception. This simple patch avoids so, checking for the divisor before proceeding. On invalid data, it prints something as: ... Inv

Re: [PATCH v2] edid-decode: Avoid division by zero

On 01/10/2019 10:26, Hans Verkuil wrote: > Can you just mail me the raw output? > > cat /sys/devices/pci:00/:00:02.0/drm/card0/card0-HDMI-A-1/edid > >edid.bin Sure, here it is. edid.bin Description: application/macbinary

Re: [PATCH v2] edid-decode: Avoid division by zero

On 10/1/19 11:15 AM, Breno Leitao wrote: > Hi Hans, > > On 01/10/2019 09:39, Hans Verkuil wrote: >> On 10/1/19 10:10 AM, Breno Leitao wrote: >>> There are some weird monitors that returns invalid data, as zeroed >>> Horizontal/Vertical Active/Blanking. >> >> Do you have an EDID that does this? I'd

Re: [PATCH v2] edid-decode: Avoid division by zero

On 01/10/2019 10:16, Hans Verkuil wrote: > On 10/1/19 11:15 AM, Breno Leitao wrote: >> Hi Hans, >> >> On 01/10/2019 09:39, Hans Verkuil wrote: >>> On 10/1/19 10:10 AM, Breno Leitao wrote: There are some weird monitors that returns invalid data, as zeroed Horizontal/Vertical Active/Blankin

Re: [PATCH v2] edid-decode: Avoid division by zero

On 10/1/19 11:15 AM, Breno Leitao wrote: > Hi Hans, > > On 01/10/2019 09:39, Hans Verkuil wrote: >> On 10/1/19 10:10 AM, Breno Leitao wrote: >>> There are some weird monitors that returns invalid data, as zeroed >>> Horizontal/Vertical Active/Blanking. >> >> Do you have an EDID that does this? I'd

Re: [PATCH v2] edid-decode: Avoid division by zero

Hi Hans, On 01/10/2019 09:39, Hans Verkuil wrote: > On 10/1/19 10:10 AM, Breno Leitao wrote: >> There are some weird monitors that returns invalid data, as zeroed >> Horizontal/Vertical Active/Blanking. > > Do you have an EDID that does this? I'd like to add it to the collection > of EDIDs in edi

Re: [PATCH] media: rc-map: Sort rc map name MACROs

Hello, On Fri, Aug 30, 2019 at 07:33:08AM +, Jisheng Zhang wrote: > Except RC_MAP_SU3000 and RC_MAP_HAUPPAUGE, others are alphabetically > sorted. Sort names alphabetically. > > Signed-off-by: Jisheng Zhang > --- > include/media/rc-map.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH v2] edid-decode: Avoid division by zero

On 10/1/19 10:10 AM, Breno Leitao wrote: > There are some weird monitors that returns invalid data, as zeroed > Horizontal/Vertical Active/Blanking. Do you have an EDID that does this? I'd like to add it to the collection of EDIDs in edid-decode. Some more nitpicks below: > > This causes edid-d

[GIT PULL for 5.5] Sensor driver patches

Hi Mauro, Here's the first pile of sensor driver patches for 5.5. There's mostly sensor driver patches but no new drivers. Please pull. The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c: Linux 5.4-rc1 (2019-09-30 10:35:40 -0700) are available in the Git repository

[PATCH v2] edid-decode: Avoid division by zero

There are some weird monitors that returns invalid data, as zeroed Horizontal/Vertical Active/Blanking. This causes edid-decode to crash with a division by zero exception. This simple patch avoids so, checking for the divisor before proceeding. Signed-off-by: Breno Leitao --- edid-decode.c | 10

[PATCH] cec-funcs.h: add status_req checks

The CEC_MSG_GIVE_DECK_STATUS and CEC_MSG_GIVE_TUNER_DEVICE_STATUS commands both have a status_req argument: ON, OFF, ONCE. If ON or ONCE, then the follower will reply with a STATUS message. Either once or whenever the status changes (status_req == ON). If status_req == OFF, then it will stop sendi

Re: [PATCH v4 3/3] cec-compliance: add tuner control test

On 10/1/19 5:18 AM, Jiunn Chang wrote: > Add test for new features added to cec-follower. > > Analog tuner control test tuner_ctl_test(): > - give analog tuner status > - select tuner analog service > - analog tuner step features > > Signed-off-by: Jiunn Chang > --- > utils/cec-compliance

Re: [PATCH v4 2/3] cec-follower: add tuner step increment/decrement

On 10/1/19 5:18 AM, Jiunn Chang wrote: > Tuner step increment/decrement will select the next highest or next > lowest service frequency. There are a total of three possible > frequencies given a broadcast type and system for a total of 81 analog > channels. > > Opcodes implemented: > - > -

Jenkins build is back to normal : media-build #1204

See