arse_fwnode_sensor_common()
> and registers the async sub-devices.
>
> After applying this change, we can see the VCM move when changing the scene.
When you derive Cc list, set some threshold to the get_maintainer.pl, like
scripts/get_maintainer.pl --git --git-min-percent=67
--
With Best Regards,
Andy Shevchenko
",
> +GPIOD_OUT_LOW);
> + if (IS_ERR(ov8856->n_shutdn_gpio)) {
> + dev_err(&client->dev, "failed to get reset-gpios\n");
> + return -EINVAL;
> + }
Ditto.
> +static const struct of_device_id ov8856_of_match[] = {
> + { .compatible = "ovti,ov8856" },
> + {},
No comma needed for terminator line.
> +};
--
With Best Regards,
Andy Shevchenko
On Tue, Sep 10, 2019 at 09:04:45PM +0800, dongchun@mediatek.com wrote:
> From: Dongchun Zhu
>
> This patch adds device tree bindings documentation for the ov8856 CMOS
> image sensor.
New bindings in YAML, please.
--
With Best Regards,
Andy Shevchenko
On Mon, Sep 09, 2019 at 12:57:15PM +0300, Sakari Ailus wrote:
> Hi Andy,
>
> On Mon, Sep 09, 2019 at 12:45:01PM +0300, Andy Shevchenko wrote:
> > On Sat, Sep 07, 2019 at 05:27:27PM +0800, dongchun@mediatek.com wrote:
> > > From: Dongchun Zhu
> > >
> >
ov02a10.txt | 54
> ++
> MAINTAINERS| 7 +++
This doesn't belong to dt-bindings.
--
With Best Regards,
Andy Shevchenko
On Thu, Sep 05, 2019 at 03:00:12PM +0300, Sakari Ailus wrote:
> And I see no reason to add a separate patch just for
> MAINTAINERS change.
It's up to maintainers of the subsystem.
--
With Best Regards,
Andy Shevchenko
On Thu, Sep 05, 2019 at 12:57:34PM +0200, Javier Martinez Canillas wrote:
> On 9/5/19 12:40 PM, Sakari Ailus wrote:
> > On Thu, Sep 05, 2019 at 01:19:08PM +0300, Andy Shevchenko wrote:
> >> On Thu, Sep 05, 2019 at 11:21:34AM +0300, Sakari Ailus wrote:
> >>> On Thu, Se
On Thu, Sep 05, 2019 at 01:48:30PM +0300, Sakari Ailus wrote:
> On Thu, Sep 05, 2019 at 01:14:06PM +0300, Andy Shevchenko wrote:
> > On Thu, Sep 05, 2019 at 03:21:41PM +0800, dongchun@mediatek.com wrote:
> > > From: Dongchun Zhu
> > >
> > > This pa
struct v4l2_subdev *sd = i2c_get_clientdata(client);
Ditto.
> + struct dw9768 *dw9768 = sd_to_dw9768_vcm(sd);
> +
> + return dw9768_power_on(dw9768);
> +}
> +static const struct i2c_device_id dw9768_id_table[] = {
> + { DW9768_NAME, 0 },
> + { },
No comma.
> +};
> +static const struct of_device_id dw9768_of_table[] = {
> + { .compatible = "dongwoon,dw9768" },
> + { },
Ditto.
> +};
--
With Best Regards,
Andy Shevchenko
;
> Could you drop the I²C ID table?
But why?
It will allow you to instanciate the device from user space.
+Cc: Javier.
Javier, is it needed in new code?
--
With Best Regards,
Andy Shevchenko
etree/bindings/media/i2c/dongwoon,dw9768.txt | 9 +
> MAINTAINERS | 7 +++
This should be:
1) two separate patches
2) binding in YAML
--
With Best Regards,
Andy Shevchenko
ower_lock);
> + dw9768_subdev_cleanup(dw9768_dev);
> + dev_err(dev, "Probe failed: %d\n", rval);
Noise. Device core has this already.
> + return rval;
> +}
> +static const struct i2c_device_id dw9768_id_table[] = {
> + { DW9768_NAME, 0 },
> + { { 0 } }
{} is enough.
> +};
> +MODULE_DEVICE_TABLE(i2c, dw9768_id_table);
> +
> +static const struct of_device_id dw9768_of_table[] = {
> + { .compatible = "dongwoon,dw9768" },
> + { { 0 } }
Ditto.
> +};
--
With Best Regards,
Andy Shevchenko
Use fwnode_property_count_uXX() directly, that makes code neater.
Signed-off-by: Andy Shevchenko
---
- drop double 'use' in the commit message
- add conversion for u64 array
drivers/media/v4l2-core/v4l2-fwnode.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
Use use fwnode_property_count_uXX() directly, that makes code neater.
Signed-off-by: Andy Shevchenko
---
drivers/media/v4l2-core/v4l2-fwnode.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c
b/drivers/media/v4l2-core/v4l2-fwnode.c
return 0;
}
Regards, Andy
>-Original Message-
>From: Tomasz Figa [mailto:tf...@chromium.org]
>Sent: Tuesday, January 15, 2019 11:23 AM
>To: Kao, Ben
>Cc: Linux Media Mailing List ; Sakari Ailus
>; Yeh, Andy
>Subject: Re: [PATCH v2] media: ov8856: Add suppo
mail.com; linux-media me...@vger.kernel.org>; Yeh, Andy ; Lai, Jim
>; grund...@chromium.org; Mani, Rajmohan
>
>Subject: Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver
>
>Hi Ping-chung,
>
>On Wed, Sep 26, 2018 at 02:27:01AM +, Chen, Ping-chung wrot
Hi PC,
Thanks for the patch.
Cc in Grant, and Intel Jim/Jason
> -Original Message-
> From: Chen, Ping-chung
> Sent: Tuesday, July 10, 2018 3:16 PM
> To: linux-media@vger.kernel.org
> Cc: sakari.ai...@linux.intel.com; Yeh, Andy ;
> tf...@chromium.org; Chen, Ping-chung
On Mon, Jun 25, 2018 at 11:02 AM, Sakari Ailus
wrote:
> Hi Alan,
> On Mon, Jun 25, 2018 at 03:29:41PM +0800, alanx.chi...@intel.com wrote:
Agreed on all Sakari's comments against the series.
--
With Best Regards,
Andy Shevchenko
Hi Alan,
Thanks for the patch set.
You should change the subject as below.
[PATCH v1, 1/2]
[PATCH v1, 2/2]
And I think you may missed to create a cover page. Please follow my BKM. Thanks.
git format-patch --cover --subject-prefix -o HEAD~n
Regards, Andy
> -Original Message-
>
; I found a solution for it and uploaded a patch to the kernel bugzilla.
>
> See here: https://bugzilla.kernel.org/show_bug.cgi?id=197731
>
> Can somebody of the maintainers have a look on it and apply the patch to the
> kernes sources?
You forget to Cc to maintainers (at least Mauro).
--
With Best Regards,
Andy Shevchenko
Hi Mauro,
>-Original Message-
>From: Mauro Carvalho Chehab [mailto:mchehab+sams...@kernel.org]
>Sent: Thursday, May 10, 2018 3:04 AM
>To: Yeh, Andy
>Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com;
>devicet...@vger.kernel.org; tf...@chromium.org;
Fix a warning reported by compiler, along with an incremental patch.
---
drivers/media/i2c/dw9807.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/dw9807.c b/drivers/media/i2c/dw9807.c
index 28ede2b..6ebb987 100644
--- a/drivers/media/i2c/dw9807.c
+++ b/drive
Hi Tomasz,
-Original Message-
From: Tomasz Figa [mailto:tf...@chromium.org]
Sent: Thursday, May 10, 2018 3:04 PM
To: Zheng, Jian Xu
Cc: Chen, JasonX Z ; Yeh, Andy ;
Linux Media Mailing List ; Sakari Ailus
; Chiang, AlanX
Subject: Re: [PATCH v11] media: imx258: Add imx258 camera
Dear reviewers,
As the dt-binding patch has been accepted, would any help set the driver patch
be accepted too? Any missing action from my side blocked the process. Thanks in
advance.
media: dw9807: Add dw9807 vcm driver
https://patchwork.linuxtv.org/patch/49159/
Regards, Andy
-Original
.remove = pt1_remove,
> .id_table = pt1_id_table,
> -#if CONFIG_PM_SLEEP
> +#ifdef CONFIG_PM_SLEEP
> .driver.pm = &pt1_pm_ops,
> #endif
> };
> --
> 2.17.0
>
--
With Best Regards,
Andy Shevchenko
es.
> + is_sat = !strncmp(cl->name, TC90522_I2C_DEV_SAT,
> + strlen(TC90522_I2C_DEV_SAT));
In this case I don't see a point to use strNcmp(). Plain strcmp() would work.
--
With Best Regards,
Andy Shevchenko
t;
> - if (!atomisp_subdev_get_rect(sd, cfg, which, pad, target))
> + p = atomisp_subdev_get_rect(sd, cfg, which, pad, target);
> + if (!p)
> return -EINVAL;
> - *r = *atomisp_subdev_get_rect(sd, cfg, which, pad, target);
> + *r = *p;
>
> dev_dbg(isp->dev, "sel actual: l %d t %d w %d h %d\n",
> r->left, r->top, r->width, r->height);
--
Andy Shevchenko
Intel Finland Oy
Hi Sakari,
Thanks to add to your tree. And I am not familiar with the process. So I wonder
how the patchset will be applied to the Linux media tree eventually?
Regards, Andy
-Original Message-
From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
Sent: Thursday, May 3, 2018 5:37 AM
Thanks for your kindly review.
Submitted v9 only with Reviewed/Acked-by.
Regards, Andy
-Original Message-
From: jacopo mondi [mailto:jac...@jmondi.org]
Sent: Wednesday, May 2, 2018 3:17 PM
To: Yeh, Andy
Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com;
devicet
From: Alan Chiang
Dongwoon DW9807 is a voice coil lens driver.
Signed-off-by: Andy Yeh
Reviewed-by: Sakari Ailus
Reviewed-by: Tomasz Figa
Reviewed-by: Jacopo Mondi
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 file changed, 9
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
Reviewed-by: Sakari Ailus
Reviewed-by: Tomasz Figa
Reviewed-by: Jacopo Mondi
Hi Sakari and Tomasz,
The two patches are the DT binding and driver for DW9807 VCM controller.
Alan Chiang (2):
media: dw9807: Add dw9807 vcm driver
media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
.../bindings/media/i2c/dongwoon,dw9807.txt | 9 +
MAINTAINERS
From: Jason Chen
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
Signed-off-by: Alan Chiang
Reviewed-by: Sakari Ailus
Reviewed-by: Tomasz Figa
---
since v2:
-- Update
Hi Rob,
Apologize missed your comment before sent out v8. I will definitely add
acks/reviewed-bys in next version.
Regards, Andy
-Original Message-
From: Rob Herring [mailto:r...@kernel.org]
Sent: Friday, April 13, 2018 11:11 PM
To: Yeh, Andy
Cc: linux-media@vger.kernel.org
ysical limitations).
Sakari:
For that purpose I'd add a new control. The user process shouldn't wait in
the kernel for just the sake of this. In order to meaningfully control the
focussing process, the user space would have to know some properties of the
lens anyway, so this information w
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
From: Alan Chiang
Dongwoon DW9807 is a voice coil lens driver.
Signed-off-by: Andy Yeh
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 file changed, 9 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
diff
Hi Sakari and Tomasz,
The two patches are the DT binding and driver for DW9807 VCM controller.
Alan Chiang (2):
media: dw9807: Add dw9807 vcm driver
media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
.../bindings/media/i2c/dongwoon,dw9807.txt | 9 +
MAINTAINERS
nd, u8 value);
> +#else
> +static inline int sony_pic_camera_command(int command, u8 value) { return 0;
> };
> +#endif
>
> #endif /* __KERNEL__ */
--
With Best Regards,
Andy Shevchenko
We are re-implementing this patch. So obsolete this patch from list first.
https://patchwork.linuxtv.org/patch/48722/
Permalink /patch/48722/
State Obsoleted
Regards, Andy
-Original Message-
From: Yeh, Andy
Sent: Monday, April 16, 2018 11:04 PM
To: linux-media@vger.kernel.org
Cc
From: Jason Chen
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
Signed-off-by: Alan Chiang
---
ince v2:
-- Update the streaming function to remove SW_STANDBY in the
Hi Jacopo,
Excuse for late reply, we were busy in past weeks for major milestone. Please
kindly check the revised V7 which has been uploaded.
https://patchwork.linuxtv.org/patch/48589/
Responded to your comments as below.
Cc in Tomasz for unintentionally missed.
Regards, Andy
-Original
From: Alan Chiang
Dongwoon DW9807 is a voice coil lens driver.
Signed-off-by: Andy Yeh
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 file changed, 9 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
diff
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
Hi Sakari and Tomasz,
The two patches are the DT binding and driver for DW9807 VCM controller.
Alan Chiang (2):
media: dw9807: Add dw9807 vcm driver
media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
.../bindings/media/i2c/dongwoon,dw9807.txt | 9 +
MAINTAINERS
2 *wdata = (void *)&data[2];
> +
> + *wdata = be32_to_cpu(*(__be32 *)&data[2]);
For x86 it is okay, though in general it should use get_unaligned().
--
Andy Shevchenko
Intel Finland Oy
Got it. We shall reverse the order in the later submission on list.
Regards, Andy
-Original Message-
From: sakari.ai...@linux.intel.com [mailto:sakari.ai...@linux.intel.com]
Sent: Thursday, March 22, 2018 1:07 AM
To: Yeh, Andy
Cc: jacopo mondi ; linux-media@vger.kernel.org;
devicet
complete and submit it after full internal
verification.
Regards, Andy
-Original Message-
From: Sakari Ailus [mailto:sakari.ai...@iki.fi]
Sent: Friday, March 23, 2018 10:30 PM
To: Tomasz Figa
Cc: Sakari Ailus ; Yeh, Andy
; Linux Media Mailing List ;
Chen, JasonX Z ; Chiang, AlanX
; Lai
Thanks for the comments. A quick question first. For the reset we need some
time to address.
-Original Message-
From: jacopo mondi [mailto:jac...@jmondi.org]
Sent: Tuesday, March 20, 2018 6:28 PM
To: Yeh, Andy
Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com;
devicet
Done. Thanks Sakari.
Regards, Andy
-Original Message-
From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
Sent: Saturday, March 17, 2018 12:47 AM
To: Yeh, Andy
Cc: linux-media@vger.kernel.org
Subject: Re: [v6 0/2] DW9807 DT binding and driver patches
On Sat, Mar 17, 2018 at 12:49
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
Hi Sakari and Tomasz,
The two patches are the DT binding and driver for DW9807 VCM controller.
Alan Chiang (2):
media: dw9807: Add dw9807 vcm driver
media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
.../bindings/media/i2c/dongwoon,dw9807.txt | 9 +
MAINTAINERS
From: Alan Chiang
Dongwoon DW9807 is a voice coil lens driver.
Signed-off-by: Andy Yeh
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 file changed, 9 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
diff
From: Alan Chiang
Dongwoon DW9807 is a voice coil lens driver.
Signed-off-by: Andy Yeh
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 file changed, 9 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt
diff
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
Hi Sakari and Tomasz,
The two patches are the DT binding and driver for DW9807 VCM controller.
Alan Chiang (2):
media: dw9807: Add dw9807 vcm driver
media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
.../bindings/media/i2c/dongwoon,dw9807.txt | 9 +
MAINTAINERS
Hi Ikp,
Per sync with Sakari, Mauro'd handle the pull request for
"v4l2_find_nearest_size" patch (https://patchwork.kernel.org/patch/10207087/)
early next week.
Hence only fixed a typo in v9.1. https://patchwork.linuxtv.org/patch/47976/
Thanks a lot!
Regards, Andy
-O
From: Jason Chen
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
Signed-off-by: Alan Chiang
---
since v2:
-- Update the streaming function to remove SW_STANDBY in the
Both comments are OKAY.
Thanks.
-Original Message-
From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
Sent: Thursday, March 15, 2018 6:31 AM
To: Yeh, Andy
Cc: linux-media@vger.kernel.org; tf...@chromium.org; Chen, JasonX Z
; Chiang, AlanX ; Lai, Jim
Subject: Re: [PATCH v8
From: Jason Chen
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
Signed-off-by: Alan Chiang
---
since v2:
-- Update the streaming function to remove SW_STANDBY in the
Sure will do. Thanks Sakari.
-Original Message-
From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
Sent: Thursday, March 15, 2018 6:31 AM
To: Yeh, Andy
Cc: linux-media@vger.kernel.org; tf...@chromium.org; Chen, JasonX Z
; Chiang, AlanX ; Lai, Jim
Subject: Re: [PATCH v8] media
Still wrong line break...
Please check the list instead. Thanks.
https://patchwork.linuxtv.org/patch/47936/
Regards, Andy
-Original Message-
From: Yeh, Andy
Sent: Thursday, March 15, 2018 12:24 AM
To: linux-media@vger.kernel.org; tf...@chromium.org
Cc: sakari.ai...@linux.intel.com; Yeh
Hi Tomasz,
Thanks for the comments. OKAY as inline.
Please check the Patch V8.
Regards, Andy
-Original Message-
From: Tomasz Figa [mailto:tf...@chromium.org]
Sent: Monday, March 12, 2018 3:33 PM
To: Yeh, Andy
Cc: Linux Media Mailing List ; Sakari Ailus
; Chen, JasonX Z ;
Chiang
From: Jason Chen
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
Signed-off-by: Alan Chiang
---
since v2:
-- Update the streaming function to remove SW_STANDBY in the
a release?
>
>> > I have no idea. Could you contact the original developers?
>> > The answer is interesting, but I have no idea.
>
>> It seems it will be included in the 4.16 release:
>
>> https://www.mail-archive.com/linux-media@vger.kernel.org/msg122619.html
>
>> Probably just a bit too late for 4.15.
>
>> Frederic
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With Best Regards,
Andy Shevchenko
> On Mar 11, 2018, at 12:51 PM, Nick French wrote:
>
> On Sat, Mar 10, 2018 at 10:20:23AM -0800, Andy Lutomirski wrote:
>>>> Perhaps the easy answer is to change the fatal is-pat-enabled check to just
>>>> a warning like "you have PAT enabled, so wc
e function to support writing 2 registers
+/* Mode : resolution and related config&values */ "\n" struct imx258_mode {
Therefore please help check the patch on the list, which is with correct line
break.
https://patchwork.linuxtv.org/patch/47869/
Sorry to bring you inconv
Okay. All comments are addressed in v7.
(https://patchwork.linuxtv.org/patch/47869/)
Thanks for all the comments and suggestions.
Regards, Andy
-Original Message-
From: Tomasz Figa [mailto:tf...@chromium.org]
Sent: Friday, March 2, 2018 11:44 PM
To: Yeh, Andy
Cc: Linux Media Mailing
imx258_free_controls(imx258);
+
+ return ret;
+}
+
+static int imx258_remove(struct i2c_client *client)
+{
+ struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ struct imx258 *imx258 = to_imx258(sd);
+
+ v4l2_async_unregister_subdev(sd);
+ media_entity_cleanup(&sd->entity);
+ imx258_free_controls(imx258);
+
+ pm_runtime_disable(&client->dev);
+ pm_runtime_set_suspended(&client->dev);
+
+ return 0;
+}
+
+static const struct dev_pm_ops imx258_pm_ops = {
+ SET_SYSTEM_SLEEP_PM_OPS(imx258_suspend, imx258_resume)
+};
+
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id imx258_acpi_ids[] = {
+ { "SONY258A" },
+ { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(acpi, imx258_acpi_ids);
+#endif
+
+static struct i2c_driver imx258_i2c_driver = {
+ .driver = {
+ .name = "imx258",
+ .pm = &imx258_pm_ops,
+ .acpi_match_table = ACPI_PTR(imx258_acpi_ids),
+ },
+ .probe_new = imx258_probe,
+ .remove = imx258_remove,
+};
+
+module_i2c_driver(imx258_i2c_driver);
+
+MODULE_AUTHOR("Yeh, Andy ");
+MODULE_AUTHOR("Chiang, Alan ");
+MODULE_AUTHOR("Chen, Jason ");
+MODULE_DESCRIPTION("Sony IMX258 sensor driver");
+MODULE_LICENSE("GPL v2");
--
2.7.4
> On Mar 10, 2018, at 8:57 AM, French, Nicholas A. wrote:
>
>> On Wed, Mar 07, 2018 at 11:23:09PM -0600, French, Nicholas A. wrote:
>>> On Thu, Mar 08, 2018 at 04:14:11AM +, Luis R. Rodriguez wrote:
On Thu, Mar 08, 2018 at 04:06:01AM +, Luis R. Rodriguez wrote:
> On Thu, Mar 0
Understood. Thank you Tomasz too.
-Original Message-
From: Tomasz Figa [mailto:tf...@chromium.org]
Sent: Friday, March 9, 2018 6:48 PM
To: Yeh, Andy
Cc: Sakari Ailus ; Linux Media Mailing List
; Chen, JasonX Z ;
Chiang, AlanX ; Lai, Jim
Subject: Re: [PATCH v8] media: imx258: Add
well.
We are working on addressing all those outstanding comments. Almost done.
Will do reply v6 with OKAY, and send to list a new v7 with all fixed.
Regards, Andy
-Original Message-
From: Tomasz Figa [mailto:tf...@chromium.org]
Sent: Friday, March 9, 2018 6:20 PM
To: Sakari Ailus
Cc
+
+error_media_entity:
+ media_entity_cleanup(&imx258->sd.entity);
+
+error_handler_free:
+ imx258_free_controls(imx258);
+
+ return ret;
+}
+
+static int imx258_remove(struct i2c_client *client)
+{
+ struct v4l2_subdev *sd = i2c_get_clientdata(client);
+ stru
t;dev);
+ pm_runtime_enable(&client->dev);
+ pm_runtime_idle(&client->dev);
+
+ return 0;
+
+error_media_entity:
+ media_entity_cleanup(&imx258->sd.entity);
+
+error_handler_free:
+ imx258_free_controls(imx258);
+
+ return ret;
+}
+
+static int imx258_remove(st
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
Signed-off-by: Jason Chen
Signed-off-by: Alan Chiang
---
since v2:
-- Update the streaming function to remove SW_STANDBY in
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
From: Alan Chiang
Dongwoon DW9807 is a voice coil lens driver.
Also add a vendor prefix for Dongwoon for one did not exist previously.
Signed-off-by: Andy Yeh
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 file changed, 9 insertions(+)
create mode
Hi Sakari and Tomasz,
The two patches are the DT binding and driver for DW9807 VCM controller.
Alan Chiang (2):
media: dw9807: Add dw9807 vcm driver
media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
.../bindings/media/i2c/dongwoon,dw9807.txt | 9 +
MAINTAINERS
-
With Best Regards,
Andy Shevchenko
1/2] media: dt-bindings: Add bindings for Dongwoon DW9807
voice coil
Dongwoon DW9807 is a voice coil lens driver.
Also add a vendor prefix for Dongwoon for one did not exist previously.
Signed-off-by: Andy Yeh
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 f
nother possibility to get rid of them under include/ by (re)moving to
drivers/auxdisplay/.
--
With Best Regards,
Andy Shevchenko
From: Alan Chiang
Dongwoon DW9807 is a voice coil lens driver.
Also add a vendor prefix for Dongwoon for one did not exist previously.
Signed-off-by: Andy Yeh
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 file changed, 9 insertions(+)
create mode
From: Alan Chiang
Hi Sakari and Tomasz,
The two patches are the DT binding and driver for DW9807 VCM controller.
Alan Chiang (2):
media: dw9807: Add dw9807 vcm driver
media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil
.../bindings/media/i2c/dongwoon,dw9807.txt | 9 +
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
Please ignore this. This is the wrong patch which has been obsoleted.
-Original Message-
From: Yeh, Andy
Sent: Tuesday, January 30, 2018 12:35 AM
To: linux-media@vger.kernel.org
Cc: Yeh, Andy ; sakari.ai...@linux.intel.com;
tf...@chromium.org; Chiang, AlanX
Subject: [PATCH v4] media
This is the right one. Sorry for inconvenience.
-Original Message-
From: Yeh, Andy
Sent: Tuesday, January 30, 2018 12:53 AM
To: linux-media@vger.kernel.org
Cc: Yeh, Andy ; sakari.ai...@linux.intel.com;
tf...@chromium.org; Chiang, AlanX
Subject: [PATCH v4] media: dw9807: Add dw9807 vcm
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
From: Alan Chiang
Dongwoon DW9807 is a voice coil lens driver.
Also add a vendor prefix for Dongwoon for one did not exist previously.
Signed-off-by: Andy Yeh
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 +
1 file changed, 9 insertions(+)
create mode
d '0' before "VCM MSB and LSB" registers are
written.
During ringing control mode operation, VBUSY bit keep '1'.
While VBUSY = '1', the I2C command for VCM is ignored.
"
Regards, Andy
-Original Message-
From: Sakari Ailus [mailto:sakari.ai...@linux
done for working
driver.
--
With Best Regards,
Andy Shevchenko
emove the OV8858 kconfig and files.
Fine with me. We can sort things out later (repository will have the
sources still in any case) when the driver itself shows signs of life.
--
Andy Shevchenko
Intel Finland Oy
Fix a few sparse warnings related to conversion between CPU and big endian.
Also simplify the code in the process.
Signed-off-by: Sakari Ailus
Acked-by: Andy Yeh
---
since v2:
- Count loop downwards, not up.
drivers/media/i2c/imx258.c | 23 +--
1 file changed, 9
On Fri, Jan 26, 2018 at 2:49 PM, LABBE Corentin wrote:
> On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote:
>> On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote:
>> > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe
>> > wrote:
&
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
Signed-off-by: Jason Chen
Signed-off-by: Alan Chiang
---
since v2:
-- Update the streaming function to remove SW_STANDBY in
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice
coil motor. This driver creates a V4L2 subdevice and provides control to set
the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice
coil motor. This driver creates a V4L2 subdevice and provides control to set
the desired focus.
Signed-off-by: Andy Yeh
---
since v1:
- changed author.
since v2:
- addressed outstanding comments
ardware to test? This is *most* important reason
why to accept or decline a change to the driver.
--
With Best Regards,
Andy Shevchenko
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Andy Yeh
---
- v2->v3
-- Update the streaming function to remove SW_STANDBY in the beginning.
-- Adjust the delay time from 1ms to 1
From: Alan Chiang
DW9807 is a 10 bit DAC from Dongwoon, designed for linear
control of voice coil motor.
This driver creates a V4L2 subdevice and
provides control to set the desired focus.
Signed-off-by: Andy Yeh
Signed-off-by: Sakari Ailus
---
v2: changed author
.../bindings/media/i2c
1 - 100 of 1679 matches
Mail list logo
