Re: adp1653 usage

. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] adp1653: set media entity type

The type of a media entity is default for this driver. This patch makes it explicitly defined as MEDIA_ENT_T_V4L2_SUBDEV_FLASH. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/adp1653.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

adp1653 usage

? - if there is no v4l-subdevX device node, when and how the kernel runs -open() and -close() methods of v4l2_subdev_internal_ops? -- Andy Shevchenko andriy.shevche...@intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCHv2] adp1653: check error code of adp1653_init_controls

(flash-subdev.entity, 0, NULL, 0); done: if (ret 0) { v4l2_ctrl_handler_free(flash-ctrls); kfree(flash); } return ret; There is no difference at first glance. However, your variant is less straight to understand for my opinion. -- Andy

Re: [PATCH] adp1653: check error code of adp1653_init_controls

On Wed, 2011-07-27 at 11:15 +0300, Sakari Ailus wrote: On Wed, Jul 27, 2011 at 10:58:02AM +0300, Andy Shevchenko wrote: Potentially the adp1653_init_controls could return an error. In our case the error was ignored, meanwhile it means incorrect initialization of V4L2 controls. Hi, Andy

[PATCHv2] adp1653: check error code of adp1653_init_controls

Potentially the adp1653_init_controls could return an error. In our case the error was ignored, meanwhile it means incorrect initialization of V4L2 controls. Additionally we have to free control handler structures in case of apd1653_init_controls or media_entity_init failure. Signed-off-by: Andy

[PATCH] adp1653: check error code of adp1653_init_controls

Potentially the adp1653_init_controls could return an error. In our case the error was ignored, meanwhile it means incorrect initialization of V4L2 controls. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Sakari Ailus sakari.ai

Re: v4l2 api for flash drivers

. However, the question is why have you chosen hardware units for *_INTENSITY instead of, let say, hundredth of percents (like 0 .. 1)? -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

[PATCH] adp1653: check platform_data before usage

The driver requires platform_data to be present. That's why we need to check and fail in case of the absence of necessary data. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Sakari Ailus sakari.ai...@iki.fi --- drivers/media

v4l2 api for flash drivers

Hello. I didn't see the patchset [1] in any public tree on git.kernel.org. Is this patch going to be pushed? [1] http://www.spinics.net/lists/linux-media/msg32527.html -- Andy Shevchenko andriy.shevche...@intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe

[PATCH 1/2] dvb: mantis: use '%pM' format to print MAC address

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/dvb/mantis/mantis_core.c |5 + drivers/media/dvb/mantis/mantis_ioc.c |9 + 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/media/dvb/mantis/mantis_core.c b/drivers/media/dvb

[PATCH 2/2] media: cx23885: use '%pM' format to print MAC address

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/video/cx23885/cx23885-dvb.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c index 3d70af2..eca7247 100644

[PATCHv2 1/2] dvb: mantis: use '%pM' format to print MAC address

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/dvb/mantis/mantis_core.c |5 + drivers/media/dvb/mantis/mantis_ioc.c |9 + 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/media/dvb/mantis/mantis_core.c b/drivers/media/dvb

[PATCHv2 2/2] media: cx23885: use '%pM' format to print MAC address

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/video/cx23885/cx23885-dvb.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c index 3d70af2..0674ea1 100644

[PATCH 1/2] drivers: usbvideo: remove custom implementation of hex_to_bin()

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/video/usbvideo/usbvideo.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/usbvideo/usbvideo.c b/drivers/media/video/usbvideo/usbvideo.c index 5ac37c6..f1fcf97 100644

[PATCH 2/2] media: video: pvrusb2: remove custom hex_to_bin()

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com Cc: Mike Isely is...@pobox.com --- drivers/media/video/pvrusb2/pvrusb2-debugifc.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/media/video/pvrusb2/pvrusb2-debugifc.c b/drivers/media/video

[PATCH 1/2] media: video: pwc: Use kernel's simple_strtol()

From: Andy Shevchenko ext-andriy.shevche...@nokia.com Change own implementation of pwc_atoi() by simple_strtol(x, NULL, 10). Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com Acked-by: Pekka Enberg penb...@cs.helsinki.fi --- drivers/media/video/pwc/pwc-if.c | 23

[PATCH 2/2] atoi: Drop custom atoi from drivers/video/modedb.c

From: Andy Shevchenko ext-andriy.shevche...@nokia.com Kernel has simple_strtol() implementation which could be used as atoi(). Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com --- drivers/video/modedb.c | 24 +--- 1 files changed, 5 insertions(+), 19

<    1   2   3