Re: [RFC PATCH 5/5] v4l2-ctl: add an option to list controls in a machine-readable format

2019-01-09 Thread Antonio Ospite
On Mon, 7 Jan 2019 11:18:58 +0100 Hans Verkuil wrote: > On 01/03/2019 07:01 PM, Antonio Ospite wrote: > > Add a new option --list-ctrls-values to list the values of controls in > > a format which can be passed again to --set-ctrl. > > > > This can be useful to save

[RFC PATCH 3/5] v4l2-ctl: use a dedicated function to print the control class name

2019-01-03 Thread Antonio Ospite
. Signed-off-by: Antonio Ospite --- utils/v4l2-ctl/v4l2-ctl-common.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp index e2710335..5d41d720 100644 --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp +++ b

[RFC PATCH 5/5] v4l2-ctl: add an option to list controls in a machine-readable format

2019-01-03 Thread Antonio Ospite
)" The new option has been tested with the vivid driver and it works well enough to be useful with a real driver as well. String controls are not supported for now, as they may not be parsed correctly by --set-ctrl if they contain a comma or a single quote. Signed-off-by: Antonio Ospite --- uti

[RFC PATCH 2/5] v4l2-ctl: list once when both OptListCtrls and OptListCtrlsMenus are there

2019-01-03 Thread Antonio Ospite
When both --list-ctrls and --list-ctrls-menus are passed, controls are listed twice which is accurate but can be confusing. Treat --list-ctrls-menus as an option modifier when also --list-ctrls is passed, in order to have the controls listed only once. Signed-off-by: Antonio Ospite --- utils

[RFC PATCH 4/5] v4l2-ctl: abstract the mechanism used to print the list of controls

2019-01-03 Thread Antonio Ospite
controls. Signed-off-by: Antonio Ospite --- utils/v4l2-ctl/v4l2-ctl-common.cpp | 32 -- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp index 5d41d720..b45c 100644 --- a/utils

[RFC PATCH 0/5] v4l2-ctl: list controls values in a machine-readable format

2019-01-03 Thread Antonio Ospite
codebase, patch 2 is a small preparatory cleanup, and patches 4 and 5 showcase the idea. Thanks, Antonio Antonio Ospite (5): v4l2-ctl: list controls with menus when OptAll is specified v4l2-ctl: list once when both OptListCtrls and OptListCtrlsMenus are there v4l2-ctl: use a dedicated

[RFC PATCH 1/5] v4l2-ctl: list controls with menus when OptAll is specified

2019-01-03 Thread Antonio Ospite
When calling "v4l2-ctl --all" the user may expect the most comprehensive output, so also print the menus when listing controls. Signed-off-by: Antonio Ospite --- utils/v4l2-ctl/v4l2-ctl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/v4l2-ctl/v4l2-ctl.c

[v4l-utils] Add options to v4l2-ctrl to save/load settings to/from a file

2018-11-24 Thread Antonio Ospite
//git.alsa-project.org/?p=alsa-utils.git;a=tree;f=alsactl;hb=HEAD [1] https://superuser.com/questions/471597/linux-v4l-webcam-make-settings-stick [2] https://git.ao2.it/v4l2-persistent-settings.git/ [3] https://sourceforge.net/projects/v4l2ucp/ -- Antonio Ospite https://ao2.it https://twitter.com/

Re: [RFC] v4l2 support for thermopile devices

2016-11-03 Thread Antonio Ospite
9e42579fd After that any v4l2 program using libv4l2 will at least be able to show _an_ image. You can play with "false color" representations too in libv4lconvert, however I don't know if such representations are generic enough to be mainlined, in the Kinect case the false color rep

Re: gstreamer and v4l2

2016-03-15 Thread Antonio Ospite
device="/dev/video0" ! > video/x-raw,width=640,height=180,framerate=30 ! autovideosink > > But it keeps giving me auto negotiation error -4. > Trying to give other values did not help neither. BTW, the need for videoconvert is more likely because of the pixelformat rather than the frame

Re: [PATCH 7/7] [media] gspca: fix a v4l2-compliance failure during read()

2016-03-14 Thread Antonio Ospite
On Thu, 10 Mar 2016 16:59:45 +0100 Hans de Goede wrote: > Hi, > > On 09-03-16 17:03, Antonio Ospite wrote: > > v4l2-compliance fails with this message: > > > >fail: v4l2-test-buffers.cpp(512): Expected EBUSY, got 22 > >test VIDIOC_REQBUFS/CREATE_BUFS/

Re: [PATCH 6/7] [media] gspca: fix a v4l2-compliance failure during VIDIOC_REQBUFS

2016-03-14 Thread Antonio Ospite
On Thu, 10 Mar 2016 15:54:37 +0100 Hans de Goede wrote: > Hi, > > On 09-03-16 17:03, Antonio Ospite wrote: > > When calling VIDIOC_REQBUFS v4l2-compliance fails with this message: > > > >fail: v4l2-test-buffers.cpp(476): q.reqbufs(node, 1) > >test VI

[PATCH 6/7] [media] gspca: fix a v4l2-compliance failure during VIDIOC_REQBUFS

2016-03-09 Thread Antonio Ospite
/videobuf2-core.c::vb2_core_reqbufs() seems to confirm this interpretation; however gspca is just returning -EBUSY in this case. Removing the special handling for the case of a different memory value fixes the compliance failure. Signed-off-by: Antonio Ospite --- This should be safe, but I'd r

[PATCH 4/7] [media] gspca: fix a v4l2-compliance failure about VIDIOC_ENUM_FRAMEINTERVALS

2016-03-09 Thread Antonio Ospite
. Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/gspca.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c index 1bb7901..61cb16d 100644 --- a/drivers/media/usb/gspca/gspca.c +++ b

[PATCH 0/7] gspca: pass all v4l2-compliance tests + minor fixes

2016-03-09 Thread Antonio Ospite
it's also a preliminary change for patch 4. - Patches from 4 to 7 are the actual compliance fixes. More details are in the commit messages. Thanks, Antonio Antonio Ospite (7): [media] gspca: ov534/topro: use a define for the default framerate [media] gspca: fix setting frame int

[PATCH 2/7] [media] gspca: fix setting frame interval type in vidioc_enum_frameintervals()

2016-03-09 Thread Antonio Ospite
Set the frame _interval_ type to V4L2_FRMIVAL_TYPE_DISCRETE instead of using V4L2_FRMSIZE_TYPE_DISCRETE which is meant for frame _size_. The old and new values happen to be the same so there is no functional change. Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/gspca.c | 2 +- 1

[PATCH 3/7] [media] gspca: rename wxh_to_mode() to wxh_to_nearest_mode()

2016-03-09 Thread Antonio Ospite
The name wxh_to_nearest_mode() reflects better what the function does. Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/gspca.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c index 9c8990f

[PATCH 5/7] [media] gspca: fix a v4l2-compliance failure about buffer timestamp

2016-03-09 Thread Antonio Ospite
pca uses v4l2_get_timestamp() which uses ktime_get_ts() which uses ktime_get_ts64() which returns a monotonic timestamp, so it's safe to initialize the buffer flags to V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC to fix the failure. Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/gspca.c | 2 +- 1 fi

[PATCH 1/7] [media] gspca: ov534/topro: use a define for the default framerate

2016-03-09 Thread Antonio Ospite
amerate has its own define to avoid risking using different values in different places, and for readability. While at it also remove some trivial comments about the framerates which don't add much to the code anymore. Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/ov534.c | 7 +++---

[PATCH 7/7] [media] gspca: fix a v4l2-compliance failure during read()

2016-03-09 Thread Antonio Ospite
calls frame_ready_nolock() but the latter returns -EINVAL in a case when v4l2-compliance expects -EBUSY. Fix the failure by changing the return value in frame_ready_nolock(). Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/gspca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] [media] gspca: ov534/topro: prevent a division by 0

2015-10-23 Thread Antonio Ospite
On Sat, 3 Oct 2015 10:14:17 +0200 Hans de Goede wrote: > Hi, > Hi HdG, > On 02-10-15 22:33, Antonio Ospite wrote: [...] > > Signed-off-by: Antonio Ospite > > Cc: sta...@vger.kernel.org > > Good catch: > > Reviewed-by: Hans de Goede > > Mauro can you

Re: v4l2-ctrl is unable to set autogain to 0 with gspca/ov534

2015-10-14 Thread Antonio Ospite
On Mon, 12 Oct 2015 09:56:08 +0200 Hans Verkuil wrote: > Hi Antonio, > > On 10/07/2015 10:05 AM, Antonio Ospite wrote: [...] > > After a little investigation I figured out some more details: in my use > > case the autogain is a master control in an auto cluster, and switc

[PATCH] [media] media/v4l2-ctrls: fix setting autocluster to manual with VIDIOC_S_CTRL

2015-10-14 Thread Antonio Ospite
x the original bug by making update_from_auto_cluster() not override the new master control value. Signed-off-by: Antonio Ospite Cc: # for v3.17 and up --- Hi, I did check the patch with scripts/checkpatch.pl but it gives an error, I think it's a false positive. Ciao ciao, Antonio dri

v4l2-ctrl is unable to set autogain to 0 with gspca/ov534

2015-10-07 Thread Antonio Ospite
trol, in this case when it's being changed from auto to manual. I may be missing some details tho, so I am asking if my reasoning is correct before sending a proper patch. And should I CC stable on it as the change fixes a regression? Thanks, Antonio -- Antonio Ospite http://ao2.it A:

gspca/ov534 gets two failures with v4l2-compliance

2015-10-03 Thread Antonio Ospite
ftype_pixfmts does not get populated because of the first failure. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscr

[PATCH] [media] gspca: ov534/topro: prevent a division by 0

2015-10-02 Thread Antonio Ospite
issue by resetting the frame rate to a default value in case of an unusable timeperframe. The fix is done in the subdrivers instead of gspca.c because only the subdrivers have notion of a default frame rate to reset the camera to. Signed-off-by: Antonio Ospite Cc: sta...@vger.kernel.org --- Hi, I

[PATCH 07/12] trivial: [media] cx25821: cx25821-medusa-reg.h: fix 0x0x prefix

2015-04-28 Thread Antonio Ospite
Fix the 0x0x prefix in integer constants. In this case a padding 0 must also be inserted to make the constants look like all the other 16 bits ones. Signed-off-by: Antonio Ospite Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/pci/cx25821/cx25821-medusa-reg.h | 6

Re: input_polldev interval (was Re: [sur40] Debugging a race condition)?

2015-03-26 Thread Antonio Ospite
oader (i.e. before lading another linux instance) and then scrape the dump to look for the kernel messages, but AFAIK this is not going to be reliable —or even possible— on a more complex system. Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people no

Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant

2015-01-06 Thread Antonio Ospite
On Tue, 28 Oct 2014 15:39:41 +0100 Antonio Ospite wrote: > On Mon, 14 Jul 2014 12:27:57 +0200 > Hans de Goede wrote: > > > Hi, > > > > On 07/11/2014 02:56 PM, Antonio Ospite wrote: > > > Signed-off-by: Antonio Ospite > > > > Thanks, I

Re: [PATCH 1/1] gspca: Add high-speed modes for PS3 Eye camera

2015-01-04 Thread Antonio Ospite
nge supports such high frame rates. > > Correct a QVGA mode that was listed as 40 FPS. It is really 37 FPS > (half of 75 FPS). > > Tests confirm that the nominal frame rates are achieved. > > Signed-off-by: Joe Howse Tested-by: Antonio Ospite Thanks Joe. I noticed t

Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant

2014-10-28 Thread Antonio Ospite
On Mon, 14 Jul 2014 12:27:57 +0200 Hans de Goede wrote: > Hi, > > On 07/11/2014 02:56 PM, Antonio Ospite wrote: > > Signed-off-by: Antonio Ospite > > Thanks, I've added this to my tree and send a pull-req for it > to Mauro. > Hi Hans, I still don't see

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-08 Thread Antonio Ospite
f -libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c +libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c libv4l-devconfig-parser.c libv4l_exynos4_camera_la_CPPFLAGS = -fvisibility=hidden -std=gnu99 libv4l_exynos4_camera_la_LDFLAGS = -avoid-version -module -shared -export-dynamic -lp

Re: [PATCH 02/12] trivial: drivers/media/usb/gspca/gspca.h: indent with TABs, not spaces

2014-09-01 Thread Antonio Ospite
On Wed, 4 Jun 2014 14:03:40 +0200 Antonio Ospite wrote: > Signed-off-by: Antonio Ospite > Cc: Hans de Goede > Cc: linux-media@vger.kernel.org Ping. linux-media patchwork link: https://patchwork.linuxtv.org/patch/24156/ Thanks, Antonio > --- > drivers/media/usb/gspca/gspc

Re: [PATCH 01/12] trivial: drivers/media/usb/gspca/gspca.c: fix the indentation of a comment

2014-09-01 Thread Antonio Ospite
On Wed, 4 Jun 2014 14:03:39 +0200 Antonio Ospite wrote: > Fix indentation of a comment, put it on the same level of the code it > refers to. > > Signed-off-by: Antonio Ospite > Cc: Hans de Goede > Cc: linux-media@vger.kernel.org Ping, I cannot see this in any upstream repos

Re: [PATCH 12/29] kinect: fix sparse warnings

2014-08-21 Thread Antonio Ospite
d on why I overlooked the issue: libfreenect —which is where the code originally comes from— uses the _same_ function for cpu_to_* and *_to_cpu conversions, and this is practically OK on common architectures even though it is not semantically correct. Thanks for the fix. > > Signed-off-by

Re: [PATCHv1 02/12] vivid.txt: add documentation for the vivid driver.

2014-08-01 Thread Antonio Ospite
that to implement Hue support. > I don't know what your requirements are here but JFTR there is already a simplistic implementation of fixed point operations in include/linux/fixp-arith.h I used them in drivers/media/usb/gspca/ov534.c for some hue calculation. Ciao, Antonio -- Ant

Re: [PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

2014-07-29 Thread Antonio Ospite
On Tue, 29 Jul 2014 07:37:44 +0200 Matthias Schwarzott wrote: > On 23.07.2014 22:10, Antonio Ospite wrote: > > On Wed, 23 Jul 2014 21:03:14 +0200 > > Matthias Schwarzott wrote: > > > > [...] > >> The crc value: > >> It protects the cont

Re: [PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

2014-07-23 Thread Antonio Ospite
ksum -a all -F "#ALGONAME{i} = #CHECKSUM{i}" payload.bin Ciao, Antonio [1] http://www.jonelo.de/java/jacksum/ -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-postin

[PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant

2014-07-11 Thread Antonio Ospite
Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c index 49d209b..6ac93d8 100644 --- a/drivers/media/usb/gspca

[PATCH 2/2] gspca_kinect: add support for the depth stream

2014-06-25 Thread Antonio Ospite
Add support for the depth stream at 10bpp, for now use a 'depth_mode' command line parameter to switch between video and depth mode. Signed-off-by: Alexander Sosna Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/kinect.c | 98 +++- 1 fi

[PATCH 0/2] gspca, gspca_kinect: add support for the depth stream

2014-06-25 Thread Antonio Ospite
Hi, here are the patches to make gspca able to deal with the Kinect depth stream at 10bpp. If anyone is really interested in the 11bpp data too, ping me. Alexander, please let us know if you can test these anytime soon. Thanks, Antonio Antonio Ospite (2): gspca: provide a mechanism to

[PATCH 1/2] gspca: provide a mechanism to select a specific transfer endpoint

2014-06-25 Thread Antonio Ospite
field to struct gspca_dev, and change alt_xfer() so that it accepts a parameter which represents a specific endpoint address to look for. If a subdriver wants to specify a value for gspca_dev->xfer_ep it can do that in its sd_config() callback. Signed-off-by: Antonio Ospite --- drivers/media/

Re: [RFC 2/2] gspca_kinect: add support for the depth stream

2014-06-25 Thread Antonio Ospite
On Thu, 19 Jun 2014 16:35:17 +0200 Hans de Goede wrote: > Hi, > > On 06/04/2014 10:24 PM, Antonio Ospite wrote: > > Add support for the depth mode at 10bpp, use a command line parameter to > > switch mode. > > > > NOTE: this is just a proof-of-concept, the fina

Re: [RFC 1/2] gspca: provide a mechanism to select a specific transfer endpoint

2014-06-24 Thread Antonio Ospite
On Thu, 19 Jun 2014 16:27:59 +0200 Hans de Goede wrote: > Hi Antonio, > > Thanks for working on this. > > On 06/04/2014 10:24 PM, Antonio Ospite wrote: > > Add a xfer_ep_index field to struct gspca_dev, and change alt_xfer() so > > that it accepts a parameter

Re: [PATCH RESEND] libv4lconvert: Fix a regression when converting from Y10B

2014-06-18 Thread Antonio Ospite
On Wed, 18 Jun 2014 15:59:13 +0200 Hans de Goede wrote: > Hi, > > On 06/18/2014 03:23 PM, Antonio Ospite wrote: > > On Wed, 18 Jun 2014 13:46:10 +0200 > > Hans de Goede wrote: > > > >> Hi, > >> > >> On 06/18/2014 01:43 PM, Hans de Goe

Re: [PATCH RESEND] libv4lconvert: Fix a regression when converting from Y10B

2014-06-18 Thread Antonio Ospite
On Wed, 18 Jun 2014 13:46:10 +0200 Hans de Goede wrote: > Hi, > > On 06/18/2014 01:43 PM, Hans de Goede wrote: > > Hi, > > > > On 06/16/2014 05:00 PM, Antonio Ospite wrote: > >> Fix a regression introduced in commit > >> efc29f1764a30808ebf7b3

[PATCH RESEND] libv4lconvert: Fix a regression when converting from Y10B

2014-06-16 Thread Antonio Ospite
9bf641 this (maybe weird) logic was misunderstood and v4lconvert_convert_pixfmt() was made to return an error even in the case of a successful conversion from Y10B. Fix the check, and now print only the message letting the errno and the result from the conversion routines to be propagated to the

[RFC 0/2] gspca_kinect: add support for the depth stream

2014-06-04 Thread Antonio Ospite
stream in the mainline driver. The first patch is about supporting data streams on endpoints other than the first one in gspca. The second patch adds support for the depth data to the kinect subdriver. Some more specific comments are annotated per-patch. Ciao ciao, Antonio Antonio Ospite (2

[RFC 1/2] gspca: provide a mechanism to select a specific transfer endpoint

2014-06-04 Thread Antonio Ospite
Add a xfer_ep_index field to struct gspca_dev, and change alt_xfer() so that it accepts a parameter which represents a specific endpoint to look for. If a subdriver wants to specify a value for gspca_dev->xfer_ep_index it can do that in its sd_config() callback. Signed-off-by: Antonio Osp

[RFC 2/2] gspca_kinect: add support for the depth stream

2014-06-04 Thread Antonio Ospite
: Antonio Ospite --- For now a command line parameter called "depth_mode" is used to select which mode to activate when loading the driver, this is necessary because gspca is not quite ready to have a subdriver call gspca_dev_probe() multiple times. The problem seems to be that gspca assumes

[PATCH 01/12] trivial: drivers/media/usb/gspca/gspca.c: fix the indentation of a comment

2014-06-04 Thread Antonio Ospite
Fix indentation of a comment, put it on the same level of the code it refers to. Signed-off-by: Antonio Ospite Cc: Hans de Goede Cc: linux-media@vger.kernel.org --- drivers/media/usb/gspca/gspca.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/gspca

[PATCH 02/12] trivial: drivers/media/usb/gspca/gspca.h: indent with TABs, not spaces

2014-06-04 Thread Antonio Ospite
Signed-off-by: Antonio Ospite Cc: Hans de Goede Cc: linux-media@vger.kernel.org --- drivers/media/usb/gspca/gspca.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/gspca.h b/drivers/media/usb/gspca/gspca.h index 300642d..c1273e5 100644 --- a/drivers

Re: [PATCH] libv4lconvert: Fix a regression when converting from Y10B

2014-06-03 Thread Antonio Ospite
On Tue, 3 Jun 2014 15:48:46 +0200 Antonio Ospite wrote: > Fix a regression introduced in commit > efc29f1764a30808ebf7b3e1d9bfa27b909bf641 (libv4lconvert: Reject too > short source buffer before accessing it). > > The old code: > > case V4L2_PIX_FMT_Y10BPACK: >

[PATCH] libv4lconvert: Fix a regression when converting from Y10B

2014-06-03 Thread Antonio Ospite
9bf641 this (maybe weird) logic was misunderstood and the v4lconvert_convert_pixfmt() was made to return an error even in the case of a successful conversion from Y10B. Fix the check, and now print only the message letting the errno and the result from the conversion routines to be propagated to the

Re: GSPCA ov534 payload error

2014-02-17 Thread Antonio Ospite
l:564ov534 2-2.3:1.0: bulk irq > [ 801.287139] ov534 2-2.3:1.0: packet l:12ov534 2-2.3:1.0: payload error > ... > > Is this likely to be a problem with the gspca ov534 driver or with the > USB subsystem? > Oscillating packet sizes (l:12, l:8768, l:564), looks more like an USB i

[PATCH 1/2] gspca_kinect: fix kinect_read() error path

2013-12-30 Thread Antonio Ospite
eport with -EREMOTEIO the case of a partial transfer. Reported-by: Julia Lawall Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/kinect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/kinect.c b/drivers/media/usb/gspca/kinect.c index 3773a8a

[PATCH 2/2] gspca_kinect: fix messages about kinect_read() return value

2013-12-30 Thread Antonio Ospite
Messages relative to kinect_read() are printing "res" which contains the return value of a previous kinect_write(). Print the correct value in the messages. Cc: Julia Lawall Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/kinect.c | 5 +++-- 1 file changed, 3 insert

Re: question about drivers/media/usb/gspca/kinect.c

2013-12-30 Thread Antonio Ospite
} actual_len -= sizeof(*rhdr); Proper patches on their way, to libfreenect too. Thanks again, Antonio [1] http://lxr.linux.no/#linux+v3.12.6/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c#L37 [2] http://lxr.linux.no/#linux+v3.12.6/Documentation/usb/error-codes.txt#L134 [3] https://github.com/O

[PATCH 1/2] [media] Documentation/DocBook/media/v4l/subdev-formats.xml: fix a typo

2013-12-16 Thread Antonio Ospite
The xref to the v4l2-mbus-pixelcode-yuv8 table gets rendered as "Table 4.22, “YUV Formats”", so use the verb in the third person singular because it refers to "Table": s/list/lists/ Signed-off-by: Antonio Ospite --- Documentation/DocBook/media/v4l/subdev-formats.xml | 2 +

[PATCH 0/2] Documentation/DocBook/media/v4l: typos

2013-12-16 Thread Antonio Ospite
Hi, here are a couple of fixes for typos in Documentation/DocBook/media/v4l/subdev-formats.xml Ciao, Antonio Antonio Ospite (2): [media] Documentation/DocBook/media/v4l/subdev-formats.xml: fix a typo [media] Documentation/DocBook/media/v4l: fix typo, s/packet/packed/ Documentation

[PATCH 2/2] [media] Documentation/DocBook/media/v4l: fix typo, s/packet/packed/

2013-12-16 Thread Antonio Ospite
Change "packet" to "packed" where the doc is talking about packed data formats. Signed-off-by: Antonio Ospite --- Documentation/DocBook/media/v4l/subdev-formats.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/DocBook/media/v4l/s

Re: [PATCH] [media] gspca-ov534: don't call sd_start() from sd_init()

2013-08-20 Thread Antonio Ospite
hen have it picked up for inclusion in stable releases, I was just wondering why you didn't consider it as a fix for 3.11, the patch fixes an actual crash experienced by a user. Regards, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally r

[PATCH] [media] gspca-ov534: don't call sd_start() from sd_init()

2013-08-15 Thread Antonio Ospite
f8 02 77 09 80 b8 20 8c 3c a0 00 74 1d 48 RIP [] v4l2_ctrl_g_ctrl+0x11/0x60 [videodev] RSP CR2: 0050 ---[ end trace 6786f15abfd2ac90 ]--- Original bug report from: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1173723/ Signed-off-by: Antonio Ospite Tested-by: Ya

[PATCH RFC] [media] gspca-ov534: don't call sd_start() from sd_init()

2013-08-04 Thread Antonio Ospite
--- Hi Yaroslav, the patch below should fix the Oops caused by sd_start() called too early, but I am not sure about why sd_start() was called from sd_init() for Hercules webcams in the first place, maybe the snippet marked with: /* (from ms-win trace) */ in sd_start() must be moved to sd_init

Re: [Regression 3.5->3.6, bisected] gspca_ov534: kernel oops when connecting Hercules Blog Webcam

2013-07-31 Thread Antonio Ospite
a look this week-end. [...] > Additional info can be found here: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1173723/ I saw you also tested with 3.11-rc2 kernel, and the issue is still there: https://launchpadlibrarian.net/145608306/kern.log Thanks, Antonio -- Antonio Ospite ht

Re: [PATCH] m920x: silence compiler warning

2013-03-11 Thread Antonio Ospite
: note: ‘ret’ was declared here > > Signed-off-by: Antti Palosaari Acked-by: Antonio Ospite And thanks. BTW Antti, there was another patch for this warning: http://thread.gmane.org/gmane.linux.kernel/1450717 but your change is easier to validate. > --- > drivers/media/usb/dvb-usb/

Re: [PATCH 0/2] A couple documentation fixes for media stuff

2013-02-06 Thread Antonio Ospite
On Mon, 28 Jan 2013 22:45:30 +0100 Antonio Ospite wrote: > From: Antonio Ospite > > Take a look at the per-patch annotations too, please. Ping on this series. > Thanks, > Antonio > > Antonio Ospite (2): > [media] Documentation/media-framework.txt: f

Re: On MIPI-CSI2 YUV420 formats and V4L2 Media Bus formats

2013-02-06 Thread Antonio Ospite
On Wed, 30 Jan 2013 01:23:48 +0100 Laurent Pinchart wrote: > Hi Antonio, > Sorry for the delay Laurent and thanks for your reply, some more questions below. > On Monday 28 January 2013 13:22:10 Antonio Ospite wrote: > > Hi, > > > > looking at the MIPI Alliance Spec

[PATCH 1/2] [media] Documentation/media-framework.txt: fix a sentence

2013-01-28 Thread Antonio Ospite
From: Antonio Ospite Signed-off-by: Antonio Ospite --- Hi, Actually I am not 100% sure whether the old form was correct English already or not but the new one sounds better to me. Thanks, Antonio Documentation/media-framework.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/2] [media] Documentation/DocBook/media/v4l/subdev-formats.xml: fix a typo

2013-01-28 Thread Antonio Ospite
From: Antonio Ospite s/lisst/lists/ Signed-off-by: Antonio Ospite --- Should it also be s/packet/packed/ on the same line? If so I'll send another patch for that, there are a couple more of these. Thanks, Antonio Documentation/DocBook/media/v4l/subdev-formats.xml |2 +- 1

[PATCH 0/2] A couple documentation fixes for media stuff

2013-01-28 Thread Antonio Ospite
From: Antonio Ospite Take a look at the per-patch annotations too, please. Thanks, Antonio Antonio Ospite (2): [media] Documentation/media-framework.txt: fix a sentence [media] Documentation/DocBook/media/v4l/subdev-formats.xml: fix a typo Documentation/DocBook/media/v4l/subdev

On MIPI-CSI2 YUV420 formats and V4L2 Media Bus formats

2013-01-28 Thread Antonio Ospite
D#l108 [4] http://kernel.org/doc/htmldocs/media/subdev.html#v4l2-mbus-pixelcode-yuv8 [5] http://www.ti.com/lit/ug/swpu235w/swpu235w.pdf -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-pos

[PATCH 2/2] contrib/m920x/m920x_parse.pl: silence a warning

2012-12-29 Thread Antonio Ospite
Silence a warning due to the way get_line() is supposed to be called: Use of uninitialized value $cmd in split at m920x_parse.pl line 118 Signed-off-by: Antonio Ospite --- contrib/m920x/m920x_parse.pl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/m920x

[PATCH 1/2] contrib/m920x/m920x_parse.pl: stricter check when extracting firmware

2012-12-29 Thread Antonio Ospite
Extract firmware only from the right messages, skip the other messages. Signed-off-by: Antonio Ospite --- contrib/m920x/m920x_parse.pl |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) mode change 100644 => 100755 contrib/m920x/m920x_parse.pl diff --git a/contrib/m920x/m920x_parse

[PATCH 0/2] v4l-utils: some fixes for contrib/m920x/m920x_parse.pl

2012-12-29 Thread Antonio Ospite
and the firmware can be extracted with no problems. Patch 02 works around a warning. Antonio Ospite (2): contrib/m920x/m920x_parse.pl: stricter check when extracting firmware contrib/m920x/m920x_parse.pl: silence a warning contrib/m920x/m920x_parse.pl |5 +++-- 1 file changed, 3

Re: [PATCHv2 0/9] dvb-usb/m920x: support VP-7049 DVB-T USB Stick and other fixes

2012-12-27 Thread Antonio Ospite
On Mon, 10 Dec 2012 22:37:08 +0100 Antonio Ospite wrote: > Hi, > Ping. > Here is a second iteration of the patchset to add support for the > Twinhan VP7049 DVB-T USB Stick, v1 is at: > http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/56714 > > Pa

Re: cannot make this Asus my cinema-u3100miniplusv2 work under linux

2012-12-16 Thread Antonio Ospite
m/wsphoto/v0/456087010/Free-shipping-50pcs-lot-fashion-style-wedding-box-candy-tin-box-jewellery-tin-box-06.jpg I verified that reception does improve a little bit, don't expect miracles tho :) Regards, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in whic

[PATCHv2 5/9] [media] m920x: avoid repeating RC state parsing at each keycode

2012-12-10 Thread Antonio Ospite
Parsing the RC press state is invariant wrt. the keycode, take it out of the keycode scanning loop. Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/m920x.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/m920x.c b/drivers/media/usb

[PATCHv2 7/9] [media] m920x: send the RC init sequence also when rc.core is used

2012-12-10 Thread Antonio Ospite
Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/m920x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/m920x.c b/drivers/media/usb/dvb-usb/m920x.c index bddd763..531a681 100644 --- a/drivers/media/usb/dvb-usb/m920x.c +++ b/drivers

[PATCHv2 6/9] [media] m920x: introduce m920x_rc_core_query()

2012-12-10 Thread Antonio Ospite
Add an m920x_rc_core_query() function for drivers which want to use the linux RC core infrastructure. Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/m920x.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/media/usb/dvb-usb/m920x.c b

[PATCHv2 8/9] [media] get_dvb_firmware: add entry for the vp7049 firmware

2012-12-10 Thread Antonio Ospite
Add an entry to download the dvb-usb-vp7049-0.95.fw firmware for the Twinhan vp7049 and similar devices. Known devices of this kind are: Twinhan/Azurewave DTV-DVB UDTT7049 Digicom Digitune-S Think Xtra Hollywood DVB-T USB2.0 Signed-off-by: Antonio Ospite --- Documentation/dvb

[PATCHv2 4/9] [media] m920x: factor out a m920x_parse_rc_state() function

2012-12-10 Thread Antonio Ospite
This is in preparation to using RC core infrastructure for some devices, the RC button state parsing logic can be shared berween rc.legacy and rc.core callbacks as it is independent from the mechanism used for RC handling. Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/m920x.c

[PATCHv2 9/9] [media] m920x: add support for the VP-7049 Twinhan DVB-T USB Stick

2012-12-10 Thread Antonio Ospite
f-by: Antonio Ospite --- drivers/media/dvb-core/dvb-usb-ids.h |1 + drivers/media/usb/dvb-usb/m920x.c| 123 ++ 2 files changed, 124 insertions(+) diff --git a/drivers/media/dvb-core/dvb-usb-ids.h b/drivers/media/dvb-core/dvb-usb-ids.h index 58e0220..fae

[PATCHv2 0/9] dvb-usb/m920x: support VP-7049 DVB-T USB Stick and other fixes

2012-12-10 Thread Antonio Ospite
want me to do otherwise. Thanks, Antonio Antonio Ospite (9): [media] dvb-usb: fix indentation of a for loop [media] m920x: fix a typo in a comment [media] m920x: factor out a m920x_write_seq() function [media] m920x: factor out a m920x_parse_rc_state() function [media] m920x:

[PATCHv2 3/9] [media] m920x: factor out a m920x_write_seq() function

2012-12-10 Thread Antonio Ospite
This is in preparation for the vp7049 frontend attach function which is going to set a sequence of registers as well. Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/m920x.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCHv2 2/9] [media] m920x: fix a typo in a comment

2012-12-10 Thread Antonio Ospite
Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/m920x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/m920x.c b/drivers/media/usb/dvb-usb/m920x.c index 661bb75..433696d 100644 --- a/drivers/media/usb/dvb-usb/m920x.c +++ b/drivers

[PATCHv2 1/9] [media] dvb-usb: fix indentation of a for loop

2012-12-10 Thread Antonio Ospite
Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/dvb-usb-init.c | 60 +++--- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dvb-usb-init.c b/drivers/media/usb/dvb-usb/dvb-usb-init.c index 169196e..1adf325 100644

[PATCH] [media] gspca_kinect: add Kinect for Windows USB id

2012-12-09 Thread Antonio Ospite
From: Jacob Schloss Add the USB ID for the Kinect for Windows RGB camera so it can be used with the gspca_kinect driver. Signed-off-by: Jacob Schloss Signed-off-by: Antonio Ospite --- Thanks Jacob, I took the liberty to rebase the patch on top of linux-3.7.0-rc7 as the gspca location has

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-29 Thread Antonio Ospite
On Thu, 29 Nov 2012 10:25:19 +0100 Hans de Goede wrote: > Hi Jean-Francois, Antonio Ospite, > > Could it be that you're both right, and that the register > Jean-Francois suggest is used (0x13) and uses in his patch > is for enabling / disabling the light-freq filter, whe

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-26 Thread Antonio Ospite
On Mon, 26 Nov 2012 16:23:18 +0100 Jean-Francois Moine wrote: > On Mon, 26 Nov 2012 14:08:06 +0100 > Antonio Ospite wrote: > > > For now I'd NAK the patch since it is a regression for users > > with 50Hz power sources and it looks like it does not _always

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-26 Thread Antonio Ospite
On Fri, 23 Nov 2012 19:12:32 +0100 Jean-Francois Moine wrote: > On Fri, 23 Nov 2012 18:09:09 +0100 > Antonio Ospite wrote: [...] > > In the datasheet I have for ov772x, bit[6] of register 0x13 is described > > as: > > > > Bit[6]: AEC - Step size limit >

Re: [PATCH] gspca - ov534: Fix the light frequency filter

2012-11-23 Thread Antonio Ospite
sccb_reg_write(gspca_dev, 0x13, /* auto */ > + sccb_reg_read(gspca_dev, 0x13) | 0x20); > } > Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Postin

Re: [PATCH 1/5] [media] dvb-usb: add a pre_init hook to struct dvb_usb_device_properties

2012-11-13 Thread Antonio Ospite
On Tue, 06 Nov 2012 02:07:19 +0200 Antti Palosaari wrote: > On 11/06/2012 01:28 AM, Antonio Ospite wrote: > > Some devices need to issue a pre-initialization command sequence via > > i2c in order to "enable" the communication with some adapter components. > > >

[PATCH 2/5] [media] get_dvb_firmware: add dvb-usb-vp7049-0.95.fw

2012-11-05 Thread Antonio Ospite
Firmware for vp7049 based design, known actual devices are: Twinhan/Azurewave DTV-DVB UDTT7049 Digicom Digitune-S Think Xtra Hollywood DVB-T USB2.0 Signed-off-by: Antonio Ospite --- I tried to contact the original manufacturer (Twinhan) but it does not exists anymore, Azurewave didn&#

[PATCH 3/5] [media] m920x: Add support for the VP-7049 Twinhan DVB-T USB Stick

2012-11-05 Thread Antonio Ospite
downloaded with: $ ./Documentation/dvb/get_dvb_firmware vp7049 [1] http://www.azurewave.com/Support_Utility_Driver.asp [2] http://www.digicom.it/digisit/driver_link.nsf/driverprodotto?openform&prodotto=DigiTuneS [3] http://www.txitalia.it/prodotto.asp?prodotto=txhollywooddvttv Signed-off-by: Ant

[PATCH 4/5] [media] dvb-usb: fix indentation of a for loop

2012-11-05 Thread Antonio Ospite
Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/dvb-usb-init.c | 60 +++--- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dvb-usb-init.c b/drivers/media/usb/dvb-usb/dvb-usb-init.c index 8ab916e..619a7f0 100644

[PATCH 5/5] [media] m920x: fix a typo in a comment

2012-11-05 Thread Antonio Ospite
Signed-off-by: Antonio Ospite --- drivers/media/usb/dvb-usb/m920x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/m920x.c b/drivers/media/usb/dvb-usb/m920x.c index ec820ec..c66c78c 100644 --- a/drivers/media/usb/dvb-usb/m920x.c +++ b/drivers

[PATCH 1/5] [media] dvb-usb: add a pre_init hook to struct dvb_usb_device_properties

2012-11-05 Thread Antonio Ospite
mmands via i2c. Signed-off-by: Antonio Ospite --- If this approach is OK I can send a similar patch for dvb-usb-v2. Are all the dvb-usb drivers going to be ported to dvb-usb-v2 eventually? drivers/media/usb/dvb-usb/dvb-usb.h |5 + drivers/media/usb/dvb-usb/dvb-usb-init.c |6

[PATCH 0/5] dvb-usb: support VP-7049 Twinhan DVB-T USB Stick and other fixes

2012-11-05 Thread Antonio Ospite
hat I arbitrarily ignored checkpatch.pl warnings and errors because I preferred to stick with the code style in use in the dvb-usb files, let me know if you want me to do otherwise. Thanks, Antonio Antonio Ospite (5): [media] dvb-usb: add a pre_init hook to struct dvb_usb_device_properties [

Re: [PATCH 0/5] v4l-utils: add some scripts from the wiki.

2012-10-10 Thread Antonio Ospite
On Wed, 10 Oct 2012 17:22:53 +0300 Antti Palosaari wrote: > On 10/10/2012 04:39 PM, Antonio Ospite wrote: > > Hi, > > > > I recently used some scripts I found on the linuxtv.org wiki to extract > > a firmware for a m920x device from USB dumps made with UsbSniff2.0 o

  1   2   3   >