Re: [PATCH 01/15] EDAC: make device_type const

2017-08-20 Thread Borislav Petkov
On Sat, Aug 19, 2017 at 01:52:12PM +0530, Bhumika Goyal wrote: > Make these const as they are only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal > --- > drivers/edac/edac_mc_sysfs.c | 8 >

Re: [PATCH v3 4/8] x86: stop exporting msr-index.h to userland

2017-01-13 Thread Borislav Petkov
nd as such it's part of the UAPI. I don't think you can > > remove it unless you can guarantee there are no userspace users. > I keep it in the v2 of the series, but the maintainer, Borislav Petkov, asks > me > to un-export it. > > I will follow the maintainer decision. I'm no

Re: [PATCH v2 4/7] x86: put msr-index.h in uapi

2017-01-06 Thread Borislav Petkov
On Fri, Jan 06, 2017 at 10:43:56AM +0100, Nicolas Dichtel wrote: > This header file is exported, thus move it to uapi. It should rather not be exported - please remove it from arch/x86/include/uapi/asm/Kbuild instead. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid

Re: [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()

2015-06-22 Thread Borislav Petkov
On Mon, Jun 22, 2015 at 03:01:38AM +0200, Luis R. Rodriguez wrote: We can certainly replace the WARN() with pr_warn(), I don't see how its confusing though as its a run time real issue. Either way whatever you recommend is fine by me. Yeah, it confused the 0day robot at least. :-) But maybe

Re: [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()

2015-06-21 Thread Borislav Petkov
On Sun, Jun 21, 2015 at 10:23:48PM +0200, Luis R. Rodriguez wrote: Nope, well the driver requires huge amounts of work to work with PAT, that work will likely never be done, so hence the warning. Its our compromise as only 2 drivers will live on Linux like this and they are both old and rare.

Re: [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()

2015-06-20 Thread Borislav Petkov
On Sat, Jun 20, 2015 at 03:17:56PM +0800, Fengguang Wu wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master commit 1bf1735b478008c30acaff18ec6f4a3ff211c28a Author: Luis R.

Re: [PATCH v6 2/3] IB/ipath: add counting for MTRR

2015-06-11 Thread Borislav Petkov
On Thu, Jun 11, 2015 at 10:50:01AM -0700, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com There is no good reason not to, we eventually delete it as well. Cc: Toshi Kani toshi.k...@hp.com Cc: Roland Dreier rol...@kernel.org Cc: Sean Hefty sean.he...@intel.com Cc: Hal

Re: [PATCH bp] EDAC, mce_amd_inj: inj_type can be static

2015-06-05 Thread Borislav Petkov
On Fri, Jun 05, 2015 at 07:24:26PM +0800, kbuild test robot wrote: Signed-off-by: Fengguang Wu fengguang...@intel.com --- mce_amd_inj.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c index 2a0c829..46a6b0e

Re: [PATCH 0/7 linux-next] drivers: remove deprecated IRQF_DISABLED

2014-10-06 Thread Borislav Petkov
On Mon, Oct 06, 2014 at 05:35:47PM +0200, Fabian Frederick wrote: This small patchset removes IRQF_DISABLED from drivers branch. See include/linux/interrupt.h: This flag is a NOOP and scheduled to be removed Note: (cross)compiled but untested. Fabian Frederick (7): mv64x60_edac:

Re: [PATCH 0/7 linux-next] drivers: remove deprecated IRQF_DISABLED

2014-10-06 Thread Borislav Petkov
On Mon, Oct 06, 2014 at 08:33:00PM +0200, Fabian Frederick wrote:    You're right, I guess we can forget this patchset. I didn't see it was already done. (nothing in linux-next yet). Not the whole patchset - I was replying only to your two patches touching code in drivers/edac/. I don't know

Re: WARNING: at drivers/media/v4l2-core/videobuf2-core.c:2065 vb2_queue_init+0x74/0x142()

2013-05-10 Thread Borislav Petkov
On Fri, May 10, 2013 at 02:06:50PM +0200, Hans Verkuil wrote: Can you try this patch? This should fix it. Yep, it does. Tested-by: Borislav Petkov b...@suse.de diff --git a/drivers/media/parport/bw-qcam.c b/drivers/media/parport/bw-qcam.c index 06231b8..d12bd33 100644 --- a/drivers/media

Re: Re: Re: Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-10-21 Thread Borislav Petkov
On Sun, Oct 21, 2012 at 01:57:21AM +, Artem S. Tashkinov wrote: The freeze happens on my *host* Linux PC. For an experiment I decided to check if I could reproduce the freeze under a virtual machine - it turns out the Linux kernel running under it also freezes. I know that - but a freeze

Re: Re: Re: Re: Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-10-21 Thread Borislav Petkov
On Sun, Oct 21, 2012 at 11:59:36AM +, Artem S. Tashkinov wrote: http://imageshack.us/a/img685/9452/panicz.jpg list_del corruption. prev-next should be ... but was ... Btw, this is one of the debug options I told you to enable. I cannot show you more as I have no serial console to use :(

Re: Re: Re: Re: Re: Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-10-21 Thread Borislav Petkov
On Sun, Oct 21, 2012 at 07:49:01PM +, Artem S. Tashkinov wrote: I ran it this way: while :; do dmesg -c; done | scat /dev/sda11 (yes, straight to a hdd partition to eliminate a FS cache) Well, I'm no fs guy but this should still go through the buffer cache. I think the O_SYNC flag makes

Re: Re: Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

2012-10-20 Thread Borislav Petkov
at this point as if some driver got into an infinite loop or something. All debug options from https://lkml.org/lkml/2012/10/20/116 are enabled, but serial console is empty. Best wishes, Artem On Oct 21, 2012, Borislav Petkov wrote: I don't think that's the problem - I rather