Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-27 Thread Chen Gang
On 11/27/2013 06:43 PM, Dan Carpenter wrote: > On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote: >> On 11/27/2013 12:03 PM, Greg KH wrote: >>> On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: >>>> dev_*() assumes 'go' is already initial

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
On 11/27/2013 12:03 PM, Greg KH wrote: > On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >> of before 'go' initialized. Related warning (with allmodconfig under >> he

[PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
007_usb_probe': drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] Also remove useless code after 'return' statement. Signed-off-by: Chen Gang --- drivers/staging/media/go7007/go7007-usb.c | 1

Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
On 11/27/2013 11:21 AM, Joe Perches wrote: > On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >> of before 'go' initialized. > [] >> diff --git a/drivers/staging/media/go7

[PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
007_usb_probe': drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] Also remove useless code after 'return' statement. Signed-off-by: Chen Gang --- drivers/staging/media/go7007/go7007-usb.c | 1

[PATCH] drivers: media: usb: b2c2: use usb_*_coherent() instead of pci_*_consistent() in flexcop-usb.c

2013-09-22 Thread Chen Gang
: implicit declaration of function ‘pci_alloc_consistent’ Signed-off-by: Chen Gang --- drivers/media/usb/b2c2/flexcop-usb.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.c index 8b6275f

Re: [PATCH] media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB

2013-08-30 Thread Chen Gang
On 08/30/2013 04:06 PM, Patrick Boettcher wrote: > Hi, > > > > On Friday 30 August 2013 10:23:24 Chen Gang wrote: > >> DVB_B2C2_FLEXCOP_USB need depend on PCI, or can not pass compiling with > >> allmodconfig for h8300. > >> > >> Th

[PATCH] media: usb: b2c2: Kconfig: add PCI dependancy to DVB_B2C2_FLEXCOP_USB

2013-08-29 Thread Chen Gang
ent(NULL, ^ cc1: some warnings being treated as errors Signed-off-by: Chen Gang --- drivers/media/usb/b2c2/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/b2c2/Kconfig b/drivers/media/usb/b2c2/Kconfig index 17d3583..06fdf

Re: [PATCH] staging: strncpy issue, need always let NUL terminated string ended by zero.

2013-06-07 Thread Chen Gang
Hello Maintainers: Please help check it when you have time. Thanks. On 05/21/2013 07:53 PM, Chen Gang wrote: > On 05/21/2013 07:47 PM, Mauro Carvalho Chehab wrote: >> Em Tue, 07 May 2013 20:11:08 +0800 >> Chen Gang escreveu: >> >>>> >>>> For NUL t

Re: [PATCH] staging: strncpy issue, need always let NUL terminated string ended by zero.

2013-05-21 Thread Chen Gang
On 05/21/2013 07:47 PM, Mauro Carvalho Chehab wrote: > Em Tue, 07 May 2013 20:11:08 +0800 > Chen Gang escreveu: > >> > >> > For NUL terminated string, need always let it ended by zero. >> > >> > The 'name' may be copied to user mode (

[PATCH] staging: strncpy issue, need always let NUL terminated string ended by zero.

2013-05-07 Thread Chen Gang
ly initialize it (not use strlcpy instead of strncpy). Signed-off-by: Chen Gang --- drivers/staging/media/as102/as102_fe.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/media/as102/as102_fe.c b/drivers/staging/media/as102/as102_fe.c index 9ce8c9d..b3e

[PATCH] drivers/staging/media/go7007: using strlcpy instead of strncpy

2013-03-24 Thread Chen Gang
for NUL terminated string, need always set '\0' in the end. Signed-off-by: Chen Gang --- drivers/staging/media/go7007/saa7134-go7007.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/media/go7007/saa7134-go7007.c b/drivers/staging/me

[PATCH] drivers/staging/media/go7007: using strlcpy instead of strncpy

2013-03-19 Thread Chen Gang
better to treate them as NUL terminated string. Signed-off-by: Chen Gang --- drivers/staging/media/go7007/go7007-v4l2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/staging/media/go7007/go7007-v4l2.c index

[PATCH] drivers/staging/media/go7007: using strlcpy instead of strncpy

2013-03-19 Thread Chen Gang
for NUL terminated string, need always set '\0' in the end. Signed-off-by: Chen Gang --- drivers/staging/media/go7007/snd-go7007.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/go7007/snd-go7007.c b/drivers/staging/media/

[PATCH] drivers/staging/media/as102: using ccflags-y instead of EXTRA_FLAGS in Makefile

2013-02-27 Thread Chen Gang
need using ccflags-y instead of EXTRA_CFLAGS can reference scripts/checkpatch.pl (1755..1766) when make EXTRA_CFLAGS=-W, the compiling issue will be occured. Signed-off-by: Chen Gang --- drivers/staging/media/as102/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions