Re: [ANN] Media sessions in Lyon in October: libcamera

2019-09-24 Thread Dave Stevenson
Helen Koike Jacopo Mondi Laurent Pinchart Niklas Söderlund Hans Verkuil If I missed someone, or you are on the list but won't attend after all, then please let me know. Could I be added to the list please? Dave Stevenson Attendees: it is probably useful if you let us know whether you ha

Re: [RFC] Stateful codecs and requirements for compressed formats

2019-06-29 Thread Dave Stevenson
Hi Nicolas On Fri, 28 Jun 2019 at 16:48, Nicolas Dufresne wrote: > > Le vendredi 28 juin 2019 à 16:21 +0100, Dave Stevenson a écrit : > > Hi Hans > > > > On Fri, 28 Jun 2019 at 15:34, Hans Verkuil wrote: > > > Hi all, > > > > > >

Re: [PATCH 00/31] staging: bcm2835-camera: Improvements

2019-06-28 Thread Dave Stevenson
Hi Stefan On Fri, 28 Jun 2019 at 17:57, Stefan Wahren wrote: > > Hi Hans, > > Am 28.06.19 um 10:06 schrieb Hans Verkuil: > > Hi Stefan, > > > > On 6/27/19 8:55 PM, Stefan Wahren wrote: > >> This is an attempt to help Dave Stevenson to get all the fixes and

Re: [RFC] Stateful codecs and requirements for compressed formats

2019-06-28 Thread Dave Stevenson
Hi Hans On Fri, 28 Jun 2019 at 15:34, Hans Verkuil wrote: > > Hi all, > > I hope I Cc-ed everyone with a stake in this issue. > > One recurring question is how a stateful encoder fills buffers and how a > stateful > decoder consumes buffers. > > The most generic case is that an encoder produces

Re: [PATCH 00/31] staging: bcm2835-camera: Improvements

2019-06-28 Thread Dave Stevenson
Hi Stefan Firstly a huge thank you for picking this up - it's been on my to-do list for ages, and just hasn't made it to the top. On Fri, 28 Jun 2019 at 09:06, Hans Verkuil wrote: > > Hi Stefan, > > On 6/27/19 8:55 PM, Stefan Wahren wrote: > > This is an attempt t

Re: [PATCH 01/31] staging: bcm2835-camera: Ensure H264 header bytes get a sensible timestamp

2019-06-28 Thread Dave Stevenson
Hi Nicolas On Thu, 27 Jun 2019 at 20:55, Nicolas Dufresne wrote: > > Hi Dave, > > Le jeudi 27 juin 2019 à 20:55 +0200, Stefan Wahren a écrit : > > From: Dave Stevenson > > > > H264 header come from VC with 0 timestamps, which means they get a > > strange tim

Re: [PATCH v3 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-06 Thread Dave Stevenson
608fbcf166 ("media: v4l: event: Prevent freeing event subscriptions > while accessed") > > Reported-by: Dave Stevenson > Signed-off-by: Sakari Ailus Tested-By: Dave Stevenson Tested with 3 bcm2835 drivers (camera driver in staging, CSI2 receiver, and codec M2M driver) via

Re: [PATCH 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-05 Thread Dave Stevenson
uot;media: v4l: event: Prevent freeing event subscriptions > while accessed") > > Reported-by: Dave Stevenson > Signed-off-by: Sakari Ailus > --- > Hi Dave, Hans, > > This should address the issue. > > The functions can (and probably should) be re-arranged later but l

Re: VIDIOC_SUBSCRIBE_EVENT for V4L2_EVENT_CTRL regression?

2018-11-05 Thread Dave Stevenson
Hi Hans On Mon, 5 Nov 2018 at 13:18, Hans Verkuil wrote: > > On 11/05/2018 01:21 PM, Dave Stevenson wrote: > > Hi All > > > > I'm testing with 4.19 and finding that testEvents in v4l2-compliance > > is failing with ""failed to find event for control

VIDIOC_SUBSCRIBE_EVENT for V4L2_EVENT_CTRL regression?

2018-11-05 Thread Dave Stevenson
Hi All I'm testing with 4.19 and finding that testEvents in v4l2-compliance is failing with ""failed to find event for control '%s' type %u", ie it hasn't got the event for the inital values. This is with the various BCM2835 drivers that I'm involved with. Having looked at the v4l2-core history I

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-22 Thread Dave Stevenson
Hi Tomasz On Mon, 22 Oct 2018 at 04:38, Tomasz Figa wrote: > > Hi Philipp, > > On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: > > > > On Wed, Oct 03, 2018 at 05:24:39PM +0900, Tomasz Figa wrote: > > [...] > > > > Yes, but that would fall in a complete redesign I guess. The buffer > > > > a

Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

2018-10-01 Thread Dave Stevenson
Hi All, On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote: > > Hi Hans, > > Thanks for looking into. I remember MJPEG vs. JPEG being a source > of confusion for me a few years ago, so clarification is greatly > welcome :-) > > On Mon, 2018-10-01 at 15:03 +0300, Laurent Pinchart wrote: > > Hi Han

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-21 Thread Dave Stevenson
Hi Laurent On 19 May 2018 at 08:04, Laurent Pinchart wrote: > Hi Dave, > > On Friday, 18 May 2018 18:37:01 EEST Dave Stevenson wrote: >> On 18 May 2018 at 16:05, Mauro Carvalho Chehab wrote: >> > Em Fri, 18 May 2018 15:27:24 +0300 >> >> >> >> >

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-18 Thread Dave Stevenson
On 18 May 2018 at 16:05, Mauro Carvalho Chehab wrote: > Em Fri, 18 May 2018 15:27:24 +0300 >> >> > There, instead of an USB camera, the hardware is equipped with a >> > MC-based ISP, connected to its camera. Currently, despite having >> > a Kernel driver for it, the camera doesn't work with any >

Re: Compressed formats - framed or unframed?

2018-05-14 Thread Dave Stevenson
On 26 April 2018 at 17:25, Dave Stevenson wrote: > Hi All. > > I'm trying to get a V4L2 M2M driver sorted for the Raspberry Pi to > allow access to the video codecs. Much of it is working fine. > > One thing that isn't clear relates to video decode. Do

Compressed formats - framed or unframed?

2018-04-26 Thread Dave Stevenson
Hi All. I'm trying to get a V4L2 M2M driver sorted for the Raspberry Pi to allow access to the video codecs. Much of it is working fine. One thing that isn't clear relates to video decode. Do the compressed formats (eg V4L2_PIX_FMT_H264) have to be framed into one frame per V4L2 buffer, or is pro

Re: [PATCH v3 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-11-22 Thread Dave Stevenson
On 21 November 2017 at 20:54, Eric Anholt wrote: > Rob Herring writes: > >> On Tue, Nov 21, 2017 at 1:26 PM, Eric Anholt wrote: >>> Dave Stevenson writes: >>> >>>> Hi Rob >>>> >>>> On 27 September 2017 at 22:51, Rob Herring wro

Re: [PATCH v3 1/4] [media] v4l2-common: Add helper function for fourcc to string

2017-10-17 Thread Dave Stevenson
Hi Sakari. On 13 October 2017 at 22:09, Sakari Ailus wrote: > Hi Dave, > > On Wed, Sep 20, 2017 at 05:07:54PM +0100, Dave Stevenson wrote: >> New helper function char *v4l2_fourcc2s(u32 fourcc, char *buf) >> that converts a fourcc into a nice printable version. >

Re: [PATCH v3 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-10-02 Thread Dave Stevenson
Hi Rob On 27 September 2017 at 22:51, Rob Herring wrote: > On Fri, Sep 22, 2017 at 05:07:22PM +0100, Dave Stevenson wrote: >> Hi Stefan >> >> On 22 September 2017 at 07:45, Stefan Wahren wrote: >> > Hi Dave, >> > >> >> Dave Stevenson ha

Re: [PATCH v2 1/2] [media] tc358743: fix connected/active CSI-2 lane reporting

2017-09-25 Thread Dave Stevenson
tly active lanes, add a new > bitfield to the v4l2_mbus_config flags. This is a temporary fix, to be > used only until a better solution is found. > > Signed-off-by: Philipp Zabel Tested-by: Dave Stevenson > --- > Changes since v1: > - Check csi_lanes_in_use <= num_data_lane

Re: [PATCH v2 0/4] BCM283x Camera Receiver driver

2017-09-25 Thread Dave Stevenson
On 22 September 2017 at 18:17, Hans Verkuil wrote: > On 22/09/17 18:31, Dave Stevenson wrote: >> On 22 September 2017 at 12:00, Hans Verkuil wrote: >>> On 13/09/17 17:49, Dave Stevenson wrote: >>>> OV5647 >>>> >>>> v4l2-compliance SHA : f6e

Re: [PATCH v2 0/4] BCM283x Camera Receiver driver

2017-09-22 Thread Dave Stevenson
On 22 September 2017 at 12:00, Hans Verkuil wrote: > On 13/09/17 17:49, Dave Stevenson wrote: >> OV5647 >> >> v4l2-compliance SHA : f6ecbc90656815d91dc6ba90aac0ad8193a14b38 >> >> Driver Info: >> Driver name : unicam >> Card type :

Re: [PATCH v3 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-09-22 Thread Dave Stevenson
Hi Stefan On 22 September 2017 at 07:45, Stefan Wahren wrote: > Hi Dave, > >> Dave Stevenson hat am 20. September 2017 um >> 18:07 geschrieben: >> >> >> Document the DT bindings for the CSI2/CCP2 receiver peripheral >> (known as Unicam) on BCM283x

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Dave Stevenson
Hi Philipp On 21 September 2017 at 11:24, Philipp Zabel wrote: > g_mbus_config was supposed to indicate all supported lane numbers, not > only the number of those currently in active use. Since the tc358743 > can dynamically reduce the number of active lanes if the required > bandwidth allows for

[PATCH v3 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-09-20 Thread Dave Stevenson
Add driver for the Unicam camera receiver block on BCM283x processors. Signed-off-by: Dave Stevenson --- Changes from v2. - Don't store the irq value as it isn't used outside the probe. - Change PIX_FMT_ALL_ defines to avoid potential clashes with 4CCs. - Clock now called "lp&quo

[PATCH v3 4/4] MAINTAINERS: Add entry for BCM2835 camera driver

2017-09-20 Thread Dave Stevenson
Signed-off-by: Dave Stevenson --- No changes from v2 to v3 MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb930eb..b47ddaa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2713,6 +2713,13 @@ S: Maintained N: bcm2835 F

[PATCH v3 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-09-20 Thread Dave Stevenson
Document the DT bindings for the CSI2/CCP2 receiver peripheral (known as Unicam) on BCM283x SoCs. Signed-off-by: Dave Stevenson --- Changes since v2 - Removed all references to Linux drivers. - Reworded section about disabling the firmware driver. - Renamed clock from "lp_clock"

[PATCH v3 0/4] BCM283x Camera Receiver driver

2017-09-20 Thread Dave Stevenson
Hi All. v3 of this patch set. This addresses the DT issues raised by Rob, and the things raised by Eric on the driver. More complete change details between v2 and v3 are in the individual patches. Thanks Dave Dave Stevenson (4): [media] v4l2-common: Add helper function for fourcc to string

[PATCH v3 1/4] [media] v4l2-common: Add helper function for fourcc to string

2017-09-20 Thread Dave Stevenson
New helper function char *v4l2_fourcc2s(u32 fourcc, char *buf) that converts a fourcc into a nice printable version. Signed-off-by: Dave Stevenson --- No changes from v2 to v3 drivers/media/v4l2-core/v4l2-common.c | 18 ++ include/media/v4l2-common.h | 3 +++ 2

Re: [PATCH 2/3] [media] tc358743: Increase FIFO level to 300.

2017-09-20 Thread Dave Stevenson
On 20 September 2017 at 12:24, Hans Verkuil wrote: > On 09/20/17 13:00, Dave Stevenson wrote: >> On 20 September 2017 at 11:23, Philipp Zabel wrote: >>> Hi, >>> >>> On Wed, 2017-09-20 at 10:14 +0100, Dave Stevenson wrote: >>>> Hi Mauro & Ph

Re: [PATCH 2/3] [media] tc358743: Increase FIFO level to 300.

2017-09-20 Thread Dave Stevenson
On 20 September 2017 at 11:23, Philipp Zabel wrote: > Hi, > > On Wed, 2017-09-20 at 10:14 +0100, Dave Stevenson wrote: >> Hi Mauro & Philipp >> >> On 19 September 2017 at 17:49, Mauro Carvalho Chehab >> wrote: >> > Em Tue, 19 Sep 2017 17:24:45 +020

Re: [PATCH 2/3] [media] tc358743: Increase FIFO level to 300.

2017-09-20 Thread Dave Stevenson
Hi Mauro & Philipp On 19 September 2017 at 17:49, Mauro Carvalho Chehab wrote: > Em Tue, 19 Sep 2017 17:24:45 +0200 > Philipp Zabel escreveu: > >> Hi Dave, >> >> On Tue, 2017-09-19 at 14:08 +0100, Dave Stevenson wrote: >> > The existing fixed value of 16

Re: [PATCH v2 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-09-19 Thread Dave Stevenson
Hi Rob. Thanks for the review. On 19 September 2017 at 15:32, Rob Herring wrote: > On Wed, Sep 13, 2017 at 04:07:47PM +0100, Dave Stevenson wrote: >> Document the DT bindings for the CSI2/CCP2 receiver peripheral >> (known as Unicam) on BCM283x SoCs. >> >> Si

[PATCH 0/3] [media] tc358743: Support for a wider range of inputs

2017-09-19 Thread Dave Stevenson
work on two lanes (useful on the Raspberry Pi which only brings out two CSI2 lanes to the camera connector). I'd like to extend the last one to dynamically calculate all the values for an arbitrary link speed, but time hasn't allowed as yet. Dave Stevenson (3): [media] tc358743: Cor

[PATCH 3/3] [media] tc358743: Add support for 972Mbit/s link freq.

2017-09-19 Thread Dave Stevenson
Adds register setups for running the CSI lanes at 972Mbit/s, which allows 1080P50 UYVY down 2 lanes. Signed-off-by: Dave Stevenson --- drivers/media/i2c/tc358743.c | 47 +++- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/drivers/media

[PATCH 1/3] [media] tc358743: Correct clock mode reported in g_mbus_config

2017-09-19 Thread Dave Stevenson
Support for non-continuous clock had previously been added via device tree, but a comment and the value reported by g_mbus_config still stated that it wasn't supported. Remove the comment, and return the correct value in g_mbus_config. Signed-off-by: Dave Stevenson --- drivers/medi

[PATCH 2/3] [media] tc358743: Increase FIFO level to 300.

2017-09-19 Thread Dave Stevenson
d the increase in frame delay is <4usecs for 1080P60 UYVY (2.55usecs for RGB888). Signed-off-by: Dave Stevenson --- drivers/media/i2c/tc358743.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 6b0fd07.

Re: [PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-09-19 Thread Dave Stevenson
Hi Hans. Thanks for the response. On 19 September 2017 at 11:20, Hans Verkuil wrote: > On 09/19/17 11:50, Dave Stevenson wrote: >> Hi Eric. >> >> Thanks for the review. >> >> On 18 September 2017 at 19:18, Eric Anholt wrote: >>> Dave Stevenson writes

Re: [PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-09-19 Thread Dave Stevenson
Hi Eric. Thanks for the review. On 18 September 2017 at 19:18, Eric Anholt wrote: > Dave Stevenson writes: >> diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c >> b/drivers/media/platform/bcm2835/bcm2835-unicam.c >> new file mode 100644 >> index 00

Re: [PATCH v2 0/4] BCM283x Camera Receiver driver

2017-09-13 Thread Dave Stevenson
ircumstances, but it isn't really a failure of this driver. Dave On 13 September 2017 at 16:07, Dave Stevenson wrote: > Hi All. > > This is v2 for adding a V4L2 subdevice driver for the CSI2/CCP2 camera > receiver peripheral on BCM283x, as used on Raspberry Pi. > Sorry for t

[PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-09-13 Thread Dave Stevenson
Add driver for the Unicam camera receiver block on BCM283x processors. Signed-off-by: Dave Stevenson --- drivers/media/platform/Kconfig |1 + drivers/media/platform/Makefile |1 + drivers/media/platform/bcm2835/Kconfig | 14 + drivers/media

[PATCH v2 4/4] MAINTAINERS: Add entry for BCM2835 camera driver

2017-09-13 Thread Dave Stevenson
Signed-off-by: Dave Stevenson --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb930eb..b47ddaa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2713,6 +2713,13 @@ S: Maintained N: bcm2835 F: drivers/staging/vc04_services

[PATCH v2 0/4] BCM283x Camera Receiver driver

2017-09-13 Thread Dave Stevenson
ough. - Added a log-status handler to get the status from the sensor. - Automatically switch away from any interlaced formats reported via g_fmt, or that are attempted to be set via try/s_fmt. - Addressed other more minor code review comments from v1. Dave Stevenson (4): [media] v4l2-common: Add help

[PATCH v2 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-09-13 Thread Dave Stevenson
Document the DT bindings for the CSI2/CCP2 receiver peripheral (known as Unicam) on BCM283x SoCs. Signed-off-by: Dave Stevenson --- .../devicetree/bindings/media/bcm2835-unicam.txt | 107 + 1 file changed, 107 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 1/4] [media] v4l2-common: Add helper function for fourcc to string

2017-09-13 Thread Dave Stevenson
New helper function char *v4l2_fourcc2s(u32 fourcc, char *buf) that converts a fourcc into a nice printable version. Signed-off-by: Dave Stevenson --- drivers/media/v4l2-core/v4l2-common.c | 18 ++ include/media/v4l2-common.h | 3 +++ 2 files changed, 21 insertions

Re: [RFC 0/2] BCM283x Camera Receiver driver

2017-08-30 Thread Dave Stevenson
On 30 August 2017 at 11:45, Hans Verkuil wrote: > On 30/08/17 11:40, Dave Stevenson wrote: >> Hi Hans. >> >> On 28 August 2017 at 15:15, Hans Verkuil wrote: >>> Hi Dave, >>> >>> What is the status of this work? I ask because I tried to use this

Re: [RFC 0/2] BCM283x Camera Receiver driver

2017-08-30 Thread Dave Stevenson
y it's piece-meal, but that should give you the bits required. I hope that helps. Dave > Regards, > > Hans > > On 14/06/17 17:15, Dave Stevenson wrote: >> Hi All. >> >> This is adding a V4L2 subdevice driver for the CSI2/CCP2 camera >> receiver pe

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-16 Thread Dave Stevenson
On 16 June 2017 at 17:08, Hans Verkuil wrote: > On 06/16/2017 05:55 PM, Dave Stevenson wrote: >> >> On 16 June 2017 at 15:05, Hans Verkuil wrote: >>> >>> On 06/15/17 17:11, Dave Stevenson wrote: >>>> >>>> On 15 June 2017 at 15:14,

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-16 Thread Dave Stevenson
On 16 June 2017 at 15:05, Hans Verkuil wrote: > On 06/15/17 17:11, Dave Stevenson wrote: >> On 15 June 2017 at 15:14, Hans Verkuil wrote: >>> On 06/15/17 15:38, Dave Stevenson wrote: >>>> Hi Hans. >>>> >>>> "On 15 June 2017 at 08:12

Re: [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-06-16 Thread Dave Stevenson
Hi Sakari On 16 June 2017 at 10:57, Sakari Ailus wrote: > Hi Dave, > > On Thu, Jun 15, 2017 at 05:15:04PM +0100, Dave Stevenson wrote: >> Hi Sakari. >> >> Thanks for the review. >> >> On 15 June 2017 at 13:59, Sakari Ailus wrote: >> > Hi Dave, >

Re: [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-06-15 Thread Dave Stevenson
Hi Sakari. Thanks for the review. On 15 June 2017 at 13:59, Sakari Ailus wrote: > Hi Dave, > > Thanks for the set! > > On Wed, Jun 14, 2017 at 04:15:46PM +0100, Dave Stevenson wrote: >> Document the DT bindings for the CSI2/CCP2 receiver peripheral >> (known

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Dave Stevenson
Hi Stefan. On 15 June 2017 at 15:49, Stefan Wahren wrote: > Hi Dave, > > Am 15.06.2017 um 15:38 schrieb Dave Stevenson: >> Hi Hans. >> >> "On 15 June 2017 at 08:12, Hans Verkuil wrote: >>> Hi Dave, >>> >>> Here is a quick review of t

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Dave Stevenson
On 15 June 2017 at 15:14, Hans Verkuil wrote: > On 06/15/17 15:38, Dave Stevenson wrote: >> Hi Hans. >> >> "On 15 June 2017 at 08:12, Hans Verkuil wrote: >>> Hi Dave, >>> >>> Here is a quick review of this driver. Once a v2 is posted I&#x

Re: [RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-15 Thread Dave Stevenson
Hi Hans. "On 15 June 2017 at 08:12, Hans Verkuil wrote: > Hi Dave, > > Here is a quick review of this driver. Once a v2 is posted I'll do a more > thorough > check. Thank you. I wasn't expecting such a quick response. > On 06/14/2017 05:15 PM, Dave Stevenso

Re: [RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-06-15 Thread Dave Stevenson
Hi Stefan. Thanks for taking the time to review this. On 15 June 2017 at 07:34, Stefan Wahren wrote: > Hi Dave, > > Am 14.06.2017 um 17:15 schrieb Dave Stevenson: >> Document the DT bindings for the CSI2/CCP2 receiver peripheral >> (known as Unicam) on BCM283x SoCs. >

Re: [RFC 0/2] BCM283x Camera Receiver driver

2017-06-15 Thread Dave Stevenson
On 15 June 2017 at 08:17, Hans Verkuil wrote: > On 06/14/2017 11:03 PM, Dave Stevenson wrote: >> >> On 14 June 2017 at 18:38, Hans Verkuil wrote: >>> >>> On 06/14/2017 06:29 PM, Dave Stevenson wrote: >>>> >>>> >>>

Re: [RFC 0/2] BCM283x Camera Receiver driver

2017-06-14 Thread Dave Stevenson
On 14 June 2017 at 18:38, Hans Verkuil wrote: > On 06/14/2017 06:29 PM, Dave Stevenson wrote: >> >> Hi Hans. >> >> On 14 June 2017 at 16:42, Hans Verkuil wrote: >>> >>> Hi Dave, >>> >>> How does this driver relate to this stagi

Re: [RFC 0/2] BCM283x Camera Receiver driver

2017-06-14 Thread Dave Stevenson
ng (as long as it supports CSI2, or eventually CCP2). > On 06/14/2017 05:15 PM, Dave Stevenson wrote: >> >> Hi All. >> >> This is adding a V4L2 subdevice driver for the CSI2/CCP2 camera >> receiver peripheral on BCM283x, as used on Raspberry Pi. >> >> v4l2

[RFC 2/2] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-06-14 Thread Dave Stevenson
Add driver for the Unicam camera receiver block on BCM283x processors. Signed-off-by: Dave Stevenson --- drivers/media/platform/Kconfig |1 + drivers/media/platform/Makefile |2 + drivers/media/platform/bcm2835/Kconfig | 14 + drivers/media

[RFC 0/2] BCM283x Camera Receiver driver

2017-06-14 Thread Dave Stevenson
essed up in sending these patches - so many ways to do something. Thanks in advance. Dave Dave Stevenson (2): [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface .../devicetree/bindings/media/bcm2835-unicam.txt | 76

[RFC 1/2] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-06-14 Thread Dave Stevenson
Document the DT bindings for the CSI2/CCP2 receiver peripheral (known as Unicam) on BCM283x SoCs. Signed-off-by: Dave Stevenson --- .../devicetree/bindings/media/bcm2835-unicam.txt | 76 ++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH 0/3] tc358743: minor driver fixes

2017-06-02 Thread Dave Stevenson
On 2 June 2017 at 15:13, Philipp Zabel wrote: > On Fri, 2017-06-02 at 15:27 +0200, Hans Verkuil wrote: >> On 06/02/17 15:03, Dave Stevenson wrote: >> > Hi Hans. >> > >> > On 2 June 2017 at 13:35, Hans Verkuil wrote: >> >> On 06/02/17 14:18,

Re: [PATCH 0/3] tc358743: minor driver fixes

2017-06-02 Thread Dave Stevenson
Hi Hans. On 2 June 2017 at 13:35, Hans Verkuil wrote: > On 06/02/17 14:18, Dave Stevenson wrote: >> These 3 patches for TC358743 came out of trying to use the >> existing driver with a new Raspberry Pi CSI-2 receiver driver. > > Nice! Doing that has been on my todo list for

[PATCH 2/3] [media] tc358743: Setup default mbus_fmt before registering

2017-06-02 Thread Dave Stevenson
Previously the mbus_fmt_code was set after the device was registered. If a connected sub-device called tc358743_get_fmt prior to that point it would get an invalid code back. Signed-off-by: Dave Stevenson --- drivers/media/i2c/tc358743.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 1/3] [media] tc358743: Add enum_mbus_code

2017-06-02 Thread Dave Stevenson
There was no way to query the supported mbus formats from this driver. enum_mbus_code is the function to expose that, so implement it. Signed-off-by: Dave Stevenson --- drivers/media/i2c/tc358743.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/media/i2c

[PATCH 3/3] [media] tc358743: Add support for platforms without IRQ line

2017-06-02 Thread Dave Stevenson
if no interrupt source is defined. Signed-off-by: Dave Stevenson --- drivers/media/i2c/tc358743.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 2f5763d..654aac2 100644 --- a/drivers/

[PATCH 0/3] tc358743: minor driver fixes

2017-06-02 Thread Dave Stevenson
line wired up to the SoC. "interrupts" is listed as being optional in the DT binding, but the driver didn't actually function if it wasn't provided. Dave Stevenson (3): [media] tc358743: Add enum_mbus_code [media] tc358743: Setup default mbus_fmt before registering [media]

Re: Sensor sub-device - what are the mandatory ops?

2017-05-17 Thread Dave Stevenson
Hi Sakari . Thanks for taking the time to respond. On 17 May 2017 at 00:04, Sakari Ailus wrote: > Hi Dave, > > On Thu, May 11, 2017 at 04:51:27PM +0100, Dave Stevenson wrote: >> Hi All. >> >> As previously discussed, I'm working on a V4L2 driver for the >> C

Sensor sub-device - what are the mandatory ops?

2017-05-11 Thread Dave Stevenson
Hi All. As previously discussed, I'm working on a V4L2 driver for the CSI-2/CCP2 receiver on BCM283x, as used on Raspberry Pi. It's a relatively simple hardware block that writes received data into SDRAM, and only accepts connection from one "sensor" sub device, so no need to involve the media con

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Hans. On 06/02/17 12:58, Hans Verkuil wrote: On 02/06/2017 12:37 PM, Dave Stevenson wrote: Hi Hans. On 06/02/17 09:08, Hans Verkuil wrote: Hi Eric, Great to see this driver appearing for upstream merging! See below for my review comments, focusing mostly on V4L2 specifics

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Mauro. Can I just say that I'm not attempting to upstream this, others are. I've just answered questions raised. On 06/02/17 12:37, Mauro Carvalho Chehab wrote: Em Sun, 5 Feb 2017 22:15:21 + Dave Stevenson escreveu: If the goal was to protect some IP related to the sensor

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Hans. On 06/02/17 09:08, Hans Verkuil wrote: Hi Eric, Great to see this driver appearing for upstream merging! See below for my review comments, focusing mostly on V4L2 specifics. On 01/27/2017 10:54 PM, Eric Anholt wrote: - Supports raw YUV capture, preview, JPEG and H264. - Uses videobu

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-05 Thread Dave Stevenson
of this archive + * for more details. + * + * Authors: Vincent Sanders + * Dave Stevenson + * Simon Mellor + * Luke Diamand All of these are now dead email addresses. Mine could be updated to dave.steven...@raspberrypi.org, but the others should probably be deleted. +

Re: uvcvideo logging kernel warnings on device disconnect

2016-12-20 Thread Dave Stevenson
, 2016 at 01:09:21AM +0200, Laurent Pinchart wrote: On Thursday 08 Dec 2016 12:31:55 Dave Stevenson wrote: Hi All. I'm working with a USB webcam which has been seen to spontaneously disconnect when in use. That's a separate issue, but when it does it throws a load of warnings into the

Re: Sony imx219 driver?

2016-12-13 Thread Dave Stevenson
Hi Ramiro On 13/12/16 13:47, Ramiro Oliveira wrote: Hi Dave On 07/21/2016 08:19 PM, Dave Stevenson wrote: Just a quick query to avoid duplicating effort. Has anyone worked on a Sony IMX219 (or other Sony sensor) subdevice driver as yet? With the new Raspberry Pi camera being IMX219, and as

uvcvideo logging kernel warnings on device disconnect

2016-12-08 Thread Dave Stevenson
Hi All. I'm working with a USB webcam which has been seen to spontaneously disconnect when in use. That's a separate issue, but when it does it throws a load of warnings into the kernel log if there is a file handle on the device open at the time, even if not streaming. I've reproduced this

Re: Sony imx219 driver?

2016-07-22 Thread Dave Stevenson
Hi Hans. On 22/07/16 10:46, Hans Verkuil wrote: On 07/21/2016 08:19 PM, Dave Stevenson wrote: Hi All. Just a quick query to avoid duplicating effort. Has anyone worked on a Sony IMX219 (or other Sony sensor) subdevice driver as yet? Not that I am aware of. OK, glad to hear I won'

Sony imx219 driver?

2016-07-21 Thread Dave Stevenson
Hi All. Just a quick query to avoid duplicating effort. Has anyone worked on a Sony IMX219 (or other Sony sensor) subdevice driver as yet? With the new Raspberry Pi camera being IMX219, and as Broadcom have released an soc_camera based driver for the sensor already (https://android.googlesou

Re: [PATCH v2 1/7] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats

2016-06-20 Thread Dave Stevenson
Hi Hans. On 20/06/16 18:03, Hans Verkuil wrote: On 06/20/2016 06:20 PM, Sakari Ailus wrote: The 10-bit packed raw bayer format documented that the data of the first pixel of a four-pixel group was found in the first byte and the two highest bits of the fifth byte. This was not entirely correct.