Re: [PATCH] v4l: vsp1: Fix function declaration/definition mismatch

2017-12-04 Thread Eugeniu Rosca
Hello Laurent, Kieran, On Mon, Dec 04, 2017 at 12:52:17PM +0200, Laurent Pinchart wrote: > Hello, > > On Friday, 24 November 2017 20:40:57 EET Kieran Bingham wrote: > > Hi Eugeniu, > > > > Thankyou for the patch, > > > > Laurent - Any comments on this? Otherwise I'll bundle this in with my > >

[PATCH] v4l: vsp1: Fix function declaration/definition mismatch

2017-08-20 Thread Eugeniu Rosca
From: Eugeniu Rosca Cppcheck v1.81 complains that the parameter names of certain vsp1 functions don't match between declaration and definition. Fix this. No functional change is confirmed by the empty delta between the disassembled object files before and after the change. Signed-o

[PATCH] [media] mxl111sf: Fix potential null pointer dereference

2017-08-13 Thread Eugeniu Rosca
From: Eugeniu Rosca Reviewing the delta between cppcheck output of v4.9.39 and v4.9.40 stable updates, I stumbled on the new warning: mxl111sf.c:80: (warning) Possible null pointer dereference: rbuf Since copying state->rcvbuf into rbuf is not needed in the 'write-only' scenario