Re: [PATCH] media: pxa_camera: disable and unprepare the clock source on error

2017-12-11 Thread Flavio Ceolin
Laurent Pinchart writes: > Hi Flavio, > > On Monday, 11 December 2017 23:05:46 EET Flavio Ceolin wrote: >> > On Wednesday, 6 December 2017 18:38:50 EET Flavio Ceolin wrote: >> >> pxa_camera_probe() was not calling pxa_camera_deactivate(), >> >> responsib

Re: [PATCH] media: pxa_camera: disable and unprepare the clock source on error

2017-12-11 Thread Flavio Ceolin
Hi Laurent, > Hi Flavio, > > Thank you for the patch. > > On Wednesday, 6 December 2017 18:38:50 EET Flavio Ceolin wrote: >> pxa_camera_probe() was not calling pxa_camera_deactivate(), >> responsible to call clk_disable_unprepare(), on the failure path. This >>

[PATCH] media: pxa_camera: disable and unprepare the clock source on error

2017-12-06 Thread Flavio Ceolin
pxa_camera_probe() was not calling pxa_camera_deactivate(), responsible to call clk_disable_unprepare(), on the failure path. This was leading to unbalancing source clock. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Flavio Ceolin --- drivers/media/platform

[PATCH] media: s5p-jpeg: Fix off-by-one problem

2017-12-06 Thread Flavio Ceolin
s5p_jpeg_runtime_resume() does not call clk_disable_unprepare() for jpeg->clocks[0] when one of the clk_prepare_enable() fails. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Flavio Ceolin --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 2 +- 1 file changed