Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-28 Thread Herbert Xu
On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote: > > > On 28/04/17 12:30 AM, Herbert Xu wrote: > > You are right. Indeed the existing code looks buggy as they > > don't take sg->offset into account when doing the kmap. Could > > you send me s

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-27 Thread Herbert Xu
On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote: > > > On 26/04/17 09:56 PM, Herbert Xu wrote: > > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > >> Very straightforward conversion to the new function in the caam driver > >> an

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-26 Thread Herbert Xu
On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > Very straightforward conversion to the new function in the caam driver > and shash library. > > Signed-off-by: Logan Gunthorpe > Cc: Herbert Xu > Cc: "David S. Miller" > --- >

Re: [PATCH v2 3/8] drivers: char: use module_platform_driver_probe()

2013-03-21 Thread Herbert Xu
On Thu, Mar 14, 2013 at 06:09:33PM +0100, Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. > > Signed-off-by: Fabio Porcedda > Cc: Greg Kroah-Hartman > Cc: Matt Mack

Re: [PATCH v2 3/8] drivers: char: use module_platform_driver_probe()

2013-03-21 Thread Herbert Xu
On Thu, Mar 21, 2013 at 11:15:26AM +0100, Fabio Porcedda wrote: > On Thu, Mar 21, 2013 at 10:55 AM, Herbert Xu > wrote: > > On Thu, Mar 14, 2013 at 06:09:33PM +0100, Fabio Porcedda wrote: > >> This patch converts the drivers to use the > >> module_platform_driver

Re: [GIT PULL -tip] fix 22 make headers_check - 200901

2009-02-03 Thread Herbert Xu
> #include Awesome, you've just broken the userspace build of kvm as the file linux/types.h conflicts with sys/types.h. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.a