[PATCH v2] af9015: avoid magically sized temporary buffer in eeprom_dump

2009-06-19 Thread Jan Nikitenko
after KERN_CONT Signed-off-by: Jan Nikitenko jan.nikite...@gmail.com --- I do not see better solution for the magical sized buffer, since print_hex_dump like functions need dump of registers in memory (so the magical sized temporary buffer would be needed for a copy anyway). If deb_info was defined

[PATCH v2] zl10353 and qt1010: fix stack corruption bug

2009-06-18 Thread Jan Nikitenko
continual printk instead of stack based buffer with proper magic number size. Signed-off-by: Jan Nikitenko jan.nikite...@gmail.com --- linux/drivers/media/common/tuners/qt1010.c | 12 +--- linux/drivers/media/dvb/frontends/zl10353.c | 12 +--- 2 files changed, 10 insertions(+), 14

[PATCH] af9015: avoid magically sized temporal buffer in eeprom_dump

2009-06-18 Thread Jan Nikitenko
Replace printing to magically sized temporal buffer with use of KERN_CONT for continual printing of eeprom registers dump. Since deb_info is defined as dprintk, which is defined as printk without additional parameters, meaning that deb_info is equivalent to direct printk (without KERN_

[PATCH] af9015: avoid magically sized temporal buffer in eeprom_dump

2009-06-18 Thread Jan Nikitenko
), we can use KERN_DEBUG and KERN_CONT in there, eliminating the need for sprintf into temporal buffer with not easily readable/magical size. Though it's strange, that deb_info definition uses printk without KERN_ facility and callers don't use it either. Signed-off-by: Jan Nikitenko jan.nikite

Re: [PATCH] zl10353 and qt1010: fix stack corruption bug

2009-06-17 Thread Jan Nikitenko
Mauro Carvalho Chehab wrote: Em Wed, 10 Jun 2009 08:21:20 +0200 Jan Nikitenko jan.nikite...@gmail.com escreveu: This patch fixes stack corruption bug present in dump_regs function of zl10353 and qt1010 drivers: the buffer buf is one byte smaller than required - there is 4 chars for address

[PATCH] zl10353 and qt1010: fix stack corruption bug

2009-06-10 Thread Jan Nikitenko
, but only 52 were provided. The one byte missing in stack based buffer buf can cause stack corruption possibly leading to kernel oops, as discovered originally with af9015 driver. Signed-off-by: Jan Nikitenko jan.nikite...@gmail.com --- Antti Palosaari wrote: On 06/10/2009 01:39 AM, Jan

Re: AVerTV Volar Black HD: i2c oops in warm state on mips

2009-06-09 Thread Jan Nikitenko
Solved with [PATCH] af9015: fix stack corruption bug. Best regards, Jan -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

AVerTV Volar Black HD: i2c oops in warm state on mips

2009-06-05 Thread Jan Nikitenko
Hi, I am trying to get AverMedia AVerTV Volar Black HD (A850) usb dvb-t tuner running on mips32 little endian platform (to stream dvb-t from home router on LAN). I've cross compiled v4l-dvb mercurial sources (revision 11448:d4274bbb8605) and when plugging the tuner stick, I get following kernel