Since rc_unregister_device() frees its argument there's no need to
subsequently call rc_free_device() on the same variable - in fact it's
a double free bug.
Easily fixed by just removing the rc_free_device() call.
Signed-off-by: Jesper Juhl
---
drivers/media/rc/gpio-ir-recv.c |1
e call to
rc_free_device() to after rc_unregister_device(). That fixes the
problem since rc_free_device() just does nothing if passed NULL and
there's no further use of 'rcdev' after the call to rc_free_device()
so it's not needed there.
Signed-off-by: Jesper Juhl
---
driver
The header is not needed, so remove it.
Signed-off-by: Jesper Juhl
---
drivers/media/platform/s5p-tv/mixer_video.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/platform/s5p-tv/mixer_video.c
b/drivers/media/platform/s5p-tv/mixer_video.c
index 0c1cd89
On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
> On Mon, Oct 15, 2012 at 9:03 PM, Jesper Juhl wrote:
> > On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
> >
> >> On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl wrote:
> >> > On Mon, 15 Oct 2012, Jesper Juhl wrote
On Mon, 15 Oct 2012, Ezequiel Garcia wrote:
> On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl wrote:
> > On Mon, 15 Oct 2012, Jesper Juhl wrote:
> >
> >> On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
> >>
[...]
> > Currently there are two checks for 'rc
On Mon, 15 Oct 2012, Jesper Juhl wrote:
> On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
>
> > On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl wrote:
> > > There are two checks for 'rc' being less than zero with no change to
> > > 'rc' between th
On Sat, 13 Oct 2012, Ezequiel Garcia wrote:
> On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl wrote:
> > There are two checks for 'rc' being less than zero with no change to
> > 'rc' between the two, so the second is just dead code - remove it.
There are two checks for 'rc' being less than zero with no change to
'rc' between the two, so the second is just dead code - remove it.
Signed-off-by: Jesper Juhl
---
drivers/media/usb/stk1160/stk1160-i2c.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff -
f output rather
than on a new line.
B) Some tools that process files line-by-line may get confused by the
lack of a newline on the last line.
C) The "\ No newline at end of file" line in diffs annoys me for some
reason.
So, let's just add the missing newline once and for al
f output rather
than on a new line.
B) Some tools that process files line-by-line may get confused by the
lack of a newline on the last line.
C) The "\ No newline at end of file" line in diffs annoys me for some
reason.
So, let's just add the missing newline once and for al
st stating that add no value.
Signed-off-by: Jesper Juhl
---
drivers/staging/media/as102/as102_fw.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/media/as102/as102_fw.c
b/drivers/staging/media/as102/as102_fw.c
index 43ebc43..9db275e 100644
--- a/driver
release_firmware() tests for NULL pointers on its own - there's no
reason to do an explicit check before calling the function.
Signed-off-by: Jesper Juhl
---
drivers/media/video/s2255drv.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/video/s2255dr
are' still uninitialized - not good.
The easy fix is to just initialize 'firmware' to NULL when we declare
it, since release_firmware() deals gracefully with being passed NULL
pointers.
Signed-off-by: Jesper Juhl
---
drivers/staging/media/as102/as102_fw.c |2 +-
1 file changed,
'dev = NULL' assignment at the end of
cx231xx_release_resources() since it is pointless.
Signed-off-by: Jesper Juhl
---
drivers/media/video/cx231xx/cx231xx-cards.c |1 -
drivers/media/video/cx231xx/cx231xx-video.c |6 ++
2 files changed, 2 insertions(+), 5 deletions(-)
Please note t
One semi-colon is enough.
Signed-off-by: Jesper Juhl
---
drivers/media/dvb/frontends/dib0090.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb/frontends/dib0090.c
b/drivers/media/dvb/frontends/dib0090.c
index 224d81e..d9fe60b 100644
--- a/drivers/media
On Mon, 6 Feb 2012, Thierry Reding wrote:
> * Jesper Juhl wrote:
> > In tm6000_ir_fini() there seems to be a problem.
> > rc_unregister_device(ir->rc); calls rc_free_device() on the pointer it is
> > given, which frees it.
> >
> > Subsequently the functi
Signed-off-by: Jesper Juhl
---
drivers/media/video/adp1653.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
compile tested only.
diff --git a/drivers/media/video/adp1653.c b/drivers/media/video/adp1653.c
index 12eedf4..badbdb6 100644
--- a/drivers/media/video/adp1653.c
+++ b
b_free_urb() before the return.
Signed-off-by: Jesper Juhl
---
drivers/staging/media/easycap/easycap_main.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
compile tested only
diff --git a/drivers/staging/media/easycap/easycap_main.c
b/drivers/staging/media/easycap/easycap_main.c
e does or why.
I don't even have a means to test it, so beyond testing that the
change compiles it has seen no testing what-so-ever.
Anyway, here's a proposed patch.
Signed-off-by: Jesper Juhl
---
drivers/media/video/tm6000/tm6000-input.c |3 +--
1 files changed, 1 insertions(
This patch removes the unneeded include.
Signed-off-by: Jesper Juhl
---
drivers/media/dvb/frontends/drxk_hard.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
compile tested only
diff --git a/drivers/media/dvb/frontends/drxk_hard.c
b/drivers/media/dvb/frontends/drxk_hard.c
index
As pointed out by 'make versioncheck', there's no need for
drivers/media/dvb/frontends/tda18271c2dd.c to
#include , so this patch removes the include.
Signed-off-by: Jesper Juhl
---
drivers/media/dvb/frontends/tda18271c2dd.c |1 -
1 files changed, 0 insertions(+), 1 deletions
In the unlikely case that pci_find_bus() should return NULL
viacam_serial_is_enabled() is going to dereference a NULL pointer and
blow up. Better safe than sorry, so be defensive and check the
pointer.
Signed-off-by: Jesper Juhl
Acked-by: Jonathan Corbet
---
drivers/media/video/via-camera.c
l.h
+++ b/include/media/pwc-ioctl.h
@@ -53,7 +53,6 @@
*/
#include
-#include
/* Enumeration of image sizes */
#define PSZ_SQCIF 0x00
--
1.7.6
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, p
On Thu, 21 Jul 2011, Jesper Juhl wrote:
> On Tue, 19 Jul 2011, Michael Krufky wrote:
>
> > On Tue, Jul 19, 2011 at 3:37 AM, Jesper Juhl wrote:
> > > Hi
> > >
> > > I have a bunch of Hauppauge HVR-1900 model 73219's, some are revision D1E9
> >
On Tue, 19 Jul 2011, Michael Krufky wrote:
> On Tue, Jul 19, 2011 at 3:37 AM, Jesper Juhl wrote:
> > Hi
> >
> > I have a bunch of Hauppauge HVR-1900 model 73219's, some are revision D1E9
> > and work perfectly, but with the newer revision D1F5's the t
On Tue, 19 Jul 2011, Michael Krufky wrote:
> On Tue, Jul 19, 2011 at 3:37 AM, Jesper Juhl wrote:
...
> > I can test any patches you may come up with and if there's any further
> > information you need from me in order to get an idea about what the
> > problem is, then j
edev, u32 pin,
> -struct smscore_config_gpio *pinconfig);
> -int smscore_set_gpio(struct smscore_device_t *coredev, u32 pin, int
> level);
>
> /* new GPIO management */
> extern int smscore_gpio_configure(struct smscore_device_t *coredev, u8
> PinNum,
>
black screen).
Any ideas on how to fix this?
I can test any patches you may come up with and if there's any further
information you need from me in order to get an idea about what the
problem is, then just ask.
Please CC me on replies since I'm not subscribed to the linux-media l
This patch fixes all 3 issues.
Signed-off-by: Jesper Juhl
---
drivers/media/dvb/frontends/drxd_hard.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb/frontends/drxd_hard.c
b/drivers/media/dvb/frontends/drxd_hard.c
index f132e49..0266a83 10
ned-off-by: Jesper Juhl
---
drivers/media/video/omap/omap_vout.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/omap/omap_vout.c
b/drivers/media/video/omap/omap_vout.c
index 4d07c58..a647894 100644
--- a/drivers/media/video/omap/omap_vout.c
+++ b/dri
In the unlikely case that pci_find_bus() should return NULL
viacam_serial_is_enabled() is going to dereference a NULL pointer and
blow up. Better safe than sorry, so be defensive and check the
pointer.
Signed-off-by: Jesper Juhl
---
drivers/media/video/via-camera.c |2 ++
1 files changed, 2
It was pointed out by 'make versioncheck' that linux/version.h was not
always being included where needed and sometimes included needlessly
in drivers/media/video/.
This patch fixes up the includes.
Signed-off-by: Jesper Juhl
---
drivers/media/video/cpia2/cpia2.h|1
It was pointed out by 'make versioncheck' that linux/version.h was not
always being included where needed and sometimes included needlessly
in drivers/media/radio/.
This patch fixes up the includes.
Signed-off-by: Jesper Juhl
---
drivers/media/radio/si470x/radio-si470x-i2c.c |1
It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/media/dvb/.
This patch removes them.
Signed-off-by: Jesper Juhl
---
drivers/media/dvb/frontends/drxd_hard.c |1 -
drivers/media/dvb/siano/smscoreapi.h|1 -
2 files
It was pointed out by 'make versioncheck' that some includes of
linux/version.h were not needed in include/.
This patch removes them.
Signed-off-by: Jesper Juhl
---
include/linux/ceph/messenger.h |1 -
include/media/pwc-ioctl.h |1 -
2 files changed, 0 insertions(+), 2
the code in any way, but it makes the tool shut up.
The patch below also removes a rather pointless blank line.
Signed-off-by: Jesper Juhl
---
smsusb.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/dvb/siano/smsusb.c b/drivers/media/dvb/siano/smsusb.c
inde
On Thu, 7 Apr 2011, Malcolm Priestley wrote:
> On Thu, 2011-04-07 at 21:46 +0200, Jesper Juhl wrote:
> > Don't leak 'fw' in
> > drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to
> > call release_firmware().
> >
> > Si
Don't leak 'fw' in
drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to
call release_firmware().
Signed-off-by: Jesper Juhl
---
lmedm04.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
compile tested only
diff --git a/drivers/media/dvb/dvb-u
If the second memory allocation in dib9000_attach() fails, we'll leak the
memory allocated by the first.
Signed-off-by: Jesper Juhl
---
dib9000.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
compile tested only...
diff --git a/drivers/media/dvb/frontends/dib9000
We leak the memory allocated to 'fw' (the firmware) when the variable goes
out of scope.
Fix the leak by calling release_firmware(fw) before 'fw' goes out of
scope.
Signed-off-by: Jesper Juhl
---
cx23885-cards.c |1 +
1 file changed, 1 insertion(+)
compile tested
On Thu, 17 Feb 2011, Matthias Schwarzott wrote:
> On Thursday 17 February 2011, Jesper Juhl wrote:
> > On Thu, 17 Feb 2011, Matthias Schwarzott wrote:
> > > On Sunday 06 February 2011, Jesper Juhl wrote:
> > > > If the memory allocation to 'state' succeeds
On Thu, 17 Feb 2011, Matthias Schwarzott wrote:
> On Sunday 06 February 2011, Jesper Juhl wrote:
> > If the memory allocation to 'state' succeeds but we jump to the 'error'
> > label before 'state' is assigned to fe->tuner_priv, then the call to
In drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c:ttusb_boot_dsp() we
need to call release_firmware(fw) before returning or we'll leak - no
matter if we succeed or fail.
Signed-off-by: Jesper Juhl
---
dvb-ttusb-budget.c |1 +
1 file changed, 1 insertion(+)
compile tested only.
e expensive than the local variable, so I
just added a 'kfree(state)' call. I guess the call to 'zl10036_release'
might not even be needed in this case, but I wasn't sure, so I left it in.
Signed-off-by: Jesper Juhl
---
zl10036.c |1 +
1 file changed, 1 insertion(+)
compil
27;m not at all intimate
with this code so I'd like a bit of review/comments on this before it's
applied.
Anyway, here's a proposed patch.
Signed-off-by: Jesper Juhl
---
stv06xx_pb0100.c |2 ++
1 file changed, 2 insertions(+)
compile tested only.
diff --git a/dri
or loop. This does
not actually make any difference, it just seemed more correct to me to let
variables exist only in the innermost scope they are used.
Signed-off-by: Jesper Juhl
---
pd-video.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
compile tested only.
d
On Sun, 2 Jan 2011, Jesper Juhl wrote:
> On Fri, 31 Dec 2010, Malcolm Priestley wrote:
>
> > On Fri, 2010-12-31 at 15:51 +0100, Jesper Juhl wrote:
> > > On Fri, 31 Dec 2010, Malcolm Priestley wrote:
> > >
> > > > On Fri, 2010-12-31 at 00
On Fri, 31 Dec 2010, Malcolm Priestley wrote:
> On Fri, 2010-12-31 at 15:51 +0100, Jesper Juhl wrote:
> > On Fri, 31 Dec 2010, Malcolm Priestley wrote:
> >
> > > On Fri, 2010-12-31 at 00:11 +0100, Jesper Juhl wrote:
> > > > Hi,
> > > >
> &g
Hi,
We may leak the storage allocated to 'state' in
drivers/media/dvb/frontends/ix2505v.c::ix2505v_attach() on error.
This patch makes sure we free the allocated memory in the failure case.
Signed-off-by: Jesper Juhl
---
ix2505v.c |1 +
1 file changed, 1 insertion(+)
Comp
1122144 1019927d7 drivers/media/video/saa7164/saa7164-fw.o
after:
textdata bss dec hex filename
7931 1122136 1017927c3 drivers/media/video/saa7164/saa7164-fw.o
Signed-off-by: Jesper Juhl
---
saa7164-fw.c |4 +---
1 file changed, 1 insertion(
Hi,
The [vk][cmz]alloc(_node) family of functions return void pointers which
it's completely unnecessary/pointless to cast to other pointer types since
that happens implicitly.
This patch removes such casts from drivers/media/
Signed-off-by: Jesper Juhl
---
cx231xx-417.c |4 ++--
1
51 matches
Mail list logo
