Hi,
I have a Dell Lattitude 7280 with two webcams. The standard one works
fine (/dev/video0). The other one is an IR camera (/dev/video1). The
camera proper works fine and produces 340x374 frames. But there is an IR
led supposed to light the object. The video is 30fps, but the LED seems
to emit li
From: Matej Hulín
Stop accessing timer struct members directly and use the setup_timer
helper intended for that use. It makes the code cleaner and will allow
for easier change of the timer struct internals.
Signed-off-by: Matej Hulín
Signed-off-by: Jiri Slaby
Cc: Hans Verkuil
Cc: Mauro
On 07/11/2016, 07:58 AM, Hans Verkuil wrote:
>> +static char *artifacts_warning = "BEWARE OF KNOWN ISSUES WITH VIDEO
>> QUALITY\n"
>
> const char * const
Or even better, drop the extra space for pointer:
static const char artifacts_warning[] =
thanks,
--
js
suse labs
--
To unsubscribe from th
On 12/12/2015, 10:12 PM, Benjamin Larsson wrote:
> On 12/12/2015 10:08 PM, Jiri Slaby wrote:
>> Hello,
>>
>> I have a USB device which digitizes composite video into a MPEG-2 stream
>> (I think). It is an AF9035 device according to windows. But it has no
>> tuner.
Hello,
I have a USB device which digitizes composite video into a MPEG-2 stream
(I think). It is an AF9035 device according to windows. But it has no
tuner. Is there a way to make it working on linux or am I out of luck?
lsusb -v:
Bus 001 Device 016: ID 1d19:6105 Dexatek Technology Ltd. Video gra
ff-by: Jiri Slaby
Cc: Sean Young
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/ttusbir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c
index cf0d47f..891762d 100644
--- a/drivers/media/rc/ttusbir.c
On 01/11/2013 01:39 PM, Mauro Carvalho Chehab wrote:
> tgz:
> git archive --format tgz HEAD >dtv-scan-files-`date
> +"%Y%m%d.%H:%M"`.tar.gz
Better to use the top commit date:
git log -n1 --date=short --pretty=format:%ad
You won't generate a snapshot every day with the same contents then.
On 01/10/2013 09:49 PM, Manu Abraham wrote:
> On 1/11/13, Jiri Slaby wrote:
>> On 01/10/2013 09:38 PM, Manu Abraham wrote:
>>> The format can be definitely changed. There's no issue to it.
>>
>> No you cannot. Applications depend on that, it's part of
On 01/10/2013 09:41 PM, Jiri Slaby wrote:
> On 01/10/2013 09:38 PM, Manu Abraham wrote:
>> The format can be definitely changed. There's no issue to it.
>
> No you cannot. Applications depend on that, it's part of the dvb ABI. If
> you changed that, you would do the
On 01/10/2013 09:38 PM, Manu Abraham wrote:
> The format can be definitely changed. There's no issue to it.
No you cannot. Applications depend on that, it's part of the dvb ABI. If
you changed that, you would do the same mistake as Mauro let it flowing
through his tree and it was pointed out by Li
On 01/10/2013 09:25 PM, Manu Abraham wrote:
>> Also, purely out of curiousity, how are the scanfiles used during
>> development?
>
> The scanfiles what you call them are the configuration files for dvb-apps,
> rather than purely data files.
But you cannot change their format, so what's the point?
On 01/10/2013 08:08 PM, Manu Abraham wrote:
> On 1/11/13, Jiri Slaby wrote:
>> On 01/10/2013 07:46 PM, Manu Abraham wrote:
>>> The scan files and config files are very specific to dvb-apps, some
>>> applications
>>> do rely on these config files. It doesn'
On 01/10/2013 07:56 PM, Michael Krufky wrote:
> I see great value in separating the history of the data files from the
> code files. If you really think this is such a terrible task for a
> developer to have to pull from a second repository to fetch these data
> files, then I find no reason why we
On 01/10/2013 07:46 PM, Manu Abraham wrote:
> The scan files and config files are very specific to dvb-apps, some
> applications
> do rely on these config files. It doesn't really make sense to have
> split out config
> files for these small applications.
I don't care where they are, really. Howe
2013 10:43:23 +0100
>>>> Oliver Schinagl escreveu:
>>>>
>>>>> On 08-01-13 21:01, Johannes Stezenbach wrote:
>>>>>> On Mon, Jan 07, 2013 at 01:48:29PM +0100, Oliver Schinagl wrote:
>>>>>>> On 07-01-13 11:46, Jiri Slaby w
On 01/09/2013 03:41 PM, Mauro Carvalho Chehab wrote:
> Christoph,
>
> Thank you for all the hard work over all those years!
Yeah, I second this.
I have a note though. Who is going to fix the URL in kaffeine? And how
often is kaffeine.kde.org/scanfile.dvb.qz updated? Is this done
automatically? A
On 12/18/2012 11:01 PM, Oliver Schinagl wrote:
> Unfortunatly, I have had zero replies.
Hmm, it's sad there is a silence in this thread from linux-media guys :/.
> So why bring it up again? On 2012/11/30 Jakub Kasprzycki provided us
> with updated polish DVB-T frequencies for his region. This has
properly stopped in that case. And
the device stops working from that moment on.
Signed-off-by: Jiri Slaby
---
drivers/media/usb/dvb-usb/dib0700_core.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c
b/drivers/media/usb/dvb-usb
--
js
# HG changeset patch
# User Jiri Slaby
# Date 1354786687 -3600
# Node ID c72238053530a0ad8e446af2cce0cb8d14c9640a
# Parent 96025655e6e844af2bc69bd368f8d04a4e5bc58b
scan_data/cz-all: 4th multiplex has FEC 3/4
Not 2/3. This I inappropriatelly got from the website. But it is
wrong. 3/4 is
err() already adds \n to the end of the format string. So remove one
more \n from formatting strings in the dib0700 driver.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: Michael Krufky
---
drivers/media/dvb/dvb-usb/dib0700_core.c |6 +++---
1 file changed, 3 insertions(+), 3
BTW I would appreciate if you move also dvb-utils to GIT. hg wastes our
time.
--
js
suse labs
# HG changeset patch
# User Jiri Slaby
# Date 1340742534 -7200
# Node ID 96025655e6e844af2bc69bd368f8d04a4e5bc58b
# Parent 4030c51d6e7baef760e65d4ff2e8f61af91bec02
proper dvb-t scan data for Czech
To properly support the three LEDs which are on the stick, we need
a special handling in the ->frontend_attach function. Thus let's have
a separate ->frontend_attach instead of ifs in the common one.
The hadnling itself will be added in further patches.
Signed-off-by: Jiri Slaby
-
This means cut & paste from the former f. attach. But while at it write
to the right GPIO to turn on the right LED. Also turn the other two
off jsut for sure.
Signed-off-by: Jiri Slaby
---
drivers/media/dvb/dvb-usb/dib0700_devices.c | 36 +-
1 files changed
Add an override of read_status to intercept lock status. This allows
us to switch LEDs appropriately on and off with signal un/locked.
The second phase is to override sleep to properly turn off both.
This is a hackish way to achieve that.
Thanks to Mike Krufky for his help.
Signed-off-by: Jiri
The start is common for both stk7070pd and novatd specific routine.
This is just a preparation for the next patch.
Signed-off-by: Jiri Slaby
---
drivers/media/dvb/dvb-usb/dib0700_devices.c | 22 ++
1 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers
On 06/17/2011 08:04 AM, Hans Petter Selasky wrote:
> PS: Don't forget the other patch to add a dependency to DVB_CORE.
Sorry, I'm not your fixing monkey. Fix your bugs on your own.
thanks,
--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to
Telling the user they can disable an option if they want is not the
much useful. Describe what it is good for instead.
The text was derived from Mauro's email.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: Hans Petter Selasky
---
drivers/media/Kconfig | 10 ++
1
Hi,
I've just updated to 3.0-rc and saw CONFIG_DVB_NET. Hmm, let's see
what's that by asking with '?'. And I got this crap:
CONFIG_DVB_NET:
The DVB network support in the DVB core can
optionally be disabled if this
option is set to N.
If unsure say Y.
Why do you
to -final, then what should happen is
> that the original commit is reverted; the "fix" for IOMMUs resulted in
> a regression for existing users which isn't trivial to resolve without
> risking possible breakage of other users.
Hi, as -rc4 is out, I think it's time to
On 04/09/2011 05:10 PM, Janusz Krzysztofik wrote:
> (CC: Jiri Slaby, the author of the problematic change; truncate subject)
>
> On Sat, 09 Apr 2011, at 09:16:24, Russell King - ARM Linux wrote:
>> On Sat, Apr 09, 2011 at 03:33:39AM +0200, Janusz Krzysztofik wrote:
>>> Si
On 03/21/2011 11:43 PM, Mauro Carvalho Chehab wrote:
> As I got no return, and the patch looked sane, I've reviewed the comment
> myself,
Aha, I forgot to send it. Sorry.
It looks OK.
> Author: Jiri Slaby
> Date: Mon Feb 28 06:37:02 2011 -0300
>
> [media] V4L:
On 03/01/2011 09:21 AM, Jiri Slaby wrote:
> mem->dma_handle is a dma address obtained by dma_alloc_coherent which
> needn't be a physical address as a hardware IOMMU can (and most
> likely will) return a bus address where physical != bus address. So
> ensure we are remapping (
it is a bug because many v4l drivers use this layer and have
no idea whether IOMMU is in the system and running or not.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: Konrad Rzeszutek Wilk
---
This is a version with updated changelog.
drivers/media/video/videobuf-dma-contig.c |2 +-
On 02/28/2011 03:53 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 28, 2011 at 10:37:02AM +0100, Jiri Slaby wrote:
>> mem->dma_handle is a dma address obtained by dma_alloc_coherent which
>> needn't be a physical address in presence of IOMMU. So ensure we are
>
> Can
On 02/28/2011 04:14 PM, Laurent Pinchart wrote:
> Hi Jiri,
>
> On Monday 28 February 2011 16:07:43 Jiri Slaby wrote:
>> On 02/28/2011 11:53 AM, Laurent Pinchart wrote:
>>> On Monday 28 February 2011 10:37:02 Jiri Slaby wrote:
>>>> mem->dma_handle is a dma
On 02/28/2011 11:53 AM, Laurent Pinchart wrote:
> On Monday 28 February 2011 10:37:02 Jiri Slaby wrote:
>> mem->dma_handle is a dma address obtained by dma_alloc_coherent which
>> needn't be a physical address in presence of IOMMU. So ensure we are
>> remapping (remap
, use PFN_DOWN instead of explicit shift.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: Konrad Rzeszutek Wilk
---
drivers/media/video/videobuf-dma-contig.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/videobuf-dma-contig.c
b/drivers/media/
On 02/24/2011 02:49 PM, Mauro Carvalho Chehab wrote:
> Em 24-02-2011 10:41, Jiri Slaby escreveu:
>> On 02/24/2011 01:53 PM, Mauro Carvalho Chehab wrote:
>>> Em 24-02-2011 09:24, Jiri Slaby escreveu:
>>>> Hmm, could anybody pick it up?
>>>>
>>>>
On 02/24/2011 01:53 PM, Mauro Carvalho Chehab wrote:
> Em 24-02-2011 09:24, Jiri Slaby escreveu:
>> Hmm, could anybody pick it up?
>>
>> On 02/05/2011 07:20 PM, Jiri Slaby wrote:
>>> These devices use different internal structures (dib7000m) and
>>> dib
Hmm, could anybody pick it up?
On 02/05/2011 07:20 PM, Jiri Slaby wrote:
> These devices use different internal structures (dib7000m) and
> dib7000p pid ctrl accesses invalid members causing kernel to die.
>
> Introduce pid control functions for dib7000m which operate on the
> co
89 f5 41 54 55 53 48 89 fb 48 83 ec 18 <48> 8b 47 10 48 83 38
00 0f 84 c8 00 00 00 65 48 8b 04 25 40 b5
Signed-off-by: Jiri Slaby
---
drivers/media/dvb/dvb-usb/dib0700_devices.c | 18 +-
drivers/media/dvb/frontends/dib7000m.c | 19 +++
drivers/med
, use PFN_DOWN instead of explicit shift.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: Konrad Rzeszutek Wilk
---
drivers/media/video/videobuf-dma-contig.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/videobuf-dma-contig.c
b/drivers/media/
mem->dma_handle is a dma address obtained by dma_alloc_coherent which
needn't be a physical address in presence of IOMMU. So ensure we are
remapping (remap_pfn_range) the right page in __videobuf_mmap_mapper
by using virt_to_phys(mem->vaddr) and not mem->dma_handle.
Signed-off-by:
Stanse found that there is mutex_lock in a fail path of
cx231xx_i2c_xfer instead of mutex_unlock (i.e. double lock + leaving a
function in locked state). So fix that.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: Devin Heitmueller
---
drivers/media/video/cx231xx/cx231xx-i2c.c |2
On 07/27/2010 08:42 PM, Kulikov Vasiliy wrote:
> Calling schedule() holding spinlock with disables irqs is improper. As
> spinlock protects list coredev->buffers, it can be unlocked untill wakeup.
> This bug was introduced in a9349315f65cd6a16e8fab1f6cf0fd40f379c4db.
>
> Signed-off-by: Kulikov Vas
test.
Signed-off-by: Jiri Slaby
Cc: Andy Walls
Cc: Mauro Carvalho Chehab
Cc: Tejun Heo
Cc: Ian Armstrong
Cc: ivtv-de...@ivtvdriver.org
Cc: linux-media@vger.kernel.org
---
drivers/media/video/ivtv/ivtvfb.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
riptions is like adding nothing.
Signed-off-by: Jiri Slaby
Cc: Markus Rechberger
Cc: Mauro Carvalho Chehab
---
drivers/media/dvb/dvb-core/dmxdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/dvb/dvb-core/dmxdev.c
b/drivers/media/dvb/dvb-core/dmxdev
Hi,
stanse found a locking error in lirc_dev_fop_read:
if (mutex_lock_interruptible(&ir->irctl_lock))
return -ERESTARTSYS;
...
while (written < length && ret == 0) {
if (mutex_lock_interruptible(&ir->irctl_lock)) {#1
ret = -ERESTARTSYS;
break;
}
...
}
remove_wait_queue(&ir->bu
On 07/04/2010 03:22 PM, Andy Walls wrote:
> On Sun, 2010-07-04 at 09:24 +0200, Jiri Slaby wrote:
>> On 07/04/2010 06:11 AM, Andy Walls wrote:
>>> --- a/drivers/media/video/ivtv/ivtvfb.c
>>> +++ b/drivers/media/video/ivtv/ivtvfb.c
>>> @@ -1201,9 +1201,14 @@ sta
On 07/04/2010 06:11 AM, Andy Walls wrote:
> You missed an identical instance of the useless test 10 lines prior in
> ivtvfb_callback_init(). :)
Ah, thank you for pointing out. Find my comment below.
> --- a/drivers/media/video/ivtv/ivtvfb.c
> +++ b/drivers/media/video/ivtv/ivtvfb.c
> @@ -1201,9 +
Stanse found that in ivtvfb_callback_cleanup there is an unneeded test
for itv being NULL. But itv is initialized as container_of with
non-zero offset, so it is never NULL (even if v4l2_dev is). This was
found because itv is dereferenced earlier than the test.
Signed-off-by: Jiri Slaby
Cc: Andy
On 06/06/2010 02:43 PM, Richard Zidlicky wrote:
> Hi,
>
> I have done a minimaly invasive patch for the stable 2.6.34 kernel and
> stress-tested
> it for many hours, definitely seems to improve the behaviour.
>
> I have left out your beautification suggestion for now, want to do more
> playing
On 05/30/2010 05:24 PM, Jiri Slaby wrote:
> struct smscore_buffer_t *get_entry(void)
> {
> struct smscore_buffer_t *cb = NULL;
> spin_lock_irqsave(&coredev->bufferslock, flags);
> if (!list_empty(&coredev->buffers)) {
> cb = (struct smscore_buffer_t *) co
On 05/30/2010 04:52 PM, Richard Zidlicky wrote:
> Hi,
>
> came across following snippet of code
> (2.6.34:drivers/media/dvb/siano/smscoreapi.c) and
> since prepare_to_wait is new for me I am wondering if this is can work?
>
> struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t *c
Userspace is allowed to coalesce events between SYNCs. And since the code
emits UP right after DOWN for the same key, it may be missed
(up+down=nothing). Add an extra sync in between UP and DOWN events to disable
the coalesce.
Signed-off-by: Jiri Slaby
Cc: Dmitry Torokhov
Cc: Mauro Carvalho
Switch second and third memset parameter to stamp the length buffer bytes
by 0xff's, not 255 bytes by low 8 bits of Length.
Signed-off-by: Jiri Slaby
Cc: Matthias Benesch
Cc: Ralph Metzler
Cc: Oliver Endriss
Cc: Mauro Carvalho Chehab
---
drivers/media/dvb/ngene/ngene-core.c |2
On 02/04/2010 07:14 PM, Dmitry Torokhov wrote:
> On Thu, Feb 04, 2010 at 11:31:45AM +0100, Jiri Slaby wrote:
> +
>> +static int dvb_event(struct hid_device *hdev, struct hid_field *field,
>> +struct hid_usage *usage, __s32 value)
>> +{
>> +/*
On 02/04/2010 02:41 PM, Mauro Carvalho Chehab wrote:
> The point is that it is better to name the function right since the beginning.
Sorry, I misunderstood you for the first time. It's .event member of
hid_driver. Hence I named it dvb_event (or now rc_event or whatever).
The function may contain
On 02/04/2010 01:04 PM, Mauro Carvalho Chehab wrote:
>> I have 2 dvb-t receivers and both of them need fullspeed quirk. Further
>> disable_rc_polling (a dvb_usb module parameter) must be set to not get
>> doubled characters now. And then, it works like a charm.
>
> Module parameters always bothers
/dev/null
+++ b/drivers/hid/hid-dvb.c
@@ -0,0 +1,78 @@
+/*
+ * HID driver for dvb devices
+ *
+ * Copyright (c) 2010 Jiri Slaby
+ *
+ * Licensed under the GPLv2.
+ */
+
+#include
+#include
+#include
+
+#include "hid-ids.h"
+
+#define FULLSPEED_INTERVAL 0x1
+
+static int dvb_event(struct hid_d
On 02/01/2010 10:23 PM, Antti Palosaari wrote:
> On 02/01/2010 09:42 PM, Jiri Slaby wrote:
>> On 02/01/2010 07:28 PM, Jiri Kosina wrote:
>>> On Mon, 1 Feb 2010, Pekka Sarnila wrote:
>>>><3>af9015: command failed:255
>>>><3>dvb
On 02/01/2010 07:28 PM, Jiri Kosina wrote:
> On Mon, 1 Feb 2010, Pekka Sarnila wrote:
>> Well short answer is: No, it does not work.
Hi, thanks for the input.
>> What I did:
>>
>> I pulled few days ago latest
>>
>>git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
>>
>> and
On 01/25/2010 12:44 AM, Antti Palosaari wrote:
> When I now test this patch with debugs enabled I don't see
> .probe and .disconnect be called for this HID interface (interface 1) at
> all and thus checks not needed.
What happens if you disable the HID layer? Or at least if you add an
ignore quirk
On 01/24/2010 05:16 PM, Antti Palosaari wrote:
>> +af9015_config.eeprom_sum = 0;
>> +for (reg = 0; reg< eeprom_size / sizeof(u32); reg++) {
>> +af9015_config.eeprom_sum *= GOLDEN_RATIO_PRIME_32;
>> +af9015_config.eeprom_sum += le32_to_cpu(((u32 *)eeprom)[reg]);
>> +}
>>
is moved earlier to the flow, namely from
af9015_af9013_frontend_attach to af9015_read_config, so that
we can access the sum in af9015_read_config already.
Signed-off-by: Jiri Slaby
Cc: Antti Palosaari
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/dvb/dvb-usb
On 01/14/2010 08:09 PM, Antti Palosaari wrote:
> Device ID 15a4:9016 is reference design ID and it is used by vary many
> devices. Also manufacturer string "Afatech" is chipset default one. This
> leads MSI remote in question configured for many devices using default /
> reference values which I do
matched against tables. Hashes will follow.
Signed-off-by: Jiri Slaby
Cc: Antti Palosaari
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/dvb/dvb-usb/af9015.c | 222 ++-
1 files changed, 89 insertions(+), 133 deletions(-)
diff --git
This is just a code shuffle without functional changes. For easier
review of later changes, i.e. preparation.
Signed-off-by: Jiri Slaby
Cc: Antti Palosaari
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/dvb/dvb-usb/af9015.c | 305
So as a final patch, add support for hash and one hash entry
for MSI digi vox mini II:
iManufacturer 1 Afatech
iProduct 2 DVB-T 2
iSerial 3 01010101061
It is now handled with proper IR and key map tables.
Signed-off-by: Jiri Slaby
Cc: Antti Palosaari
Cc: Mauro Carvalho Chehab
0c5
---[ end trace f25ee66d2135f162 ]---
Signed-off-by: Jiri Slaby
Cc: Antti Palosaari
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/dvb/dvb-usb/af9015.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/af9015.c
b/drivers
remove the quirk
as well.
With input going through dvb-usb-remote, the remote works
perfectly.
The device is 15a4:9016.
Signed-off-by: Jiri Slaby
Cc: Jiri Kosina
Cc: Pekka Sarnila
---
drivers/hid/hid-core.c |1 +
drivers/hid/usbhid/hid-core.c |8
drivers/hid/usbhid/hi
On 01/13/2010 09:20 PM, Jiri Kosina wrote:
>> diff --git a/drivers/hid/usbhid/hid-quirks.c
>> b/drivers/hid/usbhid/hid-quirks.c
>> index 38773dc..788d9a3 100644
>> --- a/drivers/hid/usbhid/hid-quirks.c
>> +++ b/drivers/hid/usbhid/hid-quirks.c
>> @@ -41,7 +41,7 @@ static const struct hid_blacklist
MSI digivox mini II works even with remote=2 module parameter. Check
for manufacturer and if it is Afatech, use af9015_ir_table_msi and
af9015_rc_keys_msi.
The device itself is 15a4:9016.
Signed-off-by: Jiri Slaby
Cc: Antti Palosaari
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
the quirk as well.
With input going through dvb-usb-remote, the remote works
perfectly.
Signed-off-by: Jiri Slaby
Cc: Jiri Kosina
---
drivers/hid/usbhid/hid-core.c |8
drivers/hid/usbhid/hid-quirks.c |2 +-
include/linux/hid.h |1 -
3 files changed, 1 inserti
On 01/13/2010 12:32 PM, Andy Walls wrote:
> If you don't mind a delay of until Sunday or so to get the patch applied
> to the V4L-DVB tree, I can take the patch and work it in my normal path
> through Mauro. Let me know.
I have no problem with that.
thanks,
--
js
--
To unsubscribe from this lis
On 01/12/2010 12:48 AM, Andy Walls wrote:
> On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote:
>> Stanse found a potential null dereference in cx18_dvb_start_feed
>> and cx18_dvb_stop_feed. There is a check for stream being NULL,
>> but it is dereferenced earlier. Move the
Mark ivtv-de...@ivtvdriver.org as 'moderated for non-subscribers'.
Signed-off-by: Jiri Slaby
Cc: linux-media@vger.kernel.org
---
MAINTAINERS |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d4baf3d..6f088ac 100644
--- a/M
Stanse found a potential null dereference in cx18_dvb_start_feed
and cx18_dvb_stop_feed. There is a check for stream being NULL,
but it is dereferenced earlier. Move the dereference after the
check.
Signed-off-by: Jiri Slaby
---
drivers/media/video/cx18/cx18-dvb.c | 18 ++
1
Stanse found an unreachable statement in zl10039_attach. There is
a `break' followed by `goto error'. Remove that break, so that it
can handle the error.
Signed-off-by: Jiri Slaby
Cc: Igor M. Liplianin
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/dvb
Stanse found a memory leak in tuner_probe. t is not
freed/assigned on all paths. Fix that.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/video/tuner-core.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers
Stanse found a memory leak in tuner_probe. t is not
freed/assigned on all paths. Fix that.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/video/tuner-core.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers
Stanse found a memory leak in smscore_gpio_configure. buffer is not
freed/assigned on all paths. Fix that.
Signed-off-by: Jiri Slaby
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/dvb/siano/smscoreapi.c |7 +--
1 files changed, 5 insertions(+), 2 deletions
On 01/06/2010 05:47 PM, Jiri Slaby wrote:
> Stanse found a memory leak in tuner_probe. t is not
> freed/assigned on all paths. Fix that.
Oops. I generated two patches here, only the second is for PCI.
Sorry Mauro, you got this one twice.
--
js
--
To unsubscribe from this list: send th
# HG changeset patch
# User Jiri Slaby
# Date 1262532622 -3600
# Node ID 5f093a32da807e2e324e978e36ab092402aece6f
# Parent a66ed623e524395f3805ce6266354f9e52913941
add scan file for Kojal, Czech Republic
diff -r a66ed623e524 -r 5f093a32da80 util/scan/dvb-t/cz-Kojal
--- /dev/null Thu Jan 01 00
On 09/14/2009 11:39 PM, Andreas Mohr wrote:
> On Mon, Sep 14, 2009 at 11:34:40PM +0200, Jiri Slaby wrote:
>> On 09/14/2009 11:07 PM, Andreas Mohr wrote:
>>> msecs_to_jiffies(1) is quite a bit too boldly assuming
>>> that all of the msecs_to_jiffies(x) implementation b
On 09/14/2009 11:07 PM, Andreas Mohr wrote:
> ./drivers/media/video/zc0301/zc0301_core.c
> do
> cam->module_param.frame_timeout *
> 1000 * msecs_to_jiffies(1) );
> multiple times each.
> What they should do instead is
> frame_timeout * msecs_t
There is one superfluos (imbalanced) unlock in a poll
function. Remove it.
Signed-off-by: Jiri Slaby
---
drivers/media/video/saa7134/saa7134-video.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/saa7134/saa7134-video.c
b/drivers/media/video
Hrm, nobody picked these up, twice. Maybe this time :)?
--
There are many lock imbalances in this driver. Fix all found.
Signed-off-by: Jiri Slaby
---
drivers/media/video/hdpvr/hdpvr-core.c | 12 ++--
drivers/media/video/hdpvr/hdpvr-video.c |6 --
2 files changed, 10
There seems to be one superfluos unlock in a poll function. Remove it.
Signed-off-by: Jiri Slaby
---
drivers/media/video/saa7134/saa7134-video.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/saa7134/saa7134-video.c
b/drivers/media/video/saa7134
There are many lock imbalances in this driver. Fix all found.
Signed-off-by: Jiri Slaby
---
drivers/media/video/hdpvr/hdpvr-core.c | 12 ++--
drivers/media/video/hdpvr/hdpvr-video.c |6 --
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video
There is one omitted unlock in em28xx_usb_probe. Fix that.
Signed-off-by: Jiri Slaby
---
drivers/media/video/em28xx/em28xx-cards.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx-cards.c
b/drivers/media/video/em28xx/em28xx-cards.c
There is one path with omitted unlock in si470x_fops_release. Fix that.
Signed-off-by: Jiri Slaby
---
drivers/media/radio/radio-si470x.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/radio/radio-si470x.c
b/drivers/media/radio/radio-si470x.c
index
There are many lock imbalances in this driver. Fix all found.
Signed-off-by: Jiri Slaby
---
drivers/media/video/hdpvr/hdpvr-core.c | 12 ++--
drivers/media/video/hdpvr/hdpvr-video.c |6 --
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video
There is one path with omitted unlock in si470x_fops_release. Fix that.
Signed-off-by: Jiri Slaby
---
drivers/media/radio/radio-si470x.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/radio/radio-si470x.c
b/drivers/media/radio/radio-si470x.c
index
There seems to be one superfluos unlock in a poll function. Remove it.
Signed-off-by: Jiri Slaby
---
drivers/media/video/saa7134/saa7134-video.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/saa7134/saa7134-video.c
b/drivers/media/video/saa7134
There is one omitted unlock in em28xx_usb_probe. Fix that.
Signed-off-by: Jiri Slaby
---
drivers/media/video/em28xx/em28xx-cards.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx-cards.c
b/drivers/media/video/em28xx/em28xx-cards.c
Hi,
we've found that there is a vmalloc call from atomic context:
dvb_dmx_swfilter_packets
-> spin_lock()
-> dvb_dmx_swfilter_packet
-> vmalloc()
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 05/28/2009 03:10 AM, FUJITA Tomonori wrote:
> This replaces dma_sync_single() with dma_sync_single_for_cpu() because
> dma_sync_single() is an obsolete API; include/linux/dma-mapping.h says:
>
> /* Backwards compat, remove in 2.7.x */
> #define dma_sync_single dma_sync_single_for_
98 matches
Mail list logo
