Re: [bug report] [media] davinci: vpif_capture: get subdevs from DT when available

2017-07-11 Thread Kevin Hilman
Dan Carpenter writes: > Hello Kevin Hilman, > > The patch 4a5f8ae50b66: "[media] davinci: vpif_capture: get subdevs > from DT when available" from Jun 6, 2017, leads to the following > static checker warning: > > drivers/media/platform/davinci/vpif_capture.c

[PATCH] [media] davinci: vpif_capture: fix potential NULL deref

2017-07-11 Thread Kevin Hilman
Fix potential NULL pointer dereference in the error path of memory allocation failure. Reported-by: Dan Carpenter Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-16 Thread Kevin Hilman
Sakari Ailus writes: > Hi Kevin, > > On Fri, Jun 09, 2017 at 09:10:26AM -0700, Kevin Hilman wrote: >> The davinci VPIF is a single hardware block, but the existing driver >> is broken up into a common library (vpif.c), output (vpif_display.c) and >> intput (vpif_captur

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-15 Thread Kevin Hilman
Hi Hans, Mauro, On Fri, Jun 9, 2017 at 9:10 AM, Kevin Hilman wrote: > The davinci VPIF is a single hardware block, but the existing driver > is broken up into a common library (vpif.c), output (vpif_display.c) and > intput (vpif_capture.c). > > When migrating to DT, to better mod

[PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-09 Thread Kevin Hilman
platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman --- Changes since v1: - added proper error checking to kzalloc calls - rebased onto media/master drivers/media/platform/davinci/vpif.c | 57

Re: [PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

2017-06-08 Thread Kevin Hilman
On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil wrote: > On 07/06/17 01:37, Kevin Hilman wrote: >> Enable getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) >> am437x-vpfe.c >> >> Signed-o

Re: [PATCH 0/4] [media] davinci: vpif_capture: raw camera support

2017-06-06 Thread Kevin Hilman
On Tue, Jun 6, 2017 at 1:34 PM, Hans Verkuil wrote: > Hi Kevin, > > On 02/06/17 23:34, Kevin Hilman wrote: >> This series fixes/updates the support for raw camera input to the VPIF. >> >> Tested on da850-evm boards using the add-on UI board. Tested with >> bot

[PATCH v2 4/4] [media] davinci: vpif: adaptions for DT support

2017-06-06 Thread Kevin Hilman
platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 49 ++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 3/4] [media] davinci: vpif_capture: cleanup raw camera support

2017-06-06 Thread Kevin Hilman
, and also tested that composite video input still works from ti,tvp514x decoder. Both tests done on the da850-evm board with the add-on UI board. NOTE: Will need further testing for other sensors with different bus formats. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci

[PATCH v2 0/4] [media] davinci: vpif_capture: raw camera support

2017-06-06 Thread Kevin Hilman
=0virtualkey0virtualkeyMT9V032C12STCH-GEVB Kevin Hilman (4): [media] davinci: vpif_capture: drop compliance hack [media] davinci: vpif_capture: get subdevs from DT when available [media] davinci: vpif_capture: cleanup raw camera support [media] davinci: vpif: adaptions for DT support drivers/media

[PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

2017-06-06 Thread Kevin Hilman
Enable getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 126 +- drivers/media/platform/davinci

[PATCH v2 1/4] [media] davinci: vpif_capture: drop compliance hack

2017-06-06 Thread Kevin Hilman
a real fix. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 128e92d1dd5a..fc5c7622660c 100644 --- a/dri

[PATCH 0/4] [media] davinci: vpif_capture: raw camera support

2017-06-02 Thread Kevin Hilman
only camera board with the right connector for the da850-evm UI board. Verified that composite video capture is still working well after these updates. [1] http://www.mouser.com/search/ProductDetail.aspx?R=0virtualkey0virtualkeyMT9V032C12STCH-GEVB Kevin Hilman (4): [media] davinci

[PATCH 4/4] [media] davinci: vpif: adaptions for DT support

2017-06-02 Thread Kevin Hilman
platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 49 ++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/4] [media] davinci: vpif_capture: drop compliance hack

2017-06-02 Thread Kevin Hilman
a real fix. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 128e92d1dd5a..fc5c7622660c 100644 --- a/dri

[PATCH 3/4] [media] davinci: vpif_capture: cleanup raw camera support

2017-06-02 Thread Kevin Hilman
, and also tested that composite video input still works from ti,tvp514x decoder. Both tests done on the da850-evm board with the add-on UI board. NOTE: Will need further testing for other sensors with different bus formats. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci

[PATCH 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

2017-06-02 Thread Kevin Hilman
Enable getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 126 +- drivers/media/platform/davinci

Re: [PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video

2017-05-26 Thread Kevin Hilman
ical Reference Manual, SPRUH77A. > > The VPIF driver incorrectly sets the default format > to V4L2_PIX_FMT_YUV422P. Fix it. > > Reported-by: Alejandro Hernandez > Signed-off-by: Sekhar Nori Acked-by: Kevin Hilman

Re: [PATCH] ARM64: defconfig: enable IR core, decoders and Meson IR device

2017-05-19 Thread Kevin Hilman
Neil Armstrong writes: > This patch enables the MEDIA Infrared RC Decoders and Meson Infrared > decoder for ARM64 defconfig. > These drivers are selected as modules by default. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/configs/defconfig | 5 + > 1 file changed, 5 insertions(+) >

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Kevin Hilman writes: > Bartosz Golaszewski writes: > >> Signed-off-by: Bartosz Golaszewski > > I'll fold this one into the original since it's not yet merged. Oops, Sekhar has already merged this one to his v4.11/dt branch, so he can apply it (or fold it in.) Kevin

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

2017-02-13 Thread Kevin Hilman
Kevin Hilman writes: > Bartosz Golaszewski writes: > >> There's a stray tab in da850_vpif_legacy_init(). Remove it. >> >> Signed-off-by: Bartosz Golaszewski > > Folding into the original, Looks like the version in Sekhar's v4.11/soc branch already has this fixed. Kevin

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > There's a stray tab in da850_vpif_legacy_init(). Remove it. > > Signed-off-by: Bartosz Golaszewski Folding into the original, Kevin > --- > arch/arm/mach-davinci/pdata-quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mac

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

2017-02-13 Thread Kevin Hilman
Sekhar Nori writes: > On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote: >> Bartosz Golaszewski writes: >> >>> When we enable vpif capture on the da850-evm we hit a BUG_ON() because >>> the i2c adapter can't be found. The board file boot uses i2c

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > Signed-off-by: Bartosz Golaszewski I'll fold this one into the original since it's not yet merged. Kevin > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/da850-evm.dts b

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > Signed-off-by: Bartosz Golaszewski Acked-by: Kevin Hilman > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da8

Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

2017-02-10 Thread Kevin Hilman
Hi Bartosz, Bartosz Golaszewski writes: > Similarly to vpif capture: we need to register the vpif display driver > and the corresponding adv7343 encoder in pdata-quirks as the DT > support is not complete. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/mach-davinci/pdata-quirks.c | 86

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

2017-02-07 Thread Kevin Hilman
i2c adapter 1 (not default: zero) */ > - if (of_machine_is_compatible("ti,da850-evm")) > - da850_vpif_capture_config.i2c_adapter_id = 1; > - oops, my bad. Acked-by: Kevin Hilman > ret = da850_register_vpif_capture(&da850_vpif_capture_config); >

Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

2017-02-07 Thread Kevin Hilman
;t currently a way to define the output_routing in the V4L2 drivers (c.f. s_routing) via DT. > Signed-off-by: Bartosz Golaszewski minor nit below, otherwise Reviewed-by: Kevin Hilman > --- > arch/arm/mach-davinci/pdata-quirks.c | 86 > +++- >

Re: [PATCH 09/10] media: vpif: use a configurable i2c_adapter_id for vpif display

2017-02-07 Thread Kevin Hilman
szewski Acked-by: Kevin Hilman > --- > arch/arm/mach-davinci/board-da850-evm.c | 1 + > drivers/media/platform/davinci/vpif_display.c | 2 +- > include/media/davinci/vpif_types.h| 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/m

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

2017-01-27 Thread Kevin Hilman
On Fri, Dec 16, 2016 at 4:49 PM, Kevin Hilman wrote: > Hans Verkuil writes: > >> On 07/12/16 19:30, Kevin Hilman wrote: >>> Prepare the groundwork for adding DT support for davinci VPIF drivers. >>> This series does some fixups/cleanups and then adds the DT bindin

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

2016-12-16 Thread Kevin Hilman
Hans Verkuil writes: > On 07/12/16 19:30, Kevin Hilman wrote: >> Prepare the groundwork for adding DT support for davinci VPIF drivers. >> This series does some fixups/cleanups and then adds the DT binding and >> DT compatible string matching for DT probing. >> >

[PATCH v6.1 1/5] [media] davinci: VPIF: fix module loading, init errors

2016-12-16 Thread Kevin Hilman
Fix problems with automatic module loading by adding MODULE_ALIAS. Also fix various load-time errors cause by incorrect or not present platform_data. Acked-by: Sakari Ailus Signed-off-by: Kevin Hilman --- Minor tweaks since v6 - added ack from Sakari - droped an extraneous change for NULL

Re: [PATCH v6 1/5] [media] davinci: VPIF: fix module loading, init errors

2016-12-16 Thread Kevin Hilman
Hans Verkuil writes: > On 07/12/16 19:30, Kevin Hilman wrote: >> Fix problems with automatic module loading by adding MODULE_ALIAS. Also >> fix various load-time errors cause by incorrect or not present >> platform_data. >> >> Signed-off-by: Kevin Hilman

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

2016-12-08 Thread Kevin Hilman
Hi Javier, Javier Martinez Canillas writes: > On Wed, Dec 7, 2016 at 3:30 PM, Kevin Hilman wrote: >> Prepare the groundwork for adding DT support for davinci VPIF drivers. >> This series does some fixups/cleanups and then adds the DT binding and >> DT compatible string ma

[PATCH v6 2/5] [media] davinci: vpif_capture: remove hard-coded I2C adapter id

2016-12-07 Thread Kevin Hilman
Remove hard-coded I2C adapter in favor of getting the ID from platform_data. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 5 - include/media/davinci/vpif_types.h| 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media

[PATCH v6 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking

2016-12-07 Thread Kevin Hilman
list, and update the irqlock comment to reflect what it actually protects. Suggested-by: Laurent Pinchart Reviewed-by: Laurent Pinchart Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 6 +++--- drivers/media/platform/davinci/vpif_capture.h | 2 +- 2 files changed

[PATCH v6 4/5] [media] dt-bindings: add TI VPIF documentation

2016-12-07 Thread Kevin Hilman
Acked-by: Rob Herring Reviewed-by: Laurent Pinchart Signed-off-by: Kevin Hilman --- .../devicetree/bindings/media/ti,da850-vpif.txt| 83 ++ 1 file changed, 83 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt diff --git a

[PATCH v6 1/5] [media] davinci: VPIF: fix module loading, init errors

2016-12-07 Thread Kevin Hilman
Fix problems with automatic module loading by adding MODULE_ALIAS. Also fix various load-time errors cause by incorrect or not present platform_data. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 5 - drivers/media/platform/davinci/vpif_capture.c | 15

[PATCH v6 0/5] davinci: VPIF: add DT support

2016-12-07 Thread Kevin Hilman
fixes/updates based on reviews from Sakari Changes since v2: - DT binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (5): [media] davinci: VPIF

[PATCH v6 5/5] [media] davinci: VPIF: add basic support for DT init

2016-12-07 Thread Kevin Hilman
Add basic support for initialization via DT Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index f50148dcba64..1b02a6363f77 100644

Re: [PATCH v5 4/5] [media] dt-bindings: add TI VPIF documentation

2016-12-07 Thread Kevin Hilman
Laurent Pinchart writes: > Hi Kevin, > > Thank you for the patch. > > On Tuesday 06 Dec 2016 21:08:25 Kevin Hilman wrote: >> Acked-by: Rob Herring >> Signed-off-by: Kevin Hilman >> --- >> .../devicetree/bindings/media/ti,da850-vpif.txt| 67 ++

Re: [PATCH v5 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking

2016-12-07 Thread Kevin Hilman
Laurent Pinchart writes: > Hi Kevin, > > Thank you for the patch. > > On Tuesday 06 Dec 2016 21:08:24 Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disabled locking when calling the subdev. >> >

Re: [PATCH v4 1/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-12-07 Thread Kevin Hilman
Laurent Pinchart writes: > Hi Kevin, > > On Tuesday 06 Dec 2016 08:49:38 Kevin Hilman wrote: >> Laurent Pinchart writes: >> > On Tuesday 29 Nov 2016 15:57:09 Kevin Hilman wrote: >> >> Video capture subdevs may be over I2C and may sleep during xfer, so we

[PATCH v5 4/5] [media] dt-bindings: add TI VPIF documentation

2016-12-06 Thread Kevin Hilman
Acked-by: Rob Herring Signed-off-by: Kevin Hilman --- .../devicetree/bindings/media/ti,da850-vpif.txt| 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt diff --git a/Documentation/devicetree/bindings

[PATCH v5 5/5] [media] davinci: VPIF: add basic support for DT init

2016-12-06 Thread Kevin Hilman
Add basic support for initialization via DT Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index f50148dcba64..1b02a6363f77 100644

[PATCH v5 1/5] [media] davinci: VPIF: fix module loading, init errors

2016-12-06 Thread Kevin Hilman
Fix problems with automatic module loading by adding MODULE_ALIAS. Also fix various load-time errors cause by incorrect or not present platform_data. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 5 - drivers/media/platform/davinci/vpif_capture.c | 15

[PATCH v5 0/5] davinci: VPIF: add DT support

2016-12-06 Thread Kevin Hilman
strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (5): [media] davinci: VPIF: fix module loading, init errors [media] davinci: vpif_capture: remove hard-coded I2C adapter id [media] davinci: vpif_capture: fix start/stop streaming locking

[PATCH v5 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking

2016-12-06 Thread Kevin Hilman
list. Suggested-by: Laurent Pinchart Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index

[PATCH v5 2/5] [media] davinci: vpif_capture: remove hard-coded I2C adapter id

2016-12-06 Thread Kevin Hilman
Remove hard-coded I2C adapter in favor of getting the ID from platform_data. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 5 - include/media/davinci/vpif_types.h| 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-12-06 Thread Kevin Hilman
On Tue, Dec 6, 2016 at 9:40 AM, Kevin Hilman wrote: > Hans Verkuil writes: > >> On 12/01/2016 10:16 AM, Laurent Pinchart wrote: >>> Hello, >>> >>> On Thursday 01 Dec 2016 09:57:31 Sakari Ailus wrote: >>>> On Wed, Nov 30, 2016 at 04:14:11PM -0

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-12-06 Thread Kevin Hilman
Hans Verkuil writes: > On 12/01/2016 10:16 AM, Laurent Pinchart wrote: >> Hello, >> >> On Thursday 01 Dec 2016 09:57:31 Sakari Ailus wrote: >>> On Wed, Nov 30, 2016 at 04:14:11PM -0800, Kevin Hilman wrote: >>>> Sakari Ailus writes: >>>>&g

Re: [PATCH v4 1/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-12-06 Thread Kevin Hilman
Laurent Pinchart writes: > Hi Kevin, > > Thank you for the patch. > > On Tuesday 29 Nov 2016 15:57:09 Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disabled locking when calling the subdev. >>

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-30 Thread Kevin Hilman
Sakari Ailus writes: > Hi Kevin, > > On Wed, Nov 23, 2016 at 03:25:32PM -0800, Kevin Hilman wrote: >> Hi Sakari, >> >> Sakari Ailus writes: >> >> > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> >> Allow getting of

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-30 Thread Kevin Hilman
Sakari Ailus writes: > Hi Rob and Kevin, > > On Tue, Nov 29, 2016 at 08:41:44AM -0600, Rob Herring wrote: >> On Mon, Nov 28, 2016 at 4:30 PM, Kevin Hilman wrote: >> > Hi Rob, >> > >> > Rob Herring writes: >> > >> >> On Tue, Nov

[PATCH v4 1/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-29 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/davinci

[PATCH v4 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-29 Thread Kevin Hilman
Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 138 +- include/media/davinci/vpif_types.h

[PATCH v4 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-29 Thread Kevin Hilman
Signed-off-by: Kevin Hilman --- .../devicetree/bindings/media/ti,da850-vpif.txt| 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt

[PATCH v4 0/4] davinci: VPIF: add DT support

2016-11-29 Thread Kevin Hilman
binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4): [media] davinci: vpif_capture: don't lock over s_stream [media] davinci: VPIF: add

[PATCH v4 2/4] [media] davinci: VPIF: add basic support for DT init

2016-11-29 Thread Kevin Hilman
. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 48 ++- drivers/media/platform/davinci/vpif_capture.c | 6 drivers/media/platform/davinci/vpif_display.c | 6 3 files changed, 59 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-28 Thread Kevin Hilman
Hi Rob, Rob Herring writes: > On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: >> Signed-off-by: Kevin Hilman >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >> ++ >> .../devicetree/bindings/media/ti,da850

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-28 Thread Kevin Hilman
Rob Herring writes: > On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: >> Signed-off-by: Kevin Hilman >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >> ++ >> .../devicetree/bindings/media/ti,da850-vpif.tx

Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-23 Thread Kevin Hilman
On Fri, Nov 18, 2016 at 4:32 PM, Kevin Hilman wrote: > Cc: Rob Herring > Signed-off-by: Kevin Hilman > --- > .../devicetree/bindings/media/ti,vpif-capture.txt | 65 > ++ > .../devicetree/bindings/media/ti,vpif.txt | 8 +++ > 2 files c

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-23 Thread Kevin Hilman
Hi Sakari, Sakari Ailus writes: > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> Allow getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) > > vpif_capture_get_pdata and "la

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-23 Thread Kevin Hilman
Hi Sakari, Sakari Ailus writes: > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> Allow getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) > > vpif_capture_get_pdata and "la

[PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-22 Thread Kevin Hilman
Signed-off-by: Kevin Hilman --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt

[PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-22 Thread Kevin Hilman
Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/davinci/vpif_types.h

[PATCH v3 1/4] [media] davinci: add support for DT init

2016-11-22 Thread Kevin Hilman
Add basic support for initialization via DT. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b

[PATCH v3 0/4] [media] davinci: VPIF: add DT support

2016-11-22 Thread Kevin Hilman
Add DT support, including getting subdevs from DT ports/endpoints. Changes since v2: - DT binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4

[PATCH v3 2/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-22 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/davinci

Re: [PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-22 Thread Kevin Hilman
Hans Verkuil writes: > On 22/11/16 02:44, Kevin Hilman wrote: >> Cc: Rob Herring >> Signed-off-by: Kevin Hilman >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >> ++ >> .../devicetree/bindings/media/ti,da850-vpif.

[PATCH v2 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-21 Thread Kevin Hilman
Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/davinci/vpif_types.h

[PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-21 Thread Kevin Hilman
Cc: Rob Herring Signed-off-by: Kevin Hilman --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850

[PATCH v2 1/4] [media] davinci: add support for DT init

2016-11-21 Thread Kevin Hilman
Add basic support for initialization via DT. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b

[PATCH v2 2/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-21 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/davinci

[PATCH v2 0/4] [media] davinci: VPIF: add DT support

2016-11-21 Thread Kevin Hilman
Add DT support, including getting subdevs from DT ports/endpoints. Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4): [media] davinci: add support for DT init [media] davinci: vpif_capture

Re: [PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-21 Thread Kevin Hilman
Hans Verkuil writes: > On 19/11/16 01:32, Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disabled locking when calling the subdev. >> >> Signed-off-by: Kevin Hilman >> --- >> drivers/me

Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-21 Thread Kevin Hilman
Arnd Bergmann writes: > On Friday, November 18, 2016 4:32:08 PM CET Kevin Hilman wrote: >> + >> +Required properties: >> +- compatible: must be "ti,vpif-capture" >> +- reg: physical base address and length of the registers set for the device; >> +-

[PATCH 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-18 Thread Kevin Hilman
Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/davinci/vpif_types.h

[PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-18 Thread Kevin Hilman
Cc: Rob Herring Signed-off-by: Kevin Hilman --- .../devicetree/bindings/media/ti,vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,vpif.txt | 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,vpif

[PATCH 1/4] [media] davinci: add support for DT init

2016-11-18 Thread Kevin Hilman
Add basic support for initialization via DT. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b

[PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-18 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/davinci

Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support

2016-11-11 Thread Kevin Hilman
Hans Verkuil writes: > Hi Kevin, > > On 10/26/2016 01:55 AM, Kevin Hilman wrote: >> This series attempts to add DT support to the davinci VPIF capture >> driver. >> >> I'm not sure I've completely grasped the proper use of the ports and >> endpo

Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support

2016-10-28 Thread Kevin Hilman
Kevin Hilman writes: > This series attempts to add DT support to the davinci VPIF capture > driver. > > I'm not sure I've completely grasped the proper use of the ports and > endpoints stuff, so this RFC is primarily to get input on whether I'm > on the right tra

[RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT

2016-10-25 Thread Kevin Hilman
o be done via DT? Not-Yet-Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 132 +- include/media/davinci/vpif_types.h| 9 +- 2 files changed, 134 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/dav

[RFC PATCH 4/6] ARM: dts: davinci: da850-lcdk: enable VPIF capture

2016-10-25 Thread Kevin Hilman
Enable video capture via the on-board TVP5147 decoder hooked up to ch0 one of the VPIF capture input. Signed-off-by: Kevin Hilman --- arch/arm/boot/dts/da850-lcdk.dts | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm

[RFC PATCH 2/6] ARM: davinci: da8xx: VPIF: enable DT init

2016-10-25 Thread Kevin Hilman
Add basic support for DT initializaion of VPIF (capture) via DT. Clocks and mux still need to happen in this file until there are real clock and pinctrl drivers, but the video nodes and subdevs can all come from DT. Signed-off-by: Kevin Hilman --- arch/arm/mach-davinci/da8xx-dt.c | 17

[RFC PATCH 1/6] [media] davinci: add support for DT init

2016-10-25 Thread Kevin Hilman
Add basic support for initialization via DT. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b

[RFC PATCH 5/6] [media] davinci: vpif_capture: don't lock over s_stream

2016-10-25 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/davinci

[RFC PATCH 3/6] ARM: dts: davinci: da850: add VPIF

2016-10-25 Thread Kevin Hilman
Add VPIF and VPIF capture nodes to da850. Note that these are separate nodes because the current media drivers have two separate drivers for vpif and vpif_capture. Signed-off-by: Kevin Hilman --- arch/arm/boot/dts/da850.dtsi | 28 1 file changed, 28 insertions

[RFC PATCH 0/6] media: davinci: VPIF: add DT support

2016-10-25 Thread Kevin Hilman
s are, the rest are just prep work to ge there. Tested on da850-lcdk and was able to do basic frame capture from the composite input. Series applies on v4.9-rc1 Kevin Hilman (6): [media] davinci: add support for DT init ARM: davinci: da8xx: VPIF: enable DT init ARM: dts: davinci: da850:

Re: [PATCH 3/5] [media] rc: meson-ir: Fix module autoload

2016-10-17 Thread Kevin Hilman
bb-irC* > alias: of:N*T*Camlogic,meson-gxbb-ir > alias: of:N*T*Camlogic,meson8b-irC* > alias: of:N*T*Camlogic,meson8b-ir > alias: of:N*T*Camlogic,meson6-irC* > alias: of:N*T*Camlogic,meson6-ir > > Signed-off-by: Javier Martinez Canill

Re: [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver

2016-08-29 Thread Kevin Hilman
Martin Blumenstingl writes: > Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different > register layout for their Infrared Remoete Controller. The decoder mode > is now configured in another register. Without the changes to the > meson-ir driver we are simply getting incorrect "durat

Re: [PATCH v4 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder

2016-08-19 Thread Kevin Hilman
> Signed-off-by: Neil Armstrong > Signed-off-by: Martin Blumenstingl Acked-by: Kevin Hilman Mauro, are you the one to pick up new media/rc drivers? Or if you prefer, with your ack, I'll take this along with the DT and submit via arm-soc. Thanks, Kevin -- To unsubscribe from this

Re: [PATCH v4 1/6] pinctrl: amlogic: gxbb: add the IR remote pin

2016-08-19 Thread Kevin Hilman
gt; + I'm trying to keep the names here so they match the datasheet, which calls this remote_input_ao. Please update throughout the patch. Otherwise looks good to me. Feel free to add Reviewed-by: Kevin Hilman and Linus W can queue it up. Thanks, Kevin -- To unsubscribe from this lis

Re: [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver

2016-08-07 Thread Kevin Hilman
Hi Martin, On Tue, Jun 28, 2016 at 12:17 PM, Martin Blumenstingl wrote: > Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different > register layout for their Infrared Remoete Controller. The decoder mode > is now configured in another register. Without the changes to the > meson-ir d

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

2012-10-09 Thread Kevin Hilman
Sakari Ailus writes: > Hi Kevin, > > Thanks for the comments! > > On Tue, Oct 09, 2012 at 01:50:04PM -0700, Kevin Hilman wrote: >> Hi Sakari, >> >> Sakari Ailus writes: >> >> > The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are conn

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

2012-10-09 Thread Kevin Hilman
Hi Sakari, Sakari Ailus writes: > The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to > the actual CSI-2 receivers outside the ISP itself. Allow changing this > configuration from the ISP driver. > > Signed-off-by: Sakari Ailus These control module registers (CSIRXFE, C

Re: [PATCH v2 04/11] OMAP4: hwmod: Include CSI2A and CSIPHY1 memory sections

2011-12-02 Thread Kevin Hilman
"Aguirre, Sergio" writes: [...] >> >> Also, work with Benoit to make sure at the scripts that autogenerate >> this data are updated to include these two regions. > > Ok. > > As a side note, I might need more addresses for the rest of the ISP > components later on. I'll enable more subsystems onc

Re: [PATCH v2 04/11] OMAP4: hwmod: Include CSI2A and CSIPHY1 memory sections

2011-12-02 Thread Kevin Hilman
+Benoit, "Aguirre, Sergio" writes: > Hi Vaibhav, > > Thanks for the comments. > > On Thu, Dec 1, 2011 at 12:34 AM, Hiremath, Vaibhav wrote: >> >>> -Original Message- >>> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >>> ow...@vger.kernel.org] On Behalf Of Aguirre, Sergio

Re: [PATCH v2 05/11] OMAP4: Add base addresses for ISS

2011-12-02 Thread Kevin Hilman
Sergio Aguirre writes: > NOTE: This isn't the whole list of features that the > ISS supports, but the only ones supported at the moment. > > Signed-off-by: Sergio Aguirre [...] > diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h > b/arch/arm/plat-omap/include/plat/omap44xx.h > index ea2

  1   2   >