[PATCH v4 0/2] ADV748x HDMI/Analog video receiver

2017-06-12 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> This is a driver for the Analog Devices ADV748x device, and follows on from a previous posting by Niklas Söderlund [0] of an earlier incarnation of this driver. Aside from a few bug fixes, and considerable refactoring this

[PATCH v4 2/2] arm64: dts: renesas: salvator-x: Add ADV7482 support

2017-06-12 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide ADV7482, and the needed connectors Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> v4: - dt: Rebase to dts/renesas/salvator-x.dtsi - dt: Use AIN0-7 rather than AIN1-8 arch/arm64/boot

[PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-12 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide support for the ADV7481 and ADV7482. The driver is modelled with 4 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs though two CSI TX entities. The HDMI entity is linked to t

[PATCH v2] media: fdp1: Support ES2 platforms

2017-06-12 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> The new Renesas R-Car H3 ES2.0 platforms have a new hw version register. Update the driver accordingly, defaulting to the new hw revision, and differentiating the older revision as ES1 Signed-off-by: Kieran Bingham <kiera

Re: [PATCH] media: fdp1: Support ES2 platforms

2017-06-10 Thread Kieran Bingham
Hi Laurent, On 10/06/17 08:54, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 09 Jun 2017 18:15:48 Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> The new Renesas R-Car H3 ES2

[PATCH] media: fdp1: Support ES2 platforms

2017-06-09 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> The new Renesas R-Car H3 ES2.0 platforms have an updated hw version register. Update the driver accordingly. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/rcar_fdp1.c

Re: [PATCH v4] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-06-09 Thread Kieran Bingham
Wed, 7 Jun 2017 10:52:07 +0100 >>> Kieran Bingham <kbing...@kernel.org> escreveu: >>> >>>> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >>>> >>>> Return NULL, if a null entity is parsed for it's v4l2_subdev >>

[PATCH v4] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-06-07 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Return NULL, if a null entity is parsed for it's v4l2_subdev Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- Not sure if this patch ever made it out of my mailbox: Here's the respin with t

Re: [PATCH 7/7] [media] v4l: rcar_fdp1: use proper name for the R-Car SoC

2017-05-28 Thread Kieran Bingham
Hi Wolfram Thankyou for the fixup On 28/05/17 18:30, Wolfram Sang wrote: > It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive text. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Acked-by: Kieran Bingham <kieran.bingham+rene...@ideason

[PATCH v4] v4l: async: Match parent devices

2017-05-23 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Devices supporting multiple endpoints on a single device node must set their subdevice fwnode to the endpoint to allow distinct comparisons. Adapt the match_fwnode call to compare against the provided fwnodes first, but t

Re: [PATCH v3 1/2] device property: Add fwnode_graph_get_port_parent

2017-05-23 Thread Kieran Bingham
Hi Sakari, On 23/05/17 22:37, Sakari Ailus wrote: > Hi Kieran, > > On Tue, May 23, 2017 at 06:15:42PM +0100, Kieran Bingham wrote: >> >> >> On 23/05/17 13:58, Sakari Ailus wrote: >>> Hi Kieran, >>> >>> On Mon, May 22, 2017 at 06:36:37PM

Re: [PATCH v3 2/2] v4l: async: Match parent devices

2017-05-23 Thread Kieran Bingham
On 23/05/17 22:43, Sakari Ailus wrote: > On Wed, May 24, 2017 at 12:40:19AM +0300, Sakari Ailus wrote: >>> * When all devices use endpoint matching, this code can be simplified, and >>> the >>> * parent comparisons can be removed. > > Oh, and this I'm not so sure about --- we'll need to match

Re: [PATCH v3 2/2] v4l: async: Match parent devices

2017-05-23 Thread Kieran Bingham
On 23/05/17 14:02, Sakari Ailus wrote: > Hi Kieran, > > On Mon, May 22, 2017 at 06:36:38PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> Devices supporting multiple endpoints on a single device node m

Re: [PATCH v3 1/2] device property: Add fwnode_graph_get_port_parent

2017-05-23 Thread Kieran Bingham
On 23/05/17 13:58, Sakari Ailus wrote: > Hi Kieran, > > On Mon, May 22, 2017 at 06:36:37PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> Provide a helper to obtain the parent device fwnode without first >

Re: [PATCH v3 2/2] media: i2c: adv748x: add adv748x driver

2017-05-23 Thread Kieran Bingham
todo list and being worked through... There are a sprinkling of questions below so I'll send this now :) > > On Wednesday 17 May 2017 15:13:18 Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> Provide basic support for th

[PATCH v3 2/2] v4l: async: Match parent devices

2017-05-22 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Devices supporting multiple endpoints on a single device node must set their subdevice fwnode to the endpoint to allow distinct comparisons. Adapt the match_fwnode call to compare against the provided fwnodes first, bu

[PATCH v3 0/2] v4l: async: Match parent devices

2017-05-22 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> As devices become more complicated, it becomes necessary (and more accurate) to match devices based on their endpoint, as devices may have multiple subdevices. To support using endpoints in the V4L2 async subdev framework, whil

[PATCH v3 1/2] device property: Add fwnode_graph_get_port_parent

2017-05-22 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide a helper to obtain the parent device fwnode without first parsing the remote-endpoint as per fwnode_graph_get_remote_port_parent. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v

Re: [PATCH v2 2/2] v4l: async: Match parent devices

2017-05-22 Thread Kieran Bingham
Reviewing my own post: On 19/05/17 17:16, Kieran Bingham wrote: > From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > > Devices supporting multiple endpoints on a single device node must set > their subdevice fwnode to the endpoint to allow distinct compa

Re: [PATCH v2 1/2] device property: Add fwnode_graph_get_port_parent

2017-05-22 Thread Kieran Bingham
Hi Sakari, On 19/05/17 22:51, Sakari Ailus wrote: > Hi Kieran, > > On Fri, May 19, 2017 at 05:16:02PM +0100, Kieran Bingham wrote: >> +struct fwnode_handle * >> +fwnode_graph_get_port_parent(struct fwnode_handle *endpoint) >> +{ >> +return fwnode_call_ptr_o

Re: [PATCH v1 3/3] v4l: async: Match parent devices

2017-05-22 Thread Kieran Bingham
Hi Laurent, On 18/05/17 15:01, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Wednesday 17 May 2017 16:03:39 Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> Devices supporting multiple

Re: [PATCH v3 0/5] R-Car DU: Fix IOMMU operation when connected to VSP

2017-05-22 Thread Kieran Bingham
-by: again please? -- Regards Kieran Bingham On 22/05/17 15:19, Kieran Bingham wrote: > Hello, > > This patch series fixes the rcar-du-drm driver to support VSP plane sources > with an IOMMU. It is available for convenience at > > git.kernel.org/pub/scm/linux/kernel/git/kbingh

[PATCH v3 3/5] v4l: vsp1: Map the DL and video buffers through the proper bus master

2017-05-22 Thread Kieran Bingham
device as usual otherwise. Suggested-by: Magnus Damm <magnus.d...@gmail.com> [Cache the bus master device] Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Signed-off-by: Kieran Bing

[PATCH v3 1/5] v4l: rcar-fcp: Don't get/put module reference

2017-05-22 Thread Kieran Bingham
ller's back. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/rcar-fcp.c | 11 ++

[PATCH v3 2/5] v4l: rcar-fcp: Add an API to retrieve the FCP device

2017-05-22 Thread Kieran Bingham
hart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/rcar-fcp.c | 6 ++ include/media/rcar-fcp.h | 5 + 2 files changed, 11 insertions(

[PATCH v3 4/5] v4l: vsp1: Add API to map and unmap DRM buffers through the VSP

2017-05-22 Thread Kieran Bingham
driver are coherent, we can skip cache handling when mapping and unmapping them. This will need to be revisited when support for non-coherent buffers will be added to the DU driver. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kier

[PATCH v3 0/5] R-Car DU: Fix IOMMU operation when connected to VSP

2017-05-22 Thread Kieran Bingham
Hello, This patch series fixes the rcar-du-drm driver to support VSP plane sources with an IOMMU. It is available for convenience at git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git vsp-du/iommu-fcp On R-Car Gen3 the DU has no direct memory access but sources planes through VSP

[PATCH v3 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Kieran Bingham
From: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> For planes handled by a VSP instance, map the framebuffer memory through the VSP to ensure proper IOMMU handling. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Ki

[PATCH v2 2/2] v4l: async: Match parent devices

2017-05-19 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Devices supporting multiple endpoints on a single device node must set their subdevice fwnode to the endpoint to allow distinct comparisons. Adapt the match_fwnode call to compare against the provided fwnodes first, bu

[PATCH v2 1/2] device property: Add fwnode_graph_get_port_parent

2017-05-19 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide a helper to obtain the parent device fwnode without first parsing the remote-endpoint as per fwnode_graph_get_remote_port_parent. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v

[PATCH v2 0/2] v4l: async: Match parent devices

2017-05-19 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> As devices become more complicated, it becomes necessary (and more accurate) to match devices based on their endpoint, as devices may have multiple subdevices. To support using endpoints in the V4L2 async subdev framework, whil

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-19 Thread Kieran Bingham
Hi Sakari, >> >> Finding and matching the parent of the SD would allow a driver to register a >> notifier ASD with a dev node, and expect to match a subdevice that has >> registered it's subdev with an EP node. This would erroneously allow drivers >> to >> register a notifier that would match

Re: [PATCH v1 2/3] device property: Add fwnode_graph_get_port_parent

2017-05-19 Thread Kieran Bingham
Hi Laurent, On 18/05/17 14:36, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Wednesday 17 May 2017 16:03:38 Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> V4L2 async notifiers c

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-18 Thread Kieran Bingham
Hi Sakari, >>> In omap3isp/isp.c: isp_fwnodes_parse() the async notifier is registered >>> looking >>> at the endpoints parent fwnode: >>> >>> isd->asd.match.fwnode.fwnode = >>> fwnode_graph_get_remote_port_parent(fwnode); >>> >>> This would therefore not support

Re: [PATCH v3 2/2] v4l: vsp1: Provide a writeback video device

2017-05-17 Thread Kieran Bingham
Hi Geert, On 16/05/17 16:30, Geert Uytterhoeven wrote: > Hi Kieran, > > On Tue, May 9, 2017 at 6:39 PM, Kieran Bingham > <kieran.bingham+rene...@ideasonboard.com> wrote: >> When the VSP1 is used in an active display pipeline, the output of the >> WPF can

Re: [PATCH v1 1/3] of: base: Provide of_graph_get_port_parent()

2017-05-17 Thread Kieran Bingham
On 17/05/17 17:36, Rob Herring wrote: > On Wed, May 17, 2017 at 10:03 AM, Kieran Bingham <kbing...@kernel.org> wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> When handling endpoints, the v4l2 async framework needs to identify the &g

[PATCH v3.1 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-05-17 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Return NULL, if a null entity is parsed for it's v4l2_subdev Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- include/media/v4l2-subdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v1 1/3] of: base: Provide of_graph_get_port_parent()

2017-05-17 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> When handling endpoints, the v4l2 async framework needs to identify the parent device of a port endpoint. Adapt the existing of_graph_get_remote_port_parent() such that a caller can obtain the parent of a port without p

[PATCH v1 2/3] device property: Add fwnode_graph_get_port_parent

2017-05-17 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> V4L2 async notifiers can pass the endpoint fwnode rather than the device fwnode. Provide a helper to obtain the parent device fwnode without first parsing the remote-endpoint as per fwnode_graph_get_remote_port_parent. Sign

[PATCH v1 3/3] v4l: async: Match parent devices

2017-05-17 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Devices supporting multiple endpoints on a single device node must set their subdevice fwnode to the endpoint to allow distinct comparisons. Adapt the match_fwnode call to compare against the provided fwnodes first, bu

[PATCH v1 0/3] v4l: async: Match parent devices

2017-05-17 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> To support using endpoints in the V4L2 Async subdev framework, we need to be able to parse a fwnode for the device from the endpoint. To enable this, provide an alternative of_graph_get_remote_port_parent which walks up th

Re: [PATCH v3 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-05-17 Thread Kieran Bingham
On 17/05/17 15:25, Geert Uytterhoeven wrote: > Hi Kieran, > > On Wed, May 17, 2017 at 4:13 PM, Kieran Bingham <kbing...@kernel.org> wrote: >> --- a/include/media/v4l2-subdev.h >> +++ b/include/media/v4l2-subdev.h >> @@ -829,7 +829,7 @@ struct v4

[PATCH v3 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-05-17 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Return NULL, if a null entity is parsed for it's v4l2_subdev Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- include/media/v4l2-subdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 2/2] media: i2c: adv748x: add adv748x driver

2017-05-17 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide basic support for the ADV7481 and ADV7482. The driver is modelled with 2 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs. Presently the HDMI is hardcoded to link to the TXA C

[PATCH v3 0/2] ADV748x HDMI/Analog video receiver

2017-05-17 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> This is a driver for the Analog Devices ADV748x device, and follows on from a previous posting by Niklas Söderlund [0] of an earlier incarnation of this driver. Aside from a few bug fixes, and considerable refactoring this

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-17 Thread Kieran Bingham
Hi Sakari, Ok - V3 is now closer :) I'm just trying to do a first spin of adding fwnode_graph_get_port_parent(), then I can post a v3 series. On 16/05/17 23:26, Sakari Ailus wrote: > Hi Kieran, > > On Tue, May 16, 2017 at 01:56:05PM +0100, Kieran Bingham wrote: > ... >&g

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-16 Thread Kieran Bingham
Hi Sakari, (Gianluca, I've pulled you in on CC in respect to discussing changes you implemented for supporting GCC < 4.4.6) On 16/05/17 12:54, Sakari Ailus wrote: > Hi Kieran, > > On Mon, May 15, 2017 at 01:32:41PM +0100, Kieran Bingham wrote: >> Hi Sakari >> >> O

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-15 Thread Kieran Bingham
e.png But the end goal of this patchset will be the following configuration: http://janet.linuxembedded.co.uk/adv748x-non-immutable.png > Please see my comments below. > > On Thu, May 11, 2017 at 06:21:20PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-12 Thread Kieran Bingham
ent :) Please see: http://janet.linuxembedded.co.uk/board-salvator-mc.png Thanks for the review - I'll go through on Monday. The weekend begins :) -- Regards Kieran > > Please see my comments below. > > On Thu, May 11, 2017 at 06:21:20PM +0100, Kieran Bingham wrote: >&g

[RFC PATCH v2 3/4] arm64: dts: r8a7796: salvator-x: enable VIN, CSI and ADV7482

2017-05-11 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide bindings between the VIN, CSI and the ADV7482 on the r8a7796. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 147 +++

[RFC PATCH v2 2/4] arm64: dts: r8a7795: salvator-x: enable VIN, CSI and ADV7482

2017-05-11 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide bindings between the VIN, CSI and the ADV7482 on the r8a7795. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 147 +++

[RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

2017-05-11 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide basic support for the ADV7481 and ADV7482. The driver is modelled with 2 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs. Presently the HDMI is hardcoded to link to the TXA C

[RFC PATCH v2 4/4] rcar-csi2: Map to fwnode endpoints rather than port parents

2017-05-11 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> To support multiple async subdevices on a single device, we need to identify which subdevice maps directly for each connection. Instead of mapping the port parent to the async notifier, use the fwnode of the direct endpoin

[RFC PATCH v2 0/4] RFC: ADV748x HDMI/Analog video receiver

2017-05-11 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> This is an RFC for the Analog Devices ADV748x driver, and follows on from a previous posting by Niklas Söderlund [0] of an earlier incarnation of this driver. Aside from a few bug fixes, and considerable refactoring this

Re: [PATCH] v4l2-subdev: Remove of_node

2017-05-11 Thread Kieran Bingham
On 10/05/17 19:13, Sakari Ailus wrote: > Hi Kieran, > > Thanks for the patch. > > On Wed, May 10, 2017 at 05:45:54PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> With the fwnode implementation,

[PATCH] v4l2-subdev: Remove of_node

2017-05-10 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> With the fwnode implementation, of_node is no longer used. Remove it. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- include/media/v4l2-subdev.h | 2 -- 1 file changed, 2 deletions(-)

[PATCH v3 1/2] Revert "[media] v4l: vsp1: Supply frames to the DU continuously"

2017-05-09 Thread Kieran Bingham
eback mode if there is an output buffer, or disable it (leaving the existing display pipeline unharmed) otherwise. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/driver

[PATCH v3 0/2] vsp1 writeback prototype

2017-05-09 Thread Kieran Bingham
and LIF - Use WPF properties to determine when to create links instead of VSP - Remove incorrect vsp1_video_verify_format() changes - Spelling and grammar fixes Kieran Bingham (2): Revert "[media] v4l: vsp1: Supply frames to the DU continuously" v4l: vsp1: Provide a writeback video devi

[PATCH v3 2/2] v4l: vsp1: Provide a writeback video device

2017-05-09 Thread Kieran Bingham
. The source will be able to perform pixel format conversion, but not rescaling, and as such the output from the memory node will always be of the same dimensions as the display output. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- Changes since RFC

Re: [PATCH 1/4] v4l: vsp1: Implement partition algorithm restrictions

2017-05-09 Thread Kieran Bingham
Hi Laurent, On 13/02/17 19:17, Laurent Pinchart wrote: > Hi Kieran, > > (CC'ing Morimoto-san) > > Thank you for the patch. > > On Friday 04 Nov 2016 18:19:27 Kieran Bingham wrote: >> The partition algorithm introduced to support scaling, and rotation on >

[PATCH v5 2/2] v4l: vsp1: Repair suspend resume operations for video pipelines

2017-05-09 Thread Kieran Bingham
When a suspend/resume action is taken, the pipeline is reset and never reconfigured. To correct this, we establish a new flag pipe->configured and utilise this to establish when we write a full configuration set to the current display list. Signed-off-by: Kieran Bingham <kieran.bingha

[PATCH v5 1/2] v4l: vsp1: Move vsp1_video_setup_pipeline()

2017-05-09 Thread Kieran Bingham
Move the static vsp1_video_setup_pipeline() function in preparation for the callee updates so that the vsp1_video_pipeline_run() call can configure pipelines following suspend resume actions. This commit is just a code move for clarity performing no functional change. Signed-off-by: Kieran

[PATCH v5 0/2] v4l: vsp1: Fix suspend/resume and race on M2M pipelines

2017-05-09 Thread Kieran Bingham
uct * v2: - Refactor video pipeline configuration implementation to solve both suspend resume and the VSP BRU race in a single change v1: - Original pipeline configuration rework Kieran Bingham (2): v4l: vsp1: Move vsp1_video_setup_pipeline() v4l: vsp1: Repair suspend resume operati

Re: [PATCH 3/4] v4l: vsp1: Calculate partition sizes at stream start.

2017-05-08 Thread Kieran Bingham
Hi Laurent, Thanks for the review, V2 to be posted after testing. On 13/02/17 21:21, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 04 Nov 2016 18:19:29 Kieran Bingham wrote: >> Previously the active window and partition sizes for eac

Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-05-06 Thread Kieran Bingham
Hi Sakari, >> Did it get lost? >> It looks like the cleanup series it was based on made it through... > > What I think happened was that I had applied it to the correct branch BUT I > already had sent a pull request on it. My apologies. No worries - thanks for checking! > >> >> Mauro,

Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-05-05 Thread Kieran Bingham
Hi Sakari, On 04/01/17 08:57, Sakari Ailus wrote: > Hi Kieran, > > Thanks for the patch! > > On Tue, Jan 03, 2017 at 05:05:58PM +, Kieran Bingham wrote: >> On 03/01/17 13:36, Laurent Pinchart wrote: >>> Hi Kieran, >>> >>> Thank you for th

[PATCH v4 3/4] v4l: vsp1: Extend VSP1 module API to allow DRM callbacks

2017-05-05 Thread Kieran Bingham
to be registered within the VSP DRM interface. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- driv

[PATCH v4 4/4] drm: rcar-du: Register a completion callback with VSP1

2017-05-05 Thread Kieran Bingham
when the full display pipeline has completed for the frame. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>

[PATCH v4 0/4] RCAR-DU, VSP1: Prevent pre-emptive frame flips on VSP1-DRM pipelines

2017-05-05 Thread Kieran Bingham
Kieran Bingham (3): v4l: vsp1: Postpone frame end handling in event of display list race v4l: vsp1: Extend VSP1 module API to allow DRM callbacks drm: rcar-du: Register a completion callback with VSP1 Laurent Pinchart (1): drm: rcar-du: Arm the page flip event after queuing the page flip

[PATCH v4 1/4] drm: rcar-du: Arm the page flip event after queuing the page flip

2017-05-05 Thread Kieran Bingham
aurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 22 +++--- 1 fil

[PATCH v4 2/4] v4l: vsp1: Postpone frame end handling in event of display list race

2017-05-05 Thread Kieran Bingham
to the user. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp

Re: [PATCH v3 2/2] [media] platform: add video-multiplexer subdevice driver

2017-05-04 Thread Kieran Bingham
Hi Philipp, Thankyou for the patch, On 04/05/17 14:38, Philipp Zabel wrote: > This driver can handle SoC internal and external video bus multiplexers, > controlled by mux controllers provided by the mux controller framework, > such as MMIO register bitfields or GPIOs. The subdevice passes

Re: [PATCH] v4l2-async: add subnotifier registration for subdevices

2017-05-03 Thread Kieran Bingham
Hi Niklas, Small thing to ponder discovered below: On 27/04/17 23:30, Niklas Söderlund wrote: > When registered() of v4l2_subdev_internal_ops is called the subdevice > have access to the master devices v4l2_dev and it's called with the > async frameworks list_lock held. In this context the

Re: [PATCH v4 23/27] rcar-vin: parse Gen3 OF and setup media graph

2017-05-02 Thread Kieran Bingham
Hi Niklas Just a quick comment here, as I've come across it while looking at the fw_node topic. On 27/04/17 23:41, Niklas Söderlund wrote: > Parse the VIN Gen3 OF graph and register all CSI-2 devices in the VIN > group common media device. Once a CSI-2 subdevice is added to the common > media

Re: [PATCH 4/5] arm64: dts: r8a7795: salvator-x: enable VIN, CSI and ADV7482

2017-04-28 Thread Kieran Bingham
On 28/04/17 11:04, Geert Uytterhoeven wrote: > On Fri, Apr 28, 2017 at 10:52 AM, Sergei Shtylyov > <sergei.shtyl...@cogentembedded.com> wrote: >> On 4/27/2017 9:26 PM, Kieran Bingham wrote: >>> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts >>> +++ b

Re: [PATCH v4 07/27] rcar-vin: change name of video device

2017-04-28 Thread Kieran Bingham
ch.se> Functional and tested. Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c >

Re: [PATCH v4 06/27] rcar-vin: move max width and height information to chip information

2017-04-28 Thread Kieran Bingham
..@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/platform/rcar-vin/rcar-core.c | 6 ++ > drivers/media/platform/rcar-vin/rcar-v4l2.c | 6 ++ > drivers/media/platform/rcar-vin/rcar-vin.h | 6 ++ > 3 files

Re: [PATCH v4 05/27] rcar-vin: move chip information to own struct

2017-04-28 Thread Kieran Bingham
iklas Söderlund <niklas.soderlund+rene...@ragnatech.se> This looks good to me Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/platform/rcar-vin/rcar-core.c | 49 > - > drivers/media/platform/rcar-v

Re: [PATCH 0/5] RFC: ADV748x HDMI/Analog video receiver

2017-04-28 Thread Kieran Bingham
Hi Simon, On 28/04/17 08:09, Simon Horman wrote: > On Thu, Apr 27, 2017 at 07:25:59PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> This is an RFC for the Analog Devices ADV748x driver, and follows on from a &g

Re: [PATCH 1/5] v4l2-subdev: Provide a port mapping for asynchronous subdevs

2017-04-27 Thread Kieran Bingham
On 27/04/17 23:49, Sakari Ailus wrote: > Hi Kieran, > > On Thu, Apr 27, 2017 at 11:13:50PM +0100, Kieran Bingham wrote: >> Hi Sakari, >> >> Thanks for taking a look > > Sure! :-) > >> >> On 27/04/17 22:43, Sakari Ailus wrote: >>> Hi Kier

Re: [PATCH 1/5] v4l2-subdev: Provide a port mapping for asynchronous subdevs

2017-04-27 Thread Kieran Bingham
while until it's really > there.) Sure, I'll merge those into my base. > On Thu, Apr 27, 2017 at 07:26:00PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> Devices such as the the ADV748x support multiple parallel

[PATCH 4/5] arm64: dts: r8a7795: salvator-x: enable VIN, CSI and ADV7482

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide bindings between the VIN, CSI and the ADV7482 on the r8a7795. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 129 +

[PATCH 3/5] media: i2c: adv748x: add adv748x driver

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide basic support for the ADV7481 and ADV7482. The driver is modelled with 2 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs. Presently the HDMI is hardcoded to link to the TXA C

[PATCH 2/5] rcar-vin: Match sources against ports if specified.

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> If an endpoint source specifies a port number, then it may have multiple entities provided by one DT node. In this event, match against both the DT node and it's relevant port. Signed-off-by: Kieran Bingham <kieran.bin

[PATCH 5/5] arm64: dts: r8a7796: salvator-x: enable VIN, CSI and ADV7482

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Provide bindings between the VIN, CSI and the ADV7482 on the r8a7796. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 129 +

[PATCH 1/5] v4l2-subdev: Provide a port mapping for asynchronous subdevs

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Devices such as the the ADV748x support multiple parallel stream routes through a single chip. This leads towards needing to provide multiple distinct entities and subdevs from a single device-tree node. To distinguish these se

[PATCH 0/5] RFC: ADV748x HDMI/Analog video receiver

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> This is an RFC for the Analog Devices ADV748x driver, and follows on from a previous posting by Niklas Söderlund [0] of an earlier incarnation of this driver. This is an early posting of the driver following the release

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Kieran Bingham
Hi Simon, On 26/04/17 08:23, Simon Horman wrote: > Hi Kieran, > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> The rvin_digital_notify_bound() call dereferences the

[PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-25 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> The rvin_digital_notify_bound() call dereferences the subdev->dev pointer to obtain the of_node. On some error paths, this dev node can be set as NULL. The of_node is mapped into the subdevice structure on initialis

Re: [PATCH 2/2] rcar-vin: group: use correct of_node

2017-04-25 Thread Kieran Bingham
Hi Niklas, On 25/04/17 15:30, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your patch. > > On 2017-04-24 19:14:26 +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> The unbind function dere

Re: [git:media_tree/master] [media] uvcvideo: Don't record timespec_sub

2017-04-25 Thread Kieran Bingham
timespec_sub" I don't believe we are 'recording' timespec_sub. I suspect it is too late to fix now. -- Regards Kieran > Author: Kieran Bingham <kieran.bing...@ideasonboard.com> > Date:Mon Apr 3 08:25:31 2017 -0300 > > The statistics function subtracts two ti

[PATCH 2/2] rcar-vin: group: use correct of_node

2017-04-24 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> The unbind function dereferences the subdev->dev node to obtain the of_node. In error paths, the subdev->dev can be set to NULL, whilst the correct reference to the of_node is available as subdev->of_node. Correct th

[PATCH 1/2] rcar-vin: Verify pads on linkage

2017-04-24 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> The current code determines the pad from the identifiers in the DTB. This is accepted without bounds in the driver. Invalid port/reg addresses defined in the DTB will cause a kernel panic when dereferencing non-existin

[PATCH] uvcvideo: don't recode timespec_sub

2017-04-03 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> The statistics function subtracts two timespecs manually. A helper is provided by the kernel to do this. Replace the implementation, using the helper. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- drive

[PATCH] uvcvideo: Fix empty packet statistic

2017-04-03 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> The frame counters are inadvertently counting packets with content as empty. Fix it by correcting the logic expression Fixes: 7bc5edb00bbd [media] uvcvideo: Extract video stream statistics Signed-off-by: Kieran Bingham <ki

Re: [PATCH 1/4] v4l: vsp1: Implement partition algorithm restrictions

2017-03-06 Thread Kieran Bingham
Hi Laurent, Morimoto-san, On 06/03/17 15:16, Laurent Pinchart wrote: > Hi Morimoto-san, > > On Monday 06 Mar 2017 06:17:47 Kuninori Morimoto wrote: >> Hi Laurent, Kieran >> I asked it to HW team. Please wait >> >> I'm still waiting from HW team's response, but can you check >>

Re: [PATCH v3 2/3] v4l: vsp1: Extend VSP1 module API to allow DRM callbacks

2017-03-05 Thread Kieran Bingham
Hi Laurent, On 05/03/17 21:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Sunday 05 Mar 2017 16:00:03 Kieran Bingham wrote: >> To be able to perform page flips in DRM without flicker we need to be >> able to notify the rcar-du module whe

[PATCH v3 2/3] v4l: vsp1: Extend VSP1 module API to allow DRM callbacks

2017-03-05 Thread Kieran Bingham
to be registered within the VSP DRM interface. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 17 + drivers/media/platform/vsp1/vsp1_drm.h | 11 +++ include/media/vsp1.h

[PATCH v3 0/3] RCAR-DU, VSP1: Prevent pre-emptive frame flips on VSP1-DRM pipelines

2017-03-05 Thread Kieran Bingham
seconds in 100uS increments for periods of 5 seconds on each delay test. These tests have successfully run for 3 hours. Manual start/stop testing has also been performed. Kieran Bingham (3): v4l: vsp1: Postpone frame end handling in event of display list race v4l: vsp1: Extend VSP1 module API

[PATCH v3 1/3] v4l: vsp1: Postpone frame end handling in event of display list race

2017-03-05 Thread Kieran Bingham
to the user. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 19 +-- drivers/media/platform/vsp1/vsp1_dl.h | 2 +- drivers/media/platform/vsp1/vsp1_pipe.c | 13 - 3 files changed, 30 inse

<    1   2   3   4   5   6   7   8   >