Hi Sakari,
On 19-10-23 13:57, Sakari Ailus wrote:
> Hi Marco,
>
> Apologies for the delay.
No problem.
> On Wed, Oct 02, 2019 at 10:07:35AM +0200, Marco Felsch wrote:
> > Hi Sakari,
> >
> > On 19-10-02 10:03, Sakari Ailus wrote:
> > > Hi Marco,
> >
Hi Sakari,
gentle ping.
On 19-10-02 10:07, Marco Felsch wrote:
> Hi Sakari,
>
> On 19-10-02 10:03, Sakari Ailus wrote:
> > Hi Marco,
> >
> > On Fri, Aug 30, 2019 at 12:16:35PM +0200, Marco Felsch wrote:
> > > The patch adds the initial connector parsing code
Hi Sakari,
On 19-10-02 10:03, Sakari Ailus wrote:
> Hi Marco,
>
> On Fri, Aug 30, 2019 at 12:16:35PM +0200, Marco Felsch wrote:
> > The patch adds the initial connector parsing code, so we can move from a
> > driver specific parsing code to a generic one. Currently only t
AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Changelog:
v7:
Hi Rob,
I droped your r b tag because I changed the
decoded video streams if the tvp5150 gets powered on before
the video signal is present.
Limit the supported sdtv standards according to the actual selected
connector to avoid a misconfiguration.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v11:
- address 80
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 69697c00dbd7..dda9f0a2995f 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
Since we expose the definition to the dt-bindings we need to keep those
definitions in sync. To address this the patch adds a simple cross
reference to the dt-bindings.
Signed-off-by: Marco Felsch
---
Changelog:
v11:
- new patch since the split https://patchwork.linuxtv.org/patch/58491/
v2-v10
ile handle or
driver state) which will be set/returned.
The selection rectangle is updated if the format is FORMAT_ACTIVE and
the rectangle position and/or size differs from the current set
rectangle.
Signed-off-by: Marco Felsch
---
Changelog:
v11:
- s/__tvp5150_get_pad_crop/tvp51
e PAL format.
This patch adds the capability to describe such limitation within the
firmware. There are no format restrictions if the property isn't
present, so it's completely backward compatible.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
[1] https://patchwork.kernel.org
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Si
Change this by brinting the register values hex formatted and the states
as more readable string.
Signed-off-by: Marco Felsch
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/tvp5150.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/dr
stored within a union, since only one of them
can be available at the time. Since this is the initial support the
patch adds only the analog-connector specific ones.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v10:
- drop unused V4L2_CONN_HDMI support
v8
-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v10:
- drop V4L2_CONN_HDMI support
- adapt pr_err msg to reflect new state (-> connector is unkown)
v9:
- Fix leading semicolon found by kbuild semicolon.cocci
v8:
- V4L2_CON_* -> V4L2_CONN_*
- tvnorms -> sdtv-
Document the optional binding to limit the possible sdtv standards on the
input connectors.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
v8:
- adapt to new sdtv-standards
- adapt commit message
- fix missing include within example code
---
.../devicetree/bindings/media/i2c/tvp5150.txt
his.
Signed-off-by: Marco Felsch
---
v10:
- new patch
---
drivers/media/i2c/tvp5150.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index d8325b6dbaee..3de935036a4e 100644
--- a/driv
0: add HW input connectors support"
Marco Felsch (13):
dt-bindings: connector: analog: add sdtv standards property
media: v4l: link dt-bindings and uapi
media: v4l2-fwnode: add v4l2_fwnode_connector
media: v4l2-fwnode: add initial connector parsing support
media: tvp5150: add input sourc
Use underlines to highlight optional and required properties. This is
quite common for all bindings. Align descriptions and start sentence
with uppercase letter. Also reword the usage of the required
endpoint properties for the output port in case BT.656 should be used.
Signed-off-by: Marco
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
[1] https://patchwork.kernel.org/cover/10794703/
[2] https://patchwork.kernel.org/cover/10786553/
v11:
- add local struct
Hi Hans,
since you review contained many checkpatch issues I wanna ask if it okay
to keep this line as it before I will send a v11. Please check my inline
comment.
On 19-08-30 12:16, Marco Felsch wrote:
> Currently a local copy of sel->r is made and adapted to the hardware
> constrain
Hi Hans,
On 19-09-27 10:54, Hans Verkuil wrote:
> On 8/30/19 12:16 PM, Marco Felsch wrote:
> > This patch adds the of_graph support to describe the tvp input connections.
> > Physical the TVP5150 has three ports: AIP1A, AIP1B and YOUT. As result
> > of discussion [1],[2]
Hi Hans,
On 19-09-27 10:52, Hans Verkuil wrote:
> Hi Marco,
>
> On 8/30/19 12:16 PM, Marco Felsch wrote:
> > The tvp5150 accepts NTSC(M,J,4.43), PAL (B,D,G,H,I,M,N) and SECAM video
> > data and is able to auto-detect the input signal. The auto-detection
> > does not
Hi Hans,
On 19-09-27 11:01, Hans Verkuil wrote:
> On 8/30/19 12:16 PM, Marco Felsch wrote:
> > Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops")
> > the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is
> > no w
Hi Hans,
On 19-09-27 11:09, Hans Verkuil wrote:
> Hi Marco,
>
> On 8/30/19 12:16 PM, Marco Felsch wrote:
> > Some connectors no matter if in- or output supports only a limited
> > range of sdtv standards. It doesn't matter if the hardware behind that
> > connect
n the driver. This gets addressed by Patch ("media: tvp5150:
fix set_selection rectangle handling").
Regards,
Marco
[1] https://www.spinics.net/lists/linux-media/msg156237.html
Javier Martinez Canillas (1):
partial revert of "[media] tvp5150: add HW input connectors suppor
decoded video streams if the tvp5150 gets powered on before
the video signal is present.
Limit the supported sdtv standards according to the actual selected
connector to avoid a misconfiguration.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v8:
- adapt commit
Change this by brinting the register values hex formatted and the states
as more readable string.
Signed-off-by: Marco Felsch
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/tvp5150.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/dr
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v10:
- drop V4L2_CONN_HDMI support
- adapt pr_err msg to reflect new state (-> connector is unkown)
v9:
- Fix leading semicolon found by kbuild semicolon.cocci
v8:
- V4L2_CON_* -> V4L2_CONN_*
- tvnorms -> sdtv-
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 636e8737ac44..dc8272d3a445 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
stored within a union, since only one of them
can be available at the time. Since this is the initial support the
patch adds only the analog-connector specific ones.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v10:
- drop unused V4L2_CONN_HDMI support
v8
Document the optional binding to limit the possible sdtv standards on the
input connectors.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
v8:
- adapt to new sdtv-standards
- adapt commit message
- fix missing include within example code
.../devicetree/bindings/media/i2c/tvp5150.txt
ile handle or
driver state) which will be set/returned.
The selection rectangle is updated if the format is FORMAT_ACTIVE and
the rectangle position and/or size differs from the current set
rectangle.
Signed-off-by: Marco Felsch
---
Changelog:
v10:
- __tvp5150_get_pad_crop: drop confusing fall-thr
Use underlines to highlight optional and required properties. This is
quite common for all bindings. Align descriptions and start sentence
with uppercase letter. Also reword the usage of the required
endpoint properties for the output port in case BT.656 should be used.
Signed-off-by: Marco
active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
[1] https://patchwork.kernel.org/cover/10794703/
[2] https://patchwork.kernel.org/cover/10786553/
v8:
- fix rebasing issue
AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Changelog:
v7:
Hi Rob,
I droped your r b tag because I changed the
e PAL format.
This patch adds the capability to describe such limitation within the
firmware. There are no format restrictions if the property isn't
present, so it's completely backward compatible.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
[1] https://patchwork.kernel.org
his.
Signed-off-by: Marco Felsch
---
v10:
- new patch
drivers/media/i2c/tvp5150.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 477a929d4f89..c1542a89e8c8 100644
--- a/drivers/me
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Si
On 19-08-29 11:56, Hans Verkuil wrote:
> On 8/22/19 10:05 AM, Marco Felsch wrote:
> > Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops")
> > the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is
> > no way to t
On 19-08-29 12:02, Hans Verkuil wrote:
> On 8/22/19 10:05 AM, Marco Felsch wrote:
> > Some connectors no matter if in- or output supports only a limited
> > range of sdtv standards. It doesn't matter if the hardware behind that
> > connector supports more than the list
On 19-08-29 11:59, Hans Verkuil wrote:
> On 8/22/19 10:05 AM, Marco Felsch wrote:
> > Currently every driver needs to parse the connector endpoints by it self.
> > This is the initial work to make this generic. A generic connector has
> > common members and connector specifi
decoded video streams if the tvp5150 gets powered on before
the video signal is present.
Limit the supported sdtv standards according to the actual selected
connector to avoid a misconfiguration.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v8:
- adapt commit
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
[1] https://patchwork.kernel.org/cover/10794703/
[2] https://patchwork.kernel.org/cover/10786553/
v8:
- fix rebasing issue
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 62a1c7c3a7c0..c74410684675 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Si
r Martinez Canillas (1):
partial revert of "[media] tvp5150: add HW input connectors support"
Marco Felsch (11):
dt-bindings: connector: analog: add sdtv standards property
media: v4l2-fwnode: add v4l2_fwnode_connector
media: v4l2-fwnode: add initial connector parsing support
media
stored within a union, since only one of them
can be available at the time. Since this is the initial support the
patch adds only the analog-connector specific ones.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v8:
- rename CON -> CONN
- supported_tvnorms_s
Change this by brinting the register values hex formatted and the states
as more readable string.
Signed-off-by: Marco Felsch
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/tvp5150.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/dr
Document the optional binding to limit the possible sdtv standards on the
input connectors.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
v8:
- adapt to new sdtv-standards
- adapt commit message
- fix missing include within example code
---
.../devicetree/bindings/media/i2c/tvp5150.txt
AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Changelog:
v7:
Hi Rob,
I droped your r b tag because I changed the
-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v9:
- Fix leading semicolon found by kbuild semicolon.cocci
v8:
- V4L2_CON_* -> V4L2_CONN_*
- tvnorms -> sdtv-standards
- adapt to new v4l2_fwnode_connector_analog member
- return error in case of V4L2_CONN_HDMI
v7:
@
Use underlines to highlight optional and required properties. This is
quite common for all bindings. Align descriptions and start sentence
with uppercase letter. Also reword the usage of the required
endpoint properties for the output port in case BT.656 should be used.
Signed-off-by: Marco
ile handle or
driver state) which will be set/returned.
The selection rectangle is updated if the format is FORMAT_ACTIVE and
the rectangle position and/or size differs from the current set
rectangle.
Signed-off-by: Marco Felsch
---
Changelog:
v8:
- adapt commit message
- remove wrong FOR
e PAL format.
This patch adds the capability to describe such limitation within the
firmware. There are no format restrictions if the property isn't
present, so it's completely backward compatible.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v8:
Hi Rob,
AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Changelog:
v7:
Hi Rob,
I droped your r b tag because I changed the
on my v7. I've tested the
code on a custom embedded device and compile tested it using our 0day
instance.
Regards,
Marco
Javier Martinez Canillas (1):
partial revert of "[media] tvp5150: add HW input connectors support"
Marco Felsch (11):
dt-bindings: connector: analog: add
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
stored within a union, since only one of them
can be available at the time. Since this is the initial support the
patch adds only the analog-connector specific ones.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v8:
- rename CON -> CONN
- supported_tvnorms_s
-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v8:
- V4L2_CON_* -> V4L2_CONN_*
- tvnorms -> sdtv-standards
- adapt to new v4l2_fwnode_connector_analog member
- return error in case of V4L2_CONN_HDMI
v7:
@Jacopo: I dropped your r b tag becuase of the amount of cha
e PAL format.
This patch adds the capability to describe such limitation within the
firmware. There are no format restrictions if the property isn't
present, so it's completely backward compatible.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v8:
Hi Rob,
Change this by brinting the register values hex formatted and the states
as more readable string.
Signed-off-by: Marco Felsch
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/tvp5150.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/dr
Use underlines to highlight optional and required properties. This is
quite common for all bindings. Align descriptions and start sentence
with uppercase letter. Also reword the usage of the required
endpoint properties for the output port in case BT.656 should be used.
Signed-off-by: Marco
ile handle or
driver state) which will be set/returned.
The selection rectangle is updated if the format is FORMAT_ACTIVE and
the rectangle position and/or size differs from the current set
rectangle.
Signed-off-by: Marco Felsch
---
Changelog:
v8:
- adapt commit message
- remove wrong FOR
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 62a1c7c3a7c0..c74410684675 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
decoded video streams if the tvp5150 gets powered on before
the video signal is present.
Limit the supported sdtv standards according to the actual selected
connector to avoid a misconfiguration.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v8:
- adapt commit
Document the optional binding to limit the possible sdtv standards on the
input connectors.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
v8:
- adapt to new sdtv-standards
- adapt commit message
- fix missing include within example code
.../devicetree/bindings/media/i2c/tvp5150.txt
active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
[1] https://patchwork.kernel.org/cover/10794703/
[2] https://patchwork.kernel.org/cover/10786553/
v8:
- fix rebasing issue
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Si
Hi Sakari,
gentle ping.
Regards,
Marco
On 19-07-29 12:40, Marco Felsch wrote:
> Hi Sakari,
>
> On 19-06-25 15:27, Sakari Ailus wrote:
> > Hi Marco,
> >
> > Thanks for the set.
> >
> > Looks quite good to me in general; a few minor comments bel
On 19-08-16 13:27, Hans Verkuil wrote:
> On 8/15/19 1:57 PM, Marco Felsch wrote:
> > Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops")
> > the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is
> > no way to t
On 19-08-16 12:59, Hans Verkuil wrote:
> On 8/15/19 1:57 PM, Marco Felsch wrote:
> > Currently every driver needs to parse the connector endpoints by it self.
> > This is the initial work to make this generic. A generic connector has
> > common members and connector specifi
On 19-08-19 10:39, Hans Verkuil wrote:
> On 8/19/19 10:09 AM, Marco Felsch wrote:
> > Hi Hans,
> >
> > On 19-08-16 13:11, Hans Verkuil wrote:
> >> On 8/15/19 1:57 PM, Marco Felsch wrote:
> >>> Some connectors no matter if in- or output supports only a l
Hi,
On 19-08-19 10:09, Marco Felsch wrote:
> Hi Hans,
>
> On 19-08-16 13:11, Hans Verkuil wrote:
> > On 8/15/19 1:57 PM, Marco Felsch wrote:
> > > Some connectors no matter if in- or output supports only a limited
> > > range of tv norms. It doesn
Hi Hans,
On 19-08-16 13:11, Hans Verkuil wrote:
> On 8/15/19 1:57 PM, Marco Felsch wrote:
> > Some connectors no matter if in- or output supports only a limited
> > range of tv norms. It doesn't matter if the hardware behind that
> > connector supports more than the list
() callback ensures that only one
> connector is active.
>
> [1] https://www.spinics.net/lists/linux-media/msg138545.html
> [2] https://www.spinics.net/lists/linux-media/msg138546.html
>
> Signed-off-by: Marco Felsch
>
> ---
> Changelog:
>
> [1]
Hi Laurent,
On 19-08-15 16:10, Laurent Pinchart wrote:
> Hi Marco,
>
> On Thu, Aug 15, 2019 at 03:04:37PM +0200, Marco Felsch wrote:
> > On 19-08-15 15:38, Laurent Pinchart wrote:
> > > On Fri, Aug 09, 2019 at 09:55:36AM +0200, Marco Felsch wrote:
> > >> On 19
Hi Laurent,
On 19-08-15 16:02, Laurent Pinchart wrote:
> Hi Marco,
>
> On Thu, Aug 15, 2019 at 02:50:02PM +0200, Marco Felsch wrote:
> > On 19-08-15 15:33, Laurent Pinchart wrote:
> > > On Fri, Aug 09, 2019 at 07:58:09AM +0200, Marco Felsch wrote:
> > >> On 19
Hi Laurent,
On 19-08-15 15:53, Laurent Pinchart wrote:
> Hi Marco,
>
> On Tue, Aug 13, 2019 at 11:10:30AM +0200, Marco Felsch wrote:
> > On 19-05-16 21:07, Laurent Pinchart wrote:
> > > On Mon, Apr 15, 2019 at 02:44:12PM +0200, Marco Felsch wrote:
> > > > The
Hi Laurent,
On 19-08-15 15:51, Laurent Pinchart wrote:
> On Tue, Aug 13, 2019 at 10:54:29AM +0200, Marco Felsch wrote:
> > Hi Laurent,
> >
> > On 19-05-16 21:03, Laurent Pinchart wrote:
> > > Hello Marco,
> > >
> > > Thank you for the patch.
>
Hi Laurent,
On 19-08-15 15:48, Laurent Pinchart wrote:
> Hi Marco,
>
> On Fri, Aug 09, 2019 at 02:16:06PM +0200, Marco Felsch wrote:
> > On 19-05-16 19:51, Laurent Pinchart wrote:
> > > On Tue, May 14, 2019 at 03:20:04PM -0300, Mauro Carvalho Chehab wrote:
> >
Hi Laurent,
On 19-08-15 15:38, Laurent Pinchart wrote:
> Hi Marco,
>
> On Fri, Aug 09, 2019 at 09:55:36AM +0200, Marco Felsch wrote:
> > On 19-05-16 19:36, Laurent Pinchart wrote:
> > > On Mon, Apr 15, 2019 at 02:44:02PM +0200, Marco Felsch wrote:
> > > > C
On 19-08-15 15:33, Laurent Pinchart wrote:
> Hi Marco,
>
> On Fri, Aug 09, 2019 at 07:58:09AM +0200, Marco Felsch wrote:
> > On 19-05-16 19:27, Laurent Pinchart wrote:
> > > On Mon, Apr 15, 2019 at 02:44:01PM +0200, Marco Felsch wrote:
> > > > Some connectors
Change this by brinting the register values hex formatted and the states
as more readable string.
Signed-off-by: Marco Felsch
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/tvp5150.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/dr
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index ad59e65e6771..26a156da3ab4 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
Document the optional binding to limit the possible tv-norms on the
input connectors.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings/media/i2c/tvp5150.txt | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings
ile handle or
driver state) which will be set/returned.
The TVP5150 AVID will be updated if the 'which' field is FORMAT_ACTIVE
and the requested selection rectangle differs from the already set one.
Signed-off-by: Marco Felsch
---
Changelog:
v7:
- __tvp5150_get_pad_crop(): return er
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Si
ormat.
This patch adds the capability to describe such limitation within the
firmware. There are no format restrictions if the property isn't
present, so it's completely backward compatible.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
[1] https://patchwork.kernel.org/cover/1
o review and maintain
Each changed patch contains a more detailed changelog.
Hopefully we get this series done :)
Regards,
Marco
Javier Martinez Canillas (1):
partial revert of "[media] tvp5150: add HW input connectors support"
Marco Felsch (11):
dt-bindings: connector: an
AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
---
Changelog:
v7:
Hi Rob,
I droped your r b tag because I changed the bindings in this
patch
-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v7:
@Jacopo: I dropped your r b tag becuase of the amount of changes I
made..
- drop unnecessary comments
- fix commet style
- s/v4l2_fwnode_connector_conv.name/v4l2_fwnode_connector_conv.compatible/
- make label size variable
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
stored within a union, since only one of them
can be available at the time. Since this is the initial support the
patch adds only the analog-connector specific ones.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v7:
- fix spelling issues
- constify label
active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
[1] https://patchwork.kernel.org/cover/10794703/
[2] https://patchwork.kernel.org/cover/10786553/
v7:
- don't init
decoded video streams if the tvp5150 gets powered on before
the video signal is present.
Limit the supported tv norms according to the actual selected connector
to avoid a misconfiguration.
Signed-off-by: Marco Felsch
---
[1] https://patchwork.kernel.org/cover/10794703/
v5:
- probe() initialize
Use underlines to highlight optional and required properties. This is
quite common for all bindings. Align descriptions and start sentence
with uppercase letter. Also reword the usage of the required
endpoint properties for the output port in case BT.656 should be used.
Signed-off-by: Marco
Hi Laurent,
On 19-05-16 21:07, Laurent Pinchart wrote:
> Hi Marco,
>
> Thank you for the patch.
>
> On Mon, Apr 15, 2019 at 02:44:12PM +0200, Marco Felsch wrote:
> > The tvp5150 accepts NTSC(M,J,4.43), PAL (B,D,G,H,I,M,N) and SECAM video
> > data and is able to auto-d
Hi Laurent,
On 19-05-16 21:05, Laurent Pinchart wrote:
> Hi Marco,
>
> Thank you for the patch.
>
> On Mon, Apr 15, 2019 at 02:44:06PM +0200, Marco Felsch wrote:
> > The TVP5150/1 decoders support different video input sources to their
> > AIP1A/B pins.
> >
&
1 - 100 of 294 matches
Mail list logo
